Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Rob Braden commented on PUP-9750 Re: optionally add pe_version to server_facts The final name is pe_serverversion Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.156036703.11103.1580752740135%40Atlassian.JIRA.
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Rob Braden updated an issue Puppet / PUP-9750 optionally add pe_version to server_facts Change By: Rob Braden Release Notes: Enhancement Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.156036703.11099.1580752680615%40Atlassian.JIRA.
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-9750
optionally add pe_version to server_facts
Change By:
Josh Cooper
Members of the Puppet Community have requested a standardized best practice to determine if a Puppet Agent is a PE or FOSS Puppet Agent. Since Puppet 4.x, there is no concept of a PE or FOSS Puppet Agent, but a Puppet Agent can be served a catalog by a PE or FOSS Puppet Server.A non-empty {{pe_version}} fact would both differentiate between PE or FOSS, but would allow for conditional code depending upon the specific version of PE.The {{pe_version}} fact is available in Puppet / PE 3.x.The {{pe_compiling_server_version}} function (which calls {{pe_server_version}}) is available on a PE Puppet Server after PE 3.x, but is not available on a FOSS Puppet Server, requiring the use of the {{is_function_available} } function to avoid generating an error when calling {{pe_compiling_server_version}} function on a FOSS Puppet Server.The {{is_function_available}} function is itself now deprecated.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9750 optionally add pe_version to server_facts Change By: Josh Cooper Sprint: Coremunity Hopper Community PRs Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.156036703.12120.1572416700802%40Atlassian.JIRA.
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9750 optionally add pe_version to server_facts Change By: Josh Cooper Sprint: Coremunity Hopper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.156036703.12112.1572416400166%40Atlassian.JIRA.
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Thomas Kishel commented on PUP-9750 Re: optionally add pe_version to server_facts Switched to `peserverversion` to match the other keys in server_facts, which do not use underscores. Reverting would be a trivial search and replace. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.156036703.70621.1566577200136%40Atlassian.JIRA.
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-9750 optionally add pe_version to server_facts Change By: Jorie Tappa Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.156036703.49487.1560790201439%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Thomas Kishel commented on PUP-9750 Re: optionally add pe_version to server_facts See also: https://puppet.com/docs/puppet/latest/lang_facts_and_builtin_vars.html#serverfacts-variable `serverversion` is the current version of Puppet on the Puppet master, so maybe server_facts['pe_version' should be server_facts['peserverversion` ? That would avoid a collision with the PE fact or function names, and the fact names in the puppetlabs-stdlib module. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.156036703.48292.1560551760171%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title
Thomas Kishel commented on PUP-9750
Re: optionally add pe_version to server_facts
This sets server_facts['pe_version'] which sets/overrides the pe_version fact ... but only in the catalog compiled by the server:
[root@pe-201818-master ~]# cat /etc/puppetlabs/code/environments/production/manifests/site.pp
node default {
$gpev = get_pe_version()
if $gpev { notify { "PE Version ${gpev} | ${server_facts['pe_version']} | ${pe_version}": } }
}
[root@pe-201818-agent ~]# puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title Thomas Kishel commented on PUP-9750 Re: optionally add pe_version to server_facts If this PR is approved (and added to Puppet 7) then we could add this function to puppetlabs-stdlib ... # This needs to be a function rather than updating the 3.x `pe_version` fact. # # In Puppet 3.x, PE is a property of the agent. # In Puppet 4.x and newer, PE is a property of the compiling master. # In Puppet 4.x to 6.x, inspect the `pe_version` file on the compiling master. # In Puppet 7.x and newer, inspect server_facts['pe_version']. Puppet::Functions.create_function(:get_pe_version) do def get_pe_version scope = closure_scope facts = scope['facts'] if Puppet::Util::Package.versioncmp(facts['puppetversion'], '3.9.9') < 0
Jira (PUP-9750) optionally add pe_version to server_facts
Title: Message Title
Thomas Kishel created an issue
Puppet / PUP-9750
optionally add pe_version to server_facts
Issue Type:
Improvement
Assignee:
Unassigned
Created:
2019/06/12 12:17 PM
Priority:
Normal
Reporter:
Thomas Kishel
Members of the Puppet Community have requested a standardized best practice to determine if a Puppet Agent is a PE or FOSS Puppet Agent. Since Puppet 4.x, there is no concept of a PE or FOSS Puppet Agent, but a Puppet Agent can be served a catalog by a PE or FOSS Puppet Server. A non-empty pe_version fact would both differentiate between PE or FOSS, but would allow for conditional code depending upon the specific version of PE. The pe_version fact is available in Puppet / PE 3.x. The pe_compiling_server_version function (which calls pe_server_version) is available on a PE Puppet Server after PE 3.x, but is not available on a FOSS Puppet Server, requiring the use of the is_function_available} function to avoid generating an error when calling {{pe_compiling_server_version function on a FOSS Puppet Server. The is_function_available function is itself now deprecated.
Add Comment
