[issue29802] A possible null-pointer dereference in struct.s_unpack_internal()

[Artem Smotrakov]

Changes by Artem Smotrakov :


--
keywords: +patch
Added file: http://bugs.python.org/file46723/_struct_cache.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29802] A possible null-pointer dereference in struct.s_unpack_internal()

[Artem Smotrakov]

New submission from Artem Smotrakov:

Attached struct_unpack_crash.py results to a null-pointer dereference in 
s_unpack_internal() function of _struct module:

ASAN:SIGSEGV
=
==20245==ERROR: AddressSanitizer: SEGV on unknown address 0x (pc 
0x7facd2cea83a bp 0x sp 0x7ffd0250f860 T0)
   #0 0x7facd2cea839 in s_unpack_internal 
/home/artem/projects/python/src/cpython-asan/Modules/_struct.c:1515
   #1 0x7facd2ceab69 in Struct_unpack_impl 
/home/artem/projects/python/src/cpython-asan/Modules/_struct.c:1570
   #2 0x7facd2ceab69 in unpack_impl 
/home/artem/projects/python/src/cpython-asan/Modules/_struct.c:2192
   #3 0x7facd2ceab69 in unpack 
/home/artem/projects/python/src/cpython-asan/Modules/clinic/_struct.c.h:215
   #4 0x474397 in _PyMethodDef_RawFastCallKeywords Objects/call.c:618
   #5 0x474397 in _PyCFunction_FastCallKeywords Objects/call.c:690
   #6 0x42685f in call_function Python/ceval.c:4817
   #7 0x42685f in _PyEval_EvalFrameDefault Python/ceval.c:3298
   #8 0x54b164 in PyEval_EvalFrameEx Python/ceval.c:663
   #9 0x54b164 in _PyEval_EvalCodeWithName Python/ceval.c:4173
   #10 0x54b252 in PyEval_EvalCodeEx Python/ceval.c:4200
   #11 0x54b252 in PyEval_EvalCode Python/ceval.c:640
   #12 0x431e0e in run_mod Python/pythonrun.c:976
   #13 0x431e0e in PyRun_FileExFlags Python/pythonrun.c:929
   #14 0x43203b in PyRun_SimpleFileExFlags Python/pythonrun.c:392
   #15 0x446354 in run_file Modules/main.c:338
   #16 0x446354 in Py_Main Modules/main.c:809
   #17 0x41df71 in main Programs/python.c:69
   #18 0x7facd58ac82f in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
   #19 0x428728 in _start 
(/home/artem/projects/python/build/cpython-asan/bin/python3.7+0x428728)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV 
/home/artem/projects/python/src/cpython-asan/Modules/_struct.c:1515 
s_unpack_internal
==20245==ABORTING


Looks like _struct implementation assumes that PyStructObject->s_codes cannot 
be null,
but it may happen if a bytearray was passed to unpack().
PyStructObject->s_codes becomes null in a couple of places in _struct.c, but 
that's not the case.
unpack() calls _PyArg_ParseStack() with cache_struct_converter() which 
maintains a cache.
Even if unpack() was called incorrectly with a string as second parameter (see 
below), this value is going to be cached anyway.
Next time, if the same format string is used, the value is going to be 
retrieved from the cache.
But PyStructObject->s_codes is still not null in cache_struct_converter() 
function.
If you watch "s_object" under gdb, you can see that "s_codes" becomes null here:

PyBuffer_FillInfo (view=0x7fffd700, obj=obj@entry=0x77e50730,
buf=0x8df478 <_PyByteArray_empty_string>, len=0, readonly=readonly@entry=0,
flags=0) at Objects/abstract.c:647
647 view->format = NULL;
(gdb) bt
#0  PyBuffer_FillInfo (view=0x7fffd700, obj=obj@entry=0x77e50730,
buf=0x8df478 <_PyByteArray_empty_string>, len=0, readonly=readonly@entry=0,
flags=0) at Objects/abstract.c:647
#1  0x0046020c in bytearray_getbuffer (obj=0x77e50730,
view=, flags=) at Objects/bytearrayobject.c:72
#2  0x00560b0a in getbuffer (errmsg=,
view=0x7fffd700, arg=0x77e50730) at Python/getargs.c:1380
#3  convertsimple (freelist=0x7fffd3b0, bufsize=256,
msgbuf=0x7fffd4c0 "must be bytes-like object, not str", flags=2,
p_va=0x0, p_format=, arg=0x77e50730)
at Python/getargs.c:938
#4  convertitem (arg=0x77e50730, p_format=p_format@entry=0x7fffd3a8,
p_va=p_va@entry=0x7fffd610, flags=flags@entry=2,
levels=levels@entry=0x7fffd3c0,
msgbuf=msgbuf@entry=0x7fffd4c0 "must be bytes-like object, not str",
bufsize=256, freelist=0x7fffd3b0) at Python/getargs.c:596
#5  0x00561d6f in vgetargs1_impl (compat_args=compat_args@entry=0x0,
stack=stack@entry=0x6164b520, nargs=2,
format=format@entry=0x735d5c88 "O*:unpack",
p_va=p_va@entry=0x7fffd610, flags=flags@entry=2) at Python/getargs.c:388
#6  0x005639b0 in _PyArg_ParseStack_SizeT (
args=args@entry=0x6164b520, nargs=,
format=format@entry=0x735d5c88 "O*:unpack") at Python/getargs.c:163
#7  0x735d2df8 in unpack (module=module@entry=0x77e523b8,
args=args@entry=0x6164b520, nargs=,
kwnames=kwnames@entry=0x0)
at 
/home/artem/projects/python/src/cpython-asan/Modules/clinic/_struct.c.h:207
#8  0x00474398 in _PyMethodDef_RawFastCallKeywords (kwnames=0x0,
nargs=140737352377272, args=0x6164b520, self=0x77e523b8,
method=0x737d94e0 ) at Objects/call.c:618
#9  _PyCFunction_FastCallKeywords (func=func@entry=0x77e53828,
args=args@entry=0x6164b520, nargs=nargs@entry=2,
kwnames=kwnames@entry=0x0) at Objects/call.c:690
#10 0x00426860 in call_function (kwnames=0x0, 

[issue29715] Arparse improperly handles "-_"

[paul j3]

paul j3 added the comment:

http://bugs.python.org/issue9334, 'argparse does not accept options taking 
arguments beginning with dash (regression from optparse)'

is an old discussion about strings that begin with a dash and don't 
match defined flags.

One proposal was to add a 'args_default_to_positional' parameter, and change 
the parsing that I described before to:

+# behave more like optparse even if the argument looks like a option
+if self.args_default_to_positional:
+return None
 # instead of return None, arg_string, None

There's a long discussion but nothing was changed (not even the test for 
negative numbers).

Two work arounds still apply

prog.py -- -_   # use -- to signal positional values
prog.py --first=-_  # = to attach any string to optional


(in my previous post I cited 'Bernard', I meant the module's original author, 
Steven Bethard.  He's no longer actively involved in these bug/issues.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29798] Handle "git worktree" in "make patchcheck"

[Nick Coghlan]

Nick Coghlan added the comment:

Turns out I missed another isdir() check in get_base_branch(), so this still 
isn't working properly in git worktree directories.

--
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17560] problem using multiprocessing with really big objects?

[artxyz]

artxyz added the comment:

@davin Thanks for your answer! I will update to the current version.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29795] Clarify how to share multiprocessing primitives

[Davin Potts]

Changes by Davin Potts :


--
resolution:  -> works for me
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17560] problem using multiprocessing with really big objects?

[Davin Potts]

Davin Potts added the comment:

@artxyz: The current release of 2.7 is 2.7.13 -- if you are still using 2.7.5 
you might consider updating to the latest release.

As pointed out in the text of the issue, the multiprocessing pickler has been 
made pluggable in 3.3 and it's been made more conveniently so in 3.6.  The 
issue reported here arises from the constraints of working with large objects 
and pickle, hence the enhanced ability to take control of the multiprocessing 
pickler in 3.x applies.

I'll assign this issue to myself as a reminder to create a blog post around 
this example and potentially include it as a motivating need for controlling 
the multiprocessing pickler in the documentation.

--
assignee:  -> davin
nosy: +davin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29801] Spam

[Zachary Ware]

Changes by Zachary Ware :


--
nosy:  -SH4Y4N
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed
title: amazing! -> Spam

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29801] amazing!

[Xiang Zhang]

Changes by Xiang Zhang :


--
Removed message: http://bugs.python.org/msg289525

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29688] Add support for Path.absolute()

[INADA Naoki]

INADA Naoki added the comment:

> posixpath.abspath() collapses "//.." to "", this is not 
> correct. Not sure about ntpath.abspath().

I feel this is reasonable limitation, and expected behavior for some cases.
So I think adding note about this in document is enough.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17560] problem using multiprocessing with really big objects?

[artxyz]

artxyz added the comment:

This is still an issue in Python 2.7.5

Will it be fixed?

--
nosy: +artxyz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28685] Optimizing list.sort() by performing safety checks in advance

[Tim Peters]

Tim Peters added the comment:

@ppperry, I believe you're right - good catch!  I expect the current patch 
would treat the NotImplemented return as meaning "the first argument is less 
than the second argument".

I added a comment to the code (on github) suggesting an obvious fix for that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22576] ftplib documentation gives a wrong argument name for storbinary

[Xiang Zhang]

Changes by Xiang Zhang :


--
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22576] ftplib documentation gives a wrong argument name for storbinary

[Xiang Zhang]

Changes by Xiang Zhang :


--
pull_requests: +539

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29795] Clarify how to share multiprocessing primitives

[Max]

Max added the comment:

Actually, never mind, I think one of the paragraphs in the Programming 
Guidelines ("Explicitly pass resources to child processes") basically explains 
everything already. I just didn't notice it until @noxdafox pointed it out to 
me on SO.

Close please.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29715] Arparse improperly handles "-_"

[Max Rothman]

Max Rothman added the comment:

I think that makes sense, but there's still an open question: what should the 
correct way be to allow dashes to be present at the beginning of positional 
arguments?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29756] Improve documentation for list methods that compare items by equality

[Xiang Zhang]

Changes by Xiang Zhang :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28856] %b format for bytes does not support objects that follow the buffer protocol

[Xiang Zhang]

Xiang Zhang added the comment:

What's your opinions Alexander and Ethan?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29756] Improve documentation for list methods that compare items by equality

[Steven D'Aprano]

Steven D'Aprano added the comment:

I'm afraid I don't know what SUT means.

But 3 == 3.0 is the correct and expected behaviour. If you need to 
check that two values are both the same type and the same value, you 
have to validate the type and value separately.

Changing the behaviour of == is ruled out for backwards 
compatability, but perhaps you could suggest a new === operator 
to check type and value. That would require some discussion on 
the Python Ideas mailing list, not just a feature request on the 
tracker.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28685] Optimizing list.sort() by performing safety checks in advance

[ppperry]

ppperry added the comment:

-

Doesn't youre skipping PyObject_RichCompareBool and directly getting
tp_richcompare also mean that you bypass the NotImplemented checking?
Thus, wouldn't this code, which raises a TypeError currently, silently
work?

class PointlessComparator:
def __lt__(self, other):
return NotImplemented
[PointlessComparator(),PointlessComparator()].sort()

... ... ...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
pull_requests: +538

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29688] Add support for Path.absolute()

[Eryk Sun]

Eryk Sun added the comment:

It's the same with ntpath.abspath since the underlying GetFullPathName function 
processes the path only as a string. OK, so it seems we're requiring that 
p.absolute().resolve() is the same as p.resolve().

Consider the following example:

>>> p = Path('C:/symlink/../nul .eggs & spam')
>>> print(p.absolute())
C:\symlink\..\nul .eggs & spam
>>> print(os.path.abspath(p))
\\.\nul

If the current absolute() result is fine, then I think resolve() should return 
\\.\nul, which means it needs to be expanded to handle device-path cases for 
which _getfinalpathname fails. We should be able to handle these cases by 
falling back on _getfullpathname. It's a separate issue, but here are some 
concrete examples that currently cause resolve() to fail. 

GetFinalPathNameByHandle will fail with ERROR_INVALID_FUNCTION or 
ERROR_INVALID_PARAMETER for devices that aren't file systems and thus do not 
support the particular NtQueryInformationFile and NtDeviceIoControlFile 
information classes and IOCTLs that it requests. Also, getting a handle via 
CreateFile can fail with ERROR_INVALID_PARAMETER for devices that require 
either read or write access such as CON. It can also fail with 
ERROR_ACCESS_DENIED for exclusive devices that are already open such as COM1.  

ERROR_ACCESS_DENIED can also be due to the file security denying the right to 
read attributes or synchronize since CreateFile implicitly requests those 
rights. There's also ERROR_SHARING_VIOLATION when trying to open a system 
paging file. These non-device PermissionError cases can be handled the same way 
that resolve() currently handles FileNotFoundError by trying to resolve the 
parent directory.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29730] unoptimal calls to PyNumber_Check

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM. Thank you Oren.

--
assignee:  -> serhiy.storchaka
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29799] Add tests for header API of 'urllib.request.Request' class

[Martin Panter]

New submission from Martin Panter:

I think the RequestTests class really belongs in test_urllib2, which already 
has a RequestHdrsTests class testing these APIs.

BTW test_urllib.py (no 2) is mainly for testing the stuff that came from Python 
2’s “urllib” module, but the Request class is in “urllib2” instead.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29730] unoptimal calls to PyNumber_Check

[Oren Milman]

Oren Milman added the comment:

I am sorry, but I guess I am missing something about startswith() and
endswith().
ISTM that PyTuple_Check() is already called by unicode_startswith,
unicode_endswith and _Py_bytes_tailmatch, which already raise a TypeError
with an appropriate error message
(e.g. "%s first arg must be bytes or a tuple of bytes, not %s").


I searched the codebase, and found that in most places, if PyIndex_Check(obj)
is true, then obj is described as 'integer' in error messages. rarely, obj
would be described as 'int'.
I found only two relevant TypeError messages of functions that accept an
integer type or None (BTW, I took the term 'integer type' from
https://docs.python.org/3.7/reference/atamodel.html?highlight=__index__#object.__index__.):
- in Modules/posixmodule.c in dir_fd_converter():
  PyErr_Format(PyExc_TypeError,
   "argument should be integer or None, not %.200s",
   Py_TYPE(o)->tp_name);
- in Modules/_functoolsmodule.c in lru_cache_new():
  PyErr_SetString(PyExc_TypeError, "maxsize should be integer or None");

so I changed the error messages in my patch to the form of
'argument should be ...' (which is, IMHO, much clearer).


also, now that the new PR was created, should I close the old one?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29730] unoptimal calls to PyNumber_Check

[Oren Milman]

Changes by Oren Milman :


--
pull_requests: +537

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8450] httplib: false BadStatusLine() raised

[Martin Panter]

Martin Panter added the comment:

I don’t think so. It is best to avoid a new exception type (even a subclass) in 
a bug fix. That would break code which checks “type(exc) == BadStatusLine” or 
similar.

Specific exception messages are supposed to be implementation details, and the 
current message is already quirky due to the change from Issue 7427 (released 
in 2.7a4). That is why I thought it might be reasonable to just change the 
exception message in a bug fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29756] Improve documentation for list methods that compare items by equality

[Alexander Todorov]

Alexander Todorov added the comment:

Hi folks,
I have another very similar issue, it could be the same root cause. Let me know 
if it is. 

assert 3 == 3.0  will pass

self.assertEqual(3, 3.0) - will pass

this had the nasty side effect of my test suite not catching a problem with 
SUT. I have updated the test suite to validate the result type as well but want 
to know how to file this use-case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7427] BadStatusLine is hell to debug

[Martin Panter]

Martin Panter added the comment:

This change was only made in 2.7a4, not 2.6

--
versions: +Python 2.7 -Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15082] [httplib] httplib.BadStatusLine on any HTTPS connection in certain unknown cases.

[Martin Panter]

Changes by Martin Panter :


--
resolution:  -> fixed
stage:  -> test needed
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29800] functools.partial segfaults in repr when keywords attribute is abused

[Michael Seifert]

Changes by Michael Seifert :


--
pull_requests: +536

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29800] functools.partial segfaults in repr when keywords attribute is abused

[Michael Seifert]

New submission from Michael Seifert:

It's possible to create a segfault when one (inappropriatly) changes the 
functools.partial.keywords attribute manually. A minimal example reproducing 
the segfault is:

>>> from functools import partial
>>> p = partial(int)
>>> p.keywords[1] = 10
>>> repr(p)

System: Windows 10
Python: 3.5.3, 3.6.0, master-branch

--
components: Library (Lib)
messages: 289510
nosy: MSeifert
priority: normal
severity: normal
status: open
title: functools.partial segfaults in repr when keywords attribute is abused
type: crash
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29742] asyncio get_extra_info() throws exception

[Yury Selivanov]

Changes by Yury Selivanov :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29600] Returning an exception object from a coroutine triggers implicit exception chaining?!?

[Yury Selivanov]

Changes by Yury Selivanov :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29688] Add support for Path.absolute()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

posixpath.abspath() collapses "//.." to "", this is not 
correct. Not sure about ntpath.abspath().

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28685] Optimizing list.sort() by performing safety checks in advance

[Elliot Gorokhovsky]

Elliot Gorokhovsky added the comment:

OK, I added the safety check to unsafe_object_compare. I verified that it
matches the current implementation on all the tests proposed in this thread.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29688] Add support for Path.absolute()

[Brett Cannon]

Brett Cannon added the comment:

"What's the rationale for not calling self._flavour.pathmod.abspath() to 
implement absolute()?" Beats me. :) It's just how Antoine wrote it and that's 
all I know.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Brett Cannon]

Changes by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29730] unoptimal calls to PyNumber_Check

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Please open a PR for review.

Checking PyTuple_Check() is needed if this code is used in startswith() and 
endswith().

"integer argument or None expected" -- I'm not sure this wording is correct 
enough. What wording is used in other similar code? I'm sure there other 
functions that accept int or None.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29742] asyncio get_extra_info() throws exception

[Yury Selivanov]

Changes by Yury Selivanov :


--
pull_requests: +534

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29742] asyncio get_extra_info() throws exception

[Yury Selivanov]

Changes by Yury Selivanov :


--
pull_requests: +535

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29795] Clarify how to share multiprocessing primitives

[Max]

Max added the comment:

Somewhat related is this statement from Programming Guidelines:

> When using the spawn or forkserver start methods many types from 
> multiprocessing need to be picklable so that child processes can use them. 
> However, one should generally avoid sending shared objects to other processes 
> using pipes or queues. Instead you should arrange the program so that a 
> process which needs access to a shared resource created elsewhere can inherit 
> it from an ancestor process.

Since on Windows, even "inheritance" is really the same pickle + pipe executed 
inside CPython, I assume the entire paragraph is intended for UNIX platform 
only (might be worth clarifying, btw).

On Linux, "inheritance" works faster, and can deal with more complex objects 
compared to pickle with pipe/queue -- but it's equally true whether it's 
inheritance through global variables or through arguments to the target 
function. There's no reason 

So the text I proposed earlier wouldn't conflict with this one. It would just 
encourage programmers to use function arguments instead of global variables: 
because it's doesn't matter on Linux but makes the code portable to Windows.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29715] Arparse improperly handles "-_"

[paul j3]

paul j3 added the comment:

I think that this string falls through to the last case in 
'parser._parse_optional' (the first parsing loop)

# it was meant to be an optional but there is no such option
# in this parser (though it might be a valid option in a subparser)
return None, arg_string, None

It has the format of a optional flag, not a positional argument.  If preceded 
by '--' it gets classed as argument.

(In the second, main, parsing loop) Since it doesn't match any defined Actions 
it gets put in the list of 'extras' (as returned by 'parse_known_args').  But 
the parser also runs a check on required arguments, and finds the positional, 
'first', was not filled.  So that's the error that's raised.

For example if I provide another string that fills the positional:

In [5]: parser.parse_known_args(['-_','other'])
Out[5]: (Namespace(first='other'), ['-_'])

'parse_args' would produce a 'error: unrecognized arguments: -_' error.

I don't see how the error message could be improved without some major changes 
in the testing and parsing.  It would either have to disallow unmatched 
optional's flags (and maybe break subparsers) or deduce that this 'extra' was 
meant for the unfilled positional.  Bernard has argued that it is better to 
raise an error in ambiguous cases, than to make too many assumptions about what 
the user intended.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29600] Returning an exception object from a coroutine triggers implicit exception chaining?!?

[Yury Selivanov]

Yury Selivanov added the comment:

What a bizarre bug.  Created a PR with a fix.  

Nathaniel, please put me in a nosy list when you submit issues about 
generators/coroutines.

--
nosy: +yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29600] Returning an exception object from a coroutine triggers implicit exception chaining?!?

[Yury Selivanov]

Changes by Yury Selivanov :


--
pull_requests: +533

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29715] Arparse improperly handles "-_"

[paul j3]

Changes by paul j3 :


--
nosy: +paul.j3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29730] unoptimal calls to PyNumber_Check

[Oren Milman]

Oren Milman added the comment:

"Perhaps some methods need to check also PyTuple_Check()."
which methods?

anyway, a new patch diff file is attached, according to your other seggustions,
Serhiy.
(I ran the test module, and some tests of my own, and it seems that the patch
doesn't break anything.)

--
keywords: +patch
Added file: http://bugs.python.org/file46721/patchVer2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29797] Deadlock with multiprocessing.Queue()

[Tim Peters]

Changes by Tim Peters :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29051] Improve error reporting involving f-strings (PEP 498)

[Claudiu Popa]

Claudiu Popa added the comment:

I'm adding another example here, where the lineno reporting is wrong:

  from ast import parse 
  n = parse('''

  def test():
 return f"{a}"
  ''')
  f = n.body[0].body[0].value.values[0]
  n = f.value
  print("name lineno", n.lineno)

In this example, the line number of the f-string inner variable is 1, while it 
should be 3.
As Mark Shannon said, this bug is affecting tools such as pyflakes and pylint.

--
nosy: +Claudiu.Popa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29723] 3.6.1rc1 adds the current directory to sys.path when running a subdirectory's __main__.py; previous versions did not

[Steve Dower]

Steve Dower added the comment:

Thanks, Nick! I agree that this alone isn't worth a second RC, though if we fix 
another "nearly worth it" (especially anything related to the github 
transition) we may want to consider it still.

Ned - I'd be okay to sneak out another release this week if we want, without 
slipping the final release.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29799] Add tests for header API of 'urllib.request.Request' class

[Jaysinh shukla]

Changes by Jaysinh shukla :


--
pull_requests: +532

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28667] FD_SETSIZE is unsigned on FreeBSD

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29799] Add tests for header API of 'urllib.request.Request' class

[Jaysinh shukla]

Changes by Jaysinh shukla :


--
components: Tests
nosy: jaysinh.shukla
priority: normal
severity: normal
status: open
title: Add tests for header API of 'urllib.request.Request' class
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8256] input() doesn't catch _PyUnicode_AsString() exception; io.StringIO().encoding is None

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +531

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8256] input() doesn't catch _PyUnicode_AsString() exception; io.StringIO().encoding is None

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +530

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Done.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15695] Correct __sizeof__ support for StgDict

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8450] httplib: false BadStatusLine() raised

[Shoham Peller]

Shoham Peller added the comment:

How about back-porting the v3.5 fix, and the new "RemoteDisconnected" 
exception? Is that reasonable?

--
nosy: +Shoham Peller

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8256] input() doesn't catch _PyUnicode_AsString() exception; io.StringIO().encoding is None

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +529

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29779] New environment variable PYTHONHISTORY

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

That's a great feature! Here's a question: what should be CPython's behavior 
when PYTHONHISTORY is explicitly set to empty? Currently there's an error:

$ PYTHONHISTORY= ./python
Python 3.7.0a0 (master:f6595983e08fe20cf06a2535d74d912c6dbb044f, Mar 12 2017, 
19:22:29) 
[GCC 6.3.1 20170306] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 
Error in atexit._run_exitfuncs:
FileNotFoundError: [Errno 2] No such file or directory

Maybe it's better to just disable the history functionality in this case?

By the way, seems comments starting from 
https://github.com/python/cpython/pull/473/files#diff-f34a16518c608b2ca946d3f5ca0a1942R419
 should be updated too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

[Nick Coghlan]

Nick Coghlan added the comment:

With the fix for issue 29723 merged, this should be properly resolved now (and 
the fix available with 3.6.1).

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29723] 3.6.1rc1 adds the current directory to sys.path when running a subdirectory's __main__.py; previous versions did not

[Nick Coghlan]

Nick Coghlan added the comment:

Noting for the record: Steve reviewed & approved the original PR before I 
merged that and did the backport to 3.6.

With the new test case ensuring sys.path configuration consistency and Paul's 
report of success when checking the original problem from issue 29319 was 
resolved, I think this is OK to just go out with 3.6.1 final rather than 
needing an rc2 release.

--
assignee: steve.dower -> ncoghlan
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15695] Correct __sizeof__ support for StgDict

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +528

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29779] New environment variable PYTHONHISTORY

[Chi Hsuan Yen]

Changes by Chi Hsuan Yen :


--
nosy: +Chi Hsuan Yen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29723] 3.6.1rc1 adds the current directory to sys.path when running a subdirectory's __main__.py; previous versions did not

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +527

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

PR 637 revert to using the own implementations of lgamma and gamma on all 
platforms.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +526

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29723] 3.6.1rc1 adds the current directory to sys.path when running a subdirectory's __main__.py; previous versions did not

[Nick Coghlan]

Nick Coghlan added the comment:

I've merged PR 575 to master, and 636 is pending a successful Travis run for 
3.6.

Both branches still need NEWS entries- I'll do those as independent PRs rather 
than cherry-picking (since cherry picking NEWS changes is currently still 
doomed to fail)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29319] Embedded 3.6.0 distribution cannot run pyz files

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +525

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29723] 3.6.1rc1 adds the current directory to sys.path when running a subdirectory's __main__.py; previous versions did not

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +524

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29797] Deadlock with multiprocessing.Queue()

[Max]

Max added the comment:

Yes, this makes sense. My bad, I didn't realize processes might need to wait 
until the queue is consumed.

I don't think there's any need to update the docs either, nobody should have 
production code that never reads the queue (mine was a test of some other 
issue).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29798] Handle "git worktree" in "make patchcheck"

[Nick Coghlan]

Changes by Nick Coghlan :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Mark Dickinson]

Mark Dickinson added the comment:

Please can we revert to using the existing implementations of lgamma and gamma 
on all platforms? It's clear that there are many issues with OS-provided 
implementations.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29797] Deadlock with multiprocessing.Queue()

[Eryk Sun]

Eryk Sun added the comment:

On Windows the "QueueFeederThread" in each child process is blocked in 
WaitForMultipleObjects in PipeConnection._send_bytes. The pipe buffer size is 8 
KiB, and each pickled int is 5-6 bytes. With 2 processes the pipe is full after 
sending (256 + 469) * 2 == 1450 int objects. Joining this feeder thread waits 
until all of the data is sent, however long that takes. This appears to be 
working correctly as designed.

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29798] Handle "git worktree" in "make patchcheck"

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +523

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29798] Handle "git worktree" in "make patchcheck"

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +522

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29798] Handle "git worktree" in "make patchcheck"

[Nick Coghlan]

Changes by Nick Coghlan :


--
pull_requests: +521

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29656] Change "make patchcheck" to be branch aware

[Nick Coghlan]

Changes by Nick Coghlan :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29730] unoptimal calls to PyNumber_Check

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The call of PyNumber_Check() is redundant if we don't bother about error 
message. But if we want to have accurate error message we should check types 
before converting.

In parse_args_finds_byte we should check rather PyObject_CheckBuffer() (and 
maybe PyBytes_Check() for fast path if this makes sense). Perhaps some methods 
need to check also PyTuple_Check().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29730] unoptimal calls to PyNumber_Check

[Oren Milman]

Oren Milman added the comment:

"In bytes/bytearray methods -- integers and bytes-like objects."
(I guess you refer to parse_args_finds_byte (in Objects/bytes_methods.c))
so you suggest that in case (!PyIndex_Check(tmp_subobj)), we also check whether
(PyByteArray_Check(tmp_subobj) or PyBytes_Check(tmp_subobj)), and raise an
error if needed?

anyway, you and Raymond suggest different things. how do we proceed?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

There are accuracy issues with tgamma() and lgamma() on Windows. But less than 
on OS X.

==
FAIL: test_mtestfile (test.test_math.MathTests)
--
Traceback (most recent call last):
  File "C:\projects\cpython\lib\test\test_math.py", line 1287, in test_mtestfile
'\n  '.join(failures))
AssertionError: Failures in test_mtestfile:
  lgam0085: lgamma(-99.99): expected -331.85460524980596, got 
-331.86198661322277 (error = 0.00738 (129854318490 ulps); permitted error = 
1e-15 or 5 ulps)
  gam0085: gamma(-99.99): expected 7.540083334884096e-145, got 
7.484632144060724e-145 (error = 5.55e-147 (38979707393612 ulps); permitted 
error = 0 or 20 ulps)
  gam0124: gamma(-176.5): expected -1.196e-321, got 0.0 (error = 1.2e-321 (243 
ulps); permitted error = 0 or 20 ulps)
--

Does this mean that we should not use libc implementations of tgamma() and 
lgamma() on Windows?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29797] Deadlock with multiprocessing.Queue()

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
nosy: +davin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

PR 632 switch on using libc implementation on Windows. Will see how AppVeyor 
tests passed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26121] Use C99 functions in math if available

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +520

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29746] Update marshal docs to Python 3

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25996] Add support of file descriptor in os.scandir()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your investigation Eryk. Helpful as always.

Since I have no access to Windows I left this feature Unix-only.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28749] Fixed the documentation of the mapping codec APIs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Do you still have objections Marc-Andre?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com