[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2019-04-29 Thread Terry J. Reedy


Terry J. Reedy  added the comment:

1. NO SKIP utest.py with debug prints added and @skipIf initially commented out.
---
from unittest import TestCase, skipIf

#@skipIf(True, "Skip Testing")
class Tests(TestCase):
  def test_skip(self):
"this test will fail - if not skipped"
print('asserting')
self.assertEqual(0, 1)

print(Tests("test_skip").run())
print(Tests("test_skip").debug())
---

test_skip is run twice, with the output difference being as documented.

asserting

asserting
Traceback (most recent call last):
...
AssertionError: 0 != 1


2. SKIPTEST Adding "self.skipTest('why')" either in a new setUp() or at the top 
of skip_test() and adding another print 

print(Tests("test_skip").run().skipped)

results in the output I expect from the doc.


[(<__main__.Tests testMethod=test_skip>, 'why')]
Traceback (most recent call last):
...
unittest.case.SkipTest: why


3. SKIPIF CLASS Uncommenting @skipIf (the OP's case) instead results in

None
asserting
Traceback ...
AssertionError: 0 != 1

Since .run does not run the test, I agree that debug() running the test and 
raising AssertionError is a bug.  The test should not be run.  In my original 
comments, I expected SkipTest, as in cases 2 above and 4 below.  I have not yet 
checked the current tests.


4. SKIPIF FUNC Moving the skipIf decorator to test_skip results in
None
Traceback (most recent call last):
..
unittest.case.SkipTest: Skip Testing

I don't know why run() returns None for skipIf cases instead of returning a 
TestResult with non-empty skipped, as it does for skipTest, or if the None is a 
separate bug.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread miss-islington


miss-islington  added the comment:


New changeset 4b5340bb634be2ee2a40242cdf4e3f7a0b6c757a by Miss Islington (bot) 
in branch '3.7':
closes bpo-35329: Change 'Package' to 'package' in accordance with PEP8. 
(GH-13008)
https://github.com/python/cpython/commit/4b5340bb634be2ee2a40242cdf4e3f7a0b6c757a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread miss-islington


miss-islington  added the comment:


New changeset 3e5c4a7c804c3ad76a558e5463655c329aee6437 by Miss Islington (bot) 
in branch '2.7':
closes bpo-35329: Change 'Package' to 'package' in accordance with PEP8. 
(GH-13008)
https://github.com/python/cpython/commit/3e5c4a7c804c3ad76a558e5463655c329aee6437


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12941

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread Benjamin Peterson


Benjamin Peterson  added the comment:


New changeset ee0309f3d83ab9ffa02542bcf45ece84f4fb265e by Benjamin Peterson 
(Utkarsh Gupta) in branch 'master':
closes bpo-35329: Change 'Package' to 'package' in accordance with PEP8. 
(GH-13008)
https://github.com/python/cpython/commit/ee0309f3d83ab9ffa02542bcf45ece84f4fb265e


--
nosy: +benjamin.peterson
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12942

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36735] minimize disk size of cross-compiled python3.6

2019-04-29 Thread Michal Gregorczyk


Michal Gregorczyk  added the comment:

Thank you. I'm closing and will ask on python-list as suggested

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
Removed message: https://bugs.python.org/msg341129

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

PR 13016 is fixed, and I will remove the release blocker, but I will leave it 
open for now until we can check if there is consensus on the status and future 
of the inspect module after PEP 570 :)

--
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

PR 13016 is merged, and I will remove the release blocker, but I will leave it 
open for now until we can check if there is consensus on the status and future 
of the inspect module after PEP 570 :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset d5d2b4546939b98244708e5bb0cfccd55b99d244 by Pablo Galindo in 
branch 'master':
bpo-36751: Deprecate getfullargspec and report positional-only args as regular 
args (GH-13016)
https://github.com/python/cpython/commit/d5d2b4546939b98244708e5bb0cfccd55b99d244


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36755] [2.7] test_httplib leaked [8, 8, 8] references with OpenSSL 1.1.1

2019-04-29 Thread STINNER Victor


New submission from STINNER Victor :

AMD64 Fedora Rawhide Refleaks 2.7 buildbot:
https://buildbot.python.org/all/#/builders/190/builds/18

test_httplib leaked [8, 8, 8] references, sum=24


When I run the test on my Fedora 29 ("OpenSSL 1.1.1b FIPS  26 Feb 2019"), I can 
reproduce leak:

$ ./python -m test -R 3:3 -m 
test.test_httplib.HTTPSTest.test_local_bad_hostname test_httplib
...
test_httplib leaked [8, 8, 8] references, sum=24
...


My bet is that the issue is related to OpenSSL 1.1.1 which changes how a TLS 
connection is terminated.


Running the test in verbose mode logs a traceback:

$ ./python -m test -v test_httplib 
...
test_local_bad_hostname (test.test_httplib.HTTPSTest) ... 

Exception happened during processing of request from ('127.0.0.1', 48554)
Traceback (most recent call last):
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 293, in 
_handle_request_noblock
self.process_request(request, client_address)
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 321, in 
process_request
self.finish_request(request, client_address)
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 334, in 
finish_request
self.RequestHandlerClass(request, client_address, self)
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 655, in 
__init__
self.handle()
  File "/home/vstinner/prog/python/2.7/Lib/BaseHTTPServer.py", line 340, in 
handle
self.handle_one_request()
  File "/home/vstinner/prog/python/2.7/Lib/BaseHTTPServer.py", line 310, in 
handle_one_request
self.raw_requestline = self.rfile.readline(65537)
  File "/home/vstinner/prog/python/2.7/Lib/socket.py", line 480, in readline
data = self._sock.recv(self._rbufsize)
  File "/home/vstinner/prog/python/2.7/Lib/ssl.py", line 754, in recv
return self.read(buflen)
  File "/home/vstinner/prog/python/2.7/Lib/ssl.py", line 641, in read
v = self._sslobj.read(len)
error: [Errno 104] Connection reset by peer

 server (('127.0.0.1', 44923):44923 ('TLS_AES_256_GCM_SHA384', 'TLSv1.3', 256)):
   [30/Apr/2019 02:40:01] code 404, message File not found
 server (('127.0.0.1', 44923):44923 ('TLS_AES_256_GCM_SHA384', 'TLSv1.3', 256)):
   [30/Apr/2019 02:40:01] "GET /nonexistent HTTP/1.1" 404 -
stopping HTTPS server
joining HTTPS thread
ok


Without -v, the test fails with:

vstinner@apu$ ./python -m test test_httplib
Run tests sequentially
0:00:00 load avg: 0.63 [1/1] test_httplib
Traceback (most recent call last):
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 293, in 
_handle_request_noblock
self.process_request(request, client_address)
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 321, in 
process_request
self.finish_request(request, client_address)
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 334, in 
finish_request
self.RequestHandlerClass(request, client_address, self)
  File "/home/vstinner/prog/python/2.7/Lib/SocketServer.py", line 655, in 
__init__
self.handle()
  File "/home/vstinner/prog/python/2.7/Lib/BaseHTTPServer.py", line 340, in 
handle
self.handle_one_request()
  File "/home/vstinner/prog/python/2.7/Lib/BaseHTTPServer.py", line 310, in 
handle_one_request
self.raw_requestline = self.rfile.readline(65537)
  File "/home/vstinner/prog/python/2.7/Lib/socket.py", line 480, in readline
data = self._sock.recv(self._rbufsize)
  File "/home/vstinner/prog/python/2.7/Lib/ssl.py", line 754, in recv
return self.read(buflen)
  File "/home/vstinner/prog/python/2.7/Lib/ssl.py", line 641, in read
v = self._sslobj.read(len)
error: [Errno 104] Connection reset by peer
test test_httplib produced unexpected output:
**

Exception happened during processing of request from ('127.0.0.1', 56044)


**

== Tests result: FAILURE ==

1 test failed:
test_httplib

Total duration: 281 ms
Tests result: FAILURE


My attempt to fix the warning:

diff --git a/Lib/BaseHTTPServer.py b/Lib/BaseHTTPServer.py
index 3df3323a97..8fe29e9d3e 100644
--- a/Lib/BaseHTTPServer.py
+++ b/Lib/BaseHTTPServer.py
@@ -332,6 +332,12 @@ class 
BaseHTTPRequestHandler(SocketServer.StreamRequestHandler):
 self.log_error("Request timed out: %r", e)
 self.close_connection = 1
 return
+except socket.error as exc:
+# Using ssl and OpenSSL 1.1.1, sometimes readline() can fail
+# with error(104, 'Connection reset by peer')
+self.close_connection = 1
+exc = None
+return
 
 def handle(self):
 """Handle multiple requests if necessary."""

--
components: Tests
messages: 341127
nosy: vstinner
priority: normal
severity: 

[issue36232] Improve error message on dbm.open

2019-04-29 Thread Brett Cannon


Brett Cannon  added the comment:


New changeset 81c5a905951aaf46f292eb459c32649c0b74ef61 by Brett Cannon (Marco 
Rougeth) in branch 'master':
bpo-36232: Improve error message on dbm.open() when the db doesn't exist 
(GH-12060)
https://github.com/python/cpython/commit/81c5a905951aaf46f292eb459c32649c0b74ef61


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

I found the time to get the first patch. Hopefully backports to 3.6 and 3.7 are 
easy, but I think 2.7 will take manual steps.

Chihiro Ito - if you have other test scenarios, it would be great if you could 
try them out with the fix in PR 13017. It should be easy enough to copy into 
your installed Python.

--
assignee:  -> steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

2019-04-29 Thread Steve Dower


Change by Steve Dower :


--
keywords: +patch
pull_requests: +12940
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado

Pablo Galindo Salgado  added the comment:

PR 13016 adds the positional-only arguments together with the regular arguments 
as suggested by Steve and Łukasz and deprecates getfullargspec() in favour of 
inspect.signature.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +12939
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36632] test_multiprocessing_forkserver: test_rapid_restart() leaked a dangling process on AMD64 FreeBSD 10-STABLE Non-Debug 3.x

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

May be related to this failure:

https://buildbot.python.org/all/#/builders/58/builds/2292

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26835] Add file-sealing ops to fcntl

2019-04-29 Thread Joannah Nanjekye


Change by Joannah Nanjekye :


--
keywords: +patch
pull_requests: +12938
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36674] "unittest.TestCase.debug" should honour "skip" (and other test controls)

2019-04-29 Thread Lisa Roach


Lisa Roach  added the comment:

+1, I think tests should run the same way in debug() and run(), the difference 
being limited only to how the result is handled. 

Marking a test as skipped should still be skipped while debugging, else it 
pollutes the results with tests that will not run with run().

--
nosy: +lisroach

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

> No, you didn't document all the changed file names,  See, for instance, 
> /usr/bin/python3* for a start :)

Oh, I see. I was thinking at something else. First I proposed to drop the "d" 
from the SOABI for debug build, but then I changed my mind. So yeah, I didn't 
change the SOABI for:
https://docs.python.org/dev/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

And this change should be documented elsewhere.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:

Thanks for the analyses everyone!  Also see the discussion in duplicate 
Issue36432.  I was never able to reproduce the failure on earlier versions of 
macOS but then it seemed to become a hard failure with the release of 10.14.4.  
I haven't gone back and tried running the tests on all supported older versions 
with this reversion in place but those I have did not exhibit any new failures. 
 So we should keep an eye open for reports of segfaults running tests as 
originally reported in Issue18075.  But better that then not being able to run 
any tests.  "Fixed" in 3.8.0a4, 3.7.4, and 3.6.9 (to allow tests to be run on 
macOS) by reverting the change for Issue18075.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Łukasz Langa

Łukasz Langa  added the comment:

+1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:


New changeset fbe2a1394bf52f5a4455681e1b1f705a31559585 by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011) 
(GH-13014)
https://github.com/python/cpython/commit/fbe2a1394bf52f5a4455681e1b1f705a31559585


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:


New changeset fbe2a1394bf52f5a4455681e1b1f705a31559585 by Ned Deily (Miss 
Islington (bot)) in branch '3.6':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011) 
(GH-13014)
https://github.com/python/cpython/commit/fbe2a1394bf52f5a4455681e1b1f705a31559585


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36432] Running python test suite fails on macOS 10.14.4 with resource.RLIMIT_STACK error

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:

Thanks, Inada-san, for the pointer.  Closing this as a duplicate of Issue34602

--
resolution:  -> duplicate
stage: test needed -> resolved
status: open -> closed
superseder:  -> python3 resource.setrlimit strange behaviour under macOS

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Łukasz Langa

Łukasz Langa  added the comment:

I'm with Steve on this one. Report positional-only args as regular arguments in 
the old functions.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12936

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12937

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread miss-islington


miss-islington  added the comment:


New changeset 52a5b71063af68c42b048095c4e555e93257f151 by Miss Islington (bot) 
in branch '3.7':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/52a5b71063af68c42b048095c4e555e93257f151


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread miss-islington


miss-islington  added the comment:


New changeset 52a5b71063af68c42b048095c4e555e93257f151 by Miss Islington (bot) 
in branch '3.7':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/52a5b71063af68c42b048095c4e555e93257f151


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:


New changeset 883dfc668f9730b00928730035b5dbd24b9da2a0 by Ned Deily in branch 
'master':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/883dfc668f9730b00928730035b5dbd24b9da2a0


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12935

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12934

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:


New changeset 883dfc668f9730b00928730035b5dbd24b9da2a0 by Ned Deily in branch 
'master':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/883dfc668f9730b00928730035b5dbd24b9da2a0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread Ned Deily


Change by Ned Deily :


--
keywords: +patch
pull_requests: +12932
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread Ned Deily


Change by Ned Deily :


--
pull_requests: +12933

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36754] Remove smart quotes in pydoc text

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

> mismatch in encodings

Also likely. I haven't looked into how pydoc does its rendering, but certainly 
Python 3.7 on Windows should be able to print regular Unicode.

Perhaps it's not going through stdout for some reason?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36754] Remove smart quotes in pydoc text

2019-04-29 Thread Steven D'Aprano

Steven D'Aprano  added the comment:

> Not all console configurations can correctly render smart quotes in 
> help() text. See the "Æ" in "superclass's" below.

That suggests to me a mismatch in encodings, rather than inability to 
render curly quotes at all. It's 2019 and surely we don't have to target 
ASCII as the lowest common denominator any more?

--
nosy: +steven.daprano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28608] Support creating hardlink using `pathlib`

2019-04-29 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

Closing this as a duplicate of issue26978 which has an open PR with comments 
from @pitrou.

Thanks

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Implement pathlib.Path.link (Using os.link)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36754] Remove smart quotes in pydoc text

2019-04-29 Thread Steve Dower

New submission from Steve Dower :

Not all console configurations can correctly render smart quotes in help() 
text. See the "Æ" in "superclass's" below.

When building for pydoc-topics, it would be ideal to disable smart quotes. (I'm 
assuming from issue31793 that this can be done in configuration, though I'm not 
entirely sure how - it's not clear to me from those PRs)

---

>>> help("BASICMETHODS")
Basic customization
***

object.__new__(cls[, ...])
...
   Typical implementations create a new instance of the class by
   invoking the superclassÆs "__new__()" method using
   "super().__new__(cls[, ...])" with appropriate arguments and then
   modifying the newly-created instance as necessary before returning
   it.

--
assignee: docs@python
components: Documentation
messages: 341107
nosy: docs@python, steve.dower
priority: normal
severity: normal
stage: needs patch
status: open
title: Remove smart quotes in pydoc text
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18748] io.IOBase destructor silence I/O error on close() by default

2019-04-29 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

The ValueError warnings in test_urllib noted in msg340059  feels like an issue 
with the test where FakeSocket calls close by itself once it's internal io_refs 
counter is 0 and during destructor again close is called on an already closed 
object causing the ValueError.

* The test uses fakehttp() creating FakeSocket starting with io_refs as 1 [1]
* During the test in urlopen, sock.makefile() (io_refs += 1) is called 
increasing the io_refs to be 2.
* HTTPConnection.close calls sock.close (fakesocket.close) [3] calling io_refs 
-= 1 and to fakesocket.io_ref to be 1.
* This test uses raises status 302 with http_error_302 which calls 
self.redirect_internal where self.close is again called causing fp.io_refs == 0 
and subsequently calling io.BytesIO.close(self) to close the object. [4]
* During the end of the test destructor is called on the above closed 
fakesocket object and trying to flush on a closed object causes the ValueError 
warnings .

Maybe a check could be added during flush to make sure the object is not closed 
by testing for self.closed but I am not sure if closed attribute is guaranteed 
to be present. Removing the manual call to close in fakesocket could help since 
the destructor should be taking care of it and I could see no test failures or 
warnings removing the close as io_refs gets to 0.

[1] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/test/test_urllib.py#L61
[2] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/test/test_urllib.py#L67
[3] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/http/client.py#L919
[4] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/urllib/request.py#L2145

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread reimar


reimar  added the comment:

The modules not linking against libpython CAUSES this issue, thus Debian being 
affected even for old Python versions before issue21536.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Brett Cannon


Brett Cannon  added the comment:

If I remember correctly the un-deprecation was because 2/3 code could only use 
getfullargspec() to get all relevant details. Since we're so close to being 
done w/ Python 2 I think this might be the last change to make to them, 
document their deprecation, tack this info on to the end of the tuple, and then 
start raising DeprecationWarning in 3.9.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Berker Peksag


Berker Peksag  added the comment:

FYI, in msg261315, Eryk has mentioned about possible improvement of the 
exception message on POSIX. The filename has been added to the exception 
message in 8621bb5d93239316f97281826461b85072ff6db7:

>>> import subprocess, os
>>> os.access('log.txt', os.X_OK)
True
>>> subprocess.call(['./log.txt'])
Traceback (most recent call last):
  File "", line 1, in 
  File "/Users/berkerpeksag/projects/cpython/Lib/subprocess.py", line 325, in 
call
with Popen(*popenargs, **kwargs) as p:
  File "/Users/berkerpeksag/projects/cpython/Lib/subprocess.py", line 830, in 
__init__
self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Users/berkerpeksag/projects/cpython/Lib/subprocess.py", line 1648, in 
_execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 8] Exec format error: './log.txt'

--
nosy: +berker.peksag
stage:  -> needs patch
versions: +Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

> My proposal was to raise an exception if the input function has positonal 
> arguments

Counter-proposal - just report them as regular position-or-name arguments.

Users of inspect are most likely to be IDEs or editors getting information to 
present to users. And in my experience, most just ignore all exceptions because 
bugs cause some function objects to raise errors when trying to inspect them. 
Which means a new exception will just result in a worse experience for users 
and no indication of what's wrong.

On the other hand, if there is no change made, they'll just report a normal 
looking signature until they migrate to using updated Signature objects. Anyone 
using current Signature objects should similarly get the argument count right, 
even if they totally ignore the positional-only count. Since one of the 
arguments for supporting positional-only parameters is that they're for 
parameters that you'd never consider passing by name, but these tools still 
need to show a name, very few people should ever be tripped up by them being 
misreported. And when they do they'll be tripped up very quickly.

Basically, this is not a scenario that *requires* existing users to be broken. 
So we should avoid breaking them at all costs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

IMHO getargs(), getargspec(), getfullargspec() should be deprecated in favor of 
signature() which is future-proof. But Nick Coghlan undeprecated these 
functions in 2017 https://bugs.python.org/issue20438 whereas these were 
deprecated since 2015. I didn't understand the subtle issues. That's why I 
asked Pablo to open a separated issue, to get Nick and others involved to get 
the context.

My proposal was to raise an exception if the input function has positonal 
arguments. There is good way to fix these legacy functions, their design cannot 
be extended, whereas signature() is fine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:

No, you didn't document all the changed file names,  See, for instance, 
/usr/bin/python3* for a start :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

About the PEP, I asked Barry to review the change and he approved it.

About the doc, I didn't know that anyone rely on the exact filename. I 
documented all changes in a top-level section of the What's New in Python 3.8:
https://docs.python.org/dev/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

Sorry for thr annoyance. I didn't know that the macOS installer rely on these 
filenames.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Brett Cannon


Brett Cannon  added the comment:

Steve's right that we can't change the indexes on those functions for 
pre-existing values, so appending to the end is the only real option in that 
case. I still think they should both be deprecated due to how limiting their 
APIs are.

Obviously signature() can be updated cleanly.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread Ned Deily


Change by Ned Deily :


--
assignee:  -> vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:

This change has an impact on downstream packagers and users of Python 3.8 
because the SOABI flag values are also used to construct a number of file names 
and directories names in an Unix or macOS framework install besides the 
extension module (*.so) file names.  Suggest comparing the directory/file names 
installed to an alternate prefix (./configure --prefix=/tmp/3x ; make install) 
in 3.7 versus master with this PR.  Also suggest reading PEP 3149, which 
introduced the ABI-specific file names, and the various issues in the bug 
tracker that reference it.  At the very least, these changes need to be 
documented in the What's New for 3.8.  But the impact of the change should 
probably also be discussed with at least some of the large distributors.  (The 
change already inadvertently broke the macOS installer build - fixing.)

--
nosy: +ned.deily
priority: normal -> deferred blocker
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread Eric N. Vander Weele


Change by Eric N. Vander Weele :


--
nosy: +ericvw

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread Matthias Klose


Matthias Klose  added the comment:

why is this an issue on Debian? Debian is already not linking with libpython.

--
nosy: +doko

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2019-04-29 Thread reimar


reimar  added the comment:

Sorry for my laziness. I opened Issue36753.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread reimar


New submission from reimar :

Most affected platforms: RedHat and Debian, but with the changes from 
issue21536 probably all Linux distributions will be affected.

issue34814 and issue21536 and 
https://bugzilla.redhat.com/show_bug.cgi?id=1585201 make statements along the 
lines of "In short, RTLD_LOCAL is not supported."
This might have been considered a reasonable stance because of the specific 
example opening libpython directly.
However Python modules not linking to libpython also breaks things when 
libpython is loaded in the most indirect ways via dlopen.
E.g. dlopen("libA.so", RTLD_LOCAL | RTLD_NOW)
libA might have linked against libB, libB against libC and libC might 
optionally link against libpython.

As a developer generally cannot really know if some library might ever pull in 
a most indirect reference to libpython, not supporting RTLD_LOCAL in Python 
essentially means RTLD_LOCAL can NEVER EVER be used safely.

A test-case that will fail the import command when modules have not been linked 
against libpython is attached (demonstrating only one layer of indirection, but 
much more complex cases are of course possible).
You will need to adjust the (include, lib) paths in test.sh for your Python 
version, it was written to demonstrate the issue against RedHat's modifications 
of Python 2.7 (to my knowledge, RedHat and Debian has been affected by this 
issue much longer than mainline Python).

While dlmopen is an alternative with similar behaviour to RTLD_LOCAL on recent 
Linux versions for this case, it is not portable.

--
components: Library (Lib)
files: pytest.tar.gz
messages: 341094
nosy: reimar
priority: normal
severity: normal
status: open
title: Python modules not linking to libpython causes issues for RTLD_LOCAL 
system-wide
type: behavior
Added file: https://bugs.python.org/file48291/pytest.tar.gz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Raúl Núñez de Arenas

Raúl Núñez de Arenas  added the comment:

Hi Steve :) I assumed that the issue was solved, that's why I warned, in case a 
patch was applied and it didn't work.

When I did read "I suggest to only call reformat_strerror() when an user 
complains", I supposed a patch was ready O:)

No big deal, I can deal with that particular error in my code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

Yes, it's due to that. I guess we need to do netloc.rpartition(':') like we 
currently do for '@' in _checknetloc.

Promoting to release blocker and security issue to match the original issue. I 
can't get to this today, but I should be able to at the PyCon sprints next week 
if nobody else gets it sooner.

--
keywords: +3.5regression, 3.6regression, 3.7regression
nosy: +benjamin.peterson, larry, lukasz.langa, ned.deily
priority: normal -> release blocker
type: behavior -> security
versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

It still happens because nobody has proposed a patch to specially handle this 
one particular error code. The earlier messages explained why we can't do 
formatting on error messages.

If this one is particularly common, then it's best for it to be handled in 
Python code at the point where it shows up and converted into something more 
readable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Raúl Núñez de Arenas

Raúl Núñez de Arenas  added the comment:

I'm sorry to say that this still happens in Python 3.7.0...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34214] Pylint recusion stack overflow abort

2019-04-29 Thread Joannah Nanjekye


Change by Joannah Nanjekye :


--
nosy: +eric.smith, nanjekyejoannah, ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1613500] Write mode option for fileinput module.

2019-04-29 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1613500] Write mode option for fileinput module.

2019-04-29 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset be6dbfb43b89989ccc83fbc4c5234f50f44c47ad by Berker Peksag in 
branch 'master':
bpo-1613500: Don't hardcode output file mode in fileinput.FileInput (GH-12986)
https://github.com/python/cpython/commit/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36729] Delete unused text variable on tests

2019-04-29 Thread Emmanuel Arias

Emmanuel Arias  added the comment:

Sorry for the noise I confused on my mail.

Arias Emmanuel
eamanu.com

El lun., 29 de abr. de 2019 11:46, Emmanuel Arias 
escribió:

>
> Emmanuel Arias  added the comment:
>
> Hello,
>
> Yes not problem. Tonight when I was just to make the MR, I see that the
> bugs was solved.
>
> Thanks
>
> Arias Emmanuel
> eamanu.com
>
> El lun., 29 de abr. de 2019 05:10, Serhiy Storchaka <
> rep...@bugs.python.org>
> escribió:
>
> >
> > Change by Serhiy Storchaka :
> >
> >
> > --
> > resolution:  -> fixed
> > stage: patch review -> resolved
> > status: open -> closed
> >
> > ___
> > Python tracker 
> > 
> > ___
> >
>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

> In short, RTLD_LOCAL is not supported.

reimar: "I am sorry, this is not a workable stance. This does not just affect 
loading libpython directly. (...)"

This issue is now closed, as bpo-21536. Would you mind to open a new issuse to 
clearly explain your own case? Please mention your platform.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36729] Delete unused text variable on tests

2019-04-29 Thread Emmanuel Arias

Emmanuel Arias  added the comment:

Hello,

Yes not problem. Tonight when I was just to make the MR, I see that the
bugs was solved.

Thanks

Arias Emmanuel
eamanu.com

El lun., 29 de abr. de 2019 05:10, Serhiy Storchaka 
escribió:

>
> Change by Serhiy Storchaka :
>
>
> --
> resolution:  -> fixed
> stage: patch review -> resolved
> status: open -> closed
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21536] extension built with a shared python cannot be loaded with a static python

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21536] extension built with a shared python cannot be loaded with a static python

2019-04-29 Thread reimar


reimar  added the comment:

As explained in Issue34814, this change not only breaks RTLD_LOCAL of 
libpython, but it breaks it in fact system-wide.
It seems a bit much for Python to enforce a system-wide policy to not use 
RTLD_LOCAL just because of its own technical challenges, and thus I'd ask to 
reconsider the original change.

--
nosy: +reimar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2019-04-29 Thread reimar


reimar  added the comment:

> In short, RTLD_LOCAL is not supported.

I am sorry, this is not a workable stance.
This does not just affect loading libpython directly.
It also affects dlopen of a library that links to a library ... that links to 
libpython.
For a developer is impossible to know if some library via dozens of 
dependencies might ever bring in libpython.
Thus your stance is essentially equivalent to "nobody must ever use 
RTLD_LOCAL". I find it hard to consider that an acceptable "solution".

--
nosy: +reimar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

Nope, I was right the first time. The FullArgSpec tulle has changed indexes, 
and formatargspec has additional (undocumented) arguments.

Since formatargspec is deprecated, it should probably just not change.

The FullArgSpec tuple might have to become a concrete class implementation so 
that it can have positional-only args as a named attribute but not part of 
unpacking.

As for where the new information *can* go, I suspect the Signature object is 
the only place. Though that has limitations, and for C APIs in particular much 
of my code only uses the more reliable getfullargspec.

--
nosy: +lukasz.langa, steve.dower
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Change by Steve Dower :


--
nosy:  -steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

My bad, there were PR changes that GitHub didn't show me. As you were

--
nosy:  -lukasz.langa
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

Marking as a release blocker and adding RM. The 3.8 branch now contains 
breaking API changes to these functions that we have to resolve before the next 
release (or revert while deciding how to handle the change) - PR 12701 has been 
merged.

--
keywords: +3.7regression
nosy: +lukasz.langa, steve.dower
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36004] Add datetime.fromisocalendar

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

Thanks Paul, nice enhancement!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36004] Add datetime.fromisocalendar

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 88c093705615c50c47fdd9ab976803f73de7e308 by Victor Stinner (Paul 
Ganssle) in branch 'master':
bpo-36004: Add date.fromisocalendar (GH-11888)
https://github.com/python/cpython/commit/88c093705615c50c47fdd9ab976803f73de7e308


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset be6cbfb7670c852ef8abf52b63989442b6942dbb by Victor Stinner in 
branch '2.7':
bpo-35952: Sync test.pythoninfo from master (GH-13010)
https://github.com/python/cpython/commit/be6cbfb7670c852ef8abf52b63989442b6942dbb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 5e09a9973b46cd6361a25877e0ca8dd0ab82d678 by Victor Stinner in 
branch '3.7':
bpo-35952: Sync test.pythoninfo from master (GH-13009)
https://github.com/python/cpython/commit/5e09a9973b46cd6361a25877e0ca8dd0ab82d678


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +12931

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36752] test multiprocessing: test_rapid_restart() crash on AIX

2019-04-29 Thread STINNER Victor


New submission from STINNER Victor :

POWER6 AIX 3.x:
https://buildbot.python.org/all/#/builders/161/builds/1050

==
ERROR: test_rapid_restart 
(test.test_multiprocessing_forkserver.WithManagerTestManagerRestart)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2872, in test_rapid_restart
queue = manager.get_queue()
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 737, in temp
token, exp = self._create(typeid, *args, **kwds)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 620, in _create
conn = self._Client(self._address, authkey=self._authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 796, in XmlClient
return ConnectionWrapper(Client(*args, **kwds), _xml_dumps, _xml_loads)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 502, in Client
c = SocketClient(address)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 629, in SocketClient
s.connect(address)
ConnectionRefusedError: [Errno 79] Connection refused

==
ERROR: test_remote 
(test.test_multiprocessing_forkserver.WithManagerTestRemoteManager)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2835, in test_remote
manager2.connect()
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 545, in connect
conn = Client(self._address, authkey=self._authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 796, in XmlClient
return ConnectionWrapper(Client(*args, **kwds), _xml_dumps, _xml_loads)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 508, in Client
answer_challenge(c, authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 751, in answer_challenge
message = connection.recv_bytes(256) # reject large message
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 216, in recv_bytes
buf = self._recv_bytes(maxlength)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 414, in _recv_bytes
buf = self._recv(4)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 379, in _recv
chunk = read(handle, remaining)
ConnectionResetError: [Errno 73] Connection reset by peer

==
ERROR: test_rapid_restart 
(test.test_multiprocessing_forkserver.WithProcessesTestManagerRestart)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2872, in test_rapid_restart
queue = manager.get_queue()
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 737, in temp
token, exp = self._create(typeid, *args, **kwds)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 620, in _create
conn = self._Client(self._address, authkey=self._authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 796, in XmlClient
return ConnectionWrapper(Client(*args, **kwds), _xml_dumps, _xml_loads)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 502, in Client
c = SocketClient(address)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 629, in SocketClient
s.connect(address)
ConnectionRefusedError: [Errno 79] Connection refused

==
ERROR: test_rapid_restart 
(test.test_multiprocessing_forkserver.WithThreadsTestManagerRestart)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2872, in test_rapid_restart
queue = manager.get_queue()
  File 

[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

Context: see https://github.com/python/cpython/pull/12701 discussion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

The implementation has been merged, so I will remove the "release blocker". We 
are still missing the documentation and the final changes to the inspect module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
priority: release blocker -> high

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +12930

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset a86e06433a010f873dfd7957e0f87a39539876ee by Victor Stinner 
(xdegaye) in branch 'master':
bpo-35952: Fix test.pythoninfo when the compiler is missing (GH-13007)
https://github.com/python/cpython/commit/a86e06433a010f873dfd7957e0f87a39539876ee


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 8c77b8cb9188165a123f2512026e3629bf03dc9b by Pablo Galindo in 
branch 'master':
bpo-36540: PEP 570 -- Implementation (GH-12701)
https://github.com/python/cpython/commit/8c77b8cb9188165a123f2512026e3629bf03dc9b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Opened https://bugs.python.org/issue36751 to track changes in the inspect 
module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado


New submission from Pablo Galindo Salgado :

This issue is to discuss how to handle the changes in the inspect module for 
PEP 570. In particular, how to handle:

* getfullargspec
* formatargspec

for positional-only parameters.

--
components: Interpreter Core
messages: 341070
nosy: pablogsal, serhiy.storchaka, vstinner
priority: normal
severity: normal
status: open
title: Changes in the inspect module for PEP 570
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34155] email.utils.parseaddr mistakenly parse an email

2019-04-29 Thread Jakub Wilk


Change by Jakub Wilk :


--
nosy:  -jwilk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34155] email.utils.parseaddr mistakenly parse an email

2019-04-29 Thread Dain Dwarf


Dain Dwarf  added the comment:

Hello, kind of new here.

I just wanted to note that the issue that lead to Tchap's security attack still 
exists in the non-deprecated message_from_string function:

email.message_from_string('From: a...@malicious.org@important.com', 
policy=email.policy.default)['from'].addresses

(Address(display_name='', username='a', domain='malicious.org'),)

So, deprecating parseaddr is not enough for security purpose, unless there is 
another ticket for the new email API.

--
nosy: +Dain Dwarf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread Xavier de Gaye


Xavier de Gaye  added the comment:

Attached pythoninfo_api_24.txt, the output of pythoninfo for Android API 24 
with PR 13007.

--
nosy: +vstinner
Added file: https://bugs.python.org/file48290/pythoninfo_api_24.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread Utkarsh Gupta


Utkarsh Gupta  added the comment:

Hey,

I'd be happy to submit one :)

--
nosy: +utkarsh2102

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread Utkarsh Gupta


Change by Utkarsh Gupta :


--
keywords: +patch
pull_requests: +12929
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

I just reverted the change. I'm unable to reproduce and I am not available this 
week to investigate anyway.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 99fcc616d400cd31af0733c3f8cc93bcc1d32a44 by Victor Stinner in 
branch 'master':
Revert "bpo-36356: Destroy the GIL at exit (GH-12453)" (GH613006)
https://github.com/python/cpython/commit/99fcc616d400cd31af0733c3f8cc93bcc1d32a44


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35907] Unnecessary URL scheme exists to allow file:// reading file in urllib

2019-04-29 Thread Charalampos Stratakis


Change by Charalampos Stratakis :


--
nosy: +cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread Xavier de Gaye


Change by Xavier de Gaye :


--
keywords: +patch
pull_requests: +12928
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +12927
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >