[issue28768] Warning: implicit declaration of function '_setmode'

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +1071

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5ea0fef6ec53 by Steve Dower in branch '2.7':
Issue #28768: Fix implicit declaration of function _setmode. Patch by Masayuki 
Yamamoto
https://hg.python.org/cpython/rev/5ea0fef6ec53

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[STINNER Victor]

STINNER Victor added the comment:

Well, the change is not going to hurt. I backported the change. Thanks for the 
fix Masayuki!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

Building 2.7 is for testing purposes. It is used to judge whether it is a 
problem (specifically for Cygwin-specific) originated in the old version. 
_setmode is an important function for setting input and output of CPython, so 
in Cygwin I feel annoying that warnings are issued even though there is 
actually no problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[STINNER Victor]

STINNER Victor added the comment:

Masayuki Yamamoto: Do you consider that Python 2.7 should be fixed as well? 
What is your use case for compiling Python 2.7 on Windows using Cygwin?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Steve Dower]

Steve Dower added the comment:

I applied to 3.6 and default. If anyone is motivated enough to apply to 2.7, 
feel free.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5027780d456b by Steve Dower in branch '3.6':
Issue #28768: Fix implicit declaration of function _setmode. Patch by Masayuki 
Yamamoto
https://hg.python.org/cpython/rev/5027780d456b

New changeset 276d1bae92be by Steve Dower in branch 'default':
Issue #28768: Fix implicit declaration of function _setmode. Patch by Masayuki 
Yamamoto
https://hg.python.org/cpython/rev/276d1bae92be

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[STINNER Victor]

STINNER Victor added the comment:

include-io.h.patch LGTM.

2.7-include-io.h.patch: Cygwin is not currently officially supported in 
CPython. I suggest to focus efforts on supporting Cygwin in the default branch 
(future 3.7) only, as we are doing with Android.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Martin Panter]

Martin Panter added the comment:

The Modules/main.c change at least looks reasonable as a bug fix.

In the long term, it would be nice to clean up some of the conditions for 
including . Currently it is unconditional via PC/pyconfig.h, configure.ac 
optionally enables HAVE_IO_H, and there are various other conditions in 
different files, like as QUICKWIN, PYCC_VACPP and MS_WINDOWS || __CYGWIN__.

--
components: +Windows
nosy: +martin.panter, paul.moore, steve.dower, tim.golden, zach.ware
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Masayuki Yamamoto]

Changes by Masayuki Yamamoto :


Added file: http://bugs.python.org/file45593/2.7-include-io.h.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Masayuki Yamamoto]

New submission from Masayuki Yamamoto:

Platform that appeared warning is Vista Cygwin x86. Interpreter execution 
doesn't crash because _setmode function is supplied from cygwin1.dll that 
always linked.
Warning reason is header io.h [*] doesn't include to source file. Therefore I 
wrote two patches for 3.7 and 2.7.

[*] https://msdn.microsoft.com/en-us/library/tw4k6df8.aspx (Cygwin also 
avaliable)

build log on 3.7:

gcc -c -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall 
-Wstrict-prototypes-std=c99 -Wextra -Wno-unused-result 
-Wno-unused-parameter -Wno-missing-field-initializers   -I. -I./Include
-DPy_BUILD_CORE -o Modules/main.o Modules/main.c
Modules/main.c: In function 'Py_Main':
Modules/main.c:599:5: warning: implicit declaration of function '_setmode' 
[-Wimplicit-function-declaration]
 _setmode(fileno(stdin), O_BINARY);
 ^
gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall 
-Wstrict-prototypes-std=c99 -Wextra -Wno-unused-result 
-Wno-unused-parameter -Wno-missing-field-initializers   -I. -I./Include
-DPy_BUILD_CORE  -I./Modules/_io -c ./Modules/_io/fileio.c -o Modules/fileio.o
./Modules/_io/fileio.c: In function '_io_FileIO___init___impl':
./Modules/_io/fileio.c:478:5: warning: implicit declaration of function 
'_setmode' [-Wimplicit-function-declaration]
 _setmode(self->fd, O_BINARY);
 ^

--
components: Build
files: include-io.h.patch
keywords: patch
messages: 281389
nosy: benjamin.peterson, masamoto, stutzbach
priority: normal
severity: normal
status: open
title: Warning: implicit declaration of function '_setmode'
type: compile error
versions: Python 2.7, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45592/include-io.h.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com