[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Steve Dower]

Steve Dower  added the comment:

Merged. It doesn't need a backport - the target audience is CI users who will 
see this on master first.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> compile error
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Steve Dower]

Steve Dower  added the comment:


New changeset 3396d1e0ca858065c5bb7e5a9737be6ffc4028f7 by Steve Dower (Jeroen 
Demeyer) in branch 'master':
bpo-36448: mention 'make regen-all' in error message (GH-12585)
https://github.com/python/cpython/commit/3396d1e0ca858065c5bb7e5a9737be6ffc4028f7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> I'd propose adding "%0D%0A%0D%0AIf you are developing on another platform, 
> try make regen-all and commit the updated files"

I updated the PR with wording similar to that. I don't want to bikeshed too 
much about the precise wording. If you disagree with my variant, I'll use your 
proposal verbatim.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

> For some reason, the Travis CI build on 
> https://github.com/python/cpython/pull/12582 isn't actually starting. It says 
> "Waiting for status to be reported" but I pushed 10 hours ago.

Travis CI had some problem with linux builds

https://www.traviscistatus.com

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> As an aside, I thought we had a merge hook to check this on Travis?

For some reason, the Travis CI build on 
https://github.com/python/cpython/pull/12582 isn't actually starting. It says 
"Waiting for status to be reported" but I pushed 10 hours ago...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Steve Dower]

Steve Dower  added the comment:

So an important aspect of the "fix" is that this message only appears after the 
fix has been applied. Anyone running into this locally has already updated 
those files, and just needs to "git add -u" to include them in their next 
commit. (Unfortunately, MSBuild has no reasonable way to retrigger a build it 
has already completed, since that introduces cycles into its dependency 
resolution.)

The problem here is that when a non-Windows developer sees this error in CI, 
it's not clear what *they* should do about it.

The current text is: "@(_Updated->'%(Filename)%(Extension)',', ') updated. You 
will need to rebuild pythoncore to see the changes."

The PR adds: "You may also need to run 'make regen-all'."

I'd propose adding "%0D%0A%0D%0AIf you are developing on another platform, try 
make regen-all and commit the updated files"

(The %0D%0A's at the start add newlines to the output for readability.)

As an aside, I thought we had a merge hook to check this on Travis? Why didn't 
that trigger? There's no reason why any of our CI platforms should let you 
build with out-of-date frozens, so it's a bit of a shame to blame the Windows 
build for doing its job properly :)

--
versions: +Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Jeroen Demeyer]

Change by Jeroen Demeyer :


--
keywords: +patch
pull_requests: +12527
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36448] Message "You will need to rebuild pythoncore to see the changes" should mention "make regen-all"

[Jeroen Demeyer]

New submission from Jeroen Demeyer :

On Windows builds, one may get the message

C:\projects\cpython\PCbuild\_freeze_importlib.vcxproj(130,5): error : 
importlib.h, importlib_external.h, importlib_zipimport.h updated. You will need 
to rebuild pythoncore to see the changes.

See for example https://bugs.python.org/issue29631 and 
https://discuss.python.org/t/windows-ci-build-fails-with-you-will-need-to-rebuild-pythoncore-to-see-the-changes/1071

The fix is simply running "make regen-all". It would be good to mention this in 
that error message.

--
components: Windows
messages: 338952
nosy: jdemeyer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Message "You will need to rebuild pythoncore to see the changes" should 
mention "make regen-all"

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com