[issue40878] Use c99 on the aixtools bot

[Michael Felt]

Michael Felt  added the comment:

Disregard the last mail -seems many routines go to unresolved.

On 15/08/2020 20:43, Stefan Krah wrote:
> Change by Stefan Krah :
>
>
> --
> assignee:  -> skrah
> resolution:  -> fixed
> stage: patch review -> resolved
> status: open -> closed
> type:  -> compile error
>
> ___
> Python tracker 
> 
> ___
>

--
Added file: https://bugs.python.org/file49986/OpenPGP_0x722BFDB61F396FC2.asc

___
Python tracker 

___

OpenPGP_0x722BFDB61F396FC2.asc
Description: application/pgp-keys
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

Change by Stefan Krah :


--
assignee:  -> skrah
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

Stefan Krah  added the comment:


New changeset 1864eacc22485b26c0ec0a059c9330f877861afb by Miss Islington (bot) 
in branch '3.9':
bpo-40878: xlc cannot handle C99 extern inline. (GH-21891)
https://github.com/python/cpython/commit/1864eacc22485b26c0ec0a059c9330f877861afb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +21010
pull_request: https://github.com/python/cpython/pull/21891

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

Stefan Krah  added the comment:


New changeset 40e700ad042089120456cc2ee79b8ca69479416b by Stefan Krah in branch 
'master':
bpo-40878: xlc cannot handle C99 extern inline. (GH-21887)
https://github.com/python/cpython/commit/40e700ad042089120456cc2ee79b8ca69479416b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

Change by Stefan Krah :


--
keywords: +patch
pull_requests: +21006
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21887

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Michael Felt]

Michael Felt  added the comment:

I have been doing manual tests - and it seems build is broken for AIX
and xlc.

I shall be working on a git bisect to try and identify what broke it for
xlc-v11. Finding what broke xlc-v13 will require more time.

Note: it is no longer limited to _decimal not being built - builds
(i.e., compile) fail completely atm.

regards,

Michael

On 15/06/2020 18:55, Michael Felt wrote:
> Michael Felt  added the comment:
>
> I'll switch my bot https://buildbot.python.org/all/#/builders/119 to use
> c99_r rather than xlc_r.
>
> Test 1129 will b e the first with c99_r (and xlc v13).
>
> On 11/06/2020 00:37, Stefan Krah wrote:
>> Stefan Krah  added the comment:
>>
>> So it would still be interesting to see what happens if you compile
>> libmpdec with c99_r (emphasis mine):
>>
>>
>> """
>> This command supports all ISO
>> C99 language features, but does
>> not support IBM language
>> extensions. Use this invocation for
>> *strict* conformance to the C99
>> standard.
>> """
>>
>> --
>>
>> ___
>> Python tracker 
>> 
>> ___
>>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Michael Felt]

Michael Felt  added the comment:

I switched the "aixtools" bot back to "xlc", and also back to my POWER6
server that runs xlc-v11.

iirc it is xlc-v13 (or maybe even v12) that is having trouble with
_decimal (or is it POWER8). From memory, _decimal was compiling properly
with xlc-v11.

Although - my last runs on the POWER6, by default, were using gcc - so
maybe I thought, incorrectly, that xlc was passing.

Time shall tell.

p.s. - if you make a PR that emulates a rollback, if that is what you
were thinking - I can test that separately/manually.

Michael

On 16/06/2020 09:04, Michael Felt wrote:
> Michael Felt  added the comment:
>
> I’ll switch back to xlc ( even try without the _r ) and look for the macro 
> asap (vacation and occasional travel). 
>
> Sent from my iPhone
>
>> On 15 Jun 2020, at 21:20, Stefan Krah  wrote:
>>
>> 
>> Stefan Krah  added the comment:
>>
>> Thanks!
>>
>> Ha, it turns out that c99_r has excellent C99 compliance. :)
>>
>>> Variable arguments macro RAISE_SYNTAX_ERROR was invoked with an empty 
>>> variable argument list.
>> Totally legit, we should use xlc (at least the front end) more often.
>>
>>
>> So maybe our code base is not C99 compliant enough and we have to switch 
>> back for sanity.
>>
>>
>>
>> For the _decimal problem at hand, if you give me the compiler identification 
>> macro (__xlc__ or something?) I can try the same as for MSVC and use the 
>> explicit EXTINLINE definition.
>>
>> --
>>
>> ___
>> Python tracker 
>> 
>> ___
>>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Michael Felt]

Michael Felt  added the comment:

I’ll switch back to xlc ( even try without the _r ) and look for the macro asap 
(vacation and occasional travel). 

Sent from my iPhone

> On 15 Jun 2020, at 21:20, Stefan Krah  wrote:
> 
> 
> Stefan Krah  added the comment:
> 
> Thanks!
> 
> Ha, it turns out that c99_r has excellent C99 compliance. :)
> 
>> Variable arguments macro RAISE_SYNTAX_ERROR was invoked with an empty 
>> variable argument list.
> 
> Totally legit, we should use xlc (at least the front end) more often.
> 
> 
> So maybe our code base is not C99 compliant enough and we have to switch back 
> for sanity.
> 
> 
> 
> For the _decimal problem at hand, if you give me the compiler identification 
> macro (__xlc__ or something?) I can try the same as for MSVC and use the 
> explicit EXTINLINE definition.
> 
> --
> 
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

Stefan Krah  added the comment:

Thanks!

Ha, it turns out that c99_r has excellent C99 compliance. :)

> Variable arguments macro RAISE_SYNTAX_ERROR was invoked with an empty 
> variable argument list.

Totally legit, we should use xlc (at least the front end) more often.


So maybe our code base is not C99 compliant enough and we have to switch back 
for sanity.



For the _decimal problem at hand, if you give me the compiler identification 
macro (__xlc__ or something?) I can try the same as for MSVC and use the 
explicit EXTINLINE definition.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Michael Felt]

Michael Felt  added the comment:

I'll switch my bot https://buildbot.python.org/all/#/builders/119 to use
c99_r rather than xlc_r.

Test 1129 will b e the first with c99_r (and xlc v13).

On 11/06/2020 00:37, Stefan Krah wrote:
> Stefan Krah  added the comment:
>
> So it would still be interesting to see what happens if you compile
> libmpdec with c99_r (emphasis mine):
>
>
> """
> This command supports all ISO
> C99 language features, but does
> not support IBM language
> extensions. Use this invocation for
> *strict* conformance to the C99
> standard.
> """
>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

Stefan Krah  added the comment:

So it would still be interesting to see what happens if you compile
libmpdec with c99_r (emphasis mine):


"""
This command supports all ISO
C99 language features, but does
not support IBM language
extensions. Use this invocation for
*strict* conformance to the C99
standard.
"""

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

Stefan Krah  added the comment:

Thanks for this information. The buildbot, however, fails to compile
C99 extern inline functions. Example:

ld: 0711-317 ERROR: Undefined symbol: .mpd_issnan


I understand the C99 extern inline feature like in this explanation:

https://www.greenend.org.uk/rjk/tech/inline.html


"""
In this example, one of the declarations does not mention inline:

// a declaration not mentioning inline
int max(int a, int b);

// a definition mentioning inline
inline int max(int a, int b) {
  return a > b ? a : b;
}

In either example, the function will be callable from other files.
"""



This is the scheme that libmpdec uses and that compilers understood
at the time I wrote it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Michael Felt]

Michael Felt  added the comment:

Actually, iirc - xlc is c99 plus a few extra settings.

The configuration files for xlc are, traditionally, in /etc (the later
versions of the compiler have moved them into /opt/show/where so that
multiple versions of the compiler can be installed.

buildbot@x064:[/home/buildbot]ls -l /etc/*vac*
-rw-r--r--    1 bin  bin   37731 Aug 02 2018  /etc/vac.cfg.53
-rw-r--r--    1 bin  bin   39672 Aug 02 2018  /etc/vac.cfg.61
-rw-r--r--    1 bin  bin   39681 Aug 02 2018  /etc/vac.cfg.71
-rw-r--r--    1 bin  bin   39611 Aug 02 2018  /etc/vac.cfg.72

Herein I see that xlc is "extc99" and some extras:

* -qlanglvl=extc99 C compiler with common extensions, UNIX headers
xlc:    use    = DEFLT_C
    crt    = /lib/crt0.o
    mcrt   = /lib/mcrt0.o
    gcrt   = /lib/gcrt0.o
    libraries  = -L/usr/vac/lib,-lxlopt,-lxlipa,-lxl,-lc
    proflibs   = -L/lib/profiled,-L/usr/lib/profiled
    options    =
-qlanglvl=extc99,-qcpluscmt,-qkeyword=inline,-qalias=ansi

I have chosen the xlc_r variant - for thread_safe additions:

* standard c compiler aliased as xlc_r (61 Threads)
xlc_r:  use    = DEFLT_C
    crt    = /lib/crt0.o
    mcrt   = /lib/mcrt0.o
    gcrt   = /lib/gcrt0.o
    libraries  = -L/usr/vac/lib,-lxlopt,-lxlipa,-lxl,-lpthreads,-lc
    proflibs   = -L/lib/profiled,-L/usr/lib/profiled
    hdlibs = -L/usr/vac/lib,-lhmd
    options    =
-qlanglvl=extc99,-qcpluscmt,-qkeyword=inline,-qalias=ansi,-qthreaded,-D_THREAD_SAFE,-D__VACPP_MULTI__

So, what is c99 then? -> focus on it is 'stdc99' rather than 'extc99'

* Strict ANSI compiler, ANSI headers
c99:    use    = DEFLT_C
    crt    = /lib/crt0.o
    mcrt   = /lib/mcrt0.o
    gcrt   = /lib/gcrt0.o
    libraries  = -L/usr/vac/lib,-lxlopt,-lxlipa,-lxl,-lc
    proflibs   = -L/lib/profiled,-L/usr/lib/profiled
    options    =
-qlanglvl=stdc99,-D_ANSI_C_SOURCE,-D_ISOC99_SOURCE,-qalias=ansi,-qstrict_induction

Hope this helps clarify that both xlc and c99 are "c99" based.

Regards,

Michael

On 05/06/2020 21:34, Stefan Krah wrote:
> New submission from Stefan Krah :
>
> There appears to be an xlc buildbot with libmpdec failures.
>
> libmpdec uses C99 extern inline semantics. From the brief period that I had 
> access to xlc I remember that xlc was quite picky about C99.
>
> Actually all of Python uses C99. So I think xlc_r needs to be invoked as 
> c99_r.
>
> --
> messages: 370779
> nosy: Michael.Felt, skrah
> priority: normal
> severity: normal
> status: open
> title: Use c99 on the aixtools bot
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40878] Use c99 on the aixtools bot

[Stefan Krah]

New submission from Stefan Krah :

There appears to be an xlc buildbot with libmpdec failures.

libmpdec uses C99 extern inline semantics. From the brief period that I had 
access to xlc I remember that xlc was quite picky about C99.

Actually all of Python uses C99. So I think xlc_r needs to be invoked as c99_r.

--
messages: 370779
nosy: Michael.Felt, skrah
priority: normal
severity: normal
status: open
title: Use c99 on the aixtools bot

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com