[issue36747] Tools/scripts/setup.py is missing

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36747] Tools/scripts/setup.py is missing

2019-04-29 Thread Xavier de Gaye


Xavier de Gaye  added the comment:

Agreed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36750] test_socket failed (env changed) on Azure pipeline

2019-04-29 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

> issue35092 reported by Victor closed as duplicate of issue23828

Sorry, it was reported by Pablo in issue35092. I haven't seen any old reports 
of this in search. The other buildbots on Ubuntu run fine so not sure if it's 
only for Azure and Ubuntu for the PR since master is green on Azure and the 
buildbots so feel free to close this if needed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36747] Tools/scripts/setup.py is missing

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

The broken scriptsinstall Makefile target of Python 3.7 doesn't hurt. I suggest 
to leave it, it's not used by any other target. I prefer to not backport the 
change just to avoid any risk of regression.

Thanks Xavier for the fix.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread Utkarsh Gupta


Change by Utkarsh Gupta :


--
keywords: +patch
pull_requests: +12929
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36747] Tools/scripts/setup.py is missing

2019-04-29 Thread Xavier de Gaye


Change by Xavier de Gaye :


--
keywords: +patch
pull_requests: +12924
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset b36e5d627d4232a01850707eb78a5067f3fd77f4 by Victor Stinner in 
branch 'master':
bpo-36356: Destroy the GIL at exit (GH-12453)
https://github.com/python/cpython/commit/b36e5d627d4232a01850707eb78a5067f3fd77f4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36475] PyEval_AcquireLock() and PyEval_AcquireThread() do not handle runtime finalization properly.

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

Oh. test_daemon_threads_shutdown_stdout_deadlock of test_io fails randomly on 
buildbots.

I ran "./python -m test test_io -m '*daemon*' -F -j4" for 5 minutes on my 
Fedora 29 before merging my PR, but I didn't get any failure :-(

==
FAIL: test_daemon_threads_shutdown_stdout_deadlock (test.test_io.CMiscIOTest)
--
Traceback (most recent call last):
  File 
"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_io.py", 
line 4186, in test_daemon_threads_shutdown_stdout_deadlock
self.check_daemon_threads_shutdown_deadlock('stdout')
  File 
"/home/dje/cpython-buildarea/3.x.edelsohn-rhel-z/build/Lib/test/test_io.py", 
line 4177, in check_daemon_threads_shutdown_deadlock
self.assertIn("Fatal Python error: could not acquire lock "
AssertionError: "Fatal Python error: could not acquire lock for 
<_io.BufferedWriter name=''> at interpreter shutdown, possibly due to 
daemon threads" not found in 'Fatal Python error: 
PyCOND_FINI(_PyRuntime.ceval.gil.cond) failed'

Failures:

AMD64 Fedora Rawhide Clang Installed 3.x: fail then pass
https://buildbot.python.org/all/#/builders/188/builds/93

s390x Debian 3.x: fail then pass
https://buildbot.python.org/all/#/builders/13/builds/2799

s390x RHEL 3.x: fail twice
https://buildbot.python.org/all/#/builders/21/builds/2780

AMD64 Debian root 3.x: fail twice
https://buildbot.python.org/all/#/builders/27/builds/2759

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread Xavier de Gaye


Change by Xavier de Gaye :


--
keywords: +patch
pull_requests: +12928
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 99fcc616d400cd31af0733c3f8cc93bcc1d32a44 by Victor Stinner in 
branch 'master':
Revert "bpo-36356: Destroy the GIL at exit (GH-12453)" (GH613006)
https://github.com/python/cpython/commit/99fcc616d400cd31af0733c3f8cc93bcc1d32a44


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

I just reverted the change. I'm unable to reproduce and I am not available this 
week to investigate anyway.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36750] test_socket failed (env changed) on Azure pipeline

2019-04-29 Thread Karthikeyan Singaravelan

New submission from Karthikeyan Singaravelan :

This PR https://github.com/python/cpython/pull/12271 has consistent build 
failures in test_socket even after merging the master branch.

Sample build failure : 
https://dev.azure.com/Python/cpython/_build/results?buildId=41411

I tried reproducing this and I can't reproduce it in Ubuntu. Mac OS seems to 
fail with leaked references which I think is unrelated to the above Azure 
failure. The Mac issue is open (issue35092 reported by Victor closed as 
duplicate of issue23828) but it was about warning though running with regrtest 
seems to leak references in addition to warnings.

Ubuntu build : 

karthi@ubuntu-s-1vcpu-1gb-blr1-01:~/cpython$ ./python -m test -R 3:3 test_socket
Run tests sequentially
0:00:00 load avg: 0.01 [1/1] test_socket
beginning 6 repetitions
123456
..
test_socket passed in 3 min 7 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 3 min 7 sec
Tests result: SUCCESS

Mac OS build (Mac OS 10.10.4 (14E46))

➜  cpython git:(master) ./python.exe -m test -R 3:3 test_socket
Run tests sequentially
0:00:00 load avg: 2.00 [1/1] test_socket
beginning 6 repetitions
123456
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2419:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg(bufsize, *args)
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2510:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg_into([buf], *args)
./Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2419:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg(bufsize, *args)
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2510:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg_into([buf], *args)
./Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2419:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg(bufsize, *args)
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2510:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg_into([buf], *args)
./Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2419:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg(bufsize, *args)
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2510:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg_into([buf], *args)
./Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2419:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg(bufsize, *args)
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2510:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg_into([buf], *args)
./Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2419:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg(bufsize, *args)
/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_socket.py:2510:
 RuntimeWarning: received malformed or improperly-truncated ancillary data
  result = sock.recvmsg_into([buf], *args)
.
test_socket leaked [20, 20, 20] file descriptors, sum=60
test_socket failed in 2 min 31 sec

== Tests result: FAILURE ==

1 test failed:
test_socket

Total duration: 2 min 31 sec
Tests result: FAILURE

--
components: Library (Lib)
messages: 341052
nosy: giampaolo.rodola, vstinner, xtreak
priority: normal
severity: normal
status: open
title: test_socket failed (env changed) on Azure pipeline
type: behavior
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36749] PPC64 AIX 3.x: compilation issue, linker fails to locate symbols

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

David Bolen: Oops, right, I was looking for David Edelsohn :-)

David Edelsohn: Are you able to reproduce this issue? If yes, would you mind to 
test my PR 13004 to validate that it fix the issue?

--
nosy: +David.Edelsohn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +12927
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21536] extension built with a shared python cannot be loaded with a static python

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 254b309c801f82509597e3d7d4be56885ef94c11 by Victor Stinner 
(xdegaye) in branch 'master':
 bpo-21536: On Android, C extensions are linked to libpython (GH-12989)
https://github.com/python/cpython/commit/254b309c801f82509597e3d7d4be56885ef94c11


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36475] PyEval_AcquireLock() and PyEval_AcquireThread() do not handle runtime finalization properly.

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

I am not comfortable to backport this change to Python 3.7. It's too early to 
know how it will impact applications and how many complains we will get :-) If 
someone really wants to backport this scary change to 3.7, I would suggest to 
wait for 1 month after Python 3.8.0 final release.

I close the issue.

See bpo-36479 for the follow-up.

--
versions: +Python 3.6 -Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36602] Recursive directory list with pathlib.Path.iterdir

2019-04-29 Thread Laurie Opperman


Laurie Opperman  added the comment:

I've updated the pull-request to list directories pointed to by listed symbolic 
links, preventing cyclic listing. An extra instance method 
`pathlib.Path._iterdir_recursive` was added for this.

We still need to decide whether to yield the directories themselves rather than 
just the files under those directories. Very easy to implement this.

One thing I just realised is that a symlink can point to a subdirectory further 
down the chain. The current implementation will list the files under that 
directory using the symlink as prefix rather than the full path. Shouldn't 
matter though.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36475] PyEval_AcquireLock() and PyEval_AcquireThread() do not handle runtime finalization properly.

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset f781d202a2382731b43bade845a58d28a02e9ea1 by Victor Stinner 
(Joannah Nanjekye) in branch 'master':
bpo-36475: Finalize PyEval_AcquireLock() and PyEval_AcquireThread() properly 
(GH-12667)
https://github.com/python/cpython/commit/f781d202a2382731b43bade845a58d28a02e9ea1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36750] test_socket leaks file descriptors on macOS

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
nosy: +pablogsal
title: test_socket failed (env changed) on Azure pipeline -> test_socket leaks 
file descriptors on macOS

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13611] Integrate ElementC14N module into xml.etree package

2019-04-29 Thread Stefan Behnel


Stefan Behnel  added the comment:

Playing around with it a bit more, I ended up changing the interface of the 
canonicalize() function to return its output as a string by default. It's 
really nice to be able to say

c14n_xml = canonicalize(plain_xml)

To write to a file, you now do this:

  with open("c14n_output.xml", mode='w', encoding='utf-8') as out_file:
  canonicalize(xml_data, out=out_file)

and to read from a file:

  canonicalize(from_file=fileobj)

I think that nicely handles all use cases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36749] PPC64 AIX 3.x: compilation issue, linker fails to locate symbols

2019-04-29 Thread STINNER Victor


New submission from STINNER Victor :

First failure:
https://buildbot.python.org/all/#/builders/10/builds/2507

Running the test suite fails with "ModuleNotFoundError: No module named 
'_socket'".

Example of (dynamic) linker issue:

*** WARNING: renaming "_socket" since importing it failed:  0509-130 Symbol 
resolution failed for build/lib.aix-7.2-3.8-pydebug/_socket.so because:
0509-136   Symbol PyCapsule_New (number 8) is not exported from
   dependent module python.
0509-136   Symbol PyErr_CheckSignals (number 9) is not exported from
   dependent module python.
0509-136   Symbol PyErr_Clear (number 10) is not exported from
   dependent module python.
0509-136   Symbol PyErr_ExceptionMatches (number 11) is not exported 
from
   dependent module python.
0509-136   Symbol PyErr_Fetch (number 12) is not exported from
   dependent module python.
0509-136   Symbol PyErr_Format (number 13) is not exported from
   dependent module python.
0509-021 Additional errors occurred but are not reported.
0509-192 Examine .loader section symbols with the
 'dump -Tv' command.

IMHO it's a regression caused by my commit 
8c3ecc6bacc8d0cd534f2b5b53ed962dd1368c7b for bpo-21536. I guess that

--
components: Build
messages: 341049
nosy: vstinner
priority: normal
severity: normal
status: open
title: PPC64 AIX 3.x: compilation issue, linker fails to locate symbols
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36749] PPC64 AIX 3.x: compilation issue, linker fails to locate symbols

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
keywords: +patch
pull_requests: +12925
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36729] Delete unused text variable on tests

2019-04-29 Thread Serhiy Storchaka


Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24048] remove_module() needs to save/restore exception state

2019-04-29 Thread Zackery Spytz


Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +12926
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread Xavier de Gaye


Xavier de Gaye  added the comment:

Attached pythoninfo_api_24.txt, the output of pythoninfo for Android API 24 
with PR 13007.

--
nosy: +vstinner
Added file: https://bugs.python.org/file48290/pythoninfo_api_24.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34155] email.utils.parseaddr mistakenly parse an email

2019-04-29 Thread Dain Dwarf


Dain Dwarf  added the comment:

Hello, kind of new here.

I just wanted to note that the issue that lead to Tchap's security attack still 
exists in the non-deprecated message_from_string function:

email.message_from_string('From: a...@malicious.org@important.com', 
policy=email.policy.default)['from'].addresses

(Address(display_name='', username='a', domain='malicious.org'),)

So, deprecating parseaddr is not enough for security purpose, unless there is 
another ticket for the new email API.

--
nosy: +Dain Dwarf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36356] Failure to build with address sanitizer

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

The initial issue has been fixed, so I close the issue. I prefer to get more 
specific issues like bpo-36724 "Clear _PyRuntime at exit" to following changes.

Thanks Ben Harper for the bug report and the fix.

Note: Ben, I like your songs! Good to know that you chose to contribute to 
Python in your free time! ;-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

FYI I modified Python 3.8 to never link C extensions to libpython on Unix 
(except on Android): bpo-21536, but with a different rationale (better reasons 
to do so).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36479] Exit threads when interpreter is finalizing rather than runtime.

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36749] PPC64 AIX 3.x: compilation issue, linker fails to locate symbols

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

Oh, that's strange now. The following build succeeded!
https://buildbot.python.org/all/#/builders/10/builds/2508

I don't understand why this buildbot runs builds on commits which are now 1 
month old.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35329] Documentation - capitalization issue

2019-04-29 Thread Utkarsh Gupta


Utkarsh Gupta  added the comment:

Hey,

I'd be happy to submit one :)

--
nosy: +utkarsh2102

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36749] PPC64 AIX 3.x: compilation issue, linker fails to locate symbols

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

David, Michael: Is one of you able to reproduce this issue? If yes, would you 
mind to test my PR 13004 to validate that it fix the issue?

Michael: Your useername "aixto...@gmail.com" on bugs.python.org is surprising. 
Maybe you should strip "@gmail.com" from it.

--
nosy: +aixto...@gmail.com, db3l

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36749] PPC64 AIX 3.x: compilation issue, linker fails to locate symbols

2019-04-29 Thread David Bolen


David Bolen  added the comment:

I think I'm the wrong David for this...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36747] Tools/scripts/setup.py is missing

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 7a5a1cfe04892351bba8e8d7d21ae2262fa35b67 by Victor Stinner 
(xdegaye) in branch 'master':
bpo-36747: Remove the stale scriptsinstall Makefile target (GH-13003)
https://github.com/python/cpython/commit/7a5a1cfe04892351bba8e8d7d21ae2262fa35b67


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24048] remove_module() needs to save/restore exception state

2019-04-29 Thread Zackery Spytz


Zackery Spytz  added the comment:

I've created a PR for this issue.

--
nosy: +ZackerySpytz
versions: +Python 3.7, Python 3.8 -Python 3.2, Python 3.3, Python 3.4, Python 
3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35907] Unnecessary URL scheme exists to allow file:// reading file in urllib

2019-04-29 Thread Charalampos Stratakis


Change by Charalampos Stratakis :


--
nosy: +cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36748] Optimize textio write buffering

2019-04-29 Thread Inada Naoki


New submission from Inada Naoki :

textio uses list of textio for internal buffering.  There are two inefficiency:

* When textio is line buffered and all written strings are line (it's very 
common), list object is allocated and freed.
* We convert texts into bytes, and call b''.join(list_of_bytes).  But when 
texts are ASCII and codecs are ASCII-compat, we can skip temporary bytes 
objects.

Attached patch is benchmark for buffered and line buffered write.

Faster (6):
- write_ascii_32k: 101 ns +- 1 ns -> 73.1 ns +- 0.4 ns: 1.39x faster (-28%)
- write_ascii_8k: 102 ns +- 1 ns -> 73.4 ns +- 0.4 ns: 1.38x faster (-28%)
- write_ascii_linebuffered: 815 ns +- 12 ns -> 731 ns +- 3 ns: 1.12x faster 
(-10%)
- write_unicode_linebuffered: 840 ns +- 11 ns -> 789 ns +- 15 ns: 1.06x faster 
(-6%)
- write_unicode_8k: 124 ns +- 1 ns -> 122 ns +- 1 ns: 1.01x faster (-1%)
- write_unicode_32k: 124 ns +- 1 ns -> 122 ns +- 1 ns: 1.01x faster (-1%)

--
components: IO
files: bm_textio.py
messages: 341044
nosy: inada.naoki
priority: normal
severity: normal
status: open
title: Optimize textio write buffering
type: performance
versions: Python 3.8
Added file: https://bugs.python.org/file48289/bm_textio.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36748] Optimize textio write buffering

2019-04-29 Thread Inada Naoki


Change by Inada Naoki :


--
keywords: +patch
pull_requests: +12923
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Raúl Núñez de Arenas

Raúl Núñez de Arenas  added the comment:

Hi Steve :) I assumed that the issue was solved, that's why I warned, in case a 
patch was applied and it didn't work.

When I did read "I suggest to only call reformat_strerror() when an user 
complains", I supposed a patch was ready O:)

No big deal, I can deal with that particular error in my code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Opened https://bugs.python.org/issue36751 to track changes in the inspect 
module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +12930

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21536] extension built with a shared python cannot be loaded with a static python

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset a86e06433a010f873dfd7957e0f87a39539876ee by Victor Stinner 
(xdegaye) in branch 'master':
bpo-35952: Fix test.pythoninfo when the compiler is missing (GH-13007)
https://github.com/python/cpython/commit/a86e06433a010f873dfd7957e0f87a39539876ee


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
pull_requests: +12931

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2019-04-29 Thread reimar


reimar  added the comment:

> In short, RTLD_LOCAL is not supported.

I am sorry, this is not a workable stance.
This does not just affect loading libpython directly.
It also affects dlopen of a library that links to a library ... that links to 
libpython.
For a developer is impossible to know if some library via dozens of 
dependencies might ever bring in libpython.
Thus your stance is essentially equivalent to "nobody must ever use 
RTLD_LOCAL". I find it hard to consider that an acceptable "solution".

--
nosy: +reimar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Raúl Núñez de Arenas

Raúl Núñez de Arenas  added the comment:

I'm sorry to say that this still happens in Python 3.7.0...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
priority: release blocker -> high

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36752] test multiprocessing: test_rapid_restart() crash on AIX

2019-04-29 Thread STINNER Victor


New submission from STINNER Victor :

POWER6 AIX 3.x:
https://buildbot.python.org/all/#/builders/161/builds/1050

==
ERROR: test_rapid_restart 
(test.test_multiprocessing_forkserver.WithManagerTestManagerRestart)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2872, in test_rapid_restart
queue = manager.get_queue()
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 737, in temp
token, exp = self._create(typeid, *args, **kwds)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 620, in _create
conn = self._Client(self._address, authkey=self._authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 796, in XmlClient
return ConnectionWrapper(Client(*args, **kwds), _xml_dumps, _xml_loads)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 502, in Client
c = SocketClient(address)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 629, in SocketClient
s.connect(address)
ConnectionRefusedError: [Errno 79] Connection refused

==
ERROR: test_remote 
(test.test_multiprocessing_forkserver.WithManagerTestRemoteManager)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2835, in test_remote
manager2.connect()
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 545, in connect
conn = Client(self._address, authkey=self._authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 796, in XmlClient
return ConnectionWrapper(Client(*args, **kwds), _xml_dumps, _xml_loads)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 508, in Client
answer_challenge(c, authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 751, in answer_challenge
message = connection.recv_bytes(256) # reject large message
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 216, in recv_bytes
buf = self._recv_bytes(maxlength)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 414, in _recv_bytes
buf = self._recv(4)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 379, in _recv
chunk = read(handle, remaining)
ConnectionResetError: [Errno 73] Connection reset by peer

==
ERROR: test_rapid_restart 
(test.test_multiprocessing_forkserver.WithProcessesTestManagerRestart)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2872, in test_rapid_restart
queue = manager.get_queue()
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 737, in temp
token, exp = self._create(typeid, *args, **kwds)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/managers.py",
 line 620, in _create
conn = self._Client(self._address, authkey=self._authkey)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 796, in XmlClient
return ConnectionWrapper(Client(*args, **kwds), _xml_dumps, _xml_loads)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 502, in Client
c = SocketClient(address)
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/multiprocessing/connection.py",
 line 629, in SocketClient
s.connect(address)
ConnectionRefusedError: [Errno 79] Connection refused

==
ERROR: test_rapid_restart 
(test.test_multiprocessing_forkserver.WithThreadsTestManagerRestart)
--
Traceback (most recent call last):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/_test_multiprocessing.py",
 line 2872, in test_rapid_restart
queue = manager.get_queue()
  File 

[issue36004] Add datetime.fromisocalendar

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 88c093705615c50c47fdd9ab976803f73de7e308 by Victor Stinner (Paul 
Ganssle) in branch 'master':
bpo-36004: Add date.fromisocalendar (GH-11888)
https://github.com/python/cpython/commit/88c093705615c50c47fdd9ab976803f73de7e308


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21536] extension built with a shared python cannot be loaded with a static python

2019-04-29 Thread reimar


reimar  added the comment:

As explained in Issue34814, this change not only breaks RTLD_LOCAL of 
libpython, but it breaks it in fact system-wide.
It seems a bit much for Python to enforce a system-wide policy to not use 
RTLD_LOCAL just because of its own technical challenges, and thus I'd ask to 
reconsider the original change.

--
nosy: +reimar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34214] Pylint recusion stack overflow abort

2019-04-29 Thread Joannah Nanjekye


Change by Joannah Nanjekye :


--
nosy: +eric.smith, nanjekyejoannah, ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36742] urlsplit doesn't accept a NFKD hostname with a port number

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

Yes, it's due to that. I guess we need to do netloc.rpartition(':') like we 
currently do for '@' in _checknetloc.

Promoting to release blocker and security issue to match the original issue. I 
can't get to this today, but I should be able to at the PyCon sprints next week 
if nobody else gets it sooner.

--
keywords: +3.5regression, 3.6regression, 3.7regression
nosy: +benjamin.peterson, larry, lukasz.langa, ned.deily
priority: normal -> release blocker
type: behavior -> security
versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Pablo Galindo Salgado


New submission from Pablo Galindo Salgado :

This issue is to discuss how to handle the changes in the inspect module for 
PEP 570. In particular, how to handle:

* getfullargspec
* formatargspec

for positional-only parameters.

--
components: Interpreter Core
messages: 341070
nosy: pablogsal, serhiy.storchaka, vstinner
priority: normal
severity: normal
status: open
title: Changes in the inspect module for PEP 570
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

The implementation has been merged, so I will remove the "release blocker". We 
are still missing the documentation and the final changes to the inspect module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

Context: see https://github.com/python/cpython/pull/12701 discussion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset be6cbfb7670c852ef8abf52b63989442b6942dbb by Victor Stinner in 
branch '2.7':
bpo-35952: Sync test.pythoninfo from master (GH-13010)
https://github.com/python/cpython/commit/be6cbfb7670c852ef8abf52b63989442b6942dbb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35952] test.pythoninfo prints a stack trace and exits with 1 when the compiler does not exist

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset 5e09a9973b46cd6361a25877e0ca8dd0ab82d678 by Victor Stinner in 
branch '3.7':
bpo-35952: Sync test.pythoninfo from master (GH-13009)
https://github.com/python/cpython/commit/5e09a9973b46cd6361a25877e0ca8dd0ab82d678


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

> In short, RTLD_LOCAL is not supported.

reimar: "I am sorry, this is not a workable stance. This does not just affect 
loading libpython directly. (...)"

This issue is now closed, as bpo-21536. Would you mind to open a new issuse to 
clearly explain your own case? Please mention your platform.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36729] Delete unused text variable on tests

2019-04-29 Thread Emmanuel Arias

Emmanuel Arias  added the comment:

Hello,

Yes not problem. Tonight when I was just to make the MR, I see that the
bugs was solved.

Thanks

Arias Emmanuel
eamanu.com

El lun., 29 de abr. de 2019 05:10, Serhiy Storchaka 
escribió:

>
> Change by Serhiy Storchaka :
>
>
> --
> resolution:  -> fixed
> stage: patch review -> resolved
> status: open -> closed
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36729] Delete unused text variable on tests

2019-04-29 Thread Emmanuel Arias

Emmanuel Arias  added the comment:

Sorry for the noise I confused on my mail.

Arias Emmanuel
eamanu.com

El lun., 29 de abr. de 2019 11:46, Emmanuel Arias 
escribió:

>
> Emmanuel Arias  added the comment:
>
> Hello,
>
> Yes not problem. Tonight when I was just to make the MR, I see that the
> bugs was solved.
>
> Thanks
>
> Arias Emmanuel
> eamanu.com
>
> El lun., 29 de abr. de 2019 05:10, Serhiy Storchaka <
> rep...@bugs.python.org>
> escribió:
>
> >
> > Change by Serhiy Storchaka :
> >
> >
> > --
> > resolution:  -> fixed
> > stage: patch review -> resolved
> > status: open -> closed
> >
> > ___
> > Python tracker 
> > 
> > ___
> >
>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

It still happens because nobody has proposed a patch to specially handle this 
one particular error code. The earlier messages explained why we can't do 
formatting on error messages.

If this one is particularly common, then it's best for it to be handled in 
Python code at the point where it shows up and converted into something more 
readable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36540] PEP 570: Python Positional-Only Parameters

2019-04-29 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 8c77b8cb9188165a123f2512026e3629bf03dc9b by Pablo Galindo in 
branch 'master':
bpo-36540: PEP 570 -- Implementation (GH-12701)
https://github.com/python/cpython/commit/8c77b8cb9188165a123f2512026e3629bf03dc9b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Change by Steve Dower :


--
nosy:  -steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

My bad, there were PR changes that GitHub didn't show me. As you were

--
nosy:  -lukasz.langa
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

Nope, I was right the first time. The FullArgSpec tulle has changed indexes, 
and formatargspec has additional (undocumented) arguments.

Since formatargspec is deprecated, it should probably just not change.

The FullArgSpec tuple might have to become a concrete class implementation so 
that it can have positional-only args as a named attribute but not part of 
unpacking.

As for where the new information *can* go, I suspect the Signature object is 
the only place. Though that has limitations, and for C APIs in particular much 
of my code only uses the more reliable getfullargspec.

--
nosy: +lukasz.langa, steve.dower
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34155] email.utils.parseaddr mistakenly parse an email

2019-04-29 Thread Jakub Wilk


Change by Jakub Wilk :


--
nosy:  -jwilk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36004] Add datetime.fromisocalendar

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

Thanks Paul, nice enhancement!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

Marking as a release blocker and adding RM. The 3.8 branch now contains 
breaking API changes to these functions that we have to resolve before the next 
release (or revert while deciding how to handle the change) - PR 12701 has been 
merged.

--
keywords: +3.7regression
nosy: +lukasz.langa, steve.dower
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1613500] Write mode option for fileinput module.

2019-04-29 Thread Berker Peksag


Berker Peksag  added the comment:


New changeset be6dbfb43b89989ccc83fbc4c5234f50f44c47ad by Berker Peksag in 
branch 'master':
bpo-1613500: Don't hardcode output file mode in fileinput.FileInput (GH-12986)
https://github.com/python/cpython/commit/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1613500] Write mode option for fileinput module.

2019-04-29 Thread Berker Peksag


Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread Ned Deily


Change by Ned Deily :


--
assignee:  -> vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Karthikeyan Singaravelan


Change by Karthikeyan Singaravelan :


--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread miss-islington


miss-islington  added the comment:


New changeset 52a5b71063af68c42b048095c4e555e93257f151 by Miss Islington (bot) 
in branch '3.7':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/52a5b71063af68c42b048095c4e555e93257f151


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread Matthias Klose


Matthias Klose  added the comment:

why is this an issue on Debian? Debian is already not linking with libpython.

--
nosy: +doko

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

About the PEP, I asked Barry to review the change and he approved it.

About the doc, I didn't know that anyone rely on the exact filename. I 
documented all changes in a top-level section of the What's New in Python 3.8:
https://docs.python.org/dev/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build

Sorry for thr annoyance. I didn't know that the macOS installer rely on these 
filenames.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36754] Remove smart quotes in pydoc text

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

> mismatch in encodings

Also likely. I haven't looked into how pydoc does its rendering, but certainly 
Python 3.7 on Windows should be able to print regular Unicode.

Perhaps it's not going through stdout for some reason?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread miss-islington


miss-islington  added the comment:


New changeset 52a5b71063af68c42b048095c4e555e93257f151 by Miss Islington (bot) 
in branch '3.7':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/52a5b71063af68c42b048095c4e555e93257f151


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread reimar


reimar  added the comment:

The modules not linking against libpython CAUSES this issue, thus Debian being 
affected even for old Python versions before issue21536.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28608] Support creating hardlink using `pathlib`

2019-04-29 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

Closing this as a duplicate of issue26978 which has an open PR with comments 
from @pitrou.

Thanks

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Implement pathlib.Path.link (Using os.link)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread Ned Deily


Change by Ned Deily :


--
pull_requests: +12933

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Brett Cannon


Brett Cannon  added the comment:

If I remember correctly the un-deprecation was because 2/3 code could only use 
getfullargspec() to get all relevant details. Since we're so close to being 
done w/ Python 2 I think this might be the last change to make to them, 
document their deprecation, tack this info on to the end of the tuple, and then 
start raising DeprecationWarning in 3.9.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36754] Remove smart quotes in pydoc text

2019-04-29 Thread Steven D'Aprano

Steven D'Aprano  added the comment:

> Not all console configurations can correctly render smart quotes in 
> help() text. See the "Æ" in "superclass's" below.

That suggests to me a mismatch in encodings, rather than inability to 
render curly quotes at all. It's 2019 and surely we don't have to target 
ASCII as the lowest common denominator any more?

--
nosy: +steven.daprano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread Ned Deily


Change by Ned Deily :


--
keywords: +patch
pull_requests: +12932
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:


New changeset 883dfc668f9730b00928730035b5dbd24b9da2a0 by Ned Deily in branch 
'master':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/883dfc668f9730b00928730035b5dbd24b9da2a0


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:


New changeset 883dfc668f9730b00928730035b5dbd24b9da2a0 by Ned Deily in branch 
'master':
bpo-34602: Avoid failures setting macOS stack resource limit (GH-13011)
https://github.com/python/cpython/commit/883dfc668f9730b00928730035b5dbd24b9da2a0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34602] python3 resource.setrlimit strange behaviour under macOS

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12934

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18075] Infinite recursion tests triggering a segfault

2019-04-29 Thread miss-islington


Change by miss-islington :


--
pull_requests: +12935

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36707] The "m" ABI flag of SOABI for pymalloc is no longer needed

2019-04-29 Thread Ned Deily


Ned Deily  added the comment:

This change has an impact on downstream packagers and users of Python 3.8 
because the SOABI flag values are also used to construct a number of file names 
and directories names in an Unix or macOS framework install besides the 
extension module (*.so) file names.  Suggest comparing the directory/file names 
installed to an alternate prefix (./configure --prefix=/tmp/3x ; make install) 
in 3.7 versus master with this PR.  Also suggest reading PEP 3149, which 
introduced the ABI-specific file names, and the various issues in the bug 
tracker that reference it.  At the very least, these changes need to be 
documented in the What's New for 3.8.  But the impact of the change should 
probably also be discussed with at least some of the large distributors.  (The 
change already inadvertently broke the macOS installer build - fixing.)

--
nosy: +ned.deily
priority: normal -> deferred blocker
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread STINNER Victor


STINNER Victor  added the comment:

IMHO getargs(), getargspec(), getfullargspec() should be deprecated in favor of 
signature() which is future-proof. But Nick Coghlan undeprecated these 
functions in 2017 https://bugs.python.org/issue20438 whereas these were 
deprecated since 2015. I didn't understand the subtle issues. That's why I 
asked Pablo to open a separated issue, to get Nick and others involved to get 
the context.

My proposal was to raise an exception if the input function has positonal 
arguments. There is good way to fix these legacy functions, their design cannot 
be extended, whereas signature() is fine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36754] Remove smart quotes in pydoc text

2019-04-29 Thread Steve Dower

New submission from Steve Dower :

Not all console configurations can correctly render smart quotes in help() 
text. See the "Æ" in "superclass's" below.

When building for pydoc-topics, it would be ideal to disable smart quotes. (I'm 
assuming from issue31793 that this can be done in configuration, though I'm not 
entirely sure how - it's not clear to me from those PRs)

---

>>> help("BASICMETHODS")
Basic customization
***

object.__new__(cls[, ...])
...
   Typical implementations create a new instance of the class by
   invoking the superclassÆs "__new__()" method using
   "super().__new__(cls[, ...])" with appropriate arguments and then
   modifying the newly-created instance as necessary before returning
   it.

--
assignee: docs@python
components: Documentation
messages: 341107
nosy: docs@python, steve.dower
priority: normal
severity: normal
stage: needs patch
status: open
title: Remove smart quotes in pydoc text
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18748] io.IOBase destructor silence I/O error on close() by default

2019-04-29 Thread Karthikeyan Singaravelan


Karthikeyan Singaravelan  added the comment:

The ValueError warnings in test_urllib noted in msg340059  feels like an issue 
with the test where FakeSocket calls close by itself once it's internal io_refs 
counter is 0 and during destructor again close is called on an already closed 
object causing the ValueError.

* The test uses fakehttp() creating FakeSocket starting with io_refs as 1 [1]
* During the test in urlopen, sock.makefile() (io_refs += 1) is called 
increasing the io_refs to be 2.
* HTTPConnection.close calls sock.close (fakesocket.close) [3] calling io_refs 
-= 1 and to fakesocket.io_ref to be 1.
* This test uses raises status 302 with http_error_302 which calls 
self.redirect_internal where self.close is again called causing fp.io_refs == 0 
and subsequently calling io.BytesIO.close(self) to close the object. [4]
* During the end of the test destructor is called on the above closed 
fakesocket object and trying to flush on a closed object causes the ValueError 
warnings .

Maybe a check could be added during flush to make sure the object is not closed 
by testing for self.closed but I am not sure if closed attribute is guaranteed 
to be present. Removing the manual call to close in fakesocket could help since 
the destructor should be taking care of it and I could see no test failures or 
warnings removing the close as io_refs gets to 0.

[1] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/test/test_urllib.py#L61
[2] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/test/test_urllib.py#L67
[3] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/http/client.py#L919
[4] 
https://github.com/python/cpython/blob/be6dbfb43b89989ccc83fbc4c5234f50f44c47ad/Lib/urllib/request.py#L2145

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread Eric N. Vander Weele


Change by Eric N. Vander Weele :


--
nosy: +ericvw

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Brett Cannon


Brett Cannon  added the comment:

Steve's right that we can't change the indexes on those functions for 
pre-existing values, so appending to the end is the only real option in that 
case. I still think they should both be deprecated due to how limiting their 
APIs are.

Obviously signature() can be updated cleanly.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36751] Changes in the inspect module for PEP 570

2019-04-29 Thread Steve Dower


Steve Dower  added the comment:

> My proposal was to raise an exception if the input function has positonal 
> arguments

Counter-proposal - just report them as regular position-or-name arguments.

Users of inspect are most likely to be IDEs or editors getting information to 
present to users. And in my experience, most just ignore all exceptions because 
bugs cause some function objects to raise errors when trying to inspect them. 
Which means a new exception will just result in a worse experience for users 
and no indication of what's wrong.

On the other hand, if there is no change made, they'll just report a normal 
looking signature until they migrate to using updated Signature objects. Anyone 
using current Signature objects should similarly get the argument count right, 
even if they totally ignore the positional-only count. Since one of the 
arguments for supporting positional-only parameters is that they're for 
parameters that you'd never consider passing by name, but these tools still 
need to show a name, very few people should ever be tripped up by them being 
misreported. And when they do they'll be tripped up very quickly.

Basically, this is not a scenario that *requires* existing users to be broken. 
So we should avoid breaking them at all costs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26493] Bad formatting in WinError 193 when using subprocess.check_call

2019-04-29 Thread Berker Peksag


Berker Peksag  added the comment:

FYI, in msg261315, Eryk has mentioned about possible improvement of the 
exception message on POSIX. The filename has been added to the exception 
message in 8621bb5d93239316f97281826461b85072ff6db7:

>>> import subprocess, os
>>> os.access('log.txt', os.X_OK)
True
>>> subprocess.call(['./log.txt'])
Traceback (most recent call last):
  File "", line 1, in 
  File "/Users/berkerpeksag/projects/cpython/Lib/subprocess.py", line 325, in 
call
with Popen(*popenargs, **kwargs) as p:
  File "/Users/berkerpeksag/projects/cpython/Lib/subprocess.py", line 830, in 
__init__
self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Users/berkerpeksag/projects/cpython/Lib/subprocess.py", line 1648, in 
_execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 8] Exec format error: './log.txt'

--
nosy: +berker.peksag
stage:  -> needs patch
versions: +Python 3.8 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

2019-04-29 Thread reimar


New submission from reimar :

Most affected platforms: RedHat and Debian, but with the changes from 
issue21536 probably all Linux distributions will be affected.

issue34814 and issue21536 and 
https://bugzilla.redhat.com/show_bug.cgi?id=1585201 make statements along the 
lines of "In short, RTLD_LOCAL is not supported."
This might have been considered a reasonable stance because of the specific 
example opening libpython directly.
However Python modules not linking to libpython also breaks things when 
libpython is loaded in the most indirect ways via dlopen.
E.g. dlopen("libA.so", RTLD_LOCAL | RTLD_NOW)
libA might have linked against libB, libB against libC and libC might 
optionally link against libpython.

As a developer generally cannot really know if some library might ever pull in 
a most indirect reference to libpython, not supporting RTLD_LOCAL in Python 
essentially means RTLD_LOCAL can NEVER EVER be used safely.

A test-case that will fail the import command when modules have not been linked 
against libpython is attached (demonstrating only one layer of indirection, but 
much more complex cases are of course possible).
You will need to adjust the (include, lib) paths in test.sh for your Python 
version, it was written to demonstrate the issue against RedHat's modifications 
of Python 2.7 (to my knowledge, RedHat and Debian has been affected by this 
issue much longer than mainline Python).

While dlmopen is an alternative with similar behaviour to RTLD_LOCAL on recent 
Linux versions for this case, it is not portable.

--
components: Library (Lib)
files: pytest.tar.gz
messages: 341094
nosy: reimar
priority: normal
severity: normal
status: open
title: Python modules not linking to libpython causes issues for RTLD_LOCAL 
system-wide
type: behavior
Added file: https://bugs.python.org/file48291/pytest.tar.gz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2019-04-29 Thread reimar


reimar  added the comment:

Sorry for my laziness. I opened Issue36753.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >