Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Victor Stinner
2018-05-14 16:41 GMT-04:00 Larry Hastings :
> Dr. Mark Shannon contributed the "key sharing dictionary" to Python, writing
> both the PEP and the implementation.  This shipped in Python 3.3 and was
> listed as one of the top features of that release as according to the
> "What's New?" document.
>
> We've asked Mark in the past if he'd be interested in becoming a core
> developer--and he actually said no.  At the time he said he didn't like our
> antiquated workflow.  Now that we've switched to the git-based core dev
> workflow, this objection is gone, and he's now interested in accepting the
> commit bit and the responsibilities that it entails.
>
> I suspect you, my colleagues in CPython core development, will be surprised
> at the current state of affairs.  I'm expecting a load of "you mean Mark
> *isn't* a core developer yet?" replies.

Wait. Mark is already a core dev, right? I don't understand your email :-)

+1, obvisouly.

Victor
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] AppVeyor and Travis-CI

2018-05-14 Thread Terry Reedy

On 5/14/2018 9:49 PM, Eric V. Smith wrote:
I accidentally checked in some test files, and they got backported to 
3.7. I pushed a commit to delete them, and it was committed to master.


But in the 3.7 backport, something has gone wrong with AppVeyor and 
Travis-CI.


https://github.com/python/cpython/pull/6844

AppVeyor says "Expected — Waiting for status to be reported". There's no 
obvious way to get it to actually report the status, or to restart. 
There is no "Details" button listed on the PR page.


For Travis-CI, Miss Isslington sent me an email that says "Backport 
status check is done, and it's a failure ❌ ." The Travis-CI log file 
ends with a timeout:


==
FAIL: test_stdin_broken_pipe 
(test.test_asyncio.test_subprocess.SubprocessSafeWatcherTests)

--
Traceback (most recent call last):
   File 
"/home/travis/build/python/cpython/Lib/test/test_asyncio/test_subprocess.py", 
line 214, in test_stdin_broken_pipe

     self.loop.run_until_complete, coro)
AssertionError: (, 'ConnectionResetError'>) not raised by run_until_complete

--

I'm sure this is all due to the heavy load the systems are under. I 
can't find a way to kick both of these off again. I couldn't find 
anything in the devguide, but if I missed it please let me know.


I have triggered retesting by editing the blurb.  It may be that 
touching by adding and deleting a space was enough, or maybe I had to 
actually change something.


But retesting right now, with tests failing, is useless.  I just 
submitting a trivial change and got the same unrelated failures for 
importlib, multiprocessing, and asyncio.


Warning -- files was modified by test_importlib
  Before: []
  After:  ['core']

ERROR: test_ignore (test.test_multiprocessing_forkserver.TestIgnoreEINTR)
--
Traceback (most recent call last):
  File 
"/home/travis/build/python/cpython/Lib/test/_test_multiprocessing.py", 
line 4359, in test_ignore

os.kill(p.pid, signal.SIGUSR1)
ProcessLookupError: [Errno 3] No such process
--
Ran 310 tests in 93.862s
FAILED (errors=1, skipped=27)
test test_multiprocessing_forkserver failed

and the same or similar multiple failures for asyncio

Both our tests ended with

FAILED (failures=2, skipped=14)
test test_asyncio failed
2 tests failed again:
test_asyncio test_multiprocessing_forkserver
Total duration: 14 min 29 sec
Tests result: FAILURE

and we cannot merge.

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


[python-committers] AppVeyor and Travis-CI

2018-05-14 Thread Eric V. Smith
I accidentally checked in some test files, and they got backported to 
3.7. I pushed a commit to delete them, and it was committed to master.


But in the 3.7 backport, something has gone wrong with AppVeyor and 
Travis-CI.


https://github.com/python/cpython/pull/6844

AppVeyor says "Expected — Waiting for status to be reported". There's no 
obvious way to get it to actually report the status, or to restart. 
There is no "Details" button listed on the PR page.


For Travis-CI, Miss Isslington sent me an email that says "Backport 
status check is done, and it's a failure ❌ ." The Travis-CI log file 
ends with a timeout:


==
FAIL: test_stdin_broken_pipe 
(test.test_asyncio.test_subprocess.SubprocessSafeWatcherTests)

--
Traceback (most recent call last):
  File 
"/home/travis/build/python/cpython/Lib/test/test_asyncio/test_subprocess.py", 
line 214, in test_stdin_broken_pipe

self.loop.run_until_complete, coro)
AssertionError: (, 'ConnectionResetError'>) not raised by run_until_complete

--

I'm sure this is all due to the heavy load the systems are under. I 
can't find a way to kick both of these off again. I couldn't find 
anything in the devguide, but if I missed it please let me know.


Thanks.
Eric
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Christian Heimes
On 2018-05-14 16:41, Larry Hastings wrote:
> 
> 
> Dr. Mark Shannon contributed the "key sharing dictionary" to Python,
> writing both the PEP and the implementation.  This shipped in Python 3.3
> and was listed as one of the top features of that release as according
> to the "What's New?" document.
> 
> We've asked Mark in the past if he'd be interested in becoming a core
> developer--and he actually said no.  At the time he said he didn't like
> our antiquated workflow.  Now that we've switched to the git-based core
> dev workflow, this objection is gone, and he's now interested in
> accepting the commit bit and the responsibilities that it entails.
> 
> I suspect you, my colleagues in CPython core development, will be
> surprised at the current state of affairs.  I'm expecting a load of "you
> mean Mark *isn't* a core developer yet?" replies.
>

+1
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Łukasz Langa
+1

-- 
Best regards,
Łukasz Langa

> On May 14, 2018, at 4:41 PM, Larry Hastings  wrote:
> 
> 
> 
> Dr. Mark Shannon contributed the "key sharing dictionary" to Python, writing 
> both the PEP and the implementation.  This shipped in Python 3.3 and was 
> listed as one of the top features of that release as according to the "What's 
> New?" document.
> 
> We've asked Mark in the past if he'd be interested in becoming a core 
> developer--and he actually said no.  At the time he said he didn't like our 
> antiquated workflow.  Now that we've switched to the git-based core dev 
> workflow, this objection is gone, and he's now interested in accepting the 
> commit bit and the responsibilities that it entails.
> 
> I suspect you, my colleagues in CPython core development, will be surprised 
> at the current state of affairs.  I'm expecting a load of "you mean Mark 
> *isn't* a core developer yet?" replies.
> 
> 
> Submitted for your consideration,
> 
> 
> /arry
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Yury Selivanov
+1

Yury
-- 
 Yury
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Carol Willing
+1

On Mon, May 14, 2018, 6:47 PM INADA Naoki  wrote:

> +1
>
> 2018年5月15日(火) 6:55 Ivan Levkivskyi :
>
>> +1
>>
>> Yes, I actually thought he is a core dev for ages :-)
>>
>
> Me too.
>
>
>> --
>> Ivan
>>
>>
>>
>> On 14 May 2018 at 17:42, Eric Snow  wrote:
>>
>>> +1
>>>
>>> -eric
>>>
>>> On Mon, May 14, 2018 at 4:41 PM, Larry Hastings 
>>> wrote:
>>> >
>>> >
>>> > Dr. Mark Shannon contributed the "key sharing dictionary" to Python,
>>> writing
>>> > both the PEP and the implementation.  This shipped in Python 3.3 and
>>> was
>>> > listed as one of the top features of that release as according to the
>>> > "What's New?" document.
>>> >
>>> > We've asked Mark in the past if he'd be interested in becoming a core
>>> > developer--and he actually said no.  At the time he said he didn't
>>> like our
>>> > antiquated workflow.  Now that we've switched to the git-based core dev
>>> > workflow, this objection is gone, and he's now interested in accepting
>>> the
>>> > commit bit and the responsibilities that it entails.
>>> >
>>> > I suspect you, my colleagues in CPython core development, will be
>>> surprised
>>> > at the current state of affairs.  I'm expecting a load of "you mean
>>> Mark
>>> > *isn't* a core developer yet?" replies.
>>> >
>>> >
>>> > Submitted for your consideration,
>>> >
>>> >
>>> > /arry
>>> >
>>> > ___
>>> > python-committers mailing list
>>> > python-committers@python.org
>>> > https://mail.python.org/mailman/listinfo/python-committers
>>> > Code of Conduct: https://www.python.org/psf/codeofconduct/
>>> >
>>> ___
>>> python-committers mailing list
>>> python-committers@python.org
>>> https://mail.python.org/mailman/listinfo/python-committers
>>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>>
>>
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Serhiy Storchaka

14.05.18 23:41, Larry Hastings пише:

Dr. Mark Shannon contributed the "key sharing dictionary" to Python, 
writing both the PEP and the implementation.  This shipped in Python 
3.3 and was listed as one of the top features of that release as 
according to the "What's New?" document.


We've asked Mark in the past if he'd be interested in becoming a core 
developer--and he actually said no.  At the time he said he didn't 
like our antiquated workflow.  Now that we've switched to the 
git-based core dev workflow, this objection is gone, and he's now 
interested in accepting the commit bit and the responsibilities that 
it entails.


I suspect you, my colleagues in CPython core development, will be 
surprised at the current state of affairs.  I'm expecting a load of 
"you mean Mark *isn't* a core developer yet?" replies.


+1 from me. I always wondered why he is not a core developer.

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread INADA Naoki
+1

2018年5月15日(火) 6:55 Ivan Levkivskyi :

> +1
>
> Yes, I actually thought he is a core dev for ages :-)
>

Me too.


> --
> Ivan
>
>
>
> On 14 May 2018 at 17:42, Eric Snow  wrote:
>
>> +1
>>
>> -eric
>>
>> On Mon, May 14, 2018 at 4:41 PM, Larry Hastings 
>> wrote:
>> >
>> >
>> > Dr. Mark Shannon contributed the "key sharing dictionary" to Python,
>> writing
>> > both the PEP and the implementation.  This shipped in Python 3.3 and was
>> > listed as one of the top features of that release as according to the
>> > "What's New?" document.
>> >
>> > We've asked Mark in the past if he'd be interested in becoming a core
>> > developer--and he actually said no.  At the time he said he didn't like
>> our
>> > antiquated workflow.  Now that we've switched to the git-based core dev
>> > workflow, this objection is gone, and he's now interested in accepting
>> the
>> > commit bit and the responsibilities that it entails.
>> >
>> > I suspect you, my colleagues in CPython core development, will be
>> surprised
>> > at the current state of affairs.  I'm expecting a load of "you mean Mark
>> > *isn't* a core developer yet?" replies.
>> >
>> >
>> > Submitted for your consideration,
>> >
>> >
>> > /arry
>> >
>> > ___
>> > python-committers mailing list
>> > python-committers@python.org
>> > https://mail.python.org/mailman/listinfo/python-committers
>> > Code of Conduct: https://www.python.org/psf/codeofconduct/
>> >
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Paul Moore
+1 from me :-)

On 14 May 2018 at 21:41, Larry Hastings  wrote:
>
>
> Dr. Mark Shannon contributed the "key sharing dictionary" to Python, writing
> both the PEP and the implementation.  This shipped in Python 3.3 and was
> listed as one of the top features of that release as according to the
> "What's New?" document.
>
> We've asked Mark in the past if he'd be interested in becoming a core
> developer--and he actually said no.  At the time he said he didn't like our
> antiquated workflow.  Now that we've switched to the git-based core dev
> workflow, this objection is gone, and he's now interested in accepting the
> commit bit and the responsibilities that it entails.
>
> I suspect you, my colleagues in CPython core development, will be surprised
> at the current state of affairs.  I'm expecting a load of "you mean Mark
> *isn't* a core developer yet?" replies.
>
>
> Submitted for your consideration,
>
>
> /arry
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Kurt B. Kaiser
+1

On Mon, May 14, 2018, at 4:41 PM, Larry Hastings wrote:
> 
> 
> Dr. Mark Shannon contributed the "key sharing dictionary" to Python, 
> writing both the PEP and the implementation.  This shipped in Python 3.3 
> and was listed as one of the top features of that release as according 
> to the "What's New?" document.
> 
> We've asked Mark in the past if he'd be interested in becoming a core 
> developer--and he actually said no.  At the time he said he didn't like 
> our antiquated workflow.  Now that we've switched to the git-based core 
> dev workflow, this objection is gone, and he's now interested in 
> accepting the commit bit and the responsibilities that it entails.
> 
> I suspect you, my colleagues in CPython core development, will be 
> surprised at the current state of affairs.  I'm expecting a load of "you 
> mean Mark *isn't* a core developer yet?" replies.
> 
> 
> Submitted for your consideration,
> 
> 
> //arry/
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Ivan Levkivskyi
+1

Yes, I actually thought he is a core dev for ages :-)

--
Ivan



On 14 May 2018 at 17:42, Eric Snow  wrote:

> +1
>
> -eric
>
> On Mon, May 14, 2018 at 4:41 PM, Larry Hastings 
> wrote:
> >
> >
> > Dr. Mark Shannon contributed the "key sharing dictionary" to Python,
> writing
> > both the PEP and the implementation.  This shipped in Python 3.3 and was
> > listed as one of the top features of that release as according to the
> > "What's New?" document.
> >
> > We've asked Mark in the past if he'd be interested in becoming a core
> > developer--and he actually said no.  At the time he said he didn't like
> our
> > antiquated workflow.  Now that we've switched to the git-based core dev
> > workflow, this objection is gone, and he's now interested in accepting
> the
> > commit bit and the responsibilities that it entails.
> >
> > I suspect you, my colleagues in CPython core development, will be
> surprised
> > at the current state of affairs.  I'm expecting a load of "you mean Mark
> > *isn't* a core developer yet?" replies.
> >
> >
> > Submitted for your consideration,
> >
> >
> > /arry
> >
> > ___
> > python-committers mailing list
> > python-committers@python.org
> > https://mail.python.org/mailman/listinfo/python-committers
> > Code of Conduct: https://www.python.org/psf/codeofconduct/
> >
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Eric Snow
+1

-eric

On Mon, May 14, 2018 at 4:41 PM, Larry Hastings  wrote:
>
>
> Dr. Mark Shannon contributed the "key sharing dictionary" to Python, writing
> both the PEP and the implementation.  This shipped in Python 3.3 and was
> listed as one of the top features of that release as according to the
> "What's New?" document.
>
> We've asked Mark in the past if he'd be interested in becoming a core
> developer--and he actually said no.  At the time he said he didn't like our
> antiquated workflow.  Now that we've switched to the git-based core dev
> workflow, this objection is gone, and he's now interested in accepting the
> commit bit and the responsibilities that it entails.
>
> I suspect you, my colleagues in CPython core development, will be surprised
> at the current state of affairs.  I'm expecting a load of "you mean Mark
> *isn't* a core developer yet?" replies.
>
>
> Submitted for your consideration,
>
>
> /arry
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Ethan Furman

On 05/14/2018 01:41 PM, Larry Hastings wrote:


Dr. Mark Shannon contributed the "key sharing dictionary" to Python, writing 
both the PEP and the implementation.  This
shipped in Python 3.3 and was listed as one of the top features of that release as 
according to the "What's New?" document.

We've asked Mark in the past if he'd be interested in becoming a core 
developer--and he actually said no.  At the time
he said he didn't like our antiquated workflow.  Now that we've switched to the 
git-based core dev workflow, this
objection is gone, and he's now interested in accepting the commit bit and the 
responsibilities that it entails.


+1

--
~Ethan~
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Tim Peters
+1
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


[python-committers] Proposing Mark Shannon to be a core developer

2018-05-14 Thread Larry Hastings



Dr. Mark Shannon contributed the "key sharing dictionary" to Python, 
writing both the PEP and the implementation.  This shipped in Python 3.3 
and was listed as one of the top features of that release as according 
to the "What's New?" document.


We've asked Mark in the past if he'd be interested in becoming a core 
developer--and he actually said no.  At the time he said he didn't like 
our antiquated workflow.  Now that we've switched to the git-based core 
dev workflow, this objection is gone, and he's now interested in 
accepting the commit bit and the responsibilities that it entails.


I suspect you, my colleagues in CPython core development, will be 
surprised at the current state of affairs.  I'm expecting a load of "you 
mean Mark *isn't* a core developer yet?" replies.



Submitted for your consideration,


//arry/
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Orphaned backports

2018-05-14 Thread Brett Cannon
On Mon, 14 May 2018 at 14:22 Mariatta Wijaya 
wrote:

> To help with this, miss-islington will now assign the PR where backport
> had failed to the core dev who merged the original PR.
>

Great feature!

-Brett


>
>
> Mariatta
>
> On Tue, Apr 24, 2018 at 8:57 AM, Brett Cannon  wrote:
>
>>
>>
>> On Tue, 24 Apr 2018 at 02:59 Serhiy Storchaka 
>> wrote:
>>
>>> 23.04.18 19:47, Brett Cannon пише:
>>>
>>> On Sun, 22 Apr 2018 at 11:27 Terry Reedy  wrote:
>>>
 Does github allow repository owners to send email directly to people
 who
 have submitted PRs or at least, people with commit privileges (in this
 case, those whose have done particular merges)?

>>>
>>> No. People have to provide explicit permission to expose their email
>>> address. Otherwise the best we have are @ mentions in a comment.
>>>
>>>
>>> Aren't all active committer subscribed to this mailing list?
>>>
>>
>> They should be. Doesn't mean they pay attention to it. ;)
>>
>> -Brett
>>
>>
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
>>
> ᐧ
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] Orphaned backports

2018-05-14 Thread Mariatta Wijaya
To help with this, miss-islington will now assign the PR where backport had
failed to the core dev who merged the original PR.


Mariatta

On Tue, Apr 24, 2018 at 8:57 AM, Brett Cannon  wrote:

>
>
> On Tue, 24 Apr 2018 at 02:59 Serhiy Storchaka  wrote:
>
>> 23.04.18 19:47, Brett Cannon пише:
>>
>> On Sun, 22 Apr 2018 at 11:27 Terry Reedy  wrote:
>>
>>> Does github allow repository owners to send email directly to people who
>>> have submitted PRs or at least, people with commit privileges (in this
>>> case, those whose have done particular merges)?
>>>
>>
>> No. People have to provide explicit permission to expose their email
>> address. Otherwise the best we have are @ mentions in a comment.
>>
>>
>> Aren't all active committer subscribed to this mailing list?
>>
>
> They should be. Doesn't mean they pay attention to it. ;)
>
> -Brett
>
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
ᐧ
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/