[python-committers] workflow enhancement: a `mark bug as fixed` PR tag [feature request]
We've got the automerge tag on GH, it+bot make it awesome. There's one more thing I'd like to see that could help with bug hygiene: A tag to close the associated bug as "fixed" after the merge happens. This doesn't have to be tied to automerge; in practice you'd find them used in unison somewhat often. More readily on features done on the main branch rather than bug fixes needing backports to multiple releases. We've had such a system at work for so long I don't even remember when it was added, but it has been a great time saver. Less more bugs laying around fixed but not marked as such. Less need for triagers to manually ask someone who has the permissions to change the bug state. Less unintentionally still open bugs in the way distracting people. Good all around. It isn't the primary way to close issues, but it helps in situations where it makes sense. I'd assume the same set of people allowed to add automerge should be allowed to add this label. -gps ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/RTIPINYIWF7IDEEJOVFTMGZPJ2SMYQC3/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: workflow enhancement: a `mark bug as fixed` PR tag [feature request]
Once issues move to GitHub we’ll have this with no additional effort. On Sun, Oct 11, 2020 at 12:14 Gregory P. Smith wrote: > We've got the automerge tag on GH, it+bot make it awesome. There's one > more thing I'd like to see that could help with bug hygiene: A tag to close > the associated bug as "fixed" after the merge happens. > > This doesn't have to be tied to automerge; in practice you'd find them > used in unison somewhat often. More readily on features done on the main > branch rather than bug fixes needing backports to multiple releases. > > We've had such a system at work for so long I don't even remember when it > was added, but it has been a great time saver. Less more bugs laying > around fixed but not marked as such. Less need for triagers to manually > ask someone who has the permissions to change the bug state. Less > unintentionally still open bugs in the way distracting people. Good all > around. > > It isn't the primary way to close issues, but it helps in situations where > it makes sense. I'd assume the same set of people allowed to add automerge > should be allowed to add this label. > > -gps > ___ > python-committers mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/[email protected]/message/RTIPINYIWF7IDEEJOVFTMGZPJ2SMYQC3/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ > -- --Guido (mobile) ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/A6HPANBCT3RHXLBXMQMXCSMLVEQCRF4A/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: workflow enhancement: a `mark bug as fixed` PR tag [feature request]
GitHub workflow is nice when a single commit is enough to close an issue. But what if a bug should be fixed in multiple branches? Is there a way in GitHub to require one commit per branch to close an issue? Victor Le dim. 11 oct. 2020 à 21:16, Guido van Rossum a écrit : > > Once issues move to GitHub we’ll have this with no additional effort. > > On Sun, Oct 11, 2020 at 12:14 Gregory P. Smith wrote: >> >> We've got the automerge tag on GH, it+bot make it awesome. There's one more >> thing I'd like to see that could help with bug hygiene: A tag to close the >> associated bug as "fixed" after the merge happens. >> >> This doesn't have to be tied to automerge; in practice you'd find them used >> in unison somewhat often. More readily on features done on the main branch >> rather than bug fixes needing backports to multiple releases. >> >> We've had such a system at work for so long I don't even remember when it >> was added, but it has been a great time saver. Less more bugs laying around >> fixed but not marked as such. Less need for triagers to manually ask >> someone who has the permissions to change the bug state. Less >> unintentionally still open bugs in the way distracting people. Good all >> around. >> >> It isn't the primary way to close issues, but it helps in situations where >> it makes sense. I'd assume the same set of people allowed to add automerge >> should be allowed to add this label. >> >> -gps >> ___ >> python-committers mailing list -- [email protected] >> To unsubscribe send an email to [email protected] >> https://mail.python.org/mailman3/lists/python-committers.python.org/ >> Message archived at >> https://mail.python.org/archives/list/[email protected]/message/RTIPINYIWF7IDEEJOVFTMGZPJ2SMYQC3/ >> Code of Conduct: https://www.python.org/psf/codeofconduct/ > > -- > --Guido (mobile) > ___ > python-committers mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/[email protected]/message/A6HPANBCT3RHXLBXMQMXCSMLVEQCRF4A/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ -- Night gathers, and now my watch begins. It shall not end until my death. ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/Z6C2MH4FLZL2U73RSDF7HHUDM5DCUG4N/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: workflow enhancement: a `mark bug as fixed` PR tag [feature request]
On Sun, Oct 11, 2020 at 2:58 PM Victor Stinner wrote: > GitHub workflow is nice when a single commit is enough to close an > issue. But what if a bug should be fixed in multiple branches? Is > there a way in GitHub to require one commit per branch to close an > issue? > I wasn't worried about automating that case... But it is something we do reasonably often for bug fixes (merge the PR to main plus PRs to backport to the past two releases) so it'd be a natural next step. It may be more difficult to automate and express as it becomes a logical "x and y and z -> close/fixed" concept. If you predicate this automation on having switched to github issues, Those work differently than bpo. We could choose to always "close" after an issue is fixed in the first branch (usually main; though we occasionally have issues that are release-only and don't impact main) and use tags on issues to determine when they still need backports to past releases. The Issue's "open for backport to 3.9" tag being removed once the fixes land in the relevant release branch. That gets complicated, I'd leave that up to whomever designs and implements our GH Issues workflow (PEP-581 and 588 or otherwise). -gps > > Victor > > Le dim. 11 oct. 2020 à 21:16, Guido van Rossum a écrit > : > > > > Once issues move to GitHub we’ll have this with no additional effort. > > > > On Sun, Oct 11, 2020 at 12:14 Gregory P. Smith wrote: > >> > >> We've got the automerge tag on GH, it+bot make it awesome. There's one > more thing I'd like to see that could help with bug hygiene: A tag to close > the associated bug as "fixed" after the merge happens. > >> > >> This doesn't have to be tied to automerge; in practice you'd find them > used in unison somewhat often. More readily on features done on the main > branch rather than bug fixes needing backports to multiple releases. > >> > >> We've had such a system at work for so long I don't even remember when > it was added, but it has been a great time saver. Less more bugs laying > around fixed but not marked as such. Less need for triagers to manually > ask someone who has the permissions to change the bug state. Less > unintentionally still open bugs in the way distracting people. Good all > around. > >> > >> It isn't the primary way to close issues, but it helps in situations > where it makes sense. I'd assume the same set of people allowed to add > automerge should be allowed to add this label. > >> > >> -gps > >> ___ > >> python-committers mailing list -- [email protected] > >> To unsubscribe send an email to [email protected] > >> https://mail.python.org/mailman3/lists/python-committers.python.org/ > >> Message archived at > https://mail.python.org/archives/list/[email protected]/message/RTIPINYIWF7IDEEJOVFTMGZPJ2SMYQC3/ > >> Code of Conduct: https://www.python.org/psf/codeofconduct/ > > > > -- > > --Guido (mobile) > > ___ > > python-committers mailing list -- [email protected] > > To unsubscribe send an email to [email protected] > > https://mail.python.org/mailman3/lists/python-committers.python.org/ > > Message archived at > https://mail.python.org/archives/list/[email protected]/message/A6HPANBCT3RHXLBXMQMXCSMLVEQCRF4A/ > > Code of Conduct: https://www.python.org/psf/codeofconduct/ > > > > -- > Night gathers, and now my watch begins. It shall not end until my death. > ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/OF5HH2VY7TMQH6VPD2ZL5X7HS7PSZTFZ/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: workflow enhancement: a `mark bug as fixed` PR tag [feature request]
On Sun, Oct 11, 2020 at 10:14 PM Gregory P. Smith wrote: > > We've got the automerge tag on GH, it+bot make it awesome. There's one more > thing I'd like to see that could help with bug hygiene: A tag to close the > associated bug as "fixed" after the merge happens. You can already do that by adding "(Fixes|Closes) bpo-NNN" to the commit message. --Berker ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/TQEHXONBONVNKEP3EXT637VNTNMQYCW6/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: workflow enhancement: a `mark bug as fixed` PR tag [feature request]
On Sun, Oct 11, 2020 at 4:23 PM Berker Peksağ wrote: > On Sun, Oct 11, 2020 at 10:14 PM Gregory P. Smith wrote: > > > > We've got the automerge tag on GH, it+bot make it awesome. There's one > more thing I'd like to see that could help with bug hygiene: A tag to close > the associated bug as "fixed" after the merge happens. > > You can already do that by adding "(Fixes|Closes) bpo-NNN" to the > commit message. > Oh cool! where do I put that so that the message automerge generates sees it? > --Berker > ___ > python-committers mailing list -- [email protected] > To unsubscribe send an email to [email protected] > https://mail.python.org/mailman3/lists/python-committers.python.org/ > Message archived at > https://mail.python.org/archives/list/[email protected]/message/TQEHXONBONVNKEP3EXT637VNTNMQYCW6/ > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/AJMEMKBLQEYGOYTFNM4XWEQFFTWPTLNR/ Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Re: workflow enhancement: a `mark bug as fixed` PR tag [feature request]
On Sun, Oct 11, 2020 at 10:13 PM Gregory P. Smith wrote: > > We've got the automerge tag on GH, it+bot make it awesome. There's one more > thing I'd like to see that could help with bug hygiene: A tag to close the > associated bug as "fixed" after the merge happens. > > This doesn't have to be tied to automerge; in practice you'd find them used > in unison somewhat often. More readily on features done on the main branch > rather than bug fixes needing backports to multiple releases. > > We've had such a system at work for so long I don't even remember when it was > added, but it has been a great time saver. Less more bugs laying around fixed > but not marked as such. Less need for triagers to manually ask someone who > has the permissions to change the bug state. Less unintentionally still open > bugs in the way distracting people. Good all around. > > It isn't the primary way to close issues, but it helps in situations where it > makes sense. I'd assume the same set of people allowed to add automerge > should be allowed to add this label. I've been taking advantage of the need to go to the bpo issue to close it for two things: 1. Final review of the issue, making sure there isn't anything else that came up in its comments that warrants further attention. 2. Thanking the reporter, patch/PR submitters and others who contributed. I've come to think that #2 is especially important. This is a difference with a project like ours vs. a work environment: At a workplace, there usually isn't a need to thank people for their work on an issue, so just making sure that status is updated is enough. Therefore, I'd only use such a feature to close issues I opened myself when merging my own PRs which resolve them. - Tal ___ python-committers mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/USAHA4H4SU7MYY4YYB35KHY5CY5XWWJJ/ Code of Conduct: https://www.python.org/psf/codeofconduct/
