[issue46576] test_peg_generator is extremely slow
Change by Jeremy Kloth : -- pull_requests: +30420 pull_request: https://github.com/python/cpython/pull/32382 ___ Python tracker <https://bugs.python.org/issue46576> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47230] New compiler warnings with latest zlib
Change by Jeremy Kloth : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue47230> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47230] New compiler warnings with latest zlib
Change by Jeremy Kloth : -- pull_requests: +30400 pull_request: https://github.com/python/cpython/pull/32347 ___ Python tracker <https://bugs.python.org/issue47230> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47230] New compiler warnings with latest zlib
Change by Jeremy Kloth : -- pull_requests: +30399 pull_request: https://github.com/python/cpython/pull/32346 ___ Python tracker <https://bugs.python.org/issue47230> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47230] New compiler warnings with latest zlib
Jeremy Kloth added the comment: It seems so, as the zlib update was also backported to 3.9 and 3.10. -- ___ Python tracker <https://bugs.python.org/issue47230> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46576] test_peg_generator is extremely slow
Jeremy Kloth added the comment: My PR-32338 further reduces the runtime of the test another ~25%. On my machine, before 85s, after 65s. -- ___ Python tracker <https://bugs.python.org/issue46576> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46576] test_peg_generator is extremely slow
Change by Jeremy Kloth : -- nosy: +jkloth nosy_count: 3.0 -> 4.0 pull_requests: +30394 pull_request: https://github.com/python/cpython/pull/32338 ___ Python tracker <https://bugs.python.org/issue46576> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47230] New compiler warnings with latest zlib
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +30393 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32337 ___ Python tracker <https://bugs.python.org/issue47230> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47230] New compiler warnings with latest zlib
New submission from Jeremy Kloth :
The latest zlib (1.2.12) introduces 3 new compiler warnings. Now being an
external library, I do not think we generally patch them, so I propose to
simply silence the warnings for the offending file.
For reference, the problem comes from:
--- deflate.h.old 2022-04-05 11:27:26.869042900 -0600
+++ deflate.h.new 2022-04-05 11:26:11.512039600 -0600
@@ -329,8 +329,8 @@
# define _tr_tally_dist(s, distance, length, flush) \
{ uch len = (uch)(length); \
ush dist = (ush)(distance); \
-s->sym_buf[s->sym_next++] = dist; \
-s->sym_buf[s->sym_next++] = dist >> 8; \
+s->sym_buf[s->sym_next++] = (uch)dist; \
+s->sym_buf[s->sym_next++] = (uch)(dist >> 8); \
s->sym_buf[s->sym_next++] = len; \
dist--; \
s->dyn_ltree[_length_code[len]+LITERALS+1].Freq++; \
--
components: Build, Windows
messages: 416792
nosy: jkloth, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: New compiler warnings with latest zlib
type: compile error
versions: Python 3.11
___
Python tracker
<https://bugs.python.org/issue47230>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45354] test_winconsoleio fails on Windows 11
Change by Jeremy Kloth : -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.org/issue45354> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47131] Speedup test_unparse
Change by Jeremy Kloth : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue47131> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47131] Speedup test_unparse
Jeremy Kloth added the comment: Resolved with merged PR. -- resolution: -> fixed ___ Python tracker <https://bugs.python.org/issue47131> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47203] ImportError: DLL load failed while importing binascii: %1 is not a valid Win32 application.
Jeremy Kloth added the comment: Well, to really see where things are going wrong, there is always the verbose option when launching Python: py -v -c "import binascii" This will output a lot of information but should help pin down what is exactly being imported when the error occurs. If the above doesn't give enough of a clue as to the offending file, try '-vv' instead of '-v'. This increases the amount of debugging output, but does show each filename attempted for each particular import. You will need to scroll back quite awhile to get to the error location (past the cleanup messages). -- ___ Python tracker <https://bugs.python.org/issue47203> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47203] ImportError: DLL load failed while importing binascii: %1 is not a valid Win32 application.
Jeremy Kloth added the comment: This error will occur when there is a 64-bit/32-bit conflict. Normally, Python extension modules are installed in architecture dependent locations, however user-installed modules (pip install) can share a path referred to as "user site". A quick check from the command-line can give you its location: py -m site A scan of the paths listed as USER_BASE and USER_SITE might reveal a binascii.pyd which would be shadowing the normally built-in module. Another source of conflict would be a PYTHONPATH environment variable, if set. -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue47203> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37387] test_compileall fails randomly on Windows when tests are run in parallel
Jeremy Kloth added the comment: bpo-47089 is a duplicate of this issue and is fixed. This issue should be closed as well. -- ___ Python tracker <https://bugs.python.org/issue37387> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47089] Avoid sporadic failure of test_compileall on Windows
Change by Jeremy Kloth : -- pull_requests: +30311 pull_request: https://github.com/python/cpython/pull/32240 ___ Python tracker <https://bugs.python.org/issue47089> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47089] Avoid sporadic failure of test_compileall on Windows
Change by Jeremy Kloth : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue47089> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47131] Speedup test_unparse
Change by Jeremy Kloth : -- nosy: +vstinner type: -> performance ___ Python tracker <https://bugs.python.org/issue47131> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47131] Speedup test_unparse
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +30212 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32132 ___ Python tracker <https://bugs.python.org/issue47131> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47131] Speedup test_unparse
New submission from Jeremy Kloth : The string building and comparing of ast.dump() causes significant slowdowns on the large ASTs produced when doing the roundtrip test on the stdlib. This PR avoids that cost by doing a direct node traversal and comparison. It results in a 33% runtime improvement on machines to which I have access. -- components: Tests messages: 416082 nosy: jkloth priority: normal severity: normal status: open title: Speedup test_unparse versions: Python 3.10, Python 3.11, Python 3.9 ___ Python tracker <https://bugs.python.org/issue47131> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46716] regrtest didn't respect the timeout when running test_subprocess on AMD64 Windows11 3.x
Change by Jeremy Kloth : -- pull_requests: +30168 pull_request: https://github.com/python/cpython/pull/32081 ___ Python tracker <https://bugs.python.org/issue46716> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46716] regrtest didn't respect the timeout when running test_subprocess on AMD64 Windows11 3.x
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +30167 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32079 ___ Python tracker <https://bugs.python.org/issue46716> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44336] Windows buildbots hang after fatal exit
Change by Jeremy Kloth : -- pull_requests: +30146 pull_request: https://github.com/python/cpython/pull/32048 ___ Python tracker <https://bugs.python.org/issue44336> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46788] regrtest fails to start on missing performance counter names
Jeremy Kloth added the comment: Backports state that they are ready... I'm just a little uneasy as I've never used cherry_picker before. 3.10 went smooth, but 3.9 required manual merging. -- ___ Python tracker <https://bugs.python.org/issue46788> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44336] Windows buildbots hang after fatal exit
Change by Jeremy Kloth : -- pull_requests: +30139 pull_request: https://github.com/python/cpython/pull/32050 ___ Python tracker <https://bugs.python.org/issue44336> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46788] regrtest fails to start on missing performance counter names
Jeremy Kloth added the comment: With 3.8 so close to security only, I would doubt it is worth it anymore. I've just run the PR against HEAD and it still works as is, so should be good to go. -- versions: -Python 3.8 ___ Python tracker <https://bugs.python.org/issue46788> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47089] Avoid sporadic failure of test_compileall on Windows
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +30127 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32037 ___ Python tracker <https://bugs.python.org/issue47089> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47089] Avoid sporadic failure of test_compileall on Windows
New submission from Jeremy Kloth : Testing on Windows occasionally has issues in test_compileall when running with multiple processes. This is due to other test files importing stdlib modules at the same time that compileall is doing its own testing. While not fatal (test_compileall succeeds on re-run), the transient warnings obfuscate the test results for other "real" warnings (e.g., compiler warnings) without digging into each run separately. This can be avoided by using the PYTHONPYCACHEPREFIX functionality to compile the stdlib modules locally. -- components: Tests messages: 415711 nosy: jkloth priority: normal severity: normal status: open title: Avoid sporadic failure of test_compileall on Windows versions: Python 3.10, Python 3.11, Python 3.9 ___ Python tracker <https://bugs.python.org/issue47089> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46788] regrtest fails to start on missing performance counter names
Jeremy Kloth added the comment: OK, I know it has been a busy month for Python, but this issue is really hampering my bug fixing efforts. It makes the complete regrtest useless for me. I am required to run each affected test directly so it is possible to miss side-effects of changes made. The original PR is now 9 months old. -- ___ Python tracker <https://bugs.python.org/issue46788> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46084] Python 3.9.6 scan_dir returns filenotfound on long paths, but os_walk does not
Change by Jeremy Kloth : -- pull_requests: -30123 ___ Python tracker <https://bugs.python.org/issue46084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46084] Python 3.9.6 scan_dir returns filenotfound on long paths, but os_walk does not
Change by Jeremy Kloth : -- pull_requests: +30123 pull_request: https://github.com/python/cpython/pull/32032 ___ Python tracker <https://bugs.python.org/issue46084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47084] Statically allocated Unicode objects leak cached representations
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +30122 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32032 ___ Python tracker <https://bugs.python.org/issue47084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46084] Python 3.9.6 scan_dir returns filenotfound on long paths, but os_walk does not
Change by Jeremy Kloth : -- pull_requests: -30121 ___ Python tracker <https://bugs.python.org/issue46084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46084] Python 3.9.6 scan_dir returns filenotfound on long paths, but os_walk does not
Change by Jeremy Kloth : -- keywords: +patch nosy: +jkloth nosy_count: 7.0 -> 8.0 pull_requests: +30121 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32032 ___ Python tracker <https://bugs.python.org/issue46084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47084] Statically allocated Unicode objects leak cached representations
New submission from Jeremy Kloth : The newly implemented statically allocated Unicode objects do not clear their cached representations (wstr and utf-8) at exit causing leaked blocks at exit (see also issue46857). At issue are the Unicode objects created by deepfreeze and the 1-character strings (ordinals < 256). -- components: Interpreter Core, Unicode messages: 415695 nosy: ezio.melotti, jkloth, vstinner priority: normal severity: normal status: open title: Statically allocated Unicode objects leak cached representations versions: Python 3.11 ___ Python tracker <https://bugs.python.org/issue47084> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46857] Python leaks one reference at exit on Windows
Jeremy Kloth added the comment: Did you also modify initconfig.c? That part is required as the usual processing of the environment variable PYTHONDUMPREFS needed to enable tracing output is ignored with -I -- ___ Python tracker <https://bugs.python.org/issue46857> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46857] Python leaks one reference at exit on Windows
Jeremy Kloth added the comment: > ./configure --enabled-shared --with-py-debug --with-trace-refs (that's what I get for typing from memory): ./configure --enable-shared --with-pydebug --with-trace-refs > > I proposed GH-31594 to fix this macro. > > Even using that change, I still have negative refs (but I still have > Py_TRACE_REFS defined) I initially missed the _PySet_Dummy change, with that total refs (w/o dump_refs) is now 0. -- ___ Python tracker <https://bugs.python.org/issue46857> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46857] Python leaks one reference at exit on Windows
Jeremy Kloth added the comment: > Oh wow. How did you find this leak? Did you read all C files and check for > code specific to Windows? How did you proceed? Well spotted! Initially, I modified Py_INCREF to dump the object (addr & tp_name) on initial inc (ob_refcnt == 1) and Py_DECREF to dump on final dec (ob_refcnt == 0). Then filter that list (~65K) to find objects not dealloc'ed. Given those names (~200), cross-check with source files containing 'ifdef MS_WINDOWS' (and related spellings). > Which command do you type? Do you pass -I option to Python? For both as -I disables environment lookup: --- a/Python/initconfig.c +++ b/Python/initconfig.c @@ -757,6 +757,7 @@ config_init_defaults(PyConfig *config) config->user_site_directory = 1; config->buffered_stdio = 1; config->pathconfig_warnings = 1; + config->dump_refs = 1; #ifdef MS_WINDOWS config->legacy_windows_stdio = 0; #endif For linux: ./configure --enabled-shared --with-py-debug --with-trace-refs make build_all LD_LIBRARY_PATH=$PWD ./python -X showrefcount -I -c pass For Windows: Add "#define Py_TRACE_REFS 1" to PC\pyconfig.h build.bat -d -e amd64\python_d.exe -X showrefcount -I -c pass > I proposed GH-31594 to fix this macro. Even using that change, I still have negative refs (but I still have Py_TRACE_REFS defined) -- nosy: +jeremy.kloth ___ Python tracker <https://bugs.python.org/issue46857> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46857] Python leaks one reference at exit on Windows
Jeremy Kloth added the comment: Note that an allocated block is still leaking. Strange as well, when using dump_refs, the total refs are much more negative (-12 linux, -13 Windows) -- ___ Python tracker <https://bugs.python.org/issue46857> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46857] Python leaks one reference at exit on Windows
Jeremy Kloth added the comment:
Good news, the difference on Windows was easy enough to find, bad news total
refs are now negative!
--- a/Objects/exceptions.c
+++ b/Objects/exceptions.c
@@ -3647,8 +3647,7 @@ _PyBuiltins_AddExceptions(PyObject *bltinmod)
#define INIT_ALIAS(NAME, TYPE) \
do { \
-Py_INCREF(PyExc_ ## TYPE); \
-Py_XDECREF(PyExc_ ## NAME); \
+Py_XSETREF(PyExc_ ## NAME, PyExc_ ## TYPE); \
PyExc_ ## NAME = PyExc_ ## TYPE; \
if (PyDict_SetItemString(mod_dict, # NAME, PyExc_ ## NAME)) { \
return -1; \
As the PyExc_* aliases just deprecated names for PyExc_OSError, there is no
need to increment their refcounts. Or they could be decremented in Fini(). Or
they could finally be removed entirely.
--
nosy: +jkloth
___
Python tracker
<https://bugs.python.org/issue46857>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46789] Restore caching of externals on Windows buildbots
Jeremy Kloth added the comment: > Would it be possible to create a download cache somewhere outside the Python > source tree, so "git clean -fdx" would not remove this cache? I was thinking of locating it next to the checkout directory. The current structure is: [worker root] -- [builder root] [checkout] I propose to add the externals directory within the builder root, so each branch would still have a unique copy. -- nosy: +jeremy.kloth ___ Python tracker <https://bugs.python.org/issue46789> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46789] Restore caching of externals on Windows buildbots
Jeremy Kloth added the comment: I personally would like to see caching restored so as to keep the duration of buildbot runs as low as possible. The repeated fetching effectively doubles compilation time for my Win11 builder. -- ___ Python tracker <https://bugs.python.org/issue46789> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46790] Normalize handling of negative timeouts in subprocess.py
Jeremy Kloth added the comment: Oh, I forgot to add that I'm in favor of following the threading.py behavior of allowing <=0 to mean "non-blocking" (i.e., just check). This would probably also benefit from a documentation update to clarify. -- ___ Python tracker <https://bugs.python.org/issue46790> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46790] Normalize handling of negative timeouts in subprocess.py
Change by Jeremy Kloth : -- nosy: +eryksun, vstinner ___ Python tracker <https://bugs.python.org/issue46790> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46790] Normalize handling of negative timeouts in subprocess.py
New submission from Jeremy Kloth : As a follow on to bpo-46716, the various timeout parameters currently deal with negative values differently in POSIX and Windows. On POSIX, a negative value is treated the same as 0; check completion and raise TimeoutExpired is still running. On Windows, the negative value is treated as unsigned and ultimately waits for ~49 days. While the Windows behavior is obviously wrong and will be fixed internally as part of bpo-46716, that still leaves what to do with timeouts coming from user-space. The current documentation just states that after `timeout` seconds TimeoutExpired is raised. A liberal reading of the documentation could lead one to believe any value <=0 would suffice for an "active" check (the POSIX behavior). OR, the documentation could be amended and negative values are now invalid and apply range checking in the user-facing functions. -- components: Library (Lib) messages: 413496 nosy: jkloth priority: normal severity: normal status: open title: Normalize handling of negative timeouts in subprocess.py versions: Python 3.10, Python 3.11, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue46790> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46789] Restore caching of externals on Windows buildbots
Change by Jeremy Kloth : -- nosy: +pablogsal, vstinner ___ Python tracker <https://bugs.python.org/issue46789> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46789] Restore caching of externals on Windows buildbots
New submission from Jeremy Kloth : A recent change to the buildmaster config effectively disabled the caching of the externals for Windows buildbots: https://github.com/python/buildmaster-config/pull/255 If the caching is desired, a simple change to the buildmaster config is needed (define EXTERNALS_DIR in the build environment). Or, to continue with fetching them each run, the buildbot scripts in Tools\buildbot can be simplified. Once a course of action is determined I can develop the requisite PR(s) in the appropriate tracker. -- components: Build, Tests, Windows messages: 413494 nosy: jkloth, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: Restore caching of externals on Windows buildbots ___ Python tracker <https://bugs.python.org/issue46789> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46788] regrtest fails to start on missing performance counter names
Change by Jeremy Kloth : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue46788> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46788] regrtest fails to start on missing performance counter names
New submission from Jeremy Kloth : When attempting to run the test harness, I receive the following: Traceback (most recent call last): File "", line 198, in _run_module_as_main File "", line 88, in _run_code File "C:\Public\Devel\cpython\main\Lib\test\__main__.py", line 2, in main() ^^ File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\main.py", line 736, in main Regrtest().main(tests=tests, **kwargs) ^^ File "C:\Public\Devel\cpython\main\Lib\contextlib.py", line 155, in __exit__ self.gen.throw(typ, value, traceback) ^ File "C:\Public\Devel\cpython\main\Lib\contextlib.py", line 155, in __exit__ self.gen.throw(typ, value, traceback) ^ File "C:\Public\Devel\cpython\main\Lib\test\support\os_helper.py", line 396, in temp_dir yield path ^^ File "C:\Public\Devel\cpython\main\Lib\contextlib.py", line 155, in __exit__ self.gen.throw(typ, value, traceback) ^ File "C:\Public\Devel\cpython\main\Lib\test\support\os_helper.py", line 427, in change_cwd yield os.getcwd() ^ File "C:\Public\Devel\cpython\main\Lib\test\support\os_helper.py", line 449, in temp_cwd yield cwd_dir ^ File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\main.py", line 658, in main self._main(tests, kwargs) ^ File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\main.py", line 704, in _main self.win_load_tracker = WindowsLoadTracker() File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\win_utils.py", line 41, in __init__ self.start() File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\win_utils.py", line 70, in start counter_name = self._get_counter_name() File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\win_utils.py", line 90, in _get_counter_name system = counters_dict['2'] ~^ KeyError: '2' This is due to my machine missing the localized names for the performance counters. Other performance monitoring tools operate just fine. While I have been working around this issue for some time, it has become difficult to seperate the workarounds from actually changes in the test harness. The PR (https://github.com/python/cpython/pull/26578) from https://bugs.python.org/issue44336 also solves this issue by accessing the counters directly instead of relying on their localized names. -- components: Tests, Windows messages: 413493 nosy: jkloth, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: regrtest fails to start on missing performance counter names versions: Python 3.10, Python 3.11, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue46788> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46778] Enable parallel compilation on Windows builds
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +29535 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31390 ___ Python tracker <https://bugs.python.org/issue46778> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46778] Enable parallel compilation on Windows builds
New submission from Jeremy Kloth : While the current build does enable building of projects in parallel (msbuild -m), the compilation of each project's source files is done sequentially. For large projects like pythoncore or _freeze_module this can take quite some time. This simple PR speeds things up significantly, ~2x on machines that I have access. -- components: Build, Windows messages: 413412 nosy: jkloth, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: Enable parallel compilation on Windows builds versions: Python 3.11 ___ Python tracker <https://bugs.python.org/issue46778> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46716] regrtest didn't respect the timeout when running test_subprocess on AMD64 Windows11 3.x
Jeremy Kloth added the comment: > > the fix should be as simple as coercing the timeout values to >= 0. > > Popen._remaining_time() should return max(endtime - _time(), 0). That was my first initial instinct as well, however, that change would also affect more of the Popen behavior and need a much more thorough investigation of the POSIX side of Popen. > Popen._wait() should raise OverflowError if the timeout is too large for the > implementation. In Windows, the upper limit in milliseconds is > `_winapi.INFINITE - 1` (about 49.7 days). It's important to only allow the > timeout in milliseconds to be _winapi.INFINITE when `timeout is None`. I agree. > The DWORD converter in _winapi needs to subclass unsigned_long_converter. The > current implementation based on the legacy format unit "k" is too lenient. > Negative values and values that are too large should fail. Whilst I agree this is a correct solution, I fear the potential 3rd-party breakage alone should bump this to its own issue. I believe that this then leads to the following action items for this issue: 1) modify Windows Popen._wait() to raise on out of bounds values [< 0 or >= INFINITE] 2) cap Popen._remaining_time() return value to >= 0 3) change _winapi DWORD converter be unsigned long 4) use Job objects to group Windows processes for termination Have I missed anything? I should be able to knock out PRs for these today. -- Jeremy Kloth -- nosy: +jeremy.kloth ___ Python tracker <https://bugs.python.org/issue46716> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46716] regrtest didn't respect the timeout when running test_subprocess on AMD64 Windows11 3.x
Jeremy Kloth added the comment: I've been able locally to reproduce the test_subprocess hang. The responsible function is subprocess.run(). The test case, test_timeout(), uses a small timeout value (0.0001), which, when given enough load, can cause the run() call to hang. A judicious use of prints in subprocess.py, reveals that the timeout passed to wait() ends up being negative. That value, once cast to a DWORD, ultimately causes a very long wait (0xfff2, in my testing). It does seem that only the Windows Popen._wait() cannot handle negative timeout values, so the fix should be as simple as coercing the timeout values to >= 0. -- Added file: https://bugs.python.org/file50623/process.py ___ Python tracker <https://bugs.python.org/issue46716> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46716] regrtest didn't respect the timeout when running test_subprocess on AMD64 Windows11 3.x
Jeremy Kloth added the comment: The test only completed once I purposefully terminated the offending Python process. The only identifying information I noticed was the command-line of `-c "while True: pass"`, indicating it was stuck in either test_call_timeout() or test_timeout() in test_subprocess.py. Something to note is that Windows does not, by default, have a concept of process trees whereas terminating a parent automatically kills the children. Eryk Sun may have additional ideas on how this desired behavior could be accomplished. -- nosy: +eryksun, jkloth ___ Python tracker <https://bugs.python.org/issue46716> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45806] Cannot Recover From StackOverflow in 3.9 Tests
Jeremy Kloth added the comment: I'll note that it also fails on first run on the Windows 11 builder: https://buildbot.python.org/all/#/builders/737/builds/65 -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker <https://bugs.python.org/issue45806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45806] Cannot Recover From StackOverflow in 3.9 Tests
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue45806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45354] test_winconsoleio fails on Windows 11
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +27062 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28712 ___ Python tracker <https://bugs.python.org/issue45354> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45354] test_winconsoleio fails on Windows 11
Jeremy Kloth added the comment: Note that I have a pending PR for adding a Windows 11 build worker that will, once merged, help in testing a solution. -- ___ Python tracker <https://bugs.python.org/issue45354> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45354] test_winconsoleio fails on Windows 11
New submission from Jeremy Kloth :
It appears there have been some console related changes in Windows 11
==
ERROR: test_open_name (test.test_winconsoleio.WindowsConsoleIOTests)
--
Traceback (most recent call last):
File "C:\Users\Jeremy\source\repos\cpython\lib\test\test_winconsoleio.py",
line 95, in test_open_name
f = open('C:/con', 'rb', buffering=0)
^
FileNotFoundError: [Errno 2] No such file or directory: 'C:/con'
==
FAIL: test_conout_path (test.test_winconsoleio.WindowsConsoleIOTests)
--
Traceback (most recent call last):
File "C:\Users\Jeremy\source\repos\cpython\lib\test\test_winconsoleio.py",
line 118, in test_conout_path
self.assertIsInstance(f, ConIO)
^^^
AssertionError: <_io.FileIO
name='C:\\Users\\Jeremy\\AppData\\Local\\Temp\\tmpoqx235b0\\CONOUT$' mode='wb'
closefd=True> is not an instance of
--
--
components: Tests, Windows
messages: 403090
nosy: jkloth, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: test_winconsoleio fails on Windows 11
type: behavior
___
Python tracker
<https://bugs.python.org/issue45354>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45110] argparse repeats itself when formatting help metavars
Jeremy Kloth added the comment: Except that the output in question is not for manpages but for the command-line. The analogous would be for `grep --help` (again an excerpt): Context control: -B, --before-context=NUM print NUM lines of leading context -A, --after-context=NUM print NUM lines of trailing context -C, --context=NUM print NUM lines of output context -NUM same as --context=NUM --color[=WHEN], --colour[=WHEN] use markers to highlight the matching strings; WHEN is 'always', 'never', or 'auto' [using grep (GNU grep) 3.1] -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue45110> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44779] Checkouts stale following changes to .gitattributes
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue44779> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44777] Create mechanism to contact buildbot worker owners
Jeremy Kloth added the comment: There is a list `python-buildb...@python.org` that all buildbot owners have been subscribed. -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue44777> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44336] Windows buildbots hang after fatal exit
Jeremy Kloth added the comment: While now not as immediately beneficial, I believe that the linked PR would be good for the long run. The ramifications of bpo-11105 meant that the Windows buildbots were basically unusable for 5 days. Realistically, any commit that triggers aborts in the Windows test runs will exhibit this problematic behavior. I'm confident that the PR is in ready-to-go form. -- ___ Python tracker <https://bugs.python.org/issue44336> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11105] Compiling recursive Python ASTs crash the interpreter
Change by Jeremy Kloth : -- nosy: +jkloth nosy_count: 11.0 -> 12.0 pull_requests: +25186 pull_request: https://github.com/python/cpython/pull/26578 ___ Python tracker <https://bugs.python.org/issue11105> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44336] Windows buildbots hang after fatal exit
Jeremy Kloth added the comment: The PR has been successfully run on the buildbots. Before: https://buildbot.python.org/all/#/builders/593/builds/58 After: https://buildbot.python.org/all/#/builders/593/builds/59 With these changes, at least now aborted runs can be seen as direct failures of Python's tests instead of just builder exceptions. -- ___ Python tracker <https://bugs.python.org/issue44336> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44336] Windows buildbots hang after fatal exit
Jeremy Kloth added the comment: To verify the PR, can someone please add the test-with-buildbots label on GH? -- ___ Python tracker <https://bugs.python.org/issue44336> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44336] Windows buildbots hang after fatal exit
Change by Jeremy Kloth : -- keywords: +patch pull_requests: +25166 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26578 ___ Python tracker <https://bugs.python.org/issue44336> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44336] Windows buildbots hang after fatal exit
New submission from Jeremy Kloth : Currently, a stack overflow is causing the debug build Windows buildbots to abort (bpo-11105). Once the regrtest process is terminated, the buildbot test process hangs indefinitely waiting for handles to be closed (see msg350191 from bpo-37531 for some details). -- components: Tests, Windows messages: 395268 nosy: jkloth, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: Windows buildbots hang after fatal exit versions: Python 3.10, Python 3.11, Python 3.9 ___ Python tracker <https://bugs.python.org/issue44336> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44214] PyArg_Parse* for vectorcall?
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue44214> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40432] Pegen regenerate project for Windows not working
Jeremy Kloth added the comment: Adding windows team to the nosy list -- components: +Windows nosy: +jkloth, paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker <https://bugs.python.org/issue40432> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2889] curses for windows (alternative patch)
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue2889> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue37945> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43538] [Windows] support args and cwd in os.startfile()
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue43538> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43022] Unable to dynamically load functions from python3.dll
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue43022> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42705] Intercepting thread lock objects not working under context managers
Change by Jeremy Kloth : -- components: -Distutils ___ Python tracker <https://bugs.python.org/issue42705> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42802] distutils: Remove bdist_wininst command
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue42802> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42611] PEP 594
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue42611> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41758] turtledemo.colormixer crashes with a stack overflow
Jeremy Kloth added the comment: The error from importing numpy comes from attempting to load a 64-bit DLL in a 32-bit process. This stems from the shared user install directory (now fixed in 3.9, I believe). There is most likely a mix of 32- and 64-bit extensions in the user install directory that are causing issues. To test this, Tushar, please rename/move the '%APPDATA%\Python\Python38' directory. -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue41758> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39978] Vectorcall implementation should conform to PEP 590.
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue39978> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39917] new_compiler() called 2nd time causes error
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue39917> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39911] "AMD64 Windows7 SP1 3.x" buildbot doesn't build anymore
Jeremy Kloth added the comment: Well, it only doesn't build on 3.9+ (master) due to not being supported going forward. The *buildmaster* needs to be fixed to stop submitting those jobs to unsupported platforms. We need to continue testing 3.7 and 3.8 on Win7 until they go EOL to ensure that no platform breaking changes get backported. This same issue will come up again (on different builders) as Win8 becomes unsupported (3.10, I believe). As to this builder directly, I am working on a replacement machine that will have the latest tooling installed which should be done before before 3.9 goes gold (real-life permitting, of course). -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue39911> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39697] Failed to build with --with-cxx-main=g++-9.2.0
Jeremy Kloth added the comment: What seems to be, at least, the conclusion of the thread: https://mail.python.org/archives/list/python-...@python.org/thread/YXMD5EIHAODRZGTQ3HU74OPGEBAVCSK6/ -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue39697> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39511] [subinterpreters] Per-interpreter singletons (None, True, False, etc.)
Jeremy Kloth added the comment: +1, obviously, as I came to the same conclusion above (see msg361122) -- ___ Python tracker <https://bugs.python.org/issue39511> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39511] [subinterpreters] Per-interpreter singletons (None, True, False, etc.)
Jeremy Kloth added the comment: > The problem is to make Py_INCREF/Py_DECREF efficient. That is exactly why I didn't propose a change to them. The singletons still are refcounted as usual, just that their ob_refcnt is ignored. If they somehow reach 0, they just "resurrect" themselves and ignore the regular collection behavior. In the presence of multiple DECREF'ers, the ob_refcnt field is garbage, but that is OK as it is effectively ignored. Practicality vs Purity and all that. > Last time someone tried to use an atomic variable for ob_refcnt, it was 20% > slower if I recall correctly. If many threads start to update such atomic > variable, the CPU cacheline of common singletons like None, True and False > can quickly become a performance bottleneck. Exactly so, hence why I chose the simple solution of effectively ignoring ob_refcnt. > On the other side, if each interpreter has its own objects, there is no need > to protect ob_refcnt, the interpreter lock protects it. My solution also does not need any protection around ob_refcnt. -- nosy: +jeremy.kloth ___ Python tracker <https://bugs.python.org/issue39511> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39511] [subinterpreters] Per-interpreter singletons (None, True, False, etc.)
Jeremy Kloth added the comment:
Would it not suffice to just make the singletons "immortal"?
Without affecting the hotpaths that are Py_INCREF and Py_DECREF, changing
_Py_Dealloc to test for objects with a "special" destructor could be used:
destructor dealloc = Py_TYPE(op)->tp_dealloc;
if (dealloc == _Py_SingletonSentinel) {
/* reset refcnt so as to not return here too often */
op->ob_refcnt = PY_SSIZE_T_MAX;
}
else {
(*dealloc)(op);
}
Even in the presence of multiple mutating threads, the object cannot be
destroyed. Worst case, they all call _Py_Dealloc.
--
nosy: +jkloth
___
Python tracker
<https://bugs.python.org/issue39511>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39401] [CVE-2020-8315] Unsafe dll loading in getpathp.c on Win7
Jeremy Kloth added the comment: As noted on the PR landing page, this PR has caused failures of 2 buildbots: https://buildbot.python.org/all/#builders/81/builds/272 https://buildbot.python.org/all/#builders/150/builds/227 (both are Windows 7) -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue39401> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38544] test_venv: test_isolation() failed on AMD64 Windows7 SP1 3.x: directory not empty: Scripts\
Jeremy Kloth added the comment: That covers the logging in _force_run(), but the warning.warn() line is also not output, suggesting that the RuntimeWarning is being suppressed somewhere. -- ___ Python tracker <https://bugs.python.org/issue38544> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38544] test_venv: test_isolation() failed on AMD64 Windows7 SP1 3.x: directory not empty: Scripts\
Jeremy Kloth added the comment: While not getting into the error itself, there seems to be another issue in that the logging that should be happening when the deletion routines from test.support fail: https://github.com/python/cpython/blob/5bc6a7c06eda20ba131ecba6752be0506d310181/Lib/test/support/__init__.py#L339 https://github.com/python/cpython/blob/5bc6a7c06eda20ba131ecba6752be0506d310181/Lib/test/support/__init__.py#L375 is not showing up when the test is re-run in verbose mode. -- ___ Python tracker <https://bugs.python.org/issue38544> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38544] test_venv: test_isolation() failed on AMD64 Windows7 SP1 3.x: directory not empty: Scripts\
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue38544> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36732] Windows: test_asyncio: test_huge_content_recvinto() fails randomly with ProactorEventLoop
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue36732> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x
Jeremy Kloth added the comment: > Windows 7 is not supported for Python 3.9, so this buildbot can be > disabled/upgraded. As long as 3.7 and 3.8 are being tested through the buildbots, I would think testing on Windows 7 is still advised. That said, once those versions are no longer tested (or deemed to not need Windows 7 support) I will be upgrading that buildbot. -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue38470> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38207] subprocess: On Windows, Popen.kill() + Popen.communicate() is blocking until all processes using the pipe close the pipe
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue38207> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS
Jeremy Kloth added the comment: Another day, another stuck test_concurrent_futures... https://buildbot.python.org/all/#/builders/40/builds/3030 The test process is again killed (line 568) but the processes from the multiprocess pool are still alive. Once I manually kill those pool processes, regrtest resumes as it should. -- ___ Python tracker <https://bugs.python.org/issue37531> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS
Jeremy Kloth added the comment: Well, the kill timeout doesn't seem to be working, at least completely: https://buildbot.python.org/all/#/builders/40/builds/3012 The worker process has been killed (line 562), but regrtest is still waiting. -- ___ Python tracker <https://bugs.python.org/issue37531> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS
Jeremy Kloth added the comment: I happened to catch a stuck build prior to the process being killed: https://buildbot.python.org/all/#/builders//builds/2887 In short, the PR doesn't change the problem. The regrtest main will wait indefinitely on the successfully killed process. I have some ideas to try, but creating a reproducer is not exactly easy... -- ___ Python tracker <https://bugs.python.org/issue37531> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS
Jeremy Kloth added the comment: Additional logging on failures is always welcome. Might I suggest that, in this case, regrtest treats this action as a hard fail so as to not got lost in the other transient failures (test_asyncio). By that I mean, either to not re-run, or to still be "failed" even after a successful re-run as this test_concurrent mishap is rare enough that I doubt it would happen twice in one build. Now for a brain dump. The process tree at this time: python.exe (buildbot) . cmd.exe (test step) .. python_d.exe (regrtest main) ... typepref.exe (load) ... typepref.exe (load for test_concurrent_futures) python_d.exe (multiprocessing pool) python_d.exe (multiprocessing pool) python_d.exe (multiprocessing pool) python_d.exe (multiprocessing pool) python_d.exe (multiprocessing pool) 1. To see how process termination played out, I killed the main regrtest process. This did not let the buildbot complete, but just sit there without any output. Also the typepref.exe process (and the failed multiprocessing pool processes) still lingered. 2. I then terminated the children* of the already terminated process. No change to the buildbot. [*] Windows doesn't really have the concept of a process tree 3. I then terminated the final typepref.exe process. The buildbot finally finished its test step. Given that typepref.exe also prevents completion, I believe the problem is in how we are spawning subprocesses. Maybe a process handle is being inherited by the spawned processes preventing it from fully terminating? I mention the process handle as it was listed as an open handle in Process Explorer for the regrtest process even though it had been terminated prior. -- nosy: +eryksun ___ Python tracker <https://bugs.python.org/issue37531> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS
Jeremy Kloth added the comment: > Can you check the process hierarchy? I would like to know how many worker > processes are still running under the main regrtest process. I expect to see > exactly one. I don't know how to investigate more on such issue on Windows. There are no child processes of the main test process. There are 5 orphaned processes from multiprocessing. Their parent process is gone (assuming the parent_pid argument is correct). There is also an orphaned typeperf.exe process, probably also from the killed process. -- nosy: +jeremy.kloth ___ Python tracker <https://bugs.python.org/issue37531> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS
Jeremy Kloth added the comment: It seems that an issue still exists. https://buildbot.python.org/all/#/builders/130/builds/1050 has been running for nearly 9 hours at this point. I can leave it "stuck" if there is some diagnostics that would be beneficial. But I would prefer not to have this impeding other testing for too long. -- ___ Python tracker <https://bugs.python.org/issue37531> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37734] Registry keys for Windows Store package have wrong executable
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue37734> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS
Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker <https://bugs.python.org/issue37531> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
