[Pywikipedia-bugs] [Maniphest] [Created] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread Lokal_Profil 
Lokal_Profil created this task.
Lokal_Profil added a subscriber: Lokal_Profil.
Lokal_Profil added a project: pywikibot-core.
Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  Currently qualifiers are misidentified as references when `fromJSON()` is 
called on the parent claim.
  
  To test:
  ```
  import pywikibot;repo = pywikibot.Site().data_repository();item = 
pywikibot.ItemPage(repo, 'Q4115189')
  item.exists()
  c = item.claims['P800'][0];sc = c.sources[1]['P813'][0];qc = 
c.qualifiers['P580'][0]
  
  qc.isReference
  qc.isQualifier
  sc.isReference
  sc.isQualifier
  ```
  
  I have a quick patch which simply moves the `isQualifier`/`isReference` 
assignment to the `qualifierFromJSON()`/`referenceFromJSON()` methods. However 
since I'm unsure if `fromJSON()` is ever called directly on a 
qualifer/reference I'm not sure whether this is enough.

TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Aklapper, Lokal_Profil, pywikibot-bugs-list, jayvdb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread jayvdb 
jayvdb added a subscriber: jayvdb.
jayvdb added a comment.

Interesting; `toJSON` contains `qualifier.isQualifier = True` and 
`source.isReference = True`.  Those should be asserts!


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T100123: API code 'readonly' not handled

2015-09-21 Thread XZise 
XZise added a comment.

Here now test.wikipedia.org using `action=edit`: 
https://travis-ci.org/xZise/pywikibot-core/jobs/81350911#L3393


TASK DETAIL
  https://phabricator.wikimedia.org/T100123

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise
Cc: XZise, Multichill, pywikibot-bugs-list, jayvdb, Aklapper, Wikidata-bugs, 
aude



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Lowered Priority] T113222: unicodecsv has dropped support for Python 2.6

2015-09-21 Thread XZise 
XZise lowered the priority of this task from "High" to "Lowest".
XZise added a comment.

After the patch has been merged it is now 
https://phabricator.wikimedia.org/tag/upstream/ as we wait on an answer 
regarding unbreaking Python 2.6 support: 
https://github.com/jdunck/python-unicodecsv/issues/62


TASK DETAIL
  https://phabricator.wikimedia.org/T113222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise
Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T113222: unicodecsv has dropped support for Python 2.6

2015-09-21 Thread XZise 
XZise added a project: Upstream.
XZise set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T113222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise
Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Krenair



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T113222: unicodecsv has dropped support for Python 2.6

2015-09-21 Thread jayvdb 
jayvdb created this task.
jayvdb assigned this task to XZise.
jayvdb added a subscriber: jayvdb.
jayvdb added a project: pywikibot-core.
Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  `unicodecsv` 0.14 has dropped support for Python 2.6.
  This is an intentional change: 
https://github.com/jdunck/python-unicodecsv/commit/1e2736c6fd73f6b7e53dfc2466700a9e8d2bffac

TASK DETAIL
  https://phabricator.wikimedia.org/T113222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise, jayvdb
Cc: Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T108904: autotranslate bug in interwiki.py with -wiktionary

2015-09-21 Thread JAnD 
JAnD added a comment.

Seems to works as expected


TASK DETAIL
  https://phabricator.wikimedia.org/T108904

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Malafaya, JAnD
Cc: gerritbot, Hydriz, Malafaya, Aklapper, JAnD, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T108904: autotranslate bug in interwiki.py with -wiktionary

2015-09-21 Thread Malafaya 
Malafaya closed this task as "Resolved".
Malafaya claimed this task.
Malafaya set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T108904

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Malafaya
Cc: gerritbot, Hydriz, Malafaya, Aklapper, JAnD, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T108904: autotranslate bug in interwiki.py with -wiktionary

2015-09-21 Thread Malafaya 
Malafaya added a comment.

@JAnD, it should be fixed. Please confirm. Thanks.


TASK DETAIL
  https://phabricator.wikimedia.org/T108904

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Malafaya
Cc: gerritbot, Hydriz, Malafaya, Aklapper, JAnD, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113222: unicodecsv has dropped support for Python 2.6

2015-09-21 Thread gerritbot 
gerritbot added a comment.

Change 239812 merged by jenkins-bot:
[FIX] Use Python 2.6 compatible unicodecsv version

https://gerrit.wikimedia.org/r/239812


TASK DETAIL
  https://phabricator.wikimedia.org/T113222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise, gerritbot
Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Krenair



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread jayvdb 
jayvdb added a comment.

The bug with regards to qualifiers vs references objects slipped in during 
https://phabricator.wikimedia.org/rPWBCcc62fbbac21f09e5e24b95df391ff25527456ee8 
, which changed `qualifierFromJSON` so that `fromJSON` was called with `hash` 
provided.

Prior to that, since 
https://phabricator.wikimedia.org/rPWBCea33047d4c0f31263e125d5253162b083f86869e,
 `fromJSON` always set `isQualifier = True` even for primary claims which were 
neither qualifier or reference, but that is a different bug.

I agree with the patch, which solves both bugs.  Anyone calling `fromJSON` for 
a reference or a qualifier should have been using `referenceFromJSON` or 
`qualifierFromJSON`, which have existed for over two years, so there is no 
excuse for using `fromJSON` with a reference or a qualifier.


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Retitled] T102477: login script -pass parameter ignored

2015-09-21 Thread jayvdb 
jayvdb changed the title from "pass parameter in login script ignored" to 
"login script -pass parameter ignored".
jayvdb set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T102477

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: Xqt, Shloub, Aklapper, pywikibot-bugs-list, XZise



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T113329: Pywikibot login not working with multiprocessing

2015-09-21 Thread Negative24 
Negative24 created this task.
Negative24 assigned this task to jayvdb.
Negative24 added a subscriber: Negative24.
Negative24 added projects: Pywikibot-login.py, Pywikibot-Commons.
Herald added subscribers: pywikibot-bugs-list, Avicennasis, Aklapper.

TASK DESCRIPTION
  When moving from the threading module to multiprocessing, I noticed [[ 
https://github.com/jdloft/bot24 | my project ]]'s `clean_sandbox.py` script 
wouldn't finish executing because of line 104 which is `self.site.login()`. I'm 
not sure what's different between the multiprocessing module and threading that 
would make the Pywikibot login script break.
  Commit: 
https://github.com/jdloft/bot24/commit/bbc4fffb47543805296d03d9efe3e4a4f426ce5b 
(multiprocessing branch)
  Main script: https://github.com/jdloft/bot24/blob/multiprocessing/main.py
  Clean_sandbox: 
https://github.com/jdloft/bot24/blob/multiprocessing/scripts/clean_sandbox.py#L104

TASK DETAIL
  https://phabricator.wikimedia.org/T113329

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb, Negative24
Cc: Aklapper, Avicennasis, Negative24, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread gerritbot 
gerritbot added a comment.

Change 239780 merged by jenkins-bot:
Correctly identify qualifier from JSON

https://gerrit.wikimedia.org/r/239780


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread jayvdb 
jayvdb edited the task description.
jayvdb set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T85385: Implement "Monolingual text" in Pywikibot

2015-09-21 Thread Lokal_Profil 
Lokal_Profil added a subscriber: Lokal_Profil.

TASK DETAIL
  https://phabricator.wikimedia.org/T85385

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, gerritbot, Smalyshev, Ricordisamoa, jayvdb, Aklapper, 
pywikibot-bugs-list, Multichill, Liuxinyu970226, Lydia_Pintscher, 
Wikidata-bugs, aude



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T108904: autotranslate bug in interwiki.py with -wiktionary

2015-09-21 Thread Hydriz 
Hydriz added a comment.

Thanks for this fix! Will deploy this change out on Thursday


TASK DETAIL
  https://phabricator.wikimedia.org/T108904

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Malafaya, Hydriz
Cc: gerritbot, Hydriz, Malafaya, Aklapper, JAnD, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread Lokal_Profil 
Lokal_Profil added a comment.

To clarify. The source of the above error is an false assumption that 
qualifiers don't have a hash property.


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T108904: autotranslate bug in interwiki.py with -wiktionary

2015-09-21 Thread gerritbot 
gerritbot added a comment.

Change 238435 merged by jenkins-bot:
[FIX] Skip auto translations for -wiktionary mode

https://gerrit.wikimedia.org/r/238435


TASK DETAIL
  https://phabricator.wikimedia.org/T108904

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Hydriz, Malafaya, Aklapper, JAnD, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113222: unicodecsv has dropped support for Python 2.6

2015-09-21 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 239812 had a related patch set uploaded (by XZise):
[FIX] Use Python 2.6 compatible unicodecsv version

https://gerrit.wikimedia.org/r/239812


TASK DETAIL
  https://phabricator.wikimedia.org/T113222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise, gerritbot
Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T113222: unicodecsv has dropped support for Python 2.6

2015-09-21 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T113222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise, gerritbot
Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T113222: unicodecsv has dropped support for Python 2.6

2015-09-21 Thread jayvdb 
jayvdb added a project: Pywikibot-tests.
jayvdb added a comment.

This has caused our `wikistats` tests to fail: 
https://travis-ci.org/wikimedia/pywikibot-core/jobs/81345284#L3371
script `data_ingestion` will also fail on Python 2.6


TASK DETAIL
  https://phabricator.wikimedia.org/T113222

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise, jayvdb
Cc: gerritbot, Aklapper, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 239780 had a related patch set uploaded (by Lokal Profil):
Correctly identify qualifier from JSON

https://gerrit.wikimedia.org/r/239780


TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T113212: qualifier misidentified in fromJSON()

2015-09-21 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T113212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs