[Qemu-commits] [qemu/qemu] 62663f: migration/ram.c: API Conversion qemu_mutex_lock(), ...
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 62663f08a75dbbddb745c80a00b09e298ede641a
https://github.com/qemu/qemu/commit/62663f08a75dbbddb745c80a00b09e298ede641a
Author: Will Gyda
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/ram.c
Log Message:
---
migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to
WITH_QEMU_LOCK_GUARD macro
migration/ram.c: API Conversion qemu_mutex_lock(),
and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro
Signed-off-by: Will Gyda
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: d4a17b8f1da567b274f7c7e4846496c564c860c4
https://github.com/qemu/qemu/commit/d4a17b8f1da567b274f7c7e4846496c564c860c4
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
M migration/trace-events
Log Message:
---
migration: move trace-point from migrate_fd_error to migrate_set_error
Cover more cases by trace-point.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: 246f54e0ccc288239fae78ec9e401ba070667b0b
https://github.com/qemu/qemu/commit/246f54e0ccc288239fae78ec9e401ba070667b0b
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
Log Message:
---
migration: process_incoming_migration_co(): complete cleanup on failure
Make call to migration_incoming_state_destroy(), instead of doing only
partial of it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: 30116e9079e3f395ef186960d986c7d073d7eb8a
https://github.com/qemu/qemu/commit/30116e9079e3f395ef186960d986c7d073d7eb8a
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
Log Message:
---
migration: process_incoming_migration_co(): fix reporting s->error
It's bad idea to leave critical section with error object freed, but
s->error still set, this theoretically may lead to use-after-free
crash. Let's avoid it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: f84eaa9ffdcf00a81922fc1380870775a60792bf
https://github.com/qemu/qemu/commit/f84eaa9ffdcf00a81922fc1380870775a60792bf
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
Log Message:
---
migration: process_incoming_migration_co(): rework error reporting
Unify error reporting in the function. This simplifies the following
commit, which will not-exit-on-error behavior variant to the function.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: dbea1c89dad37a6ab96befd017d33edaa50ded0a
https://github.com/qemu/qemu/commit/dbea1c89dad37a6ab96befd017d33edaa50ded0a
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration-hmp-cmds.c
M migration/migration.c
M migration/migration.h
M qapi/migration.json
M system/vl.c
Log Message:
---
qapi: introduce exit-on-error parameter for migrate-incoming
Now we do set MIGRATION_FAILED state, but don't give a chance to
orchestrator to query migration state and get the error.
Let's provide a possibility for QMP-based orchestrators to get an error
like with outgoing migration.
For hmp_migrate_incoming(), let's enable the new behavior: HMP is not
and ABI, it's mostly intended to use by developer and it makes sense
not to stop the process.
For x-exit-preconfig, let's keep the old behavior:
- it's called from init(), so here we want to keep current behavior by
default
- it does exit on error by itself as well
So, if we want to change the behavior of x-exit-preconfig, it should be
another patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Markus Armbruster
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: f7b1cd3c2ebbc102b8edfacd5c5cd10c04dc887d
https://github.com/qemu/qemu/commit/f7b1cd3c2ebbc102b8edfacd5c5cd10c04dc887d
Author: Fabiano Rosas
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M docs/about/deprecated.rst
M docs/about/removed-features.rst
M migration/migration-hmp-cmds.c
M migration/migration.c
M qapi/migration.json
Log Message:
---
migration: Remove 'skipped' field from MigrationStats
The 'skipped' field of the MigrationStats struct has been deprecated
in 8.1. Time to remove it.
Deprecation commit 7b24d32634 ("migration: skipped field is really
obsolete.").
Reviewed-by: Markus
[Qemu-commits] [qemu/qemu] 62663f: migration/ram.c: API Conversion qemu_mutex_lock(), ...
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 62663f08a75dbbddb745c80a00b09e298ede641a
https://github.com/qemu/qemu/commit/62663f08a75dbbddb745c80a00b09e298ede641a
Author: Will Gyda
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/ram.c
Log Message:
---
migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to
WITH_QEMU_LOCK_GUARD macro
migration/ram.c: API Conversion qemu_mutex_lock(),
and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro
Signed-off-by: Will Gyda
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: d4a17b8f1da567b274f7c7e4846496c564c860c4
https://github.com/qemu/qemu/commit/d4a17b8f1da567b274f7c7e4846496c564c860c4
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
M migration/trace-events
Log Message:
---
migration: move trace-point from migrate_fd_error to migrate_set_error
Cover more cases by trace-point.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: 246f54e0ccc288239fae78ec9e401ba070667b0b
https://github.com/qemu/qemu/commit/246f54e0ccc288239fae78ec9e401ba070667b0b
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
Log Message:
---
migration: process_incoming_migration_co(): complete cleanup on failure
Make call to migration_incoming_state_destroy(), instead of doing only
partial of it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: 30116e9079e3f395ef186960d986c7d073d7eb8a
https://github.com/qemu/qemu/commit/30116e9079e3f395ef186960d986c7d073d7eb8a
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
Log Message:
---
migration: process_incoming_migration_co(): fix reporting s->error
It's bad idea to leave critical section with error object freed, but
s->error still set, this theoretically may lead to use-after-free
crash. Let's avoid it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: f84eaa9ffdcf00a81922fc1380870775a60792bf
https://github.com/qemu/qemu/commit/f84eaa9ffdcf00a81922fc1380870775a60792bf
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration.c
Log Message:
---
migration: process_incoming_migration_co(): rework error reporting
Unify error reporting in the function. This simplifies the following
commit, which will not-exit-on-error behavior variant to the function.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: dbea1c89dad37a6ab96befd017d33edaa50ded0a
https://github.com/qemu/qemu/commit/dbea1c89dad37a6ab96befd017d33edaa50ded0a
Author: Vladimir Sementsov-Ogievskiy
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M migration/migration-hmp-cmds.c
M migration/migration.c
M migration/migration.h
M qapi/migration.json
M system/vl.c
Log Message:
---
qapi: introduce exit-on-error parameter for migrate-incoming
Now we do set MIGRATION_FAILED state, but don't give a chance to
orchestrator to query migration state and get the error.
Let's provide a possibility for QMP-based orchestrators to get an error
like with outgoing migration.
For hmp_migrate_incoming(), let's enable the new behavior: HMP is not
and ABI, it's mostly intended to use by developer and it makes sense
not to stop the process.
For x-exit-preconfig, let's keep the old behavior:
- it's called from init(), so here we want to keep current behavior by
default
- it does exit on error by itself as well
So, if we want to change the behavior of x-exit-preconfig, it should be
another patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Markus Armbruster
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Commit: f7b1cd3c2ebbc102b8edfacd5c5cd10c04dc887d
https://github.com/qemu/qemu/commit/f7b1cd3c2ebbc102b8edfacd5c5cd10c04dc887d
Author: Fabiano Rosas
Date: 2024-05-08 (Wed, 08 May 2024)
Changed paths:
M docs/about/deprecated.rst
M docs/about/removed-features.rst
M migration/migration-hmp-cmds.c
M migration/migration.c
M qapi/migration.json
Log Message:
---
migration: Remove 'skipped' field from MigrationStats
The 'skipped' field of the MigrationStats struct has been deprecated
in 8.1. Time to remove it.
Deprecation commit 7b24d32634 ("migration: skipped field is really
obsolete.").
Reviewed-by: Markus
