[Qemu-commits] [qemu/qemu] a44da2: target/riscv: Update the ePMP CSR address
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: a44da25aa69a7a3588a33607a8067c87b3b5a68e https://github.com/qemu/qemu/commit/a44da25aa69a7a3588a33607a8067c87b3b5a68e Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M target/riscv/cpu.c M target/riscv/cpu_bits.h Log Message: --- target/riscv: Update the ePMP CSR address Update the ePMP CSRs to match the 0.9.3 ePMP spec https://github.com/riscv/riscv-tee/blob/61455747230a26002d741f64879dd78cc9689323/Smepmp/Smepmp.pdf Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Message-id: 28c908de60b9b04fa20e63d113885c98586053f3.1630543194.git.alistair.fran...@wdc.com Commit: 15732b8ed290460334ee58dd25939da733f362fd https://github.com/qemu/qemu/commit/15732b8ed290460334ee58dd25939da733f362fd Author: LIU Zhiwei Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M target/riscv/csr.c Log Message: --- target/riscv: Fix satp write These variables should be target_ulong. If truncated to int, the bool conditions they indicate will be wrong. As satp is very important for Linux, this bug almost fails every boot. Signed-off-by: LIU Zhiwei Reviewed-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210901124539.222868-1-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis Commit: 0f0b70eeecdd4e0f29efe28a7ffec01cbe5c43bf https://github.com/qemu/qemu/commit/0f0b70eeecdd4e0f29efe28a7ffec01cbe5c43bf Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M target/riscv/cpu.c Log Message: --- target/riscv: Expose interrupt pending bits as GPIO lines Expose the 12 interrupt pending bits in MIP as GPIO lines. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Bin Meng Tested-by: Bin Meng Message-id: 069d6162f0bc2f4a4f5a44e73f6442b11c703c53.1630301632.git.alistair.fran...@wdc.com Commit: a714b8aa029c2a6cc0b99a798f4f8b6d4282e711 https://github.com/qemu/qemu/commit/a714b8aa029c2a6cc0b99a798f4f8b6d4282e711 Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/intc/sifive_clint.c M include/hw/intc/sifive_clint.h Log Message: --- hw/intc: sifive_clint: Use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the timer and soft MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: LIU Zhiwei Message-id: 946e1ef5e268b24084c7ddad84c146de62a56736.1630301632.git.alistair.fran...@wdc.com Commit: e5cc6aaeb51dd0d80e1f5a6d6a6808d6355958aa https://github.com/qemu/qemu/commit/e5cc6aaeb51dd0d80e1f5a6d6a6808d6355958aa Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/intc/ibex_plic.c M hw/riscv/opentitan.c M include/hw/intc/ibex_plic.h Log Message: --- hw/intc: ibex_plic: Convert the PLIC to use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the external MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 0a76946981852f5bd15f0c37ab35b253371027a8.1630301632.git.alistair.fran...@wdc.com Commit: f436ecc3156dea7edce97e7c247e3667203f5c8b https://github.com/qemu/qemu/commit/f436ecc3156dea7edce97e7c247e3667203f5c8b Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/intc/sifive_plic.c M hw/riscv/microchip_pfsoc.c M hw/riscv/shakti_c.c M hw/riscv/sifive_e.c M hw/riscv/sifive_u.c M hw/riscv/virt.c M include/hw/intc/sifive_plic.h Log Message: --- hw/intc: sifive_plic: Convert the PLIC to use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the external MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Bin Meng Tested-by: Bin Meng Message-id: 0364190bfa935058a845c0fa1ecf650328840ad5.1630301632.git.alistair.fran...@wdc.com Commit: 57a3a6226529e60ef4eb5e11b577f2e532a72acc https://github.com/qemu/qemu/commit/57a3a6226529e60ef4eb5e11b577f2e532a72acc Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/riscv/opentitan.c M hw/timer/ibex_timer.c M include/hw/timer/ibex_timer.h Log Message: --- hw/intc: ibex_timer: Convert the timer to use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the timer MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id:
[Qemu-commits] [qemu/qemu] 8b1d5b: include/exec: Move cpu_signal_handler declaration
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 8b1d5b3c3507d062d7611a64a81989e8903605ed https://github.com/qemu/qemu/commit/8b1d5b3c3507d062d7611a64a81989e8903605ed Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M include/exec/exec-all.h M target/alpha/cpu.h M target/arm/cpu.h M target/avr/cpu.h M target/cris/cpu.h M target/hexagon/cpu.h M target/hppa/cpu.h M target/i386/cpu.h M target/m68k/cpu.h M target/microblaze/cpu.h M target/mips/cpu.h M target/mips/internal.h M target/nios2/cpu.h M target/openrisc/cpu.h M target/ppc/cpu.h M target/riscv/cpu.h M target/rx/cpu.h M target/s390x/cpu.h M target/sh4/cpu.h M target/sparc/cpu.h M target/tricore/cpu.h M target/xtensa/cpu.h Log Message: --- include/exec: Move cpu_signal_handler declaration There is nothing target specific about this. The implementation is host specific, but the declaration is 100% common. Reviewed-By: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson Commit: 0596fa11f16c81d5237da64e59e8583a971dfe1c https://github.com/qemu/qemu/commit/0596fa11f16c81d5237da64e59e8583a971dfe1c Author: Philippe Mathieu-Daudé Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M accel/tcg/cpu-exec.c Log Message: --- accel/tcg: Restrict cpu_handle_halt() to sysemu Commit 372579427a5 ("tcg: enable thread-per-vCPU") added the following comment describing EXCP_HALTED in qemu_tcg_cpu_thread_fn(): case EXCP_HALTED: /* during start-up the vCPU is reset and the thread is * kicked several times. If we don't ensure we go back * to sleep in the halted state we won't cleanly * start-up when the vCPU is enabled. * * cpu->halted should ensure we sleep in wait_io_event */ g_assert(cpu->halted); break; qemu_wait_io_event() is sysemu-specific, so we can restrict the cpu_handle_halt() call in cpu_exec() to system emulation. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210912172731.789788-2-f4...@amsat.org> Signed-off-by: Richard Henderson Commit: 10d4af5810ab0250418e34e40be817932f26ff95 https://github.com/qemu/qemu/commit/10d4af5810ab0250418e34e40be817932f26ff95 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/mips/tcg-target.c.inc Log Message: --- tcg/mips: Drop inline markers Let the compiler decide about inlining. Remove tcg_out_ext8s and tcg_out_ext16s as unused. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: d7fc9f48c3056dc1a1e69d095858742f012ae910 https://github.com/qemu/qemu/commit/d7fc9f48c3056dc1a1e69d095858742f012ae910 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/mips/tcg-target.c.inc Log Message: --- tcg/mips: Allow JAL to be out of range in tcg_out_bswap_subr Weaning off of unique alignment requirements, so allow JAL to not reach the target. TCG_TMP1 is always available for use as a scratch because it is clobbered by the subroutine being called. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 5a8f0a5dd2a9dcb60355158d04e8e8a5d41fdec6 https://github.com/qemu/qemu/commit/5a8f0a5dd2a9dcb60355158d04e8e8a5d41fdec6 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/mips/tcg-target.c.inc M tcg/mips/tcg-target.h Log Message: --- tcg/mips: Unset TCG_TARGET_HAS_direct_jump Only use indirect jumps. Finish weaning away from the unique alignment requirements for code_gen_buffer. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 3d1e8ed011ee87ab3e4688c1a22f5b909856b0a4 https://github.com/qemu/qemu/commit/3d1e8ed011ee87ab3e4688c1a22f5b909856b0a4 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/region.c Log Message: --- tcg/mips: Drop special alignment for code_gen_buffer Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 897fd616fdb1347b903c81f101f03eb6e6474246 https://github.com/qemu/qemu/commit/897fd616fdb1347b903c81f101f03eb6e6474246 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/sparc/tcg-target.c.inc Log Message: --- tcg/sparc: Drop inline markers Let the compiler decide about inlining. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 220b2da7f34c29412db0dc0182e36fce67c8a9e4 https://github.com/qemu/qemu/commit/220b2da7f34c29412db0dc0182e36fce67c8a9e4 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021)
[Qemu-commits] [qemu/qemu] 8b1d5b: include/exec: Move cpu_signal_handler declaration
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 8b1d5b3c3507d062d7611a64a81989e8903605ed https://github.com/qemu/qemu/commit/8b1d5b3c3507d062d7611a64a81989e8903605ed Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M include/exec/exec-all.h M target/alpha/cpu.h M target/arm/cpu.h M target/avr/cpu.h M target/cris/cpu.h M target/hexagon/cpu.h M target/hppa/cpu.h M target/i386/cpu.h M target/m68k/cpu.h M target/microblaze/cpu.h M target/mips/cpu.h M target/mips/internal.h M target/nios2/cpu.h M target/openrisc/cpu.h M target/ppc/cpu.h M target/riscv/cpu.h M target/rx/cpu.h M target/s390x/cpu.h M target/sh4/cpu.h M target/sparc/cpu.h M target/tricore/cpu.h M target/xtensa/cpu.h Log Message: --- include/exec: Move cpu_signal_handler declaration There is nothing target specific about this. The implementation is host specific, but the declaration is 100% common. Reviewed-By: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson Commit: 0596fa11f16c81d5237da64e59e8583a971dfe1c https://github.com/qemu/qemu/commit/0596fa11f16c81d5237da64e59e8583a971dfe1c Author: Philippe Mathieu-Daudé Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M accel/tcg/cpu-exec.c Log Message: --- accel/tcg: Restrict cpu_handle_halt() to sysemu Commit 372579427a5 ("tcg: enable thread-per-vCPU") added the following comment describing EXCP_HALTED in qemu_tcg_cpu_thread_fn(): case EXCP_HALTED: /* during start-up the vCPU is reset and the thread is * kicked several times. If we don't ensure we go back * to sleep in the halted state we won't cleanly * start-up when the vCPU is enabled. * * cpu->halted should ensure we sleep in wait_io_event */ g_assert(cpu->halted); break; qemu_wait_io_event() is sysemu-specific, so we can restrict the cpu_handle_halt() call in cpu_exec() to system emulation. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210912172731.789788-2-f4...@amsat.org> Signed-off-by: Richard Henderson Commit: 10d4af5810ab0250418e34e40be817932f26ff95 https://github.com/qemu/qemu/commit/10d4af5810ab0250418e34e40be817932f26ff95 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/mips/tcg-target.c.inc Log Message: --- tcg/mips: Drop inline markers Let the compiler decide about inlining. Remove tcg_out_ext8s and tcg_out_ext16s as unused. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: d7fc9f48c3056dc1a1e69d095858742f012ae910 https://github.com/qemu/qemu/commit/d7fc9f48c3056dc1a1e69d095858742f012ae910 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/mips/tcg-target.c.inc Log Message: --- tcg/mips: Allow JAL to be out of range in tcg_out_bswap_subr Weaning off of unique alignment requirements, so allow JAL to not reach the target. TCG_TMP1 is always available for use as a scratch because it is clobbered by the subroutine being called. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 5a8f0a5dd2a9dcb60355158d04e8e8a5d41fdec6 https://github.com/qemu/qemu/commit/5a8f0a5dd2a9dcb60355158d04e8e8a5d41fdec6 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/mips/tcg-target.c.inc M tcg/mips/tcg-target.h Log Message: --- tcg/mips: Unset TCG_TARGET_HAS_direct_jump Only use indirect jumps. Finish weaning away from the unique alignment requirements for code_gen_buffer. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 3d1e8ed011ee87ab3e4688c1a22f5b909856b0a4 https://github.com/qemu/qemu/commit/3d1e8ed011ee87ab3e4688c1a22f5b909856b0a4 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/region.c Log Message: --- tcg/mips: Drop special alignment for code_gen_buffer Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 897fd616fdb1347b903c81f101f03eb6e6474246 https://github.com/qemu/qemu/commit/897fd616fdb1347b903c81f101f03eb6e6474246 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M tcg/sparc/tcg-target.c.inc Log Message: --- tcg/sparc: Drop inline markers Let the compiler decide about inlining. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 220b2da7f34c29412db0dc0182e36fce67c8a9e4 https://github.com/qemu/qemu/commit/220b2da7f34c29412db0dc0182e36fce67c8a9e4 Author: Richard Henderson Date: 2021-09-21 (Tue, 21 Sep 2021)
[Qemu-commits] [qemu/qemu] 025720: python/aqmp: add greeting property to QMPClient
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 0257209a09793bfaf1b662faad5558e7011e748a https://github.com/qemu/qemu/commit/0257209a09793bfaf1b662faad5558e7011e748a Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/qmp_client.py Log Message: --- python/aqmp: add greeting property to QMPClient Expose the greeting as a read-only property of QMPClient so it can be retrieved at-will. Signed-off-by: John Snow Reviewed-by: Hanna Reitz Reviewed-by: Paolo Bonzini Message-id: 20210923004938.363-2-js...@redhat.com Signed-off-by: John Snow Commit: 16cce725ed87e3ed5901c93e61514840c989216a https://github.com/qemu/qemu/commit/16cce725ed87e3ed5901c93e61514840c989216a Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/events.py Log Message: --- python/aqmp: add .empty() method to EventListener Synchronous clients may want to know if they're about to block waiting for an event or not. A method such as this is necessary to implement a compatible interface for the old QEMUMonitorProtocol using the new async internals. Signed-off-by: John Snow Reviewed-by: Hanna Reitz Reviewed-by: Paolo Bonzini Message-id: 20210923004938.363-3-js...@redhat.com Signed-off-by: John Snow Commit: 6bfebc7306e42910cd33553d9ed385ef475d8196 https://github.com/qemu/qemu/commit/6bfebc7306e42910cd33553d9ed385ef475d8196 Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/events.py Log Message: --- python/aqmp: Return cleared events from EventListener.clear() This serves two purposes: (1) It is now possible to discern whether or not clear() removed any event(s) from the queue with absolute certainty, and (2) It is now very easy to get a List of all pending events in one chunk, which is useful for the sync bridge. Signed-off-by: John Snow Reviewed-by: Hanna Reitz Reviewed-by: Paolo Bonzini Message-id: 20210923004938.363-4-js...@redhat.com Signed-off-by: John Snow Commit: 6e2f6ec5615f50c38e21542bb66bb690a289cbfc https://github.com/qemu/qemu/commit/6e2f6ec5615f50c38e21542bb66bb690a289cbfc Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/qmp_client.py Log Message: --- python/aqmp: add send_fd_scm Add an implementation for send_fd_scm to the async QMP implementation. Like socket_scm_helper mentions, a non-empty payload is required for QEMU to process the ancillary data. A space is most useful because it does not disturb the parsing of subsequent JSON objects. A note on "voiding the warranty": Python 3.11 removes support for calling sendmsg directly from a transport's socket. There is no other interface for doing this, our use case is, I suspect, "quite unique". As far as I can tell, this is safe to do -- send_fd_scm is a synchronous function and we can be guaranteed that the async coroutines will *not* be running when it is invoked. In testing, it works correctly. I investigated quite thoroughly the possibility of creating my own asyncio Transport (The class that ultimately manages the raw socket object) so that I could manage the socket myself, but this is so wildly invasive and unportable I scrapped the idea. It would involve a lot of copy-pasting of various python utilities and classes just to re-create the same infrastructure, and for extremely little benefit. Nah. Just boldly void the warranty instead, while I try to follow up on https://bugs.python.org/issue43232 Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Message-id: 20210923004938.363-5-js...@redhat.com Signed-off-by: John Snow Commit: 58026b11f36f9a19fd35fdfbfa50be7bd78e70a5 https://github.com/qemu/qemu/commit/58026b11f36f9a19fd35fdfbfa50be7bd78e70a5 Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/models.py Log Message: --- python/aqmp: Add dict conversion method to Greeting object The iotests interface expects to return the greeting as a dict; AQMP offers it as a rich object. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Message-id: 20210923004938.363-6-js...@redhat.com Signed-off-by: John Snow Commit: 3e55dc35b8ed8cea53ef2604874d2fe882fbadc1 https://github.com/qemu/qemu/commit/3e55dc35b8ed8cea53ef2604874d2fe882fbadc1 Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/protocol.py Log Message: --- python/aqmp: Reduce severity of EOFError-caused loop terminations When we encounter an EOFError, we don't know if it's an "error" in the perspective of the user of the library yet. Therefore, we should not log it as an error. Reduce the severity of this logging message to "INFO" to indicate that it's
[Qemu-commits] [qemu/qemu] 025720: python/aqmp: add greeting property to QMPClient
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 0257209a09793bfaf1b662faad5558e7011e748a https://github.com/qemu/qemu/commit/0257209a09793bfaf1b662faad5558e7011e748a Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/qmp_client.py Log Message: --- python/aqmp: add greeting property to QMPClient Expose the greeting as a read-only property of QMPClient so it can be retrieved at-will. Signed-off-by: John Snow Reviewed-by: Hanna Reitz Reviewed-by: Paolo Bonzini Message-id: 20210923004938.363-2-js...@redhat.com Signed-off-by: John Snow Commit: 16cce725ed87e3ed5901c93e61514840c989216a https://github.com/qemu/qemu/commit/16cce725ed87e3ed5901c93e61514840c989216a Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/events.py Log Message: --- python/aqmp: add .empty() method to EventListener Synchronous clients may want to know if they're about to block waiting for an event or not. A method such as this is necessary to implement a compatible interface for the old QEMUMonitorProtocol using the new async internals. Signed-off-by: John Snow Reviewed-by: Hanna Reitz Reviewed-by: Paolo Bonzini Message-id: 20210923004938.363-3-js...@redhat.com Signed-off-by: John Snow Commit: 6bfebc7306e42910cd33553d9ed385ef475d8196 https://github.com/qemu/qemu/commit/6bfebc7306e42910cd33553d9ed385ef475d8196 Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/events.py Log Message: --- python/aqmp: Return cleared events from EventListener.clear() This serves two purposes: (1) It is now possible to discern whether or not clear() removed any event(s) from the queue with absolute certainty, and (2) It is now very easy to get a List of all pending events in one chunk, which is useful for the sync bridge. Signed-off-by: John Snow Reviewed-by: Hanna Reitz Reviewed-by: Paolo Bonzini Message-id: 20210923004938.363-4-js...@redhat.com Signed-off-by: John Snow Commit: 6e2f6ec5615f50c38e21542bb66bb690a289cbfc https://github.com/qemu/qemu/commit/6e2f6ec5615f50c38e21542bb66bb690a289cbfc Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/qmp_client.py Log Message: --- python/aqmp: add send_fd_scm Add an implementation for send_fd_scm to the async QMP implementation. Like socket_scm_helper mentions, a non-empty payload is required for QEMU to process the ancillary data. A space is most useful because it does not disturb the parsing of subsequent JSON objects. A note on "voiding the warranty": Python 3.11 removes support for calling sendmsg directly from a transport's socket. There is no other interface for doing this, our use case is, I suspect, "quite unique". As far as I can tell, this is safe to do -- send_fd_scm is a synchronous function and we can be guaranteed that the async coroutines will *not* be running when it is invoked. In testing, it works correctly. I investigated quite thoroughly the possibility of creating my own asyncio Transport (The class that ultimately manages the raw socket object) so that I could manage the socket myself, but this is so wildly invasive and unportable I scrapped the idea. It would involve a lot of copy-pasting of various python utilities and classes just to re-create the same infrastructure, and for extremely little benefit. Nah. Just boldly void the warranty instead, while I try to follow up on https://bugs.python.org/issue43232 Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Message-id: 20210923004938.363-5-js...@redhat.com Signed-off-by: John Snow Commit: 58026b11f36f9a19fd35fdfbfa50be7bd78e70a5 https://github.com/qemu/qemu/commit/58026b11f36f9a19fd35fdfbfa50be7bd78e70a5 Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/models.py Log Message: --- python/aqmp: Add dict conversion method to Greeting object The iotests interface expects to return the greeting as a dict; AQMP offers it as a rich object. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Message-id: 20210923004938.363-6-js...@redhat.com Signed-off-by: John Snow Commit: 3e55dc35b8ed8cea53ef2604874d2fe882fbadc1 https://github.com/qemu/qemu/commit/3e55dc35b8ed8cea53ef2604874d2fe882fbadc1 Author: John Snow Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M python/qemu/aqmp/protocol.py Log Message: --- python/aqmp: Reduce severity of EOFError-caused loop terminations When we encounter an EOFError, we don't know if it's an "error" in the perspective of the user of the library yet. Therefore, we should not log it as an error. Reduce the severity of this logging message to "INFO" to indicate that it's
[Qemu-commits] [qemu/qemu] 8fc898: block/backup: avoid integer overflow of `max-workers`
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 8fc898ce0b3e7fea8c7c2a8d8977f2a9b77ecebf https://github.com/qemu/qemu/commit/8fc898ce0b3e7fea8c7c2a8d8977f2a9b77ecebf Author: Stefano Garzarella Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M block/backup.c Log Message: --- block/backup: avoid integer overflow of `max-workers` QAPI generates `struct BackupPerf` where `max-workers` value is stored in an `int64_t` variable. But block_copy_async(), and the underlying code, uses an `int` parameter. At the end that variable is used to initialize `max_busy_tasks` in block/aio_task.c causing the following assertion failure if a value greater than INT_MAX(2147483647) is used: ../block/aio_task.c:63: aio_task_pool_wait_one: Assertion `pool->busy_tasks > 0' failed. Let's check that `max-workers` doesn't exceed INT_MAX and print an error in that case. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2009310 Signed-off-by: Stefano Garzarella Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211005161157.282396-2-sgarz...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: a9515df4d66da34cbc2938e4c1f46015fc74ff93 https://github.com/qemu/qemu/commit/a9515df4d66da34cbc2938e4c1f46015fc74ff93 Author: Stefano Garzarella Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M block/aio_task.c Log Message: --- block/aio_task: assert `max_busy_tasks` is greater than 0 All code in block/aio_task.c expects `max_busy_tasks` to always be greater than 0. Assert this condition during the AioTaskPool creation where `max_busy_tasks` is set. Signed-off-by: Stefano Garzarella Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211005161157.282396-3-sgarz...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: d431131439f228626aedc6d211c73b2a3616d5e1 https://github.com/qemu/qemu/commit/d431131439f228626aedc6d211c73b2a3616d5e1 Author: Hanna Reitz Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M job.c Log Message: --- job: Context changes in job_completed_txn_abort() Finalizing the job may cause its AioContext to change. This is noted by job_exit(), which points at job_txn_apply() to take this fact into account. However, job_completed() does not necessarily invoke job_txn_apply() (through job_completed_txn_success()), but potentially also job_completed_txn_abort(). The latter stores the context in a local variable, and so always acquires the same context at its end that it has released in the beginning -- which may be a different context from the one that job_exit() releases at its end. If it is different, qemu aborts ("qemu_mutex_unlock_impl: Operation not permitted"). Drop the local @outer_ctx variable from job_completed_txn_abort(), and instead re-acquire the actual job's context at the end of the function, so job_exit() will release the same. Signed-off-by: Hanna Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006151940.214590-2-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: a3810da5cff152a2a1b2d25a8b8080f640e491b6 https://github.com/qemu/qemu/commit/a3810da5cff152a2a1b2d25a8b8080f640e491b6 Author: Hanna Reitz Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M block/mirror.c Log Message: --- mirror: Keep s->synced on error An error does not take us out of the READY phase, which is what s->synced signifies. It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->synced never meant that source and target are in sync, only that they were at some point (and at that point we transitioned into the READY phase). The tangible problem is that we transition to READY once we are in sync and s->synced is false. By resetting s->synced here, we will transition from READY to READY once the error is resolved (if the job keeps running), and that transition is not allowed. Signed-off-by: Hanna Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Message-Id: <20211006151940.214590-3-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: 447162242803bdc38bb198312e1d0a0675948424 https://github.com/qemu/qemu/commit/447162242803bdc38bb198312e1d0a0675948424 Author: Hanna Reitz Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M block/mirror.c Log Message: --- mirror: Drop s->synced As of HEAD^, there is no meaning to s->synced other than whether the job is READY or not. job_is_ready() gives us that information, too. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Hanna Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Message-Id: <20211006151940.214590-4-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit:
[Qemu-commits] [qemu/qemu] 601454: MAINTAINERS: Add myself as reviewer of the 'Memory...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 60145485232cf1c4f3e9314ddb8a99d0473d785a https://github.com/qemu/qemu/commit/60145485232cf1c4f3e9314ddb8a99d0473d785a Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- MAINTAINERS: Add myself as reviewer of the 'Memory API' Having developed interest with the Memory API, volunteer to review the patches. Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Hildenbrand Message-Id: <20211007091949.319404-1-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 8009806ec81ff2caa711c99e87ca394f9ba50565 https://github.com/qemu/qemu/commit/8009806ec81ff2caa711c99e87ca394f9ba50565 Author: Paolo Bonzini Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M tests/Makefile.include Log Message: --- tests: add missing dependency for check-block qemu-iotests run qemu-storage-daemon, make sure it is up to date. Signed-off-by: Paolo Bonzini Commit: 097a5f19a357b6bc699a05ccd119bfa89ea409cc https://github.com/qemu/qemu/commit/097a5f19a357b6bc699a05ccd119bfa89ea409cc Author: Paolo Bonzini Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M tests/Makefile.include Log Message: --- build: fix "make check" without earlier "make" "make check", if not preceded by "make", will not build the tools needed by qemu-iotests. This happens because qemu-iotests, aka "make check-block", is not yet part of meson.build. While at it, remove the reference to the now-dead QEMU_IOTESTS_HELPERS-y variable. Signed-off-by: Paolo Bonzini Commit: ecc00666a020368ec2c3712c40386dc7ea75a8a9 https://github.com/qemu/qemu/commit/ecc00666a020368ec2c3712c40386dc7ea75a8a9 Author: Paolo Bonzini Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M tests/qemu-iotests/testrunner.py Log Message: --- qemu-iotests: flush after every test This makes it possible to see what is happening, even if the output of "make check-block" is not sent to a tty (for example if it is sent to grep or tee). Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 6bd17dccb63e152266cf7a7399931c9fe11bc8cf https://github.com/qemu/qemu/commit/6bd17dccb63e152266cf7a7399931c9fe11bc8cf Author: Kacper Słomiński Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M meson.build M util/compatfd.c Log Message: --- util/compatfd.c: use libc signalfd wrapper instead of raw syscall This allows the use of native signalfd instead of the sigtimedwait based emulation on systems other than Linux. Signed-off-by: Kacper Słomiński Message-Id: <20210905011621.200785-1-kacper.slominsk...@gmail.com> Signed-off-by: Paolo Bonzini Commit: b50f6dc174cf391d725fca895d74c441b23e2e47 https://github.com/qemu/qemu/commit/b50f6dc174cf391d725fca895d74c441b23e2e47 Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M qapi/misc-target.json Log Message: --- qapi/misc-target: Wrap long 'SEV Attestation Report' long lines Wrap long lines before 70 characters for legibility. Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211007161716.453984-2-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 993e26058d10756f5e206742c20b0cd03a9cb973 https://github.com/qemu/qemu/commit/993e26058d10756f5e206742c20b0cd03a9cb973 Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M qapi/misc-target.json Log Message: --- qapi/misc-target: Group SEV QAPI definitions There is already a section with various SEV commands / types, so move the SEV guest attestation together. Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211007161716.453984-3-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 02310f3a91470575a103857222d3a6e8acea338e https://github.com/qemu/qemu/commit/02310f3a91470575a103857222d3a6e8acea338e Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/i386/kvm/meson.build Log Message: --- target/i386/kvm: Introduce i386_softmmu_kvm Meson source set Introduce the i386_softmmu_kvm Meson source set to be able to add features dependent on CONFIG_KVM. Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211007161716.453984-4-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 773ab6cb16b34272dc7eb8171824924c38dbeb90 https://github.com/qemu/qemu/commit/773ab6cb16b34272dc7eb8171824924c38dbeb90 Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M accel/kvm/meson.build R accel/kvm/sev-stub.c M target/i386/kvm/meson.build A
[Qemu-commits] [qemu/qemu] 452635: target/alpha: Reorg fp memory operations
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 452635318b78b98f0ef2586463334565674cb9e6 https://github.com/qemu/qemu/commit/452635318b78b98f0ef2586463334565674cb9e6 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- target/alpha: Reorg fp memory operations Pass in the context to each mini-helper, instead of an incorrectly named "flags". Separate gen_load_fp and gen_store_fp, away from the integer helpers. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 5ffcb33426aaa2906daea2eee7a5195662a6580f https://github.com/qemu/qemu/commit/5ffcb33426aaa2906daea2eee7a5195662a6580f Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- target/alpha: Reorg integer memory operations Pass in the MemOp instead of a callback. Drop the fp argument; add a locked argument. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Commit: 984b2b504942d9adb31d7743f02138fb79a73c12 https://github.com/qemu/qemu/commit/984b2b504942d9adb31d7743f02138fb79a73c12 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20211013' into staging Cleanup alpha memory ops prior to prctl PR_SET_UNALIGN # gpg: Signature made Wed 13 Oct 2021 10:34:10 AM PDT # gpg:using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F # gpg:issuer "richard.hender...@linaro.org" # gpg: Good signature from "Richard Henderson " [ultimate] * remotes/rth/tags/pull-axp-20211013: target/alpha: Reorg integer memory operations target/alpha: Reorg fp memory operations Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/946de558354c...984b2b504942
[Qemu-commits] [qemu/qemu] 601454: MAINTAINERS: Add myself as reviewer of the 'Memory...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 60145485232cf1c4f3e9314ddb8a99d0473d785a https://github.com/qemu/qemu/commit/60145485232cf1c4f3e9314ddb8a99d0473d785a Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- MAINTAINERS: Add myself as reviewer of the 'Memory API' Having developed interest with the Memory API, volunteer to review the patches. Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Hildenbrand Message-Id: <20211007091949.319404-1-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 8009806ec81ff2caa711c99e87ca394f9ba50565 https://github.com/qemu/qemu/commit/8009806ec81ff2caa711c99e87ca394f9ba50565 Author: Paolo Bonzini Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M tests/Makefile.include Log Message: --- tests: add missing dependency for check-block qemu-iotests run qemu-storage-daemon, make sure it is up to date. Signed-off-by: Paolo Bonzini Commit: 097a5f19a357b6bc699a05ccd119bfa89ea409cc https://github.com/qemu/qemu/commit/097a5f19a357b6bc699a05ccd119bfa89ea409cc Author: Paolo Bonzini Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M tests/Makefile.include Log Message: --- build: fix "make check" without earlier "make" "make check", if not preceded by "make", will not build the tools needed by qemu-iotests. This happens because qemu-iotests, aka "make check-block", is not yet part of meson.build. While at it, remove the reference to the now-dead QEMU_IOTESTS_HELPERS-y variable. Signed-off-by: Paolo Bonzini Commit: ecc00666a020368ec2c3712c40386dc7ea75a8a9 https://github.com/qemu/qemu/commit/ecc00666a020368ec2c3712c40386dc7ea75a8a9 Author: Paolo Bonzini Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M tests/qemu-iotests/testrunner.py Log Message: --- qemu-iotests: flush after every test This makes it possible to see what is happening, even if the output of "make check-block" is not sent to a tty (for example if it is sent to grep or tee). Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 6bd17dccb63e152266cf7a7399931c9fe11bc8cf https://github.com/qemu/qemu/commit/6bd17dccb63e152266cf7a7399931c9fe11bc8cf Author: Kacper Słomiński Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M meson.build M util/compatfd.c Log Message: --- util/compatfd.c: use libc signalfd wrapper instead of raw syscall This allows the use of native signalfd instead of the sigtimedwait based emulation on systems other than Linux. Signed-off-by: Kacper Słomiński Message-Id: <20210905011621.200785-1-kacper.slominsk...@gmail.com> Signed-off-by: Paolo Bonzini Commit: b50f6dc174cf391d725fca895d74c441b23e2e47 https://github.com/qemu/qemu/commit/b50f6dc174cf391d725fca895d74c441b23e2e47 Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M qapi/misc-target.json Log Message: --- qapi/misc-target: Wrap long 'SEV Attestation Report' long lines Wrap long lines before 70 characters for legibility. Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211007161716.453984-2-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 993e26058d10756f5e206742c20b0cd03a9cb973 https://github.com/qemu/qemu/commit/993e26058d10756f5e206742c20b0cd03a9cb973 Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M qapi/misc-target.json Log Message: --- qapi/misc-target: Group SEV QAPI definitions There is already a section with various SEV commands / types, so move the SEV guest attestation together. Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211007161716.453984-3-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 02310f3a91470575a103857222d3a6e8acea338e https://github.com/qemu/qemu/commit/02310f3a91470575a103857222d3a6e8acea338e Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/i386/kvm/meson.build Log Message: --- target/i386/kvm: Introduce i386_softmmu_kvm Meson source set Introduce the i386_softmmu_kvm Meson source set to be able to add features dependent on CONFIG_KVM. Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211007161716.453984-4-phi...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 773ab6cb16b34272dc7eb8171824924c38dbeb90 https://github.com/qemu/qemu/commit/773ab6cb16b34272dc7eb8171824924c38dbeb90 Author: Philippe Mathieu-Daudé Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M accel/kvm/meson.build R accel/kvm/sev-stub.c M target/i386/kvm/meson.build A
[Qemu-commits] [qemu/qemu] 452635: target/alpha: Reorg fp memory operations
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 452635318b78b98f0ef2586463334565674cb9e6 https://github.com/qemu/qemu/commit/452635318b78b98f0ef2586463334565674cb9e6 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- target/alpha: Reorg fp memory operations Pass in the context to each mini-helper, instead of an incorrectly named "flags". Separate gen_load_fp and gen_store_fp, away from the integer helpers. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 5ffcb33426aaa2906daea2eee7a5195662a6580f https://github.com/qemu/qemu/commit/5ffcb33426aaa2906daea2eee7a5195662a6580f Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- target/alpha: Reorg integer memory operations Pass in the MemOp instead of a callback. Drop the fp argument; add a locked argument. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Commit: 984b2b504942d9adb31d7743f02138fb79a73c12 https://github.com/qemu/qemu/commit/984b2b504942d9adb31d7743f02138fb79a73c12 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20211013' into staging Cleanup alpha memory ops prior to prctl PR_SET_UNALIGN # gpg: Signature made Wed 13 Oct 2021 10:34:10 AM PDT # gpg:using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F # gpg:issuer "richard.hender...@linaro.org" # gpg: Good signature from "Richard Henderson " [ultimate] * remotes/rth/tags/pull-axp-20211013: target/alpha: Reorg integer memory operations target/alpha: Reorg fp memory operations Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/946de558354c...984b2b504942
[Qemu-commits] [qemu/qemu] e770b8: pc-bios: Update hppa-firmware.img
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: e770b8cf76083cc51497b854e73f0a9bb92d1bc7 https://github.com/qemu/qemu/commit/e770b8cf76083cc51497b854e73f0a9bb92d1bc7 Author: Helge Deller Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M pc-bios/hppa-firmware.img M roms/seabios-hppa Log Message: --- pc-bios: Update hppa-firmware.img Update SeaBIOS to seabios-hppa-v2 Changes in seabios-hppa: * Include all latest upstream SeaBIOS patches * add support for the qemu "bootindex" parameter * add support for the qemu "-boot order=g-m" parameter to choose SCSI ID Signed-off-by: Helge Deller Message-Id: Signed-off-by: Richard Henderson Commit: 8be1d4ed9838f807c63695753b30865f6edc4a5c https://github.com/qemu/qemu/commit/8be1d4ed9838f807c63695753b30865f6edc4a5c Author: Richard Henderson Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M pc-bios/hppa-firmware.img M roms/seabios-hppa Log Message: --- Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20211012' into staging seabios-hppa update # gpg: Signature made Tue 12 Oct 2021 09:28:12 AM PDT # gpg:using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F # gpg:issuer "richard.hender...@linaro.org" # gpg: Good signature from "Richard Henderson " [ultimate] * remotes/rth/tags/pull-hppa-20211012: pc-bios: Update hppa-firmware.img Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/bfd9a76f9c14...8be1d4ed9838
[Qemu-commits] [qemu/qemu] f0ed36: iothread: rename PollParamInfo to IOThreadParamInfo
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: f0ed36a64f1750a0ebc5d2a5437f4740985461d7 https://github.com/qemu/qemu/commit/f0ed36a64f1750a0ebc5d2a5437f4740985461d7 Author: Stefano Garzarella Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M iothread.c Log Message: --- iothread: rename PollParamInfo to IOThreadParamInfo Commit 1793ad0247 ("iothread: add aio-max-batch parameter") added a new parameter (aio-max-batch) to IOThread and used PollParamInfo structure to handle it. Since it is not a parameter of the polling mechanism, we rename the structure to a more generic IOThreadParamInfo. Suggested-by: Kevin Wolf Signed-off-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210727145936.147032-2-sgarz...@redhat.com Signed-off-by: Stefan Hajnoczi Commit: 1cc7eada97914f090125e588497986f6f7900514 https://github.com/qemu/qemu/commit/1cc7eada97914f090125e588497986f6f7900514 Author: Stefano Garzarella Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M iothread.c Log Message: --- iothread: use IOThreadParamInfo in iothread_[set|get]_param() Commit 0445409d74 ("iothread: generalize iothread_set_param/iothread_get_param") moved common code to set and get IOThread parameters in two new functions. These functions are called inside callbacks, so we don't need to use an opaque pointer. Let's replace `void *opaque` parameter with `IOThreadParamInfo *info`. Suggested-by: Kevin Wolf Signed-off-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210727145936.147032-3-sgarz...@redhat.com Signed-off-by: Stefan Hajnoczi Commit: c09124dcb8401a0d635b4a52b295e9b3fc12392a https://github.com/qemu/qemu/commit/c09124dcb8401a0d635b4a52b295e9b3fc12392a Author: Richard Henderson Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M iothread.c Log Message: --- Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging Pull request # gpg: Signature made Mon 11 Oct 2021 05:40:35 AM PDT # gpg:using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8 # gpg: Good signature from "Stefan Hajnoczi " [full] # gpg: aka "Stefan Hajnoczi " [full] * remotes/stefanha/tags/block-pull-request: iothread: use IOThreadParamInfo in iothread_[set|get]_param() iothread: rename PollParamInfo to IOThreadParamInfo Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/15a0578903dc...c09124dcb840
[Qemu-commits] [qemu/qemu] f0ed36: iothread: rename PollParamInfo to IOThreadParamInfo
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: f0ed36a64f1750a0ebc5d2a5437f4740985461d7 https://github.com/qemu/qemu/commit/f0ed36a64f1750a0ebc5d2a5437f4740985461d7 Author: Stefano Garzarella Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M iothread.c Log Message: --- iothread: rename PollParamInfo to IOThreadParamInfo Commit 1793ad0247 ("iothread: add aio-max-batch parameter") added a new parameter (aio-max-batch) to IOThread and used PollParamInfo structure to handle it. Since it is not a parameter of the polling mechanism, we rename the structure to a more generic IOThreadParamInfo. Suggested-by: Kevin Wolf Signed-off-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210727145936.147032-2-sgarz...@redhat.com Signed-off-by: Stefan Hajnoczi Commit: 1cc7eada97914f090125e588497986f6f7900514 https://github.com/qemu/qemu/commit/1cc7eada97914f090125e588497986f6f7900514 Author: Stefano Garzarella Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M iothread.c Log Message: --- iothread: use IOThreadParamInfo in iothread_[set|get]_param() Commit 0445409d74 ("iothread: generalize iothread_set_param/iothread_get_param") moved common code to set and get IOThread parameters in two new functions. These functions are called inside callbacks, so we don't need to use an opaque pointer. Let's replace `void *opaque` parameter with `IOThreadParamInfo *info`. Suggested-by: Kevin Wolf Signed-off-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210727145936.147032-3-sgarz...@redhat.com Signed-off-by: Stefan Hajnoczi Commit: c09124dcb8401a0d635b4a52b295e9b3fc12392a https://github.com/qemu/qemu/commit/c09124dcb8401a0d635b4a52b295e9b3fc12392a Author: Richard Henderson Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M iothread.c Log Message: --- Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging Pull request # gpg: Signature made Mon 11 Oct 2021 05:40:35 AM PDT # gpg:using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8 # gpg: Good signature from "Stefan Hajnoczi " [full] # gpg: aka "Stefan Hajnoczi " [full] * remotes/stefanha/tags/block-pull-request: iothread: use IOThreadParamInfo in iothread_[set|get]_param() iothread: rename PollParamInfo to IOThreadParamInfo Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/3a76e8a42d86...c09124dcb840
[Qemu-commits] [qemu/qemu] 9557af: configure: don't override the selected host test c...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 9557af9ce94d434440d6397fb0d80748e4714e94 https://github.com/qemu/qemu/commit/9557af9ce94d434440d6397fb0d80748e4714e94 Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M configure Log Message: --- configure: don't override the selected host test compiler if defined There are not many cases you would want to do this but one is if you want to use a test friendly compiler like gcc instead of a system compiler like clang. Either way we should honour the users choice if they have made it. Signed-off-by: Alex Bennée Cc: Warner Losh Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-2-alex.ben...@linaro.org> Commit: 4f0ebed41809531e4e84658b8ac1742c4ba6966a https://github.com/qemu/qemu/commit/4f0ebed41809531e4e84658b8ac1742c4ba6966a Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M tests/tcg/multiarch/sha1.c Log Message: --- tests/tcg/sha1: remove endian include This doesn't exist in BSD world and doesn't seem to be needed by either. Signed-off-by: Alex Bennée Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-3-alex.ben...@linaro.org> Commit: 5343a837cdb0e10db05310e0da5a89843539b400 https://github.com/qemu/qemu/commit/5343a837cdb0e10db05310e0da5a89843539b400 Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M tests/tcg/multiarch/Makefile.target R tests/tcg/multiarch/float_helpers.c A tests/tcg/multiarch/libs/float_helpers.c R tests/tcg/multiarch/linux-test.c A tests/tcg/multiarch/linux/linux-test.c M tests/tcg/x86_64/Makefile.target Log Message: --- tests/tcg: move some multiarch files and make conditional We had some messy code to filter out stuff we can't build. Lets junk that and simplify the logic by pushing some stuff into subdirs. In particular we move: float_helpers into libs - not a standalone test linux-test into linux - so we only build on Linux hosts This allows for at least some of the tests to be nominally usable by *BSD user builds. Signed-off-by: Alex Bennée Cc: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-4-alex.ben...@linaro.org> Commit: 5c24acf320a0ac259447788162a3b17505ad4fb9 https://github.com/qemu/qemu/commit/5c24acf320a0ac259447788162a3b17505ad4fb9 Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M .gitlab-ci.d/container-cross.yml M tests/docker/Makefile.include M tests/docker/dockerfiles/debian-riscv64-cross.docker Log Message: --- tests/docker: promote debian-riscv64-cross to a full image To be able to cross build QEMU itself we need to include a few more libraries. These are only available in Debian's unstable ports repo for now so we need to base the riscv64 image on sid with the the minimal libs needed to build QEMU (glib/pixman). The result works but is not as clean as using build-dep to bring in more dependencies. However sid is by definition a shifting pile of sand and by keeping the list of libs minimal we reduce the chance of having an image we can't build. It's good enough for a basic cross build testing of TCG. Cc: "Daniel P. Berrangé" Signed-off-by: Richard Henderson Message-Id: <20210914185830.1378771-2-richard.hender...@linaro.org> [AJB: tweak allow_failure] Signed-off-by: Alex Bennée Message-Id: <20210917162332.3511179-5-alex.ben...@linaro.org> Commit: 9f62025141c67c5dbe5c5a04becb12add2de12cf https://github.com/qemu/qemu/commit/9f62025141c67c5dbe5c5a04becb12add2de12cf Author: Richard Henderson Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M .gitlab-ci.d/crossbuilds.yml Log Message: --- gitlab: Add cross-riscv64-system, cross-riscv64-user Signed-off-by: Richard Henderson Message-Id: <20210914185830.1378771-3-richard.hender...@linaro.org> [AJB: add allow_failure] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Willian Rampazzo Message-Id: <20210917162332.3511179-6-alex.ben...@linaro.org> Commit: 9d03f5abede84a7b05877f7adeeea967d55566a0 https://github.com/qemu/qemu/commit/9d03f5abede84a7b05877f7adeeea967d55566a0 Author: Thomas Huth Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M .travis.yml Log Message: --- travis.yml: Remove the "Release tarball" job This is a leftover from the days when we were using Travis excessively, but since x86 jobs are not really usable there anymore, this job has likely never been used since many months. Let's simply remove it now. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Message-Id: <20210917094826.466047-1-th...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20210917162332.3511179-8-alex.ben...@linaro.org> Commit:
[Qemu-commits] [qemu/qemu] 45a904: aspeed/smc: Add watchdog Control/Status Registers
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 45a904af3861b5457050e55271e1386a7040f04f https://github.com/qemu/qemu/commit/45a904af3861b5457050e55271e1386a7040f04f Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c Log Message: --- aspeed/smc: Add watchdog Control/Status Registers The Aspeed SoCs have a dual boot function for firmware fail-over recovery. The system auto-reboots from the second flash if the main flash does not boot successfully within a certain amount of time. This function is called alternate boot (ABR) in the FMC controllers. On AST2400/AST2500, ABR is enabled by hardware strapping in SCU70 to enable the 2nd watchdog timer, on AST2600, through register SCU510. If the boot on the the main flash succeeds, the firmware should disable the 2nd watchdog timer. If not, the BMC is reset and the CE0 and CE1 mappings are swapped to restart the BMC from the 2nd flash. On the AST2600, the ABR registers controlling the 2nd watchdog timer were moved from the watchdog register to the FMC controller and the FMC model should be able to control WDT2 through its own register set. This requires more work. For now, add dummy read/write handlers to let the FW disable the 2nd watchdog without error. Reviewed-by: Peter Delevoryas Reported-by: Peter Delevoryas Signed-off-by: Cédric Le Goater Commit: 32c54bd0ed622bbd1614ca9d1f5f108823f5cc11 https://github.com/qemu/qemu/commit/32c54bd0ed622bbd1614ca9d1f5f108823f5cc11 Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c Log Message: --- aspeed/smc: Introduce aspeed_smc_error() helper It unifies the errors reported by the Aspeed SMC model and also removes some use of ctrl->name which will help us for the next patches. Signed-off-by: Cédric Le Goater Commit: d0180a3ae48f71d4cb5b9cea89b49451e2dc9a47 https://github.com/qemu/qemu/commit/d0180a3ae48f71d4cb5b9cea89b49451e2dc9a47 Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c Log Message: --- aspeed/smc: Stop using the model name for the memory regions There is no real reason to use this name. It's simply nice to have in the monitor output but it's a burden for the following patch which removes the AspeedSMCController structure describing the controller. Signed-off-by: Cédric Le Goater Commit: 30b6852ce4c3398c54fc6f6c7ff5ccbf8c15cf4f https://github.com/qemu/qemu/commit/30b6852ce4c3398c54fc6f6c7ff5ccbf8c15cf4f Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/arm/aspeed_ast2600.c M hw/arm/aspeed_soc.c M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Drop AspeedSMCController structure The characteristics of the Aspeed controllers are described in a AspeedSMCController structure which is redundant with the AspeedSMCClass. Move all attributes under the class and adapt the code to use class attributes instead. This is a large change but it is functionally equivalent. Signed-off-by: Cédric Le Goater Commit: a7d78beff46f8e5c4343edca4b76675e6e55172e https://github.com/qemu/qemu/commit/a7d78beff46f8e5c4343edca4b76675e6e55172e Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/arm/aspeed.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Remove the 'flash' attribute from AspeedSMCFlash There is no need to keep a reference of the flash qdev in the AspeedSMCFlash state: the SPI bus takes ownership and will release its resources. Remove AspeedSMCFlash::flash. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Commit: 6bb55e796740a0b685831faa784efb0c38dd151c https://github.com/qemu/qemu/commit/6bb55e796740a0b685831faa784efb0c38dd151c Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/arm/aspeed.c M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash AspeedSMCFlash::size is only used to compute the initial size of the boot_rom region. Not very useful, so directly call memory_region_size() instead. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Commit: 10f915e4caefeacedf092eb90bfcce56e23e102e https://github.com/qemu/qemu/commit/10f915e4caefeacedf092eb90bfcce56e23e102e Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Rename AspeedSMCFlash 'id' to 'cs' 'cs' is a more appropriate name to index SPI flash devices. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Commit:
[Qemu-commits] [qemu/qemu] 7437b1: macfb: handle errors that occur during realize
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 7437b13eacfd05ed6817c2f05c4712ed618544e1 https://github.com/qemu/qemu/commit/7437b13eacfd05ed6817c2f05c4712ed618544e1 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: handle errors that occur during realize Make sure any errors that occur within the macfb realize chain are detected and handled correctly to prevent crashes and to ensure that error messages are reported back to the user. Signed-off-by: Mark Cave-Ayland Reviewed-by: BALATON Zoltan Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: c047862acd502c305fbdc66a4a3fd717c04fa6d2 https://github.com/qemu/qemu/commit/c047862acd502c305fbdc66a4a3fd717c04fa6d2 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: update macfb.c to use the Error API best practices As per the current Error API best practices, change macfb_commom_realize() to return a boolean indicating success to reduce errp boiler-plate handling code. Note that memory_region_init_ram_nomigrate() is also updated to use _abort to indicate a non-recoverable error, matching the behaviour recommended after similar discussions on memory API failures for the recent nubus changes. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-3-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 906c2323f1edf41b1851e7e36231023ee930aa3c https://github.com/qemu/qemu/commit/906c2323f1edf41b1851e7e36231023ee930aa3c Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: fix invalid object reference in macfb_common_realize() During realize memory_region_init_ram_nomigrate() is used to initialise the RAM memory region used for the framebuffer but the owner object reference is incorrect since MacFbState is a typedef and not a QOM type. Change the memory region owner to be the corresponding DeviceState to fix the issue and prevent random crashes during macfb_common_realize(). Signed-off-by: Mark Cave-Ayland Fixes: 8ac919a0654 ("hw/m68k: add Nubus macfb video card") Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-4-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 14d0ddfce781374b7ce40062c0afc2ed00419267 https://github.com/qemu/qemu/commit/14d0ddfce781374b7ce40062c0afc2ed00419267 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: fix overflow of color_palette array The palette_current index counter has a maximum size of 256 * 3 to cover a full color palette of 256 RGB entries. Linux assumes that the palette_current index wraps back around to zero after writing 256 RGB entries so ensure that palette_current is reset at this point to prevent data corruption within MacfbState. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-5-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 3b10b5673c902981129d1817fcc235e467648200 https://github.com/qemu/qemu/commit/3b10b5673c902981129d1817fcc235e467648200 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer Currently macfb_common_realize() defines the framebuffer RAM memory region as being non-migrateable but then immediately registers it for migration. Replace memory_region_init_ram_nomigrate() with memory_region_init_ram() which is clearer and does exactly the same thing. Signed-off-by: Mark Cave-Ayland Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-6-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 4ec27073fd0e5a82a87b1122dfdca7a820cb1561 https://github.com/qemu/qemu/commit/4ec27073fd0e5a82a87b1122dfdca7a820cb1561 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c M hw/display/trace-events Log Message: --- macfb: add trace events for reading and writing the control registers Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-7-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: e6108b96363bda0704ca69e5dfdb4b07dc589336
[Qemu-commits] [qemu/qemu] 7437b1: macfb: handle errors that occur during realize
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 7437b13eacfd05ed6817c2f05c4712ed618544e1 https://github.com/qemu/qemu/commit/7437b13eacfd05ed6817c2f05c4712ed618544e1 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: handle errors that occur during realize Make sure any errors that occur within the macfb realize chain are detected and handled correctly to prevent crashes and to ensure that error messages are reported back to the user. Signed-off-by: Mark Cave-Ayland Reviewed-by: BALATON Zoltan Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: c047862acd502c305fbdc66a4a3fd717c04fa6d2 https://github.com/qemu/qemu/commit/c047862acd502c305fbdc66a4a3fd717c04fa6d2 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: update macfb.c to use the Error API best practices As per the current Error API best practices, change macfb_commom_realize() to return a boolean indicating success to reduce errp boiler-plate handling code. Note that memory_region_init_ram_nomigrate() is also updated to use _abort to indicate a non-recoverable error, matching the behaviour recommended after similar discussions on memory API failures for the recent nubus changes. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-3-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 906c2323f1edf41b1851e7e36231023ee930aa3c https://github.com/qemu/qemu/commit/906c2323f1edf41b1851e7e36231023ee930aa3c Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: fix invalid object reference in macfb_common_realize() During realize memory_region_init_ram_nomigrate() is used to initialise the RAM memory region used for the framebuffer but the owner object reference is incorrect since MacFbState is a typedef and not a QOM type. Change the memory region owner to be the corresponding DeviceState to fix the issue and prevent random crashes during macfb_common_realize(). Signed-off-by: Mark Cave-Ayland Fixes: 8ac919a0654 ("hw/m68k: add Nubus macfb video card") Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-4-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 14d0ddfce781374b7ce40062c0afc2ed00419267 https://github.com/qemu/qemu/commit/14d0ddfce781374b7ce40062c0afc2ed00419267 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: fix overflow of color_palette array The palette_current index counter has a maximum size of 256 * 3 to cover a full color palette of 256 RGB entries. Linux assumes that the palette_current index wraps back around to zero after writing 256 RGB entries so ensure that palette_current is reset at this point to prevent data corruption within MacfbState. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-5-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 3b10b5673c902981129d1817fcc235e467648200 https://github.com/qemu/qemu/commit/3b10b5673c902981129d1817fcc235e467648200 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c Log Message: --- macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer Currently macfb_common_realize() defines the framebuffer RAM memory region as being non-migrateable but then immediately registers it for migration. Replace memory_region_init_ram_nomigrate() with memory_region_init_ram() which is clearer and does exactly the same thing. Signed-off-by: Mark Cave-Ayland Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-6-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 4ec27073fd0e5a82a87b1122dfdca7a820cb1561 https://github.com/qemu/qemu/commit/4ec27073fd0e5a82a87b1122dfdca7a820cb1561 Author: Mark Cave-Ayland Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M hw/display/macfb.c M hw/display/trace-events Log Message: --- macfb: add trace events for reading and writing the control registers Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20211007221253.29024-7-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: e6108b96363bda0704ca69e5dfdb4b07dc589336
[Qemu-commits] [qemu/qemu] 45a904: aspeed/smc: Add watchdog Control/Status Registers
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 45a904af3861b5457050e55271e1386a7040f04f https://github.com/qemu/qemu/commit/45a904af3861b5457050e55271e1386a7040f04f Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c Log Message: --- aspeed/smc: Add watchdog Control/Status Registers The Aspeed SoCs have a dual boot function for firmware fail-over recovery. The system auto-reboots from the second flash if the main flash does not boot successfully within a certain amount of time. This function is called alternate boot (ABR) in the FMC controllers. On AST2400/AST2500, ABR is enabled by hardware strapping in SCU70 to enable the 2nd watchdog timer, on AST2600, through register SCU510. If the boot on the the main flash succeeds, the firmware should disable the 2nd watchdog timer. If not, the BMC is reset and the CE0 and CE1 mappings are swapped to restart the BMC from the 2nd flash. On the AST2600, the ABR registers controlling the 2nd watchdog timer were moved from the watchdog register to the FMC controller and the FMC model should be able to control WDT2 through its own register set. This requires more work. For now, add dummy read/write handlers to let the FW disable the 2nd watchdog without error. Reviewed-by: Peter Delevoryas Reported-by: Peter Delevoryas Signed-off-by: Cédric Le Goater Commit: 32c54bd0ed622bbd1614ca9d1f5f108823f5cc11 https://github.com/qemu/qemu/commit/32c54bd0ed622bbd1614ca9d1f5f108823f5cc11 Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c Log Message: --- aspeed/smc: Introduce aspeed_smc_error() helper It unifies the errors reported by the Aspeed SMC model and also removes some use of ctrl->name which will help us for the next patches. Signed-off-by: Cédric Le Goater Commit: d0180a3ae48f71d4cb5b9cea89b49451e2dc9a47 https://github.com/qemu/qemu/commit/d0180a3ae48f71d4cb5b9cea89b49451e2dc9a47 Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c Log Message: --- aspeed/smc: Stop using the model name for the memory regions There is no real reason to use this name. It's simply nice to have in the monitor output but it's a burden for the following patch which removes the AspeedSMCController structure describing the controller. Signed-off-by: Cédric Le Goater Commit: 30b6852ce4c3398c54fc6f6c7ff5ccbf8c15cf4f https://github.com/qemu/qemu/commit/30b6852ce4c3398c54fc6f6c7ff5ccbf8c15cf4f Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/arm/aspeed_ast2600.c M hw/arm/aspeed_soc.c M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Drop AspeedSMCController structure The characteristics of the Aspeed controllers are described in a AspeedSMCController structure which is redundant with the AspeedSMCClass. Move all attributes under the class and adapt the code to use class attributes instead. This is a large change but it is functionally equivalent. Signed-off-by: Cédric Le Goater Commit: a7d78beff46f8e5c4343edca4b76675e6e55172e https://github.com/qemu/qemu/commit/a7d78beff46f8e5c4343edca4b76675e6e55172e Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/arm/aspeed.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Remove the 'flash' attribute from AspeedSMCFlash There is no need to keep a reference of the flash qdev in the AspeedSMCFlash state: the SPI bus takes ownership and will release its resources. Remove AspeedSMCFlash::flash. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Commit: 6bb55e796740a0b685831faa784efb0c38dd151c https://github.com/qemu/qemu/commit/6bb55e796740a0b685831faa784efb0c38dd151c Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/arm/aspeed.c M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash AspeedSMCFlash::size is only used to compute the initial size of the boot_rom region. Not very useful, so directly call memory_region_size() instead. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Commit: 10f915e4caefeacedf092eb90bfcce56e23e102e https://github.com/qemu/qemu/commit/10f915e4caefeacedf092eb90bfcce56e23e102e Author: Cédric Le Goater Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Rename AspeedSMCFlash 'id' to 'cs' 'cs' is a more appropriate name to index SPI flash devices. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Commit:
[Qemu-commits] [qemu/qemu] 9557af: configure: don't override the selected host test c...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 9557af9ce94d434440d6397fb0d80748e4714e94 https://github.com/qemu/qemu/commit/9557af9ce94d434440d6397fb0d80748e4714e94 Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M configure Log Message: --- configure: don't override the selected host test compiler if defined There are not many cases you would want to do this but one is if you want to use a test friendly compiler like gcc instead of a system compiler like clang. Either way we should honour the users choice if they have made it. Signed-off-by: Alex Bennée Cc: Warner Losh Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-2-alex.ben...@linaro.org> Commit: 4f0ebed41809531e4e84658b8ac1742c4ba6966a https://github.com/qemu/qemu/commit/4f0ebed41809531e4e84658b8ac1742c4ba6966a Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M tests/tcg/multiarch/sha1.c Log Message: --- tests/tcg/sha1: remove endian include This doesn't exist in BSD world and doesn't seem to be needed by either. Signed-off-by: Alex Bennée Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-3-alex.ben...@linaro.org> Commit: 5343a837cdb0e10db05310e0da5a89843539b400 https://github.com/qemu/qemu/commit/5343a837cdb0e10db05310e0da5a89843539b400 Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M tests/tcg/multiarch/Makefile.target R tests/tcg/multiarch/float_helpers.c A tests/tcg/multiarch/libs/float_helpers.c R tests/tcg/multiarch/linux-test.c A tests/tcg/multiarch/linux/linux-test.c M tests/tcg/x86_64/Makefile.target Log Message: --- tests/tcg: move some multiarch files and make conditional We had some messy code to filter out stuff we can't build. Lets junk that and simplify the logic by pushing some stuff into subdirs. In particular we move: float_helpers into libs - not a standalone test linux-test into linux - so we only build on Linux hosts This allows for at least some of the tests to be nominally usable by *BSD user builds. Signed-off-by: Alex Bennée Cc: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-4-alex.ben...@linaro.org> Commit: 5c24acf320a0ac259447788162a3b17505ad4fb9 https://github.com/qemu/qemu/commit/5c24acf320a0ac259447788162a3b17505ad4fb9 Author: Alex Bennée Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M .gitlab-ci.d/container-cross.yml M tests/docker/Makefile.include M tests/docker/dockerfiles/debian-riscv64-cross.docker Log Message: --- tests/docker: promote debian-riscv64-cross to a full image To be able to cross build QEMU itself we need to include a few more libraries. These are only available in Debian's unstable ports repo for now so we need to base the riscv64 image on sid with the the minimal libs needed to build QEMU (glib/pixman). The result works but is not as clean as using build-dep to bring in more dependencies. However sid is by definition a shifting pile of sand and by keeping the list of libs minimal we reduce the chance of having an image we can't build. It's good enough for a basic cross build testing of TCG. Cc: "Daniel P. Berrangé" Signed-off-by: Richard Henderson Message-Id: <20210914185830.1378771-2-richard.hender...@linaro.org> [AJB: tweak allow_failure] Signed-off-by: Alex Bennée Message-Id: <20210917162332.3511179-5-alex.ben...@linaro.org> Commit: 9f62025141c67c5dbe5c5a04becb12add2de12cf https://github.com/qemu/qemu/commit/9f62025141c67c5dbe5c5a04becb12add2de12cf Author: Richard Henderson Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M .gitlab-ci.d/crossbuilds.yml Log Message: --- gitlab: Add cross-riscv64-system, cross-riscv64-user Signed-off-by: Richard Henderson Message-Id: <20210914185830.1378771-3-richard.hender...@linaro.org> [AJB: add allow_failure] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Willian Rampazzo Message-Id: <20210917162332.3511179-6-alex.ben...@linaro.org> Commit: 9d03f5abede84a7b05877f7adeeea967d55566a0 https://github.com/qemu/qemu/commit/9d03f5abede84a7b05877f7adeeea967d55566a0 Author: Thomas Huth Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M .travis.yml Log Message: --- travis.yml: Remove the "Release tarball" job This is a leftover from the days when we were using Travis excessively, but since x86 jobs are not really usable there anymore, this job has likely never been used since many months. Let's simply remove it now. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Message-Id: <20210917094826.466047-1-th...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20210917162332.3511179-8-alex.ben...@linaro.org> Commit:
[Qemu-commits] [qemu/qemu] e770b8: pc-bios: Update hppa-firmware.img
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: e770b8cf76083cc51497b854e73f0a9bb92d1bc7 https://github.com/qemu/qemu/commit/e770b8cf76083cc51497b854e73f0a9bb92d1bc7 Author: Helge Deller Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M pc-bios/hppa-firmware.img M roms/seabios-hppa Log Message: --- pc-bios: Update hppa-firmware.img Update SeaBIOS to seabios-hppa-v2 Changes in seabios-hppa: * Include all latest upstream SeaBIOS patches * add support for the qemu "bootindex" parameter * add support for the qemu "-boot order=g-m" parameter to choose SCSI ID Signed-off-by: Helge Deller Message-Id: Signed-off-by: Richard Henderson Commit: 8be1d4ed9838f807c63695753b30865f6edc4a5c https://github.com/qemu/qemu/commit/8be1d4ed9838f807c63695753b30865f6edc4a5c Author: Richard Henderson Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M pc-bios/hppa-firmware.img M roms/seabios-hppa Log Message: --- Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20211012' into staging seabios-hppa update # gpg: Signature made Tue 12 Oct 2021 09:28:12 AM PDT # gpg:using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F # gpg:issuer "richard.hender...@linaro.org" # gpg: Good signature from "Richard Henderson " [ultimate] * remotes/rth/tags/pull-hppa-20211012: pc-bios: Update hppa-firmware.img Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/bfd9a76f9c14...8be1d4ed9838
[Qemu-commits] [qemu/qemu] 685db1: tests: acpi: dump table with failed checksum
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 685db13a38f7599fabd353382ff65d3c244ea641 https://github.com/qemu/qemu/commit/685db13a38f7599fabd353382ff65d3c244ea641 Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/qtest/acpi-utils.c Log Message: --- tests: acpi: dump table with failed checksum Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-2-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: e741aff0f43343d6d91242fee1072fee376d5cce https://github.com/qemu/qemu/commit/e741aff0f43343d6d91242fee1072fee376d5cce Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M meson.build M tests/qtest/libqos/libqtest.h M tests/qtest/libqtest.c Log Message: --- tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator Currently it is not possible to create tests that have KVM as a hard requirement on a host that doesn't support KVM for tested target binary (modulo going through the trouble of compiling out the offending test case). Following scenario makes test fail when it's run on non x86 host: qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288 This patch introduces qtest_has_accel() to let users check if accel is available in advance and avoid executing non run-able test-cases. It implements detection of TCG and KVM only, the rest could be added later on, when we actually start testing them in qtest. Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: c306cdb0cc5327f336fbf9a7411f319f0717ee75 https://github.com/qemu/qemu/commit/c306cdb0cc5327f336fbf9a7411f319f0717ee75 Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: A tests/data/acpi/q35/APIC.xapic A tests/data/acpi/q35/DSDT.xapic A tests/data/acpi/q35/FACP.xapic A tests/data/acpi/q35/SRAT.xapic M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests: acpi: whitelist expected tables for acpi/q35/xapic testcase Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-4-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 80a2f3387c239d06d4a4b6838b511a88838ddc0f https://github.com/qemu/qemu/commit/80a2f3387c239d06d4a4b6838b511a88838ddc0f Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/qtest/bios-tables-test.c Log Message: --- tests: acpi: q35: test for x2APIC entries in SRAT Set -smp 1,maxcpus=288 to test for ACPI code that deal with CPUs with large APIC ID (>255). PS: Test requires KVM and in-kernel irqchip support, so skip test if KVM is not available. Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-5-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: b59a898458aea328618521be7dc180d2396c0bf4 https://github.com/qemu/qemu/commit/b59a898458aea328618521be7dc180d2396c0bf4 Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/data/acpi/q35/APIC.xapic M tests/data/acpi/q35/DSDT.xapic M tests/data/acpi/q35/FACP.xapic M tests/data/acpi/q35/SRAT.xapic M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests: acpi: update expected tables blobs Update adds CPU entries to MADT/SRAT/FACP and DSDT to cover 288 CPUs. Notable changes are that CPUs with APIC ID 255 and higher use 'Processor Local x2APIC Affinity' structure in SRAT and "Device" element in DSDT. FACP: - Use APIC Cluster Model (V4) : 0 + Use APIC Cluster Model (V4) : 1 SRAT: ... +[1010h 4112 1]Subtable Type : 00 [Processor Local APIC/SAPIC Affinity] +[1011h 4113 1] Length : 10 + +[1012h 4114 1] Proximity Domain Low(8) : 00 +[1013h 4115 1] Apic ID : FE +[1014h 4116 4]Flags (decoded below) : 0001 + Enabled : 1 +[1018h 4120 1] Local Sapic EID : 00 +[1019h 4121 3]Proximity Domain High(24) : 00 +[101Ch 4124 4] Clock Domain : + +[1020h 4128 1]Subtable Type : 02 [Processor Local x2APIC Affinity] +[1021h 4129 1] Length : 18 + +[1022h 4130 2]Reserved1 : +[1024h 4132 4] Proximity Domain : 0001 +[1028h 4136 4] Apic ID : 00FF +[102Ch 4140 4]Flags (decoded below) : 0001 + Enabled : 1 +[1030h 4144 4] Clock Domain : +[1034h 4148 4]Reserved2 : ...
[Qemu-commits] [qemu/qemu] 621f70: spapr/xive: Add source status helpers
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 621f70d21027a914eda1446134193a24e7a662d5 https://github.com/qemu/qemu/commit/621f70d21027a914eda1446134193a24e7a662d5 Author: Cédric Le Goater Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/intc/spapr_xive.c M hw/intc/spapr_xive_kvm.c M hw/intc/xive.c M include/hw/ppc/xive.h Log Message: --- spapr/xive: Add source status helpers and use them to set and test the ASSERTED bit of LSI sources. Signed-off-by: Cédric Le Goater Message-Id: <20211004212141.432954-1-...@kaod.org> Signed-off-by: David Gibson Commit: 6f4912a4160f157217730b0affdcb6c92c24ca76 https://github.com/qemu/qemu/commit/6f4912a4160f157217730b0affdcb6c92c24ca76 Author: Philippe Mathieu-Daudé Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M target/ppc/translate.c Log Message: --- target/ppc: Use tcg_constant_i32() in gen_setb() Avoid using TCG temporaries for the -1 and 8 constant values. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003141711.3673181-2-f4...@amsat.org> Reviewed-by: Richard Henderson Signed-off-by: David Gibson Commit: 491b3cca3653bf36db67f91be0e3db64682bef91 https://github.com/qemu/qemu/commit/491b3cca3653bf36db67f91be0e3db64682bef91 Author: Philippe Mathieu-Daudé Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M target/ppc/translate.c Log Message: --- target/ppc: Use tcg_constant_i64() in gen_brh() The mask of the Byte-Reverse Halfword opcode is a read-only constant. We can avoid using a TCG temporary by moving the mask to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003141711.3673181-3-f4...@amsat.org> Reviewed-by: Richard Henderson Signed-off-by: David Gibson Commit: a8dcb8da8a95edde3d6d8bb6a0502d50ed632557 https://github.com/qemu/qemu/commit/a8dcb8da8a95edde3d6d8bb6a0502d50ed632557 Author: Cédric Le Goater Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/ppc/ppc.c Log Message: --- target/ppc: Fix the test raising the decrementer exception Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced new int64t variables and broke the test triggering the decrementer exception. Revert partially the change to evaluate both clause of the if statement. Reported-by: Coverity CID 1464061 Fixes: 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") Suggested-by: Peter Maydell Signed-off-by: Cédric Le Goater Message-Id: <20211005053324.441132-1-...@kaod.org> Reviewed-by: Greg Kurz Signed-off-by: David Gibson Commit: 3c706d02522fb031e79823fd14b121878dccbcc6 https://github.com/qemu/qemu/commit/3c706d02522fb031e79823fd14b121878dccbcc6 Author: Philippe Mathieu-Daudé Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/ppc/spapr_softmmu.c Log Message: --- hw/ppc/spapr_softmmu: Reduce include list Commit 962104f0448 ("hw/ppc: moved hcalls that depend on softmmu") introduced a lot of unnecessary #include directives. Remove them. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211006170801.178023-1-phi...@redhat.com> Signed-off-by: David Gibson Commit: 644c68696e8335f80d4a9295db0445505e24d8e2 https://github.com/qemu/qemu/commit/644c68696e8335f80d4a9295db0445505e24d8e2 Author: Cédric Le Goater Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/intc/spapr_xive_kvm.c Log Message: --- spapr/xive: Use xive_esb_rw() to trigger interrupts xive_esb_rw() is the common routine used for memory accesses on ESB page. Use it for triggers also. Signed-off-by: Cédric Le Goater Message-Id: <20211006210546.641102-1-...@kaod.org> Signed-off-by: David Gibson Commit: 5ae3d2e8ba37def4b3ca38f220200bf5721317e0 https://github.com/qemu/qemu/commit/5ae3d2e8ba37def4b3ca38f220200bf5721317e0 Author: Thomas Huth Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/ppc/ppc.c Log Message: --- hw/ppc: Fix iothread locking in the 405 code When using u-boot as firmware with the taihu board, QEMU aborts with this assertion: ERROR:../accel/tcg/tcg-accel-ops.c:79:tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()) Running QEMU with "-d in_asm" shows that the crash happens when writing to SPR 0x3f2, so we are missing to lock the iothread in the code path here. Signed-off-by: Thomas Huth Message-Id: <20211006071140.565952-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: David Gibson Commit: 252fcf36bba483493365e91c2f98569de29a43fd https://github.com/qemu/qemu/commit/252fcf36bba483493365e91c2f98569de29a43fd Author: Thomas Huth Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: A tests/acceptance/ppc_405.py Log Message: --- tests/acceptance: Add tests for the ppc405 boards Using the U-Boot firmware,
[Qemu-commits] [qemu/qemu] 621f70: spapr/xive: Add source status helpers
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 621f70d21027a914eda1446134193a24e7a662d5 https://github.com/qemu/qemu/commit/621f70d21027a914eda1446134193a24e7a662d5 Author: Cédric Le Goater Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/intc/spapr_xive.c M hw/intc/spapr_xive_kvm.c M hw/intc/xive.c M include/hw/ppc/xive.h Log Message: --- spapr/xive: Add source status helpers and use them to set and test the ASSERTED bit of LSI sources. Signed-off-by: Cédric Le Goater Message-Id: <20211004212141.432954-1-...@kaod.org> Signed-off-by: David Gibson Commit: 6f4912a4160f157217730b0affdcb6c92c24ca76 https://github.com/qemu/qemu/commit/6f4912a4160f157217730b0affdcb6c92c24ca76 Author: Philippe Mathieu-Daudé Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M target/ppc/translate.c Log Message: --- target/ppc: Use tcg_constant_i32() in gen_setb() Avoid using TCG temporaries for the -1 and 8 constant values. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003141711.3673181-2-f4...@amsat.org> Reviewed-by: Richard Henderson Signed-off-by: David Gibson Commit: 491b3cca3653bf36db67f91be0e3db64682bef91 https://github.com/qemu/qemu/commit/491b3cca3653bf36db67f91be0e3db64682bef91 Author: Philippe Mathieu-Daudé Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M target/ppc/translate.c Log Message: --- target/ppc: Use tcg_constant_i64() in gen_brh() The mask of the Byte-Reverse Halfword opcode is a read-only constant. We can avoid using a TCG temporary by moving the mask to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003141711.3673181-3-f4...@amsat.org> Reviewed-by: Richard Henderson Signed-off-by: David Gibson Commit: a8dcb8da8a95edde3d6d8bb6a0502d50ed632557 https://github.com/qemu/qemu/commit/a8dcb8da8a95edde3d6d8bb6a0502d50ed632557 Author: Cédric Le Goater Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/ppc/ppc.c Log Message: --- target/ppc: Fix the test raising the decrementer exception Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced new int64t variables and broke the test triggering the decrementer exception. Revert partially the change to evaluate both clause of the if statement. Reported-by: Coverity CID 1464061 Fixes: 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") Suggested-by: Peter Maydell Signed-off-by: Cédric Le Goater Message-Id: <20211005053324.441132-1-...@kaod.org> Reviewed-by: Greg Kurz Signed-off-by: David Gibson Commit: 3c706d02522fb031e79823fd14b121878dccbcc6 https://github.com/qemu/qemu/commit/3c706d02522fb031e79823fd14b121878dccbcc6 Author: Philippe Mathieu-Daudé Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/ppc/spapr_softmmu.c Log Message: --- hw/ppc/spapr_softmmu: Reduce include list Commit 962104f0448 ("hw/ppc: moved hcalls that depend on softmmu") introduced a lot of unnecessary #include directives. Remove them. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211006170801.178023-1-phi...@redhat.com> Signed-off-by: David Gibson Commit: 644c68696e8335f80d4a9295db0445505e24d8e2 https://github.com/qemu/qemu/commit/644c68696e8335f80d4a9295db0445505e24d8e2 Author: Cédric Le Goater Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/intc/spapr_xive_kvm.c Log Message: --- spapr/xive: Use xive_esb_rw() to trigger interrupts xive_esb_rw() is the common routine used for memory accesses on ESB page. Use it for triggers also. Signed-off-by: Cédric Le Goater Message-Id: <20211006210546.641102-1-...@kaod.org> Signed-off-by: David Gibson Commit: 5ae3d2e8ba37def4b3ca38f220200bf5721317e0 https://github.com/qemu/qemu/commit/5ae3d2e8ba37def4b3ca38f220200bf5721317e0 Author: Thomas Huth Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M hw/ppc/ppc.c Log Message: --- hw/ppc: Fix iothread locking in the 405 code When using u-boot as firmware with the taihu board, QEMU aborts with this assertion: ERROR:../accel/tcg/tcg-accel-ops.c:79:tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()) Running QEMU with "-d in_asm" shows that the crash happens when writing to SPR 0x3f2, so we are missing to lock the iothread in the code path here. Signed-off-by: Thomas Huth Message-Id: <20211006071140.565952-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: David Gibson Commit: 252fcf36bba483493365e91c2f98569de29a43fd https://github.com/qemu/qemu/commit/252fcf36bba483493365e91c2f98569de29a43fd Author: Thomas Huth Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: A tests/acceptance/ppc_405.py Log Message: --- tests/acceptance: Add tests for the ppc405 boards Using the U-Boot firmware,
[Qemu-commits] [qemu/qemu] 5384ad: tests/acpi: Get prepared for IORT E.b revision upg...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 5384adef5d5ac27d57f684e3937592d2074ce8b9 https://github.com/qemu/qemu/commit/5384adef5d5ac27d57f684e3937592d2074ce8b9 Author: Eric Auger Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests/acpi: Get prepared for IORT E.b revision upgrade Ignore IORT till reference blob for E.b spec revision gets added. Signed-off-by: Eric Auger Reviewed-by: Michael S. Tsirkin Message-Id: <20211014115643.756977-2-eric.au...@redhat.com> Signed-off-by: Richard Henderson Commit: 1c2cb7e0b3e6743b449a4ad28d70b77d2290e817 https://github.com/qemu/qemu/commit/1c2cb7e0b3e6743b449a4ad28d70b77d2290e817 Author: Eric Auger Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/arm/virt-acpi-build.c Log Message: --- hw/arm/virt-acpi-build: IORT upgrade up to revision E.b Upgrade the IORT table from B to E.b specification revision (ARM DEN 0049E.b). The SMMUv3 and root complex node have additional fields. Also unique IORT node identifiers are introduced: they are generated in sequential order. They are not cross-referenced though. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Message-Id: <20211014115643.756977-3-eric.au...@redhat.com> Signed-off-by: Richard Henderson Commit: 47432863ff1892870730e78630b5d0dbed7e72b2 https://github.com/qemu/qemu/commit/47432863ff1892870730e78630b5d0dbed7e72b2 Author: Eric Auger Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/data/acpi/virt/IORT M tests/data/acpi/virt/IORT.memhp M tests/data/acpi/virt/IORT.numamem M tests/data/acpi/virt/IORT.pxb M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests/acpi: Generate reference blob for IORT rev E.b Re-generate reference blobs with rebuild-expected-aml.sh. Differences reported by "make check V=1" are listed below (IORT.numamem). Differences for other variants are similar. /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180629 (64-bit version) * Copyright (c) 2000 - 2018 Intel Corporation * - * Disassembly of tests/data/acpi/virt/IORT.numamem, Thu Oct 14 06:13:19 2021 + * Disassembly of /tmp/aml-K8L9A1, Thu Oct 14 06:13:19 2021 * * ACPI Data Table [IORT] * * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue */ [000h 4]Signature : "IORT"[IO Remapping Table] -[004h 0004 4] Table Length : 007C -[008h 0008 1] Revision : 00 -[009h 0009 1] Checksum : 07 +[004h 0004 4] Table Length : 0080 +[008h 0008 1] Revision : 03 +[009h 0009 1] Checksum : B3 [00Ah 0010 6] Oem ID : "BOCHS " [010h 0016 8] Oem Table ID : "BXPC" [018h 0024 4] Oem Revision : 0001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4]Asl Compiler Revision : 0001 [024h 0036 4] Node Count : 0002 [028h 0040 4] Node Offset : 0030 [02Ch 0044 4] Reserved : [030h 0048 1] Type : 00 [031h 0049 2] Length : 0018 -[033h 0051 1] Revision : 00 +[033h 0051 1] Revision : 01 [034h 0052 4] Reserved : [038h 0056 4]Mapping Count : [03Ch 0060 4] Mapping Offset : [040h 0064 4] ItsCount : 0001 [044h 0068 4] Identifiers : [048h 0072 1] Type : 02 -[049h 0073 2] Length : 0034 -[04Bh 0075 1] Revision : 00 -[04Ch 0076 4] Reserved : +[049h 0073 2] Length : 0038 +[04Bh 0075 1] Revision : 03 +[04Ch 0076 4] Reserved : 0001 [050h 0080 4]Mapping Count : 0001 -[054h 0084 4] Mapping Offset : 0020 +[054h 0084 4] Mapping Offset : 0024 [058h 0088 8]Memory Properties : [IORT Memory Access Properties] [058h 0088 4] Cache Coherency : 0001 [05Ch 0092 1]Hints (decoded below) : 00 Transient : 0 Write Allocate : 0 Read Allocate : 0 Override : 0 [05Dh 0093 2] Reserved : [05Fh 0095 1] Memory Flags (decoded below) : 03 Coherency : 1
[Qemu-commits] [qemu/qemu] 4b2b3d: coroutine: resize pool periodically instead of lim...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 4b2b3d2653f255ef4259a7689af1956536565901 https://github.com/qemu/qemu/commit/4b2b3d2653f255ef4259a7689af1956536565901 Author: Stefan Hajnoczi Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: A include/qemu/coroutine-pool-timer.h M include/qemu/coroutine.h M iothread.c A util/coroutine-pool-timer.c M util/main-loop.c M util/meson.build M util/qemu-coroutine.c Log Message: --- coroutine: resize pool periodically instead of limiting size It was reported that enabling SafeStack reduces IOPS significantly (>25%) with the following fio benchmark on virtio-blk using a NVMe host block device: # fio --rw=randrw --bs=4k --iodepth=64 --runtime=1m --direct=1 \ --filename=/dev/vdb --name=job1 --ioengine=libaio --thread \ --group_reporting --numjobs=16 --time_based \ --output=/tmp/fio_result Serge Guelton and I found that SafeStack is not really at fault, it just increases the cost of coroutine creation. This fio workload exhausts the coroutine pool and coroutine creation becomes a bottleneck. Previous work by Honghao Wang also pointed to excessive coroutine creation. Creating new coroutines is expensive due to allocating new stacks with mmap(2) and mprotect(2). Currently there are thread-local and global pools that recycle old Coroutine objects and their stacks but the hardcoded size limit of 64 for thread-local pools and 128 for the global pool is insufficient for the fio benchmark shown above. This patch changes the coroutine pool algorithm to a simple thread-local pool without a maximum size limit. Threads periodically shrink the pool down to a size sufficient for the maximum observed number of coroutines. The global pool is removed by this patch. It can help to hide the fact that local pools are easily exhausted, but it's doesn't fix the root cause. I don't think there is a need for a global pool because QEMU's threads are long-lived, so let's keep things simple. Performance of the above fio benchmark is as follows: Before After IOPS 60k 97k Memory usage varies over time as needed by the workload: VSZ (KB) RSS (KB) Before fio 4705248 843128 During fio 5747668 (+ ~100 MB) 849280 After fio 4694996 (- ~100 MB) 845184 This confirms that coroutines are indeed being freed when no longer needed. Thanks to Serge Guelton for working on identifying the bottleneck with me! Reported-by: Tingting Mao Signed-off-by: Stefan Hajnoczi Message-id: 20210913153524.1190696-1-stefa...@redhat.com Cc: Serge Guelton Cc: Honghao Wang Cc: Paolo Bonzini Cc: Daniele Buono Signed-off-by: Stefan Hajnoczi [Moved atexit notifier to coroutine_delete() after GitLab CI reported a memory leak in tests/unit/test-aio-multithread because the Coroutine object was created in the main thread but runs in an IOThread (where it's also deleted). --Stefan] Commit: 78d98bfbd39d507ffb38f846f60ad63335cd9c83 https://github.com/qemu/qemu/commit/78d98bfbd39d507ffb38f846f60ad63335cd9c83 Author: Richard Henderson Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: A include/qemu/coroutine-pool-timer.h M include/qemu/coroutine.h M iothread.c A util/coroutine-pool-timer.c M util/main-loop.c M util/meson.build M util/qemu-coroutine.c Log Message: --- Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging Pull request Performance optimization when guest applications submit a lot of parallel I/O. This has also been found to improve clang SafeStack performance. # gpg: Signature made Thu 21 Oct 2021 10:40:49 AM PDT # gpg:using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8 # gpg: Good signature from "Stefan Hajnoczi " [full] # gpg: aka "Stefan Hajnoczi " [full] * remotes/stefanha/tags/block-pull-request: coroutine: resize pool periodically instead of limiting size Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/4c127fdbe81d...78d98bfbd39d
[Qemu-commits] [qemu/qemu] 5384ad: tests/acpi: Get prepared for IORT E.b revision upg...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 5384adef5d5ac27d57f684e3937592d2074ce8b9 https://github.com/qemu/qemu/commit/5384adef5d5ac27d57f684e3937592d2074ce8b9 Author: Eric Auger Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests/acpi: Get prepared for IORT E.b revision upgrade Ignore IORT till reference blob for E.b spec revision gets added. Signed-off-by: Eric Auger Reviewed-by: Michael S. Tsirkin Message-Id: <20211014115643.756977-2-eric.au...@redhat.com> Signed-off-by: Richard Henderson Commit: 1c2cb7e0b3e6743b449a4ad28d70b77d2290e817 https://github.com/qemu/qemu/commit/1c2cb7e0b3e6743b449a4ad28d70b77d2290e817 Author: Eric Auger Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/arm/virt-acpi-build.c Log Message: --- hw/arm/virt-acpi-build: IORT upgrade up to revision E.b Upgrade the IORT table from B to E.b specification revision (ARM DEN 0049E.b). The SMMUv3 and root complex node have additional fields. Also unique IORT node identifiers are introduced: they are generated in sequential order. They are not cross-referenced though. Signed-off-by: Eric Auger Reviewed-by: Jean-Philippe Brucker Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Message-Id: <20211014115643.756977-3-eric.au...@redhat.com> Signed-off-by: Richard Henderson Commit: 47432863ff1892870730e78630b5d0dbed7e72b2 https://github.com/qemu/qemu/commit/47432863ff1892870730e78630b5d0dbed7e72b2 Author: Eric Auger Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/data/acpi/virt/IORT M tests/data/acpi/virt/IORT.memhp M tests/data/acpi/virt/IORT.numamem M tests/data/acpi/virt/IORT.pxb M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests/acpi: Generate reference blob for IORT rev E.b Re-generate reference blobs with rebuild-expected-aml.sh. Differences reported by "make check V=1" are listed below (IORT.numamem). Differences for other variants are similar. /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180629 (64-bit version) * Copyright (c) 2000 - 2018 Intel Corporation * - * Disassembly of tests/data/acpi/virt/IORT.numamem, Thu Oct 14 06:13:19 2021 + * Disassembly of /tmp/aml-K8L9A1, Thu Oct 14 06:13:19 2021 * * ACPI Data Table [IORT] * * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue */ [000h 4]Signature : "IORT"[IO Remapping Table] -[004h 0004 4] Table Length : 007C -[008h 0008 1] Revision : 00 -[009h 0009 1] Checksum : 07 +[004h 0004 4] Table Length : 0080 +[008h 0008 1] Revision : 03 +[009h 0009 1] Checksum : B3 [00Ah 0010 6] Oem ID : "BOCHS " [010h 0016 8] Oem Table ID : "BXPC" [018h 0024 4] Oem Revision : 0001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4]Asl Compiler Revision : 0001 [024h 0036 4] Node Count : 0002 [028h 0040 4] Node Offset : 0030 [02Ch 0044 4] Reserved : [030h 0048 1] Type : 00 [031h 0049 2] Length : 0018 -[033h 0051 1] Revision : 00 +[033h 0051 1] Revision : 01 [034h 0052 4] Reserved : [038h 0056 4]Mapping Count : [03Ch 0060 4] Mapping Offset : [040h 0064 4] ItsCount : 0001 [044h 0068 4] Identifiers : [048h 0072 1] Type : 02 -[049h 0073 2] Length : 0034 -[04Bh 0075 1] Revision : 00 -[04Ch 0076 4] Reserved : +[049h 0073 2] Length : 0038 +[04Bh 0075 1] Revision : 03 +[04Ch 0076 4] Reserved : 0001 [050h 0080 4]Mapping Count : 0001 -[054h 0084 4] Mapping Offset : 0020 +[054h 0084 4] Mapping Offset : 0024 [058h 0088 8]Memory Properties : [IORT Memory Access Properties] [058h 0088 4] Cache Coherency : 0001 [05Ch 0092 1]Hints (decoded below) : 00 Transient : 0 Write Allocate : 0 Read Allocate : 0 Override : 0 [05Dh 0093 2] Reserved : [05Fh 0095 1] Memory Flags (decoded below) : 03 Coherency : 1
[Qemu-commits] [qemu/qemu] c9460d: accel/tcg: Handle gdb singlestep in cpu_tb_exec
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: c9460d75c59fc6b6f110156e4c1035e9ae9bd611 https://github.com/qemu/qemu/commit/c9460d75c59fc6b6f110156e4c1035e9ae9bd611 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M accel/tcg/cpu-exec.c Log Message: --- accel/tcg: Handle gdb singlestep in cpu_tb_exec Currently the change in cpu_tb_exec is masked by the debug exception being raised by the translators. But this allows us to remove that code. Signed-off-by: Richard Henderson Commit: 1760e4abf11223535b92e25a7fbd928b29b57233 https://github.com/qemu/qemu/commit/1760e4abf11223535b92e25a7fbd928b29b57233 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- target/alpha: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: a893daa936161b8f45b2567875922343e388de9c https://github.com/qemu/qemu/commit/a893daa936161b8f45b2567875922343e388de9c Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/avr/translate.c Log Message: --- target/avr: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Tested-by: Michael Rolnik Reviewed-by: Michael Rolnik Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: e3774881b5b651da7b44e5e98c5c8cea610e35bc https://github.com/qemu/qemu/commit/e3774881b5b651da7b44e5e98c5c8cea610e35bc Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/cris/translate.c Log Message: --- target/cris: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson Commit: db07bd026ee6f5ea4fe32c503645813252bae2c6 https://github.com/qemu/qemu/commit/db07bd026ee6f5ea4fe32c503645813252bae2c6 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/hexagon/translate.c Log Message: --- target/hexagon: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 364caea70f965a4fc81395863a3bae6bc16ce240 https://github.com/qemu/qemu/commit/364caea70f965a4fc81395863a3bae6bc16ce240 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/arm/translate-a64.c M target/arm/translate.c Log Message: --- target/arm: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson Commit: 8532a14e413b3395c3ee2f13285462259858f433 https://github.com/qemu/qemu/commit/8532a14e413b3395c3ee2f13285462259858f433 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/hppa/translate.c Log Message: --- target/hppa: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 9ef6c6ec08b8ecd89a797fa6819b0c1d121e24d7 https://github.com/qemu/qemu/commit/9ef6c6ec08b8ecd89a797fa6819b0c1d121e24d7 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/i386/tcg/translate.c Log Message: --- target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt We were using singlestep_enabled as a proxy for whether translator_use_goto_tb would always return false. Signed-off-by: Richard Henderson Commit: 4bc4c3135be4b258ae8143b1f8982fe76cba460a https://github.com/qemu/qemu/commit/4bc4c3135be4b258ae8143b1f8982fe76cba460a Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/i386/helper.h M target/i386/tcg/misc_helper.c M target/i386/tcg/translate.c Log Message: --- target/i386: Drop check for singlestep_enabled GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson Commit: 661da0f63f973b84755423ae9e919582ff330a0c https://github.com/qemu/qemu/commit/661da0f63f973b84755423ae9e919582ff330a0c Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/m68k/translate.c Log Message: --- target/m68k: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Acked-by: Laurent Vivier Signed-off-by: Richard Henderson Commit: fbafb3a4d2fc90efdba05ec0d1f2ad7c4f68e9a5 https://github.com/qemu/qemu/commit/fbafb3a4d2fc90efdba05ec0d1f2ad7c4f68e9a5 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/microblaze/translate.c
[Qemu-commits] [qemu/qemu] c9460d: accel/tcg: Handle gdb singlestep in cpu_tb_exec
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: c9460d75c59fc6b6f110156e4c1035e9ae9bd611 https://github.com/qemu/qemu/commit/c9460d75c59fc6b6f110156e4c1035e9ae9bd611 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M accel/tcg/cpu-exec.c Log Message: --- accel/tcg: Handle gdb singlestep in cpu_tb_exec Currently the change in cpu_tb_exec is masked by the debug exception being raised by the translators. But this allows us to remove that code. Signed-off-by: Richard Henderson Commit: 1760e4abf11223535b92e25a7fbd928b29b57233 https://github.com/qemu/qemu/commit/1760e4abf11223535b92e25a7fbd928b29b57233 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/alpha/translate.c Log Message: --- target/alpha: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: a893daa936161b8f45b2567875922343e388de9c https://github.com/qemu/qemu/commit/a893daa936161b8f45b2567875922343e388de9c Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/avr/translate.c Log Message: --- target/avr: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Tested-by: Michael Rolnik Reviewed-by: Michael Rolnik Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: e3774881b5b651da7b44e5e98c5c8cea610e35bc https://github.com/qemu/qemu/commit/e3774881b5b651da7b44e5e98c5c8cea610e35bc Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/cris/translate.c Log Message: --- target/cris: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson Commit: db07bd026ee6f5ea4fe32c503645813252bae2c6 https://github.com/qemu/qemu/commit/db07bd026ee6f5ea4fe32c503645813252bae2c6 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/hexagon/translate.c Log Message: --- target/hexagon: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 364caea70f965a4fc81395863a3bae6bc16ce240 https://github.com/qemu/qemu/commit/364caea70f965a4fc81395863a3bae6bc16ce240 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/arm/translate-a64.c M target/arm/translate.c Log Message: --- target/arm: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson Commit: 8532a14e413b3395c3ee2f13285462259858f433 https://github.com/qemu/qemu/commit/8532a14e413b3395c3ee2f13285462259858f433 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/hppa/translate.c Log Message: --- target/hppa: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 9ef6c6ec08b8ecd89a797fa6819b0c1d121e24d7 https://github.com/qemu/qemu/commit/9ef6c6ec08b8ecd89a797fa6819b0c1d121e24d7 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/i386/tcg/translate.c Log Message: --- target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt We were using singlestep_enabled as a proxy for whether translator_use_goto_tb would always return false. Signed-off-by: Richard Henderson Commit: 4bc4c3135be4b258ae8143b1f8982fe76cba460a https://github.com/qemu/qemu/commit/4bc4c3135be4b258ae8143b1f8982fe76cba460a Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/i386/helper.h M target/i386/tcg/misc_helper.c M target/i386/tcg/translate.c Log Message: --- target/i386: Drop check for singlestep_enabled GDB single-stepping is now handled generically. Signed-off-by: Richard Henderson Commit: 661da0f63f973b84755423ae9e919582ff330a0c https://github.com/qemu/qemu/commit/661da0f63f973b84755423ae9e919582ff330a0c Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/m68k/translate.c Log Message: --- target/m68k: Drop checks for singlestep_enabled GDB single-stepping is now handled generically. Acked-by: Laurent Vivier Signed-off-by: Richard Henderson Commit: fbafb3a4d2fc90efdba05ec0d1f2ad7c4f68e9a5 https://github.com/qemu/qemu/commit/fbafb3a4d2fc90efdba05ec0d1f2ad7c4f68e9a5 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M target/microblaze/translate.c
[Qemu-commits] [qemu/qemu] 719f87: target/mips: Check nanoMIPS DSP MULT[U] accumulato...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 719f874b83792951faa3fe67378eca4034bec3dc https://github.com/qemu/qemu/commit/719f874b83792951faa3fe67378eca4034bec3dc Author: Philippe Mathieu-Daudé Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M target/mips/tcg/nanomips_translate.c.inc Log Message: --- target/mips: Check nanoMIPS DSP MULT[U] accumulator with Release 6 Per the "MIPS Architecture Extension: nanoMIPS32 DSP TRM" rev 0.04, MULT and MULTU opcodes: The value of ac selects an accumulator numbered from 0 to 3. When ac=0, this refers to the original HI/LO register pair of the MIPS32 architecture. In Release 6 of the MIPS Architecture, accumulators are eliminated from MIPS32. Ensure pre-Release 6 is restricted to HI/LO registers pair. Fixes: 8b3698b2947 ("target/mips: Add emulation of DSP ASE for nanoMIPS - part 4") Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Commit: e07f3e265b90d078d69c1f305563f04f1371b7aa https://github.com/qemu/qemu/commit/e07f3e265b90d078d69c1f305563f04f1371b7aa Author: Jiaxun Yang Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Massage memory map information Use memmap array to uinfy address of memory map. That would allow us reuse address information for FDT generation. Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé [PMD: Use local 'regaddr' in gen_firmware(), fix coding style] Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211002184539.169-2-jiaxun.y...@flygoat.com> Commit: 10e3f30ff730624094a2fe6a81aaa72064853036 https://github.com/qemu/qemu/commit/10e3f30ff730624094a2fe6a81aaa72064853036 Author: Jiaxun Yang Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Allow loading elf kernel and dtb ELF kernel allows us debugging much easier with DWARF symbols. Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé [PMD: Fix coding style] Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211002184539.169-3-jiaxun.y...@flygoat.com> Commit: 723038999ef42fec4f845841d2d35a52f9ab1dbe https://github.com/qemu/qemu/commit/723038999ef42fec4f845841d2d35a52f9ab1dbe Author: Jiaxun Yang Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Add FDT generator Generate FDT on our own if no dtb argument supplied. Avoid introducing unused device in FDT with user supplied dtb. Signed-off-by: Jiaxun Yang [PMD: Fix coding style] Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211002184539.169-4-jiaxun.y...@flygoat.com> Commit: 7da51cb391bc1100b941d04a0e9fec2cdc5b9632 https://github.com/qemu/qemu/commit/7da51cb391bc1100b941d04a0e9fec2cdc5b9632 Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message: --- target/mips: Remove unused register from MSA 2R/2RF instruction format Commits cbe50b9a8e7 ("target-mips: add MSA VEC/2R format instructions") and 3bdeb68866e ("target-mips: add MSA 2RF format instructions") added the MSA 2R/2RF instructions. However these instructions don't use any target vector register, so remove the unused TCG temporaries. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003175743.3738710-2-f4...@amsat.org> Commit: 2b537a3d856e2500acc321c9333f03b36a829f4e https://github.com/qemu/qemu/commit/2b537a3d856e2500acc321c9333f03b36a829f4e Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message: --- target/mips: Use tcg_constant_i32() in gen_msa_elm_df() Data Format is a 2-bit constant value. Avoid using a TCG temporary by moving it to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211003175743.3738710-3-f4...@amsat.org> Commit: e81a48b9e7fb3db72b7820b0342779227bf0510f https://github.com/qemu/qemu/commit/e81a48b9e7fb3db72b7820b0342779227bf0510f Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message: --- target/mips: Use tcg_constant_i32() in gen_msa_2rf() Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211003175743.3738710-4-f4...@amsat.org> Commit: 74341af7d6c7093bba0893a7efd53d30aa50a200 https://github.com/qemu/qemu/commit/74341af7d6c7093bba0893a7efd53d30aa50a200 Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message:
[Qemu-commits] [qemu/qemu] 719f87: target/mips: Check nanoMIPS DSP MULT[U] accumulato...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 719f874b83792951faa3fe67378eca4034bec3dc https://github.com/qemu/qemu/commit/719f874b83792951faa3fe67378eca4034bec3dc Author: Philippe Mathieu-Daudé Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M target/mips/tcg/nanomips_translate.c.inc Log Message: --- target/mips: Check nanoMIPS DSP MULT[U] accumulator with Release 6 Per the "MIPS Architecture Extension: nanoMIPS32 DSP TRM" rev 0.04, MULT and MULTU opcodes: The value of ac selects an accumulator numbered from 0 to 3. When ac=0, this refers to the original HI/LO register pair of the MIPS32 architecture. In Release 6 of the MIPS Architecture, accumulators are eliminated from MIPS32. Ensure pre-Release 6 is restricted to HI/LO registers pair. Fixes: 8b3698b2947 ("target/mips: Add emulation of DSP ASE for nanoMIPS - part 4") Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Commit: e07f3e265b90d078d69c1f305563f04f1371b7aa https://github.com/qemu/qemu/commit/e07f3e265b90d078d69c1f305563f04f1371b7aa Author: Jiaxun Yang Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Massage memory map information Use memmap array to uinfy address of memory map. That would allow us reuse address information for FDT generation. Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé [PMD: Use local 'regaddr' in gen_firmware(), fix coding style] Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211002184539.169-2-jiaxun.y...@flygoat.com> Commit: 10e3f30ff730624094a2fe6a81aaa72064853036 https://github.com/qemu/qemu/commit/10e3f30ff730624094a2fe6a81aaa72064853036 Author: Jiaxun Yang Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Allow loading elf kernel and dtb ELF kernel allows us debugging much easier with DWARF symbols. Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé [PMD: Fix coding style] Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211002184539.169-3-jiaxun.y...@flygoat.com> Commit: 723038999ef42fec4f845841d2d35a52f9ab1dbe https://github.com/qemu/qemu/commit/723038999ef42fec4f845841d2d35a52f9ab1dbe Author: Jiaxun Yang Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Add FDT generator Generate FDT on our own if no dtb argument supplied. Avoid introducing unused device in FDT with user supplied dtb. Signed-off-by: Jiaxun Yang [PMD: Fix coding style] Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211002184539.169-4-jiaxun.y...@flygoat.com> Commit: 7da51cb391bc1100b941d04a0e9fec2cdc5b9632 https://github.com/qemu/qemu/commit/7da51cb391bc1100b941d04a0e9fec2cdc5b9632 Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message: --- target/mips: Remove unused register from MSA 2R/2RF instruction format Commits cbe50b9a8e7 ("target-mips: add MSA VEC/2R format instructions") and 3bdeb68866e ("target-mips: add MSA 2RF format instructions") added the MSA 2R/2RF instructions. However these instructions don't use any target vector register, so remove the unused TCG temporaries. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003175743.3738710-2-f4...@amsat.org> Commit: 2b537a3d856e2500acc321c9333f03b36a829f4e https://github.com/qemu/qemu/commit/2b537a3d856e2500acc321c9333f03b36a829f4e Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message: --- target/mips: Use tcg_constant_i32() in gen_msa_elm_df() Data Format is a 2-bit constant value. Avoid using a TCG temporary by moving it to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211003175743.3738710-3-f4...@amsat.org> Commit: e81a48b9e7fb3db72b7820b0342779227bf0510f https://github.com/qemu/qemu/commit/e81a48b9e7fb3db72b7820b0342779227bf0510f Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message: --- target/mips: Use tcg_constant_i32() in gen_msa_2rf() Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211003175743.3738710-4-f4...@amsat.org> Commit: 74341af7d6c7093bba0893a7efd53d30aa50a200 https://github.com/qemu/qemu/commit/74341af7d6c7093bba0893a7efd53d30aa50a200 Author: Philippe Mathieu-Daudé Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M target/mips/tcg/msa_translate.c Log Message:
[Qemu-commits] [qemu/qemu] 948516: bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory ...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 948516a3fac0bdd47eb127fe1a86148ed86d5c65 https://github.com/qemu/qemu/commit/948516a3fac0bdd47eb127fe1a86148ed86d5c65 Author: Mikaël Urankar Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag() Similar to the equivalent linux-user commit e6deac9cf99 When mapping MAP_ANONYMOUS memory fragments, still need notice about to set it zero, or it will cause issues. Signed-off-by: Mikaël Urankar Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 26778ac3da794f29c2c7c7d473f0a8d77b874392 https://github.com/qemu/qemu/commit/26778ac3da794f29c2c7c7d473f0a8d77b874392 Author: Mikaël Urankar Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE Simmilar to the equivalent linux-user: commit fb7e378cf9c, which added checking to pread's return value. Update to current qemu standards with {} around the if statement. Signed-off-by: Mikaël Urankar Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kyle Evans Commit: 36d5d891559f6b9f0bae4907669de9bfdf5d4d94 https://github.com/qemu/qemu/commit/36d5d891559f6b9f0bae4907669de9bfdf5d4d94 Author: Warner Losh Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs All these MAP_ symbols are always defined on supported FreeBSD versions (12.2 and newer), so remove the #ifdefs since they aren't needed. Signed-off-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 14837a3f7540f38ba78261238da3914a6529d882 https://github.com/qemu/qemu/commit/14837a3f7540f38ba78261238da3914a6529d882 Author: Warner Losh Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: mmap return ENOMEM on overflow mmap should return ENOMEM on len overflow rather than EINVAL. Return EINVAL when len == 0 and ENOMEM when the rounded to a page length is 0. Found by make check-tcg. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kyle Evans Commit: 953b69cc06fe3ae5fa1c157f17f054fa95620f38 https://github.com/qemu/qemu/commit/953b69cc06fe3ae5fa1c157f17f054fa95620f38 Author: Warner Losh Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: mmap prefer MAP_ANON for BSD MAP_ANON and MAP_ANONYMOUS are identical. Prefer MAP_ANON for BSD since the file is now a confusing mix of the two. Signed-off-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 45b8765e8f3001436c09cebcd9b8b281e6c55804 https://github.com/qemu/qemu/commit/45b8765e8f3001436c09cebcd9b8b281e6c55804 Author: Warner Losh Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Convert to qemu_log logging for mmap debugging Convert DEBUG_MMAP to qemu_log CPU_LOG_PAGE. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kyle Evans Commit: a6b2d060667422d54e077c0a8e4c55bd083ef489 https://github.com/qemu/qemu/commit/a6b2d060667422d54e077c0a8e4c55bd083ef489 Author: Warner Losh Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag Switch checks for !(flags & MAP_ANONYMOUS) with checks for fd != -1. MAP_STACK and MAP_GUARD both require fd == -1 and don't require mapping the fd either. Add analysis from Guy Yur detailing the different cases for MAP_GUARD and MAP_STACK. Signed-off-by: Guy Yur [ partially merged before, finishing the job and documenting origin] Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 0fc76b685989d30a32316b17a9c43ba017e114a1 https://github.com/qemu/qemu/commit/0fc76b685989d30a32316b17a9c43ba017e114a1 Author: Kyle Evans Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head jemalloc requires a working MAP_EXCL. Ensure that no page is double mapped when specified. In addition, use guest_range_valid_untagged to test for valid ranges of pages rather than an incomplete inlined version of the test that might be wrong.
[Qemu-commits] [qemu/qemu] 948516: bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory ...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 948516a3fac0bdd47eb127fe1a86148ed86d5c65 https://github.com/qemu/qemu/commit/948516a3fac0bdd47eb127fe1a86148ed86d5c65 Author: Mikaël Urankar Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag() Similar to the equivalent linux-user commit e6deac9cf99 When mapping MAP_ANONYMOUS memory fragments, still need notice about to set it zero, or it will cause issues. Signed-off-by: Mikaël Urankar Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 26778ac3da794f29c2c7c7d473f0a8d77b874392 https://github.com/qemu/qemu/commit/26778ac3da794f29c2c7c7d473f0a8d77b874392 Author: Mikaël Urankar Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE Simmilar to the equivalent linux-user: commit fb7e378cf9c, which added checking to pread's return value. Update to current qemu standards with {} around the if statement. Signed-off-by: Mikaël Urankar Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kyle Evans Commit: 36d5d891559f6b9f0bae4907669de9bfdf5d4d94 https://github.com/qemu/qemu/commit/36d5d891559f6b9f0bae4907669de9bfdf5d4d94 Author: Warner Losh Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs All these MAP_ symbols are always defined on supported FreeBSD versions (12.2 and newer), so remove the #ifdefs since they aren't needed. Signed-off-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 14837a3f7540f38ba78261238da3914a6529d882 https://github.com/qemu/qemu/commit/14837a3f7540f38ba78261238da3914a6529d882 Author: Warner Losh Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: mmap return ENOMEM on overflow mmap should return ENOMEM on len overflow rather than EINVAL. Return EINVAL when len == 0 and ENOMEM when the rounded to a page length is 0. Found by make check-tcg. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kyle Evans Commit: 953b69cc06fe3ae5fa1c157f17f054fa95620f38 https://github.com/qemu/qemu/commit/953b69cc06fe3ae5fa1c157f17f054fa95620f38 Author: Warner Losh Date: 2021-10-17 (Sun, 17 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: mmap prefer MAP_ANON for BSD MAP_ANON and MAP_ANONYMOUS are identical. Prefer MAP_ANON for BSD since the file is now a confusing mix of the two. Signed-off-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 45b8765e8f3001436c09cebcd9b8b281e6c55804 https://github.com/qemu/qemu/commit/45b8765e8f3001436c09cebcd9b8b281e6c55804 Author: Warner Losh Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Convert to qemu_log logging for mmap debugging Convert DEBUG_MMAP to qemu_log CPU_LOG_PAGE. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kyle Evans Commit: a6b2d060667422d54e077c0a8e4c55bd083ef489 https://github.com/qemu/qemu/commit/a6b2d060667422d54e077c0a8e4c55bd083ef489 Author: Warner Losh Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag Switch checks for !(flags & MAP_ANONYMOUS) with checks for fd != -1. MAP_STACK and MAP_GUARD both require fd == -1 and don't require mapping the fd either. Add analysis from Guy Yur detailing the different cases for MAP_GUARD and MAP_STACK. Signed-off-by: Guy Yur [ partially merged before, finishing the job and documenting origin] Signed-off-by: Warner Losh Reviewed-by: Richard Henderson Reviewed-by: Kyle Evans Commit: 0fc76b685989d30a32316b17a9c43ba017e114a1 https://github.com/qemu/qemu/commit/0fc76b685989d30a32316b17a9c43ba017e114a1 Author: Kyle Evans Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M bsd-user/mmap.c Log Message: --- bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head jemalloc requires a working MAP_EXCL. Ensure that no page is double mapped when specified. In addition, use guest_range_valid_untagged to test for valid ranges of pages rather than an incomplete inlined version of the test that might be wrong.
[Qemu-commits] [qemu/qemu] 20171e: multifd: Implement yank for multifd send side
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 20171ea8950c619f00dc5cfa6136fd489998ffc5 https://github.com/qemu/qemu/commit/20171ea8950c619f00dc5cfa6136fd489998ffc5 Author: Lukas Straub Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/multifd.c M migration/multifd.h Log Message: --- multifd: Implement yank for multifd send side To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 1 Sep 2021 17:58:57 +0200 (1 week, 15 hours, 17 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-09-01T17:58:57+0200 using RSA]] When introducing yank functionality in the migration code I forgot to cover the multifd send side. Signed-off-by: Lukas Straub Tested-by: Leonardo Bras Reviewed-by: Leonardo Bras Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: e9ab82b858c14aa76dac5235a99d1723ec069407 https://github.com/qemu/qemu/commit/e9ab82b858c14aa76dac5235a99d1723ec069407 Author: Lukas Straub Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/multifd.c Log Message: --- multifd: Unconditionally unregister yank function To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 4 Aug 2021 21:26:32 +0200 (5 weeks, 11 hours, 52 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-08-04T21:26:32+0200 using RSA]] Unconditionally unregister yank function in multifd_load_cleanup(). If it is not unregistered here, it will leak and cause a crash in yank_unregister_instance(). Now if the ioc is still in use afterwards, it will only lead to qemu not being able to recover from a hang related to that ioc. After checking the code, i am pretty sure that ref is always 1 when arriving here. So all this currently does is remove the unneeded check. Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: 1230a25f6fa3048c56d0f7f4e70e451330f4d33c https://github.com/qemu/qemu/commit/1230a25f6fa3048c56d0f7f4e70e451330f4d33c Author: David Hildenbrand Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/ram.c Log Message: --- migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*() The parameter is unused, let's drop it. Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: David Hildenbrand Signed-off-by: Juan Quintela Commit: b7acd65707623a8b728b622f4c9dd96c2085c05b https://github.com/qemu/qemu/commit/b7acd65707623a8b728b622f4c9dd96c2085c05b Author: Li Zhijian Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/migration.c M migration/multifd.c M migration/multifd.h Log Message: --- migration: allow multifd for socket protocol only To: , , CC: Li Zhijian Date: Sat, 31 Jul 2021 22:05:51 +0800 (5 weeks, 4 days, 17 hours ago) multifd with unsupported protocol will cause a segment fault. (gdb) bt #0 0x563b4a93faf8 in socket_connect (addr=0x0, errp=0x7f7f02675410) at ../util/qemu-sockets.c:1190 #1 0x563b4a797a03 in qio_channel_socket_connect_sync (ioc=0x563b4d16e8c0, addr=0x0, errp=0x7f7f02675410) at ../io/channel-socket.c:145 #2 0x563b4a797abf in qio_channel_socket_connect_worker (task=0x563b4cd86c30, opaque=0x0) at ../io/channel-socket.c:168 #3 0x563b4a792631 in qio_task_thread_worker (opaque=0x563b4cd86c30) at ../io/task.c:124 #4 0x563b4a91da69 in qemu_thread_start (args=0x563b4c44bb80) at ../util/qemu-thread-posix.c:541 #5 0x7f7fe9b5b3f9 in ?? () #6 0x in ?? () It's enough to check migrate_multifd_is_allowed() in multifd cleanup() and multifd setup() though there are so many other places using migrate_use_multifd(). Signed-off-by: Li Zhijian Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: 5ad15e8614b0877225af42aa28a7195ed2fb74e4 https://github.com/qemu/qemu/commit/5ad15e8614b0877225af42aa28a7195ed2fb74e4 Author: Li Zhijian Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/migration.c M migration/multifd.c Log Message: --- migration: allow enabling mutilfd for specific protocol only To: , , CC: Li Zhijian Date: Sat, 31 Jul 2021 22:05:52 +0800 (5 weeks, 4 days, 17 hours ago) And change the default to true so that in '-incoming defer' case, user is able to change multifd capability. Signed-off-by: Li Zhijian Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: e2daccb0d0375717efed80b772e9fd1e4c51ae5b https://github.com/qemu/qemu/commit/e2daccb0d0375717efed80b772e9fd1e4c51ae5b Author: Li Zhijian Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/rdma.c M migration/trace-events Log Message:
[Qemu-commits] [qemu/qemu] 07a12e: tests: acpi: dump table with failed checksum
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 07a12e71f2f03ace3ea44365f787c7e9b1dd836d https://github.com/qemu/qemu/commit/07a12e71f2f03ace3ea44365f787c7e9b1dd836d Author: Igor Mammedov Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M tests/qtest/acpi-utils.c Log Message: --- tests: acpi: dump table with failed checksum Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-2-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 147478071977a42e9d951aeab38435249754c8b7 https://github.com/qemu/qemu/commit/147478071977a42e9d951aeab38435249754c8b7 Author: Igor Mammedov Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M meson.build M tests/qtest/libqos/libqtest.h M tests/qtest/libqtest.c Log Message: --- tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator Currently it is not possible to create tests that have KVM as a hard requirement on a host that doesn't support KVM for tested target binary (modulo going through the trouble of compiling out the offending test case). Following scenario makes test fail when it's run on non x86 host: qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288 This patch introduces qtest_has_accel() to let users check if accel is available in advance and avoid executing non run-able test-cases. It implements detection of TCG and KVM only, the rest could be added later on, when we actually start testing them in qtest. Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 9db5bf78ba6ace02b05667a1df8a63b10a46699a https://github.com/qemu/qemu/commit/9db5bf78ba6ace02b05667a1df8a63b10a46699a Author: Igor Mammedov Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: A tests/data/acpi/q35/APIC.xapic A tests/data/acpi/q35/DSDT.xapic A tests/data/acpi/q35/FACP.xapic A tests/data/acpi/q35/SRAT.xapic M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests: acpi: whitelist expected tables for acpi/q35/xapic testcase Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-4-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 59b98b1514737535cc46a2955d5ef7922836ac48 https://github.com/qemu/qemu/commit/59b98b1514737535cc46a2955d5ef7922836ac48 Author: Igor Mammedov Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M tests/qtest/bios-tables-test.c Log Message: --- tests: acpi: q35: test for x2APIC entries in SRAT Set -smp 1,maxcpus=288 to test for ACPI code that deal with CPUs with large APIC ID (>255). PS: Test requires KVM and in-kernel irqchip support, so skip test if KVM is not available. Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-5-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: d92f2410aa80b7cf022bda1d5e4d1116cd179afe https://github.com/qemu/qemu/commit/d92f2410aa80b7cf022bda1d5e4d1116cd179afe Author: Igor Mammedov Date: 2021-10-18 (Mon, 18 Oct 2021) Changed paths: M tests/data/acpi/q35/APIC.xapic M tests/data/acpi/q35/DSDT.xapic M tests/data/acpi/q35/FACP.xapic M tests/data/acpi/q35/SRAT.xapic M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests: acpi: update expected tables blobs Update adds CPU entries to MADT/SRAT/FACP and DSDT to cover 288 CPUs. Notable changes are that CPUs with APIC ID 255 and higher use 'Processor Local x2APIC Affinity' structure in SRAT and "Device" element in DSDT. FACP: - Use APIC Cluster Model (V4) : 0 + Use APIC Cluster Model (V4) : 1 SRAT: ... +[1010h 4112 1]Subtable Type : 00 [Processor Local APIC/SAPIC Affinity] +[1011h 4113 1] Length : 10 + +[1012h 4114 1] Proximity Domain Low(8) : 00 +[1013h 4115 1] Apic ID : FE +[1014h 4116 4]Flags (decoded below) : 0001 + Enabled : 1 +[1018h 4120 1] Local Sapic EID : 00 +[1019h 4121 3]Proximity Domain High(24) : 00 +[101Ch 4124 4] Clock Domain : + +[1020h 4128 1]Subtable Type : 02 [Processor Local x2APIC Affinity] +[1021h 4129 1] Length : 18 + +[1022h 4130 2]Reserved1 : +[1024h 4132 4] Proximity Domain : 0001 +[1028h 4136 4] Apic ID : 00FF +[102Ch 4140 4]Flags (decoded below) : 0001 + Enabled : 1 +[1030h 4144 4] Clock Domain : +[1034h 4148 4]Reserved2 : ...
[Qemu-commits] [qemu/qemu] 20171e: multifd: Implement yank for multifd send side
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 20171ea8950c619f00dc5cfa6136fd489998ffc5 https://github.com/qemu/qemu/commit/20171ea8950c619f00dc5cfa6136fd489998ffc5 Author: Lukas Straub Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/multifd.c M migration/multifd.h Log Message: --- multifd: Implement yank for multifd send side To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 1 Sep 2021 17:58:57 +0200 (1 week, 15 hours, 17 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-09-01T17:58:57+0200 using RSA]] When introducing yank functionality in the migration code I forgot to cover the multifd send side. Signed-off-by: Lukas Straub Tested-by: Leonardo Bras Reviewed-by: Leonardo Bras Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: e9ab82b858c14aa76dac5235a99d1723ec069407 https://github.com/qemu/qemu/commit/e9ab82b858c14aa76dac5235a99d1723ec069407 Author: Lukas Straub Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/multifd.c Log Message: --- multifd: Unconditionally unregister yank function To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 4 Aug 2021 21:26:32 +0200 (5 weeks, 11 hours, 52 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-08-04T21:26:32+0200 using RSA]] Unconditionally unregister yank function in multifd_load_cleanup(). If it is not unregistered here, it will leak and cause a crash in yank_unregister_instance(). Now if the ioc is still in use afterwards, it will only lead to qemu not being able to recover from a hang related to that ioc. After checking the code, i am pretty sure that ref is always 1 when arriving here. So all this currently does is remove the unneeded check. Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: 1230a25f6fa3048c56d0f7f4e70e451330f4d33c https://github.com/qemu/qemu/commit/1230a25f6fa3048c56d0f7f4e70e451330f4d33c Author: David Hildenbrand Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/ram.c Log Message: --- migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*() The parameter is unused, let's drop it. Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: David Hildenbrand Signed-off-by: Juan Quintela Commit: b7acd65707623a8b728b622f4c9dd96c2085c05b https://github.com/qemu/qemu/commit/b7acd65707623a8b728b622f4c9dd96c2085c05b Author: Li Zhijian Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/migration.c M migration/multifd.c M migration/multifd.h Log Message: --- migration: allow multifd for socket protocol only To: , , CC: Li Zhijian Date: Sat, 31 Jul 2021 22:05:51 +0800 (5 weeks, 4 days, 17 hours ago) multifd with unsupported protocol will cause a segment fault. (gdb) bt #0 0x563b4a93faf8 in socket_connect (addr=0x0, errp=0x7f7f02675410) at ../util/qemu-sockets.c:1190 #1 0x563b4a797a03 in qio_channel_socket_connect_sync (ioc=0x563b4d16e8c0, addr=0x0, errp=0x7f7f02675410) at ../io/channel-socket.c:145 #2 0x563b4a797abf in qio_channel_socket_connect_worker (task=0x563b4cd86c30, opaque=0x0) at ../io/channel-socket.c:168 #3 0x563b4a792631 in qio_task_thread_worker (opaque=0x563b4cd86c30) at ../io/task.c:124 #4 0x563b4a91da69 in qemu_thread_start (args=0x563b4c44bb80) at ../util/qemu-thread-posix.c:541 #5 0x7f7fe9b5b3f9 in ?? () #6 0x in ?? () It's enough to check migrate_multifd_is_allowed() in multifd cleanup() and multifd setup() though there are so many other places using migrate_use_multifd(). Signed-off-by: Li Zhijian Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: 5ad15e8614b0877225af42aa28a7195ed2fb74e4 https://github.com/qemu/qemu/commit/5ad15e8614b0877225af42aa28a7195ed2fb74e4 Author: Li Zhijian Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/migration.c M migration/multifd.c Log Message: --- migration: allow enabling mutilfd for specific protocol only To: , , CC: Li Zhijian Date: Sat, 31 Jul 2021 22:05:52 +0800 (5 weeks, 4 days, 17 hours ago) And change the default to true so that in '-incoming defer' case, user is able to change multifd capability. Signed-off-by: Li Zhijian Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Commit: e2daccb0d0375717efed80b772e9fd1e4c51ae5b https://github.com/qemu/qemu/commit/e2daccb0d0375717efed80b772e9fd1e4c51ae5b Author: Li Zhijian Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M migration/rdma.c M migration/trace-events Log Message:
[Qemu-commits] [qemu/qemu] 685db1: tests: acpi: dump table with failed checksum
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 685db13a38f7599fabd353382ff65d3c244ea641 https://github.com/qemu/qemu/commit/685db13a38f7599fabd353382ff65d3c244ea641 Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/qtest/acpi-utils.c Log Message: --- tests: acpi: dump table with failed checksum Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-2-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: e741aff0f43343d6d91242fee1072fee376d5cce https://github.com/qemu/qemu/commit/e741aff0f43343d6d91242fee1072fee376d5cce Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M meson.build M tests/qtest/libqos/libqtest.h M tests/qtest/libqtest.c Log Message: --- tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator Currently it is not possible to create tests that have KVM as a hard requirement on a host that doesn't support KVM for tested target binary (modulo going through the trouble of compiling out the offending test case). Following scenario makes test fail when it's run on non x86 host: qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288 This patch introduces qtest_has_accel() to let users check if accel is available in advance and avoid executing non run-able test-cases. It implements detection of TCG and KVM only, the rest could be added later on, when we actually start testing them in qtest. Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-3-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: c306cdb0cc5327f336fbf9a7411f319f0717ee75 https://github.com/qemu/qemu/commit/c306cdb0cc5327f336fbf9a7411f319f0717ee75 Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: A tests/data/acpi/q35/APIC.xapic A tests/data/acpi/q35/DSDT.xapic A tests/data/acpi/q35/FACP.xapic A tests/data/acpi/q35/SRAT.xapic M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests: acpi: whitelist expected tables for acpi/q35/xapic testcase Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-4-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 80a2f3387c239d06d4a4b6838b511a88838ddc0f https://github.com/qemu/qemu/commit/80a2f3387c239d06d4a4b6838b511a88838ddc0f Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/qtest/bios-tables-test.c Log Message: --- tests: acpi: q35: test for x2APIC entries in SRAT Set -smp 1,maxcpus=288 to test for ACPI code that deal with CPUs with large APIC ID (>255). PS: Test requires KVM and in-kernel irqchip support, so skip test if KVM is not available. Signed-off-by: Igor Mammedov Message-Id: <20210902113551.461632-5-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: b59a898458aea328618521be7dc180d2396c0bf4 https://github.com/qemu/qemu/commit/b59a898458aea328618521be7dc180d2396c0bf4 Author: Igor Mammedov Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M tests/data/acpi/q35/APIC.xapic M tests/data/acpi/q35/DSDT.xapic M tests/data/acpi/q35/FACP.xapic M tests/data/acpi/q35/SRAT.xapic M tests/qtest/bios-tables-test-allowed-diff.h Log Message: --- tests: acpi: update expected tables blobs Update adds CPU entries to MADT/SRAT/FACP and DSDT to cover 288 CPUs. Notable changes are that CPUs with APIC ID 255 and higher use 'Processor Local x2APIC Affinity' structure in SRAT and "Device" element in DSDT. FACP: - Use APIC Cluster Model (V4) : 0 + Use APIC Cluster Model (V4) : 1 SRAT: ... +[1010h 4112 1]Subtable Type : 00 [Processor Local APIC/SAPIC Affinity] +[1011h 4113 1] Length : 10 + +[1012h 4114 1] Proximity Domain Low(8) : 00 +[1013h 4115 1] Apic ID : FE +[1014h 4116 4]Flags (decoded below) : 0001 + Enabled : 1 +[1018h 4120 1] Local Sapic EID : 00 +[1019h 4121 3]Proximity Domain High(24) : 00 +[101Ch 4124 4] Clock Domain : + +[1020h 4128 1]Subtable Type : 02 [Processor Local x2APIC Affinity] +[1021h 4129 1] Length : 18 + +[1022h 4130 2]Reserved1 : +[1024h 4132 4] Proximity Domain : 0001 +[1028h 4136 4] Apic ID : 00FF +[102Ch 4140 4]Flags (decoded below) : 0001 + Enabled : 1 +[1030h 4144 4] Clock Domain : +[1034h 4148 4]Reserved2 : ...
[Qemu-commits] [qemu/qemu] 381123: configure: remove --oss-lib
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 381123ddae754b68d55cd872e719a2ba69fe7f4a https://github.com/qemu/qemu/commit/381123ddae754b68d55cd872e719a2ba69fe7f4a Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M configure Log Message: --- configure: remove --oss-lib OSS is a kernel API, so the option should not be needed. The library is used on NetBSD, where OSS is emulated, so keep the variable. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20211007130630.632028-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 7e1fbe7963f2b9bb44d6aa5c1ef793894212190a https://github.com/qemu/qemu/commit/7e1fbe7963f2b9bb44d6aa5c1ef793894212190a Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M audio/meson.build M configure Log Message: --- audio: remove CONFIG_AUDIO_WIN_INT Ever since winwaveaudio was removed in 2015, CONFIG_AUDIO_WIN_INT is only set if dsound is in use, so use CONFIG_AUDIO_DSOUND directly. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-3-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 87430d5b13fdef0768cdb55352652ff78095e761 https://github.com/qemu/qemu/commit/87430d5b13fdef0768cdb55352652ff78095e761 Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M audio/meson.build M configure M meson.build M meson_options.txt Log Message: --- configure, meson: move audio driver detection to Meson This brings a change that makes audio drivers more similar to all other modules. All drivers are built by default, while --audio-drv-list only governs the default choice of the audio driver. Meson options are added to disable the drivers, and the next patches will fix the help messages and command line options, and especially make the non-default drivers available via -audiodev. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-4-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: e5424a2997bd5c6d480e80d3aa106bd4fba5fa7c https://github.com/qemu/qemu/commit/e5424a2997bd5c6d480e80d3aa106bd4fba5fa7c Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M meson.build Log Message: --- meson: define symbols for all available audio drivers All drivers are now built by default if the corresponding libraries are available, similar to how all other modules behave; --audio-drv-list only governs the default choice of the audio driver. Adjust the CONFIG_AUDIO_* preprocessor symbols so that they are based on library availability rather than --audio-drv-list, so that the tests and -audiodev help follow the new logic. Cc: Gerd Hoffman Cc: Volker Rümelin Message-Id: <20211007130630.632028-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: ca50e5231cfc120e90d264890bff59330257c361 https://github.com/qemu/qemu/commit/ca50e5231cfc120e90d264890bff59330257c361 Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M configure Log Message: --- configure: add command line options for audio drivers Handle the choice of audio drivers the same as all other dependencies. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 65ce87d47669168593398a4a3a0c0b0494858c0d https://github.com/qemu/qemu/commit/65ce87d47669168593398a4a3a0c0b0494858c0d Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M Kconfig.host M hw/mem/Kconfig M hw/mem/meson.build M meson.build Log Message: --- kconfig: split CONFIG_SPARSE_MEM from fuzzing Pass CONFIG_FUZZ via host_kconfig, and use it to select the sparse-mem device. Cc: Alexander Oleinik Reviewed-by: Alexander Bulekov Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-1-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 537b7248991b85d1fb92cce78ecf1056f40bb750 https://github.com/qemu/qemu/commit/537b7248991b85d1fb92cce78ecf1056f40bb750 Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M configure M meson.build M meson_options.txt M tests/qtest/fuzz/meson.build Log Message: --- configure, meson: move fuzzing configuration to Meson Cc: Alexander Oleinik Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 0955d66e65e68580021a99960581422e93c127d4
[Qemu-commits] [qemu/qemu] 381123: configure: remove --oss-lib
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 381123ddae754b68d55cd872e719a2ba69fe7f4a https://github.com/qemu/qemu/commit/381123ddae754b68d55cd872e719a2ba69fe7f4a Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M configure Log Message: --- configure: remove --oss-lib OSS is a kernel API, so the option should not be needed. The library is used on NetBSD, where OSS is emulated, so keep the variable. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20211007130630.632028-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 7e1fbe7963f2b9bb44d6aa5c1ef793894212190a https://github.com/qemu/qemu/commit/7e1fbe7963f2b9bb44d6aa5c1ef793894212190a Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M audio/meson.build M configure Log Message: --- audio: remove CONFIG_AUDIO_WIN_INT Ever since winwaveaudio was removed in 2015, CONFIG_AUDIO_WIN_INT is only set if dsound is in use, so use CONFIG_AUDIO_DSOUND directly. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-3-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 87430d5b13fdef0768cdb55352652ff78095e761 https://github.com/qemu/qemu/commit/87430d5b13fdef0768cdb55352652ff78095e761 Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M audio/meson.build M configure M meson.build M meson_options.txt Log Message: --- configure, meson: move audio driver detection to Meson This brings a change that makes audio drivers more similar to all other modules. All drivers are built by default, while --audio-drv-list only governs the default choice of the audio driver. Meson options are added to disable the drivers, and the next patches will fix the help messages and command line options, and especially make the non-default drivers available via -audiodev. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-4-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: e5424a2997bd5c6d480e80d3aa106bd4fba5fa7c https://github.com/qemu/qemu/commit/e5424a2997bd5c6d480e80d3aa106bd4fba5fa7c Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M meson.build Log Message: --- meson: define symbols for all available audio drivers All drivers are now built by default if the corresponding libraries are available, similar to how all other modules behave; --audio-drv-list only governs the default choice of the audio driver. Adjust the CONFIG_AUDIO_* preprocessor symbols so that they are based on library availability rather than --audio-drv-list, so that the tests and -audiodev help follow the new logic. Cc: Gerd Hoffman Cc: Volker Rümelin Message-Id: <20211007130630.632028-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: ca50e5231cfc120e90d264890bff59330257c361 https://github.com/qemu/qemu/commit/ca50e5231cfc120e90d264890bff59330257c361 Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M configure Log Message: --- configure: add command line options for audio drivers Handle the choice of audio drivers the same as all other dependencies. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 65ce87d47669168593398a4a3a0c0b0494858c0d https://github.com/qemu/qemu/commit/65ce87d47669168593398a4a3a0c0b0494858c0d Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M Kconfig.host M hw/mem/Kconfig M hw/mem/meson.build M meson.build Log Message: --- kconfig: split CONFIG_SPARSE_MEM from fuzzing Pass CONFIG_FUZZ via host_kconfig, and use it to select the sparse-mem device. Cc: Alexander Oleinik Reviewed-by: Alexander Bulekov Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-1-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 537b7248991b85d1fb92cce78ecf1056f40bb750 https://github.com/qemu/qemu/commit/537b7248991b85d1fb92cce78ecf1056f40bb750 Author: Paolo Bonzini Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M configure M meson.build M meson_options.txt M tests/qtest/fuzz/meson.build Log Message: --- configure, meson: move fuzzing configuration to Meson Cc: Alexander Oleinik Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 0955d66e65e68580021a99960581422e93c127d4
[Qemu-commits] [qemu/qemu] e287bf: net: Introduce NetClientInfo.check_peer_type()
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: e287bf7bb15ffd3728c000d9c5b52460ea17d713 https://github.com/qemu/qemu/commit/e287bf7bb15ffd3728c000d9c5b52460ea17d713 Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M hw/core/qdev-properties-system.c M include/net/net.h Log Message: --- net: Introduce NetClientInfo.check_peer_type() Some network backends (vhost-user and vhost-vdpa) work only with specific devices. At startup, they second guess what the command line option handling will do and error out if they think a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error messages ('-device floppy,netdev=foo' should complain about an unknown property, not about the wrong kind of network device being attached) and completely ignores hotplugging. Add a callback where backends can check compatibility with a device when it actually tries to attach, even on hotplug. Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-2-kw...@redhat.com> Reviewed-by: Damien Hedde Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: 5c485d51c4e2e8b3c78110a1a3f31f789c900d9d https://github.com/qemu/qemu/commit/5c485d51c4e2e8b3c78110a1a3f31f789c900d9d Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M net/vhost-user.c Log Message: --- net/vhost-user: Fix device compatibility check vhost-user works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error messages ('-device floppy,netdev=foo' should complain about an unknown property, not about the wrong kind of network device being attached) and completely ignores hotplugging. Drop the old checks and implement .check_peer_type() instead to fix this. As a nice side effect, it also removes one more dependency on the legacy QemuOpts infrastructure and even reduces the code size. Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-3-kw...@redhat.com> Reviewed-by: Damien Hedde Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: ee8a1c63d337a893fa915dd263dfdaa272e1a76a https://github.com/qemu/qemu/commit/ee8a1c63d337a893fa915dd263dfdaa272e1a76a Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M net/vhost-vdpa.c Log Message: --- net/vhost-vdpa: Fix device compatibility check vhost-vdpa works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error messages ('-device floppy,netdev=foo' should complain about an unknown property, not about the wrong kind of network device being attached) and completely ignores hotplugging. Drop the old checks and implement .check_peer_type() instead to fix this. As a nice side effect, it also removes one more dependency on the legacy QemuOpts infrastructure and even reduces the code size. Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-4-kw...@redhat.com> Reviewed-by: Damien Hedde Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: dbc8221f8cf3a3004fb6b4d0675f5852758b0388 https://github.com/qemu/qemu/commit/dbc8221f8cf3a3004fb6b4d0675f5852758b0388 Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M qom/object.c M qom/object_interfaces.c Log Message: --- qom: Reduce use of error_propagate() ERRP_GUARD() makes debugging easier by making sure that _abort still fails at the real origin of the error instead of error_propagate(). Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-5-kw...@redhat.com> Reviewed-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: e2c8eb1454b6aee79077d6d9710ec92d66554e56 https://github.com/qemu/qemu/commit/e2c8eb1454b6aee79077d6d9710ec92d66554e56 Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M tests/qemu-iotests/245 Log Message: --- iotests/245: Fix type for iothread property iothread is a string property, so None (= JSON null) is not a valid value for it. Pass the empty string instead to get the default iothread. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211008133442.141332-6-kw...@redhat.com> Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: af6400afb89f5eb3f66f841c8ee8c2f6754c8394
[Qemu-commits] [qemu/qemu] e7e588: qcow2: Silence clang -m32 compiler warning
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: e7e588d432d31ecebc26358e47201dd108db964c https://github.com/qemu/qemu/commit/e7e588d432d31ecebc26358e47201dd108db964c Author: Hanna Reitz Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/qcow2-cluster.c Log Message: --- qcow2: Silence clang -m32 compiler warning With -m32, size_t is generally only a uint32_t. That makes clang complain that in the assertion assert(qiov->size <= INT64_MAX); the range of the type of qiov->size (size_t) is too small for any of its values to ever exceed INT64_MAX. Cast qiov->size to uint64_t to silence clang. Fixes: f7ef38dd1310d7d9db76d0aa16899cbc5744f36d ("block: use int64_t instead of uint64_t in driver read handlers") Signed-off-by: Hanna Reitz Message-Id: <20211011155031.149158-1-hre...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake Commit: 7242db6389261cb936bd2240351b137843d49807 https://github.com/qemu/qemu/commit/7242db6389261cb936bd2240351b137843d49807 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c Log Message: --- block-backend: blk_check_byte_request(): int64_t bytes Rename size and make it int64_t to correspond to modern block layer, which always uses int64_t for offset and bytes (not in blk layer yet, which is a task for following commits). All callers pass int or unsigned int. So, for bytes in [0, INT_MAX] nothing is changed, for negative bytes we now fail on "bytes < 0" check instead of "bytes > INT_MAX" check. Note, that blk_check_byte_request() still doesn't allow requests exceeding INT_MAX. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-2-vsement...@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake Commit: 9547907705c94fa0415427ce12be418f8b68b56d https://github.com/qemu/qemu/commit/9547907705c94fa0415427ce12be418f8b68b56d Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c M block/trace-events M include/sysemu/block-backend.h Log Message: --- block-backend: make blk_co_preadv() 64bit For both updated functions, the type of bytes becomes wider, so all callers should be OK with it. blk_co_preadv() only passes its arguments to blk_do_preadv(). blk_do_preadv() passes bytes to: - trace_blk_co_preadv, which is updated too - blk_check_byte_request, throttle_group_co_io_limits_intercept, bdrv_co_preadv, which are already int64_t. Note that requests exceeding INT_MAX are still restricted by blk_check_byte_request(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-3-vsement...@virtuozzo.com> Reviewed-by: Eric Blake [eblake: grammar tweaks] Signed-off-by: Eric Blake Commit: 34460feb63230daad12b0e0f31754f7ef5bc2be9 https://github.com/qemu/qemu/commit/34460feb63230daad12b0e0f31754f7ef5bc2be9 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c M block/trace-events M include/sysemu/block-backend.h Log Message: --- block-backend: convert blk_co_pwritev_part to int64_t bytes We convert blk_do_pwritev_part() and some wrappers: blk_co_pwritev_part(), blk_co_pwritev(), blk_co_pwrite_zeroes(). All functions are converted so that the parameter type becomes wider, so all callers should be OK with it. Look at blk_do_pwritev_part() body: bytes is passed to: - trace_blk_co_pwritev (we update it here) - blk_check_byte_request, throttle_group_co_io_limits_intercept, bdrv_co_pwritev_part - all already have int64_t argument. Note that requests exceeding INT_MAX are still restricted by blk_check_byte_request(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-4-vsement...@virtuozzo.com> Reviewed-by: Eric Blake [eblake: grammar tweaks] Signed-off-by: Eric Blake Commit: 2800637a33b0ff68c40c94a1d3d13f92feaadbc6 https://github.com/qemu/qemu/commit/2800637a33b0ff68c40c94a1d3d13f92feaadbc6 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c M include/sysemu/block-backend.h Log Message: --- block-backend: convert blk_co_pdiscard to int64_t bytes We updated blk_do_pdiscard() and its wrapper blk_co_pdiscard(). Both functions are updated so that the parameter type becomes wider, so all callers should be OK with it. Look at blk_do_pdiscard(): bytes is passed only to blk_check_byte_request() and bdrv_co_pdiscard(), which already have int64_t bytes parameter, so we are OK. Note that requests exceeding INT_MAX are still restricted by blk_check_byte_request(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-5-vsement...@virtuozzo.com> Reviewed-by:
[Qemu-commits] [qemu/qemu] e7e588: qcow2: Silence clang -m32 compiler warning
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: e7e588d432d31ecebc26358e47201dd108db964c https://github.com/qemu/qemu/commit/e7e588d432d31ecebc26358e47201dd108db964c Author: Hanna Reitz Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/qcow2-cluster.c Log Message: --- qcow2: Silence clang -m32 compiler warning With -m32, size_t is generally only a uint32_t. That makes clang complain that in the assertion assert(qiov->size <= INT64_MAX); the range of the type of qiov->size (size_t) is too small for any of its values to ever exceed INT64_MAX. Cast qiov->size to uint64_t to silence clang. Fixes: f7ef38dd1310d7d9db76d0aa16899cbc5744f36d ("block: use int64_t instead of uint64_t in driver read handlers") Signed-off-by: Hanna Reitz Message-Id: <20211011155031.149158-1-hre...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake Commit: 7242db6389261cb936bd2240351b137843d49807 https://github.com/qemu/qemu/commit/7242db6389261cb936bd2240351b137843d49807 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c Log Message: --- block-backend: blk_check_byte_request(): int64_t bytes Rename size and make it int64_t to correspond to modern block layer, which always uses int64_t for offset and bytes (not in blk layer yet, which is a task for following commits). All callers pass int or unsigned int. So, for bytes in [0, INT_MAX] nothing is changed, for negative bytes we now fail on "bytes < 0" check instead of "bytes > INT_MAX" check. Note, that blk_check_byte_request() still doesn't allow requests exceeding INT_MAX. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-2-vsement...@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake Commit: 9547907705c94fa0415427ce12be418f8b68b56d https://github.com/qemu/qemu/commit/9547907705c94fa0415427ce12be418f8b68b56d Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c M block/trace-events M include/sysemu/block-backend.h Log Message: --- block-backend: make blk_co_preadv() 64bit For both updated functions, the type of bytes becomes wider, so all callers should be OK with it. blk_co_preadv() only passes its arguments to blk_do_preadv(). blk_do_preadv() passes bytes to: - trace_blk_co_preadv, which is updated too - blk_check_byte_request, throttle_group_co_io_limits_intercept, bdrv_co_preadv, which are already int64_t. Note that requests exceeding INT_MAX are still restricted by blk_check_byte_request(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-3-vsement...@virtuozzo.com> Reviewed-by: Eric Blake [eblake: grammar tweaks] Signed-off-by: Eric Blake Commit: 34460feb63230daad12b0e0f31754f7ef5bc2be9 https://github.com/qemu/qemu/commit/34460feb63230daad12b0e0f31754f7ef5bc2be9 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c M block/trace-events M include/sysemu/block-backend.h Log Message: --- block-backend: convert blk_co_pwritev_part to int64_t bytes We convert blk_do_pwritev_part() and some wrappers: blk_co_pwritev_part(), blk_co_pwritev(), blk_co_pwrite_zeroes(). All functions are converted so that the parameter type becomes wider, so all callers should be OK with it. Look at blk_do_pwritev_part() body: bytes is passed to: - trace_blk_co_pwritev (we update it here) - blk_check_byte_request, throttle_group_co_io_limits_intercept, bdrv_co_pwritev_part - all already have int64_t argument. Note that requests exceeding INT_MAX are still restricted by blk_check_byte_request(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-4-vsement...@virtuozzo.com> Reviewed-by: Eric Blake [eblake: grammar tweaks] Signed-off-by: Eric Blake Commit: 2800637a33b0ff68c40c94a1d3d13f92feaadbc6 https://github.com/qemu/qemu/commit/2800637a33b0ff68c40c94a1d3d13f92feaadbc6 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M block/block-backend.c M include/sysemu/block-backend.h Log Message: --- block-backend: convert blk_co_pdiscard to int64_t bytes We updated blk_do_pdiscard() and its wrapper blk_co_pdiscard(). Both functions are updated so that the parameter type becomes wider, so all callers should be OK with it. Look at blk_do_pdiscard(): bytes is passed only to blk_check_byte_request() and bdrv_co_pdiscard(), which already have int64_t bytes parameter, so we are OK. Note that requests exceeding INT_MAX are still restricted by blk_check_byte_request(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006131718.214235-5-vsement...@virtuozzo.com> Reviewed-by:
[Qemu-commits] [qemu/qemu] f14201: s390x/ipl: check kernel command line size
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: f1420101023c7d170d802efc8daab686189ed1bf https://github.com/qemu/qemu/commit/f1420101023c7d170d802efc8daab686189ed1bf Author: Marc Hartmayer Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M hw/s390x/ipl.c Log Message: --- s390x/ipl: check kernel command line size Check if the provided kernel command line exceeds the maximum size of the s390x Linux kernel command line size, which is 896 bytes. Reported-by: Sven Schnelle Signed-off-by: Marc Hartmayer Message-Id: <20211006092631.20732-1-mhart...@linux.ibm.com> Reviewed-by: Christian Borntraeger Reviewed-by: Philippe Mathieu-Daudé [thuth: Adjusted format specifier for size_t] Signed-off-by: Thomas Huth Commit: 998eb7448c75b432a13257d019f6866e604ce43c https://github.com/qemu/qemu/commit/998eb7448c75b432a13257d019f6866e604ce43c Author: Eric Farman Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/s390x/sigp.c Log Message: --- s390x: sigp: Force Set Architecture to return Invalid Parameter According to the Principles of Operation, the SIGP Set Architecture order will return Incorrect State if some CPUs are not stopped, but only if the CZAM facility is not present. If it is, the order will return Invalid Parameter because the architecture mode cannot be changed. Since CZAM always exists when S390_FEAT_ZARCH exists, which in turn exists for every defined CPU model, we can simplify this code. Fixes: 075e52b81664 ("s390x/cpumodel: we are always in zarchitecture mode") Signed-off-by: Eric Farman Reviewed-by: Christian Borntraeger Reviewed-by: Janosch Frank Message-Id: <20211008203811.1980478-2-far...@linux.ibm.com> Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth Commit: ebbc6034dcfe772473d1d29724b36ce7a9a49ad2 https://github.com/qemu/qemu/commit/ebbc6034dcfe772473d1d29724b36ce7a9a49ad2 Author: Cornelia Huck Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- vfio-ccw: step down as maintainer I currently don't have time to act as vfio-ccw maintainer anymore, so remove myself there. Signed-off-by: Cornelia Huck Message-Id: <20211012144040.360887-2-coh...@redhat.com> Acked-by: Matthew Rosato Acked-by: Eric Farman Signed-off-by: Thomas Huth Commit: 373b2ab35635537c67bb6fe9aa36367f28a067a2 https://github.com/qemu/qemu/commit/373b2ab35635537c67bb6fe9aa36367f28a067a2 Author: Cornelia Huck Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- s390x/kvm: step down as maintainer I'm no longer involved with KVM/s390 on the kernel side, and I don't have enough resources to work on the s390 KVM cpus support, so I'll step down. Signed-off-by: Cornelia Huck Acked-by: Halil Pasic Message-Id: <20211012144040.360887-3-coh...@redhat.com> Signed-off-by: Thomas Huth Commit: afe5c8c5c14aff25fab6ae83957e87c717415be3 https://github.com/qemu/qemu/commit/afe5c8c5c14aff25fab6ae83957e87c717415be3 Author: Cornelia Huck Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- s390x virtio-ccw machine: step down as maintainer I currently don't have time to work on the s390x virtio-ccw machine anymore, so let's step down. (I will, however, continue as a maintainer for the virtio-ccw *transport*.) Signed-off-by: Cornelia Huck Acked-by: Halil Pasic Message-Id: <20211012144040.360887-4-coh...@redhat.com> Signed-off-by: Thomas Huth Commit: 962fde57b7d573281619cb2b7068d570470ef833 https://github.com/qemu/qemu/commit/962fde57b7d573281619cb2b7068d570470ef833 Author: Thomas Huth Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M dtc Log Message: --- dtc: Update to version 1.6.1 The dtc submodule is currently pointing to non-release commit. It's nicer if submodules point to release versions instead and since dtc 1.6.1 is available now, let's update to that version. Message-Id: <20210827120901.150276-4-th...@redhat.com> Acked-by: Greg Kurz Acked-by: David Gibson Signed-off-by: Thomas Huth Commit: 82d88f834c8f7d33ad9529fca80924bc496fcb70 https://github.com/qemu/qemu/commit/82d88f834c8f7d33ad9529fca80924bc496fcb70 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M MAINTAINERS M dtc M hw/s390x/ipl.c M target/s390x/sigp.c Log Message: --- Merge remote-tracking branch 'remotes/thuth/tags/pull-request-2021-10-15' into staging * Check kernel command line size on s390x * Simplification of one of the SIGP instructions on s390x * Cornelia stepping down as maintainer in some subsystems * Update the dtc submodule to a proper release version # gpg: Signature made Fri 15 Oct 2021 02:11:13 AM PDT # gpg:using RSA key
[Qemu-commits] [qemu/qemu] f14201: s390x/ipl: check kernel command line size
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: f1420101023c7d170d802efc8daab686189ed1bf https://github.com/qemu/qemu/commit/f1420101023c7d170d802efc8daab686189ed1bf Author: Marc Hartmayer Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M hw/s390x/ipl.c Log Message: --- s390x/ipl: check kernel command line size Check if the provided kernel command line exceeds the maximum size of the s390x Linux kernel command line size, which is 896 bytes. Reported-by: Sven Schnelle Signed-off-by: Marc Hartmayer Message-Id: <20211006092631.20732-1-mhart...@linux.ibm.com> Reviewed-by: Christian Borntraeger Reviewed-by: Philippe Mathieu-Daudé [thuth: Adjusted format specifier for size_t] Signed-off-by: Thomas Huth Commit: 998eb7448c75b432a13257d019f6866e604ce43c https://github.com/qemu/qemu/commit/998eb7448c75b432a13257d019f6866e604ce43c Author: Eric Farman Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/s390x/sigp.c Log Message: --- s390x: sigp: Force Set Architecture to return Invalid Parameter According to the Principles of Operation, the SIGP Set Architecture order will return Incorrect State if some CPUs are not stopped, but only if the CZAM facility is not present. If it is, the order will return Invalid Parameter because the architecture mode cannot be changed. Since CZAM always exists when S390_FEAT_ZARCH exists, which in turn exists for every defined CPU model, we can simplify this code. Fixes: 075e52b81664 ("s390x/cpumodel: we are always in zarchitecture mode") Signed-off-by: Eric Farman Reviewed-by: Christian Borntraeger Reviewed-by: Janosch Frank Message-Id: <20211008203811.1980478-2-far...@linux.ibm.com> Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth Commit: ebbc6034dcfe772473d1d29724b36ce7a9a49ad2 https://github.com/qemu/qemu/commit/ebbc6034dcfe772473d1d29724b36ce7a9a49ad2 Author: Cornelia Huck Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- vfio-ccw: step down as maintainer I currently don't have time to act as vfio-ccw maintainer anymore, so remove myself there. Signed-off-by: Cornelia Huck Message-Id: <20211012144040.360887-2-coh...@redhat.com> Acked-by: Matthew Rosato Acked-by: Eric Farman Signed-off-by: Thomas Huth Commit: 373b2ab35635537c67bb6fe9aa36367f28a067a2 https://github.com/qemu/qemu/commit/373b2ab35635537c67bb6fe9aa36367f28a067a2 Author: Cornelia Huck Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- s390x/kvm: step down as maintainer I'm no longer involved with KVM/s390 on the kernel side, and I don't have enough resources to work on the s390 KVM cpus support, so I'll step down. Signed-off-by: Cornelia Huck Acked-by: Halil Pasic Message-Id: <20211012144040.360887-3-coh...@redhat.com> Signed-off-by: Thomas Huth Commit: afe5c8c5c14aff25fab6ae83957e87c717415be3 https://github.com/qemu/qemu/commit/afe5c8c5c14aff25fab6ae83957e87c717415be3 Author: Cornelia Huck Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M MAINTAINERS Log Message: --- s390x virtio-ccw machine: step down as maintainer I currently don't have time to work on the s390x virtio-ccw machine anymore, so let's step down. (I will, however, continue as a maintainer for the virtio-ccw *transport*.) Signed-off-by: Cornelia Huck Acked-by: Halil Pasic Message-Id: <20211012144040.360887-4-coh...@redhat.com> Signed-off-by: Thomas Huth Commit: 962fde57b7d573281619cb2b7068d570470ef833 https://github.com/qemu/qemu/commit/962fde57b7d573281619cb2b7068d570470ef833 Author: Thomas Huth Date: 2021-10-14 (Thu, 14 Oct 2021) Changed paths: M dtc Log Message: --- dtc: Update to version 1.6.1 The dtc submodule is currently pointing to non-release commit. It's nicer if submodules point to release versions instead and since dtc 1.6.1 is available now, let's update to that version. Message-Id: <20210827120901.150276-4-th...@redhat.com> Acked-by: Greg Kurz Acked-by: David Gibson Signed-off-by: Thomas Huth Commit: 82d88f834c8f7d33ad9529fca80924bc496fcb70 https://github.com/qemu/qemu/commit/82d88f834c8f7d33ad9529fca80924bc496fcb70 Author: Richard Henderson Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M MAINTAINERS M dtc M hw/s390x/ipl.c M target/s390x/sigp.c Log Message: --- Merge remote-tracking branch 'remotes/thuth/tags/pull-request-2021-10-15' into staging * Check kernel command line size on s390x * Simplification of one of the SIGP instructions on s390x * Cornelia stepping down as maintainer in some subsystems * Update the dtc submodule to a proper release version # gpg: Signature made Fri 15 Oct 2021 02:11:13 AM PDT # gpg:using RSA key
[Qemu-commits] [qemu/qemu] e287bf: net: Introduce NetClientInfo.check_peer_type()
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: e287bf7bb15ffd3728c000d9c5b52460ea17d713 https://github.com/qemu/qemu/commit/e287bf7bb15ffd3728c000d9c5b52460ea17d713 Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M hw/core/qdev-properties-system.c M include/net/net.h Log Message: --- net: Introduce NetClientInfo.check_peer_type() Some network backends (vhost-user and vhost-vdpa) work only with specific devices. At startup, they second guess what the command line option handling will do and error out if they think a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error messages ('-device floppy,netdev=foo' should complain about an unknown property, not about the wrong kind of network device being attached) and completely ignores hotplugging. Add a callback where backends can check compatibility with a device when it actually tries to attach, even on hotplug. Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-2-kw...@redhat.com> Reviewed-by: Damien Hedde Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: 5c485d51c4e2e8b3c78110a1a3f31f789c900d9d https://github.com/qemu/qemu/commit/5c485d51c4e2e8b3c78110a1a3f31f789c900d9d Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M net/vhost-user.c Log Message: --- net/vhost-user: Fix device compatibility check vhost-user works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error messages ('-device floppy,netdev=foo' should complain about an unknown property, not about the wrong kind of network device being attached) and completely ignores hotplugging. Drop the old checks and implement .check_peer_type() instead to fix this. As a nice side effect, it also removes one more dependency on the legacy QemuOpts infrastructure and even reduces the code size. Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-3-kw...@redhat.com> Reviewed-by: Damien Hedde Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: ee8a1c63d337a893fa915dd263dfdaa272e1a76a https://github.com/qemu/qemu/commit/ee8a1c63d337a893fa915dd263dfdaa272e1a76a Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M net/vhost-vdpa.c Log Message: --- net/vhost-vdpa: Fix device compatibility check vhost-vdpa works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error messages ('-device floppy,netdev=foo' should complain about an unknown property, not about the wrong kind of network device being attached) and completely ignores hotplugging. Drop the old checks and implement .check_peer_type() instead to fix this. As a nice side effect, it also removes one more dependency on the legacy QemuOpts infrastructure and even reduces the code size. Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-4-kw...@redhat.com> Reviewed-by: Damien Hedde Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: dbc8221f8cf3a3004fb6b4d0675f5852758b0388 https://github.com/qemu/qemu/commit/dbc8221f8cf3a3004fb6b4d0675f5852758b0388 Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M qom/object.c M qom/object_interfaces.c Log Message: --- qom: Reduce use of error_propagate() ERRP_GUARD() makes debugging easier by making sure that _abort still fails at the real origin of the error instead of error_propagate(). Signed-off-by: Kevin Wolf Message-Id: <20211008133442.141332-5-kw...@redhat.com> Reviewed-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: e2c8eb1454b6aee79077d6d9710ec92d66554e56 https://github.com/qemu/qemu/commit/e2c8eb1454b6aee79077d6d9710ec92d66554e56 Author: Kevin Wolf Date: 2021-10-15 (Fri, 15 Oct 2021) Changed paths: M tests/qemu-iotests/245 Log Message: --- iotests/245: Fix type for iothread property iothread is a string property, so None (= JSON null) is not a valid value for it. Pass the empty string instead to get the default iothread. Signed-off-by: Kevin Wolf Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211008133442.141332-6-kw...@redhat.com> Reviewed-by: Michael S. Tsirkin Tested-by: Peter Krempa Signed-off-by: Kevin Wolf Commit: af6400afb89f5eb3f66f841c8ee8c2f6754c8394
[Qemu-commits] [qemu/qemu] 52012b: configure: don't override the selected host test c...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 52012b0809cfb5e7be7ed8434b519c3a2e85c25f https://github.com/qemu/qemu/commit/52012b0809cfb5e7be7ed8434b519c3a2e85c25f Author: Alex Bennée Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M configure Log Message: --- configure: don't override the selected host test compiler if defined There are not many cases you would want to do this but one is if you want to use a test friendly compiler like gcc instead of a system compiler like clang. Either way we should honour the users choice if they have made it. Signed-off-by: Alex Bennée Cc: Warner Losh Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-2-alex.ben...@linaro.org> Commit: 4e5a2fc0b2d5e6b31035e41edac7467716874a57 https://github.com/qemu/qemu/commit/4e5a2fc0b2d5e6b31035e41edac7467716874a57 Author: Alex Bennée Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M tests/tcg/multiarch/sha1.c Log Message: --- tests/tcg/sha1: remove endian include This doesn't exist in BSD world and doesn't seem to be needed by either. Signed-off-by: Alex Bennée Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-3-alex.ben...@linaro.org> Commit: 99bc9f19b3ccfc7ca74a503c679fca629a115d41 https://github.com/qemu/qemu/commit/99bc9f19b3ccfc7ca74a503c679fca629a115d41 Author: Alex Bennée Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M tests/tcg/multiarch/Makefile.target R tests/tcg/multiarch/float_helpers.c A tests/tcg/multiarch/libs/float_helpers.c R tests/tcg/multiarch/linux-test.c A tests/tcg/multiarch/linux/linux-test.c M tests/tcg/x86_64/Makefile.target Log Message: --- tests/tcg: move some multiarch files and make conditional We had some messy code to filter out stuff we can't build. Lets junk that and simplify the logic by pushing some stuff into subdirs. In particular we move: float_helpers into libs - not a standalone test linux-test into linux - so we only build on Linux hosts This allows for at least some of the tests to be nominally usable by *BSD user builds. Signed-off-by: Alex Bennée Cc: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id: <20210917162332.3511179-4-alex.ben...@linaro.org> Commit: ffa3dd5159b4e878218b28af59976e91740e6a5f https://github.com/qemu/qemu/commit/ffa3dd5159b4e878218b28af59976e91740e6a5f Author: Alex Bennée Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M .gitlab-ci.d/container-cross.yml M tests/docker/Makefile.include M tests/docker/dockerfiles/debian-riscv64-cross.docker Log Message: --- tests/docker: promote debian-riscv64-cross to a full image To be able to cross build QEMU itself we need to include a few more libraries. These are only available in Debian's unstable ports repo for now so we need to base the riscv64 image on sid with the the minimal libs needed to build QEMU (glib/pixman). The result works but is not as clean as using build-dep to bring in more dependencies. However sid is by definition a shifting pile of sand and by keeping the list of libs minimal we reduce the chance of having an image we can't build. It's good enough for a basic cross build testing of TCG. Cc: "Daniel P. Berrangé" Signed-off-by: Richard Henderson Message-Id: <20210914185830.1378771-2-richard.hender...@linaro.org> [AJB: tweak allow_failure] Signed-off-by: Alex Bennée Message-Id: <20210917162332.3511179-5-alex.ben...@linaro.org> Commit: cb64ff0bb63cd2812e37ef49c2831ca1b70107bc https://github.com/qemu/qemu/commit/cb64ff0bb63cd2812e37ef49c2831ca1b70107bc Author: Richard Henderson Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M .gitlab-ci.d/crossbuilds.yml Log Message: --- gitlab: Add cross-riscv64-system, cross-riscv64-user Signed-off-by: Richard Henderson Message-Id: <20210914185830.1378771-3-richard.hender...@linaro.org> [AJB: add allow_failure] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Willian Rampazzo Message-Id: <20210917162332.3511179-6-alex.ben...@linaro.org> Commit: 2c8d6e5c6aea0ef993c93aa929aee0b19f569d33 https://github.com/qemu/qemu/commit/2c8d6e5c6aea0ef993c93aa929aee0b19f569d33 Author: Thomas Huth Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M .travis.yml Log Message: --- travis.yml: Remove the "Release tarball" job This is a leftover from the days when we were using Travis excessively, but since x86 jobs are not really usable there anymore, this job has likely never been used since many months. Let's simply remove it now. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Message-Id: <20210917094826.466047-1-th...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20210917162332.3511179-8-alex.ben...@linaro.org> Commit:
[Qemu-commits] [qemu/qemu] 7a7142: memory: Log access direction for invalid accesses
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 7a7142f0254464d16f0ddefd61237b40bfa97a47 https://github.com/qemu/qemu/commit/7a7142f0254464d16f0ddefd61237b40bfa97a47 Author: BALATON Zoltan Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M softmmu/memory.c Log Message: --- memory: Log access direction for invalid accesses In memory_region_access_valid() invalid accesses are logged to help debugging but the log message does not say if it was a read or write. Log that too to better identify the access causing the problem. Reviewed-by: David Hildenbrand Signed-off-by: BALATON Zoltan Message-Id: <20211011173616.f1de0756...@zero.eik.bme.hu> Signed-off-by: Richard Henderson Commit: c21751f394591f2444c62bfcb1124300849ab46a https://github.com/qemu/qemu/commit/c21751f394591f2444c62bfcb1124300849ab46a Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/arm/helper-a64.c Log Message: --- target/arm: Use MO_128 for 16 byte atomics Cc: qemu-...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 26b14640d933d703c175a314479bdd0b8c26fedd https://github.com/qemu/qemu/commit/26b14640d933d703c175a314479bdd0b8c26fedd Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/i386/tcg/mem_helper.c Log Message: --- target/i386: Use MO_128 for 16 byte atomics Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 68e33d869d2be9a765644782a0834fd87eec98f0 https://github.com/qemu/qemu/commit/68e33d869d2be9a765644782a0834fd87eec98f0 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/ppc/translate.c Log Message: --- target/ppc: Use MO_128 for 16 byte atomics Cc: qemu-...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 35c65de02998d23a26964c61b8c2e3b4235dcceb https://github.com/qemu/qemu/commit/35c65de02998d23a26964c61b8c2e3b4235dcceb Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/s390x/tcg/mem_helper.c Log Message: --- target/s390x: Use MO_128 for 16 byte atomics Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: f79e80899dbcd306ae2e8a43bc5e139b051f30f4 https://github.com/qemu/qemu/commit/f79e80899dbcd306ae2e8a43bc5e139b051f30f4 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/hexagon/cpu.h Log Message: --- target/hexagon: Implement cpu_mmu_index The function is trivial for user-only, but still must be present. Reviewed-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: f83bcecb1ffe25a18367409eaf4ba1453c835c48 https://github.com/qemu/qemu/commit/f83bcecb1ffe25a18367409eaf4ba1453c835c48 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M accel/tcg/cputlb.c A accel/tcg/ldst_common.c.inc M accel/tcg/user-exec.c M docs/devel/loads-stores.rst M include/exec/cpu_ldst.h Log Message: --- accel/tcg: Add cpu_{ld,st}*_mmu interfaces These functions are much closer to the softmmu helper functions, in that they take the complete MemOpIdx, and from that they may enforce required alignment. The previous cpu_ldst.h functions did not have alignment info, and so did not enforce it. Retain this by adding MO_UNALN to the MemOp that we create in calling the new functions. Note that we are not yet enforcing alignment for user-only, but we now have the information with which to do so. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Commit: b4c8f3d4dddcb6e547e1ba318f60ae9566743db1 https://github.com/qemu/qemu/commit/b4c8f3d4dddcb6e547e1ba318f60ae9566743db1 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M include/exec/cpu_ldst.h M include/tcg/tcg.h M target/arm/helper-a64.c M target/m68k/op_helper.c M target/ppc/mem_helper.c M target/s390x/tcg/mem_helper.c Log Message: --- accel/tcg: Move cpu_atomic decls to exec/cpu_ldst.h The previous placement in tcg/tcg.h was not logical. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 948f88661c68307162dc4241144d87dc7772ca8d https://github.com/qemu/qemu/commit/948f88661c68307162dc4241144d87dc7772ca8d Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/mips/tcg/msa_helper.c Log Message: --- target/mips: Use cpu_*_data_ra for msa load/store We should not have been using the helper_ret_* set of functions, as they are supposed to be private to tcg. Nor should we have been using
[Qemu-commits] [qemu/qemu] 7a7142: memory: Log access direction for invalid accesses
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 7a7142f0254464d16f0ddefd61237b40bfa97a47 https://github.com/qemu/qemu/commit/7a7142f0254464d16f0ddefd61237b40bfa97a47 Author: BALATON Zoltan Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M softmmu/memory.c Log Message: --- memory: Log access direction for invalid accesses In memory_region_access_valid() invalid accesses are logged to help debugging but the log message does not say if it was a read or write. Log that too to better identify the access causing the problem. Reviewed-by: David Hildenbrand Signed-off-by: BALATON Zoltan Message-Id: <20211011173616.f1de0756...@zero.eik.bme.hu> Signed-off-by: Richard Henderson Commit: c21751f394591f2444c62bfcb1124300849ab46a https://github.com/qemu/qemu/commit/c21751f394591f2444c62bfcb1124300849ab46a Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/arm/helper-a64.c Log Message: --- target/arm: Use MO_128 for 16 byte atomics Cc: qemu-...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 26b14640d933d703c175a314479bdd0b8c26fedd https://github.com/qemu/qemu/commit/26b14640d933d703c175a314479bdd0b8c26fedd Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/i386/tcg/mem_helper.c Log Message: --- target/i386: Use MO_128 for 16 byte atomics Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 68e33d869d2be9a765644782a0834fd87eec98f0 https://github.com/qemu/qemu/commit/68e33d869d2be9a765644782a0834fd87eec98f0 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/ppc/translate.c Log Message: --- target/ppc: Use MO_128 for 16 byte atomics Cc: qemu-...@nongnu.org Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 35c65de02998d23a26964c61b8c2e3b4235dcceb https://github.com/qemu/qemu/commit/35c65de02998d23a26964c61b8c2e3b4235dcceb Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/s390x/tcg/mem_helper.c Log Message: --- target/s390x: Use MO_128 for 16 byte atomics Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: f79e80899dbcd306ae2e8a43bc5e139b051f30f4 https://github.com/qemu/qemu/commit/f79e80899dbcd306ae2e8a43bc5e139b051f30f4 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/hexagon/cpu.h Log Message: --- target/hexagon: Implement cpu_mmu_index The function is trivial for user-only, but still must be present. Reviewed-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: f83bcecb1ffe25a18367409eaf4ba1453c835c48 https://github.com/qemu/qemu/commit/f83bcecb1ffe25a18367409eaf4ba1453c835c48 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M accel/tcg/cputlb.c A accel/tcg/ldst_common.c.inc M accel/tcg/user-exec.c M docs/devel/loads-stores.rst M include/exec/cpu_ldst.h Log Message: --- accel/tcg: Add cpu_{ld,st}*_mmu interfaces These functions are much closer to the softmmu helper functions, in that they take the complete MemOpIdx, and from that they may enforce required alignment. The previous cpu_ldst.h functions did not have alignment info, and so did not enforce it. Retain this by adding MO_UNALN to the MemOp that we create in calling the new functions. Note that we are not yet enforcing alignment for user-only, but we now have the information with which to do so. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Commit: b4c8f3d4dddcb6e547e1ba318f60ae9566743db1 https://github.com/qemu/qemu/commit/b4c8f3d4dddcb6e547e1ba318f60ae9566743db1 Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M include/exec/cpu_ldst.h M include/tcg/tcg.h M target/arm/helper-a64.c M target/m68k/op_helper.c M target/ppc/mem_helper.c M target/s390x/tcg/mem_helper.c Log Message: --- accel/tcg: Move cpu_atomic decls to exec/cpu_ldst.h The previous placement in tcg/tcg.h was not logical. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 948f88661c68307162dc4241144d87dc7772ca8d https://github.com/qemu/qemu/commit/948f88661c68307162dc4241144d87dc7772ca8d Author: Richard Henderson Date: 2021-10-13 (Wed, 13 Oct 2021) Changed paths: M target/mips/tcg/msa_helper.c Log Message: --- target/mips: Use cpu_*_data_ra for msa load/store We should not have been using the helper_ret_* set of functions, as they are supposed to be private to tcg. Nor should we have been using
[Qemu-commits] [qemu/qemu] a6297e: include/block.h: remove outdated comment
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: a6297e1ade6d9981c4a8d43eb426830b49a7913c https://github.com/qemu/qemu/commit/a6297e1ade6d9981c4a8d43eb426830b49a7913c Author: Emanuele Giuseppe Esposito Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M include/block/block.h Log Message: --- include/block.h: remove outdated comment There are a couple of errors in bdrv_drained_begin header comment: - block_job_pause does not exist anymore, it has been replaced with job_pause in b15de82867 - job_pause is automatically invoked as a .drained_begin callback (child_job_drained_begin) by the child_job BdrvChildClass struct in blockjob.c. So no additional pause should be required. Signed-off-by: Emanuele Giuseppe Esposito Message-Id: <20210903113800.59970-1-eespo...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf Commit: d1bbd965bd96028b0f5a8e3dc01b37f1f8ae4456 https://github.com/qemu/qemu/commit/d1bbd965bd96028b0f5a8e3dc01b37f1f8ae4456 Author: Philippe Mathieu-Daudé Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M storage-daemon/qemu-storage-daemon.c Log Message: --- qemu-storage-daemon: Only display FUSE help when FUSE is built-in When configuring QEMU with --disable-fuse, the qemu-storage-daemon still reports FUSE command line options in its help: $ qemu-storage-daemon -h Usage: qemu-storage-daemon [options] QEMU storage daemon --export [type=]fuse,id=,node-name=,mountpoint= [,growable=on|off][,writable=on|off] export the specified block node over FUSE Remove this help message when FUSE is disabled, to avoid: $ qemu-storage-daemon --export fuse qemu-storage-daemon: --export fuse: Invalid parameter 'fuse' Reported-by: Qing Wang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210816180442.2000642-1-phi...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Signed-off-by: Kevin Wolf Commit: 621d17378a40509757d5e03eb1c2f5305ff76df3 https://github.com/qemu/qemu/commit/621d17378a40509757d5e03eb1c2f5305ff76df3 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c M include/block/block.h Log Message: --- block: implement bdrv_new_open_driver_opts() Add version of bdrv_new_open_driver() that supports QDict options. We'll use it in further commit. Simply add one more argument to bdrv_new_open_driver() is worse, as there are too many invocations of bdrv_new_open_driver() to update then. Signed-off-by: Vladimir Sementsov-Ogievskiy Suggested-by: Kevin Wolf Message-Id: <20210920115538.264372-2-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf Commit: f053b7e8005d7f72c2a8e686c4779f75b0ae631f https://github.com/qemu/qemu/commit/f053b7e8005d7f72c2a8e686c4779f75b0ae631f Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c Log Message: --- block: bdrv_insert_node(): fix and improve error handling - use ERRP_GUARD(): function calls error_prepend(), so it must use ERRP_GUARD(), otherwise error_prepend() would not be called when passed errp is error_fatal - drop error propagation, handle return code instead - for symmetry, do error_prepend() for the second failure Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210920115538.264372-3-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf Commit: 96796fae6f22931d91223d086e9fa56d0f3e6720 https://github.com/qemu/qemu/commit/96796fae6f22931d91223d086e9fa56d0f3e6720 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c Log Message: --- block: bdrv_insert_node(): doc and style - options & flags is common pair for open-like functions, let's use it - add a comment that specifies use of @options Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210920115538.264372-4-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf Commit: b11c8739ae38166acac0669cee94b7e236ccb639 https://github.com/qemu/qemu/commit/b11c8739ae38166acac0669cee94b7e236ccb639 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c Log Message: --- block: bdrv_insert_node(): don't use bdrv_open() Use bdrv_new_open_driver_opts() instead of complicated bdrv_open(). Among other extra things bdrv_open() also check for white-listed formats, which we don't want for internal node creation: currently backup doesn't work when copy-before-write filter is not white-listed. As well block-stream doesn't work when copy-on-read is not white-listed. Fixes: 751cec7a261adaf1145dc7adf6de7c9c084e5a0b Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2004812 Reported-by: Yanan Fu Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id:
[Qemu-commits] [qemu/qemu] 6a2b0f: tests/docker: Remove fedora-i386-cross from DOCKER...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 6a2b0fd171082eae19f1da043cf53b5a5a7b9c6c https://github.com/qemu/qemu/commit/6a2b0fd171082eae19f1da043cf53b5a5a7b9c6c Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M tests/docker/Makefile.include Log Message: --- tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES The image was upgraded to a full image in ee381b7fe146. This makes it possible to use docker-test@image syntax with this container. Signed-off-by: Richard Henderson Reviewed-by: Daniel P. Berrangé Message-Id: <20210930163636.721311-2-richard.hender...@linaro.org> Commit: 08a13c4b247338329951238a6c47b94f70c387d2 https://github.com/qemu/qemu/commit/08a13c4b247338329951238a6c47b94f70c387d2 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M tests/docker/dockerfiles/fedora-i386-cross.docker Log Message: --- tests/docker: Fix fedora-i386-cross cross-compilation By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, we were still including the 64-bit packages. Install pcre-devel.i686 to fill a missing glib2 dependency. By using --extra-cflags instead of --cpu, we incorrectly use the wrong probing during meson. Signed-off-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Daniel P. Berrangé Message-Id: <20210930163636.721311-3-richard.hender...@linaro.org> Commit: db637f270b52f8c2a1c55e7e707532532295715c https://github.com/qemu/qemu/commit/db637f270b52f8c2a1c55e7e707532532295715c Author: Philipp Tomsich Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M include/tcg/tcg.h Log Message: --- tcg: add dup_const_tl wrapper dup_const always generates a uint64_t, which may exceed the size of a target_long (generating warnings with recent-enough compilers). To ensure that we can use dup_const both for 64bit and 32bit targets, this adds dup_const_tl, which either maps back to dup_const (for 64bit targets) or provides a similar implementation using 32bit constants. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philipp Tomsich Message-Id: <20211003214243.3813425-1-philipp.toms...@vrull.eu> Signed-off-by: Richard Henderson Commit: c433e298d99228e41a78d480a505cfcc8c9ea067 https://github.com/qemu/qemu/commit/c433e298d99228e41a78d480a505cfcc8c9ea067 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M accel/tcg/cputlb.c M accel/tcg/user-exec.c Log Message: --- accel/tcg: Drop signness in tracing in cputlb.c We are already inconsistent about whether or not MO_SIGN is set in trace_mem_get_info. Dropping it entirely allows some simplification. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 4b473e0c60d802bb69accab3177d350fc580e2a4 https://github.com/qemu/qemu/commit/4b473e0c60d802bb69accab3177d350fc580e2a4 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M include/exec/memop.h M target/arm/translate-a64.c M target/s390x/tcg/translate_vx.c.inc M tcg/aarch64/tcg-target.c.inc M tcg/arm/tcg-target.c.inc M tcg/i386/tcg-target.c.inc M tcg/mips/tcg-target.c.inc M tcg/ppc/tcg-target.c.inc M tcg/riscv/tcg-target.c.inc M tcg/s390/tcg-target.c.inc M tcg/sparc/tcg-target.c.inc M tcg/tcg-op.c Log Message: --- tcg: Expand MO_SIZE to 3 bits We have lacked expressive support for memory sizes larger than 64-bits for a while. Fixing that requires adjustment to several points where we used this for array indexing, and two places that develop -Wswitch warnings after the change. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 9002ffcb7264947d9a193567b457dea42f15c321 https://github.com/qemu/qemu/commit/9002ffcb7264947d9a193567b457dea42f15c321 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M accel/tcg/atomic_common.c.inc M accel/tcg/atomic_template.h M accel/tcg/cputlb.c M accel/tcg/user-exec.c M include/tcg/tcg.h M target/arm/helper-a64.c M target/arm/m_helper.c M target/i386/tcg/mem_helper.c M target/m68k/op_helper.c M target/mips/tcg/msa_helper.c M target/s390x/tcg/mem_helper.c M target/sparc/ldst_helper.c M tcg/aarch64/tcg-target.c.inc M tcg/arm/tcg-target.c.inc M tcg/i386/tcg-target.c.inc M tcg/mips/tcg-target.c.inc M tcg/optimize.c M tcg/ppc/tcg-target.c.inc M tcg/riscv/tcg-target.c.inc M tcg/s390/tcg-target.c.inc M tcg/sparc/tcg-target.c.inc M tcg/tcg-ldst.c.inc M tcg/tcg-op.c M tcg/tcg.c M tcg/tci.c Log Message: --- tcg: Rename TCGMemOpIdx to MemOpIdx We're about to move this out of tcg.h, so rename it as we did when moving MemOp. Reviewed-by:
[Qemu-commits] [qemu/qemu] c23b57: Hexagon (target/hexagon) probe the stores in a pac...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: c23b5764e79f3951e98160faf6e97284453c4056 https://github.com/qemu/qemu/commit/c23b5764e79f3951e98160faf6e97284453c4056 Author: Taylor Simpson Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/helper.h M target/hexagon/op_helper.c M target/hexagon/translate.c M tests/tcg/hexagon/Makefile.target A tests/tcg/hexagon/hex_sigsegv.c Log Message: --- Hexagon (target/hexagon) probe the stores in a packet at start of commit When a packet has 2 stores, either both commit or neither commit. At the beginning of gen_commit_packet, we check for multiple stores. If there are multiple stores, call a helper that will probe each of them before proceeding with the commit. Note that we don't call the probe helper for packets with only one store. Therefore, we call process_store_log before anything else involved in committing the packet. We also fix a typo in the comment in process_store_log. Test case added in tests/tcg/hexagon/hex_sigsegv.c Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson Message-Id: <1633036599-7637-1-git-send-email-tsimp...@quicinc.com> Commit: f844f745a81a8b8dc7f85eaa3fe6a3bb880afaff https://github.com/qemu/qemu/commit/f844f745a81a8b8dc7f85eaa3fe6a3bb880afaff Author: Philippe Mathieu-Daudé Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/macros.h Log Message: --- target/hexagon: Remove unused TCG temporary from predicated loads The gen_pred_cancel() function, introduced in commit a646e99cb90 (Hexagon macros) doesn't use the 'one' TCG temporary; remove it. Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003004750.3608983-2-f4...@amsat.org> Commit: 23803bbe524c34d5725508f169a0a23f652e6584 https://github.com/qemu/qemu/commit/23803bbe524c34d5725508f169a0a23f652e6584 Author: Philippe Mathieu-Daudé Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/gen_tcg.h M target/hexagon/gen_tcg_funcs.py M target/hexagon/genptr.c M target/hexagon/macros.h M target/hexagon/translate.c Log Message: --- target/hexagon: Use tcg_constant_* Replace uses of tcg_const_* with the allocate and free close together. Inspired-by: Richard Henderson Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003004750.3608983-3-f4...@amsat.org> Commit: ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def https://github.com/qemu/qemu/commit/ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def Author: Richard Henderson Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/gen_tcg.h M target/hexagon/gen_tcg_funcs.py M target/hexagon/genptr.c M target/hexagon/helper.h M target/hexagon/macros.h M target/hexagon/op_helper.c M target/hexagon/translate.c M tests/tcg/hexagon/Makefile.target A tests/tcg/hexagon/hex_sigsegv.c Log Message: --- Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20211006' into staging Change from Philippe - Use tcg_constant_* Change from Philippe - Remove unused TCG temp Change from Taylor - Probe the stores in a packet at start of commit # gpg: Signature made Wed 06 Oct 2021 08:44:13 AM PDT # gpg:using RSA key 7B0244FB12DE4422 # gpg: Good signature from "Taylor Simpson (Rock on) " [marginal] # gpg: WARNING: This key is not certified with sufficiently trusted signatures! # gpg: It is not certain that the signature belongs to the owner. # Primary key fingerprint: 3635 C788 CE62 B91F D4C5 9AB4 7B02 44FB 12DE 4422 * remotes/quic/tags/pull-hex-20211006: target/hexagon: Use tcg_constant_* target/hexagon: Remove unused TCG temporary from predicated loads Hexagon (target/hexagon) probe the stores in a packet at start of commit Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/6723ff639cac...ca61fa4b803e
[Qemu-commits] [qemu/qemu] a6297e: include/block.h: remove outdated comment
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: a6297e1ade6d9981c4a8d43eb426830b49a7913c https://github.com/qemu/qemu/commit/a6297e1ade6d9981c4a8d43eb426830b49a7913c Author: Emanuele Giuseppe Esposito Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M include/block/block.h Log Message: --- include/block.h: remove outdated comment There are a couple of errors in bdrv_drained_begin header comment: - block_job_pause does not exist anymore, it has been replaced with job_pause in b15de82867 - job_pause is automatically invoked as a .drained_begin callback (child_job_drained_begin) by the child_job BdrvChildClass struct in blockjob.c. So no additional pause should be required. Signed-off-by: Emanuele Giuseppe Esposito Message-Id: <20210903113800.59970-1-eespo...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf Commit: d1bbd965bd96028b0f5a8e3dc01b37f1f8ae4456 https://github.com/qemu/qemu/commit/d1bbd965bd96028b0f5a8e3dc01b37f1f8ae4456 Author: Philippe Mathieu-Daudé Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M storage-daemon/qemu-storage-daemon.c Log Message: --- qemu-storage-daemon: Only display FUSE help when FUSE is built-in When configuring QEMU with --disable-fuse, the qemu-storage-daemon still reports FUSE command line options in its help: $ qemu-storage-daemon -h Usage: qemu-storage-daemon [options] QEMU storage daemon --export [type=]fuse,id=,node-name=,mountpoint= [,growable=on|off][,writable=on|off] export the specified block node over FUSE Remove this help message when FUSE is disabled, to avoid: $ qemu-storage-daemon --export fuse qemu-storage-daemon: --export fuse: Invalid parameter 'fuse' Reported-by: Qing Wang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210816180442.2000642-1-phi...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz Signed-off-by: Kevin Wolf Commit: 621d17378a40509757d5e03eb1c2f5305ff76df3 https://github.com/qemu/qemu/commit/621d17378a40509757d5e03eb1c2f5305ff76df3 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c M include/block/block.h Log Message: --- block: implement bdrv_new_open_driver_opts() Add version of bdrv_new_open_driver() that supports QDict options. We'll use it in further commit. Simply add one more argument to bdrv_new_open_driver() is worse, as there are too many invocations of bdrv_new_open_driver() to update then. Signed-off-by: Vladimir Sementsov-Ogievskiy Suggested-by: Kevin Wolf Message-Id: <20210920115538.264372-2-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf Commit: f053b7e8005d7f72c2a8e686c4779f75b0ae631f https://github.com/qemu/qemu/commit/f053b7e8005d7f72c2a8e686c4779f75b0ae631f Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c Log Message: --- block: bdrv_insert_node(): fix and improve error handling - use ERRP_GUARD(): function calls error_prepend(), so it must use ERRP_GUARD(), otherwise error_prepend() would not be called when passed errp is error_fatal - drop error propagation, handle return code instead - for symmetry, do error_prepend() for the second failure Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210920115538.264372-3-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf Commit: 96796fae6f22931d91223d086e9fa56d0f3e6720 https://github.com/qemu/qemu/commit/96796fae6f22931d91223d086e9fa56d0f3e6720 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c Log Message: --- block: bdrv_insert_node(): doc and style - options & flags is common pair for open-like functions, let's use it - add a comment that specifies use of @options Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210920115538.264372-4-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf Commit: b11c8739ae38166acac0669cee94b7e236ccb639 https://github.com/qemu/qemu/commit/b11c8739ae38166acac0669cee94b7e236ccb639 Author: Vladimir Sementsov-Ogievskiy Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M block.c Log Message: --- block: bdrv_insert_node(): don't use bdrv_open() Use bdrv_new_open_driver_opts() instead of complicated bdrv_open(). Among other extra things bdrv_open() also check for white-listed formats, which we don't want for internal node creation: currently backup doesn't work when copy-before-write filter is not white-listed. As well block-stream doesn't work when copy-on-read is not white-listed. Fixes: 751cec7a261adaf1145dc7adf6de7c9c084e5a0b Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2004812 Reported-by: Yanan Fu Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id:
[Qemu-commits] [qemu/qemu] 6a2b0f: tests/docker: Remove fedora-i386-cross from DOCKER...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 6a2b0fd171082eae19f1da043cf53b5a5a7b9c6c https://github.com/qemu/qemu/commit/6a2b0fd171082eae19f1da043cf53b5a5a7b9c6c Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M tests/docker/Makefile.include Log Message: --- tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES The image was upgraded to a full image in ee381b7fe146. This makes it possible to use docker-test@image syntax with this container. Signed-off-by: Richard Henderson Reviewed-by: Daniel P. Berrangé Message-Id: <20210930163636.721311-2-richard.hender...@linaro.org> Commit: 08a13c4b247338329951238a6c47b94f70c387d2 https://github.com/qemu/qemu/commit/08a13c4b247338329951238a6c47b94f70c387d2 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M tests/docker/dockerfiles/fedora-i386-cross.docker Log Message: --- tests/docker: Fix fedora-i386-cross cross-compilation By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, we were still including the 64-bit packages. Install pcre-devel.i686 to fill a missing glib2 dependency. By using --extra-cflags instead of --cpu, we incorrectly use the wrong probing during meson. Signed-off-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Daniel P. Berrangé Message-Id: <20210930163636.721311-3-richard.hender...@linaro.org> Commit: db637f270b52f8c2a1c55e7e707532532295715c https://github.com/qemu/qemu/commit/db637f270b52f8c2a1c55e7e707532532295715c Author: Philipp Tomsich Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M include/tcg/tcg.h Log Message: --- tcg: add dup_const_tl wrapper dup_const always generates a uint64_t, which may exceed the size of a target_long (generating warnings with recent-enough compilers). To ensure that we can use dup_const both for 64bit and 32bit targets, this adds dup_const_tl, which either maps back to dup_const (for 64bit targets) or provides a similar implementation using 32bit constants. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philipp Tomsich Message-Id: <20211003214243.3813425-1-philipp.toms...@vrull.eu> Signed-off-by: Richard Henderson Commit: c433e298d99228e41a78d480a505cfcc8c9ea067 https://github.com/qemu/qemu/commit/c433e298d99228e41a78d480a505cfcc8c9ea067 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M accel/tcg/cputlb.c M accel/tcg/user-exec.c Log Message: --- accel/tcg: Drop signness in tracing in cputlb.c We are already inconsistent about whether or not MO_SIGN is set in trace_mem_get_info. Dropping it entirely allows some simplification. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 4b473e0c60d802bb69accab3177d350fc580e2a4 https://github.com/qemu/qemu/commit/4b473e0c60d802bb69accab3177d350fc580e2a4 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M include/exec/memop.h M target/arm/translate-a64.c M target/s390x/tcg/translate_vx.c.inc M tcg/aarch64/tcg-target.c.inc M tcg/arm/tcg-target.c.inc M tcg/i386/tcg-target.c.inc M tcg/mips/tcg-target.c.inc M tcg/ppc/tcg-target.c.inc M tcg/riscv/tcg-target.c.inc M tcg/s390/tcg-target.c.inc M tcg/sparc/tcg-target.c.inc M tcg/tcg-op.c Log Message: --- tcg: Expand MO_SIZE to 3 bits We have lacked expressive support for memory sizes larger than 64-bits for a while. Fixing that requires adjustment to several points where we used this for array indexing, and two places that develop -Wswitch warnings after the change. Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Commit: 9002ffcb7264947d9a193567b457dea42f15c321 https://github.com/qemu/qemu/commit/9002ffcb7264947d9a193567b457dea42f15c321 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M accel/tcg/atomic_common.c.inc M accel/tcg/atomic_template.h M accel/tcg/cputlb.c M accel/tcg/user-exec.c M include/tcg/tcg.h M target/arm/helper-a64.c M target/arm/m_helper.c M target/i386/tcg/mem_helper.c M target/m68k/op_helper.c M target/mips/tcg/msa_helper.c M target/s390x/tcg/mem_helper.c M target/sparc/ldst_helper.c M tcg/aarch64/tcg-target.c.inc M tcg/arm/tcg-target.c.inc M tcg/i386/tcg-target.c.inc M tcg/mips/tcg-target.c.inc M tcg/optimize.c M tcg/ppc/tcg-target.c.inc M tcg/riscv/tcg-target.c.inc M tcg/s390/tcg-target.c.inc M tcg/sparc/tcg-target.c.inc M tcg/tcg-ldst.c.inc M tcg/tcg-op.c M tcg/tcg.c M tcg/tci.c Log Message: --- tcg: Rename TCGMemOpIdx to MemOpIdx We're about to move this out of tcg.h, so rename it as we did when moving MemOp. Reviewed-by:
[Qemu-commits] [qemu/qemu] c23b57: Hexagon (target/hexagon) probe the stores in a pac...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: c23b5764e79f3951e98160faf6e97284453c4056 https://github.com/qemu/qemu/commit/c23b5764e79f3951e98160faf6e97284453c4056 Author: Taylor Simpson Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/helper.h M target/hexagon/op_helper.c M target/hexagon/translate.c M tests/tcg/hexagon/Makefile.target A tests/tcg/hexagon/hex_sigsegv.c Log Message: --- Hexagon (target/hexagon) probe the stores in a packet at start of commit When a packet has 2 stores, either both commit or neither commit. At the beginning of gen_commit_packet, we check for multiple stores. If there are multiple stores, call a helper that will probe each of them before proceeding with the commit. Note that we don't call the probe helper for packets with only one store. Therefore, we call process_store_log before anything else involved in committing the packet. We also fix a typo in the comment in process_store_log. Test case added in tests/tcg/hexagon/hex_sigsegv.c Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson Message-Id: <1633036599-7637-1-git-send-email-tsimp...@quicinc.com> Commit: f844f745a81a8b8dc7f85eaa3fe6a3bb880afaff https://github.com/qemu/qemu/commit/f844f745a81a8b8dc7f85eaa3fe6a3bb880afaff Author: Philippe Mathieu-Daudé Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/macros.h Log Message: --- target/hexagon: Remove unused TCG temporary from predicated loads The gen_pred_cancel() function, introduced in commit a646e99cb90 (Hexagon macros) doesn't use the 'one' TCG temporary; remove it. Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003004750.3608983-2-f4...@amsat.org> Commit: 23803bbe524c34d5725508f169a0a23f652e6584 https://github.com/qemu/qemu/commit/23803bbe524c34d5725508f169a0a23f652e6584 Author: Philippe Mathieu-Daudé Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/gen_tcg.h M target/hexagon/gen_tcg_funcs.py M target/hexagon/genptr.c M target/hexagon/macros.h M target/hexagon/translate.c Log Message: --- target/hexagon: Use tcg_constant_* Replace uses of tcg_const_* with the allocate and free close together. Inspired-by: Richard Henderson Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211003004750.3608983-3-f4...@amsat.org> Commit: ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def https://github.com/qemu/qemu/commit/ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def Author: Richard Henderson Date: 2021-10-06 (Wed, 06 Oct 2021) Changed paths: M target/hexagon/gen_tcg.h M target/hexagon/gen_tcg_funcs.py M target/hexagon/genptr.c M target/hexagon/helper.h M target/hexagon/macros.h M target/hexagon/op_helper.c M target/hexagon/translate.c M tests/tcg/hexagon/Makefile.target A tests/tcg/hexagon/hex_sigsegv.c Log Message: --- Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20211006' into staging Change from Philippe - Use tcg_constant_* Change from Philippe - Remove unused TCG temp Change from Taylor - Probe the stores in a packet at start of commit # gpg: Signature made Wed 06 Oct 2021 08:44:13 AM PDT # gpg:using RSA key 7B0244FB12DE4422 # gpg: Good signature from "Taylor Simpson (Rock on) " [marginal] # gpg: WARNING: This key is not certified with sufficiently trusted signatures! # gpg: It is not certain that the signature belongs to the owner. # Primary key fingerprint: 3635 C788 CE62 B91F D4C5 9AB4 7B02 44FB 12DE 4422 * remotes/quic/tags/pull-hex-20211006: target/hexagon: Use tcg_constant_* target/hexagon: Remove unused TCG temporary from predicated loads Hexagon (target/hexagon) probe the stores in a packet at start of commit Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/6723ff639cac...ca61fa4b803e
[Qemu-commits] [qemu/qemu] c5b4ee: target/riscv: Introduce temporary in gen_add_uw()
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: c5b4ee5bb799685e1c5a4a30ab40013a984daded https://github.com/qemu/qemu/commit/c5b4ee5bb799685e1c5a4a30ab40013a984daded Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: Introduce temporary in gen_add_uw() Following the recent changes in translate.c, gen_add_uw() causes failures on CF3 and SPEC2017 due to the reuse of arg1. Fix these regressions by introducing a temporary. Signed-off-by: Philipp Tomsich Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Reviewed-by: Richard Henderson Message-id: 20210911140016.834071-2-philipp.toms...@vrull.eu Fixes: 191d1dafae9c ("target/riscv: Add DisasExtend to gen_arith*") Signed-off-by: Alistair Francis Commit: e47fb6c1e96a4e50603c13b8408e0745a09cd867 https://github.com/qemu/qemu/commit/e47fb6c1e96a4e50603c13b8408e0745a09cd867 Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: fix clzw implementation to operate on arg1 The refactored gen_clzw() uses ret as its argument, instead of arg1. Fix it. Signed-off-by: Philipp Tomsich Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Reviewed-by: Richard Henderson Message-id: 20210911140016.834071-3-philipp.toms...@vrull.eu Fixes: 60903915050 ("target/riscv: Add DisasExtend to gen_unary") Signed-off-by: Alistair Francis Commit: 45d1749c1c32f7f44e02f267407cd6bca88fb84a https://github.com/qemu/qemu/commit/45d1749c1c32f7f44e02f267407cd6bca88fb84a Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: clwz must ignore high bits (use shift-left & changed logic) Assume clzw being executed on a register that is not sign-extended, such as for the following sequence that uses (1ULL << 63) | 392 as the operand to clzw: bseti a2, zero, 63 addia2, a2, 392 clzwa3, a2 The correct result of clzw would be 23, but the current implementation returns -32 (as it performs a 64bit clz, which results in 0 leading zero bits, and then subtracts 32). Fix this by changing the implementation to: 1. shift the original register up by 32 2. performs a target-length (64bit) clz 3. return 32 if no bits are set Marking this instruction as 'w-form' (i.e., setting ctx->w) would not correctly model the behaviour, as the instruction should not perform a zero-extensions on the input (after all, it is not a .uw instruction) and the result is always in the range 0..32 (so neither a sign-extension nor a zero-extension on the result will ever be needed). Consequently, we do not set ctx->w and mark the instruction as EXT_NONE. Signed-off-by: Philipp Tomsich Reviewed-by: LIU Zhiwei Message-id: 20210911140016.834071-4-philipp.toms...@vrull.eu Signed-off-by: Alistair Francis Commit: 878dd0e9ac18af657dcbdb598bb2eb1278606d3a https://github.com/qemu/qemu/commit/878dd0e9ac18af657dcbdb598bb2eb1278606d3a Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/cpu.c M target/riscv/cpu.h Log Message: --- target/riscv: Add x-zba, x-zbb, x-zbc and x-zbs properties The bitmanipulation ISA extensions will be ratified as individual small extension packages instead of a large B-extension. The first new instructions through the door (these have completed public review) are Zb[abcs]. This adds new 'x-zba', 'x-zbb', 'x-zbc' and 'x-zbs' properties for these in target/riscv/cpu.[ch]. Signed-off-by: Philipp Tomsich Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Message-id: 20210911140016.834071-5-philipp.toms...@vrull.eu Signed-off-by: Alistair Francis Commit: bb4dc158e084c3293b553c37f3ace7aeff6f https://github.com/qemu/qemu/commit/bb4dc158e084c3293b553c37f3ace7aeff6f Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn32.decode M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: Reassign instructions to the Zba-extension The following instructions are part of Zba: - add.uw (RV64 only) - sh[123]add (RV32 and RV64) - sh[123]add.uw (RV64-only) - slli.uw (RV64-only) Signed-off-by: Philipp Tomsich Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Acked-by: Bin Meng Message-id: 20210911140016.834071-6-philipp.toms...@vrull.eu Signed-off-by: Alistair Francis Commit: dd98a74034a4ae6a80162f2db42e67260875eb5e https://github.com/qemu/qemu/commit/dd98a74034a4ae6a80162f2db42e67260875eb5e Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn32.decode
[Qemu-commits] [qemu/qemu] c5b4ee: target/riscv: Introduce temporary in gen_add_uw()
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: c5b4ee5bb799685e1c5a4a30ab40013a984daded https://github.com/qemu/qemu/commit/c5b4ee5bb799685e1c5a4a30ab40013a984daded Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: Introduce temporary in gen_add_uw() Following the recent changes in translate.c, gen_add_uw() causes failures on CF3 and SPEC2017 due to the reuse of arg1. Fix these regressions by introducing a temporary. Signed-off-by: Philipp Tomsich Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Reviewed-by: Richard Henderson Message-id: 20210911140016.834071-2-philipp.toms...@vrull.eu Fixes: 191d1dafae9c ("target/riscv: Add DisasExtend to gen_arith*") Signed-off-by: Alistair Francis Commit: e47fb6c1e96a4e50603c13b8408e0745a09cd867 https://github.com/qemu/qemu/commit/e47fb6c1e96a4e50603c13b8408e0745a09cd867 Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: fix clzw implementation to operate on arg1 The refactored gen_clzw() uses ret as its argument, instead of arg1. Fix it. Signed-off-by: Philipp Tomsich Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Reviewed-by: Richard Henderson Message-id: 20210911140016.834071-3-philipp.toms...@vrull.eu Fixes: 60903915050 ("target/riscv: Add DisasExtend to gen_unary") Signed-off-by: Alistair Francis Commit: 45d1749c1c32f7f44e02f267407cd6bca88fb84a https://github.com/qemu/qemu/commit/45d1749c1c32f7f44e02f267407cd6bca88fb84a Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: clwz must ignore high bits (use shift-left & changed logic) Assume clzw being executed on a register that is not sign-extended, such as for the following sequence that uses (1ULL << 63) | 392 as the operand to clzw: bseti a2, zero, 63 addia2, a2, 392 clzwa3, a2 The correct result of clzw would be 23, but the current implementation returns -32 (as it performs a 64bit clz, which results in 0 leading zero bits, and then subtracts 32). Fix this by changing the implementation to: 1. shift the original register up by 32 2. performs a target-length (64bit) clz 3. return 32 if no bits are set Marking this instruction as 'w-form' (i.e., setting ctx->w) would not correctly model the behaviour, as the instruction should not perform a zero-extensions on the input (after all, it is not a .uw instruction) and the result is always in the range 0..32 (so neither a sign-extension nor a zero-extension on the result will ever be needed). Consequently, we do not set ctx->w and mark the instruction as EXT_NONE. Signed-off-by: Philipp Tomsich Reviewed-by: LIU Zhiwei Message-id: 20210911140016.834071-4-philipp.toms...@vrull.eu Signed-off-by: Alistair Francis Commit: 878dd0e9ac18af657dcbdb598bb2eb1278606d3a https://github.com/qemu/qemu/commit/878dd0e9ac18af657dcbdb598bb2eb1278606d3a Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/cpu.c M target/riscv/cpu.h Log Message: --- target/riscv: Add x-zba, x-zbb, x-zbc and x-zbs properties The bitmanipulation ISA extensions will be ratified as individual small extension packages instead of a large B-extension. The first new instructions through the door (these have completed public review) are Zb[abcs]. This adds new 'x-zba', 'x-zbb', 'x-zbc' and 'x-zbs' properties for these in target/riscv/cpu.[ch]. Signed-off-by: Philipp Tomsich Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by: Bin Meng Message-id: 20210911140016.834071-5-philipp.toms...@vrull.eu Signed-off-by: Alistair Francis Commit: bb4dc158e084c3293b553c37f3ace7aeff6f https://github.com/qemu/qemu/commit/bb4dc158e084c3293b553c37f3ace7aeff6f Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn32.decode M target/riscv/insn_trans/trans_rvb.c.inc Log Message: --- target/riscv: Reassign instructions to the Zba-extension The following instructions are part of Zba: - add.uw (RV64 only) - sh[123]add (RV32 and RV64) - sh[123]add.uw (RV64-only) - slli.uw (RV64-only) Signed-off-by: Philipp Tomsich Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Acked-by: Bin Meng Message-id: 20210911140016.834071-6-philipp.toms...@vrull.eu Signed-off-by: Alistair Francis Commit: dd98a74034a4ae6a80162f2db42e67260875eb5e https://github.com/qemu/qemu/commit/dd98a74034a4ae6a80162f2db42e67260875eb5e Author: Philipp Tomsich Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M target/riscv/insn32.decode
[Qemu-commits] [qemu/qemu] 8fc898: block/backup: avoid integer overflow of `max-workers`
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 8fc898ce0b3e7fea8c7c2a8d8977f2a9b77ecebf https://github.com/qemu/qemu/commit/8fc898ce0b3e7fea8c7c2a8d8977f2a9b77ecebf Author: Stefano Garzarella Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M block/backup.c Log Message: --- block/backup: avoid integer overflow of `max-workers` QAPI generates `struct BackupPerf` where `max-workers` value is stored in an `int64_t` variable. But block_copy_async(), and the underlying code, uses an `int` parameter. At the end that variable is used to initialize `max_busy_tasks` in block/aio_task.c causing the following assertion failure if a value greater than INT_MAX(2147483647) is used: ../block/aio_task.c:63: aio_task_pool_wait_one: Assertion `pool->busy_tasks > 0' failed. Let's check that `max-workers` doesn't exceed INT_MAX and print an error in that case. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2009310 Signed-off-by: Stefano Garzarella Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211005161157.282396-2-sgarz...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: a9515df4d66da34cbc2938e4c1f46015fc74ff93 https://github.com/qemu/qemu/commit/a9515df4d66da34cbc2938e4c1f46015fc74ff93 Author: Stefano Garzarella Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M block/aio_task.c Log Message: --- block/aio_task: assert `max_busy_tasks` is greater than 0 All code in block/aio_task.c expects `max_busy_tasks` to always be greater than 0. Assert this condition during the AioTaskPool creation where `max_busy_tasks` is set. Signed-off-by: Stefano Garzarella Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211005161157.282396-3-sgarz...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: d431131439f228626aedc6d211c73b2a3616d5e1 https://github.com/qemu/qemu/commit/d431131439f228626aedc6d211c73b2a3616d5e1 Author: Hanna Reitz Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M job.c Log Message: --- job: Context changes in job_completed_txn_abort() Finalizing the job may cause its AioContext to change. This is noted by job_exit(), which points at job_txn_apply() to take this fact into account. However, job_completed() does not necessarily invoke job_txn_apply() (through job_completed_txn_success()), but potentially also job_completed_txn_abort(). The latter stores the context in a local variable, and so always acquires the same context at its end that it has released in the beginning -- which may be a different context from the one that job_exit() releases at its end. If it is different, qemu aborts ("qemu_mutex_unlock_impl: Operation not permitted"). Drop the local @outer_ctx variable from job_completed_txn_abort(), and instead re-acquire the actual job's context at the end of the function, so job_exit() will release the same. Signed-off-by: Hanna Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20211006151940.214590-2-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: a3810da5cff152a2a1b2d25a8b8080f640e491b6 https://github.com/qemu/qemu/commit/a3810da5cff152a2a1b2d25a8b8080f640e491b6 Author: Hanna Reitz Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M block/mirror.c Log Message: --- mirror: Keep s->synced on error An error does not take us out of the READY phase, which is what s->synced signifies. It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->synced never meant that source and target are in sync, only that they were at some point (and at that point we transitioned into the READY phase). The tangible problem is that we transition to READY once we are in sync and s->synced is false. By resetting s->synced here, we will transition from READY to READY once the error is resolved (if the job keeps running), and that transition is not allowed. Signed-off-by: Hanna Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Message-Id: <20211006151940.214590-3-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: 447162242803bdc38bb198312e1d0a0675948424 https://github.com/qemu/qemu/commit/447162242803bdc38bb198312e1d0a0675948424 Author: Hanna Reitz Date: 2021-10-07 (Thu, 07 Oct 2021) Changed paths: M block/mirror.c Log Message: --- mirror: Drop s->synced As of HEAD^, there is no meaning to s->synced other than whether the job is READY or not. job_is_ready() gives us that information, too. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Hanna Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Message-Id: <20211006151940.214590-4-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit:
[Qemu-commits] [qemu/qemu] 1b680a: job: Context changes in job_completed_txn_abort()
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 1b680aee216d152d5f764244f0ba32f3a2ce75a8 https://github.com/qemu/qemu/commit/1b680aee216d152d5f764244f0ba32f3a2ce75a8 Author: Hanna Reitz Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M job.c Log Message: --- job: Context changes in job_completed_txn_abort() Finalizing the job may cause its AioContext to change. This is noted by job_exit(), which points at job_txn_apply() to take this fact into account. However, job_completed() does not necessarily invoke job_txn_apply() (through job_completed_txn_success()), but potentially also job_completed_txn_abort(). The latter stores the context in a local variable, and so always acquires the same context at its end that it has released in the beginning -- which may be a different context from the one that job_exit() releases at its end. If it is different, qemu aborts ("qemu_mutex_unlock_impl: Operation not permitted"). Drop the local @outer_ctx variable from job_completed_txn_abort(), and instead re-acquire the actual job's context at the end of the function, so job_exit() will release the same. Signed-off-by: Hanna Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210907124245.143492-2-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: 3df3fe8baf72a81a4bab8a1a599a9d12cc325bf5 https://github.com/qemu/qemu/commit/3df3fe8baf72a81a4bab8a1a599a9d12cc325bf5 Author: Hanna Reitz Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M block/mirror.c Log Message: --- mirror: Keep s->synced on error An error does not take us out of the READY phase, which is what s->synced signifies. It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->synced never meant that source and target are in sync, only that they were at some point (and at that point we transitioned into the READY phase). The tangible problem is that we transition to READY once we are in sync and s->synced is false. By resetting s->synced here, we will transition from READY to READY once the error is resolved (if the job keeps running), and that transition is not allowed. Signed-off-by: Hanna Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Message-Id: <20210907124245.143492-3-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: cda6701cfe4ba801ae65fcd1afd6412faefce89f https://github.com/qemu/qemu/commit/cda6701cfe4ba801ae65fcd1afd6412faefce89f Author: Hanna Reitz Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M block/mirror.c Log Message: --- mirror: Drop s->synced As of HEAD^, there is no meaning to s->synced other than whether the job is READY or not. job_is_ready() gives us that information, too. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Hanna Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Message-Id: <20210907124245.143492-4-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: ad7c9f5a9e853693f68583162624b15746a2eeb8 https://github.com/qemu/qemu/commit/ad7c9f5a9e853693f68583162624b15746a2eeb8 Author: Hanna Reitz Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M job.c Log Message: --- job: Force-cancel jobs in a failed transaction When a transaction is aborted, no result matters, and so all jobs within should be force-cancelled. Signed-off-by: Hanna Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210907124245.143492-5-hre...@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy Commit: 22f48f7eefdfa7a1cfb1e21c965f4646bd34d834 https://github.com/qemu/qemu/commit/22f48f7eefdfa7a1cfb1e21c965f4646bd34d834 Author: Hanna Reitz Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M block/replication.c M blockdev.c M include/qemu/job.h M job.c M tests/qemu-iotests/109.out M tests/qemu-iotests/tests/qsd-jobs.out M tests/unit/test-blockjob.c Log Message: --- job: @force parameter for job_cancel_sync() Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to terminate as soon as possible, so they should pass force=true. The replication block driver is the exception, specifically the active commit job it runs. As for job_cancel_sync_all(), all callers want it to force-cancel all jobs, because that is the point of it: To cancel all remaining jobs as quickly as possible (generally on process termination). So make it invoke job_cancel_sync() with force=true. This changes some iotest outputs, because quitting qemu while a mirror job is active will now lead to it being cancelled instead of
[Qemu-commits] [qemu/qemu] 1c0091: qapi/pylintrc: ignore 'consider-using-f-string' wa...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 1c00917409c9604cfc587045ba37395a48337dff https://github.com/qemu/qemu/commit/1c00917409c9604cfc587045ba37395a48337dff Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/pylintrc Log Message: --- qapi/pylintrc: ignore 'consider-using-f-string' warning Pylint 2.11.x adds this warning. We're not yet ready to pursue that conversion, so silence it for now. Signed-off-by: John Snow Message-Id: <20210930205716.1148693-2-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: 2adb988ed4ca31813d237c475a6a327ef16c5432 https://github.com/qemu/qemu/commit/2adb988ed4ca31813d237c475a6a327ef16c5432 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/gen.py Log Message: --- qapi/gen: use dict.items() to iterate over _modules New pylint warning. I could silence it, but this is the only occurrence in the entire tree, including everything in iotests/ and python/. Easier to just change this one instance. (The warning is emitted in cases where you are fetching the values anyway, so you may as well just take advantage of the iterator to avoid redundant lookups.) Signed-off-by: John Snow Message-Id: <20210930205716.1148693-3-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: 012336a152641b264a65176a388a7fb0118e1781 https://github.com/qemu/qemu/commit/012336a152641b264a65176a388a7fb0118e1781 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/parser.py M tests/qapi-schema/doc-bad-feature.err Log Message: --- qapi/parser: fix unused check_args_section arguments Pylint informs us we're not using these arguments. Oops, it's right. Correct the error message and remove the remaining unused parameter. Fix test output now that the error message is improved. Fixes: e151941d1b Signed-off-by: John Snow Message-Id: <20210930205716.1148693-4-js...@redhat.com> [Commit message formatting tweaked] Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: a9e2eb06ed061f37c3ba6ad52722eef20afd713a https://github.com/qemu/qemu/commit/a9e2eb06ed061f37c3ba6ad52722eef20afd713a Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M qapi/block-core.json M qga/qapi-schema.json M tests/qapi-schema/doc-good.json Log Message: --- qapi: Add spaces after symbol declaration for consistency Several QGA definitions omit a blank line after the symbol declaration. This works OK currently, but it's the only place where we do this. Adjust it for consistency. Future commits may wind up enforcing this formatting. Signed-off-by: John Snow Message-Id: <20210930205716.1148693-5-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: cd87c14cde5db42a2f13bfdbba1f3cbeb347a411 https://github.com/qemu/qemu/commit/cd87c14cde5db42a2f13bfdbba1f3cbeb347a411 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/parser.py M tests/qapi-schema/doc-empty-symbol.err Log Message: --- qapi/parser: remove FIXME comment from _append_body_line True, we do not check the validity of this symbol -- but we don't check the validity of definition names during parse, either -- that happens later, during the expr check. I don't want to introduce a dependency on expr.py:check_name_str here and introduce a cycle. Instead, rest assured that a documentation block is required for each definition. This requirement uses the names of each section to ensure that we fulfilled this requirement. e.g., let's say that block-core.json has a comment block for "Snapshot!Info" by accident. We'll see this error message: In file included from ../../qapi/block.json:8: ../../qapi/block-core.json: In struct 'SnapshotInfo': ../../qapi/block-core.json:38: documentation comment is for 'Snapshot!Info' That's a pretty decent error message. Now, let's say that we actually mangle it twice, identically: ../../qapi/block-core.json: In struct 'Snapshot!Info': ../../qapi/block-core.json:38: struct has an invalid name That's also pretty decent. If we forget to fix it in both places, we'll just be back to the first error. Therefore, let's just drop this FIXME and adjust the error message to not imply a more thorough check than is actually performed. Signed-off-by: John Snow Message-Id: <20210930205716.1148693-6-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: 1e20a77576dedf1489ce1cdb6abc4b34663637a4 https://github.com/qemu/qemu/commit/1e20a77576dedf1489ce1cdb6abc4b34663637a4 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/parser.py Log Message:
[Qemu-commits] [qemu/qemu] 7237c7: qapi/machine: Fix an incorrect comment of SMPConfi...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 7237c7ce772794d6be10b8b987fe4d02dfd76562 https://github.com/qemu/qemu/commit/7237c7ce772794d6be10b8b987fe4d02dfd76562 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M qapi/machine.json Log Message: --- qapi/machine: Fix an incorrect comment of SMPConfiguration The explanation of @cores should be "number of cores per die" but not "number of cores per thread". Let's fix it. Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse") Signed-off-by: Yanan Wang Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-2-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: c2511b1632e109130df524121dfb7d2413216d3c https://github.com/qemu/qemu/commit/c2511b1632e109130df524121dfb7d2413216d3c Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M docs/about/deprecated.rst M hw/core/machine.c M qemu-options.hx Log Message: --- machine: Deprecate "parameter=0" SMP configurations In the SMP configuration, we should either provide a topology parameter with a reasonable value (greater than zero) or just omit it and QEMU will compute the missing value. The users shouldn't provide a configuration with any parameter of it specified as zero (e.g. -smp 8,sockets=0) which could possibly cause unexpected results in the -smp parsing. So we deprecate this kind of configurations since 6.2 by adding the explicit sanity check. Signed-off-by: Yanan Wang Reviewed-by: Cornelia Huck Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-3-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: 5d8b5a505571b7927095015c805646f78fc56578 https://github.com/qemu/qemu/commit/5d8b5a505571b7927095015c805646f78fc56578 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M hw/core/machine.c M hw/i386/pc.c Log Message: --- machine: Minor refactor/fix for the smp parsers To pave the way for the functional improvement in later patches, make some refactor/cleanup for the smp parsers, including using local maxcpus instead of ms->smp.max_cpus in the calculation, defaulting dies to 0 initially like other members, cleanup the sanity check for dies. We actually also fix a hidden defect by avoiding directly using the provided *zero value* in the calculation, which could cause a segment fault (e.g. using dies=0 in the calculation). Signed-off-by: Yanan Wang Reviewed-by: Andrew Jones Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-4-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: 9a52b508061163df4dae05e708cd2a9cd790ad04 https://github.com/qemu/qemu/commit/9a52b508061163df4dae05e708cd2a9cd790ad04 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M hw/core/machine.c M hw/i386/pc.c Log Message: --- machine: Uniformly use maxcpus to calculate the omitted parameters We are currently using maxcpus to calculate the omitted sockets but using cpus to calculate the omitted cores/threads. This makes cmdlines like: -smp cpus=8,maxcpus=16 -smp cpus=8,cores=4,maxcpus=16 -smp cpus=8,threads=2,maxcpus=16 work fine but the ones like: -smp cpus=8,sockets=2,maxcpus=16 -smp cpus=8,sockets=2,cores=4,maxcpus=16 -smp cpus=8,sockets=2,threads=2,maxcpus=16 break the sanity check. Since we require for a valid config that the product of "sockets * cores * threads" should equal to the maxcpus, we should uniformly use maxcpus to calculate their omitted values. Also the if-branch of "cpus == 0 || sockets == 0" was split into two branches of "cpus == 0" and "sockets == 0" so that we can clearly read that we are parsing the configuration with a preference on cpus over sockets over cores over threads. Note: change in this patch won't affect any existing working cmdlines but improves consistency and allows more incomplete configs to be valid. Signed-off-by: Yanan Wang Reviewed-by: Andrew Jones Reviewed-by: Pankaj Gupta Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-5-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: 7d8c5a39628820f6927b8b70c8f54872f5d1a196 https://github.com/qemu/qemu/commit/7d8c5a39628820f6927b8b70c8f54872f5d1a196 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M hw/core/machine.c M hw/i386/pc.c M qemu-options.hx Log Message: --- machine: Set the value of cpus to match maxcpus if it's omitted Currently we directly calculate the omitted cpus based on the given incomplete collection of parameters. This makes some cmdlines like: -smp maxcpus=16 -smp sockets=2,maxcpus=16 -smp sockets=2,dies=2,maxcpus=16 -smp sockets=2,cores=4,maxcpus=16 not work. We should probably set the value of cpus to match maxcpus if it's omitted, which will make above
[Qemu-commits] [qemu/qemu] 1c0091: qapi/pylintrc: ignore 'consider-using-f-string' wa...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 1c00917409c9604cfc587045ba37395a48337dff https://github.com/qemu/qemu/commit/1c00917409c9604cfc587045ba37395a48337dff Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/pylintrc Log Message: --- qapi/pylintrc: ignore 'consider-using-f-string' warning Pylint 2.11.x adds this warning. We're not yet ready to pursue that conversion, so silence it for now. Signed-off-by: John Snow Message-Id: <20210930205716.1148693-2-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: 2adb988ed4ca31813d237c475a6a327ef16c5432 https://github.com/qemu/qemu/commit/2adb988ed4ca31813d237c475a6a327ef16c5432 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/gen.py Log Message: --- qapi/gen: use dict.items() to iterate over _modules New pylint warning. I could silence it, but this is the only occurrence in the entire tree, including everything in iotests/ and python/. Easier to just change this one instance. (The warning is emitted in cases where you are fetching the values anyway, so you may as well just take advantage of the iterator to avoid redundant lookups.) Signed-off-by: John Snow Message-Id: <20210930205716.1148693-3-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: 012336a152641b264a65176a388a7fb0118e1781 https://github.com/qemu/qemu/commit/012336a152641b264a65176a388a7fb0118e1781 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/parser.py M tests/qapi-schema/doc-bad-feature.err Log Message: --- qapi/parser: fix unused check_args_section arguments Pylint informs us we're not using these arguments. Oops, it's right. Correct the error message and remove the remaining unused parameter. Fix test output now that the error message is improved. Fixes: e151941d1b Signed-off-by: John Snow Message-Id: <20210930205716.1148693-4-js...@redhat.com> [Commit message formatting tweaked] Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: a9e2eb06ed061f37c3ba6ad52722eef20afd713a https://github.com/qemu/qemu/commit/a9e2eb06ed061f37c3ba6ad52722eef20afd713a Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M qapi/block-core.json M qga/qapi-schema.json M tests/qapi-schema/doc-good.json Log Message: --- qapi: Add spaces after symbol declaration for consistency Several QGA definitions omit a blank line after the symbol declaration. This works OK currently, but it's the only place where we do this. Adjust it for consistency. Future commits may wind up enforcing this formatting. Signed-off-by: John Snow Message-Id: <20210930205716.1148693-5-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: cd87c14cde5db42a2f13bfdbba1f3cbeb347a411 https://github.com/qemu/qemu/commit/cd87c14cde5db42a2f13bfdbba1f3cbeb347a411 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/parser.py M tests/qapi-schema/doc-empty-symbol.err Log Message: --- qapi/parser: remove FIXME comment from _append_body_line True, we do not check the validity of this symbol -- but we don't check the validity of definition names during parse, either -- that happens later, during the expr check. I don't want to introduce a dependency on expr.py:check_name_str here and introduce a cycle. Instead, rest assured that a documentation block is required for each definition. This requirement uses the names of each section to ensure that we fulfilled this requirement. e.g., let's say that block-core.json has a comment block for "Snapshot!Info" by accident. We'll see this error message: In file included from ../../qapi/block.json:8: ../../qapi/block-core.json: In struct 'SnapshotInfo': ../../qapi/block-core.json:38: documentation comment is for 'Snapshot!Info' That's a pretty decent error message. Now, let's say that we actually mangle it twice, identically: ../../qapi/block-core.json: In struct 'Snapshot!Info': ../../qapi/block-core.json:38: struct has an invalid name That's also pretty decent. If we forget to fix it in both places, we'll just be back to the first error. Therefore, let's just drop this FIXME and adjust the error message to not imply a more thorough check than is actually performed. Signed-off-by: John Snow Message-Id: <20210930205716.1148693-6-js...@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster Commit: 1e20a77576dedf1489ce1cdb6abc4b34663637a4 https://github.com/qemu/qemu/commit/1e20a77576dedf1489ce1cdb6abc4b34663637a4 Author: John Snow Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M scripts/qapi/parser.py Log Message:
[Qemu-commits] [qemu/qemu] 3830df: configure: Loosen GCC requirement from 7.5.0 to 7.4.0
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 3830df5f83b9b52d9496763ce1a50afb9231c998 https://github.com/qemu/qemu/commit/3830df5f83b9b52d9496763ce1a50afb9231c998 Author: nia Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M configure Log Message: --- configure: Loosen GCC requirement from 7.5.0 to 7.4.0 As discussed in issue 614, we're shipping GCC 7.4.0 as the system compiler in NetBSD 9, the most recent stable branch, and are still actively interested in QEMU on this platform. The differences between GCC 7.5.0 and 7.4.0 are trivial. Signed-off-by: Nia Alarie Reviewed-by: Richard Henderson Message-Id: Signed-off-by: Paolo Bonzini Commit: 75b98cb9f6456ccf194211beffcbf93b0a995fa4 https://github.com/qemu/qemu/commit/75b98cb9f6456ccf194211beffcbf93b0a995fa4 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M hw/virtio/virtio-mem-pci.c Log Message: --- virtio-mem-pci: Fix memory leak when creating MEMORY_DEVICE_SIZE_CHANGE event Apparently, we don't have to duplicate the string. Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size changes") Cc: qemu-sta...@nongnu.org Signed-off-by: David Hildenbrand Reviewed-by: Markus Armbruster Message-Id: <20210929162445.64060-2-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: d89dd28f0e29c9eae997b0cd645208454a2f3374 https://github.com/qemu/qemu/commit/d89dd28f0e29c9eae997b0cd645208454a2f3374 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M hw/virtio/virtio-mem-pci.c M qapi/machine.json Log Message: --- qapi: Include qom-path in MEMORY_DEVICE_SIZE_CHANGE qapi events As we might not always have a device id, it is impossible to always match MEMORY_DEVICE_SIZE_CHANGE events to an actual device. Let's include the qom-path in the event, which allows for reliable mapping of events to devices. Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size changes") Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand Message-Id: <20210929162445.64060-3-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 77ae2302ae167aa840d5a3aa489f7958db7c1426 https://github.com/qemu/qemu/commit/77ae2302ae167aa840d5a3aa489f7958db7c1426 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M monitor/monitor.c Log Message: --- monitor: Rate-limit MEMORY_DEVICE_SIZE_CHANGE qapi events per device We want to rate-limit MEMORY_DEVICE_SIZE_CHANGE events per device, otherwise we can lose some events for devices. We can now use the qom-path to reliably map an event to a device and make rate-limiting device-aware. This was noticed by starting a VM with two virtio-mem devices that each have a requested size > 0. The Linux guest will initialize both devices in parallel, resulting in losing MEMORY_DEVICE_SIZE_CHANGE events for one of the devices. Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size changes") Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand Message-Id: <20210929162445.64060-4-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 45e576c74533c70b38ba00f0c298dcdbc1635163 https://github.com/qemu/qemu/commit/45e576c74533c70b38ba00f0c298dcdbc1635163 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M hw/tpm/tpm_ppi.c Log Message: --- tpm: mark correct memory region range dirty when clearing RAM We might not start at the beginning of the memory region. Let's calculate the offset into the memory region via the difference in the host addresses. Acked-by: Stefan Berger Fixes: ffab1be70692 ("tpm: clear RAM when "memory overwrite" requested") Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc: Thomas Huth Cc: "Alex Bennée" Cc: Peter Xu Cc: Laurent Vivier Cc: Stefan Berger Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu Message-Id: <20210727082545.17934-2-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 602f8ea79ce39b7bd6d2e22c686ef05227e1876b https://github.com/qemu/qemu/commit/602f8ea79ce39b7bd6d2e22c686ef05227e1876b Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M softmmu/memory_mapping.c Log Message: --- softmmu/memory_mapping: never merge ranges accross memory regions Let's make sure to not merge when different memory regions are involved. Unlikely, but theoretically possible. Acked-by: Stefan Berger Reviewed-by: Peter Xu Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert
[Qemu-commits] [qemu/qemu] 3830df: configure: Loosen GCC requirement from 7.5.0 to 7.4.0
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 3830df5f83b9b52d9496763ce1a50afb9231c998 https://github.com/qemu/qemu/commit/3830df5f83b9b52d9496763ce1a50afb9231c998 Author: nia Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M configure Log Message: --- configure: Loosen GCC requirement from 7.5.0 to 7.4.0 As discussed in issue 614, we're shipping GCC 7.4.0 as the system compiler in NetBSD 9, the most recent stable branch, and are still actively interested in QEMU on this platform. The differences between GCC 7.5.0 and 7.4.0 are trivial. Signed-off-by: Nia Alarie Reviewed-by: Richard Henderson Message-Id: Signed-off-by: Paolo Bonzini Commit: 75b98cb9f6456ccf194211beffcbf93b0a995fa4 https://github.com/qemu/qemu/commit/75b98cb9f6456ccf194211beffcbf93b0a995fa4 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M hw/virtio/virtio-mem-pci.c Log Message: --- virtio-mem-pci: Fix memory leak when creating MEMORY_DEVICE_SIZE_CHANGE event Apparently, we don't have to duplicate the string. Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size changes") Cc: qemu-sta...@nongnu.org Signed-off-by: David Hildenbrand Reviewed-by: Markus Armbruster Message-Id: <20210929162445.64060-2-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: d89dd28f0e29c9eae997b0cd645208454a2f3374 https://github.com/qemu/qemu/commit/d89dd28f0e29c9eae997b0cd645208454a2f3374 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M hw/virtio/virtio-mem-pci.c M qapi/machine.json Log Message: --- qapi: Include qom-path in MEMORY_DEVICE_SIZE_CHANGE qapi events As we might not always have a device id, it is impossible to always match MEMORY_DEVICE_SIZE_CHANGE events to an actual device. Let's include the qom-path in the event, which allows for reliable mapping of events to devices. Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size changes") Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand Message-Id: <20210929162445.64060-3-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 77ae2302ae167aa840d5a3aa489f7958db7c1426 https://github.com/qemu/qemu/commit/77ae2302ae167aa840d5a3aa489f7958db7c1426 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M monitor/monitor.c Log Message: --- monitor: Rate-limit MEMORY_DEVICE_SIZE_CHANGE qapi events per device We want to rate-limit MEMORY_DEVICE_SIZE_CHANGE events per device, otherwise we can lose some events for devices. We can now use the qom-path to reliably map an event to a device and make rate-limiting device-aware. This was noticed by starting a VM with two virtio-mem devices that each have a requested size > 0. The Linux guest will initialize both devices in parallel, resulting in losing MEMORY_DEVICE_SIZE_CHANGE events for one of the devices. Fixes: 722a3c783ef4 ("virtio-pci: Send qapi events when the virtio-mem size changes") Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: David Hildenbrand Message-Id: <20210929162445.64060-4-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 45e576c74533c70b38ba00f0c298dcdbc1635163 https://github.com/qemu/qemu/commit/45e576c74533c70b38ba00f0c298dcdbc1635163 Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M hw/tpm/tpm_ppi.c Log Message: --- tpm: mark correct memory region range dirty when clearing RAM We might not start at the beginning of the memory region. Let's calculate the offset into the memory region via the difference in the host addresses. Acked-by: Stefan Berger Fixes: ffab1be70692 ("tpm: clear RAM when "memory overwrite" requested") Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc: Thomas Huth Cc: "Alex Bennée" Cc: Peter Xu Cc: Laurent Vivier Cc: Stefan Berger Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu Message-Id: <20210727082545.17934-2-da...@redhat.com> Signed-off-by: Paolo Bonzini Commit: 602f8ea79ce39b7bd6d2e22c686ef05227e1876b https://github.com/qemu/qemu/commit/602f8ea79ce39b7bd6d2e22c686ef05227e1876b Author: David Hildenbrand Date: 2021-10-02 (Sat, 02 Oct 2021) Changed paths: M softmmu/memory_mapping.c Log Message: --- softmmu/memory_mapping: never merge ranges accross memory regions Let's make sure to not merge when different memory regions are involved. Unlikely, but theoretically possible. Acked-by: Stefan Berger Reviewed-by: Peter Xu Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert
[Qemu-commits] [qemu/qemu] 7237c7: qapi/machine: Fix an incorrect comment of SMPConfi...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 7237c7ce772794d6be10b8b987fe4d02dfd76562 https://github.com/qemu/qemu/commit/7237c7ce772794d6be10b8b987fe4d02dfd76562 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M qapi/machine.json Log Message: --- qapi/machine: Fix an incorrect comment of SMPConfiguration The explanation of @cores should be "number of cores per die" but not "number of cores per thread". Let's fix it. Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse") Signed-off-by: Yanan Wang Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-2-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: c2511b1632e109130df524121dfb7d2413216d3c https://github.com/qemu/qemu/commit/c2511b1632e109130df524121dfb7d2413216d3c Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M docs/about/deprecated.rst M hw/core/machine.c M qemu-options.hx Log Message: --- machine: Deprecate "parameter=0" SMP configurations In the SMP configuration, we should either provide a topology parameter with a reasonable value (greater than zero) or just omit it and QEMU will compute the missing value. The users shouldn't provide a configuration with any parameter of it specified as zero (e.g. -smp 8,sockets=0) which could possibly cause unexpected results in the -smp parsing. So we deprecate this kind of configurations since 6.2 by adding the explicit sanity check. Signed-off-by: Yanan Wang Reviewed-by: Cornelia Huck Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-3-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: 5d8b5a505571b7927095015c805646f78fc56578 https://github.com/qemu/qemu/commit/5d8b5a505571b7927095015c805646f78fc56578 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M hw/core/machine.c M hw/i386/pc.c Log Message: --- machine: Minor refactor/fix for the smp parsers To pave the way for the functional improvement in later patches, make some refactor/cleanup for the smp parsers, including using local maxcpus instead of ms->smp.max_cpus in the calculation, defaulting dies to 0 initially like other members, cleanup the sanity check for dies. We actually also fix a hidden defect by avoiding directly using the provided *zero value* in the calculation, which could cause a segment fault (e.g. using dies=0 in the calculation). Signed-off-by: Yanan Wang Reviewed-by: Andrew Jones Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-4-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: 9a52b508061163df4dae05e708cd2a9cd790ad04 https://github.com/qemu/qemu/commit/9a52b508061163df4dae05e708cd2a9cd790ad04 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M hw/core/machine.c M hw/i386/pc.c Log Message: --- machine: Uniformly use maxcpus to calculate the omitted parameters We are currently using maxcpus to calculate the omitted sockets but using cpus to calculate the omitted cores/threads. This makes cmdlines like: -smp cpus=8,maxcpus=16 -smp cpus=8,cores=4,maxcpus=16 -smp cpus=8,threads=2,maxcpus=16 work fine but the ones like: -smp cpus=8,sockets=2,maxcpus=16 -smp cpus=8,sockets=2,cores=4,maxcpus=16 -smp cpus=8,sockets=2,threads=2,maxcpus=16 break the sanity check. Since we require for a valid config that the product of "sockets * cores * threads" should equal to the maxcpus, we should uniformly use maxcpus to calculate their omitted values. Also the if-branch of "cpus == 0 || sockets == 0" was split into two branches of "cpus == 0" and "sockets == 0" so that we can clearly read that we are parsing the configuration with a preference on cpus over sockets over cores over threads. Note: change in this patch won't affect any existing working cmdlines but improves consistency and allows more incomplete configs to be valid. Signed-off-by: Yanan Wang Reviewed-by: Andrew Jones Reviewed-by: Pankaj Gupta Reviewed-by: Daniel P. Berrangé Message-Id: <20210929025816.21076-5-wangyana...@huawei.com> Signed-off-by: Paolo Bonzini Commit: 7d8c5a39628820f6927b8b70c8f54872f5d1a196 https://github.com/qemu/qemu/commit/7d8c5a39628820f6927b8b70c8f54872f5d1a196 Author: Yanan Wang Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M hw/core/machine.c M hw/i386/pc.c M qemu-options.hx Log Message: --- machine: Set the value of cpus to match maxcpus if it's omitted Currently we directly calculate the omitted cpus based on the given incomplete collection of parameters. This makes some cmdlines like: -smp maxcpus=16 -smp sockets=2,maxcpus=16 -smp sockets=2,dies=2,maxcpus=16 -smp sockets=2,cores=4,maxcpus=16 not work. We should probably set the value of cpus to match maxcpus if it's omitted, which will make
[Qemu-commits] [qemu/qemu] db2af6: linux-user: Add infrastructure for a signal trampo...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: db2af69d6ba836a264878dbf2cf676d3c1fc46b4 https://github.com/qemu/qemu/commit/db2af69d6ba836a264878dbf2cf676d3c1fc46b4 Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/elfload.c M linux-user/signal-common.h M linux-user/signal.c Log Message: --- linux-user: Add infrastructure for a signal trampoline page Allocate a page to hold the signal trampoline(s). Invoke a guest-specific hook to fill in the contents of the page before marking it read-execute again. Reviewed-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: c70887a38212fd8ba0141d61502a33cda0a38d2d https://github.com/qemu/qemu/commit/c70887a38212fd8ba0141d61502a33cda0a38d2d Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/aarch64/signal.c M linux-user/aarch64/target_signal.h Log Message: --- linux-user/aarch64: Implement setup_sigtramp Create and record the rt signal trampoline. Use it when the guest does not use SA_RESTORER. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: eef9790007e4282b808558f93089ad0b204487f0 https://github.com/qemu/qemu/commit/eef9790007e4282b808558f93089ad0b204487f0 Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/arm/signal.c Log Message: --- linux-user/arm: Drop v1 signal frames Version 2 signal frames are used from 2.6.12 and since cbc14e6f286, we have set UNAME_MINIMUM_RELEASE to 2.6.32. Suggested-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: b807a1087ed864f6c37ccbf6ea416387f00a8b3c https://github.com/qemu/qemu/commit/b807a1087ed864f6c37ccbf6ea416387f00a8b3c Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/arm/signal.c Log Message: --- linux-user/arm: Drop "_v2" from symbols in signal.c Since we no longer support "v1", there's no need to distinguish "v2". Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-5-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: b5d66e0dd8dda3d58e58dafa425372d158bed3e8 https://github.com/qemu/qemu/commit/b5d66e0dd8dda3d58e58dafa425372d158bed3e8 Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/arm/signal.c M linux-user/arm/target_signal.h Log Message: --- linux-user/arm: Implement setup_sigtramp Mirror what the kernel does in arch/arm/kernel/signal.h, using the old sigframe struct in the rt sigframe struct. Update the trampoline code to match the kernel: this uses sp-relative accesses rather than pc-relative. Copy the code into frame->retcode from the trampoline page. This minimises the different cases wrt arm vs thumb vs fdpic. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210929130553.121567-6-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: dd55f1c8b217e14293f42d8531371b7c626c61dd https://github.com/qemu/qemu/commit/dd55f1c8b217e14293f42d8531371b7c626c61dd Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/alpha/signal.c M linux-user/alpha/target_signal.h Log Message: --- linux-user/alpha: Implement setup_sigtramp Create and record the two signal trampolines. Use them when the guest does not use ka_restorer. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-7-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: e281c2bafe22135c47caf7e1fa9db19647e49c3d https://github.com/qemu/qemu/commit/e281c2bafe22135c47caf7e1fa9db19647e49c3d Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/cris/signal.c M linux-user/cris/target_signal.h Log Message: --- linux-user/cris: Implement setup_sigtramp Split out setup_sigreturn so that we can continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: c8ef02b1acf0d78e909c6cbd38ed60ecc5ce52ff
[Qemu-commits] [qemu/qemu] ba858d: qemu-options: -chardev reconnect=seconds duplicate...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: ba858d1fadec417ab95c29938d2a0bb967d86114 https://github.com/qemu/qemu/commit/ba858d1fadec417ab95c29938d2a0bb967d86114 Author: Markus Armbruster Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M qemu-options.hx Log Message: --- qemu-options: -chardev reconnect=seconds duplicated in help, tidy up Fixes: 5dd1f02b4bc2f2c2ef3a2adfd8a412c8c8769085 Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Message-Id: <20210928071449.1416022-1-arm...@redhat.com> Signed-off-by: Laurent Vivier Commit: 553dc36b387d9c99740f5ae825465ffdd93685f2 https://github.com/qemu/qemu/commit/553dc36b387d9c99740f5ae825465ffdd93685f2 Author: Yanan Wang Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M qemu-options.hx Log Message: --- qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part. Obviously the later is right, let's fix the previous one. Signed-off-by: Yanan Wang Reviewed-by: Damien Hedde Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrew Jones Message-Id: <20210928121134.21064-2-wangyana...@huawei.com> Signed-off-by: Laurent Vivier Commit: 848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd https://github.com/qemu/qemu/commit/848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd Author: Yanan Wang Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M qemu-options.hx Log Message: --- qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2" There is one numa config example in qemu-options.hx currently using "-smp 2" and assuming that there will be 2 sockets and 2 cpus totally. However now the actual calculation logic of missing sockets and cores is not immutable and is considered liable to change. Although we will get maxcpus=2 finally based on current parser, it's always stable to specify it explicitly. So "-smp 2,sockets=2,maxcpus=2" will be optimal when we expect multiple sockets and 2 cpus totally. Signed-off-by: Yanan Wang Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrew Jones Message-Id: <20210928121134.21064-3-wangyana...@huawei.com> Signed-off-by: Laurent Vivier Commit: 196fb7ac7cb83f3b5547435f3b1d8b5bfaca35fb https://github.com/qemu/qemu/commit/196fb7ac7cb83f3b5547435f3b1d8b5bfaca35fb Author: Richard Henderson Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M target/sh4/translate.c Log Message: --- target/sh4: Use lookup_symbol in sh4_tr_disas_log The correct thing to do has been present but commented out since the initial commit of the sh4 translator. Fixes: fdf9b3e831e Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210929130316.121330-1-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: daf0db06308b55c518312abc39a4bf74413ac007 https://github.com/qemu/qemu/commit/daf0db06308b55c518312abc39a4bf74413ac007 Author: Philippe Mathieu-Daudé Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M hw/remote/proxy.c Log Message: --- hw/remote/proxy: Categorize Wireless devices as 'Network' ones QEMU doesn't distinct network devices per link layer (Ethernet, Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network devices. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jagannathan Raman Message-Id: <20210926201926.1690896-1-f4...@amsat.org> Signed-off-by: Laurent Vivier Commit: 9618c5badaa8eed25259cf095ff880efb939fbe7 https://github.com/qemu/qemu/commit/9618c5badaa8eed25259cf095ff880efb939fbe7 Author: Richard Henderson Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M hw/remote/proxy.c M qemu-options.hx M target/sh4/translate.c Log Message: --- Merge remote-tracking branch 'remotes/vivier/tags/trivial-branch-for-6.2-pull-request' into staging Pull request trivial-patches 2021104 # gpg: Signature made Mon 04 Oct 2021 01:30:22 AM PDT # gpg:using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C # gpg:issuer "laur...@vivier.eu" # gpg: Good signature from "Laurent Vivier " [full] # gpg: aka "Laurent Vivier " [full] # gpg: aka "Laurent Vivier (Red Hat) " [full] * remotes/vivier/tags/trivial-branch-for-6.2-pull-request: hw/remote/proxy: Categorize Wireless devices as 'Network' ones target/sh4: Use lookup_symbol in sh4_tr_disas_log qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2" qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/e7ab6584784d...9618c5badaa8
[Qemu-commits] [qemu/qemu] db2af6: linux-user: Add infrastructure for a signal trampo...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: db2af69d6ba836a264878dbf2cf676d3c1fc46b4 https://github.com/qemu/qemu/commit/db2af69d6ba836a264878dbf2cf676d3c1fc46b4 Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/elfload.c M linux-user/signal-common.h M linux-user/signal.c Log Message: --- linux-user: Add infrastructure for a signal trampoline page Allocate a page to hold the signal trampoline(s). Invoke a guest-specific hook to fill in the contents of the page before marking it read-execute again. Reviewed-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: c70887a38212fd8ba0141d61502a33cda0a38d2d https://github.com/qemu/qemu/commit/c70887a38212fd8ba0141d61502a33cda0a38d2d Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/aarch64/signal.c M linux-user/aarch64/target_signal.h Log Message: --- linux-user/aarch64: Implement setup_sigtramp Create and record the rt signal trampoline. Use it when the guest does not use SA_RESTORER. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-3-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: eef9790007e4282b808558f93089ad0b204487f0 https://github.com/qemu/qemu/commit/eef9790007e4282b808558f93089ad0b204487f0 Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/arm/signal.c Log Message: --- linux-user/arm: Drop v1 signal frames Version 2 signal frames are used from 2.6.12 and since cbc14e6f286, we have set UNAME_MINIMUM_RELEASE to 2.6.32. Suggested-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: b807a1087ed864f6c37ccbf6ea416387f00a8b3c https://github.com/qemu/qemu/commit/b807a1087ed864f6c37ccbf6ea416387f00a8b3c Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/arm/signal.c Log Message: --- linux-user/arm: Drop "_v2" from symbols in signal.c Since we no longer support "v1", there's no need to distinguish "v2". Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-5-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: b5d66e0dd8dda3d58e58dafa425372d158bed3e8 https://github.com/qemu/qemu/commit/b5d66e0dd8dda3d58e58dafa425372d158bed3e8 Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/arm/signal.c M linux-user/arm/target_signal.h Log Message: --- linux-user/arm: Implement setup_sigtramp Mirror what the kernel does in arch/arm/kernel/signal.h, using the old sigframe struct in the rt sigframe struct. Update the trampoline code to match the kernel: this uses sp-relative accesses rather than pc-relative. Copy the code into frame->retcode from the trampoline page. This minimises the different cases wrt arm vs thumb vs fdpic. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20210929130553.121567-6-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: dd55f1c8b217e14293f42d8531371b7c626c61dd https://github.com/qemu/qemu/commit/dd55f1c8b217e14293f42d8531371b7c626c61dd Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/alpha/signal.c M linux-user/alpha/target_signal.h Log Message: --- linux-user/alpha: Implement setup_sigtramp Create and record the two signal trampolines. Use them when the guest does not use ka_restorer. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-7-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: e281c2bafe22135c47caf7e1fa9db19647e49c3d https://github.com/qemu/qemu/commit/e281c2bafe22135c47caf7e1fa9db19647e49c3d Author: Richard Henderson Date: 2021-10-01 (Fri, 01 Oct 2021) Changed paths: M linux-user/cris/signal.c M linux-user/cris/target_signal.h Log Message: --- linux-user/cris: Implement setup_sigtramp Split out setup_sigreturn so that we can continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: c8ef02b1acf0d78e909c6cbd38ed60ecc5ce52ff
[Qemu-commits] [qemu/qemu] ba858d: qemu-options: -chardev reconnect=seconds duplicate...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: ba858d1fadec417ab95c29938d2a0bb967d86114 https://github.com/qemu/qemu/commit/ba858d1fadec417ab95c29938d2a0bb967d86114 Author: Markus Armbruster Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M qemu-options.hx Log Message: --- qemu-options: -chardev reconnect=seconds duplicated in help, tidy up Fixes: 5dd1f02b4bc2f2c2ef3a2adfd8a412c8c8769085 Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Message-Id: <20210928071449.1416022-1-arm...@redhat.com> Signed-off-by: Laurent Vivier Commit: 553dc36b387d9c99740f5ae825465ffdd93685f2 https://github.com/qemu/qemu/commit/553dc36b387d9c99740f5ae825465ffdd93685f2 Author: Yanan Wang Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M qemu-options.hx Log Message: --- qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part. Obviously the later is right, let's fix the previous one. Signed-off-by: Yanan Wang Reviewed-by: Damien Hedde Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrew Jones Message-Id: <20210928121134.21064-2-wangyana...@huawei.com> Signed-off-by: Laurent Vivier Commit: 848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd https://github.com/qemu/qemu/commit/848dd26928e2f4ceb63d7de06dd0b5f5b55bbddd Author: Yanan Wang Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M qemu-options.hx Log Message: --- qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2" There is one numa config example in qemu-options.hx currently using "-smp 2" and assuming that there will be 2 sockets and 2 cpus totally. However now the actual calculation logic of missing sockets and cores is not immutable and is considered liable to change. Although we will get maxcpus=2 finally based on current parser, it's always stable to specify it explicitly. So "-smp 2,sockets=2,maxcpus=2" will be optimal when we expect multiple sockets and 2 cpus totally. Signed-off-by: Yanan Wang Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrew Jones Message-Id: <20210928121134.21064-3-wangyana...@huawei.com> Signed-off-by: Laurent Vivier Commit: 196fb7ac7cb83f3b5547435f3b1d8b5bfaca35fb https://github.com/qemu/qemu/commit/196fb7ac7cb83f3b5547435f3b1d8b5bfaca35fb Author: Richard Henderson Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M target/sh4/translate.c Log Message: --- target/sh4: Use lookup_symbol in sh4_tr_disas_log The correct thing to do has been present but commented out since the initial commit of the sh4 translator. Fixes: fdf9b3e831e Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210929130316.121330-1-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier Commit: daf0db06308b55c518312abc39a4bf74413ac007 https://github.com/qemu/qemu/commit/daf0db06308b55c518312abc39a4bf74413ac007 Author: Philippe Mathieu-Daudé Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M hw/remote/proxy.c Log Message: --- hw/remote/proxy: Categorize Wireless devices as 'Network' ones QEMU doesn't distinct network devices per link layer (Ethernet, Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network devices. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jagannathan Raman Message-Id: <20210926201926.1690896-1-f4...@amsat.org> Signed-off-by: Laurent Vivier Commit: 9618c5badaa8eed25259cf095ff880efb939fbe7 https://github.com/qemu/qemu/commit/9618c5badaa8eed25259cf095ff880efb939fbe7 Author: Richard Henderson Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M hw/remote/proxy.c M qemu-options.hx M target/sh4/translate.c Log Message: --- Merge remote-tracking branch 'remotes/vivier/tags/trivial-branch-for-6.2-pull-request' into staging Pull request trivial-patches 2021104 # gpg: Signature made Mon 04 Oct 2021 01:30:22 AM PDT # gpg:using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C # gpg:issuer "laur...@vivier.eu" # gpg: Good signature from "Laurent Vivier " [full] # gpg: aka "Laurent Vivier " [full] # gpg: aka "Laurent Vivier (Red Hat) " [full] * remotes/vivier/tags/trivial-branch-for-6.2-pull-request: hw/remote/proxy: Categorize Wireless devices as 'Network' ones target/sh4: Use lookup_symbol in sh4_tr_disas_log qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2" qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/e7ab6584784d...9618c5badaa8
[Qemu-commits] [qemu/qemu] ab4dd2: hw/virtio: Acquire RCU read lock in virtqueue_pack...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: ab4dd2746c234f038206b3ccfe6bec1f19f98c24 https://github.com/qemu/qemu/commit/ab4dd2746c234f038206b3ccfe6bec1f19f98c24 Author: Philippe Mathieu-Daudé Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/virtio/virtio.c Log Message: --- hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all() vring_get_region_caches() must be called with the RCU read lock acquired. virtqueue_packed_drop_all() does not, and uses the 'caches' pointer. Fix that by using the RCU_READ_LOCK_GUARD() macro. Reported-by: Stefano Garzarella Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210906104318.1569967-3-phi...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefano Garzarella Commit: d6ed27bae717ceac9de0c53a31389143846b8465 https://github.com/qemu/qemu/commit/d6ed27bae717ceac9de0c53a31389143846b8465 Author: Philippe Mathieu-Daudé Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/virtio/virtio.c Log Message: --- hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees Both virtqueue_packed_get_avail_bytes() and virtqueue_split_get_avail_bytes() access the region cache, but their caller also does. Simplify by having virtqueue_get_avail_bytes calling both with RCU lock held, and passing the caches as argument. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210906104318.1569967-4-phi...@redhat.com> Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefano Garzarella Commit: e77b6374c0b8b6e410f0d74bcba0df98dfae4cce https://github.com/qemu/qemu/commit/e77b6374c0b8b6e410f0d74bcba0df98dfae4cce Author: Jason Wang Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M net/vhost-vdpa.c Log Message: --- vhost-vdpa: open device fd in net_init_vhost_vdpa() This patch switches to open device fd in net_init_vhost_vpda(). This is used to prepare for the multiqueue support. Reviewed-by: Stefano Garzarella Signed-off-by: Jason Wang Message-Id: <20210907090322.1756-2-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 67262edeb5c7bb99ed86304312bb7768e92f4cd7 https://github.com/qemu/qemu/commit/67262edeb5c7bb99ed86304312bb7768e92f4cd7 Author: Jason Wang Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/virtio/vhost-vdpa.c M include/hw/virtio/vhost-vdpa.h Log Message: --- vhost-vdpa: classify one time request Vhost-vdpa uses one device multiqueue queue (pairs) model. So we need to classify the one time request (e.g SET_OWNER) and make sure those request were only called once per device. This is used for multiqueue support. Signed-off-by: Jason Wang Message-Id: <20210907090322.1756-3-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 0f5bfa27e1c1df21b4c874cedf18d5ac812d81e2 https://github.com/qemu/qemu/commit/0f5bfa27e1c1df21b4c874cedf18d5ac812d81e2 Author: Jason Wang Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/virtio/vhost-vdpa.c Log Message: --- vhost-vdpa: prepare for the multiqueue support Unlike vhost-kernel, vhost-vdpa adapts a single device multiqueue model. So we need to simply use virtqueue index as the vhost virtqueue index. This is a must for multiqueue to work for vhost-vdpa. Signed-off-by: Jason Wang Message-Id: <20210907090322.1756-4-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 7e91ad3cafee23b780d12fcd17786617b7dbc7b8 https://github.com/qemu/qemu/commit/7e91ad3cafee23b780d12fcd17786617b7dbc7b8 Author: Jason Wang Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M net/vhost-vdpa.c Log Message: --- vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState * This patch switches to let net_vhost_vdpa_init() to return NetClientState *. This is used for the callers to allocate multiqueue NetClientState for multiqueue support. Signed-off-by: Jason Wang Message-Id: <20210907090322.1756-5-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 14155bf5e07ec61d8d79763d420dd152b7bea3a4 https://github.com/qemu/qemu/commit/14155bf5e07ec61d8d79763d420dd152b7bea3a4 Author: Jason Wang Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M include/net/net.h M net/net.c Log Message: --- net: introduce control client This patch introduces a boolean for the device has control queue which can accepts control command via network queue. The first user would be the control virtqueue support for vhost. Signed-off-by: Jason Wang Message-Id: <20210907090322.1756-6-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by:
[Qemu-commits] [qemu/qemu] 7f7c8d: i386: docs: Briefly describe KVM PV features
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 7f7c8d0ce3630849a4df3d627b11de354fcb3bb0 https://github.com/qemu/qemu/commit/7f7c8d0ce3630849a4df3d627b11de354fcb3bb0 Author: Vitaly Kuznetsov Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: A docs/system/i386/kvm-pv.rst M docs/system/target-i386.rst Log Message: --- i386: docs: Briefly describe KVM PV features KVM PV features don't seem to be documented anywhere, in particular, the fact that some of the features are enabled by default and some are not can only be figured out from the code. Signed-off-by: Vitaly Kuznetsov Message-Id: <20211004140445.624875-1-vkuzn...@redhat.com> Signed-off-by: Paolo Bonzini Commit: cff03145ed3cec5c7bd542ea2e6b4458439e0bb0 https://github.com/qemu/qemu/commit/cff03145ed3cec5c7bd542ea2e6b4458439e0bb0 Author: Dov Murik Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M target/i386/sev-stub.c M target/i386/sev.c M target/i386/sev_i386.h Log Message: --- sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot Add the sev_add_kernel_loader_hashes function to calculate the hashes of the kernel/initrd/cmdline and fill a designated OVMF encrypted hash table area. For this to work, OVMF must support an encrypted area to place the data which is advertised via a special GUID in the OVMF reset table. The hashes of each of the files is calculated (or the string in the case of the cmdline with trailing '\0' included). Each entry in the hashes table is GUID identified and since they're passed through the sev_encrypt_flash interface, the hashes will be accumulated by the AMD PSP measurement (SEV_LAUNCH_MEASURE). Co-developed-by: James Bottomley Signed-off-by: James Bottomley Signed-off-by: Dov Murik Reviewed-by: Daniel P. Berrangé Message-Id: <20210930054915.13252-2-dovmu...@linux.ibm.com> Signed-off-by: Paolo Bonzini Commit: c0c2d319d6714517cc4e0332edf99f2fccaa9442 https://github.com/qemu/qemu/commit/c0c2d319d6714517cc4e0332edf99f2fccaa9442 Author: Dov Murik Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/i386/x86.c Log Message: --- x86/sev: generate SEV kernel loader hashes in x86_load_linux If SEV is enabled and a kernel is passed via -kernel, pass the hashes of kernel/initrd/cmdline in an encrypted guest page to OVMF for SEV measured boot. Co-developed-by: James Bottomley Signed-off-by: James Bottomley Signed-off-by: Dov Murik Reviewed-by: Daniel P. Berrangé Message-Id: <20210930054915.13252-3-dovmu...@linux.ibm.com> Signed-off-by: Paolo Bonzini Commit: 93ddefbc3c909bb6c3b76086f1dfc8ad98dd3725 https://github.com/qemu/qemu/commit/93ddefbc3c909bb6c3b76086f1dfc8ad98dd3725 Author: Pedro Tôrres Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/misc/applesmc.c Log Message: --- hw/misc: applesmc: use host osk as default on macs When running on a Mac, QEMU is able to get the host OSK and use it as the default value for the AppleSMC device. The OSK query operation doesn't require administrator privileges and can be executed by any user on the system. This patch is based on open-source code from Apple, just like the implementation from VirtualBox. Apple: https://opensource.apple.com/source/IOKitUser/IOKitUser-647.6.13/pwr_mgt.subproj/IOPMLibPrivate.c https://opensource.apple.com/source/PowerManagement/PowerManagement-637.60.1/pmconfigd/PrivateLib.c VirtualBox: https://www.virtualbox.org/browser/vbox/trunk/src/VBox/Devices/EFI/DevSmc.cpp#L516 Signed-off-by: Pedro Tôrres Commit: 4dba27890844146d69e84916d024697947821655 https://github.com/qemu/qemu/commit/4dba27890844146d69e84916d024697947821655 Author: Paolo Bonzini Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M configure Log Message: --- configure, meson: move CPU_CFLAGS out of QEMU_CFLAGS Flags that choose the target architecture, such as -m32 on x86, affect all invocations of the compiler driver, for example including options such as --print-search-dirs. To ensure that they are treated as such, place them in the cross file in the [binaries] section instead of including them in QEMU_CFLAGS. Signed-off-by: Paolo Bonzini Commit: 3c158eba1e11e52dbd0e14fc8fd40ec80abca436 https://github.com/qemu/qemu/commit/3c158eba1e11e52dbd0e14fc8fd40ec80abca436 Author: Emanuele Giuseppe Esposito Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M migration/block-dirty-bitmap.c Log Message: --- migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread init_dirty_bitmap_migration assumes the iothread lock (BQL) to be held, but instead it isn't. Instead of adding the lock to qemu_savevm_state_setup(), follow the same pattern as the other ->save_setup callbacks and lock+unlock inside dirty_bitmap_save_setup(). Signed-off-by: Emanuele Giuseppe Esposito
[Qemu-commits] [qemu/qemu] ab4dd2: hw/virtio: Acquire RCU read lock in virtqueue_pack...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: ab4dd2746c234f038206b3ccfe6bec1f19f98c24 https://github.com/qemu/qemu/commit/ab4dd2746c234f038206b3ccfe6bec1f19f98c24 Author: Philippe Mathieu-Daudé Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/virtio/virtio.c Log Message: --- hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all() vring_get_region_caches() must be called with the RCU read lock acquired. virtqueue_packed_drop_all() does not, and uses the 'caches' pointer. Fix that by using the RCU_READ_LOCK_GUARD() macro. Reported-by: Stefano Garzarella Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210906104318.1569967-3-phi...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefano Garzarella Commit: d6ed27bae717ceac9de0c53a31389143846b8465 https://github.com/qemu/qemu/commit/d6ed27bae717ceac9de0c53a31389143846b8465 Author: Philippe Mathieu-Daudé Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/virtio/virtio.c Log Message: --- hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees Both virtqueue_packed_get_avail_bytes() and virtqueue_split_get_avail_bytes() access the region cache, but their caller also does. Simplify by having virtqueue_get_avail_bytes calling both with RCU lock held, and passing the caches as argument. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210906104318.1569967-4-phi...@redhat.com> Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefano Garzarella Commit: d6a9378f47515c6d70dbff4912c5740c98709880 https://github.com/qemu/qemu/commit/d6a9378f47515c6d70dbff4912c5740c98709880 Author: Stefano Garzarella Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/core/machine.c M hw/virtio/vhost-vsock.c M include/hw/virtio/vhost-vsock.h Log Message: --- vhost-vsock: fix migration issue when seqpacket is supported Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support") enabled the SEQPACKET feature bit. This commit is released with QEMU 6.1, so if we try to migrate a VM where the host kernel supports SEQPACKET but machine type version is less than 6.1, we get the following errors: Features 0x13002 unsupported. Allowed features: 0x17900 Failed to load virtio-vhost_vsock:virtio error while loading state for instance 0x0 of device ':00:05.0/virtio-vhost_vsock' load of migration failed: Operation not permitted Let's disable the feature bit for machine types < 6.1. We add a new OnOffAuto property for this, called `seqpacket`. When it is `auto` (default), QEMU behaves as before, trying to enable the feature, when it is `on` QEMU will fail if the backend (vhost-vsock kernel module) doesn't support it. Fixes: 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support") Cc: qemu-sta...@nongnu.org Reported-by: Jiang Wang Signed-off-by: Stefano Garzarella Message-Id: <20210921161642.206461-2-sgarz...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: 46ce017167d800c5d96104a88cfaed9949c4a3b6 https://github.com/qemu/qemu/commit/46ce017167d800c5d96104a88cfaed9949c4a3b6 Author: Stefano Garzarella Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/core/machine.c M hw/virtio/vhost-user-vsock.c M hw/virtio/vhost-vsock-common.c M hw/virtio/vhost-vsock.c M include/hw/virtio/vhost-vsock-common.h M include/hw/virtio/vhost-vsock.h Log Message: --- vhost-vsock: handle common features in vhost-vsock-common virtio-vsock features, like VIRTIO_VSOCK_F_SEQPACKET, can be handled by vhost-vsock-common parent class. In this way, we can reuse the same code for all virtio-vsock backends (i.e. vhost-vsock, vhost-user-vsock). Let's move `seqpacket` property to vhost-vsock-common class, add vhost_vsock_common_get_features() used by children, and disable `seqpacket` for vhost-user-vsock device for machine types < 6.2. The behavior of vhost-vsock device doesn't change; vhost-user-vsock device now supports `seqpacket` property. Signed-off-by: Stefano Garzarella Message-Id: <20210921161642.206461-3-sgarz...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Commit: c151fd87102cbb4082ac5dbcd704196b0495d28a https://github.com/qemu/qemu/commit/c151fd87102cbb4082ac5dbcd704196b0495d28a Author: Igor Mammedov Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/acpi/aml-build.c M include/hw/acpi/aml-build.h Log Message: --- acpi: add helper routines to initialize ACPI tables Patch introduces acpi_table_begin()/ acpi_table_end() API that hides pointer/offset arithmetic from user as opposed to build_header(), to prevent errors caused by it [1]. acpi_table_begin(): initializes table
[Qemu-commits] [qemu/qemu] 7f7c8d: i386: docs: Briefly describe KVM PV features
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 7f7c8d0ce3630849a4df3d627b11de354fcb3bb0 https://github.com/qemu/qemu/commit/7f7c8d0ce3630849a4df3d627b11de354fcb3bb0 Author: Vitaly Kuznetsov Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: A docs/system/i386/kvm-pv.rst M docs/system/target-i386.rst Log Message: --- i386: docs: Briefly describe KVM PV features KVM PV features don't seem to be documented anywhere, in particular, the fact that some of the features are enabled by default and some are not can only be figured out from the code. Signed-off-by: Vitaly Kuznetsov Message-Id: <20211004140445.624875-1-vkuzn...@redhat.com> Signed-off-by: Paolo Bonzini Commit: cff03145ed3cec5c7bd542ea2e6b4458439e0bb0 https://github.com/qemu/qemu/commit/cff03145ed3cec5c7bd542ea2e6b4458439e0bb0 Author: Dov Murik Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M target/i386/sev-stub.c M target/i386/sev.c M target/i386/sev_i386.h Log Message: --- sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot Add the sev_add_kernel_loader_hashes function to calculate the hashes of the kernel/initrd/cmdline and fill a designated OVMF encrypted hash table area. For this to work, OVMF must support an encrypted area to place the data which is advertised via a special GUID in the OVMF reset table. The hashes of each of the files is calculated (or the string in the case of the cmdline with trailing '\0' included). Each entry in the hashes table is GUID identified and since they're passed through the sev_encrypt_flash interface, the hashes will be accumulated by the AMD PSP measurement (SEV_LAUNCH_MEASURE). Co-developed-by: James Bottomley Signed-off-by: James Bottomley Signed-off-by: Dov Murik Reviewed-by: Daniel P. Berrangé Message-Id: <20210930054915.13252-2-dovmu...@linux.ibm.com> Signed-off-by: Paolo Bonzini Commit: c0c2d319d6714517cc4e0332edf99f2fccaa9442 https://github.com/qemu/qemu/commit/c0c2d319d6714517cc4e0332edf99f2fccaa9442 Author: Dov Murik Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/i386/x86.c Log Message: --- x86/sev: generate SEV kernel loader hashes in x86_load_linux If SEV is enabled and a kernel is passed via -kernel, pass the hashes of kernel/initrd/cmdline in an encrypted guest page to OVMF for SEV measured boot. Co-developed-by: James Bottomley Signed-off-by: James Bottomley Signed-off-by: Dov Murik Reviewed-by: Daniel P. Berrangé Message-Id: <20210930054915.13252-3-dovmu...@linux.ibm.com> Signed-off-by: Paolo Bonzini Commit: 93ddefbc3c909bb6c3b76086f1dfc8ad98dd3725 https://github.com/qemu/qemu/commit/93ddefbc3c909bb6c3b76086f1dfc8ad98dd3725 Author: Pedro Tôrres Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M hw/misc/applesmc.c Log Message: --- hw/misc: applesmc: use host osk as default on macs When running on a Mac, QEMU is able to get the host OSK and use it as the default value for the AppleSMC device. The OSK query operation doesn't require administrator privileges and can be executed by any user on the system. This patch is based on open-source code from Apple, just like the implementation from VirtualBox. Apple: https://opensource.apple.com/source/IOKitUser/IOKitUser-647.6.13/pwr_mgt.subproj/IOPMLibPrivate.c https://opensource.apple.com/source/PowerManagement/PowerManagement-637.60.1/pmconfigd/PrivateLib.c VirtualBox: https://www.virtualbox.org/browser/vbox/trunk/src/VBox/Devices/EFI/DevSmc.cpp#L516 Signed-off-by: Pedro Tôrres Commit: 4dba27890844146d69e84916d024697947821655 https://github.com/qemu/qemu/commit/4dba27890844146d69e84916d024697947821655 Author: Paolo Bonzini Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M configure Log Message: --- configure, meson: move CPU_CFLAGS out of QEMU_CFLAGS Flags that choose the target architecture, such as -m32 on x86, affect all invocations of the compiler driver, for example including options such as --print-search-dirs. To ensure that they are treated as such, place them in the cross file in the [binaries] section instead of including them in QEMU_CFLAGS. Signed-off-by: Paolo Bonzini Commit: 3c158eba1e11e52dbd0e14fc8fd40ec80abca436 https://github.com/qemu/qemu/commit/3c158eba1e11e52dbd0e14fc8fd40ec80abca436 Author: Emanuele Giuseppe Esposito Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M migration/block-dirty-bitmap.c Log Message: --- migration: block-dirty-bitmap: add missing qemu_mutex_lock_iothread init_dirty_bitmap_migration assumes the iothread lock (BQL) to be held, but instead it isn't. Instead of adding the lock to qemu_savevm_state_setup(), follow the same pattern as the other ->save_setup callbacks and lock+unlock inside dirty_bitmap_save_setup(). Signed-off-by: Emanuele Giuseppe Esposito
[Qemu-commits] [qemu/qemu] e3acc2: tests/docker/dockerfiles: Bump fedora-i386-cross t...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: e3acc2c1961cbe22ca474cd5da4163b7bbf7cea3 https://github.com/qemu/qemu/commit/e3acc2c1961cbe22ca474cd5da4163b7bbf7cea3 Author: Richard Henderson Date: 2021-10-05 (Tue, 05 Oct 2021) Changed paths: M tests/docker/dockerfiles/fedora-i386-cross.docker Log Message: --- tests/docker/dockerfiles: Bump fedora-i386-cross to fedora 34 For unknown and unrepeatable reasons, the cross-i386-tci test has started failing. "Fix" this by updating the container to use fedora 34. Add sysprof-capture-devel as a new dependency of glib2-devel that was not correctly spelled out in the rpm rules. Use dnf update Just In Case -- there are presently out-of-date packages in the upstream docker registry. Reviewed-by: Paolo Bonzini Message-Id: <20211005205846.153724-1-richard.hender...@linaro.org> Signed-off-by: Richard Henderson
[Qemu-commits] [qemu/qemu] a44da2: target/riscv: Update the ePMP CSR address
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: a44da25aa69a7a3588a33607a8067c87b3b5a68e https://github.com/qemu/qemu/commit/a44da25aa69a7a3588a33607a8067c87b3b5a68e Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M target/riscv/cpu.c M target/riscv/cpu_bits.h Log Message: --- target/riscv: Update the ePMP CSR address Update the ePMP CSRs to match the 0.9.3 ePMP spec https://github.com/riscv/riscv-tee/blob/61455747230a26002d741f64879dd78cc9689323/Smepmp/Smepmp.pdf Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Message-id: 28c908de60b9b04fa20e63d113885c98586053f3.1630543194.git.alistair.fran...@wdc.com Commit: 15732b8ed290460334ee58dd25939da733f362fd https://github.com/qemu/qemu/commit/15732b8ed290460334ee58dd25939da733f362fd Author: LIU Zhiwei Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M target/riscv/csr.c Log Message: --- target/riscv: Fix satp write These variables should be target_ulong. If truncated to int, the bool conditions they indicate will be wrong. As satp is very important for Linux, this bug almost fails every boot. Signed-off-by: LIU Zhiwei Reviewed-by: Bin Meng Reviewed-by: Alistair Francis Message-id: 20210901124539.222868-1-zhiwei_...@c-sky.com Signed-off-by: Alistair Francis Commit: 0f0b70eeecdd4e0f29efe28a7ffec01cbe5c43bf https://github.com/qemu/qemu/commit/0f0b70eeecdd4e0f29efe28a7ffec01cbe5c43bf Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M target/riscv/cpu.c Log Message: --- target/riscv: Expose interrupt pending bits as GPIO lines Expose the 12 interrupt pending bits in MIP as GPIO lines. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Bin Meng Tested-by: Bin Meng Message-id: 069d6162f0bc2f4a4f5a44e73f6442b11c703c53.1630301632.git.alistair.fran...@wdc.com Commit: a714b8aa029c2a6cc0b99a798f4f8b6d4282e711 https://github.com/qemu/qemu/commit/a714b8aa029c2a6cc0b99a798f4f8b6d4282e711 Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/intc/sifive_clint.c M include/hw/intc/sifive_clint.h Log Message: --- hw/intc: sifive_clint: Use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the timer and soft MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: LIU Zhiwei Message-id: 946e1ef5e268b24084c7ddad84c146de62a56736.1630301632.git.alistair.fran...@wdc.com Commit: e5cc6aaeb51dd0d80e1f5a6d6a6808d6355958aa https://github.com/qemu/qemu/commit/e5cc6aaeb51dd0d80e1f5a6d6a6808d6355958aa Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/intc/ibex_plic.c M hw/riscv/opentitan.c M include/hw/intc/ibex_plic.h Log Message: --- hw/intc: ibex_plic: Convert the PLIC to use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the external MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 0a76946981852f5bd15f0c37ab35b253371027a8.1630301632.git.alistair.fran...@wdc.com Commit: f436ecc3156dea7edce97e7c247e3667203f5c8b https://github.com/qemu/qemu/commit/f436ecc3156dea7edce97e7c247e3667203f5c8b Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/intc/sifive_plic.c M hw/riscv/microchip_pfsoc.c M hw/riscv/shakti_c.c M hw/riscv/sifive_e.c M hw/riscv/sifive_u.c M hw/riscv/virt.c M include/hw/intc/sifive_plic.h Log Message: --- hw/intc: sifive_plic: Convert the PLIC to use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the external MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Bin Meng Tested-by: Bin Meng Message-id: 0364190bfa935058a845c0fa1ecf650328840ad5.1630301632.git.alistair.fran...@wdc.com Commit: 57a3a6226529e60ef4eb5e11b577f2e532a72acc https://github.com/qemu/qemu/commit/57a3a6226529e60ef4eb5e11b577f2e532a72acc Author: Alistair Francis Date: 2021-09-21 (Tue, 21 Sep 2021) Changed paths: M hw/riscv/opentitan.c M hw/timer/ibex_timer.c M include/hw/timer/ibex_timer.h Log Message: --- hw/intc: ibex_timer: Convert the timer to use RISC-V CPU GPIO lines Instead of using riscv_cpu_update_mip() let's instead use the new RISC-V CPU GPIO lines to set the timer MIP bits. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id:
[Qemu-commits] [qemu/qemu] e97645: mac_via: update comment for VIA1B_vMystery bit
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: e976459b3b127838befaef57f1587770452a0827 https://github.com/qemu/qemu/commit/e976459b3b127838befaef57f1587770452a0827 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/misc/mac_via.c Log Message: --- mac_via: update comment for VIA1B_vMystery bit According to both Linux and NetBSD, port B bit 6 is used on the Quadra 800 to configure the GLUE logic in A/UX mode. Whilst the name VIA1B_vMystery isn't particularly descriptive, the patch leaves this to ensure that the constants in mac_via.c remain in sync with Linux's mac_via.h. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 39950b16ecc21bce3bbea3fddcdf1aaefa0d6cef https://github.com/qemu/qemu/commit/39950b16ecc21bce3bbea3fddcdf1aaefa0d6cef Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: move VIA1 IRQ from level 1 to level 6 On a Quadra 800 machine Linux sets via_alt_mapping to 1 and clears port B bit 6 to ensure that the VIA1 IRQ is delivered at level 6 rather than level 1. Even though QEMU doesn't yet emulate this behaviour, Linux still installs the VIA1 level 1 IRQ handler regardless of the value of via_alt_mapping which is why the kernel has been able to boot until now. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-3-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 91ff5e4dcd855c6f93b91ef8c5d43b18a1d080d0 https://github.com/qemu/qemu/commit/91ff5e4dcd855c6f93b91ef8c5d43b18a1d080d0 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: use GLUE IRQ numbers instead of IRQ level for GLUE IRQs In order to allow dynamic routing of IRQs to different IRQ levels on the CPU depending upon port B bit 6, use GLUE IRQ numbers and map them to the the corresponding CPU IRQ level accordingly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-4-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 291bc1809a0ec75f283717850003c08953d80e7c https://github.com/qemu/qemu/commit/291bc1809a0ec75f283717850003c08953d80e7c Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/misc/mac_via.c M hw/misc/trace-events M include/hw/misc/mac_via.h Log Message: --- mac_via: add GPIO for A/UX mode Add a new auxmode GPIO that is updated when port B bit 6 is changed indicating whether the hardware is configured for A/UX mode. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-5-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: a85d18aabdd4632bb0eeb496c97472746ba35d3c https://github.com/qemu/qemu/commit/a85d18aabdd4632bb0eeb496c97472746ba35d3c Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: wire up auxmode GPIO to GLUE This enables the GLUE logic to change its CPU level IRQ routing depending upon whether the hardware has been configured for A/UX mode. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-6-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: f7c6e12e24a736f7f3f0bf2c4e34a598e3274130 https://github.com/qemu/qemu/commit/f7c6e12e24a736f7f3f0bf2c4e34a598e3274130 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: route SONIC on-board Ethernet IRQ via nubus IRQ 9 in classic mode When the hardware is operating in classic mode the SONIC on-board Ethernet IRQ is routed to nubus IRQ 9 instead of directly to the CPU at level 3. This does not affect the framebuffer which although it exists in slot 9, has its own dedicated IRQ on the Quadra 800 hardware. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-7-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: c7710c1ebf0b316ac0ab517fa8ceaa2824904474 https://github.com/qemu/qemu/commit/c7710c1ebf0b316ac0ab517fa8ceaa2824904474 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: wire up remaining IRQs in classic mode Explicitly wire up the remaining IRQs in classic mode to enable the use of g_assert_not_reached() in the default case to detect any unexpected IRQs. Add a comment explaining the IRQ routing differences in A/UX mode based upon the comments in NetBSD (also
[Qemu-commits] [qemu/qemu] 82b6a3: aspeed: Add support for the fp5280g2-bmc board
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 82b6a3f64d6d1ed0d5c455489a9294b59c8de65f https://github.com/qemu/qemu/commit/82b6a3f64d6d1ed0d5c455489a9294b59c8de65f Author: John Wang Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M hw/arm/aspeed.c Log Message: --- aspeed: Add support for the fp5280g2-bmc board The fp5280g2-bmc is supported by OpenBMC, It's based on the following device tree https://github.com/openbmc/linux/blob/dev-5.10/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts Signed-off-by: John Wang Reviewed-by: Cédric Le Goater Message-Id: <20211014064548.934799-1-wangzhiqian...@inspur.com> Signed-off-by: Cédric Le Goater Commit: fc6642544eb86b520fed4e3b7792bd89e563de08 https://github.com/qemu/qemu/commit/fc6642544eb86b520fed4e3b7792bd89e563de08 Author: Cédric Le Goater Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- aspeed/smc: Use a container for the flash mmio address space Because AddressSpaces must not be sysbus-mapped, commit e9c568dbc225 ("hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias") introduced an alias for the flash mmio region. Using a container is cleaner. Cc: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Message-Id: <20211018132609.160008-5-...@kaod.org> Signed-off-by: Cédric Le Goater Commit: b12fa6118f4d838d19720ec6476a1666a1b43474 https://github.com/qemu/qemu/commit/b12fa6118f4d838d19720ec6476a1666a1b43474 Author: Cédric Le Goater Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M hw/sd/aspeed_sdhci.c M hw/sd/trace-events Log Message: --- speed/sdhci: Add trace events Signed-off-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Message-Id: <20211018132609.160008-6-...@kaod.org> Signed-off-by: Cédric Le Goater Commit: eb8f1d57bd754b19da73bb316e80bbaf9b66103a https://github.com/qemu/qemu/commit/eb8f1d57bd754b19da73bb316e80bbaf9b66103a Author: Richard Henderson Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M hw/arm/aspeed.c M hw/sd/aspeed_sdhci.c M hw/sd/trace-events M hw/ssi/aspeed_smc.c M include/hw/ssi/aspeed_smc.h Log Message: --- Merge remote-tracking branch 'remotes/clg/tags/pull-aspeed-20211022' into staging Aspeed patches : * New fp5280g2-bmc board (John) * Small cleanup in Aspeed SMC model (Cedric) # gpg: Signature made Fri 22 Oct 2021 12:55:18 AM PDT # gpg:using RSA key A0F66548F04895EBFE6B0B6051A343C7CFFBECA1 # gpg: Good signature from "Cédric Le Goater " [marginal] # gpg: WARNING: This key is not certified with sufficiently trusted signatures! # gpg: It is not certain that the signature belongs to the owner. # Primary key fingerprint: A0F6 6548 F048 95EB FE6B 0B60 51A3 43C7 CFFB ECA1 * remotes/clg/tags/pull-aspeed-20211022: speed/sdhci: Add trace events aspeed/smc: Use a container for the flash mmio address space aspeed: Add support for the fp5280g2-bmc board Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/1dafe7656a9c...eb8f1d57bd75
[Qemu-commits] [qemu/qemu] e97645: mac_via: update comment for VIA1B_vMystery bit
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: e976459b3b127838befaef57f1587770452a0827 https://github.com/qemu/qemu/commit/e976459b3b127838befaef57f1587770452a0827 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/misc/mac_via.c Log Message: --- mac_via: update comment for VIA1B_vMystery bit According to both Linux and NetBSD, port B bit 6 is used on the Quadra 800 to configure the GLUE logic in A/UX mode. Whilst the name VIA1B_vMystery isn't particularly descriptive, the patch leaves this to ensure that the constants in mac_via.c remain in sync with Linux's mac_via.h. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 39950b16ecc21bce3bbea3fddcdf1aaefa0d6cef https://github.com/qemu/qemu/commit/39950b16ecc21bce3bbea3fddcdf1aaefa0d6cef Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: move VIA1 IRQ from level 1 to level 6 On a Quadra 800 machine Linux sets via_alt_mapping to 1 and clears port B bit 6 to ensure that the VIA1 IRQ is delivered at level 6 rather than level 1. Even though QEMU doesn't yet emulate this behaviour, Linux still installs the VIA1 level 1 IRQ handler regardless of the value of via_alt_mapping which is why the kernel has been able to boot until now. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-3-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 91ff5e4dcd855c6f93b91ef8c5d43b18a1d080d0 https://github.com/qemu/qemu/commit/91ff5e4dcd855c6f93b91ef8c5d43b18a1d080d0 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: use GLUE IRQ numbers instead of IRQ level for GLUE IRQs In order to allow dynamic routing of IRQs to different IRQ levels on the CPU depending upon port B bit 6, use GLUE IRQ numbers and map them to the the corresponding CPU IRQ level accordingly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-4-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: 291bc1809a0ec75f283717850003c08953d80e7c https://github.com/qemu/qemu/commit/291bc1809a0ec75f283717850003c08953d80e7c Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/misc/mac_via.c M hw/misc/trace-events M include/hw/misc/mac_via.h Log Message: --- mac_via: add GPIO for A/UX mode Add a new auxmode GPIO that is updated when port B bit 6 is changed indicating whether the hardware is configured for A/UX mode. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-5-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: a85d18aabdd4632bb0eeb496c97472746ba35d3c https://github.com/qemu/qemu/commit/a85d18aabdd4632bb0eeb496c97472746ba35d3c Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: wire up auxmode GPIO to GLUE This enables the GLUE logic to change its CPU level IRQ routing depending upon whether the hardware has been configured for A/UX mode. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-6-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: f7c6e12e24a736f7f3f0bf2c4e34a598e3274130 https://github.com/qemu/qemu/commit/f7c6e12e24a736f7f3f0bf2c4e34a598e3274130 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: route SONIC on-board Ethernet IRQ via nubus IRQ 9 in classic mode When the hardware is operating in classic mode the SONIC on-board Ethernet IRQ is routed to nubus IRQ 9 instead of directly to the CPU at level 3. This does not affect the framebuffer which although it exists in slot 9, has its own dedicated IRQ on the Quadra 800 hardware. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20211020134131.4392-7-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier Commit: c7710c1ebf0b316ac0ab517fa8ceaa2824904474 https://github.com/qemu/qemu/commit/c7710c1ebf0b316ac0ab517fa8ceaa2824904474 Author: Mark Cave-Ayland Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M hw/m68k/q800.c Log Message: --- q800: wire up remaining IRQs in classic mode Explicitly wire up the remaining IRQs in classic mode to enable the use of g_assert_not_reached() in the default case to detect any unexpected IRQs. Add a comment explaining the IRQ routing differences in A/UX mode based upon the comments in NetBSD (also
[Qemu-commits] [qemu/qemu] 7bf00d: target/ppc: fix Hash64 MMU update of PTE bit R
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 7bf00dfb51566070960e0b7977e41abba96c130e https://github.com/qemu/qemu/commit/7bf00dfb51566070960e0b7977e41abba96c130e Author: Leandro Lupori Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M hw/ppc/spapr.c M hw/ppc/spapr_softmmu.c M target/ppc/mmu-hash64.c M target/ppc/mmu-hash64.h Log Message: --- target/ppc: fix Hash64 MMU update of PTE bit R When updating the R bit of a PTE, the Hash64 MMU was using a wrong byte offset, causing the first byte of the adjacent PTE to be corrupted. This caused a panic when booting FreeBSD, using the Hash MMU. Fixes: a2dd4e83e76b ("ppc/hash64: Rework R and C bit updates") Signed-off-by: Leandro Lupori Signed-off-by: Cédric Le Goater Commit: 50456a6794fbb8dc94a31eb9534e91c586da7add https://github.com/qemu/qemu/commit/50456a6794fbb8dc94a31eb9534e91c586da7add Author: Richard Henderson Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M hw/ppc/spapr.c M hw/ppc/spapr_softmmu.c M target/ppc/mmu-hash64.c M target/ppc/mmu-hash64.h Log Message: --- Merge tag 'pull-ppc-20211129' of https://github.com/legoater/qemu into staging ppc 6.2 queue: * Hash64 MMU fix for FreeBSD installer # gpg: Signature made Mon 29 Nov 2021 09:49:54 PM CET # gpg:using RSA key A0F66548F04895EBFE6B0B6051A343C7CFFBECA1 # gpg: Good signature from "Cédric Le Goater " [marginal] # gpg: WARNING: This key is not certified with sufficiently trusted signatures! # gpg: It is not certain that the signature belongs to the owner. # Primary key fingerprint: A0F6 6548 F048 95EB FE6B 0B60 51A3 43C7 CFFB ECA1 * tag 'pull-ppc-20211129' of https://github.com/legoater/qemu: target/ppc: fix Hash64 MMU update of PTE bit R Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/a0fd8a549224...50456a6794fb
[Qemu-commits] [qemu/qemu] 0a761c: linux-user: implement more loop ioctls
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 0a761ce30338526213f74dfe9900b9213d4bbb0b https://github.com/qemu/qemu/commit/0a761ce30338526213f74dfe9900b9213d4bbb0b Author: Andreas Schwab Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M linux-user/ioctls.h M linux-user/linux_loop.h M linux-user/syscall_defs.h M linux-user/syscall_types.h Log Message: --- linux-user: implement more loop ioctls LOOP_CONFIGURE is now used by losetup, and it cannot cope with ENOSYS. Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: Signed-off-by: Laurent Vivier Commit: 095c7737fbb8f25f7458290e4b5e5aa198f10a60 https://github.com/qemu/qemu/commit/095c7737fbb8f25f7458290e4b5e5aa198f10a60 Author: Richard Henderson Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M linux-user/ioctls.h M linux-user/linux_loop.h M linux-user/syscall_defs.h M linux-user/syscall_types.h Log Message: --- Merge tag 'linux-user-for-6.2-pull-request' of git://github.com/vivier/qemu into staging linux-user pull request 20211129 Fix losetup # gpg: Signature made Mon 29 Nov 2021 03:04:30 PM CET # gpg:using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C # gpg:issuer "laur...@vivier.eu" # gpg: Good signature from "Laurent Vivier " [full] # gpg: aka "Laurent Vivier " [full] # gpg: aka "Laurent Vivier (Red Hat) " [full] * tag 'linux-user-for-6.2-pull-request' of git://github.com/vivier/qemu: linux-user: implement more loop ioctls Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/b1641c50975c...095c7737fbb8
[Qemu-commits] [qemu/qemu] 48e140: accel/tcg: introduce CF_NOIRQ
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 48e14066ac10581db4e69f75eda107cfdafa6022 https://github.com/qemu/qemu/commit/48e14066ac10581db4e69f75eda107cfdafa6022 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M include/exec/exec-all.h M include/exec/gen-icount.h Log Message: --- accel/tcg: introduce CF_NOIRQ Here we introduce a new compiler flag to disable the checking of exit request (icount_decr.u32). This is useful when we want to ensure the next block cannot be preempted by an asynchronous event. Suggested-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20211129140932.4115115-2-alex.ben...@linaro.org> Commit: aff0e204cb1f1c036a496c94c15f5dfafcd9b4b4 https://github.com/qemu/qemu/commit/aff0e204cb1f1c036a496c94c15f5dfafcd9b4b4 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M accel/tcg/cpu-exec.c M accel/tcg/translate-all.c M softmmu/physmem.c Log Message: --- accel/tcg: suppress IRQ check for special TBs When we set cpu->cflags_next_tb it is because we want to carefully control the execution of the next TB. Currently there is a race that causes the second stage of watchpoint handling to get ignored if an IRQ is processed before we finish executing the instruction that triggers the watchpoint. Use the new CF_NOIRQ facility to avoid the race. We also suppress IRQs when handling precise self modifying code to avoid unnecessary bouncing. Signed-off-by: Alex Bennée Cc: Pavel Dovgalyuk Fixes: https://gitlab.com/qemu-project/qemu/-/issues/245 Reviewed-by: Richard Henderson Message-Id: <20211129140932.4115115-3-alex.ben...@linaro.org> Commit: a7c6e562e6f3f4e009c5dfa4e44cbbe908c4bf05 https://github.com/qemu/qemu/commit/a7c6e562e6f3f4e009c5dfa4e44cbbe908c4bf05 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M tests/avocado/tcg_plugins.py Log Message: --- tests/avocado: fix tcg_plugin mem access count test When we cleaned up argument handling the test was missed. Fixes: 5ae589faad ("tests/plugins/mem: introduce "track" arg and make args not positional") Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211129140932.4115115-4-alex.ben...@linaro.org> Commit: 86a41ac7fd488ce084175a30d1e5fd92dc37596b https://github.com/qemu/qemu/commit/86a41ac7fd488ce084175a30d1e5fd92dc37596b Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M plugins/meson.build Log Message: --- plugins/meson.build: fix linker issue with weird paths Signed-off-by: Alex Bennée Tested-by: Stefan Weil Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712 Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211129140932.4115115-5-alex.ben...@linaro.org> Commit: a8e537fa4d61b29c5c0ab1395918ad63f7752b25 https://github.com/qemu/qemu/commit/a8e537fa4d61b29c5c0ab1395918ad63f7752b25 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M gdbstub.c Log Message: --- gdbstub: handle a potentially racing TaskState When dealing with multi-threaded userspace programs there is a race condition with the addition of cpu->opaque (aka TaskState). This is due to cpu_copy calling cpu_create which updates the global vCPU list. However the task state isn't set until later. This shouldn't be a problem because the new thread can't have executed anything yet but the gdbstub code does liberally iterate through the CPU list in various places. This sticking plaster ensure the not yet fully realized vCPU is given an pid of -1 which should be enough to ensure it doesn't show up anywhere else. In the longer term I think the code that manages the association between vCPUs and attached GDB processes could do with a clean-up and re-factor. Signed-off-by: Alex Bennée Tested-by: Richard Henderson Reviewed-by: Richard Henderson Cc: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/730 Message-Id: <20211129140932.4115115-6-alex.ben...@linaro.org> Commit: 40525be5cbe768b23b427c6535c0b11bda80c851 https://github.com/qemu/qemu/commit/40525be5cbe768b23b427c6535c0b11bda80c851 Author: Willian Rampazzo Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M MAINTAINERS Log Message: --- MAINTAINERS: Remove me as a reviewer for the build and test/avocado Remove me as a reviewer for the Build and test automation and the Integration Testing with the Avocado Framework and add Beraldo Leal. Signed-off-by: Willian Rampazzo Reviewed-by: Beraldo Leal Message-Id: <20211122191124.31620-1-willi...@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211129140932.4115115-7-alex.ben...@linaro.org> Commit:
[Qemu-commits] [qemu/qemu] 48e140: accel/tcg: introduce CF_NOIRQ
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 48e14066ac10581db4e69f75eda107cfdafa6022 https://github.com/qemu/qemu/commit/48e14066ac10581db4e69f75eda107cfdafa6022 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M include/exec/exec-all.h M include/exec/gen-icount.h Log Message: --- accel/tcg: introduce CF_NOIRQ Here we introduce a new compiler flag to disable the checking of exit request (icount_decr.u32). This is useful when we want to ensure the next block cannot be preempted by an asynchronous event. Suggested-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20211129140932.4115115-2-alex.ben...@linaro.org> Commit: aff0e204cb1f1c036a496c94c15f5dfafcd9b4b4 https://github.com/qemu/qemu/commit/aff0e204cb1f1c036a496c94c15f5dfafcd9b4b4 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M accel/tcg/cpu-exec.c M accel/tcg/translate-all.c M softmmu/physmem.c Log Message: --- accel/tcg: suppress IRQ check for special TBs When we set cpu->cflags_next_tb it is because we want to carefully control the execution of the next TB. Currently there is a race that causes the second stage of watchpoint handling to get ignored if an IRQ is processed before we finish executing the instruction that triggers the watchpoint. Use the new CF_NOIRQ facility to avoid the race. We also suppress IRQs when handling precise self modifying code to avoid unnecessary bouncing. Signed-off-by: Alex Bennée Cc: Pavel Dovgalyuk Fixes: https://gitlab.com/qemu-project/qemu/-/issues/245 Reviewed-by: Richard Henderson Message-Id: <20211129140932.4115115-3-alex.ben...@linaro.org> Commit: a7c6e562e6f3f4e009c5dfa4e44cbbe908c4bf05 https://github.com/qemu/qemu/commit/a7c6e562e6f3f4e009c5dfa4e44cbbe908c4bf05 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M tests/avocado/tcg_plugins.py Log Message: --- tests/avocado: fix tcg_plugin mem access count test When we cleaned up argument handling the test was missed. Fixes: 5ae589faad ("tests/plugins/mem: introduce "track" arg and make args not positional") Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211129140932.4115115-4-alex.ben...@linaro.org> Commit: 86a41ac7fd488ce084175a30d1e5fd92dc37596b https://github.com/qemu/qemu/commit/86a41ac7fd488ce084175a30d1e5fd92dc37596b Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M plugins/meson.build Log Message: --- plugins/meson.build: fix linker issue with weird paths Signed-off-by: Alex Bennée Tested-by: Stefan Weil Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712 Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211129140932.4115115-5-alex.ben...@linaro.org> Commit: a8e537fa4d61b29c5c0ab1395918ad63f7752b25 https://github.com/qemu/qemu/commit/a8e537fa4d61b29c5c0ab1395918ad63f7752b25 Author: Alex Bennée Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M gdbstub.c Log Message: --- gdbstub: handle a potentially racing TaskState When dealing with multi-threaded userspace programs there is a race condition with the addition of cpu->opaque (aka TaskState). This is due to cpu_copy calling cpu_create which updates the global vCPU list. However the task state isn't set until later. This shouldn't be a problem because the new thread can't have executed anything yet but the gdbstub code does liberally iterate through the CPU list in various places. This sticking plaster ensure the not yet fully realized vCPU is given an pid of -1 which should be enough to ensure it doesn't show up anywhere else. In the longer term I think the code that manages the association between vCPUs and attached GDB processes could do with a clean-up and re-factor. Signed-off-by: Alex Bennée Tested-by: Richard Henderson Reviewed-by: Richard Henderson Cc: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/730 Message-Id: <20211129140932.4115115-6-alex.ben...@linaro.org> Commit: 40525be5cbe768b23b427c6535c0b11bda80c851 https://github.com/qemu/qemu/commit/40525be5cbe768b23b427c6535c0b11bda80c851 Author: Willian Rampazzo Date: 2021-11-29 (Mon, 29 Nov 2021) Changed paths: M MAINTAINERS Log Message: --- MAINTAINERS: Remove me as a reviewer for the build and test/avocado Remove me as a reviewer for the Build and test automation and the Integration Testing with the Avocado Framework and add Beraldo Leal. Signed-off-by: Willian Rampazzo Reviewed-by: Beraldo Leal Message-Id: <20211122191124.31620-1-willi...@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211129140932.4115115-7-alex.ben...@linaro.org> Commit:
[Qemu-commits] [qemu/qemu] 24c4cd: MAINTAINERS: Change my email address
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 24c4cd1311a45fa8ecfcde2f7b7afe84eb17dfac https://github.com/qemu/qemu/commit/24c4cd1311a45fa8ecfcde2f7b7afe84eb17dfac Author: Eduardo Habkost Date: 2021-12-01 (Wed, 01 Dec 2021) Changed paths: M MAINTAINERS Log Message: --- MAINTAINERS: Change my email address The ehabk...@redhat.com email address will stop working on 2021-12-01, change it to my personal email address. Signed-off-by: Eduardo Habkost Message-Id: <20211129163053.2506734-1-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost Message-Id: <20211130204722.2732997-2-ehabk...@redhat.com> Signed-off-by: Richard Henderson Commit: 682aa69b1f4dd5f2905a94066fa4c853adc33251 https://github.com/qemu/qemu/commit/682aa69b1f4dd5f2905a94066fa4c853adc33251 Author: Richard Henderson Date: 2021-12-01 (Wed, 01 Dec 2021) Changed paths: M VERSION Log Message: --- Update version for v6.2.0-rc3 release Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/50456a6794fb...682aa69b1f4d
[Qemu-commits] [qemu/qemu] 24ade8: hw/mips/bootloader: Fix write_ulong()
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 24ade8c5decd092bde5e863bc542db45d924ae12 https://github.com/qemu/qemu/commit/24ade8c5decd092bde5e863bc542db45d924ae12 Author: Jiaxun Yang Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/mips/bootloader.c Log Message: --- hw/mips/bootloader: Fix write_ulong() bl_gen_write_ulong uses sd for both 32 and 64 bit CPU, while sd is illegal on 32 bit CPUs. Replace sd with sw on 32bit CPUs. Fixes: 3ebbf86128f ("hw/mips: Add a bootloader helper") Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211130211729.7116-2-jiaxun.y...@flygoat.com> Signed-off-by: Philippe Mathieu-Daudé Commit: d77c462bf25001cc2ae03824a547ed761cd0c5bc https://github.com/qemu/qemu/commit/d77c462bf25001cc2ae03824a547ed761cd0c5bc Author: Jiaxun Yang Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Fix load_elf() error detection load_elf() gives negative return in case of error, not zero. Fixes: 10e3f30ff73 ("hw/mips/boston: Allow loading elf kernel and dtb") Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211130211729.7116-3-jiaxun.y...@flygoat.com> Signed-off-by: Philippe Mathieu-Daudé Commit: ac5837e330ec33e2df2d83338713a5c4272c8cc8 https://github.com/qemu/qemu/commit/ac5837e330ec33e2df2d83338713a5c4272c8cc8 Author: Alex Bennée Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/display/vga-isa.c Log Message: --- Revert "vga: don't abort when adding a duplicate isa-vga device" This reverts commit 7852a77f598635a67a222b6c1463c8b46098aed2. The check is bogus as it ends up finding itself and falling over. Signed-off-by: Alex Bennée Resolves: https://gitlab.com/qemu-project/qemu/-/issues/733 Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211206095209.2332376-1-alex.ben...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Commit: 2f8eb086732ad1875003101f5324f01c47d7408c https://github.com/qemu/qemu/commit/2f8eb086732ad1875003101f5324f01c47d7408c Author: Richard Henderson Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/display/vga-isa.c M hw/mips/bootloader.c M hw/mips/boston.c Log Message: --- Merge tag 'mips-20211206' of https://github.com/philmd/qemu into staging MIPS fixes - Do not emit SD instruction on 32-bit CPU (Jiaxun Yang) - Correctly catch load_elf() errors on Boston board (Jiaxun Yang) - Revert bogus CLI fix for ISA VGA devices (Alex Bennée) # gpg: Signature made Mon 06 Dec 2021 03:03:24 AM PST # gpg:using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE # gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) " [full] * tag 'mips-20211206' of https://github.com/philmd/qemu: Revert "vga: don't abort when adding a duplicate isa-vga device" hw/mips/boston: Fix load_elf() error detection hw/mips/bootloader: Fix write_ulong() Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/99fc08366b06...2f8eb086732a
[Qemu-commits] [qemu/qemu] e7fa33: seabios: update submodule to 1.15.0
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: e7fa3377ccee50b0fd4596c06d2e62815e74328b https://github.com/qemu/qemu/commit/e7fa3377ccee50b0fd4596c06d2e62815e74328b Author: Gerd Hoffmann Date: 2021-12-03 (Fri, 03 Dec 2021) Changed paths: M roms/seabios Log Message: --- seabios: update submodule to 1.15.0 Update seabios to the final release. No code changes compared to the snapshot merged a few weeks ago. shortlog 64f37cc530f1..rel-1.15.0 - Kevin O'Connor (1): docs: Note v1.15.0 release Signed-off-by: Gerd Hoffmann Commit: 3bc90ac567f64fbe07b17b1174c85ec8a3e17d94 https://github.com/qemu/qemu/commit/3bc90ac567f64fbe07b17b1174c85ec8a3e17d94 Author: Gerd Hoffmann Date: 2021-12-03 (Fri, 03 Dec 2021) Changed paths: M pc-bios/bios-256k.bin M pc-bios/bios-microvm.bin M pc-bios/bios.bin M pc-bios/vgabios-ati.bin M pc-bios/vgabios-bochs-display.bin M pc-bios/vgabios-cirrus.bin M pc-bios/vgabios-qxl.bin M pc-bios/vgabios-ramfb.bin M pc-bios/vgabios-stdvga.bin M pc-bios/vgabios-virtio.bin M pc-bios/vgabios-vmware.bin M pc-bios/vgabios.bin Log Message: --- seabios: update binaries to 1.15.0 Signed-off-by: Gerd Hoffmann Commit: 99fc08366b06282614daeda989d2fde6ab8a707f https://github.com/qemu/qemu/commit/99fc08366b06282614daeda989d2fde6ab8a707f Author: Richard Henderson Date: 2021-12-03 (Fri, 03 Dec 2021) Changed paths: M pc-bios/bios-256k.bin M pc-bios/bios-microvm.bin M pc-bios/bios.bin M pc-bios/vgabios-ati.bin M pc-bios/vgabios-bochs-display.bin M pc-bios/vgabios-cirrus.bin M pc-bios/vgabios-qxl.bin M pc-bios/vgabios-ramfb.bin M pc-bios/vgabios-stdvga.bin M pc-bios/vgabios-virtio.bin M pc-bios/vgabios-vmware.bin M pc-bios/vgabios.bin M roms/seabios Log Message: --- Merge tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu into staging seabios: update from snapshot to final 1.15.0 release (no code changes). # gpg: Signature made Fri 03 Dec 2021 12:55:34 AM PST # gpg:using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138 # gpg: Good signature from "Gerd Hoffmann (work) " [full] # gpg: aka "Gerd Hoffmann " [full] # gpg: aka "Gerd Hoffmann (private) " [full] * tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu: seabios: update binaries to 1.15.0 seabios: update submodule to 1.15.0 Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/a69254a2b320...99fc08366b06
[Qemu-commits] [qemu/qemu] 24ade8: hw/mips/bootloader: Fix write_ulong()
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 24ade8c5decd092bde5e863bc542db45d924ae12 https://github.com/qemu/qemu/commit/24ade8c5decd092bde5e863bc542db45d924ae12 Author: Jiaxun Yang Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/mips/bootloader.c Log Message: --- hw/mips/bootloader: Fix write_ulong() bl_gen_write_ulong uses sd for both 32 and 64 bit CPU, while sd is illegal on 32 bit CPUs. Replace sd with sw on 32bit CPUs. Fixes: 3ebbf86128f ("hw/mips: Add a bootloader helper") Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211130211729.7116-2-jiaxun.y...@flygoat.com> Signed-off-by: Philippe Mathieu-Daudé Commit: d77c462bf25001cc2ae03824a547ed761cd0c5bc https://github.com/qemu/qemu/commit/d77c462bf25001cc2ae03824a547ed761cd0c5bc Author: Jiaxun Yang Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/mips/boston.c Log Message: --- hw/mips/boston: Fix load_elf() error detection load_elf() gives negative return in case of error, not zero. Fixes: 10e3f30ff73 ("hw/mips/boston: Allow loading elf kernel and dtb") Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211130211729.7116-3-jiaxun.y...@flygoat.com> Signed-off-by: Philippe Mathieu-Daudé Commit: ac5837e330ec33e2df2d83338713a5c4272c8cc8 https://github.com/qemu/qemu/commit/ac5837e330ec33e2df2d83338713a5c4272c8cc8 Author: Alex Bennée Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/display/vga-isa.c Log Message: --- Revert "vga: don't abort when adding a duplicate isa-vga device" This reverts commit 7852a77f598635a67a222b6c1463c8b46098aed2. The check is bogus as it ends up finding itself and falling over. Signed-off-by: Alex Bennée Resolves: https://gitlab.com/qemu-project/qemu/-/issues/733 Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211206095209.2332376-1-alex.ben...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Commit: 2f8eb086732ad1875003101f5324f01c47d7408c https://github.com/qemu/qemu/commit/2f8eb086732ad1875003101f5324f01c47d7408c Author: Richard Henderson Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/display/vga-isa.c M hw/mips/bootloader.c M hw/mips/boston.c Log Message: --- Merge tag 'mips-20211206' of https://github.com/philmd/qemu into staging MIPS fixes - Do not emit SD instruction on 32-bit CPU (Jiaxun Yang) - Correctly catch load_elf() errors on Boston board (Jiaxun Yang) - Revert bogus CLI fix for ISA VGA devices (Alex Bennée) # gpg: Signature made Mon 06 Dec 2021 03:03:24 AM PST # gpg:using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE # gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) " [full] * tag 'mips-20211206' of https://github.com/philmd/qemu: Revert "vga: don't abort when adding a duplicate isa-vga device" hw/mips/boston: Fix load_elf() error detection hw/mips/bootloader: Fix write_ulong() Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/99fc08366b06...2f8eb086732a
[Qemu-commits] [qemu/qemu] 5b8071: virtio-blk: Fix clean up of host notifiers for sin...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 5b807181c27a940a3a7ad1f221a2e76a132cbdc0 https://github.com/qemu/qemu/commit/5b807181c27a940a3a7ad1f221a2e76a132cbdc0 Author: Mark Mielke Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/block/dataplane/virtio-blk.c Log Message: --- virtio-blk: Fix clean up of host notifiers for single MR transaction. The code that introduced "virtio-blk: Configure all host notifiers in a single MR transaction" introduced a second loop variable to perform cleanup in second loop, but mistakenly still refers to the first loop variable within the second loop body. Fixes: d0267da61489 ("virtio-blk: Configure all host notifiers in a single MR transaction") Signed-off-by: Mark Mielke Message-id: CALm7yL08qarOu0dnQkTN+pa=bsrc92g31ypqqndeait4ylz...@mail.gmail.com Signed-off-by: Stefan Hajnoczi Commit: 7635eff97104242d618400e4b6746d0a5c97af82 https://github.com/qemu/qemu/commit/7635eff97104242d618400e4b6746d0a5c97af82 Author: Richard Henderson Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/block/dataplane/virtio-blk.c Log Message: --- Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging Pull request # gpg: Signature made Mon 06 Dec 2021 07:27:19 AM PST # gpg:using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8 # gpg: Good signature from "Stefan Hajnoczi " [full] # gpg: aka "Stefan Hajnoczi " [full] * tag 'block-pull-request' of https://gitlab.com/stefanha/qemu: virtio-blk: Fix clean up of host notifiers for single MR transaction. Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/2f8eb086732a...7635eff97104
[Qemu-commits] [qemu/qemu] 5b8071: virtio-blk: Fix clean up of host notifiers for sin...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 5b807181c27a940a3a7ad1f221a2e76a132cbdc0 https://github.com/qemu/qemu/commit/5b807181c27a940a3a7ad1f221a2e76a132cbdc0 Author: Mark Mielke Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/block/dataplane/virtio-blk.c Log Message: --- virtio-blk: Fix clean up of host notifiers for single MR transaction. The code that introduced "virtio-blk: Configure all host notifiers in a single MR transaction" introduced a second loop variable to perform cleanup in second loop, but mistakenly still refers to the first loop variable within the second loop body. Fixes: d0267da61489 ("virtio-blk: Configure all host notifiers in a single MR transaction") Signed-off-by: Mark Mielke Message-id: CALm7yL08qarOu0dnQkTN+pa=bsrc92g31ypqqndeait4ylz...@mail.gmail.com Signed-off-by: Stefan Hajnoczi Commit: 7635eff97104242d618400e4b6746d0a5c97af82 https://github.com/qemu/qemu/commit/7635eff97104242d618400e4b6746d0a5c97af82 Author: Richard Henderson Date: 2021-12-06 (Mon, 06 Dec 2021) Changed paths: M hw/block/dataplane/virtio-blk.c Log Message: --- Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging Pull request # gpg: Signature made Mon 06 Dec 2021 07:27:19 AM PST # gpg:using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8 # gpg: Good signature from "Stefan Hajnoczi " [full] # gpg: aka "Stefan Hajnoczi " [full] * tag 'block-pull-request' of https://gitlab.com/stefanha/qemu: virtio-blk: Fix clean up of host notifiers for single MR transaction. Signed-off-by: Richard Henderson Compare: https://github.com/qemu/qemu/compare/2f8eb086732a...7635eff97104
[Qemu-commits] [qemu/qemu] 73944a: pseries: Update SLOF firmware image
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 73944a4bf4ab259b489af8128b4aec525484d642 https://github.com/qemu/qemu/commit/73944a4bf4ab259b489af8128b4aec525484d642 Author: Alexey Kardashevskiy Date: 2021-11-13 (Sat, 13 Nov 2021) Changed paths: M pc-bios/README M pc-bios/slof.bin M roms/SLOF Log Message: --- pseries: Update SLOF firmware image This has really just one fix from Stefan, the rest is housekeeping. The full changelog is: Alexey Kardashevskiy (3): Revert "make: Define default rule for .c when V=1 or V=2" js2x: Fix compile and cleanup version: update to 2022 Stefan Berger (1): tcgbios: Disable platform hierarchy in case of failure Thomas Huth (8): Mention the CR vs. LF problem in the documentation slof/fs/accept: Replace TABs with spaces Fix the URL to the Linux kernel coding style lib/libc/README.txt: Fix "cannel" typo travis.yml: Fix keywords travis.yml: Update to Focal Fossa travis.yml: Compile-test the qemu build Silence some trivial compiler warning in the js2x code Signed-off-by: Alexey Kardashevskiy Commit: 2307ddc15b4f966f9de2066fe399bc723a452e28 https://github.com/qemu/qemu/commit/2307ddc15b4f966f9de2066fe399bc723a452e28 Author: Cédric Le Goater Date: 2021-12-16 (Thu, 16 Dec 2021) Changed paths: M pc-bios/README M pc-bios/slof.bin M roms/SLOF Log Message: --- Merge tag 'qemu-slof-2022' of github.com:aik/qemu into ppc-next * tag 'qemu-slof-2022' of github.com:aik/qemu: pseries: Update SLOF firmware image Signed-off-by: Cédric Le Goater Commit: 81fa8f265e698b741cbb954b7fd8db227525b3ef https://github.com/qemu/qemu/commit/81fa8f265e698b741cbb954b7fd8db227525b3ef Author: Peter Maydell Date: 2021-12-16 (Thu, 16 Dec 2021) Changed paths: M hw/ppc/mac.h M hw/ppc/mac_newworld.c M hw/ppc/mac_oldworld.c Log Message: --- hw/ppc/mac.h: Remove MAX_CPUS macro The mac.h header defines a MAX_CPUS macro. This is confusingly named, because it suggests it's a generic setting, but in fact it's used by only the g3beige and mac99 machines. It's also using a single macro for two values which aren't inherently the same -- if one of these two machines was updated to support SMP configurations then it would want a different max_cpus value to the other. Since the macro is used in only two places, just expand it out and get rid of it. If hypothetical future work to support SMP in these boards needs a compile-time-known limit on the number of CPUs, we can give it a suitable name at that point. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-Id: <20211105184216.120972-1-peter.mayd...@linaro.org> Signed-off-by: Cédric Le Goater Commit: a9911b2dd37b52748f06fa21f28cfb4d299f7a35 https://github.com/qemu/qemu/commit/a9911b2dd37b52748f06fa21f28cfb4d299f7a35 Author: Lucas Mateus Castro (alqotel) Date: 2021-12-16 (Thu, 16 Dec 2021) Changed paths: M target/ppc/fpu_helper.c M target/ppc/helper.h M target/ppc/translate/fp-impl.c.inc Log Message: --- target/ppc: Fixed call to deferred exception mtfsf, mtfsfi and mtfsb1 instructions call helper_float_check_status after updating the value of FPSCR, but helper_float_check_status checks fp_status and fp_status isn't updated based on FPSCR and since the value of fp_status is reset earlier in the instruction, it's always 0. Because of this helper_float_check_status would change the FI bit to 0 as this bit checks if the last operation was inexact and float_flag_inexact is always 0. These instructions also don't throw exceptions correctly since helper_float_check_status throw exceptions based on fp_status. This commit created a new helper, helper_fpscr_check_status that checks FPSCR value instead of fp_status and checks for a larger variety of exceptions than do_float_check_status. Since fp_status isn't used, gen_reset_fpstatus() was removed. The hardware used to compare QEMU's behavior to was a Power9. Reviewed-by: Richard Henderson Signed-off-by: Lucas Mateus Castro (alqotel) Message-Id: <20211201163808.440385-2-lucas.ara...@eldorado.org.br> Signed-off-by: Cédric Le Goater Commit: 75bf9c760d9cdf72b842f2afb2bd5e0278cc0695 https://github.com/qemu/qemu/commit/75bf9c760d9cdf72b842f2afb2bd5e0278cc0695 Author: Lucas Mateus Castro (alqotel) Date: 2021-12-16 (Thu, 16 Dec 2021) Changed paths: M tests/tcg/ppc64/Makefile.target M tests/tcg/ppc64le/Makefile.target A tests/tcg/ppc64le/mtfsf.c Log Message: --- test/tcg/ppc64le: test mtfsf Added tests for the mtfsf to check if FI bit of FPSCR is being set and if exception calls are being made correctly. Reviewed-by: Richard Henderson Signed-off-by: Lucas Mateus Castro (alqotel) Message-Id:
[Qemu-commits] [qemu/qemu] ba7c60: configure: make $targetos lowercase, use windows i...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: ba7c60c203eb068cff591e4d0e7dbcc2b5aa013a https://github.com/qemu/qemu/commit/ba7c60c203eb068cff591e4d0e7dbcc2b5aa013a Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: make $targetos lowercase, use windows instead of MINGW32 targetos is already mostly the same as Meson host_machine.system(), just in CamelCase. Adjust Windows, which is different, and switch to lowercase to match Meson. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 65eff01bcf920bcdbdb83dd0546005b522742c47 https://github.com/qemu/qemu/commit/65eff01bcf920bcdbdb83dd0546005b522742c47 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: move target detection before CPU detection This makes more sense, since target detection can affect CPU detection on Solaris. Signed-off-by: Paolo Bonzini Commit: e4da0e39dfce5366b22b3e28ec63d0470c1df550 https://github.com/qemu/qemu/commit/e4da0e39dfce5366b22b3e28ec63d0470c1df550 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: unify two case statements on $cpu Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: d8ff892dc23e9921db49d2053036240675bb50f8 https://github.com/qemu/qemu/commit/d8ff892dc23e9921db49d2053036240675bb50f8 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M tests/tcg/configure.sh Log Message: --- configure: unify ppc64 and ppc64le The only difference between the two, as far as either configure or Meson are concerned, is the default endianness of the compiler. For tests/tcg, specify the endianness explicitly on the command line; for configure, do the same so that it is possible to have --cpu=ppc64le on a bigendian system or vice versa. Apart from this, cpu=ppc64le can be normalized to ppc64 also in configure and not just in the meson cross file. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 4da270be1c4ac32c0e60a364e3173b57b1f79dba https://github.com/qemu/qemu/commit/4da270be1c4ac32c0e60a364e3173b57b1f79dba Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M meson.build Log Message: --- configure: unify x86_64 and x32 The only difference between the two, as far as either configure or Meson are concerned, is in the multilib flags passed to the compiler. For QEMU, this fixes the handling of TYPE_OLDDEVT in include/exec/user/thunk.h and enables testing of dirty ring buffer, because both are using HOST_X86_64. For tests/tcg, this means that on a hypothetical x32 host the cross compiler will not be used to build the tests. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: ffb91f68b1c13a1cc36124350eacfe14095d5e1e https://github.com/qemu/qemu/commit/ffb91f68b1c13a1cc36124350eacfe14095d5e1e Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M meson.build Log Message: --- meson: rename "arch" variable Avoid confusion between the ARCH variable of configure/config-host.mak and the same-named variable of meson.build. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 823eb013452e93d34fc0630fea98717d7d8f240a https://github.com/qemu/qemu/commit/823eb013452e93d34fc0630fea98717d7d8f240a Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M meson.build Log Message: --- configure, meson: move ARCH to meson.build $ARCH and the HOST_* symbols are only used by the QEMU build; configure uses $cpu instead. Remove it from config-host.mak. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 0f457147f41bd7cbb7fd1193b057af9226a2184a https://github.com/qemu/qemu/commit/0f457147f41bd7cbb7fd1193b057af9226a2184a Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M pc-bios/meson.build Log Message: --- configure: remove unnecessary symlinks Make pc-bios/meson.build use the files in the source tree as inputs to bzip2. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 5dce7b8d8ce6f397a2f2e46c236cc102d4e7a585 https://github.com/qemu/qemu/commit/5dce7b8d8ce6f397a2f2e46c236cc102d4e7a585 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: remove DIRS DIRS is used to create the directory in which the LINKS symbolic links reside, or to create directories
[Qemu-commits] [qemu/qemu] c35aff: s390: kvm: adjust diag318 resets to retain data
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: c35aff184b2ed5be930da671ea25c857713555af https://github.com/qemu/qemu/commit/c35aff184b2ed5be930da671ea25c857713555af Author: Collin Walling Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M target/s390x/cpu.h M target/s390x/kvm/kvm.c Log Message: --- s390: kvm: adjust diag318 resets to retain data The CPNC portion of the diag318 data is erroneously reset during an initial CPU reset caused by SIGP. Let's go ahead and relocate the diag318_info field within the CPUS390XState struct such that it is only zeroed during a clear reset. This way, the CPNC will be retained for each VCPU in the configuration after the diag318 instruction has been invoked. The s390_machine_reset code already takes care of zeroing the diag318 data on VM resets, which also cover resets caused by diag308. Fixes: fabdada9357b ("s390: guest support for diagnose 0x318") Reported-by: Christian Borntraeger Signed-off-by: Collin Walling Reviewed-by: Janosch Frank Reviewed-by: Christian Borntraeger Message-Id: <2027152303.627969-1-wall...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: 2c092950a4766307e3d14f3764f7610d551515b9 https://github.com/qemu/qemu/commit/2c092950a4766307e3d14f3764f7610d551515b9 Author: Christian Borntraeger Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M .mailmap M MAINTAINERS Log Message: --- MAINTAINERS: update email address of Christian Borntraeger My borntrae...@de.ibm.com email is just a forwarder to the linux.ibm.com address. Let us remove the extra hop to avoid a potential source of errors. While at it, add the relevant email addresses to mailmap. Signed-off-by: Christian Borntraeger Message-Id: <20211126102449.287524-1-borntrae...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: b2892a2b9d45d25b909108ca633d19f9d8d673f5 https://github.com/qemu/qemu/commit/b2892a2b9d45d25b909108ca633d19f9d8d673f5 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/hw/s390x/s390-pci-bus.h Log Message: --- s390x/pci: use a reserved ID for the default PCI group The current default PCI group being used can technically collide with a real group ID passed from a hostdev. Let's instead use a group ID that comes from a special pool (0xF0-0xFF) that is architected to be reserved for simulated devices. Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-2-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: df7ce0a94d9283f0656b4bc0f21566973ff649a3 https://github.com/qemu/qemu/commit/df7ce0a94d9283f0656b4bc0f21566973ff649a3 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/s390x/s390-pci-inst.c Log Message: --- s390x/pci: don't use hard-coded dma range in reg_ioat Instead use the values from clp info, they will either be the hard-coded values or what came from the host driver via vfio. Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-3-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: cb6d6a3e6aa1226b67fd218953dcb3866c3a6845 https://github.com/qemu/qemu/commit/cb6d6a3e6aa1226b67fd218953dcb3866c3a6845 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/s390x/s390-pci-inst.c Log Message: --- s390x/pci: use the passthrough measurement update interval We may have gotten a measurement update interval from the underlying host via vfio -- Use it to set the interval via which we update the function measurement block. Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-4-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: ac6aa30ac47b2abaf142f76de46374da2a98f6e7 https://github.com/qemu/qemu/commit/ac6aa30ac47b2abaf142f76de46374da2a98f6e7 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/s390x/s390-pci-bus.c M hw/s390x/s390-pci-inst.c M hw/s390x/s390-pci-vfio.c M include/hw/s390x/s390-pci-bus.h M include/hw/s390x/s390-pci-clp.h Log Message: --- s390x/pci: add supported DT information to clp response The DTSM is a mask that specifies which I/O Address Translation designation types are supported. Today QEMU only supports DT=1. Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-5-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: 9f8e6cad65a66b27e797defe639a4a4fd4330f23
[Qemu-commits] [qemu/qemu] c35aff: s390: kvm: adjust diag318 resets to retain data
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: c35aff184b2ed5be930da671ea25c857713555af https://github.com/qemu/qemu/commit/c35aff184b2ed5be930da671ea25c857713555af Author: Collin Walling Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M target/s390x/cpu.h M target/s390x/kvm/kvm.c Log Message: --- s390: kvm: adjust diag318 resets to retain data The CPNC portion of the diag318 data is erroneously reset during an initial CPU reset caused by SIGP. Let's go ahead and relocate the diag318_info field within the CPUS390XState struct such that it is only zeroed during a clear reset. This way, the CPNC will be retained for each VCPU in the configuration after the diag318 instruction has been invoked. The s390_machine_reset code already takes care of zeroing the diag318 data on VM resets, which also cover resets caused by diag308. Fixes: fabdada9357b ("s390: guest support for diagnose 0x318") Reported-by: Christian Borntraeger Signed-off-by: Collin Walling Reviewed-by: Janosch Frank Reviewed-by: Christian Borntraeger Message-Id: <2027152303.627969-1-wall...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: 2c092950a4766307e3d14f3764f7610d551515b9 https://github.com/qemu/qemu/commit/2c092950a4766307e3d14f3764f7610d551515b9 Author: Christian Borntraeger Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M .mailmap M MAINTAINERS Log Message: --- MAINTAINERS: update email address of Christian Borntraeger My borntrae...@de.ibm.com email is just a forwarder to the linux.ibm.com address. Let us remove the extra hop to avoid a potential source of errors. While at it, add the relevant email addresses to mailmap. Signed-off-by: Christian Borntraeger Message-Id: <20211126102449.287524-1-borntrae...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: b2892a2b9d45d25b909108ca633d19f9d8d673f5 https://github.com/qemu/qemu/commit/b2892a2b9d45d25b909108ca633d19f9d8d673f5 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/hw/s390x/s390-pci-bus.h Log Message: --- s390x/pci: use a reserved ID for the default PCI group The current default PCI group being used can technically collide with a real group ID passed from a hostdev. Let's instead use a group ID that comes from a special pool (0xF0-0xFF) that is architected to be reserved for simulated devices. Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-2-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: df7ce0a94d9283f0656b4bc0f21566973ff649a3 https://github.com/qemu/qemu/commit/df7ce0a94d9283f0656b4bc0f21566973ff649a3 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/s390x/s390-pci-inst.c Log Message: --- s390x/pci: don't use hard-coded dma range in reg_ioat Instead use the values from clp info, they will either be the hard-coded values or what came from the host driver via vfio. Fixes: 9670ee752727 ("s390x/pci: use a PCI Function structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-3-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: cb6d6a3e6aa1226b67fd218953dcb3866c3a6845 https://github.com/qemu/qemu/commit/cb6d6a3e6aa1226b67fd218953dcb3866c3a6845 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/s390x/s390-pci-inst.c Log Message: --- s390x/pci: use the passthrough measurement update interval We may have gotten a measurement update interval from the underlying host via vfio -- Use it to set the interval via which we update the function measurement block. Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure") Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-4-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: ac6aa30ac47b2abaf142f76de46374da2a98f6e7 https://github.com/qemu/qemu/commit/ac6aa30ac47b2abaf142f76de46374da2a98f6e7 Author: Matthew Rosato Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/s390x/s390-pci-bus.c M hw/s390x/s390-pci-inst.c M hw/s390x/s390-pci-vfio.c M include/hw/s390x/s390-pci-bus.h M include/hw/s390x/s390-pci-clp.h Log Message: --- s390x/pci: add supported DT information to clp response The DTSM is a mask that specifies which I/O Address Translation designation types are supported. Today QEMU only supports DT=1. Signed-off-by: Matthew Rosato Reviewed-by: Eric Farman Reviewed-by: Pierre Morel Message-Id: <20211203142706.427279-5-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth Commit: 9f8e6cad65a66b27e797defe639a4a4fd4330f23
[Qemu-commits] [qemu/qemu] 73944a: pseries: Update SLOF firmware image
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 73944a4bf4ab259b489af8128b4aec525484d642 https://github.com/qemu/qemu/commit/73944a4bf4ab259b489af8128b4aec525484d642 Author: Alexey Kardashevskiy Date: 2021-11-13 (Sat, 13 Nov 2021) Changed paths: M pc-bios/README M pc-bios/slof.bin M roms/SLOF Log Message: --- pseries: Update SLOF firmware image This has really just one fix from Stefan, the rest is housekeeping. The full changelog is: Alexey Kardashevskiy (3): Revert "make: Define default rule for .c when V=1 or V=2" js2x: Fix compile and cleanup version: update to 2022 Stefan Berger (1): tcgbios: Disable platform hierarchy in case of failure Thomas Huth (8): Mention the CR vs. LF problem in the documentation slof/fs/accept: Replace TABs with spaces Fix the URL to the Linux kernel coding style lib/libc/README.txt: Fix "cannel" typo travis.yml: Fix keywords travis.yml: Update to Focal Fossa travis.yml: Compile-test the qemu build Silence some trivial compiler warning in the js2x code Signed-off-by: Alexey Kardashevskiy Commit: 2307ddc15b4f966f9de2066fe399bc723a452e28 https://github.com/qemu/qemu/commit/2307ddc15b4f966f9de2066fe399bc723a452e28 Author: Cédric Le Goater Date: 2021-12-16 (Thu, 16 Dec 2021) Changed paths: M pc-bios/README M pc-bios/slof.bin M roms/SLOF Log Message: --- Merge tag 'qemu-slof-2022' of github.com:aik/qemu into ppc-next * tag 'qemu-slof-2022' of github.com:aik/qemu: pseries: Update SLOF firmware image Signed-off-by: Cédric Le Goater Commit: 83234b8289e64fc359a5bf02d886a333d65b8f8c https://github.com/qemu/qemu/commit/83234b8289e64fc359a5bf02d886a333d65b8f8c Author: Peter Maydell Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/ppc/mac.h M hw/ppc/mac_newworld.c M hw/ppc/mac_oldworld.c Log Message: --- hw/ppc/mac.h: Remove MAX_CPUS macro The mac.h header defines a MAX_CPUS macro. This is confusingly named, because it suggests it's a generic setting, but in fact it's used by only the g3beige and mac99 machines. It's also using a single macro for two values which aren't inherently the same -- if one of these two machines was updated to support SMP configurations then it would want a different max_cpus value to the other. Since the macro is used in only two places, just expand it out and get rid of it. If hypothetical future work to support SMP in these boards needs a compile-time-known limit on the number of CPUs, we can give it a suitable name at that point. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-Id: <20211105184216.120972-1-peter.mayd...@linaro.org> Signed-off-by: Cédric Le Goater Commit: c3a824b0cf23f98353fa91c715fe4918432d7928 https://github.com/qemu/qemu/commit/c3a824b0cf23f98353fa91c715fe4918432d7928 Author: Lucas Mateus Castro (alqotel) Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M target/ppc/fpu_helper.c M target/ppc/helper.h M target/ppc/translate/fp-impl.c.inc Log Message: --- target/ppc: Fixed call to deferred exception mtfsf, mtfsfi and mtfsb1 instructions call helper_float_check_status after updating the value of FPSCR, but helper_float_check_status checks fp_status and fp_status isn't updated based on FPSCR and since the value of fp_status is reset earlier in the instruction, it's always 0. Because of this helper_float_check_status would change the FI bit to 0 as this bit checks if the last operation was inexact and float_flag_inexact is always 0. These instructions also don't throw exceptions correctly since helper_float_check_status throw exceptions based on fp_status. This commit created a new helper, helper_fpscr_check_status that checks FPSCR value instead of fp_status and checks for a larger variety of exceptions than do_float_check_status. Since fp_status isn't used, gen_reset_fpstatus() was removed. The hardware used to compare QEMU's behavior to was a Power9. Reviewed-by: Richard Henderson Signed-off-by: Lucas Mateus Castro (alqotel) Message-Id: <20211201163808.440385-2-lucas.ara...@eldorado.org.br> Signed-off-by: Cédric Le Goater Commit: 00d38802513da6141a732ef7c3619bd0f8f01a8e https://github.com/qemu/qemu/commit/00d38802513da6141a732ef7c3619bd0f8f01a8e Author: Lucas Mateus Castro (alqotel) Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M tests/tcg/ppc64/Makefile.target M tests/tcg/ppc64le/Makefile.target A tests/tcg/ppc64le/mtfsf.c Log Message: --- test/tcg/ppc64le: test mtfsf Added tests for the mtfsf to check if FI bit of FPSCR is being set and if exception calls are being made correctly. Reviewed-by: Richard Henderson Signed-off-by: Lucas Mateus Castro (alqotel) Message-Id:
[Qemu-commits] [qemu/qemu] 73944a: pseries: Update SLOF firmware image
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 73944a4bf4ab259b489af8128b4aec525484d642 https://github.com/qemu/qemu/commit/73944a4bf4ab259b489af8128b4aec525484d642 Author: Alexey Kardashevskiy Date: 2021-11-13 (Sat, 13 Nov 2021) Changed paths: M pc-bios/README M pc-bios/slof.bin M roms/SLOF Log Message: --- pseries: Update SLOF firmware image This has really just one fix from Stefan, the rest is housekeeping. The full changelog is: Alexey Kardashevskiy (3): Revert "make: Define default rule for .c when V=1 or V=2" js2x: Fix compile and cleanup version: update to 2022 Stefan Berger (1): tcgbios: Disable platform hierarchy in case of failure Thomas Huth (8): Mention the CR vs. LF problem in the documentation slof/fs/accept: Replace TABs with spaces Fix the URL to the Linux kernel coding style lib/libc/README.txt: Fix "cannel" typo travis.yml: Fix keywords travis.yml: Update to Focal Fossa travis.yml: Compile-test the qemu build Silence some trivial compiler warning in the js2x code Signed-off-by: Alexey Kardashevskiy Commit: 2307ddc15b4f966f9de2066fe399bc723a452e28 https://github.com/qemu/qemu/commit/2307ddc15b4f966f9de2066fe399bc723a452e28 Author: Cédric Le Goater Date: 2021-12-16 (Thu, 16 Dec 2021) Changed paths: M pc-bios/README M pc-bios/slof.bin M roms/SLOF Log Message: --- Merge tag 'qemu-slof-2022' of github.com:aik/qemu into ppc-next * tag 'qemu-slof-2022' of github.com:aik/qemu: pseries: Update SLOF firmware image Signed-off-by: Cédric Le Goater Commit: 83234b8289e64fc359a5bf02d886a333d65b8f8c https://github.com/qemu/qemu/commit/83234b8289e64fc359a5bf02d886a333d65b8f8c Author: Peter Maydell Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/ppc/mac.h M hw/ppc/mac_newworld.c M hw/ppc/mac_oldworld.c Log Message: --- hw/ppc/mac.h: Remove MAX_CPUS macro The mac.h header defines a MAX_CPUS macro. This is confusingly named, because it suggests it's a generic setting, but in fact it's used by only the g3beige and mac99 machines. It's also using a single macro for two values which aren't inherently the same -- if one of these two machines was updated to support SMP configurations then it would want a different max_cpus value to the other. Since the macro is used in only two places, just expand it out and get rid of it. If hypothetical future work to support SMP in these boards needs a compile-time-known limit on the number of CPUs, we can give it a suitable name at that point. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-Id: <20211105184216.120972-1-peter.mayd...@linaro.org> Signed-off-by: Cédric Le Goater Commit: c3a824b0cf23f98353fa91c715fe4918432d7928 https://github.com/qemu/qemu/commit/c3a824b0cf23f98353fa91c715fe4918432d7928 Author: Lucas Mateus Castro (alqotel) Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M target/ppc/fpu_helper.c M target/ppc/helper.h M target/ppc/translate/fp-impl.c.inc Log Message: --- target/ppc: Fixed call to deferred exception mtfsf, mtfsfi and mtfsb1 instructions call helper_float_check_status after updating the value of FPSCR, but helper_float_check_status checks fp_status and fp_status isn't updated based on FPSCR and since the value of fp_status is reset earlier in the instruction, it's always 0. Because of this helper_float_check_status would change the FI bit to 0 as this bit checks if the last operation was inexact and float_flag_inexact is always 0. These instructions also don't throw exceptions correctly since helper_float_check_status throw exceptions based on fp_status. This commit created a new helper, helper_fpscr_check_status that checks FPSCR value instead of fp_status and checks for a larger variety of exceptions than do_float_check_status. Since fp_status isn't used, gen_reset_fpstatus() was removed. The hardware used to compare QEMU's behavior to was a Power9. Reviewed-by: Richard Henderson Signed-off-by: Lucas Mateus Castro (alqotel) Message-Id: <20211201163808.440385-2-lucas.ara...@eldorado.org.br> Signed-off-by: Cédric Le Goater Commit: 00d38802513da6141a732ef7c3619bd0f8f01a8e https://github.com/qemu/qemu/commit/00d38802513da6141a732ef7c3619bd0f8f01a8e Author: Lucas Mateus Castro (alqotel) Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M tests/tcg/ppc64/Makefile.target M tests/tcg/ppc64le/Makefile.target A tests/tcg/ppc64le/mtfsf.c Log Message: --- test/tcg/ppc64le: test mtfsf Added tests for the mtfsf to check if FI bit of FPSCR is being set and if exception calls are being made correctly. Reviewed-by: Richard Henderson Signed-off-by: Lucas Mateus Castro (alqotel) Message-Id:
[Qemu-commits] [qemu/qemu] f2b143: ui/vdagent: add CHECK_SPICE_PROTOCOL_VERSION
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: f2b143dc3ae9447abb0a4301e1a1ad0ed7adc33b https://github.com/qemu/qemu/commit/f2b143dc3ae9447abb0a4301e1a1ad0ed7adc33b Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M meson.build M ui/vdagent.c Log Message: --- ui/vdagent: add CHECK_SPICE_PROTOCOL_VERSION Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Commit: 1f28c0354471af5c12fb26ed3dbc3cd3a22e7802 https://github.com/qemu/qemu/commit/1f28c0354471af5c12fb26ed3dbc3cd3a22e7802 Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M ui/vdagent.c Log Message: --- ui/vdagent: replace #if 0 with protocol version check Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Commit: ddd5c8672b2e24eab62add12da7416feb53171bd https://github.com/qemu/qemu/commit/ddd5c8672b2e24eab62add12da7416feb53171bd Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/ui/clipboard.h M ui/clipboard.c M ui/cocoa.m M ui/gtk-clipboard.c M ui/vdagent.c M ui/vnc-clipboard.c M ui/vnc.c Log Message: --- ui: generalize clipboard notifier Use a QemuClipboardNotify union type for extendable clipboard events. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Commit: e49fe7d54b711da675243fba144ad1ef2596c506 https://github.com/qemu/qemu/commit/e49fe7d54b711da675243fba144ad1ef2596c506 Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/ui/clipboard.h M ui/trace-events M ui/vdagent.c Log Message: --- ui/vdagent: add serial capability support The Spice agent implements a simple serial mechanism to avoid clipboard races between client & guest. See: https://gitlab.freedesktop.org/spice/spice-protocol/-/commit/045a6978d6dbbf7046affc5c321fa8177c8cce56 Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Commit: a191d276db9f49b4eb10ce3b18efaee9b2153f56 https://github.com/qemu/qemu/commit/a191d276db9f49b4eb10ce3b18efaee9b2153f56 Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/ui/clipboard.h M ui/clipboard.c Log Message: --- ui/clipboard: add qemu_clipboard_check_serial() Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Commit: 7b4a3b108f84499a8d384c14459989743ff2c95b https://github.com/qemu/qemu/commit/7b4a3b108f84499a8d384c14459989743ff2c95b Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/ui/clipboard.h M ui/clipboard.c M ui/cocoa.m M ui/gtk-clipboard.c M ui/vdagent.c M ui/vnc-clipboard.c Log Message: --- ui/clipboard: add a clipboard reset serial event Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Commit: 7410186b0a4761dec4ef03b2f40eaf9d9d311f9f https://github.com/qemu/qemu/commit/7410186b0a4761dec4ef03b2f40eaf9d9d311f9f Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/display/virtio-gpu-virgl.c Log Message: --- hw/display: report an error if virgl initialization failed Currently, virgl initialization error is silent. Make it verbose instead. (this is likely going to bug later on, as the device isn't fully initialized) Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Commit: 9c49e356df18098124c361bc31be3d2050eabc2c https://github.com/qemu/qemu/commit/9c49e356df18098124c361bc31be3d2050eabc2c Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/display/virtio-gpu-virgl.c Log Message: --- virtio-gpu: use VIRTIO_GPU_RESOURCE_FLAG_Y_0_TOP It's part of Linux headers for a while now. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Commit: 7ed12fa3b3feca8d1a561e7b03d26cc08dbf0e5e https://github.com/qemu/qemu/commit/7ed12fa3b3feca8d1a561e7b03d26cc08dbf0e5e Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/ui/console.h M ui/console.c M ui/gtk.c M ui/sdl2.c M ui/spice-display.c M ui/vnc.c Log Message: --- ui: do not delay further remote resize A remote client, such as Spice, will already avoid flooding the stream by delaying the resize requests. Signed-off-by: Marc-André Lureau Acked-by: Gerd Hoffmann Commit: 090759cacfd776a9d8ee540dbde3b5be694da394 https://github.com/qemu/qemu/commit/090759cacfd776a9d8ee540dbde3b5be694da394 Author: Marc-André Lureau Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/ui/console.h M ui/console.c Log Message: --- ui: factor out qemu_console_set_display_gl_ctx() The
[Qemu-commits] [qemu/qemu] 57a93f: configure: Symlink binaries using .exe suffix with...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 57a93f16e8dad554720edcc5ed1fe613d68bf230 https://github.com/qemu/qemu/commit/57a93f16e8dad554720edcc5ed1fe613d68bf230 Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M configure Log Message: --- configure: Symlink binaries using .exe suffix with MinGW When using the MinGW toolchain, we use the .exe suffix for the executable name. We also need to use it for the symlinks in the build directory. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil Acked-by: Paolo Bonzini Message-Id: <20211109144504.1541206-1-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit: dc7d6cafce8a7d36d2ebc03be3b6162e0eb98c22 https://github.com/qemu/qemu/commit/dc7d6cafce8a7d36d2ebc03be3b6162e0eb98c22 Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M target/i386/kvm/kvm.c Log Message: --- target/i386/kvm: Replace use of __u32 type QEMU coding style mandates to not use Linux kernel internal types for scalars types. Replace __u32 by uint32_t. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <2026193955.2793171-1-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit: 4455922f7bb8fef2f5aa0a4d3901041bcc4b659d https://github.com/qemu/qemu/commit/4455922f7bb8fef2f5aa0a4d3901041bcc4b659d Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M qemu-keymap.c Log Message: --- qemu-keymap: Add license in generated files Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id: <2027174533.1900570-1-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit: 74fb2f4f4c47c966ab54687392e6561b4de4bb8a https://github.com/qemu/qemu/commit/74fb2f4f4c47c966ab54687392e6561b4de4bb8a Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/avr/atmega.c Log Message: --- hw/avr: Realize AVRCPU qdev object using qdev_realize() TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. TYPE_DEVICE instances are realized using qdev_realize(), we don't need to access QOM internal values. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Rolnik Message-Id: <20211205224109.322152-1-f4...@amsat.org> Signed-off-by: Laurent Vivier Commit: f71d31fa811f15d40ab076b350c2067d30ac22b1 https://github.com/qemu/qemu/commit/f71d31fa811f15d40ab076b350c2067d30ac22b1 Author: Leonardo Garcia Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/virtio/vhost.c Log Message: --- hw/virtio/vhost: Fix typo in comment. Signed-off-by: Leonardo Garcia Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: Signed-off-by: Laurent Vivier Commit: 036ef344b6c51f651a3b5c6ca56868fa3e6554fe https://github.com/qemu/qemu/commit/036ef344b6c51f651a3b5c6ca56868fa3e6554fe Author: Zhang Chen Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M docs/block-replication.txt Log Message: --- docs/block-replication.txt: Fix replication top-id command demo This demo not correct, the original childs1 can't pass the the bdrv_is_root_node check in replcation_start(). Keep consistent with docs/COLO-FT.txt Signed-off-by: Zhang Chen Reviewed-by: Laurent Vivier Message-Id: <20211018085044.2788276-1-chen.zh...@intel.com> Signed-off-by: Laurent Vivier Commit: 2c674fada72079583a3f2cc1790b16a0259c4fa0 https://github.com/qemu/qemu/commit/2c674fada72079583a3f2cc1790b16a0259c4fa0 Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/glib-compat.h Log Message: --- glib-compat: Introduce g_memdup2() wrapper When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 (Fedora 34 provides GLib 2.68.1) we get: hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use 'g_memdup2' instead [-Werror,-Wdeprecated-declarations] ... g_memdup() has been updated by g_memdup2() to fix eventual security issues (size argument is 32-bit and could be truncated / wrapping). GLib recommends to copy their static inline version of g_memdup2(): https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 Our glib-compat.h provides a comment explaining how to deal with these deprecated declarations (see commit e71e8cc0355 "glib: enforce the minimum required version and warn about old APIs"). Following this comment suggestion, implement the g_memdup2_qemu() wrapper to g_memdup2(), and use the safer equivalent inlined when we are using pre-2.68 GLib. Reported-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Message-Id: <20210903174510.751630-3-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit:
[Qemu-commits] [qemu/qemu] 57a93f: configure: Symlink binaries using .exe suffix with...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 57a93f16e8dad554720edcc5ed1fe613d68bf230 https://github.com/qemu/qemu/commit/57a93f16e8dad554720edcc5ed1fe613d68bf230 Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M configure Log Message: --- configure: Symlink binaries using .exe suffix with MinGW When using the MinGW toolchain, we use the .exe suffix for the executable name. We also need to use it for the symlinks in the build directory. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Weil Acked-by: Paolo Bonzini Message-Id: <20211109144504.1541206-1-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit: dc7d6cafce8a7d36d2ebc03be3b6162e0eb98c22 https://github.com/qemu/qemu/commit/dc7d6cafce8a7d36d2ebc03be3b6162e0eb98c22 Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M target/i386/kvm/kvm.c Log Message: --- target/i386/kvm: Replace use of __u32 type QEMU coding style mandates to not use Linux kernel internal types for scalars types. Replace __u32 by uint32_t. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <2026193955.2793171-1-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit: 4455922f7bb8fef2f5aa0a4d3901041bcc4b659d https://github.com/qemu/qemu/commit/4455922f7bb8fef2f5aa0a4d3901041bcc4b659d Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M qemu-keymap.c Log Message: --- qemu-keymap: Add license in generated files Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Message-Id: <2027174533.1900570-1-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit: 74fb2f4f4c47c966ab54687392e6561b4de4bb8a https://github.com/qemu/qemu/commit/74fb2f4f4c47c966ab54687392e6561b4de4bb8a Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/avr/atmega.c Log Message: --- hw/avr: Realize AVRCPU qdev object using qdev_realize() TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. TYPE_DEVICE instances are realized using qdev_realize(), we don't need to access QOM internal values. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael Rolnik Message-Id: <20211205224109.322152-1-f4...@amsat.org> Signed-off-by: Laurent Vivier Commit: f71d31fa811f15d40ab076b350c2067d30ac22b1 https://github.com/qemu/qemu/commit/f71d31fa811f15d40ab076b350c2067d30ac22b1 Author: Leonardo Garcia Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M hw/virtio/vhost.c Log Message: --- hw/virtio/vhost: Fix typo in comment. Signed-off-by: Leonardo Garcia Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: Signed-off-by: Laurent Vivier Commit: 036ef344b6c51f651a3b5c6ca56868fa3e6554fe https://github.com/qemu/qemu/commit/036ef344b6c51f651a3b5c6ca56868fa3e6554fe Author: Zhang Chen Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M docs/block-replication.txt Log Message: --- docs/block-replication.txt: Fix replication top-id command demo This demo not correct, the original childs1 can't pass the the bdrv_is_root_node check in replcation_start(). Keep consistent with docs/COLO-FT.txt Signed-off-by: Zhang Chen Reviewed-by: Laurent Vivier Message-Id: <20211018085044.2788276-1-chen.zh...@intel.com> Signed-off-by: Laurent Vivier Commit: 2c674fada72079583a3f2cc1790b16a0259c4fa0 https://github.com/qemu/qemu/commit/2c674fada72079583a3f2cc1790b16a0259c4fa0 Author: Philippe Mathieu-Daudé Date: 2021-12-17 (Fri, 17 Dec 2021) Changed paths: M include/glib-compat.h Log Message: --- glib-compat: Introduce g_memdup2() wrapper When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 (Fedora 34 provides GLib 2.68.1) we get: hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use 'g_memdup2' instead [-Werror,-Wdeprecated-declarations] ... g_memdup() has been updated by g_memdup2() to fix eventual security issues (size argument is 32-bit and could be truncated / wrapping). GLib recommends to copy their static inline version of g_memdup2(): https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 Our glib-compat.h provides a comment explaining how to deal with these deprecated declarations (see commit e71e8cc0355 "glib: enforce the minimum required version and warn about old APIs"). Following this comment suggestion, implement the g_memdup2_qemu() wrapper to g_memdup2(), and use the safer equivalent inlined when we are using pre-2.68 GLib. Reported-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Message-Id: <20210903174510.751630-3-phi...@redhat.com> Signed-off-by: Laurent Vivier Commit:
[Qemu-commits] [qemu/qemu] ba7c60: configure: make $targetos lowercase, use windows i...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: ba7c60c203eb068cff591e4d0e7dbcc2b5aa013a https://github.com/qemu/qemu/commit/ba7c60c203eb068cff591e4d0e7dbcc2b5aa013a Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: make $targetos lowercase, use windows instead of MINGW32 targetos is already mostly the same as Meson host_machine.system(), just in CamelCase. Adjust Windows, which is different, and switch to lowercase to match Meson. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 65eff01bcf920bcdbdb83dd0546005b522742c47 https://github.com/qemu/qemu/commit/65eff01bcf920bcdbdb83dd0546005b522742c47 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: move target detection before CPU detection This makes more sense, since target detection can affect CPU detection on Solaris. Signed-off-by: Paolo Bonzini Commit: e4da0e39dfce5366b22b3e28ec63d0470c1df550 https://github.com/qemu/qemu/commit/e4da0e39dfce5366b22b3e28ec63d0470c1df550 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: unify two case statements on $cpu Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: d8ff892dc23e9921db49d2053036240675bb50f8 https://github.com/qemu/qemu/commit/d8ff892dc23e9921db49d2053036240675bb50f8 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M tests/tcg/configure.sh Log Message: --- configure: unify ppc64 and ppc64le The only difference between the two, as far as either configure or Meson are concerned, is the default endianness of the compiler. For tests/tcg, specify the endianness explicitly on the command line; for configure, do the same so that it is possible to have --cpu=ppc64le on a bigendian system or vice versa. Apart from this, cpu=ppc64le can be normalized to ppc64 also in configure and not just in the meson cross file. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 4da270be1c4ac32c0e60a364e3173b57b1f79dba https://github.com/qemu/qemu/commit/4da270be1c4ac32c0e60a364e3173b57b1f79dba Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M meson.build Log Message: --- configure: unify x86_64 and x32 The only difference between the two, as far as either configure or Meson are concerned, is in the multilib flags passed to the compiler. For QEMU, this fixes the handling of TYPE_OLDDEVT in include/exec/user/thunk.h and enables testing of dirty ring buffer, because both are using HOST_X86_64. For tests/tcg, this means that on a hypothetical x32 host the cross compiler will not be used to build the tests. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: ffb91f68b1c13a1cc36124350eacfe14095d5e1e https://github.com/qemu/qemu/commit/ffb91f68b1c13a1cc36124350eacfe14095d5e1e Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M meson.build Log Message: --- meson: rename "arch" variable Avoid confusion between the ARCH variable of configure/config-host.mak and the same-named variable of meson.build. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 823eb013452e93d34fc0630fea98717d7d8f240a https://github.com/qemu/qemu/commit/823eb013452e93d34fc0630fea98717d7d8f240a Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M meson.build Log Message: --- configure, meson: move ARCH to meson.build $ARCH and the HOST_* symbols are only used by the QEMU build; configure uses $cpu instead. Remove it from config-host.mak. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 0f457147f41bd7cbb7fd1193b057af9226a2184a https://github.com/qemu/qemu/commit/0f457147f41bd7cbb7fd1193b057af9226a2184a Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure M pc-bios/meson.build Log Message: --- configure: remove unnecessary symlinks Make pc-bios/meson.build use the files in the source tree as inputs to bzip2. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini Commit: 5dce7b8d8ce6f397a2f2e46c236cc102d4e7a585 https://github.com/qemu/qemu/commit/5dce7b8d8ce6f397a2f2e46c236cc102d4e7a585 Author: Paolo Bonzini Date: 2021-12-18 (Sat, 18 Dec 2021) Changed paths: M configure Log Message: --- configure: remove DIRS DIRS is used to create the directory in which the LINKS symbolic links reside, or to create directories for
[Qemu-commits] [qemu/qemu] 99423b: tests/tcg: Use $cpu in configure.sh
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 99423bc1c3c3c13d6b60bd112c0eaea3205abc65 https://github.com/qemu/qemu/commit/99423bc1c3c3c13d6b60bd112c0eaea3205abc65 Author: Richard Henderson Date: 2021-12-24 (Fri, 24 Dec 2021) Changed paths: M configure M tests/tcg/configure.sh Log Message: --- tests/tcg: Use $cpu in configure.sh Use $cpu instead of $ARCH, which has been removed from the top-level configure. Fixes: 823eb013452e Signed-off-by: Richard Henderson
[Qemu-commits] [qemu/qemu] 41d5e8: hw/scsi/megasas: Use uint32_t for reply queue head...
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 41d5e8da3d5e0a143a9fb397c9f34707ec544997 https://github.com/qemu/qemu/commit/41d5e8da3d5e0a143a9fb397c9f34707ec544997 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/scsi/megasas.c M hw/scsi/trace-events Log Message: --- hw/scsi/megasas: Use uint32_t for reply queue head/tail values While the reply queue values fit in 16-bit, they are accessed as 32-bit: 661:s->reply_queue_head = ldl_le_pci_dma(pcid, s->producer_pa); 662:s->reply_queue_head %= MEGASAS_MAX_FRAMES; 663:s->reply_queue_tail = ldl_le_pci_dma(pcid, s->consumer_pa); 664:s->reply_queue_tail %= MEGASAS_MAX_FRAMES; Having: 41:#define MEGASAS_MAX_FRAMES 2048 /* Firmware limit at 65535 */ In order to update the ld/st*_pci_dma() API to pass the address of the value to access, it is simpler to have the head/tail declared as 32-bit values. Replace the uint16_t by uint32_t, wasting 4 bytes in the MegasasState structure. Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211223115554.3155328-20-phi...@redhat.com> Commit: 7ccb391ccd594b3f33de8deb293ff8d47bb4e219 https://github.com/qemu/qemu/commit/7ccb391ccd594b3f33de8deb293ff8d47bb4e219 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M include/hw/ppc/spapr_vio.h M include/sysemu/dma.h Log Message: --- dma: Let dma_memory_valid() take MemTxAttrs argument Let devices specify transaction attributes when calling dma_memory_valid(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-2-phi...@redhat.com> Commit: 7a36e42d9114474278ce30ba36945cc62292eb60 https://github.com/qemu/qemu/commit/7a36e42d9114474278ce30ba36945cc62292eb60 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/nvram/fw_cfg.c M include/hw/ppc/spapr_vio.h M include/sysemu/dma.h M softmmu/dma-helpers.c Log Message: --- dma: Let dma_memory_set() take MemTxAttrs argument Let devices specify transaction attributes when calling dma_memory_set(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-3-phi...@redhat.com> Commit: 4afd0f2f220ec3dc8518b8de0d66cbf8d2fd1be7 https://github.com/qemu/qemu/commit/4afd0f2f220ec3dc8518b8de0d66cbf8d2fd1be7 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M include/sysemu/dma.h Log Message: --- dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument We will add the MemTxAttrs argument to dma_memory_rw() in the next commit. Since dma_memory_rw_relaxed() is only used by dma_memory_rw(), modify it first in a separate commit to keep the next commit easier to review. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-4-phi...@redhat.com> Commit: 23faf5694ff8054b847e9733297727be4a641132 https://github.com/qemu/qemu/commit/23faf5694ff8054b847e9733297727be4a641132 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/intc/spapr_xive.c M hw/usb/hcd-ohci.c M include/hw/pci/pci.h M include/sysemu/dma.h M softmmu/dma-helpers.c Log Message: --- dma: Let dma_memory_rw() take MemTxAttrs argument Let devices specify transaction attributes when calling dma_memory_rw(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-5-phi...@redhat.com> Commit: ba06fe8add5b788956a7317246c6280dfc157040 https://github.com/qemu/qemu/commit/ba06fe8add5b788956a7317246c6280dfc157040 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/arm/musicpal.c M hw/arm/smmu-common.c M hw/arm/smmuv3.c M hw/core/generic-loader.c M hw/dma/pl330.c M hw/dma/sparc32_dma.c M hw/dma/xlnx-zynq-devcfg.c M hw/dma/xlnx_dpdma.c M hw/i386/amd_iommu.c M hw/i386/intel_iommu.c M hw/ide/macio.c M hw/intc/xive.c M hw/misc/bcm2835_property.c M hw/misc/macio/mac_dbdma.c M hw/net/allwinner-sun8i-emac.c M hw/net/ftgmac100.c M hw/net/imx_fec.c M hw/net/npcm7xx_emc.c M hw/nvram/fw_cfg.c M hw/pci-host/pnv_phb3.c M hw/pci-host/pnv_phb3_msi.c M hw/pci-host/pnv_phb4.c M hw/sd/allwinner-sdhost.c M hw/sd/sdhci.c M hw/usb/hcd-dwc2.c M
[Qemu-commits] [qemu/qemu] 41d5e8: hw/scsi/megasas: Use uint32_t for reply queue head...
Branch: refs/heads/staging Home: https://github.com/qemu/qemu Commit: 41d5e8da3d5e0a143a9fb397c9f34707ec544997 https://github.com/qemu/qemu/commit/41d5e8da3d5e0a143a9fb397c9f34707ec544997 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/scsi/megasas.c M hw/scsi/trace-events Log Message: --- hw/scsi/megasas: Use uint32_t for reply queue head/tail values While the reply queue values fit in 16-bit, they are accessed as 32-bit: 661:s->reply_queue_head = ldl_le_pci_dma(pcid, s->producer_pa); 662:s->reply_queue_head %= MEGASAS_MAX_FRAMES; 663:s->reply_queue_tail = ldl_le_pci_dma(pcid, s->consumer_pa); 664:s->reply_queue_tail %= MEGASAS_MAX_FRAMES; Having: 41:#define MEGASAS_MAX_FRAMES 2048 /* Firmware limit at 65535 */ In order to update the ld/st*_pci_dma() API to pass the address of the value to access, it is simpler to have the head/tail declared as 32-bit values. Replace the uint16_t by uint32_t, wasting 4 bytes in the MegasasState structure. Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211223115554.3155328-20-phi...@redhat.com> Commit: 7ccb391ccd594b3f33de8deb293ff8d47bb4e219 https://github.com/qemu/qemu/commit/7ccb391ccd594b3f33de8deb293ff8d47bb4e219 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M include/hw/ppc/spapr_vio.h M include/sysemu/dma.h Log Message: --- dma: Let dma_memory_valid() take MemTxAttrs argument Let devices specify transaction attributes when calling dma_memory_valid(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-2-phi...@redhat.com> Commit: 7a36e42d9114474278ce30ba36945cc62292eb60 https://github.com/qemu/qemu/commit/7a36e42d9114474278ce30ba36945cc62292eb60 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/nvram/fw_cfg.c M include/hw/ppc/spapr_vio.h M include/sysemu/dma.h M softmmu/dma-helpers.c Log Message: --- dma: Let dma_memory_set() take MemTxAttrs argument Let devices specify transaction attributes when calling dma_memory_set(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-3-phi...@redhat.com> Commit: 4afd0f2f220ec3dc8518b8de0d66cbf8d2fd1be7 https://github.com/qemu/qemu/commit/4afd0f2f220ec3dc8518b8de0d66cbf8d2fd1be7 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M include/sysemu/dma.h Log Message: --- dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument We will add the MemTxAttrs argument to dma_memory_rw() in the next commit. Since dma_memory_rw_relaxed() is only used by dma_memory_rw(), modify it first in a separate commit to keep the next commit easier to review. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-4-phi...@redhat.com> Commit: 23faf5694ff8054b847e9733297727be4a641132 https://github.com/qemu/qemu/commit/23faf5694ff8054b847e9733297727be4a641132 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/intc/spapr_xive.c M hw/usb/hcd-ohci.c M include/hw/pci/pci.h M include/sysemu/dma.h M softmmu/dma-helpers.c Log Message: --- dma: Let dma_memory_rw() take MemTxAttrs argument Let devices specify transaction attributes when calling dma_memory_rw(). Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Acked-by: Stefan Hajnoczi Message-Id: <20211223115554.3155328-5-phi...@redhat.com> Commit: ba06fe8add5b788956a7317246c6280dfc157040 https://github.com/qemu/qemu/commit/ba06fe8add5b788956a7317246c6280dfc157040 Author: Philippe Mathieu-Daudé Date: 2021-12-30 (Thu, 30 Dec 2021) Changed paths: M hw/arm/musicpal.c M hw/arm/smmu-common.c M hw/arm/smmuv3.c M hw/core/generic-loader.c M hw/dma/pl330.c M hw/dma/sparc32_dma.c M hw/dma/xlnx-zynq-devcfg.c M hw/dma/xlnx_dpdma.c M hw/i386/amd_iommu.c M hw/i386/intel_iommu.c M hw/ide/macio.c M hw/intc/xive.c M hw/misc/bcm2835_property.c M hw/misc/macio/mac_dbdma.c M hw/net/allwinner-sun8i-emac.c M hw/net/ftgmac100.c M hw/net/imx_fec.c M hw/net/npcm7xx_emc.c M hw/nvram/fw_cfg.c M hw/pci-host/pnv_phb3.c M hw/pci-host/pnv_phb3_msi.c M hw/pci-host/pnv_phb4.c M hw/sd/allwinner-sdhost.c M hw/sd/sdhci.c M hw/usb/hcd-dwc2.c M
[Qemu-commits] [qemu/qemu] 694804: hw/qdev: Cosmetic around documentation
Branch: refs/heads/master Home: https://github.com/qemu/qemu Commit: 694804ed7b26e66e114a2330887187d697a0d92b https://github.com/qemu/qemu/commit/694804ed7b26e66e114a2330887187d697a0d92b Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M include/hw/qdev-core.h Log Message: --- hw/qdev: Cosmetic around documentation Add empty lines to have a clearer distinction between different functions declarations. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yanan Wang Message-Id: <20211218130437.1516929-2-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé Commit: 14b0375b39f4acbd2b313a37f5fdf886b0fe74cb https://github.com/qemu/qemu/commit/14b0375b39f4acbd2b313a37f5fdf886b0fe74cb Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M include/hw/qdev-core.h Log Message: --- hw/qdev: Correct qdev_init_gpio_out_named() documentation qdev_init_gpio_out_named() is described as qdev_init_gpio_out(), and referring to itself in an endless loop, which is confusing. Fix. Reported-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yanan Wang Message-Id: <20211218130437.1516929-3-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé Commit: 1fbd004b00198fb3f27e52ce7b138b9c13288f78 https://github.com/qemu/qemu/commit/1fbd004b00198fb3f27e52ce7b138b9c13288f78 Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M include/hw/qdev-core.h Log Message: --- hw/qdev: Correct qdev_connect_gpio_out_named() documentation qdev_connect_gpio_out_named() is described as qdev_connect_gpio_out(), and referring to itself in an endless loop, which is confusing. Fix. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yanan Wang Message-Id: <20211218130437.1516929-4-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé Commit: 2ebd9ce19a324aa627c3f9b8f40285a1cf9bb0c9 https://github.com/qemu/qemu/commit/2ebd9ce19a324aa627c3f9b8f40285a1cf9bb0c9 Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M hw/core/gpio.c M include/hw/qdev-core.h Log Message: --- hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter @pin is an input where we connect a device output. Rename it @input_pin to simplify the documentation. Reviewed-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211218130437.1516929-5-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé Commit: 1ab192f30caeb7dd409fa82164ffa0df5e984a70 https://github.com/qemu/qemu/commit/1ab192f30caeb7dd409fa82164ffa0df5e984a70 Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M tests/unit/test-smp-parse.c Log Message: --- tests/unit/test-smp-parse: Pass machine type as argument to tests Use g_test_add_data_func() instead of g_test_add_func() so we can pass the machine type to the tests (we will soon have different machine types). Reviewed-by: Richard Henderson Reviewed-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211216132015.815493-2-phi...@redhat.com> Commit: c30bdb025ce04f26ad63cbaebba911cff6573a52 https://github.com/qemu/qemu/commit/c30bdb025ce04f26ad63cbaebba911cff6573a52 Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M tests/unit/test-smp-parse.c Log Message: --- tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid Split the 'generic' test in two tests: 'valid' and 'invalid'. This will allow us to remove the hack which modifies the MachineClass internal state. Reviewed-by: Richard Henderson Reviewed-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211216132015.815493-3-phi...@redhat.com> Commit: 76b6d4cce364ef841a3e2e3574322ca6d8a27414 https://github.com/qemu/qemu/commit/76b6d4cce364ef841a3e2e3574322ca6d8a27414 Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M tests/unit/test-smp-parse.c Log Message: --- tests/unit/test-smp-parse: Add 'smp-with-dies' machine type Avoid modifying the MachineClass internals by adding the 'smp-with-dies' machine, which inherits from TYPE_MACHINE. Reviewed-by: Richard Henderson Reviewed-by: Yanan Wang Tested-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20211216132015.815493-4-phi...@redhat.com> Commit: 7ca0705eba00c0d38f7b37670ee6cff9b607bb74 https://github.com/qemu/qemu/commit/7ca0705eba00c0d38f7b37670ee6cff9b607bb74 Author: Philippe Mathieu-Daudé Date: 2021-12-31 (Fri, 31 Dec 2021) Changed paths: M tests/unit/test-smp-parse.c Log Message: --- tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type Avoid modifying the MachineClass internals by adding the