Re: [PATCH 0/5] iotests: Some fixes for rarely run cases
On 17.06.20 16:19, Kevin Wolf wrote: > Am 17.06.2020 um 16:11 hat Max Reitz geschrieben: >> On 17.06.20 14:52, Kevin Wolf wrote: >>> Am 17.06.2020 um 12:48 hat Max Reitz geschrieben: Hi, Thomas’s report (https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00791.html) has given me a nice excuse to write this series. There are some iotests that have recently start to fail in rarely exercised test environments (qed, qcow2 with data_file, qcow2 v2), and this series fixes what I found. >>> >>> Thanks, applied to the block branch. >> >> Sorry, I didn’t run iotest 297 before sending this series... >> >> The problems arise in patch 1: >> >> iotests.py:1113:0: C0301: Line too long (80/79) (line-too-long) >> iotests.py:1106: error: Function is missing a return type annotation >> >> (So there’s a line with 80 characters, when 79 is the maximum (*shrug*), >> and I failed to specify skip_for_format’s return type.) >> >> I think patch 1 needs the attached diff squashed in. Are you willing to >> do that or should I just send a v2? > > I'm squashing it in. In fact, I already had fixed it, but I was too lazy > to be more specific than Callable[..., Any], so I'll replace that with > your version. I have to admit I was intrigued to see how the actual signature would turn out, so I followed it through until the biter end. :) Thanks! signature.asc Description: OpenPGP digital signature
Re: [PATCH 0/5] iotests: Some fixes for rarely run cases
Am 17.06.2020 um 16:11 hat Max Reitz geschrieben: > On 17.06.20 14:52, Kevin Wolf wrote: > > Am 17.06.2020 um 12:48 hat Max Reitz geschrieben: > >> Hi, > >> > >> Thomas’s report > >> (https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00791.html) > >> has given me a nice excuse to write this series. > >> > >> There are some iotests that have recently start to fail in rarely > >> exercised test environments (qed, qcow2 with data_file, qcow2 v2), and > >> this series fixes what I found. > > > > Thanks, applied to the block branch. > > Sorry, I didn’t run iotest 297 before sending this series... > > The problems arise in patch 1: > > iotests.py:1113:0: C0301: Line too long (80/79) (line-too-long) > iotests.py:1106: error: Function is missing a return type annotation > > (So there’s a line with 80 characters, when 79 is the maximum (*shrug*), > and I failed to specify skip_for_format’s return type.) > > I think patch 1 needs the attached diff squashed in. Are you willing to > do that or should I just send a v2? I'm squashing it in. In fact, I already had fixed it, but I was too lazy to be more specific than Callable[..., Any], so I'll replace that with your version. Kevin signature.asc Description: PGP signature
Re: [PATCH 0/5] iotests: Some fixes for rarely run cases
On 17.06.20 14:52, Kevin Wolf wrote:
> Am 17.06.2020 um 12:48 hat Max Reitz geschrieben:
>> Hi,
>>
>> Thomas’s report
>> (https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00791.html)
>> has given me a nice excuse to write this series.
>>
>> There are some iotests that have recently start to fail in rarely
>> exercised test environments (qed, qcow2 with data_file, qcow2 v2), and
>> this series fixes what I found.
>
> Thanks, applied to the block branch.
Sorry, I didn’t run iotest 297 before sending this series...
The problems arise in patch 1:
iotests.py:1113:0: C0301: Line too long (80/79) (line-too-long)
iotests.py:1106: error: Function is missing a return type annotation
(So there’s a line with 80 characters, when 79 is the maximum (*shrug*),
and I failed to specify skip_for_format’s return type.)
I think patch 1 needs the attached diff squashed in. Are you willing to
do that or should I just send a v2?
Max
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 92c08b9dc6..5ea4c4df8b 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -1103,14 +1103,17 @@ def skip_if_unsupported(required_formats=(), read_only=False):
return func_wrapper
return skip_test_decorator
-def skip_for_formats(formats: Sequence[str] = ()):
+def skip_for_formats(formats: Sequence[str] = ()) \
+-> Callable[[Callable[[QMPTestCase, List[Any], Dict[str, Any]], None]],
+Callable[[QMPTestCase, List[Any], Dict[str, Any]], None]]:
'''Skip Test Decorator
Skips the test for the given formats'''
def skip_test_decorator(func):
def func_wrapper(test_case: QMPTestCase, *args: List[Any],
**kwargs: Dict[str, Any]) -> None:
if imgfmt in formats:
-test_case.case_skip(f'{test_case}: Skipped for format {imgfmt}')
+msg = f'{test_case}: Skipped for format {imgfmt}'
+test_case.case_skip(msg)
else:
func(test_case, *args, **kwargs)
return func_wrapper
signature.asc
Description: OpenPGP digital signature
Re: [PATCH 0/5] iotests: Some fixes for rarely run cases
Am 17.06.2020 um 12:48 hat Max Reitz geschrieben: > Hi, > > Thomas’s report > (https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00791.html) > has given me a nice excuse to write this series. > > There are some iotests that have recently start to fail in rarely > exercised test environments (qed, qcow2 with data_file, qcow2 v2), and > this series fixes what I found. Thanks, applied to the block branch. Kevin
Re: [PATCH 0/5] iotests: Some fixes for rarely run cases
Patchew URL: https://patchew.org/QEMU/20200617104822.27525-1-mre...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === CC qga/main.o CC qga/commands-posix.o CC qga/channel-posix.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC qga/qapi-generated/qga-qapi-types.o CC qga/qapi-generated/qga-qapi-visit.o CC qga/qapi-generated/qga-qapi-commands.o --- GEN docs/interop/qemu-ga-ref.html GEN docs/interop/qemu-ga-ref.txt GEN docs/interop/qemu-ga-ref.7 /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-ga LINKqemu-keymap /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-client /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-server LINKqemu-nbd /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) AS pc-bios/optionrom/multiboot.o AS pc-bios/optionrom/linuxboot.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-storage-daemon CC pc-bios/optionrom/linuxboot_dma.o AS pc-bios/optionrom/kvmvapic.o LINKqemu-img /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) AS pc-bios/optionrom/pvh.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC pc-bios/optionrom/pvh_main.o BUILD pc-bios/optionrom/multiboot.img BUILD pc-bios/optionrom/linuxboot.img --- LINKqemu-edid BUILD pc-bios/optionrom/pvh.raw SIGNpc-bios/optionrom/multiboot.bin /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) SIGNpc-bios/optionrom/linuxboot.bin /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) SIGNpc-bios/optionrom/linuxboot_dma.bin LINKfsdev/virtfs-proxy-helper SIGNpc-bios/optionrom/kvmvapic.bin SIGNpc-bios/optionrom/pvh.bin LINKscsi/qemu-pr-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-bridge-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of
[PATCH 0/5] iotests: Some fixes for rarely run cases
Hi,
Thomas’s report
(https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg00791.html)
has given me a nice excuse to write this series.
There are some iotests that have recently start to fail in rarely
exercised test environments (qed, qcow2 with data_file, qcow2 v2), and
this series fixes what I found.
Max Reitz (5):
iotests.py: Add skip_for_formats() decorator
iotests/041: Skip test_small_target for qed
iotests/292: data_file is unsupported
iotests/229: data_file is unsupported
iotests/{190,291}: compat=0.10 is unsupported
tests/qemu-iotests/041| 2 ++
tests/qemu-iotests/118| 7 +++
tests/qemu-iotests/190| 2 ++
tests/qemu-iotests/229| 3 +++
tests/qemu-iotests/291| 2 ++
tests/qemu-iotests/292| 5 +
tests/qemu-iotests/iotests.py | 13 +
7 files changed, 30 insertions(+), 4 deletions(-)
--
2.26.2
