[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Wed, Jan 05, 2011 at 01:10:08PM +0200, Gleb Natapov wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Acked-by: Gleb Natapov g...@redhat.com Thanks. I committed this. -Kevin
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Sun, Dec 12, 2010 at 02:57:45PM -0500, Kevin O'Connor wrote: On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Thanks Marcelo, Can you add acked-bys from the qemu/kvm maintaners? Marcelo is kvm maintainer ;) FWIW I tested this with Windows 7 XP and it works as expected. The patch relies on patch not yes excepted to qemu though. Yeah - I know - but I figured I'd ask for concensus before committing. :-) The committing of seabios patches that have a dependency on qemu/kvm is an area that I think could be better clarified. I'm thinking that if the seabios part depends on something in qemu/kvm then we should have the corresponding kvm/qemu maintaners ack it. -Kevin Avi, are you OK with this patch ? Yes, perhaps it all (including PCI hotplug controller) should be using something else than hardcoded IO ports, but thats what we have now.
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On 12/20/2010 10:49 AM, Marcelo Tosatti wrote: On Sun, Dec 12, 2010 at 02:57:45PM -0500, Kevin O'Connor wrote: On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosattimtosa...@redhat.com Thanks Marcelo, Can you add acked-bys from the qemu/kvm maintaners? Marcelo is kvm maintainer ;) FWIW I tested this with Windows 7 XP and it works as expected. The patch relies on patch not yes excepted to qemu though. Yeah - I know - but I figured I'd ask for concensus before committing. :-) The committing of seabios patches that have a dependency on qemu/kvm is an area that I think could be better clarified. I'm thinking that if the seabios part depends on something in qemu/kvm then we should have the corresponding kvm/qemu maintaners ack it. -Kevin Avi, are you OK with this patch ? Yes, perhaps it all (including PCI hotplug controller) should be using something else than hardcoded IO ports, but thats what we have now. At least it should be documented. What's the behaviour with a qemu that doesn't support the new port? We don't strictly support it, but let's do so if we can. -- error compiling committee.c: too many arguments to function
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On 12/20/2010 07:05 PM, Marcelo Tosatti wrote: Yes, perhaps it all (including PCI hotplug controller) should be using something else than hardcoded IO ports, but thats what we have now. At least it should be documented. What's the behaviour with a qemu that doesn't support the new port? We don't strictly support it, but let's do so if we can. All slots will be marked as hotpluggable (since the removability IO port will not be registered and return all 1's). Good, so compatibility is retained. seabios will know not to allocate this address to pci bars? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Mon, Dec 20, 2010 at 11:15:40AM +0200, Avi Kivity wrote: On 12/20/2010 10:49 AM, Marcelo Tosatti wrote: On Sun, Dec 12, 2010 at 02:57:45PM -0500, Kevin O'Connor wrote: On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosattimtosa...@redhat.com Thanks Marcelo, Can you add acked-bys from the qemu/kvm maintaners? Marcelo is kvm maintainer ;) FWIW I tested this with Windows 7 XP and it works as expected. The patch relies on patch not yes excepted to qemu though. Yeah - I know - but I figured I'd ask for concensus before committing. :-) The committing of seabios patches that have a dependency on qemu/kvm is an area that I think could be better clarified. I'm thinking that if the seabios part depends on something in qemu/kvm then we should have the corresponding kvm/qemu maintaners ack it. -Kevin Avi, are you OK with this patch ? Yes, perhaps it all (including PCI hotplug controller) should be using something else than hardcoded IO ports, but thats what we have now. At least it should be documented. What's the behaviour with a qemu that doesn't support the new port? We don't strictly support it, but let's do so if we can. All slots will be marked as hotpluggable (since the removability IO port will not be registered and return all 1's).
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Mon, Dec 20, 2010 at 07:44:12PM +0200, Avi Kivity wrote: On 12/20/2010 07:05 PM, Marcelo Tosatti wrote: Yes, perhaps it all (including PCI hotplug controller) should be using something else than hardcoded IO ports, but thats what we have now. At least it should be documented. What's the behaviour with a qemu that doesn't support the new port? We don't strictly support it, but let's do so if we can. All slots will be marked as hotpluggable (since the removability IO port will not be registered and return all 1's). Good, so compatibility is retained. seabios will know not to allocate this address to pci bars? seabios starts allocating at 0xc000, which is past the hardcoded addresses. In any case, qemu will abort on registration if there are conflicts.
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? Its the next available address after PCI EJ base, used for QEMU-ACPI hotplug communication. What's the protocol? ACPI reads the 32-bit field indicating the return value of the _RMV method (which is used by Windows to decide removability). 1-bit per slot. More ports have to be registered if more buses are added. Maybe we should do this via fw_cfg. I don't see a need for it? (yes, it might be possible, but i'm not familiar enough with AML). To avoid adding tons of undocumented I/O ports, and to allow discoverability (what happens with a new seabios on old qemu)? We could do this in two ways: by adding a fwcfg client to the DSDT, or by copying the information to system memory, and referencing system memory from the DSDT. -- error compiling committee.c: too many arguments to function
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Mon, Dec 13, 2010 at 10:41:25AM +0200, Avi Kivity wrote: On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? Its the next available address after PCI EJ base, used for QEMU-ACPI hotplug communication. What's the protocol? ACPI reads the 32-bit field indicating the return value of the _RMV method (which is used by Windows to decide removability). 1-bit per slot. More ports have to be registered if more buses are added. Maybe we should do this via fw_cfg. I don't see a need for it? (yes, it might be possible, but i'm not familiar enough with AML). To avoid adding tons of undocumented I/O ports, and to allow discoverability (what happens with a new seabios on old qemu)? We already have out own mini pci hot-plug controller at io port 0xae00. The patch just extends its functionality a bit. Logically this functionality belongs there. We could do this in two ways: by adding a fwcfg client to the DSDT, or by copying the information to system memory, and referencing system memory from the DSDT. This is even worse. It requires some fixed address to be shared between DSDT and Seabios (or alternatively Seabios will have to generate this part of DSDT dynamically). -- Gleb.
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On 12/13/2010 10:49 AM, Gleb Natapov wrote: On Mon, Dec 13, 2010 at 10:41:25AM +0200, Avi Kivity wrote: On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? Its the next available address after PCI EJ base, used for QEMU-ACPI hotplug communication. What's the protocol? ACPI reads the 32-bit field indicating the return value of the _RMV method (which is used by Windows to decide removability). 1-bit per slot. More ports have to be registered if more buses are added. Maybe we should do this via fw_cfg. I don't see a need for it? (yes, it might be possible, but i'm not familiar enough with AML). To avoid adding tons of undocumented I/O ports, and to allow discoverability (what happens with a new seabios on old qemu)? We already have out own mini pci hot-plug controller at io port 0xae00. The patch just extends its functionality a bit. Logically this functionality belongs there. Well, at least it should be documented. We could also deprecate the old port and use fwcfg for everything (try fwcfg, fall back to ae00). We could do this in two ways: by adding a fwcfg client to the DSDT, or by copying the information to system memory, and referencing system memory from the DSDT. This is even worse. It requires some fixed address to be shared between DSDT and Seabios (or alternatively Seabios will have to generate this part of DSDT dynamically). Could easily be something in the F segment. -- error compiling committee.c: too many arguments to function
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Mon, Dec 13, 2010 at 10:53:07AM +0200, Avi Kivity wrote: On 12/13/2010 10:49 AM, Gleb Natapov wrote: On Mon, Dec 13, 2010 at 10:41:25AM +0200, Avi Kivity wrote: On 12/13/2010 02:00 AM, Marcelo Tosatti wrote: On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? Its the next available address after PCI EJ base, used for QEMU-ACPI hotplug communication. What's the protocol? ACPI reads the 32-bit field indicating the return value of the _RMV method (which is used by Windows to decide removability). 1-bit per slot. More ports have to be registered if more buses are added. Maybe we should do this via fw_cfg. I don't see a need for it? (yes, it might be possible, but i'm not familiar enough with AML). To avoid adding tons of undocumented I/O ports, and to allow discoverability (what happens with a new seabios on old qemu)? We already have out own mini pci hot-plug controller at io port 0xae00. The patch just extends its functionality a bit. Logically this functionality belongs there. Well, at least it should be documented. Agree. We could also deprecate the old port and use fwcfg for everything (try fwcfg, fall back to ae00). fwcfg designed to be simple for easy use by firmware. It has two port one for index another for value, so its use is racy in multi-threaded SMP environment. DSDT code is executed in such environment. There is lock facility in AML, but why complicate things. We could do this in two ways: by adding a fwcfg client to the DSDT, or by copying the information to system memory, and referencing system memory from the DSDT. This is even worse. It requires some fixed address to be shared between DSDT and Seabios (or alternatively Seabios will have to generate this part of DSDT dynamically). Could easily be something in the F segment. Yes, but then we will have two magic values (fwcfg index + address in F segment) instead of one (address of pci hot-plug controller). -- Gleb.
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On 12/13/2010 11:03 AM, Gleb Natapov wrote: We could also deprecate the old port and use fwcfg for everything (try fwcfg, fall back to ae00). fwcfg designed to be simple for easy use by firmware. It has two port one for index another for value, so its use is racy in multi-threaded SMP environment. DSDT code is executed in such environment. There is lock facility in AML, but why complicate things. I prefer to remove complexity from interfaces and have it in the implementation instead. We could do this in two ways: by adding a fwcfg client to the DSDT, or by copying the information to system memory, and referencing system memory from the DSDT. This is even worse. It requires some fixed address to be shared between DSDT and Seabios (or alternatively Seabios will have to generate this part of DSDT dynamically). Could easily be something in the F segment. Yes, but then we will have two magic values (fwcfg index + address in F segment) instead of one (address of pci hot-plug controller). The F segment address is internal to SeaBIOS; it isn't an external interface. -- error compiling committee.c: too many arguments to function
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Mon, Dec 13, 2010 at 11:10:38AM +0200, Avi Kivity wrote: On 12/13/2010 11:03 AM, Gleb Natapov wrote: We could also deprecate the old port and use fwcfg for everything (try fwcfg, fall back to ae00). fwcfg designed to be simple for easy use by firmware. It has two port one for index another for value, so its use is racy in multi-threaded SMP environment. DSDT code is executed in such environment. There is lock facility in AML, but why complicate things. I prefer to remove complexity from interfaces and have it in the implementation instead. I prefer whatever is simpler :) simpler == less bugs. And it is not like we discuss new interface here. You want to deprecate existing interface in favor of something that was not designed to handle the task. We could do this in two ways: by adding a fwcfg client to the DSDT, or by copying the information to system memory, and referencing system memory from the DSDT. This is even worse. It requires some fixed address to be shared between DSDT and Seabios (or alternatively Seabios will have to generate this part of DSDT dynamically). Could easily be something in the F segment. Yes, but then we will have two magic values (fwcfg index + address in F segment) instead of one (address of pci hot-plug controller). The F segment address is internal to SeaBIOS; it isn't an external interface. Depends on how you define external interface. It can be considered as interface between OSPM and firmware. Next time layout of F segment changes in SeaBIOS will you remember fixing DSDT too? -- Gleb.
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Thanks Marcelo, Can you add acked-bys from the qemu/kvm maintaners? -Kevin
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Thanks Marcelo, Can you add acked-bys from the qemu/kvm maintaners? Marcelo is kvm maintainer ;) FWIW I tested this with Windows 7 XP and it works as expected. The patch relies on patch not yes excepted to qemu though. -- Gleb.
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Sun, Dec 12, 2010 at 09:49:16PM +0200, Gleb Natapov wrote: On Sun, Dec 12, 2010 at 02:11:29PM -0500, Kevin O'Connor wrote: On Wed, Dec 08, 2010 at 03:08:59PM -0200, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Thanks Marcelo, Can you add acked-bys from the qemu/kvm maintaners? Marcelo is kvm maintainer ;) FWIW I tested this with Windows 7 XP and it works as expected. The patch relies on patch not yes excepted to qemu though. Yeah - I know - but I figured I'd ask for concensus before committing. :-) The committing of seabios patches that have a dependency on qemu/kvm is an area that I think could be better clarified. I'm thinking that if the seabios part depends on something in qemu/kvm then we should have the corresponding kvm/qemu maintaners ack it. -Kevin
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On Sat, Dec 11, 2010 at 09:39:30AM +0200, Avi Kivity wrote: On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? Its the next available address after PCI EJ base, used for QEMU-ACPI hotplug communication. What's the protocol? ACPI reads the 32-bit field indicating the return value of the _RMV method (which is used by Windows to decide removability). 1-bit per slot. More ports have to be registered if more buses are added. Maybe we should do this via fw_cfg. I don't see a need for it? (yes, it might be possible, but i'm not familiar enough with AML).
[Qemu-devel] Re: [SeaBIOS] seabios: acpi: add _RMV control method for PCI devices
On 12/08/2010 07:08 PM, Marcelo Tosatti wrote: Use _RMV method to indicate whether device can be removed. Data is retrieved from QEMU via I/O port 0xae0c. Where did this port come from? What's the protocol? Maybe we should do this via fw_cfg. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
