Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
27.05.2013 05:40, li guang wrote: [] NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes no sense as-is (just look at the stderr output to see what I mean) and it pretends that I suggested that! Actually I did just that, rebuild with DEBUG_DEBUGCON and looked at the output, -- because I didn't know how it works. And you're right, it's not a good change ;) But your email come before I was able to reply. Unqueued. Hi, Michael Hello. Please excuse me for the long(ish) delay, I was out of the city when you sent this email and when you pinged me on IRC. do you queued patch 1-3? if so, I will only send one patch for comments from Andreas, otherwise, I will refactor all patches. Yes I queued your patches 1-3 but not 4. It can be seen at http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next (I just rebased it again on top of current qemu/master, but your 3 patches are there). Should I replace these 3 with the next set? But as Gerd correctly say, maybe it's better to just get rid of these stuff completely, or maybe, just maybe, replace it with tracepoints. Anyway, I think the 3 queued-up patches are okay. Thanks, /mjt
Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
在 2013-05-28二的 00:42 +0400，Michael Tokarev写道： 27.05.2013 05:40, li guang wrote: [] NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes no sense as-is (just look at the stderr output to see what I mean) and it pretends that I suggested that! Actually I did just that, rebuild with DEBUG_DEBUGCON and looked at the output, -- because I didn't know how it works. And you're right, it's not a good change ;) But your email come before I was able to reply. Unqueued. Hi, Michael Hello. Please excuse me for the long(ish) delay, I was out of the city when you sent this email and when you pinged me on IRC. That's OK. do you queued patch 1-3? if so, I will only send one patch for comments from Andreas, otherwise, I will refactor all patches. Yes I queued your patches 1-3 but not 4. It can be seen at http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next (I just rebased it again on top of current qemu/master, but your 3 patches are there). Should I replace these 3 with the next set? I think you don't have to do that. I will try to do a patch base on the patches you queued as Andreas commented. But as Gerd correctly say, maybe it's better to just get rid of these stuff completely, or maybe, just maybe, replace it with tracepoints. Anyway, I think the 3 queued-up patches are okay. I will consider this comments later. Thanks!
Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
在 2013-05-25六的 14:42 +0400，Michael Tokarev写道： 25.05.2013 14:35, Andreas Färber wrote: Am 25.05.2013 11:28, schrieb Michael Tokarev: [] debugcon: use fprintf(stderr...) instead of printf The subjects and commit messages are a bit inaccurate, and as Andreas says, these may have been merged together, but the inaccuracy is small (and mostly due to language barriers), and the result is good anyway, with one patch doing one thing. So.. thanks, applied to the trivial-patches queue. NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes no sense as-is (just look at the stderr output to see what I mean) and it pretends that I suggested that! Actually I did just that, rebuild with DEBUG_DEBUGCON and looked at the output, -- because I didn't know how it works. And you're right, it's not a good change ;) But your email come before I was able to reply. Unqueued. Hi, Michael do you queued patch 1-3? if so, I will only send one patch for comments from Andreas, otherwise, I will refactor all patches. Thanks!
Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
24.05.2013 06:47, liguang wrote: when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. this patch-set based on previous 3 patches, http://comments.gmane.org/gmane.comp.emulators.qemu/212550 http://comments.gmane.org/gmane.comp.emulators.qemu/212551 http://comments.gmane.org/gmane.comp.emulators.qemu/212552 cover-letter and patch [4/4] are new, no changes for other 3. Li Guang (4) debugcon: fix always print addr=0x0, val=0x0 bug when use DEBUG_DEBUGCON debugcon: make debug message more readable debugcon: fix compiler warning when open DEBUG_DEBUGCON debugcon: use fprintf(stderr...) instead of printf The subjects and commit messages are a bit inaccurate, and as Andreas says, these may have been merged together, but the inaccuracy is small (and mostly due to language barriers), and the result is good anyway, with one patch doing one thing. So.. thanks, applied to the trivial-patches queue. /mjt
Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
Am 25.05.2013 11:28, schrieb Michael Tokarev: 24.05.2013 06:47, liguang wrote: when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. this patch-set based on previous 3 patches, http://comments.gmane.org/gmane.comp.emulators.qemu/212550 http://comments.gmane.org/gmane.comp.emulators.qemu/212551 http://comments.gmane.org/gmane.comp.emulators.qemu/212552 cover-letter and patch [4/4] are new, no changes for other 3. Li Guang (4) debugcon: fix always print addr=0x0, val=0x0 bug when use DEBUG_DEBUGCON debugcon: make debug message more readable debugcon: fix compiler warning when open DEBUG_DEBUGCON debugcon: use fprintf(stderr...) instead of printf The subjects and commit messages are a bit inaccurate, and as Andreas says, these may have been merged together, but the inaccuracy is small (and mostly due to language barriers), and the result is good anyway, with one patch doing one thing. So.. thanks, applied to the trivial-patches queue. NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes no sense as-is (just look at the stderr output to see what I mean) and it pretends that I suggested that! Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
25.05.2013 14:35, Andreas Färber wrote: Am 25.05.2013 11:28, schrieb Michael Tokarev: [] debugcon: use fprintf(stderr...) instead of printf The subjects and commit messages are a bit inaccurate, and as Andreas says, these may have been merged together, but the inaccuracy is small (and mostly due to language barriers), and the result is good anyway, with one patch doing one thing. So.. thanks, applied to the trivial-patches queue. NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes no sense as-is (just look at the stderr output to see what I mean) and it pretends that I suggested that! Actually I did just that, rebuild with DEBUG_DEBUGCON and looked at the output, -- because I didn't know how it works. And you're right, it's not a good change ;) But your email come before I was able to reply. Unqueued. Thank you for noticing this. /mjt
