[qmailadmin] Qmailadmin MySQL replication quota patch.

2002-10-23 Thread Matt Simerson
At long last.

All the known problems with qmailadmin and MySQL replication are now  
fixed. In cases where MySQL slave(s) fail replication there could be a  
race condition but fixing that requires some code additions to  
vpopmail. My patch is based on Bill's patch that fixes the MySQL  
replication issues. To that base I applied Justin Hopper's quota  
patches and adjusted the quota patches to work the same way as the rest  
of modusergo (as with Bill's updates).

The patch is at  
http://matt.simerson.net/computing/mail/toaster/qmailadmin-106- 
quotafix.txt.

The patch applies cleanly to qmailadmin-1.06. In addition to the quota  
patches, I also did a bunch of pretty work to the HTML. The most  
substantial is on the modify user page. See the jpg here:

   http://matt.simerson.net/computing/mail/toaster/qmailadmin_quota.jpg

I'd love to know what you think about it. I added some Javascript to  
that page so that users could only make mail routing choices that make  
sense. I'd appreciate if people would have a look at it and let me know  
what they think.

If everyone likes the changes, I respectfully request that the changes  
be incorporated into the qmailadmin source.

Matt

PS: I'm running this code on a production system with 50,000+ users,  
using replicated MySQL databases and the aforementioned code.


On Wednesday, October 23, 2002, at 04:21  PM, Bill Shupp wrote:

On Wednesday, October 23, 2002, at 01:20  PM, Matt Simerson wrote:


Perfect, that patch worked nicely.


Cool, thanks.  I'll start doing universal diffs from now on.

Bill







Re: [qmailadmin] Qmailadmin MySQL replication quota patch.

2002-10-23 Thread Bill Shupp
On Wednesday, October 23, 2002, at 02:34  PM, Matt Simerson wrote:


At long last.

All the known problems with qmailadmin and MySQL replication are now  
fixed. In cases where MySQL slave(s) fail replication there could be a  
race condition but fixing that requires some code additions to  
vpopmail. My patch is based on Bill's patch that fixes the MySQL  
replication issues. To that base I applied Justin Hopper's quota  
patches and adjusted the quota patches to work the same way as the  
rest of modusergo (as with Bill's updates).

The patch is at  
http://matt.simerson.net/computing/mail/toaster/qmailadmin-106- 
quotafix.txt.

The patch applies cleanly to qmailadmin-1.06. In addition to the quota  
patches, I also did a bunch of pretty work to the HTML. The most  
substantial is on the modify user page. See the jpg here:

   http://matt.simerson.net/computing/mail/toaster/qmailadmin_quota.jpg

I'd love to know what you think about it. I added some Javascript to  
that page so that users could only make mail routing choices that make  
sense. I'd appreciate if people would have a look at it and let me  
know what they think.

If everyone likes the changes, I respectfully request that the changes  
be incorporated into the qmailadmin source.

Matt

PS: I'm running this code on a production system with 50,000+ users,  
using replicated MySQL databases and the aforementioned code.

Thanks for the updated patch.  As I've mentioned (off-list) before,  
there are a few issues with this path that need to be addressed:

1. Lack of full Maildir++ support.  The only quota format available is  
in MB.  Also, getting current quota usage does dot adhere to the  
Maildir++ spec, and will need to be updated.  (currently uses a du  
style function, which is accurate, but not as efficient)
2. This patch needs to be conditional.  Many of us do not want our  
customers to have the ability to change quotas.  IMO, it should be both  
a configure option and a .qmailadmin-limits option (which is overridden  
by the configure option).

I'm happy to make these modifications, and will start on these tomorrow.

Regards,

Bill Shupp




[qmailadmin] Fwd: failure notice

2002-10-23 Thread Matt Simerson
I forgot to ask in the last email...

I've taken to modifying the qmailadmin HTML templates and adding little
[?] signs on the HTML pages with popup help screens to further explain
some of the not-so-intuitive mail choices. We're all smart folks (on
this list) and can figure out what it means but making it easier for
our end users means fewer support calls for us.

What I've done is just place the HTML files in the /images/qmailadmin/
directory and link to them from there. However, it seems like there
would be a nicer more appropriate way of doing that. If I drop the
file(s) into /usr/local/share/qmailadmin/html is there a way I can link
to that?

Matt





Re: [qmailadmin] Fwd: failure notice

2002-10-23 Thread Bill Shupp
On Wednesday, October 23, 2002, at 02:48  PM, Matt Simerson wrote:


I forgot to ask in the last email...

I've taken to modifying the qmailadmin HTML templates and adding little
[?] signs on the HTML pages with popup help screens to further explain
some of the not-so-intuitive mail choices. We're all smart folks (on
this list) and can figure out what it means but making it easier for
our end users means fewer support calls for us.

What I've done is just place the HTML files in the /images/qmailadmin/
directory and link to them from there. However, it seems like there
would be a nicer more appropriate way of doing that. If I drop the
file(s) into /usr/local/share/qmailadmin/html is there a way I can link
to that?


Not that I can think of without a symlink, or an Alias in apache.  The 
best way would be to send them from send_template.  There could be a 
help command that is dedicated to this.

Bill