Re: [Qt5-feedback] Getting rid of build keys
On 23 Aug, 2011, at 13:55 , ext Thiago Macieira wrote: On Tuesday, 23 de August de 2011 12:07:25 lars.kn...@nokia.com wrote: Hi Thiago, Full ack. I'm all for removing them. Are you willing to create the change? I suppose removing code isn't that hard... I'll do it after the QUrl changes. The build keys we could remove at any time, even after 5.0. I've started looking at removing the build-key and QSettings from plugin loading. I'm doing it in two steps, first step is to remove the build-key: http://pastebin.com/7bJmsTiT Next step will be to remove QSettings from QLibrary and QFactoryLoader. There is no replacement at the moment (i.e. no pluginspec or .desktop file), but this can always be done later. -- Bradley T. Hughes bradley.hug...@nokia.com ___ Qt5-feedback mailing list Qt5-feedback@qt.nokia.com http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
Re: [Qt5-feedback] Getting rid of build keys
On 31 Aug, 2011, at 15:04 , ext bradley.hug...@nokia.com wrote: I've started looking at removing the build-key and QSettings from plugin loading. I'm doing it in two steps, first step is to remove the build-key: http://pastebin.com/7bJmsTiT Next step will be to remove QSettings from QLibrary and QFactoryLoader. There is no replacement at the moment (i.e. no pluginspec or .desktop file), but this can always be done later. See http://pastebin.com/n9wkKXWn -- Bradley T. Hughes bradley.hug...@nokia.com ___ Qt5-feedback mailing list Qt5-feedback@qt.nokia.com http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
Re: [Qt5-feedback] Getting rid of build keys
On 8/23/11 1:55 PM, ext Thiago Macieira thi...@kde.org wrote: On Tuesday, 23 de August de 2011 12:07:25 lars.kn...@nokia.com wrote: Hi Thiago, Full ack. I'm all for removing them. Are you willing to create the change? I suppose removing code isn't that hard... I'll do it after the QUrl changes. The build keys we could remove at any time, even after 5.0. Yes, but I'm happy if this is gone for 5.0. Right! That reminds me of another implication I had thought of but forgot to write: we need a new, better and much more efficient way of finding out what is a plugin and what isn't, instead of loading everything found in the plugin directory and hoping for the best. Yes. Didn't we have some code to inspect elf headers? Could we maybe add some data into a special elf section containing the info about the plugin? That would at least solve it on elf systems. Lars ___ Qt5-feedback mailing list Qt5-feedback@qt.nokia.com http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
Re: [Qt5-feedback] Getting rid of build keys
On Tuesday, 23 de August de 2011 14:07:46 Philip Ashmore wrote: For example image file format support, you instantiate a mapping object that looks up the registry and loads the implementor for that format if it's not already loaded. What registry are you talking about? This is exactly the point that Stephen was trying to make: we need a way to detect which plugins exist and what they do, plus this should be cached somehow. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 signature.asc Description: This is a digitally signed message part. ___ Qt5-feedback mailing list Qt5-feedback@qt.nokia.com http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
Re: [Qt5-feedback] Getting rid of build keys
On Tuesday, 23 de August de 2011 14:04:19 lars.kn...@nokia.com wrote: Yes. Didn't we have some code to inspect elf headers? Could we maybe add some data into a special elf section containing the info about the plugin? That would at least solve it on elf systems. Yes, we have that code. I think 4.8 has it. But that defeats the purpose of not needing to inspect the files before attempting to load them. Between having the data next to the plugin as opposed to inside the plugin, I'd rather have it next to them. In any case: for loading of modules (QLibrary), there's nothing to be inspected. It's only for the plugin mechanism that we need something better. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 signature.asc Description: This is a digitally signed message part. ___ Qt5-feedback mailing list Qt5-feedback@qt.nokia.com http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
