Re: Request to make Wayland hard build dependency in KWin starting with Plasma 5.5

2015-08-12 Thread Martin Graesslin
On Monday, August 10, 2015 02:17:35 PM Martin Graesslin wrote:
 On Thursday, July 16, 2015 09:49:45 AM Martin Gräßlin wrote:
  Hi KDE distro packagers,
  
  we are currently (Plasma 5.4) in the awkward situation that
  plasma-workspace has a hard Wayland dependency and KWin has only an
  optional build
  dependency. After the release of Plasma 5.4 I want to change this and turn
  some optional build dependencies into hard dependencies in KWin.
 
 Given the non-negative replies to this thread I'm going ahead and change
 master to require Wayland shortly.

I just pushed the changes. There are a few changes to the original outline:
* libdrm and gbm are kept optional given that the drm backend depends on udev 
which is to my knowledge not available on non-Linux. Linux distros: please 
make sure you build with drm and gbm! Otherwise Wayland support is broken!
* X11_XCB is now a requirement for building the X11 backend. It's still 
optional but without it you won't get the X11 backend. Previous you got the 
backend, but had broken EGL support.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Request to make Wayland hard build dependency in KWin starting with Plasma 5.5

2015-08-10 Thread Martin Graesslin
On Thursday, July 16, 2015 09:49:45 AM Martin Gräßlin wrote:
 Hi KDE distro packagers,
 
 we are currently (Plasma 5.4) in the awkward situation that plasma-workspace
 has a hard Wayland dependency and KWin has only an optional build
 dependency. After the release of Plasma 5.4 I want to change this and turn
 some optional build dependencies into hard dependencies in KWin.

Given the non-negative replies to this thread I'm going ahead and change 
master to require Wayland shortly.

Cheers
Martin Gräßlin

signature.asc
Description: This is a digitally signed message part.
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Request to make Wayland hard build dependency in KWin starting with Plasma 5.5

2015-07-16 Thread Eric Hameleers

On Thu, 16 Jul 2015, Martin Gräßlin wrote:


Hi KDE distro packagers,

we are currently (Plasma 5.4) in the awkward situation that plasma-workspace
has a hard Wayland dependency and KWin has only an optional build dependency.
After the release of Plasma 5.4 I want to change this and turn some optional
build dependencies into hard dependencies in KWin.

Reasoning: over the Plasma 5.4 cycle I have pretty much only worked on Wayland
support and that has resulted in more than 100
#if HAVE_WAYLAND
...
#endif

As our CI system and most distributions only compile with Wayland support the
risk of accidental breakage increases each day. Even more it means that
running builds without this build dependency is pretty much untested. While
it's unlikely to affect kwin_x11, it is possible, nevertheless.

Given that I want to turn the following list of dependencies from optional to
required in the next development cycle:
* KF5Wayland
* Wayland::Cursor
* Wayland::Egl
* xkbcommon
* libdrm
* gbm


Speaking for Slackware, we will not move to Plasma 5 nor Wayland in 
the foreseeable future anyway. Having said that, I am the one who 
maintains the bleeding edge KDE packages for Slackware in my personal 
repository and there I do not have these restrictions - except that I 
can not make software-related decisions that would go against the 
Slackware policy (my packages always end up being part of the 
Slackware core at some point).
And I already compile Plasma 5 in the presence of Wayland, so the 
move to a hard *build-time* dependency is OK with me. as long as it 
does not become a hard *run-time* dependency.
An xkbcommon package would have to be added to my repository  as a new 
dependency but that is not an issue for me.

So, no objections from me for the hard build requirements.


The following Wayland specific dependencies would be kept optional:
* X11_XCB
* libhybris
* Libinput
* udev


Thanks for that, I am not prepared to add libinput since according to 
your erlier posts it would require logind (which we don't and won't 
include) or a logind-shim (implementations of which do not exist at 
present).
And libhybris? A library to allow the use of Android device drivers? 
Surely that will always remain optional.



I would like to ask you to try to compile kwin (as of master/5.4 branch) and
verify that you can provide the listed required packages. If your distribution
is not able to provide one please inform me ASAP about it, so that I can
evaluate how much impact it has to keep the dependency optional.

Please note that libinput and udev are only kept optional as to my knowledge
BSDs cannot provide them. Unfortunately it means that the drm backend in KWin
is not functional (doesn't support input) without this dependency.

Thank you for your collaboration.

Best Regards
Martin Gräßlin
Head of KDE Wayland porting team


Cheers, Eric

--
Eric Hameleers al...@slackware.com
Home: http://alien.slackbook.org/blog/___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Request to make Wayland hard build dependency in KWin starting with Plasma 5.5

2015-07-16 Thread Martin Gräßlin

On Thursday 16 July 2015 02:54:17 Eric Hameleers wrote:

An xkbcommon package would have to be added to my repository  as a new
dependency but that is not an issue for me.
So, no objections from me for the hard build requirements.


A small note on xkbcommon: Qt/xcb also requires it. Please make sure 
that Qt
is built with a system xkbcommon, otherwise it picks the one bundled in 
3rd-
party and that has resulted in crashes in KWin in the past if KWin is 
build

with a system xkbcommon.



 The following Wayland specific dependencies would be kept optional:
 * X11_XCB
 * libhybris
 * Libinput
 * udev

Thanks for that, I am not prepared to add libinput since according to
your erlier posts it would require logind (which we don't and won't
include) or a logind-shim (implementations of which do not exist at
present).


Please note that libinput support in KWin does not introduce any 
build-time
dependency on logind or logind-shm. It only imposes a runtime 
dependency. The
same runtime dependency is also required by the drm backend. So this 
runtime

dependency should not hinder anyone to build dep on libinput.

The logind integration is build unconditionally and also run 
unconditionally

on both x11 and wayland.

Cheers
Martin
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Request to make Wayland hard build dependency in KWin starting with Plasma 5.5

2015-07-16 Thread Martin Gräßlin

Am 2015-07-16 15:22, schrieb Eric Hameleers:

On Thu, 16 Jul 2015, Martin Gräßlin wrote:


On Thursday 16 July 2015 02:54:17 Eric Hameleers wrote:
An xkbcommon package would have to be added to my repository  as a 
new

dependency but that is not an issue for me.
So, no objections from me for the hard build requirements.


A small note on xkbcommon: Qt/xcb also requires it. Please make sure 
that Qt
is built with a system xkbcommon, otherwise it picks the one bundled 
in 3rd-
party and that has resulted in crashes in KWin in the past if KWin is 
build

with a system xkbcommon.


My Qt5 so far has been built using the 3rdparty source which is part
of the qt tarball. Once I add xkbcommon as a system package I will
have to recompile Qt5, is what you are telling?


yes


Is this a Qt5 bug that has not been addressed yet?


I'm not sure whether it counts as a bug (I have not reported one about 
it). It would certainly be nice if Qt would tell us in the build system 
that it pulled it in from 3rd-party so that we can error out in CMake. 
Apart from that there is probably not much to do. I always thought that 
it doesn't matter as distros don't like 3rd-party and will just build Qt 
against the system library ;-)


Cheers
Martin
___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


Re: Request to make Wayland hard build dependency in KWin starting with Plasma 5.5

2015-07-16 Thread Eric Hameleers

On Thu, 16 Jul 2015, Martin Gräßlin wrote:


On Thursday 16 July 2015 02:54:17 Eric Hameleers wrote:

An xkbcommon package would have to be added to my repository  as a new
dependency but that is not an issue for me.
So, no objections from me for the hard build requirements.


A small note on xkbcommon: Qt/xcb also requires it. Please make sure that Qt
is built with a system xkbcommon, otherwise it picks the one bundled in 3rd-
party and that has resulted in crashes in KWin in the past if KWin is build
with a system xkbcommon.


My Qt5 so far has been built using the 3rdparty source which is part 
of the qt tarball. Once I add xkbcommon as a system package I will 
have to recompile Qt5, is what you are telling? Is this a Qt5 bug that 
has not been addressed yet?


Cheers, Eric

--
Eric Hameleers al...@slackware.com
Home: http://alien.slackbook.org/blog/___
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team