[request-sponsor] Want to fix CR 5031620, need sponsor

[frank.hofm...@sun.com]

On Mon, 19 May 2008, Bonnie Corwin wrote:

> Hi Thomas,
>
> FYI, I will not be adding this request to the request-sponsor table
> because this isn't a program for Sun engineers.  This program provides a
> way for non-Sun OpenSolaris community members to request a sponsor for
> putbacks to consolidation gates that are inside Sun's firewall.

Hi Bonnie,

I've noticed that Thomas sent this request via his private email address, 
makes me assume this is spare time work and not directly associated to his 
day-to-day chores as a Sun employee.

Your mail seems to imply that Sun employees should not use the community 
process to contribute. Is that really so ?

I'm confused by that, on one hand there's the Sun engineer encouraged to 
be part of a community, on the other hand there's the same Sun engineer, 
in doing a community contribution, being held to different standards for 
no other reason than being a Sun engineer.

Why should Sun engineers use different processes for contributing code 
than non-Sun community members ?

Thanks for clarification on this,
FrankH.

>
> Thanks.
>
> Bonnie
>
> Dan Mick wrote:
>> I don't believe the fix is appropriate; it's unsafe to recognize
>> controllers that are not using the right self-id information.  That's why
>> those lines were added (because we know of such devices).
>>
>> Thomas Tornblom wrote:
>>> CR 5031620 has a trivial fix, removing two source lines, which if
>>> implemented allows easy addition of new and unknown ATA controllers.
>>>
>>> One might even argue that is_pciide() has a bug that is unnecessarily
>>> stopping some adapters from working.
>>>
>>> Cheers,
>>> Thomas Tornblom (Sun employee)
>>>
>>>

[request-sponsor] Shooting my mouth off

[frank.hofm...@sun.com]

On Thu, 31 Jan 2008, Avinash Joshi wrote:

> But how do we do a webrev?
> I got the workspace at cr.opensolaris.org/~avinashj

The manpage - usr/src/tools/scripts/webrev.1 - explains what you can do 
with it. Basically, you need to keep an unmodified ON sourcetree, take a 
clone of that, modify your files there, and then run webrev.

FrankH.

>
> Thanks & regards,
> Avinash Joshi
>
> On 1/31/08, Frank.Hofmann at sun.com  wrote:
>> On Thu, 31 Jan 2008, Antonello Cruz wrote:
>>
>>> James Carlson wrote:
 Seeing those submitters go to the relevant community or project
 mailing list with a proposed patch (or better yet a pointer to a
 webrev) would be greatly preferred, and if we can gently guide them
 there when they mistakenly post changes here, that'd be good.
>>> Quick question: Do the contributors have access to the tools to generate
>>> webrevs?
>>
>> If you've got a full opensolaris source tree, you'll find it in:
>>
>>  usr/src/tools/scripts/webrev.sh
>>
>> FrankH.
>> ___
>> request-sponsor mailing list
>> request-sponsor at opensolaris.org
>>
>
> -- 
> Sent from Gmail for mobile | mobile.google.com
>
> Thanks & Regards,
> Avinash Joshi
> AM106IT015
> Department of Information Technology
> Amrita School of Engineering
> Amrita Vishwa Vidyapeetham
> Amritapuri Campus
> Clappana P.O., Kollam 690 525
> Kerala, INDIA
> Ph : (+91) 98954 94427
> Blog: http://avinashtjoshi.wordpress.com/
> Site: http://avinashtjoshi.googlepages.com/
>

--
No good can come from selling your freedom, not for all the gold in the world,
for the value of this heavenly gift far exceeds that of any fortune on earth.
--

[request-sponsor] Shooting my mouth off

[frank.hofm...@sun.com]

On Thu, 31 Jan 2008, Antonello Cruz wrote:

> James Carlson wrote:
>> Seeing those submitters go to the relevant community or project
>> mailing list with a proposed patch (or better yet a pointer to a
>> webrev) would be greatly preferred, and if we can gently guide them
>> there when they mistakenly post changes here, that'd be good.
> Quick question: Do the contributors have access to the tools to generate
> webrevs?

If you've got a full opensolaris source tree, you'll find it in:

usr/src/tools/scripts/webrev.sh

FrankH.

[request-sponsor] Request for bug-6286429

[frank.hofm...@sun.com]

On Mon, 28 Jan 2008, Abhilash wrote:

> Sir,
>
> Me and arjun would like to work on bug 6286429 . We are students of  Amrita 
> University. My sca number is oso183 and arjuns is oso211.
>
> The synopsis is
>
> See comments.
> x at x  2005-06-16 02:14:58 GMT

Hmm, not quite:

typo in desctbls.c

In any case, this bug is fixed / not applicable anymore, the code in there 
has significantly changed since it was logged there's no need / no way for 
that request to go in.

Please pick another one,
Thanks,

FrankH.

[request-sponsor] bugid 6207437

[frank.hofm...@sun.com]

On Thu, 10 Jan 2008, Visakh M R wrote:

> fix attached.
>
>
> This message posted from opensolaris.org
>

Hi Visakh,

given the description of the bug, the submitter seems to mean something 
else by "merged" than "sum of either read or write". In fact, there's an 
explicit reference in the bug submission to the Linux iostat:

http://linuxreviews.org/man/iostat/

If I understand that right, then iostat on Linux allows observability down 
into driver implementation details - namely, to check whether the storage 
architecture managed to coalesce two or more different I/O requests (as 
seen from userland) into a single actual hardware/disk access.

Solaris doesn't have a metric for that, i.e. no kstat or anything that'd 
allow to measure this. Enabling the Linux' iostat rrqm/s and wrqm/s 
metrics, therefore, will, if I see it right, require more work than the 
diff you submitted.

There's another thing about the change that you've suggested - it changes 
the output format of iostat -x. One should be careful about such things, 
because there are a lot of scripts and utilities out there that rely on 
the existing format. Adding a column to the iostat output requires:
- ARC approval
- likely a new iostat flag to make this 'on demand', to prevent
  breaking existing utilities that parse iostat output

The first thing to research would be what the Linux metrics that the bug 
references actually mean, though :)


Best wishes,
FrankH.



--
No good can come from selling your freedom, not for all the gold in the world,
for the value of this heavenly gift far exceeds that of any fortune on earth.
--

[request-sponsor] Bug 6358775

[frank.hofm...@sun.com]

On Thu, 20 Dec 2007, Rishi M Nair wrote:

> Hi All
> I would like to request a sponsor for bug 6358775
> My open solaris id is rishios and SCA Number is OS0148

This one is already fixed, via:

6486456 SIMULATOR_SUPPORT should die

The bug 6358775 should be closed as dup, but there's no work to do on it.


Sorry - but thanks for highlighting :)

FrankH.

>
> Thanks & Regards
>
> Rishi
> Amrita University, Kollam
> 3rdYear BSc Computer Science
>

--
No good can come from selling your freedom, not for all the gold in the world,
for the value of this heavenly gift far exceeds that of any fortune on earth.
--

[request-sponsor] madhu...@gmail.com

[frank.hofm...@sun.com]

On Sat, 1 Dec 2007, rishi m nair wrote:

> Hi All
>
>  I would like to request a sponsor for bug 6458839
>  My open solaris id is rishios and my SCA number is OS0148
>
> Thanks & Regards
>
> Rishi
> Amrita University, Kollam
> 3rdYear BSc Computer Science

I can sponsor this for you if you like. If Madhu has already agreed, 
though, then I won't push him aside :)

Let me know,
Thx,

FrankH.

[request-sponsor] contribution

[frank.hofm...@sun.com]

On Wed, 14 Nov 2007, ashish kataria wrote:

> Want to work on bug (number 10),*CrNumber
> =*6291460
> **
> *Synopsis=too much pseudo-spelling in solaris (oss-bite-size) for 1 month
> (approx.)*

Hmm, James McPherson fixed this one:

6291454 speeling of pseudo is rong inside ON

a few years back - could be that it's an oversight 6291460 is still open.
cc:'ing James, he should be able to help you there.

FrankH.