creating multiple review requests for changes in one file
Hi, I am wondering how you handle changes in the same file which don't really fit into the same review request. So you would have a change for which you create a review request. Then you change other things in the same file and would like to create a review request for these changes only. Is it necessary to create branches for each of the changes, wait until the review is complete, commit changes and then merge branches into trunk? Thank, Tino --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cannot enter text in popups
That's EXACTLY how it behaves here... Ubuntu is debian-based, right?... hmmm... Anyways, it should just be noted that the problem exists in IE7 and Gnome. I haven't tested it with FF... On 29 Dec., 19:06, plumpy plu...@gmail.com wrote: I have this issue on Ubuntu 8.10. The review dialog pops up like normal and I can click into the various text entry fields, but I can't enter text into any of them. (I can, however, check/uncheck the Ship It checkbox.) On Dec 29, 4:32 am, Ibmurai j...@dansupport.dk wrote: Hi, I've set review-board up on a Debian linux. After about 10 hours of hammering I finally got it working somewhat. The only problem is that I cannot enter text in text-fields in dialogs: * I cannot enter a caption in the Submit screenshot dialog, and therefore I cannot submit a screenshot. * I cannot enter text in the review dialog... Does anyone know what might be wrong? There's no errors in apache's error-log...- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Get the latest diff from command line using ReviewBoard API
Hi,
You can get the latest diff by accessing /r/{review_request_id}/diff/raw/
You can also use /r/{review_request_id}/diff/{diff_revision}/raw/ to get a
specific revision.
I don't know that we have anything for retrieving the number of revisions
from the API yet, though.
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Mon, Dec 29, 2008 at 3:21 PM, Jothiram jothira...@gmail.com wrote:
Hello Everyone,
I'm running review board on Linux (with SVN) and wondering whether,
through any Review Board API, is it possible to get the latest diff
patch from a review.
Also, a review can have more than one diff updated in it. Is it
possible to find the the number of uploaded diffs and to get each
specific uploaded diff.
Thank you very much.
Jothiram
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: New Review UI
This indicates your Djblets is out of date. Try to upgrade this and clear the server cache. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 1:41 PM, ScottingItUp scottingi...@gmail.comwrote: Firebug is showing errors on: editable.inlineEditor is not a function https://reviewboard.brandassetdigital.com/media/rb/js/reviews.js Line 1135 on the review page and that error + $(div/).attr(id, review-form).appendTo(body).html (formHTML).modalBox is not a function https://reviewboard.brandassetdigital.com/media/rb/js/reviews.js Line 805 on the view diff page Entire VM box running review board was restarted. On Dec 28, 3:19 am, Christian Hammond chip...@chipx86.com wrote: Hi everyone. I've committed the new review UI earlier today and posted a news update going over the major changes. It's available at: http://www.review-board.org/news/2008/12/28/new-review-ui/ It's really important to make sure you restart/clear your server-side cache after upgrading or the diff viewer won't work correctly! And please let me know if you run into any major issues. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cannot enter text in popups
I'm not able to reproduce this, but I'll look into it further. Possibly a dumb question, but did you restart the server after grabbing the 20081229 build? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 11:01 PM, Ibmurai j...@dansupport.dk wrote: Sorry, I WAS missing something, namely -U # easy_install -U Djblets This gave me the 20081229 build. I cleared the browser cache, closed the browser and rebooted the whole server. The problem persists :( On 30 Dec., 07:50, Ibmurai j...@dansupport.dk wrote: Neat! :) I AM using an older one, but when I try to update, this happens: # easy_install Djblets Searching for Djblets Best match: Djblets 0.4.dev-20081228 Processing Djblets-0.4.dev_20081228-py2.5.egg Djblets 0.4.dev-20081228 is already the active version in easy- install.pth Using /usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081228- py2.5.egg Processing dependencies for Djblets Finished processing dependencies for Djblets As you can see, I still get the version from the 28th... Is there something I don't know here? I'm really new to this :) On 30 Dec., 07:30, Christian Hammond chip...@chipx86.com wrote: Make sure you're using an up-to-date Djblets. If you're using one older than last night's nightly, this will happen. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 9:16 PM, Ibmurai j...@dansupport.dk wrote: That's EXACTLY how it behaves here... Ubuntu is debian-based, right?... hmmm... Anyways, it should just be noted that the problem exists in IE7 and Gnome. I haven't tested it with FF... On 29 Dec., 19:06, plumpy plu...@gmail.com wrote: I have this issue on Ubuntu 8.10. The review dialog pops up like normal and I can click into the various text entry fields, but I can't enter text into any of them. (I can, however, check/uncheck the Ship It checkbox.) On Dec 29, 4:32 am, Ibmurai j...@dansupport.dk wrote: Hi, I've set review-board up on a Debian linux. After about 10 hours of hammering I finally got it working somewhat. The only problem is that I cannot enter text in text-fields in dialogs: * I cannot enter a caption in the Submit screenshot dialog, and therefore I cannot submit a screenshot. * I cannot enter text in the review dialog... Does anyone know what might be wrong? There's no errors in apache's error-log...- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cannot enter text in popups
Yes, I did a: # reboot On 30 Dec., 08:08, Christian Hammond chip...@chipx86.com wrote: I'm not able to reproduce this, but I'll look into it further. Possibly a dumb question, but did you restart the server after grabbing the 20081229 build? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 11:01 PM, Ibmurai j...@dansupport.dk wrote: Sorry, I WAS missing something, namely -U # easy_install -U Djblets This gave me the 20081229 build. I cleared the browser cache, closed the browser and rebooted the whole server. The problem persists :( On 30 Dec., 07:50, Ibmurai j...@dansupport.dk wrote: Neat! :) I AM using an older one, but when I try to update, this happens: # easy_install Djblets Searching for Djblets Best match: Djblets 0.4.dev-20081228 Processing Djblets-0.4.dev_20081228-py2.5.egg Djblets 0.4.dev-20081228 is already the active version in easy- install.pth Using /usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081228- py2.5.egg Processing dependencies for Djblets Finished processing dependencies for Djblets As you can see, I still get the version from the 28th... Is there something I don't know here? I'm really new to this :) On 30 Dec., 07:30, Christian Hammond chip...@chipx86.com wrote: Make sure you're using an up-to-date Djblets. If you're using one older than last night's nightly, this will happen. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 9:16 PM, Ibmurai j...@dansupport.dk wrote: That's EXACTLY how it behaves here... Ubuntu is debian-based, right?... hmmm... Anyways, it should just be noted that the problem exists in IE7 and Gnome. I haven't tested it with FF... On 29 Dec., 19:06, plumpy plu...@gmail.com wrote: I have this issue on Ubuntu 8.10. The review dialog pops up like normal and I can click into the various text entry fields, but I can't enter text into any of them. (I can, however, check/uncheck the Ship It checkbox.) On Dec 29, 4:32 am, Ibmurai j...@dansupport.dk wrote: Hi, I've set review-board up on a Debian linux. After about 10 hours of hammering I finally got it working somewhat. The only problem is that I cannot enter text in text-fields in dialogs: * I cannot enter a caption in the Submit screenshot dialog, and therefore I cannot submit a screenshot. * I cannot enter text in the review dialog... Does anyone know what might be wrong? There's no errors in apache's error-log...- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cannot enter text in popups
Ah, well, that should do it then ;) I'll look into this more and report back. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 11:17 PM, Ibmurai j...@dansupport.dk wrote: Yes, I did a: # reboot On 30 Dec., 08:08, Christian Hammond chip...@chipx86.com wrote: I'm not able to reproduce this, but I'll look into it further. Possibly a dumb question, but did you restart the server after grabbing the 20081229 build? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 11:01 PM, Ibmurai j...@dansupport.dk wrote: Sorry, I WAS missing something, namely -U # easy_install -U Djblets This gave me the 20081229 build. I cleared the browser cache, closed the browser and rebooted the whole server. The problem persists :( On 30 Dec., 07:50, Ibmurai j...@dansupport.dk wrote: Neat! :) I AM using an older one, but when I try to update, this happens: # easy_install Djblets Searching for Djblets Best match: Djblets 0.4.dev-20081228 Processing Djblets-0.4.dev_20081228-py2.5.egg Djblets 0.4.dev-20081228 is already the active version in easy- install.pth Using /usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081228- py2.5.egg Processing dependencies for Djblets Finished processing dependencies for Djblets As you can see, I still get the version from the 28th... Is there something I don't know here? I'm really new to this :) On 30 Dec., 07:30, Christian Hammond chip...@chipx86.com wrote: Make sure you're using an up-to-date Djblets. If you're using one older than last night's nightly, this will happen. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Dec 29, 2008 at 9:16 PM, Ibmurai j...@dansupport.dk wrote: That's EXACTLY how it behaves here... Ubuntu is debian-based, right?... hmmm... Anyways, it should just be noted that the problem exists in IE7 and Gnome. I haven't tested it with FF... On 29 Dec., 19:06, plumpy plu...@gmail.com wrote: I have this issue on Ubuntu 8.10. The review dialog pops up like normal and I can click into the various text entry fields, but I can't enter text into any of them. (I can, however, check/uncheck the Ship It checkbox.) On Dec 29, 4:32 am, Ibmurai j...@dansupport.dk wrote: Hi, I've set review-board up on a Debian linux. After about 10 hours of hammering I finally got it working somewhat. The only problem is that I cannot enter text in text-fields in dialogs: * I cannot enter a caption in the Submit screenshot dialog, and therefore I cannot submit a screenshot. * I cannot enter text in the review dialog... Does anyone know what might be wrong? There's no errors in apache's error-log...- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn -- Skjul tekst i anførselstegn - - Vis tekst i anførselstegn - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cannot enter text in popups
Alright, so this works perfectly fine in my copy of Djblets. It's possible
that the change didn't make the last nightly (even though it certainly
should have). If that's the case, just wait another half hour or so. The
next nightly should spin and 20081230 should fix it.
A couple more things to verify though:
1) Are you using rb-site to install/maintain the site? If so, did you do
rb-site upgrade /path/to/site?
2) Does clearing the browser cache help?
3) If the above two are not the problem, open up
/path/to/site/htdocs/media/djblets/js/jquery.gravy.js and see what's on line
588. It should be:
.keydown(function(e) { e.stopPropagation(); });
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Mon, Dec 29, 2008 at 11:19 PM, Christian Hammond chip...@chipx86.comwrote:
Ah, well, that should do it then ;)
I'll look into this more and report back.
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Mon, Dec 29, 2008 at 11:17 PM, Ibmurai j...@dansupport.dk wrote:
Yes, I did a:
# reboot
On 30 Dec., 08:08, Christian Hammond chip...@chipx86.com wrote:
I'm not able to reproduce this, but I'll look into it further.
Possibly a dumb question, but did you restart the server after grabbing
the
20081229 build?
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Mon, Dec 29, 2008 at 11:01 PM, Ibmurai j...@dansupport.dk wrote:
Sorry, I WAS missing something, namely -U
# easy_install -U Djblets
This gave me the 20081229 build.
I cleared the browser cache, closed the browser and rebooted the whole
server.
The problem persists :(
On 30 Dec., 07:50, Ibmurai j...@dansupport.dk wrote:
Neat! :)
I AM using an older one, but when I try to update, this happens:
# easy_install Djblets
Searching for Djblets
Best match: Djblets 0.4.dev-20081228
Processing Djblets-0.4.dev_20081228-py2.5.egg
Djblets 0.4.dev-20081228 is already the active version in easy-
install.pth
Using /usr/lib/python2.5/site-packages/Djblets-0.4.dev_20081228-
py2.5.egg
Processing dependencies for Djblets
Finished processing dependencies for Djblets
As you can see, I still get the version from the 28th...
Is there something I don't know here? I'm really new to this :)
On 30 Dec., 07:30, Christian Hammond chip...@chipx86.com wrote:
Make sure you're using an up-to-date Djblets. If you're using one
older
than
last night's nightly, this will happen.
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Mon, Dec 29, 2008 at 9:16 PM, Ibmurai j...@dansupport.dk
wrote:
That's EXACTLY how it behaves here... Ubuntu is debian-based,
right?... hmmm...
Anyways, it should just be noted that the problem exists in IE7
and
Gnome. I haven't tested it with FF...
On 29 Dec., 19:06, plumpy plu...@gmail.com wrote:
I have this issue on Ubuntu 8.10. The review dialog pops up
like
normal and I can click into the various text entry fields, but
I
can't
enter text into any of them. (I can, however, check/uncheck
the
Ship
It checkbox.)
On Dec 29, 4:32 am, Ibmurai j...@dansupport.dk wrote:
Hi,
I've set review-board up on a Debian linux. After about 10
hours
of
hammering I finally got it working somewhat.
The only problem is that I cannot enter text in text-fields
in
dialogs:
* I cannot enter a caption in the Submit screenshot
dialog, and
therefore I cannot submit a screenshot.
* I cannot enter text in the review dialog...
Does anyone know what might be wrong? There's no errors in
apache's
error-log...- Skjul tekst i anførselstegn -
- Vis tekst i anførselstegn -- Skjul tekst i anførselstegn -
- Vis tekst i anførselstegn -- Skjul tekst i anførselstegn -
- Vis tekst i anførselstegn -- Skjul tekst i anførselstegn -
- Vis tekst i anførselstegn -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
