Publishing a review request by a user other than the submitter

2012-05-09 Thread hanen ben elarbi
Hi,
It seems that only  the submitter can publish a review request !!
Even if we grant the permission to change review request the reviewer
cant publish it.
is there any alternative to make other reviewers make this ?
thx,

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Suppressing Description Change in Review Request Changed

2012-05-09 Thread Jeff Gutierrez
Hello!

We have hook in Mercurial that submits or updates a review request on
changegroup event (similar to post commit hook in SVN.) The change
requests are keyed off of JIRA tickets numbers. Here's the format:
JIRA-TICKET-123 JIRA ticket summary/title here (mercurial repo name.)
We also automatically update the review request description with the
commit comments.

Since the reviews requests are per ticket, we see a fair amount of
code changes submitted per review request. Due to this, a review
request page gets cluttered with change notification when diffs are
uploaded. The reason is the description FROM and TO parts get getting
too long and are eating up the screen real estate.

Does anybody know if there's a way to suppresses the description
change FROM and TO from showing up in the review?

Here's a example of a review request change:

sample
Review request changed
Updated 18 hours, 37 minutes ago (May 8th, 2012, 2:39 p.m.)
Diff
  added Diff r2

Description
Changed from:
(17076c4a0588) JIRA-123 Commit comment here (John Doe/2012-05-08 14:07
-0500)

Changed to:
(17076c4a0588) JIRA-123 Commit comment here (John Doe/2012-05-08 14:07
-0500)
---
(ff595b0dd8b2) BO-9762 More commit comments here  (John Doe/2012-05-08
14:37 -0500)
/sample

I'd appreciate any information.

Thanks,
Jeff

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


/r in diff files

2012-05-09 Thread Jean-Noel Meneghetti
Hi,

Python version: 2.5
RBtools version: 0.4.1
reviewboard version: 1.6.6

I have the following error when I upload a diff file generated by 
reviewboard:
 
The patch to '//mypath/Annotations.xml' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.fe-Ge_' for debugging purposes. 
`patch` returned: patching file /tmp/reviewboard.fe-Ge_/tmpAKbuGL Hunk #1 
FAILED at 55. 1 out of 1 hunk FAILED -- saving rejects to file 
/tmp/reviewboard.fe-Ge_/tmpAKbuGL-new.rej missing header for unified diff 
at line 29 of patch can't find file to patch at input line 29 Perhaps you 
should have used the -p or --strip option? The text leading up to this was: 
-- | /Table | | Table 
TableName=JobModifiedEntity | |- Bidirectional UpQuery=WHERE 1=0 
DownQuery=WHERE 1=1 / | |+ Bidirectional UpQuery='WHERE 
ReplicationState == Satellite' DownQuery='WHERE ReplicationState != 
Satellite' / | | /Table | | Table 
TableName=ActivatedKeyGroupPermission | | Down / | 
-- File to patch: Skip this patch? [y] Skipping 
patch. patch:  malformed patch at line 36: 

Traceback (most recent call last):
  File 
/usr/lib/python2.5/site-packages/ReviewBoard-1.6.6-py2.5.egg/reviewboard/diffviewer/views.py,
 line 151, in view_diff
interdiffset, highlighting, True)
  File 
/usr/lib/python2.5/site-packages/ReviewBoard-1.6.6-py2.5.egg/reviewboard/diffviewer/diffutils.py,
 line 1072, in get_diff_files
large_data=True)
  File 
/usr/lib/python2.5/site-packages/Djblets-0.6.16-py2.5.egg/djblets/util/misc.py,
 line 157, in cache_memoize
data = lookup_callable()
  File 
/usr/lib/python2.5/site-packages/ReviewBoard-1.6.6-py2.5.egg/reviewboard/diffviewer/diffutils.py,
 line 1071, in lambda
enable_syntax_highlighting)),
  File 
/usr/lib/python2.5/site-packages/ReviewBoard-1.6.6-py2.5.egg/reviewboard/diffviewer/diffutils.py,
 line 553, in get_chunks
new = get_patched_file(old, filediff)
  File 
/usr/lib/python2.5/site-packages/ReviewBoard-1.6.6-py2.5.egg/reviewboard/diffviewer/diffutils.py,
 line 375, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
  File 
/usr/lib/python2.5/site-packages/ReviewBoard-1.6.6-py2.5.egg/reviewboard/diffviewer/diffutils.py,
 line 243, in patch
(filename, tempdir, patch_output))
Exception: The patch to '//mypath/Annotations.xml' didn't apply cleanly. The 
temporary files have been left in '/tmp/reviewboard.fe-Ge_' for debugging 
purposes.
`patch` returned: patching file /tmp/reviewboard.fe-Ge_/tmpAKbuGL
Hunk #1 FAILED at 55.
1 out of 1 hunk FAILED -- saving rejects to file 
/tmp/reviewboard.fe-Ge_/tmpAKbuGL-new.rej
missing header for unified diff at line 29 of patch
can't find file to patch at input line 29
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--
| /Table
|
| Table TableName=JobModifiedEntity
|
|-  Bidirectional UpQuery=WHERE 1=0 DownQuery=WHERE 1=1 /
|
|+  Bidirectional UpQuery='WHERE ReplicationState == Satellite' 
DownQuery='WHERE ReplicationState != Satellite' /
|
| /Table
|
| Table TableName=ActivatedKeyGroupPermission
|
|   Down /
|
--
File to patch: 
Skip this patch? [y] 
Skipping patch.
patch:  malformed patch at line 36: 



 

the diff files contains /r/r/n at the end of every lines.

however, if I remove the /r manually, the diff files are processed 
correctly. 

I joined a working and a not working file example. 
Is there anything I can do against such issue?

Best regards,
Jean-Noël

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en--- //mypath/Annotations.xml	//mypath/Annotations.xml#14
+++ //mypath/Annotations.xml	2012-05-09 12:13:05
@@ -55,10 +55,10 @@

   Down /

 /Table

 Table TableName=Job

-  Bidirectional UpQuery=WHERE 1=0 DownQuery=WHERE 1=1 /

+  Bidirectional UpQuery='WHERE ReplicationState == Example' DownQuery='WHERE ReplicationState != Example' /

 /Table

 Table TableName=JobModifiedEntity

-  Bidirectional UpQuery=WHERE 1=0 DownQuery=WHERE 1=1 /

+  Bidirectional UpQuery='WHERE ReplicationState == Example' DownQuery='WHERE ReplicationState != Example' /

 /Table

 Table TableName=ActivatedKeyGroupPermission

   Down /
--- //mypath/Annotations.xml	//mypath/Annotations.xml#14
+++ //mypath/Annotations.xml	2012-05-09 14:06:12
@@ -55,10 +55,10 @@
   Down /
 /Table
 Table TableName=Job
-  Bidirectional UpQuery=WHERE 1=0 DownQuery=WHERE 1=1 /
+  Bidirectional UpQuery='WHERE ReplicationState == Example' DownQuery='WHERE ReplicationState != Example' /
 /Table
 Table TableName=JobModifiedEntity
-  Bidirectional UpQuery=WHERE 1=0 DownQuery=WHERE 1=1 /
+  

Do you have any plan for including localization file in your project?

2012-05-09 Thread Po-Chien Lin
I'm a Reviewboard user in Chinese environment.

I create a django.po (and django.mo) file under the 
reviewboard/locale/zh_TW/LC_MESSAGES/ directory,
so that our work team can use the Reviewboard in Chinese happier :-D

Reviewboard has many specific terminology that are not supported by the 
original Django localization library,
so I think it's a good idea to maintain a Reviewboard-specific localization 
library.

Do you have any plans about create a locale/ directory under the 
Reviewboard project,
collect (accept user's submit) different language files in it, and the 
release tarball will have localization support!

Thanks for taking time to read this,

Sincerely,
linpc

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-05-09 Thread reviewboard


Comment #7 on issue 2555 by mailsw...@gmail.com: On a https Mercurial URL,  
a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

In which file? Which line number?

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.