Re: P4PythonInstaller issue on Ubuntu 11.10
Hi, Sorry for the long delay. Was quite busy.. Anyway I've tried the modified P4PythonInstaller in my Ubuntu 11.10, and it seems to be working fine for me. (I'm ignoring several warnings that occurred on during compilation) Here is diff of setup.py: --- ./setup.py 2009-07-30 18:02:38.0 +0900 +++ ../setup.py 2012-07-06 13:14:44.377499927 +0900 @@ -98,7 +98,7 @@ if osname == Linux: linuxver = platform.release() -if linuxver.startswith(2.6): +if linuxver.startswith(2.6) or linuxver.startswith(3.0): osname = linux26 elif linuxver.startswith(2.4): osname = linux24 Thanks, Izeki -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: P4PythonInstaller issue on Ubuntu 11.10
Thanks. I've made the change upstream. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 3:56 AM, yIzeki __ y.iz...@gmail.com wrote: Hi, Sorry for the long delay. Was quite busy.. Anyway I've tried the modified P4PythonInstaller in my Ubuntu 11.10, and it seems to be working fine for me. (I'm ignoring several warnings that occurred on during compilation) Here is diff of setup.py: --- ./setup.py 2009-07-30 18:02:38.0 +0900 +++ ../setup.py 2012-07-06 13:14:44.377499927 +0900 @@ -98,7 +98,7 @@ if osname == Linux: linuxver = platform.release() -if linuxver.startswith(2.6): +if linuxver.startswith(2.6) or linuxver.startswith(3.0): osname = linux26 elif linuxver.startswith(2.4): osname = linux24 Thanks, Izeki -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6.10 released
We upgraded from 1.6.3 to 1.6.10, everything looks good. Except the Authentication Settings page only shows Standard Reg and Legacy, no LDAP, AD, or others. Is there something I'm misssing. THanks. Phil On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote: Hey everyone, We just released Review Board 1.6.10, which, amongst other things, is a pretty speedy release. A lot of work went into this release to drastically speed up nearly every page. There's more to do, but the improvement should be noticeable. Given the extensive changes that happened under the hood for this, we'd be very interested in knowing if you hit any problems. There are some other great little improvements and fixes. See http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for more information. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Reviewer to close review request
Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is done seems superfluous. Thanks! -Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6.10 released
Did you upgrade using pip or easy_install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:40 PM, Phil Hom phil...@gmail.com wrote: We upgraded from 1.6.3 to 1.6.10, everything looks good. Except the Authentication Settings page only shows Standard Reg and Legacy, no LDAP, AD, or others. Is there something I'm misssing. THanks. Phil On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote: Hey everyone, We just released Review Board 1.6.10, which, amongst other things, is a pretty speedy release. A lot of work went into this release to drastically speed up nearly every page. There's more to do, but the improvement should be noticeable. Given the extensive changes that happened under the hood for this, we'd be very interested in knowing if you hit any problems. There are some other great little improvements and fixes. See http://www.reviewboard.org/**news/2012/07/22/review-board-** 1610-released/http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for more information. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewer to close review request
Yep, there's a Can Change Status permission you can set on a user that will allow them to do just that. Is it not the owner that's committing the code? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:53 PM, Peter Konneker pkonne...@wahoo.comwrote: Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is done seems superfluous. Thanks! -Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewer to close review request
Okay. I tried playing with that, but will have to try again. :) So we have a post-commit hook running that is posting the review request, then we want the reviewer to be able to come in, look at the code and close it out. So the owner pushes up the code, then the review request is pushed up automatically. So hopefully we can get it working. Not too much trouble even if we can't, though. Thanks! -Peter On Wed, Jul 25, 2012 at 2:06 PM, Christian Hammond chip...@chipx86.comwrote: Yep, there's a Can Change Status permission you can set on a user that will allow them to do just that. Is it not the owner that's committing the code? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:53 PM, Peter Konneker pkonne...@wahoo.comwrote: Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is done seems superfluous. Thanks! -Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re : Reviewer to close review request
Edit review request is the permission you are looking for. Envoyé depuis mon Xperia™ S Message original Objet : Reviewer to close review request De : Peter Konneker pkonne...@wahoo.com À : reviewboard@googlegroups.com Cc : Is there a permission that can be set on a user to allow them to close a review request that they are reviewing (instead of just the owner)? We are trying to implement reviews with as little impact on work flow as possible, so making the owner go back and close the request after the review is done seems superfluous. Thanks! -Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6.10 released
We grabed the gzips from the releases directory and created RPMs for DJblets 0.6.21 and reviewboard 1.6.10, then installed the RPMs, then ran rb-site upgrade. We used RPMs before for 1.6.3, so continued doing it this way just in case we need to back out. On Wednesday, July 25, 2012 1:05:27 PM UTC-7, Christian Hammond wrote: Did you upgrade using pip or easy_install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:40 PM, Phil Hom phil...@gmail.com wrote: We upgraded from 1.6.3 to 1.6.10, everything looks good. Except the Authentication Settings page only shows Standard Reg and Legacy, no LDAP, AD, or others. Is there something I'm misssing. THanks. Phil On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote: Hey everyone, We just released Review Board 1.6.10, which, amongst other things, is a pretty speedy release. A lot of work went into this release to drastically speed up nearly every page. There's more to do, but the improvement should be noticeable. Given the extensive changes that happened under the hood for this, we'd be very interested in knowing if you hit any problems. There are some other great little improvements and fixes. See http://www.reviewboard.org/**news/2012/07/22/review-board-** 1610-released/http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for more information. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6.10 released
We make use of setuptools-provided Python Entrypoints, which register some scannable bits of data for things like authentication modules. It sounds like those registrations got lost somehow in your packaging. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 1:30 PM, Phil Hom phil...@gmail.com wrote: We grabed the gzips from the releases directory and created RPMs for DJblets 0.6.21 and reviewboard 1.6.10, then installed the RPMs, then ran rb-site upgrade. We used RPMs before for 1.6.3, so continued doing it this way just in case we need to back out. On Wednesday, July 25, 2012 1:05:27 PM UTC-7, Christian Hammond wrote: Did you upgrade using pip or easy_install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:40 PM, Phil Hom phil...@gmail.com wrote: We upgraded from 1.6.3 to 1.6.10, everything looks good. Except the Authentication Settings page only shows Standard Reg and Legacy, no LDAP, AD, or others. Is there something I'm misssing. THanks. Phil On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote: Hey everyone, We just released Review Board 1.6.10, which, amongst other things, is a pretty speedy release. A lot of work went into this release to drastically speed up nearly every page. There's more to do, but the improvement should be noticeable. Given the extensive changes that happened under the hood for this, we'd be very interested in knowing if you hit any problems. There are some other great little improvements and fixes. See http://www.reviewboard.org/**new**s/2012/07/22/review-board-**1610** -released/http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for more information. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6.10 released
The problem turned out to be the RPM spec file for reviewboard listed Djblets 0.6.20, while we upgraded to 0.6.21. There were auth module errors in the reviewboard log. This has been fixed by re-rolling the reviewboard RPM. Thanks for your help. Phil On Wednesday, July 25, 2012 2:00:36 PM UTC-7, Christian Hammond wrote: We make use of setuptools-provided Python Entrypoints, which register some scannable bits of data for things like authentication modules. It sounds like those registrations got lost somehow in your packaging. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 1:30 PM, Phil Hom phil...@gmail.com wrote: We grabed the gzips from the releases directory and created RPMs for DJblets 0.6.21 and reviewboard 1.6.10, then installed the RPMs, then ran rb-site upgrade. We used RPMs before for 1.6.3, so continued doing it this way just in case we need to back out. On Wednesday, July 25, 2012 1:05:27 PM UTC-7, Christian Hammond wrote: Did you upgrade using pip or easy_install? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 25, 2012 at 12:40 PM, Phil Hom phil...@gmail.com wrote: We upgraded from 1.6.3 to 1.6.10, everything looks good. Except the Authentication Settings page only shows Standard Reg and Legacy, no LDAP, AD, or others. Is there something I'm misssing. THanks. Phil On Sunday, July 22, 2012 1:20:30 AM UTC-7, Christian Hammond wrote: Hey everyone, We just released Review Board 1.6.10, which, amongst other things, is a pretty speedy release. A lot of work went into this release to drastically speed up nearly every page. There's more to do, but the improvement should be noticeable. Given the extensive changes that happened under the hood for this, we'd be very interested in knowing if you hit any problems. There are some other great little improvements and fixes. See http://www.reviewboard.org/**new**s/2012/07/22/review-board-**1610** -released/http://www.reviewboard.org/news/2012/07/22/review-board-1610-released/for more information. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 2681 in reviewboard: Can not edit newly created review request
Comment #5 on issue 2681 by ex...@dps-online.de: Can not edit newly created review request http://code.google.com/p/reviewboard/issues/detail?id=2681 I upgraded Djblets and it worked fine. Thanks for the quick help. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2681 in reviewboard: Can not edit newly created review request
Comment #6 on issue 2681 by kofem...@gmail.com: Can not edit newly created review request http://code.google.com/p/reviewboard/issues/detail?id=2681 works for me as well -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2678 in reviewboard: making the review item Fixed does not do anything
Comment #3 on issue 2678 by trowb...@gmail.com: making the review item Fixed does not do anything http://code.google.com/p/reviewboard/issues/detail?id=2678 Can you check the javascript console in the browser to see if there are any errors? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2683 in reviewboard: Line breaks in comments are removed when the comment is displayed in IE
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2683 by acidh...@gmail.com: Line breaks in comments are removed when the comment is displayed in IE http://code.google.com/p/reviewboard/issues/detail?id=2683 What version are you running? 1.6.9. It also happens in 1.7.0 alpha 0 What's the URL of the page containing the problem? http://demo.reviewboard.org/r/9523/ What steps will reproduce the problem? 1. Type a review comment that has multiple lines. 2. Save the review and reload the page. 3. Click Edit Review at the top of the page. What is the expected output? What do you see instead? Expected: The comment has the same formatting as when I saved it. Actual: Line breaks are removed. When I publish the review, the line breaks are there, so this looks like just a display issue. What operating system are you using? What browser? The bug happens in IE 9.0.8112.16421 on Win 7. It does not happen in Firefox 3.6.28 or Chrome 20.0.1132.57. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2684 in reviewboard: comments are shown out-of-order
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2684 by vlov...@gmail.com: comments are shown out-of-order http://code.google.com/p/reviewboard/issues/detail?id=2684 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6.10 What's the URL of the page containing the problem? What steps will reproduce the problem? Best guess is as follows: 1. User A posts multiple comments for review 2. User B starts writing responses 3. User C publishes a reply to comments 4. User B publishes comments (or updates page publishes) Although I think I've seen the order screwed up even publishing a mutli-comment reply with step 3 omitted. Basically not sure what actually causes this. What is the expected output? What do you see instead? Expected output is that replies are shown in the chronological order they were submitted. There doesn't appear to be any order to the comments. This is a really critical bug as reviews become impossible to follow. What operating system are you using? What browser? Chrome 21 Firefox 11 Please provide any additional information below. Worked fine on 1.6.4 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
