Re: Image diffs in 2.0
Sean, The basic framework is in place, but there are a number of complications with binary files in the diff viewer that we didn't solve in time for 2.0, so it's not yet enabled. It's on the roadmap for the next major version. -David On Tue, May 13, 2014 at 9:15 PM, sean...@gmail.com wrote: I am interested in the image diff functionality described in the following review: https://reviews.reviewboard.org/r/4493/ Specifically, I'd like to see the image diff viewer described in the above review shown for binary image files (jpeg, gif, png) inline in the diff viewer. I've been playing with a local copy of 2.0 RC3 and haven't been able to get this to work. The diff viewer just shows that the file is binary instead of showing the image diff as described in that review. I've seen some references to this in various emails and notes, but couldn't find any documentation on how to get this to work. I read through the diff in the above review and it appears to be based off of the File Attachment functionality, which makes me think I need to upload one or two file attachments (only new version and reviewboard pulls original from repository, or both original and new) and somehow link them with the diff either by name / attributes or perhaps posting them directly to the diff resource. Am I on the right track here? Any pointers to documentation or tools that already do this? I read through various rbtools files and didn't see anything, but that doesn't mean it isn't there... For reference, we have ReviewBoard setup with a git repository which is actually a bridge to another SCM so we have custom tools which generate a git compatible diff. We then create the review request and post the diff using the Web API. I'm just trying to figure out what steps to modify or add to this process to support this cool image diff functionality. Thanks, Sean -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Renaming Repositories
That sorted it - thank you. Cheers Dan On Tuesday, 13 May 2014 21:49:26 UTC+1, David Trowbridge wrote: The fix itself is in djblets 1.7.26. If you upgrade to Review Board 1.7.25 you'll get the latest djblets along with it. -David On Tue, May 13, 2014 at 1:01 PM, Daniel Laird daniel@googlemail.comjavascript: wrote: I am running 1.7.18 and having this problem. I could upgrade to 1.7.25 if you think that will fix it? Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Mercurial and kerberos: can't post review
I've tried to work around this problem so that I can evaluate the product. I created a local clone of the Mercurial repository and have added that to ReviewBoard instead of the kerberized remote one. When I clone that repository, make a change, and try to create a review I get the following cryptic error message: pburka@reviewboard:~/repo$ rbt post --server=http://reviewboard.example.com/ ERROR: Error uploading diff The file was not found in the repository (HTTP 400, API Error 207) Your review request still exists, but the diff is not attached. There are no error messages in /var/log/apache2/error.log, and logs/reviewboard.log includes only the following messages: 2014-05-14 15:04:17,675 - DEBUG - - DiffParser.parse: Beginning parse of diff, size = 437 2014-05-14 15:04:17,675 - DEBUG - - DiffParser.parse: Finished parsing diff. 2014-05-14 15:04:17,715 - DEBUG - - Using rbssh for mercurial What does this error (207) mean? What is the file that the error message refers to? /peter On Monday, May 12, 2014 4:33:16 PM UTC-4, Peter Burka wrote: I've installed Reviewboard and configured it with a Mercurial repository through the Admin dashboard. Our Mercurial servers use Kerberos authentication, and not all users have access to all repositories. When I try to post a review, rbt reports: ERROR: Error uploading diff The file was not found in the repository (HTTP 400, API Error 207) Your review request still exists, but the diff is not attached. And /var/log/apache2/error.log includes the following error: [Mon May 12 18:40:08 2014] [error] ERROR:root:HTTP error code 401 when fetching file from https://hg.example.com/repos/main/.../hg-history/344a0cddd514/.../Foo.java: HTTP Error 401: Authorization Required It appears that the Reviewboard server is attempting to contact the Hg server through https, and that it's being denied. I'm surprised that the server is doing this - I would have expected the client to be responsible for fetching the appropriate files so that the user's permissions could be enforced. How can I configure Reviewboard so that this will work? Do I have to grant the www-data user permission to read all of our Mercurial repositories? Even if I do that, will reviewboard correctly negotiate with the server? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
CVS 1.12 on ReviewBoard
Greetings, I'm had a problem with adding a CVS repository running on CVS 1.11. I'm accessing it using ssh with a key and my CVSROOT is valid. When I click Save on the Add Repository page it returns the message A repository was not found at the specified path. This is on CentOS 6 with both ReviewBoard 1.7.25 and 2.0rc3. I found that ReviewBoard is attempting to execute the rls cvs command, which isn't valid until CVS 1.12, which is the 'feature' build. The current stable build is 1.11.23 (according to http://ftp.gnu.org/non-gnu/cvs/source/stable/). Anyone attempting to add a CVS server running anything lower than 1.12 is going to fail. I suspect that even if the server was 1.12 the operation would still fail if the client is anything less than 1.12. I found the problem in /usr/lib/python2.6/site-packages/ReviewBoard-2.0rc3-py2.6.egg/reviewboard/scmtools/cvs.py: 331 def check_repository(self): 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, '*rls* '], 333 self.local_site_name) 334 errmsg = six.text_type(p.stderr.read()) 335 if p.wait() != 0: 336 raise SCMError(errmsg) I was able to resolve the issue by substituting 'rls' for 'version' on line 332. Since ReviewBoard is just checking for the return code from CVS it should function the same. 331 def check_repository(self): 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, ' *version*'], 333 self.local_site_name) 334 errmsg = six.text_type(p.stderr.read()) 335 if p.wait() != 0: 336 raise SCMError(errmsg) I then did a recompile (python -m compileall .) from the reviewboard/scmtools directory and restarted Apache. Problem solved. Thought you might want to know. Your documentation indicates that on RHEL/CentOS you can install CVS using yum install cvs. The version included with CentOS 6 is 1.11.23 and will not work without these modifications. Thanks, Jason -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CVS 1.12 on ReviewBoard
Jason, Thanks for the report. Would you mind filing a bug on our issue tracker? https://code.google.com/p/reviewboard/issues/entry -David On Wed, May 14, 2014 at 2:05 PM, Jason Woodrich jwoodr...@gmail.com wrote: Greetings, I'm had a problem with adding a CVS repository running on CVS 1.11. I'm accessing it using ssh with a key and my CVSROOT is valid. When I click Save on the Add Repository page it returns the message A repository was not found at the specified path. This is on CentOS 6 with both ReviewBoard 1.7.25 and 2.0rc3. I found that ReviewBoard is attempting to execute the rls cvs command, which isn't valid until CVS 1.12, which is the 'feature' build. The current stable build is 1.11.23 (according to http://ftp.gnu.org/non-gnu/cvs/source/stable/). Anyone attempting to add a CVS server running anything lower than 1.12 is going to fail. I suspect that even if the server was 1.12 the operation would still fail if the client is anything less than 1.12. I found the problem in /usr/lib/python2.6/site-packages/ReviewBoard-2.0rc3-py2.6.egg/reviewboard/scmtools/cvs.py: 331 def check_repository(self): 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, '*rls* '], 333 self.local_site_name) 334 errmsg = six.text_type(p.stderr.read()) 335 if p.wait() != 0: 336 raise SCMError(errmsg) I was able to resolve the issue by substituting 'rls' for 'version' on line 332. Since ReviewBoard is just checking for the return code from CVS it should function the same. 331 def check_repository(self): 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, ' *version*'], 333 self.local_site_name) 334 errmsg = six.text_type(p.stderr.read()) 335 if p.wait() != 0: 336 raise SCMError(errmsg) I then did a recompile (python -m compileall .) from the reviewboard/scmtools directory and restarted Apache. Problem solved. Thought you might want to know. Your documentation indicates that on RHEL/CentOS you can install CVS using yum install cvs. The version included with CentOS 6 is 1.11.23 and will not work without these modifications. Thanks, Jason -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: CVS 1.12 on ReviewBoard
Actually, one question, too. Does 'cvs -f -d cvsroot version' actually check that the cvsroot is valid, or does it just check that the local cvs binary runs? The goal of this method is to verify the remote repository. -David On Wed, May 14, 2014 at 2:05 PM, Jason Woodrich jwoodr...@gmail.com wrote: Greetings, I'm had a problem with adding a CVS repository running on CVS 1.11. I'm accessing it using ssh with a key and my CVSROOT is valid. When I click Save on the Add Repository page it returns the message A repository was not found at the specified path. This is on CentOS 6 with both ReviewBoard 1.7.25 and 2.0rc3. I found that ReviewBoard is attempting to execute the rls cvs command, which isn't valid until CVS 1.12, which is the 'feature' build. The current stable build is 1.11.23 (according to http://ftp.gnu.org/non-gnu/cvs/source/stable/). Anyone attempting to add a CVS server running anything lower than 1.12 is going to fail. I suspect that even if the server was 1.12 the operation would still fail if the client is anything less than 1.12. I found the problem in /usr/lib/python2.6/site-packages/ReviewBoard-2.0rc3-py2.6.egg/reviewboard/scmtools/cvs.py: 331 def check_repository(self): 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, '*rls* '], 333 self.local_site_name) 334 errmsg = six.text_type(p.stderr.read()) 335 if p.wait() != 0: 336 raise SCMError(errmsg) I was able to resolve the issue by substituting 'rls' for 'version' on line 332. Since ReviewBoard is just checking for the return code from CVS it should function the same. 331 def check_repository(self): 332 p = SCMTool.popen(['cvs', '-f', '-d', self.cvsroot, ' *version*'], 333 self.local_site_name) 334 errmsg = six.text_type(p.stderr.read()) 335 if p.wait() != 0: 336 raise SCMError(errmsg) I then did a recompile (python -m compileall .) from the reviewboard/scmtools directory and restarted Apache. Problem solved. Thought you might want to know. Your documentation indicates that on RHEL/CentOS you can install CVS using yum install cvs. The version included with CentOS 6 is 1.11.23 and will not work without these modifications. Thanks, Jason -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: How to get the issue ID
On Monday, April 14, 2014 10:15:54 PM UTC+5:30, Dhananjay Joshi wrote: Hello, In the document/code reviews how to get a separate Issue ID for the issues reported during the review. Right now there is no issue id specified in the issue table (please see the attachment). PLease help. Regards, Dhananjay. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2054 in reviewboard: RBTools-0.3.2 + Perforce - failed to upload diff when source file is a new file
Comment #6 on issue 2054 by 308007...@qq.com: RBTools-0.3.2 + Perforce -
failed to upload diff when source file is a new file
http://code.google.com/p/reviewboard/issues/detail?id=2054
Thank you for #3 roasti...@gmail.com.
In Ubuntu ,the path is /usr/lib/python27
And if your os language is Chinese,you should
sys.setdefaultencoding('GB18030')
Here is my error msg:
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.25-py2.7.egg/reviewboard/diffviewer/managers.py,
line
200, in _process_files
filename = os.path.join(basedir, f2).replace(\\, /)
File /usr/lib/python2.7/posixpath.py, line 71, in join
path += '/' + b
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3341 in reviewboard: 'Security Checklist' link gives http 500 due to permission problem
Status: PendingReview
Owner: trowb...@gmail.com
Labels: Type-Defect Priority-Medium Component-Admin Milestone-Release2.0
New issue 3341 by trowb...@gmail.com: 'Security Checklist' link gives http
500 due to permission problem
http://code.google.com/p/reviewboard/issues/detail?id=3341
The 'Security checklist' link on the admin page (which links to
/admin/security/) in 2.0 RC3 produces an http 500 error because it tries to
access media/uploaded/files/exec_check.php, which is disallowed via the
section in apache-wsgi.conf:
Prevent the server from processing or allowing the rendering of certain
file types.
2014-05-14 04:20:36,301 - ERROR - - Exception thrown for user a_user at
https://example.com/admin/security/
[Errno 13] Permission
denied: '/var/www/example.com/htdocs/media/uploaded/files/exec_check.php'
Traceback (most recent call last):
File /usr/local/lib/python2.7/dist-packages/Django-1.6.4-py2.7.egg/django/core/handlers/base.py,
line 114, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File /usr/local/lib/python2.7/dist-packages/Django-1.6.4-py2.7.egg/django/contrib/admin/views/decorators.py,
line 17, in _checklogin
return view_func(request, *args, **kwargs)
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0rc3-py2.7.egg/reviewboard/admin/views.py,
line 81, in security
results = runner.run()
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0rc3-py2.7.egg/reviewboard/admin/security_checks.py,
line 203, in run
check.setUp()
File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0rc3-py2.7.egg/reviewboard/admin/security_checks.py,
line 99, in setUp
self.storage.save('exec_check' + ext, ContentFile(content))
File /usr/local/lib/python2.7/dist-packages/Django-1.6.4-py2.7.egg/django/core/files/storage.py,
line 49, in save
name = self._save(name, content)
File /usr/local/lib/python2.7/dist-packages/Django-1.6.4-py2.7.egg/django/core/files/storage.py,
line 199, in _save
fd = os.open(full_path, flags, 0o666)
OSError: [Errno 13] Permission
denied: '/var/www/example.com/htdocs/media/uploaded/files/exec_check.php'
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3342 in reviewboard: ADS authentication not available after upgrade
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3342 by tjbut...@gmail.com: ADS authentication not available after upgrade http://code.google.com/p/reviewboard/issues/detail?id=3342 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 2.0rc3 Commit 5e8b1ba779196e9b09a02ed3c7d9dd7c06ccb431 What's the URL of the page containing the problem? http://hostname/admin/settings/authentication What steps will reproduce the problem? 1. Log in to Review Board 2. Select Admin 3. Select Authentication What is the expected output? What do you see instead? I expect to see a list of the usually supported authentication methods, including LDAP and ADS What I see after this update is 'Standard Authentication' 'Legacy Authentication' What operating system are you using? What browser? Using Ubuntu 12.04.4 LTS, recent firefox browser Please provide any additional information below. Our previous Reviewboard provided the full list of authentication methods, Reviewboard 2.0rc2. I suspect this is related to the Djblets update performed at the same time. Rolling back to these previous Reviewboard and Djblets versions, and updating rb-site eliminates the problem. The previous Reviewboard and Djblets versions are about 1 week old, I can find exact commit tags if needed. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
