Re: 'rbt patch', git diffs and default --px value
Sorry, it's not actually git but mercurial I'm having trouble with. After running 'rbt post' I run 'rbt patch ' and get the error: Patch is being applied from request 41123 with diff revision 1. Failed to execute command: ['patch', '-i', '/tmp/tmps2NVdI'] can't find file to patch at input line 4 Perhaps you should have used the -p or --strip option? The text leading up to this was: -- |diff -r 7802e325d133 -r 967f7807ca97 jenkins/pyfile.py |--- a/jenkins/pyfile.py Wed Jun 18 16:35:16 2014 -0600 |+++ b/jenkins/pyfile.py Wed Jun 18 20:01:56 2014 -0600 -- File to patch: Skip this patch? [y] Skipping patch. 1 out of 1 hunk ignored -- Bruce On Wed, Jun 18, 2014 at 6:47 PM, David Trowbridge wrote: Bruce, > > I use 'rbt patch' with git all the time without specifying --px. What in > particular are you seeing? > > -David > > > On Wed, Jun 18, 2014 at 7:58 AM, Bruce Cran wrote: > >> I've been trying to use the 'rbt patch' command, and it seems that >> _get_p_number() is only for subversion repositories. >> >> Since diffs are commonly created with a prefix, and git defaults to >> adding a/ and b/, should we automatically try, or retry, using 'patch -p1' >> without the user needing to specify '--px 1'? >> > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: 'rbt patch', git diffs and default --px value
Bruce, I use 'rbt patch' with git all the time without specifying --px. What in particular are you seeing? -David On Wed, Jun 18, 2014 at 7:58 AM, Bruce Cran wrote: > I've been trying to use the 'rbt patch' command, and it seems that > _get_p_number() is only for subversion repositories. > > Since diffs are commonly created with a prefix, and git defaults to adding > a/ and b/, should we automatically try, or retry, using 'patch -p1' without > the user needing to specify '--px 1'? > > -- > Bruce > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Active Directory - Can't Assign New User to Review
New install of RB 2.0.2 on Ubuntu, with Active Directory login working. Users can login once and create their account correctly. But I can't seem to add a user to a review who has not logged in at least once. I enabled logging, but don't see anything in the log after failing to add a user. (Looking at the sources, backends.py for ActiveDirectory doesn't output errors for exceptions in get_or_create_user()) Any advice on how to get this working? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Error using post-review and Reviewboard 1.7.25
All,
We are currently using post-review and Reviewboard 1.7.25 (RBtools 0.5.1).
We added a new Repo to Reviewboard and its listed as repository 26.
However when we try to post a new review to Reviewboard we get:
DEBUG:root:repository info: Path: http://server/svn/repo_name, Base path:
/trunk, Supports changesets: False
>>> Attempting to create review request on http://server/svn/repo_name for
None >>> HTTP POSTing to
http://reviewboard-server/api/review-requests/:
{'repository': u'http://server/svn/repo_name'} >>> Got API Error 206 (HTTP
code 400): The repository path specified is not in the list of known
repositories >>> Error data: {u'stat': u'fail', u'repository':
u'http://server/svn/repo_name', u'err': {u'msg': u'The repository path
specified is not in the list of known repositories', u'code': 206}}
Any ideas why it sees the repo in the list, generates the diff and then
when posting it falls over?
Cheers
Dan
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
'rbt patch', git diffs and default --px value
I've been trying to use the 'rbt patch' command, and it seems that _get_p_number() is only for subversion repositories. Since diffs are commonly created with a prefix, and git defaults to adding a/ and b/, should we automatically try, or retry, using 'patch -p1' without the user needing to specify '--px 1'? -- Bruce -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Migrating From modpython To wsgi After Upgrade From Reviewboard 1.6.11 To 2.0.2
You can create the apache configs by hand by copying the templates and modifying them with the appropriate paths. The files you'll want are apache-wsgi.conf.in and reviewboard.wsgi.in (see https://github.com/reviewboard/reviewboard/tree/master/reviewboard/cmdline/conf ) I'm not entirely sure what you mean by "adverse effects". Running with mod_python can have some strange bugs (which is why django removed it), but I'd be surprised if it was anything that would cause permanent data loss. I'd suggest migrating over to mod_wsgi as soon as convenient, though. -David On Tue, Jun 17, 2014 at 5:47 PM, wrote: > We just upgraded our install from 1.6.11 to 2.0.2 and had serious problems > getting things running because we were using the modpython Django library > with the mod_python Apache module and that hasn't been supported for > awhile. Since Django no longer supports modpython I'm wondering how I > migrate to wsgi? If I have the mod_ wsgi Apache module loaded I'm assuming > the only other thing that I need to do is update my Apache configuration > file, is that accurate? How do I get a sample apache-wsgi.conf generated so > I can modify my config with the correct data? Also, in the mean time, I > copied over the modpython libraries from the 1.3.3 Django site-packages > directory to the Django 1.6.5 site directory and this hack seems to have > gotten things working again in the short term, do you think this could have > any adverse effects on my site? Please let me know. Thanks. > > Also, we're running on CentOS 6.5, Apache 2.2.15, and Python 2.6.6. > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
