Re: Condense diff warning: UnicodeWarning: Unicode unequal comparison.....
Hello David, 1) When can the fix be expected in RB-2.0.x? 2) Do you suggest the migration can still proceed with this warning? 3) What is the impact if we go ahead with production upgrade? Seasons Greetings. Thanks, Ravi On Thursday, December 18, 2014 3:20:21 PM UTC+5:30, Ravikumar R wrote: Thank you David on quick response. The bug report has been generated: https://code.google.com/p/reviewboard/issues/detail?id=3698 Please let me know if more information is needed! Thanks, Ravi On Thursday, December 18, 2014 5:46:46 AM UTC+5:30, David Trowbridge wrote: Ravi, Would you mind filing a bug about this? Thanks! -David On Wed, Dec 17, 2014 at 8:28 AM, Ravikumar R raa...@gmail.com wrote: Hello, While doing condense diff (from RB version 1.6.9 == 2.0.11, the below warning is observed, but the task was successful. This pilot migration was done in a test environment by taking DB dump with a different installation. Can below message on STDOUT be ignored? Can we consider the DB upgrade was successful? Am I good to go ahead with production DB upgrade? PS: DB is MySQL-5.6, ensured DB and its all tables are mapped to utf8 (production DB is in latin1) character set and collation to DB default also all tables are moved to InnoDB as first step. Please suggest. Thanks, Ravi == STDOUT is as below = $ rb-site manage /var/reviewboard/localsite -- condensediffs Processing 555709 diffs for duplicates... This may take a while. It is safe to continue using Review Board while this is processing, but it may temporarily run slower. WARNING:py.warnings:/usr/lib/python2.7/site-packages/ReviewBoard-2.0.11-py2.7.egg/reviewboard/diffviewer/models.py:174: UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal if parent_diff != : [100%] 555709/555709 - 0 seconds remaining === -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Google Chrome defect breaks parts of Reviewboard
Hi all, Just a heads up that in certain scenarios Google Chrome might prevent your users from downloading diffs from Reviewboard. See https://code.google.com/p/reviewboard/issues/detail?id=3704 for more information. Despite what Chrome says, the headers are fine. A temporary fix is available within the report. It is the only browser and client affected by this. Thanks, Ben Cooksley KDE Sysadmin -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3698 in reviewboard: Condensediff warning in 2.0.11
Comment #2 on issue 3698 by raav...@gmail.com: Condensediff warning in 2.0.11 https://code.google.com/p/reviewboard/issues/detail?id=3698 Hello, 1) When can the fix be expected in RB-2.0.x? 2) Do you suggest the migration can still proceed with this warning? 3) What is the impact if we go ahead with production upgrade? Thanks, Ravi -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3704 in reviewboard: Google Chrome policies prevent diffs from being downloaded in some cases
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3704 by sourto...@gmail.com: Google Chrome policies prevent diffs
from being downloaded in some cases
https://code.google.com/p/reviewboard/issues/detail?id=3704
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
2.0.11
What's the URL of the page containing the problem?
https://git.reviewboard.kde.org/r/121338/
What steps will reproduce the problem?
1. Attempt to download the diff in Google Chrome (v16 or later)
2. Get a Multiple Content-Disposition error page from Chrome.
3.
What is the expected output? What do you see instead?
The diff.
What operating system are you using? What browser?
Any OS. Browser is Google Chrome.
Please provide any additional information below.
All other browsers and utilities are unaffected.
Caused by Google Chrome policies -
https://code.google.com/p/chromium/issues/detail?id=108188
The fix is to edit reviewboard/reviews/views.py, and insert the
following just below line 949.
filename = filename.replace(',', '_')
Only occurs if the diff name is based upon the summary, and it contains a
comma.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
