Issue 3824 in reviewboard: Git hooks not working
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3824 by kevin.be...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 When using the git hooks provided in RBTools/contrib/tools, I've got a Python TypeError. This bug affect RBTools v0.7.2 The version 0.6 works fine. Example of a git push with the two server-side hooks: $ git push Counting objects: 9, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (6/6), 572 bytes | 0 bytes/s, done. Total 6 (delta 3), reused 0 (delta 0) remote: ['92838c18206430eadad27792c744458e1391b8e2 d0f234ec84f84973b1e3d2992d67af45f8f373ca refs/heads/master\n'] remote: Traceback (most recent call last): remote: File hooks/pre-receive, line 80, in module remote: main() remote: File hooks/pre-receive, line 49, in main remote: review_id_to_commits = get_review_id_to_commits_map(lines, compiled_regex) remote: File /usr/local/lib/python2.7/dist-packages/RBTools-0.7.2-py2.7.egg/rbtools/hooks/git.py, line 78, in get_review_id_to_commits_map remote: commit_hashes = get_commit_hashes(old_rev, new_rev) remote: File /usr/local/lib/python2.7/dist-packages/RBTools-0.7.2-py2.7.egg/rbtools/hooks/git.py, line 20, in get_commit_hashes remote: return execute(git_command, split_lines=True) remote: TypeError: execute() got an unexpected keyword argument 'split_lines' To ssh://git@192.168.1.105/my_repo ! [remote rejected] master - master (pre-receive hook declined) error: failed to push some refs to 'ssh://git@192.168.1.105/my_repo' -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3824 in reviewboard: Git hooks not working
Updates: Status: Confirmed Labels: Project-RBTools EasyFix Milestone-RBTools-Release0.7.x Component-RBTools Comment #1 on issue 3824 by chip...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 Looks like there's a second execute() function that shouldn't be there, which doesn't accept the split_lines argument. Should be an easy fix. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Confusion about Git configuration
Hi ReviewBoard Devs, Using ReviewBoard 1.7.28. When adding/changing an HTTP hosted Git repository (using Gitolite), I've found that I have to configure the repository with the following pattern: Path: http://username:passw...@gitserver.example.com/git/git-repo-path Mirror path: http://gitserver.example.com/git/git-repo-path Raw file URL mask: http://gitserver.example.com/git/?p=git-repo-path.git;a=blob_plain;f= filename;h=revision Username: username Password: password Obviously, where username password are set to the correct values. It seems like a bug to me that I must specify the username and password in the URL. I've tried removing them, but then ReviewBoard refuses to add / save the repository. When the Path is configured with the user name and password, rbt post doesn't find the repository unless I also set the Mirror path, or unless REPOSITORY is set to the name of the ReviewBoard repository in .reviewboardrc Is there any way to get the username password out of the Path URL? Thanks! Eric. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Confusion about Git configuration
Hi Eric, To fix the matching of repositories, you can leave out Mirror Path and just use `REPOSITORY = 'name` in .reviewboardrc, as you've noted. This is the recommended way of matching repositories and configuring RBTools. I'd also recommend using a SSH URL along with a configured SSH key, instead of HTTP paths, as the former is more secure and shouldn't require specifying a password in the Path field. Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com -Original Message- From: Eric Johnson e...@tibco.com Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com Date: March 27, 2015 at 11:00:19 AM To: reviewboard@googlegroups.com reviewboard@googlegroups.com Subject: Confusion about Git configuration Hi ReviewBoard Devs, Using ReviewBoard 1.7.28. When adding/changing an HTTP hosted Git repository (using Gitolite), I've found that I have to configure the repository with the following pattern: Path: http://username:passw...@gitserver.example.com/git/git-repo-path Mirror path: http://gitserver.example.com/git/git-repo-path Raw file URL mask: http://gitserver.example.com/git/?p=git-repo-path.git;a=blob_plain;f= ;h= Username: username Password: password Obviously, where username password are set to the correct values. It seems like a bug to me that I must specify the username and password in the URL. I've tried removing them, but then ReviewBoard refuses to add / save the repository. When the Path is configured with the user name and password, rbt post doesn't find the repository unless I also set the Mirror path, or unless REPOSITORY is set to the name of the ReviewBoard repository in .reviewboardrc Is there any way to get the username password out of the Path URL? Thanks! Eric. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3824 in reviewboard: Git hooks not working
Comment #2 on issue 3824 by tienv2...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 I got this one -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3108 in reviewboard: APIErrors return 403 but do not log anything
Comment #10 on issue 3108 by tienv2...@gmail.com: APIErrors return 403 but do not log anything https://code.google.com/p/reviewboard/issues/detail?id=3108 can this be explained more clearly? 2. Get a given review request using RBClient 3. review.submit() -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3421 in reviewboard: RB Tools cannot create a review request for a changeset that belongs to a discarded review request
Comment #3 on issue 3421 by tienv2...@gmail.com: RB Tools cannot create a review request for a changeset that belongs to a discarded review request https://code.google.com/p/reviewboard/issues/detail?id=3421 is this bug still valid? I tried to reproduce it, doing: vim test git add test git commit rbt post - review request id 126 (discard the review request via the command line) rbt post - review request id 127 seems to work fine. I did notice that after reopening the review request, the View Diff button seems to have disappeared -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
