Review Board Extension
Hi Team, I have a query that, if I write a extension for Review Board1.7.7.1, will it work fine on newer releases without a tweak. Like suppose we are planning to move to Review Board2.x in near feature. So, will my extension on Review Board1.7.7.1 work on Review Board 2.x ? Or if a tweak will be required will it be a major one. I am asking this because, I can see that Review Board 2.x has major changes with respect to JS technology, Backbone and underscore js has been introduced in this version. Please let me know what will be the best approach. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Oops, sorry for forgetting that. Review Board 2.0.15 RBTools 0.7.2 --steve On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote: What version of Review Board and RBTools are you running? -David On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com javascript: wrote: Looking further into this, it appears that when I run rbt post -r 3 CL commit_id for RR 3 gets updated with the new cl number, but changenum does not. The docs say that changenum is being deprecated in favor of commit_id, but from what I can see, it's the value in changenum that is being displayed in the review web page. Is it just me, or are others seeing the same behavior? --Steve On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: I've noticed that when I post diffs from a new change list to an existing review request using the -r option that the change list number is not updated in the review. I think the review request should update the change list since that's the CL that reflects the current set of diffs, but there may be good reasons to not update it. So I guess my question is, is this a bug or a feature? Since we use perforce, one of the consequences of not updating it is that when the change list is submitted, it won't get automatically updated in the review request with the actual submitted change list number, because the number in the review is not the one that was submitted. I hope that wasn't as confusing as it sounds. Thanks --Steve -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
What version of Review Board and RBTools are you running? -David On Tue, Apr 21, 2015 at 2:11 PM Steve seide.al...@gmail.com wrote: Looking further into this, it appears that when I run rbt post -r 3 CL commit_id for RR 3 gets updated with the new cl number, but changenum does not. The docs say that changenum is being deprecated in favor of commit_id, but from what I can see, it's the value in changenum that is being displayed in the review web page. Is it just me, or are others seeing the same behavior? --Steve On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: I've noticed that when I post diffs from a new change list to an existing review request using the -r option that the change list number is not updated in the review. I think the review request should update the change list since that's the CL that reflects the current set of diffs, but there may be good reasons to not update it. So I guess my question is, is this a bug or a feature? Since we use perforce, one of the consequences of not updating it is that when the change list is submitted, it won't get automatically updated in the review request with the actual submitted change list number, because the number in the review is not the one that was submitted. I hope that wasn't as confusing as it sounds. Thanks --Steve -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Would you mind filing a bug on our issue tracker? Thanks, -David On Tue, Apr 21, 2015 at 2:35 PM Steve seide.al...@gmail.com wrote: Oops, sorry for forgetting that. Review Board 2.0.15 RBTools 0.7.2 --steve On Tuesday, April 21, 2015 at 2:22:17 PM UTC-7, David Trowbridge wrote: What version of Review Board and RBTools are you running? -David On Tue, Apr 21, 2015 at 2:11 PM Steve seide...@gmail.com wrote: Looking further into this, it appears that when I run rbt post -r 3 CL commit_id for RR 3 gets updated with the new cl number, but changenum does not. The docs say that changenum is being deprecated in favor of commit_id, but from what I can see, it's the value in changenum that is being displayed in the review web page. Is it just me, or are others seeing the same behavior? --Steve On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: I've noticed that when I post diffs from a new change list to an existing review request using the -r option that the change list number is not updated in the review. I think the review request should update the change list since that's the CL that reflects the current set of diffs, but there may be good reasons to not update it. So I guess my question is, is this a bug or a feature? Since we use perforce, one of the consequences of not updating it is that when the change list is submitted, it won't get automatically updated in the review request with the actual submitted change list number, because the number in the review is not the one that was submitted. I hope that wasn't as confusing as it sounds. Thanks --Steve -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3661 in reviewboard: Unable to select text in a new file when viewing the text of a New File
Comment #9 on issue 3661 by trowb...@gmail.com: Unable to select text in a new file when viewing the text of a New File https://code.google.com/p/reviewboard/issues/detail?id=3661 Issue 3853 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3853 in reviewboard: Can't select text from a new file on diff page.
Updates: Status: Duplicate Mergedinto: 3661 Comment #1 on issue 3853 by trowb...@gmail.com: Can't select text from a new file on diff page. https://code.google.com/p/reviewboard/issues/detail?id=3853 This bug was fixed in 2.0.12 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Not able to find a function
Hi, I am trying to understand the integration of perforce repository with review board. I am stuck at one point, i am not able to find the implementation of a particular function. Can someone please explain how this function call works: In rbtools\command\post.py file, within post_request function : review_request = api_root.get_review_requests().create(**request_data) Where are these functions? get_review_requests() create() Similarly, further down : review_request.get_diffs().upload_diff(diff_content,**diff_kwargs) where is get_diffs() method ? Tnx -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools: rbt post -r ID changenum does not update the change list number in the review request
Looking further into this, it appears that when I run rbt post -r 3 CL commit_id for RR 3 gets updated with the new cl number, but changenum does not. The docs say that changenum is being deprecated in favor of commit_id, but from what I can see, it's the value in changenum that is being displayed in the review web page. Is it just me, or are others seeing the same behavior? --Steve On Monday, April 20, 2015 at 2:40:42 PM UTC-7, Steve wrote: I've noticed that when I post diffs from a new change list to an existing review request using the -r option that the change list number is not updated in the review. I think the review request should update the change list since that's the CL that reflects the current set of diffs, but there may be good reasons to not update it. So I guess my question is, is this a bug or a feature? Since we use perforce, one of the consequences of not updating it is that when the change list is submitted, it won't get automatically updated in the review request with the actual submitted change list number, because the number in the review is not the one that was submitted. I hope that wasn't as confusing as it sounds. Thanks --Steve -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Extension
Satish, We try pretty hard to make the extension framework backward- and forward-compatible, but depending on how complex your extension is, it might be tricky. Can you tell us a bit about what you're building? -David On Mon, Apr 20, 2015 at 11:40 PM satish singh trivi...@gmail.com wrote: Hi Team, I have a query that, if I write a extension for Review Board1.7.7.1, will it work fine on newer releases without a tweak. Like suppose we are planning to move to Review Board2.x in near feature. So, will my extension on Review Board1.7.7.1 work on Review Board 2.x ? Or if a tweak will be required will it be a major one. I am asking this because, I can see that Review Board 2.x has major changes with respect to JS technology, Backbone and underscore js has been introduced in this version. Please let me know what will be the best approach. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
