Re: RB default reviewer group not getting updated

2018-10-25 Thread Christian Hammond 
Hi,

This is expected. They only take effect for the initial review request. The
idea is to prevent overriding the list of targeted reviewers, or to re-add
someone who was removed, based on a re-run of the algorithm. Consider for
instance an important confidential security fix that may initially trigger
a Default Reviewer rule adding some people or groups to the list, but the
owner of the review request erases them all and assigns it instead to a
private "security" group. You wouldn't want anyone re-added if you were to
update your change, for security disclosure reasons. Instead, once the
review request is published, those fields are meant to be your
responsibility to update.

Christian

On Thu, Oct 25, 2018 at 3:16 PM manoj m  wrote:

> Hello,
>
> If an user uploads a new diff to an already published review request the
> default groups doesn't get updated. Is this expected?
>
> On the contrary, an unpublished review requests gets updated properly.
>
> Thanks
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RB default reviewer group not getting updated

2018-10-25 Thread manoj m 
Hello,

If an user uploads a new diff to an already published review request the 
default groups doesn't get updated. Is this expected?

On the contrary, an unpublished review requests gets updated properly.

Thanks

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Slow SQL query for dashboard

2018-10-25 Thread Joshua Cannon 
Howdy folks!

My users have noticed that the dashboard has gotten increasingly slower, 
taking several seconds to completely load (I think historically it's always 
been slow, but recently people have come out of the woodwork to complain). 
I noticed in the MySQL "High Cost SQL Statements" most of them are a very 
similar SELECT COUNT or SELECT DISTINCTROW which on average takes around 3 
or 4 seconds to complete.

Our setup is apache + mod_wsgi, MySQL InnoDB database.

An example of the first ~20 or so rows that MySQL says are "high cost" are 
attached (note that times are in microseconds)

Happy to provide more info, and thanks in advanced!


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Query,Full Table Scan,Executed (#),Errors (#),Warnings (#),Total Time,Max Time,Avg Time,Rows Sent (#),Avg. Rows Sent (#),Rows Scanned (#),Avg. Rows Scanned (#),Temp. Tables (#)
SELECT COUNT ( DISTINCTROW `reviews_reviewrequest` . `id` ) FROM `reviews_reviewrequest` INNER JOIN `auth_user` ON ( `reviews_reviewrequest` . `submitter_id` = `auth_user` . `id` ) LEFT OUTER JOIN `reviews_reviewrequest_target_people` ON ( `reviews_reviewrequest` . `id` = `reviews_reviewrequest_target_people` . `reviewrequest_id` ) LEFT OUTER JOIN `reviews_reviewrequest_target_groups` ON ( `reviews_reviewrequest` . `id` = `reviews_reviewrequest_target_groups` . `reviewrequest_id` ) LEFT OUTER JOIN `accounts_profile_starred_review_requests` ON ( `reviews_reviewrequest` . `id` = `accounts_profile_starred_review_requests` . `reviewrequest_id` ) WHERE ( ( `reviews_reviewrequest` . `public` = ? OR `reviews_reviewrequest` . `submitter_id` = ? ) AND `auth_user` . `is_active` = ? AND `reviews_reviewrequest` . `status` = ? AND `reviews_reviewrequest` . `local_site_id` IS NULL AND ( `reviews_reviewrequest_target_people` . `user_id` = ? OR `reviews_reviewrequest_target_groups` . `group_id` IN (...) OR `accounts_profile_starred_review_requests` . `profile_id` = ? ) AND ,,69553,1,0,2.86803E+11,75910190.32,4123522.02,69553,1,9381694476,134886,100532
SELECT COUNT ( DISTINCTROW `reviews_reviewrequest` . `id` ) FROM `reviews_reviewrequest` INNER JOIN `auth_user` ON ( `reviews_reviewrequest` . `submitter_id` = `auth_user` . `id` ) LEFT OUTER JOIN `reviews_reviewrequest_target_people` ON ( `reviews_reviewrequest` . `id` = `reviews_reviewrequest_target_people` . `reviewrequest_id` ) LEFT OUTER JOIN `reviews_reviewrequest_target_groups` ON ( `reviews_reviewrequest` . `id` = `reviews_reviewrequest_target_groups` . `reviewrequest_id` ) LEFT OUTER JOIN `accounts_profile_starred_review_requests` ON ( `reviews_reviewrequest` . `id` = `accounts_profile_starred_review_requests` . `reviewrequest_id` ) WHERE ( ( `reviews_reviewrequest` . `public` = ? OR `reviews_reviewrequest` . `submitter_id` = ? ) AND `auth_user` . `is_active` = ? AND `reviews_reviewrequest` . `status` = ? AND `reviews_reviewrequest` . `local_site_id` IS NULL AND ( `reviews_reviewrequest_target_people` . `user_id` = ? OR `reviews_reviewrequest_target_groups` . `group_id` IN (?) OR `accounts_profile_starred_review_requests` . `profile_id` = ? ) AND ,,58915,0,0,2.42122E+11,77549288.2,4109689.27,58915,1,8210335156,139359,99326
"SELECT DISTINCTROW `reviews_reviewrequest` . `id` , `reviews_reviewrequest` . `description` , `reviews_reviewrequest` . `description_rich_text` , `reviews_reviewrequest` . `testing_done` , `reviews_reviewrequest` . `testing_done_rich_text` , `reviews_reviewrequest` . `bugs_closed` , `reviews_reviewrequest` . `branch` , `reviews_reviewrequest` . `commit_id` , `reviews_reviewrequest` . `extra_data` , `reviews_reviewrequest` . `rich_text` , `reviews_reviewrequest` . `summary` , `reviews_reviewrequest` . `submitter_id` , `reviews_reviewrequest` . `time_added` , `reviews_reviewrequest` . `last_updated` , `reviews_reviewrequest` . `status` , `reviews_reviewrequest` . `public` , `reviews_reviewrequest` . `changenum` , `reviews_reviewrequest` . `repository_id` , `reviews_reviewrequest` . `email_message_id` , `reviews_reviewrequest` . `time_emailed` , `reviews_reviewrequest` . `diffset_history_id` , `reviews_reviewrequest` . `last_review_timestamp` , `reviews_reviewrequest` . ",*,17175,0,0,1.57455E+11,181180256,9167663.68,533120,31,15093158090,878786,17567
SELECT COUNT ( DISTINCTROW `reviews_reviewrequest` . `id` ) FROM `reviews_reviewrequest` INNER JOIN `auth_user` ON ( `reviews_reviewrequest` . `submitter_id` = `auth_user` . `id` ) LEFT OUTER JOIN `reviews_reviewrequest_target_people` ON ( `reviews_reviewrequest` .