Re: Comment with non-ascii character doesn't post

2023-01-18 Thread Christian Hammond 
Hi Jon,

Most likely, the database being used is MySQL and the tables weren’t
created with UTF-8 support. More annoyingly, until recently, MySQL’s UTF-8
support didn’t support Emojis.

To work around the latter, we support Emoji shortcodes. Here’s a list of
known ones:
https://gist.github.com/rxaviers/7360908

But that doesn’t help with copying/pasting.

Other databases (Postgres) and new databases created on MySQL 8+ don’t have
this issue.

Are you the admin on the server? We could check some things.

Christian


On Wed, Jan 18, 2023 at 04:31 Jonathan Combe  wrote:

> On Review Board 4.0.11.
>
> I tried to paste in a comment as a reply to a review comment from Outlook.
> The email contained a smiley symbol.
>
> This did paste into the comment box OK and I hit OK, but I didn't get an
> error but I also didn't get the green banner asking to publish or discard
> the comment. If I reefrshed the page the comment is gone.
>
> If I turned on Developer mode I could see it was raising an HTTP 500
> Internal Server Error, but this wasn't visible to the user.
>
> Is this a known issue? Is there a fix for it? Otherwise have to manually
> filter things like this out from emails which is a nuisance.
>
> Thanks
> Jon
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/934fcf9f-80cd-4af1-a0ee-adddf4a91baen%40googlegroups.com
> 
> .
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3DBnfqcpOsg5MdZQkadKmSs-o9J%3DbbEFdyp3X_QYjcGdg%40mail.gmail.com.

Re: get the diff in a patch file

2023-01-18 Thread David Trowbridge 
If your `rbt patch` command doesn't have the `--write` flag, then you're
running a version older than 2.0.1. We highly recommend upgrading.

David

On Mon, Jan 16, 2023 at 8:57 PM 'Ramakrishnan P R' via Review Board
Community  wrote:

> Hi,
>
>
>
> Thanks for replying back.
>
> I think the “1234” you mention in your example is the RB number.
>
> I tried as below:
>
>
>
> lvnvdb1375 ...rp889981/dynbwfixes/trunk> rbt patch -write 260437.diff
> 260437
>
> usage: rbt patch [options] 
>
> rbt: error: unrecognized arguments: -write
>
> lvnvdb1375 ...rp889981/dynbwfixes/trunk> rbt patch --write 260437.diff
> 260437
>
> usage: rbt patch [options] 
>
> rbt: error: unrecognized arguments: --write
>
> lvnvdb1375 ...rp889981/dynbwfixes/trunk>
>
>
>
> Does not seem to recognize.
>
> 260437 is a valid rb :https://wlan-rb.lvn.broadcom.net/r/260437/
>
>
>
> This would be helpful when we have to merge the changes from one
> repository to another. And in the new repository you want to do some sanity
> test before you use merge_jira to check in the change.
>
> Using rbt patch rbnumber# does not work since the RB was created from a
> different repository.
>
>
>
> lvnvdb1375 ...rp889981/dynbwfixes/trunk> rbt patch --px 4 260437
>
> Patch is being applied from request 260437 with diff revision 4.
>
> WARNING: This patch was generated in a different directory. To prevent
> conflicts, all files not under the current directory have been excluded. To
> apply all files in this patch, apply this patch from the
> /dot11_firmware/branches/RhinoUcodeBranch_1555_1 directory.
>
> WARNING: All files were excluded from the patch.
>
> Successfully applied patch.
>
>
>
> I found another way to do it using --print:
>
> rbt patch --print 260437 > 260437.diff
>
>
>
> Thanks.
>
> Regards,
>
> Rama
>
>
>
>
>
> *From:* reviewboard@googlegroups.com  *On
> Behalf Of *David Trowbridge
> *Sent:* Monday, January 16, 2023 11:40 PM
> *To:* reviewboard@googlegroups.com
> *Subject:* Re: get the diff in a patch file
>
>
>
> Rama,
>
>
>
> If you want to save the patch to a file, you can do that with rbt patch:
>
>
>
> rbt patch --write 1234.diff 1234
>
>
>
> By default, that will grab the latest diff. If you want a specific
> revision you can use --diff-revision
>
>
>
> David
>
>
>
> On Mon, Jan 16, 2023 at 10:54 AM 'Ramakrishnan P R' via Review Board
> Community  wrote:
>
> Hi,
>
> Is there a way I can get a copy of the diff in a patch file format by
> using a rbt command on the linux server.
>
> I see there is an option to download the diff from the review board html
> page. Request is to get the patch file on the linux server (SJ/BLR) using a
> rbt command such as rbt patch / rbt post etc.
>
>
>
> Thanks.
>
> Regards,
>
> Rama
>
>
> This electronic communication and the information and any files
> transmitted with it, or attached to it, are confidential and are intended
> solely for the use of the individual or entity to whom it is addressed and
> may contain information that is confidential, legally privileged, protected
> by privacy laws, or otherwise restricted from disclosure to anyone else. If
> you are not the intended recipient or the person responsible for delivering
> the e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/74418966-5ab8-4407-9438-bc28cb807167n%40googlegroups.com
> 
> .
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/CAFS3VNU8eQ3OJ_1cQuDCcmjnR2Nj%2BwrdfvBWy1wfa8bu9sqg7A%40mail.gmail.com
>

Comment with non-ascii character doesn't post

2023-01-18 Thread Jonathan Combe 
On Review Board 4.0.11.

I tried to paste in a comment as a reply to a review comment from Outlook. 
The email contained a smiley symbol.

This did paste into the comment box OK and I hit OK, but I didn't get an 
error but I also didn't get the green banner asking to publish or discard 
the comment. If I reefrshed the page the comment is gone.

If I turned on Developer mode I could see it was raising an HTTP 500 
Internal Server Error, but this wasn't visible to the user.

Is this a known issue? Is there a fix for it? Otherwise have to manually 
filter things like this out from emails which is a nuisance.

Thanks
Jon

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/934fcf9f-80cd-4af1-a0ee-adddf4a91baen%40googlegroups.com.