Re: Draft diff not visible to user with access to drafts
Thanks Christian. > Likely, the browser experience would remain the same whether or not special permissions are granted, but if you do have special permissions, you’d get some UI to toggle your view to let you interact on behalf of the user. I think that would work quite well. The only reason we grant some users these permissions is so they can tidy up reviews when people have left, or add additional groups/users the poster missed. Most of the time they won't need to be editing the review. Cheers, Neil. On Wednesday, 25 January 2023 at 21:48:38 UTC Christian Hammond wrote: > Thanks for all the detailed information! Yep, this is a known bug where > the API and UI have a mismatch in terms of what can be seen when you have > the special permissions. We’re wanting to fix this but haven’t yet. > > The permissions were initially built to enable API-level control for > another user’s review requests, intended for bot accounts. The experience > isn’t really built right for humans. We’ve been discussing a complete > rethink. Likely, the browser experience would remain the same whether or > not special permissions are granted, but if you do have special > permissions, you’d get some UI to toggle your view to let you interact on > behalf of the user. > > Earliest release for a fix would be 6.0, due to the level of work involved. > > Christian > > > On Wed, Jan 25, 2023 at 13:07 puremo...@gmail.com > wrote: > >> FWIW, the diff fragment request returns 404 because it does a lookup on >> the draft where submitter = the requesting user. This is why you get the >> inconsistent UI (with the diff fragments failing to load). >> >> On Tuesday, January 24, 2023 at 5:40:35 PM UTC Neil Potter wrote: >> >>> >>> Hi, >>> >>> We've recently upgraded to RB 4.0.11. We're seeing an odd issue >>> involving draft reviews and users with rights to administer other people's >>> reviews. >>> >>> I'm not sure if this is a bug, is intentional or is perhaps a >>> configuration issue. We upgraded from RB 2.x to RB 4 and I don't think we >>> observed this before. >>> >>> Would it be possible to get some guidance on what the expected behaviour >>> is? >>> >>> *What Version are you running ?* >>> >>> 4.0.11 >>> >>> We've reproduced this in RB5 also. >>> >>> *What's the URL Of the page containing the problem?* >>> >>> http://reviews/r/102802/ >>> http://reviews/r/102802/diff/2/#index_header >>> >>> *What steps will reproduce the problem?* >>> >>> 1. Configure UserA with typical permissions to post and manage their own >>> reviews, review others people's reviews. >>> >>> 2. Configure UserB with typical permissions to post and manage their own >>> reviews. In addition, grant them the ability to administer other people's >>> reviews via rights: >>> reviews | review request | Can submit as user >>> reviews | review request | Can change status >>> reviews | review request | Can edit review request >>> >>> 3. UserA creates and publishes a review with diff revision 1 (r1) >>> >>> 4. UserA prepares a new review draft with a new diff revision 2 (r2) >>> >>> 5. UserB visits the review >>> >>> *What is the expected output? What do you see instead?* >>> >>> At Step 5. >>> >>> i. When visiting http://reviews/r/102802/ UserB does not see any draft >>> review >>>banner at the top. >>> >>> ii. When using the 'Diff' link as UserB (top right), it takes you to the >>> Revision 2 draft >>>diff: >>>http://reviews/r/102802/diff/2/#index_header >>> >>>See DiffScreen.png >>> >>> iii. On the 'Diff' page displayed to UserB the diff r2 never loads. The >>> spinner icon remains. There are errors in the javascript console. >>> See ConsoleLog.png >>> >>> iv. Eventually a banner saying "A Server error occurred" appears. >>> See DiffScreenServerError.png >>> >>> *Potential issues / questions* >>> >>> Q1. (i) and (ii) are inconsistent. UserB has additional permissions, >>> yes, but >>> oddly only sees the draft banner on the diff page not the main page >>> which seems odd >>> compared to UserA viewing their own draft. >>> I'd expect the draft banner should be visible whenever UserB views the >>> review? >>> >>>
Re: Issue: Only team foundation available when adding repository (Windows install)
Christian, thanks again - you are right, the install seems to be just broken. For ease and to save time, I will re-install on a linux system as it's only needed in-house. If I get any answers from Bitnami I will make sure to post them here - just incase someone else has this issue. thanks, Neil On Sunday, 15 October 2017 15:57:24 UTC+1, Neil Beresford wrote: > > just install review board on our local server (Windows server 2008) and > noticed, when adding a repository - the only options available are for the > team foundation. > > There is no option to support GIT, SVN etc as per the old version. > > Am I missing sometihng? > > many thanks, Neil > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue: Only team foundation available when adding repository (Windows install)
Good morning all, firstly thanks for all the quick replies. Christian - as it's windows - I followed the links and installed from here - https://bitnami.com/stack/reviewboard-plus-powerpack ... there was no errors and I assumed it all went ok. I will follow Erik's advice and get back with the findings. thanks Neil On Sunday, 15 October 2017 15:57:24 UTC+1, Neil Beresford wrote: > > just install review board on our local server (Windows server 2008) and > noticed, when adding a repository - the only options available are for the > team foundation. > > There is no option to support GIT, SVN etc as per the old version. > > Am I missing sometihng? > > many thanks, Neil > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Issue: Only team foundation available when adding repository (Windows install)
just install review board on our local server (Windows server 2008) and noticed, when adding a repository - the only options available are for the team foundation. There is no option to support GIT, SVN etc as per the old version. Am I missing sometihng? many thanks, Neil -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RB with TFS
Yeah, my team would really benefit from this as well. Let me know if you want any contribution help. Neil On Sunday, January 15, 2017 at 12:49:24 PM UTC-5, Geoffrey wrote: > > Hello, > > I have used Review Board at my previous employer with great success and it > was really awesome. On that team, we used RB in the typical fashion with > git. The RB server was on linux and the clients were all (mostly) linux. > > In my new role, I am experimenting with RB with a TFS/TFVC repository and > am running into a lot of issues. I setup an Ubuntu server and installed > the powerpack extension. For now, it is just me experimenting so the 2 > user limit is not an issue. My client machine uses windows. > > This leads me to a few questions: > >- Does RB/powerpack support TFS 2015 or 2017? (some of the documents I >read were a little stale and out of sync with release notes) >- Does the powerpack extension work correctly with TFS while RB server >is hosted on linux? >- Is there any intention of ever making TFS part of the free/open >source version? > - I believe there would be more users and more contribution to make > TFS stable. > - It would probably lead to more users thus more potential > purchasers of the other powerpack features :) > - It is hard to 'sell' the idea to management when it isn't stable > and/or requires much effort to configure. More contribution will fix > this. >If it was purely open source and free, it would be much easier to > justify > spending time. > > > ReviewBoard is an awesome tool and I think there is a huge world of TFS > users out there who would enjoy it as well if it was easier to use for this > specific case. > > Thanks, > Geoff > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Multiple ReviewBoard install on one server interfere with each other
I've installed RB twice, in 2 separate subdirectories, each using a
separate run of rb-site. One is in /local/reviews, and a test/debug one is
in /local/reviews-test. I have set up an Apache config. to set up each of
these as separate sub-URLs on the same server (no virtual servers).
I am finding that I can get into one OK, but when I try to get into the
other, it gives errors trying to access the other! I can see nothing in
the DB or settings in either that refer to the other. An example error I
get when accessing the main one (/reviews/) is:
Page not found (404) Request Method: GET Request URL:
http://localhost/reviews/dashboard/
Using the URLconf defined in djblets.util.rooturl, Django tried these URL
patterns, in this order:
1. ^reviews-test/
The current URL, reviews/dashboard/, didn't match any of these.
You're seeing this error because you have DEBUG = True in your Django
settings file. Change that to False, and Django will display a standard 404
page.
Where did the ref. to /reviews-test/ come from? I had been getting it the
other way around (reviews-test failed accessing reviews) until I restarted
httpd, and could log into the test one. But now the main one fails.
Here's the config:
# RB access itself
WSGIScriptAlias /reviews /local/reviews/htdocs/reviewboard.wsgi/reviews
Directory /local/reviews/htdocs
# Error handlers
ErrorDocument 500 /errordocs/500.html
WSGIPassAuthorization On
AllowOverride All
Options -Indexes FollowSymLinks
Allow from all
/Directory
# Alias static media requests to filesystem
Alias /reviews/media /local/reviews/htdocs/media
Alias /reviews/errordocs /local/reviews/htdocs/errordocs
Alias /reviews/favicon.ico
/local/reviews/htdocs/media/rbcommons/images/favicon.png
# TEST
# RB access itself
WSGIScriptAlias /reviews-test
/local/reviews-test/htdocs/reviewboard.wsgi/reviews-test
## NB - I guessed at the argument above also including '-test', that may be
wrong to do
Directory /local/reviews-test/htdocs
# Error handlers
ErrorDocument 500 /errordocs/500.html
WSGIPassAuthorization On
AllowOverride All
Options -Indexes FollowSymLinks
Allow from all
/Directory
# Alias static media requests to filesystem
Alias /reviews-test/media /local/reviews-test/htdocs/media
Alias /reviews-test/errordocs /local/reviews-test/htdocs/errordocs
Alias /reviews-test/favicon.ico
/local/reviews-test/htdocs/media/rbcommons/images/favicon.png
I had to fiddle with the script-generated one to get it to work outside of
a virtual server setting.
And the site settings for the main one:
# Site-specific configuration settings for Review Board
# Definitions of these settings can be found at
# http://docs.djangoproject.com/en/dev/ref/settings/
# Database configuration
DATABASES = {
'default': {
'ENGINE': 'django.db.backends.mysql',
'NAME': 'reviewboard',
'USER': 'review_board_user',
'PASSWORD': 'xxx',
'HOST': 'localhost',
'PORT': '',
},
}
# Unique secret key. Don't share this with anybody.
SECRET_KEY = 'xxx'
# Cache backend settings.
CACHE_BACKEND = 'memcached://localhost:11211/'
# Extra site information.
SITE_ID = 1
SITE_ROOT = '/reviews/'
FORCE_SCRIPT_NAME = ''
DEBUG = True
The test settings have equiv. values, with a diff. NAME (d/b name) value.
Full disclosure: I originally had the test one installed in
/local/reviews-test but using the reviews d/b and /reviews/ path, and have
moved it (renamed the d/b) while updating the d/b and Apache settings. I
then created the 'main' one in /local/reviews/ using the right values.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard not accepting Subversion diffs containing new files
On Wednesday, 17 October 2012 21:31:37 UTC+1, Christian Hammond wrote: Yes, each ReviewBoard hardcodes a required version of Djblets. See setup.py for the dependency list. The latest 1.6.x release introduced support for SVN properties, so I suspect you'll have more luck when that release is installed. OK, thanks. I'll give them another try when I get a chance. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard not accepting Subversion diffs containing new files
On Tuesday, 16 October 2012 21:13:48 UTC+1, Christian Hammond wrote: That's the wrong humanize. Your Djblets wasn't updated along with Review Board, which is the problem. You need to update that package too. Not sure I follow; is that ReviewBoard release tied to a specific version of this Djblets then? I have Djblets 0.6.22. Can you run that post-review command but with --output-diff and show the headers of that file where it lists the filenames? I imagine post-review in this case is choosing the wrong base path. Not sure if this is what you were planning on looking for, but I've discovered the basic cause of the issue, if not the problem. It's that post-review issues svn diff --diff-cmd=diff. This causes a change in the output (possibly a diff/patch corruption) for (at least) new files with svn properties set. If I run post-review with the given diff as created by the post-review command, it fails. If I do the same, but create the diff without the --diff-cmd it works. Example snippet of failing output (the diff that post-review would create): +#endif /* TREE_CELLEDIT_H */ + Index: trunk/Source/Framework/Gui/Tree/TreeEdit.h === --- trunk/Source/Framework/Gui/Tree/TreeEdit.h(revision 12566) +++ trunk/Source/Framework/Gui/Tree/TreeEdit.h(revision 12567) Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h ___ Added: svn:eol-style ## -0,0 +1 ## +LF \ No newline at end of property Example snippet of working output: +#endif /* TREE_CELLEDIT_H */ + Property changes on: trunk/Source/Framework/Gui/Tree/TreeEdit.h ___ Added: svn:eol-style ## -0,0 +1 ## +LF \ No newline at end of property But I can't comment of the rightness or wrongness of either input or processing. I'll have to see if I can nobble my post-review to not issue that option, or wrap it such that I do the diff manually pass it in as a file. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
ReviewBoard not accepting Subversion diffs containing new files
I'm trying to set up ReviewBoard (1.6.11, on Scientific Linux 6), and am
trying to post a diff to a review from Subversion (RBTools 0.4.2), where
the diff contains a new file being added.
It's failing with an error which implies RB is trying to fetch an old
(non-existent) version of the file to diff:
Got API Error 207 (HTTP code 400): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file':
u'//trunk/Source/Framework/Gui/Tree/TreeEdit.h', u'err': {u'msg': u'The
file was not found in the repository', u'code': 207}, u'revision':
u'12566'}
The diff contains the following snippet:
Index: trunk/Source/Framework/Gui/Tree/TreeEdit.h
===
--- trunk/Source/Framework/Gui/Tree/TreeEdit.h (revision 0)
+++ trunk/Source/Framework/Gui/Tree/TreeEdit.h (revision 12567)
@@ -0,0 +1,108 @@
+#ifndef TREE_CELLEDIT_H
+#define TREE_CELLEDIT_H
...
Is this a config. issue or a bug?
FWIW, I tried the latest 1.6.13, but that wouldn't run due to some odd
Django error about not being able to find humanize or something.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard not accepting Subversion diffs containing new files
On Tuesday, 16 October 2012 10:33:21 UTC+1, Christian Hammond wrote:
How did you generate/upload the diff? It looks like the base path was set
incorrectly. If you use post-review, this should be taken care of for you.
Yes, I ran post-review. The latest version of that is now printing the svn
diff command in its debug (still fails):
DEBUG:root:Running: svn diff --diff-cmd=diff
http://localhost/repos/Framework/@12566
http://localhost/repos/Framework/@12567
.. which seems sane to me.
Also, how did you install Review Board? The humanize error indicates your
Djblets wasn't updated properly (which should happen automatically).
I downloaded the SRPM for the currently available version (1.6.11), then
changed it to use 1.6.13 (and used the tarball for that). Apart from not
having to apply one patch that has presumably gone in since, it went
seemingly smoothly. But I got Internal Server Error out of Apache after
restarting, with the following logged:
mod_wsgi (pid=9820): Exception occurred processing WSGI script
'/local/reviews-test/htdocs/reviewboard.wsgi'.
Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/django/core/handlers/wsgi.py,
line 250, in __call__
self.load_middleware()
File /usr/lib/python2.6/site-packages/django/core/handlers/base.py,
line 47, in load_middleware
raise exceptions.ImproperlyConfigured('Error importing middleware %s:
%s' % (mw_module, e))
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: No module named humanize
File does not exist: /var/www/html/errordocs
mod_wsgi (pid=9825): Exception occurred processing WSGI script
'/local/reviews-test/htdocs/reviewboard.wsgi'.
Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/django/core/handlers/wsgi.py,
line 250, in __call__
self.load_middleware()
File /usr/lib/python2.6/site-packages/django/core/handlers/base.py,
line 47, in load_middleware
raise exceptions.ImproperlyConfigured('Error importing middleware %s:
%s' % (mw_module, e))
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: No module named humanize
I didn't have a clue what to do with that, so I reverted. I do have stuff
(from Django) in:
/usr/lib/python2.6/site-packages/django/contrib/humanize/
.. but that doesn't look like it would be automatically found.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Problem installing on Ubuntu Hardy / Git / GitHub
Does anyone have any other ideas? I'm trying a variety of things but not getting anywhere with this... TIA Neil On Mon, Sep 28, 2009 at 1:03 PM, Neil Middleton neil.middle...@gmail.comwrote: git is in /usr/bin which I would assume is correct. N On 28 Sep 2009, at 12:11, Thilo-Alexander Ginkel wrote: On Mon, Sep 28, 2009 at 12:53, Neil neil.middle...@gmail.com wrote: I've just installed ReviewBoard on a plain Hardy install, and have created a repository pointed at GitHub. However, when I try to create a new review request I get an http 500, plus the following in the logs: Git is installed on the server and working. Is the git binary in the PATH for the user that is running the RB web server? Regards, Thilo Neil Middleton http://neilmiddleton.com -- Neil Middleton --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
RBTools and Python 2.4
I was trying to install RBTools on my Python 2.3.4 system and got the
message about the missing cookielib import. Is it possible to support
the pre-2.4 libraries of ClientCookie like is documented at
http://code.activestate.com/recipes/302930/ ? I'm not sure if there
are any other requirements for later versions of Python, but I
couldn't find any from the web pages.
Full error when trying to run post-review:
# python -V
Python 2.3.4
# post-review
Traceback (most recent call last):
File /usr/bin/post-review, line 5, in ?
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.3/site-packages/setuptools-0.6c9-py2.3.egg/
pkg_resources.py, line 448, in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.3/site-packages/setuptools-0.6c9-py2.3.egg/
pkg_resources.py, line 1173, in run_script
exec script_code in namespace, namespace
File /usr/bin/post-review, line 2, in ?
# EASY-INSTALL-SCRIPT: 'RBTools==0.2beta1','post-review'
ImportError: No module named cookielib
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: RBTools and Python 2.4
I started looking around and the closest thing I see is http://reviewboard.googlecode.com/svn/trunk/reviewboard/contrib/tools/post-commit. Is there another place that the RBTools source is, or is that it? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: RBTools and Python 2.4
It's over before it began. Replacing cookielib is one thing, but going back and replacing subprocess is another. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: No module named crypt
Great thanks. Commented out import crypt in reviewboard/accounts/backends.py I then get error about import nis in the same file Commented that out and appears to work OK Is commenting out the nis likely to break something? On Jul 29, 1:05 pm, Dan Savilonis d...@n-cube.org wrote: crypt is only available in unix versions of python. Perhaps no one has tried using LDAP on a Windows install. This module isn't needed for for LDAP, so you could try removing the import from backends.py to verify whether you can set up LDAP authentication. Dan On Jul 28, 6:43 pm, neil neil.trim...@gmail.com wrote: The win32 installer for 2.5 does not appear to include crypt On Jul 28, 5:40 pm, Christian Hammond chip...@chipx86.com wrote: Where did you install Python from? It should be part of Python. The Python 2.5 or 2.6 installer from python.org includes it. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Mon, Jul 27, 2009 at 9:57 PM, neil neil.trim...@gmail.com wrote: I am running 1.0 on windows. I have tried to enable ldap authentication. I have done easy_install python_ldap but get an error No module named crypt It looks like reviewboard/accounts/backends.py attempts to import crypt Where do I get a windows version of this from? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: No module named crypt
Done= issue 1244 http://code.google.com/p/reviewboard/issues/detail?id=1244 On Jul 29, 1:57 pm, Christian Hammond chip...@chipx86.com wrote: No, it's not. We should fix this so it's only imported as needed. Would you mind filing a bug? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Jul 28, 2009 at 6:40 PM, neil neil.trim...@gmail.com wrote: Great thanks. Commented out import crypt in reviewboard/accounts/backends.py I then get error about import nis in the same file Commented that out and appears to work OK Is commenting out the nis likely to break something? On Jul 29, 1:05 pm, Dan Savilonis d...@n-cube.org wrote: crypt is only available in unix versions of python. Perhaps no one has tried using LDAP on a Windows install. This module isn't needed for for LDAP, so you could try removing the import from backends.py to verify whether you can set up LDAP authentication. Dan On Jul 28, 6:43 pm, neil neil.trim...@gmail.com wrote: The win32 installer for 2.5 does not appear to include crypt On Jul 28, 5:40 pm, Christian Hammond chip...@chipx86.com wrote: Where did you install Python from? It should be part of Python. The Python 2.5 or 2.6 installer from python.org includes it. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Mon, Jul 27, 2009 at 9:57 PM, neil neil.trim...@gmail.com wrote: I am running 1.0 on windows. I have tried to enable ldap authentication. I have done easy_install python_ldap but get an error No module named crypt It looks like reviewboard/accounts/backends.py attempts to import crypt Where do I get a windows version of this from? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
No module named crypt
I am running 1.0 on windows. I have tried to enable ldap authentication. I have done easy_install python_ldap but get an error No module named crypt It looks like reviewboard/accounts/backends.py attempts to import crypt Where do I get a windows version of this from? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: IDE integration
Most of the work would be on the plug-in side, I would imagine. It would be cool if we leveraged Django event handler property to broadcast change review events to other interested parties IDE via mylien, just as crucible does. It would also be cool to leverage IDE code coverage integration so reviewers can get a bird's eye view if the new code has tests around it BEFORE reviewing. On Sun, Jul 12, 2009 at 5:33 PM, Jeff Andros j...@bigredtj.com wrote: I've heard some about this from my guys too. Eclipse integration was on the gsoc list, but I never heard which projects the students wound up doing. I'm not sure there's any work done on it yet. --Jeff --Original Message-- From: nap4110 Sender: reviewboard@googlegroups.com To: reviewboard ReplyTo: reviewboard@googlegroups.com Subject: IDE integration Sent: Jul 12, 2009 2:24 PM Hi, I am new to the reviewboard community. I noticed that there has been some talk about tighter integration between reviewboard and IDE such as Eclipse, Intellij and Visual Studio. My company has expressed interest in assisting the open source community with development of this feature. Where do we get started? Has anyone else in the community started any work at the design or implementation level? Thanks, Neil --Jeff --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
