Re: Automated merge after review continuous integration

2013-11-25 Thread Venkateswara Reddy
any updates on this

On Thursday, November 7, 2013 4:31:19 PM UTC+5:30, Venkateswara Reddy wrote:

 even i am looking for this, let me know if some one did it.
 Vreddy

 On Friday, September 20, 2013 9:30:05 PM UTC+5:30, David Trowbridge wrote:

 There have been no changes to this as yet. We'd like to address this 
 eventually but it's a very difficult thing to address in a generic way, and 
 for the time being we have other priorities.

 -David


 On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský lubos.r...@gmail.comwrote:

 I have the same question. Is there any way how to merge (from 
 ReviewBoard) after acceptance of review?


 On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:

 Hey David,
 This is an older post but im actually looking for exactly these things 
 currently and was wondering if these features have been built into 
 reviewboard now  / via plugins or are they still in pipeline?

 Thanks,
 M

 On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:

 #2 would be great; I know a lot of people have requested the ability 
 to have some indication that the patch submitted will (a) apply cleanly 
 and 
 (b) build (maybe even including automated testing).

 #1 is often requested, but it's something which we've been wary of 
 because of the complexities of user authentication, audit chains, and the 
 abilities it would introduce to break things. It would be a cool feature, 
 but I think we'd need to approach it carefully.

 -David


 On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski 
 jan.ko...@gmail.comwrote:

 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two 
 things bring my attention:

 1) Gerrit try to merge code automatically after review. This is great 
 ability. As far I'm aware when merge won't end with success developer 
 get 
 message to rebase their code and send to review again. It will be cool 
 to 
 get something similar at reviewboard. I think this approach will for for 
 Git and probably for Mercurial too.

 2) Build system integration. I saw Hudson  Gerrit integration which 
 assume additional field for build system which check is project build 
 with 
 new versions or not. It is well  exposed at 
 http://source.android.com/source/life-of-a-patch.html. Will be 
 something nice to make accessible some by API checkbox field for build 
 system and approach such workflow in reviewboard - optional ofcourse.

 What do You think?

 Regards,

 Jan

 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fdonate%2Fsa=Dsntz=1usg=AFQjCNGXNqC_euiTahMwUEszbqikxPUy8w
 Happy user? Let us know at 
 http://www.reviewboard.org/users/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fusers%2Fsa=Dsntz=1usg=AFQjCNFyEqttNN29TbXXuEolF2UQXwajng
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard...@googlegroups.com
 For more options, visit this group at http://groups.google.com/
 group/reviewboard?hl=en


  -- 
 Get the Review Board Power Pack at 
 http://www.reviewboard.org/powerpack/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fpowerpack%2Fsa=Dsntz=1usg=AFQjCNHvNQmuU5sDe3NAVxxmt3e7_0CXHA
 ---
 Sign up for Review Board hosting at RBCommons: 
 https://rbcommons.com/https://www.google.com/url?q=https%3A%2F%2Frbcommons.com%2Fsa=Dsntz=1usg=AFQjCNHb-u2_RY-dBIOlVIqiWd3JbrdivA
 ---

 Happy user? Let us know at 
 http://www.reviewboard.org/users/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fusers%2Fsa=Dsntz=1usg=AFQjCNFyEqttNN29TbXXuEolF2UQXwajng
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Automated merge after review continuous integration

2013-11-25 Thread David Trowbridge
As I said before, this is a very large project and we're currently quite
busy with other things. Until you read about it in the release notes, it
hasn't happened.

-David



On Mon, Nov 25, 2013 at 3:45 AM, Venkateswara Reddy
venkuvenk...@gmail.comwrote:

 any updates on this


 On Thursday, November 7, 2013 4:31:19 PM UTC+5:30, Venkateswara Reddy
 wrote:

 even i am looking for this, let me know if some one did it.
 Vreddy

 On Friday, September 20, 2013 9:30:05 PM UTC+5:30, David Trowbridge wrote:

 There have been no changes to this as yet. We'd like to address this
 eventually but it's a very difficult thing to address in a generic way, and
 for the time being we have other priorities.

  -David


 On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský lubos.r...@gmail.comwrote:

 I have the same question. Is there any way how to merge (from
 ReviewBoard) after acceptance of review?


 On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:

 Hey David,
 This is an older post but im actually looking for exactly these
 things currently and was wondering if these features have been built into
 reviewboard now  / via plugins or are they still in pipeline?

 Thanks,
 M

 On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:

 #2 would be great; I know a lot of people have requested the ability
 to have some indication that the patch submitted will (a) apply cleanly 
 and
 (b) build (maybe even including automated testing).

 #1 is often requested, but it's something which we've been wary of
 because of the complexities of user authentication, audit chains, and the
 abilities it would introduce to break things. It would be a cool feature,
 but I think we'd need to approach it carefully.

 -David


 On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski 
 jan.ko...@gmail.comwrote:

 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two
 things bring my attention:

 1) Gerrit try to merge code automatically after review. This is
 great ability. As far I'm aware when merge won't end with success 
 developer
 get message to rebase their code and send to review again. It will be 
 cool
 to get something similar at reviewboard. I think this approach will for 
 for
 Git and probably for Mercurial too.

 2) Build system integration. I saw Hudson  Gerrit integration which
 assume additional field for build system which check is project build 
 with
 new versions or not. It is well  exposed at
 http://source.android.com/source/life-of-a-patch.html. Will be
 something nice to make accessible some by API checkbox field for build
 system and approach such workflow in reviewboard - optional ofcourse.

 What do You think?

 Regards,

 Jan

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fdonate%2Fsa=Dsntz=1usg=AFQjCNGXNqC_euiTahMwUEszbqikxPUy8w
 Happy user? Let us know at 
 http://www.reviewboard.org/users/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fusers%2Fsa=Dsntz=1usg=AFQjCNFyEqttNN29TbXXuEolF2UQXwajng
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard...@googlegroups.com
 For more options, visit this group at http://groups.google.com/group
 /reviewboard?hl=en


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/
 powerpack/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fpowerpack%2Fsa=Dsntz=1usg=AFQjCNHvNQmuU5sDe3NAVxxmt3e7_0CXHA
 ---
 Sign up for Review Board hosting at RBCommons: 
 https://rbcommons.com/https://www.google.com/url?q=https%3A%2F%2Frbcommons.com%2Fsa=Dsntz=1usg=AFQjCNHb-u2_RY-dBIOlVIqiWd3JbrdivA
 ---

 Happy user? Let us know at 
 http://www.reviewboard.org/users/http://www.google.com/url?q=http%3A%2F%2Fwww.reviewboard.org%2Fusers%2Fsa=Dsntz=1usg=AFQjCNFyEqttNN29TbXXuEolF2UQXwajng
  ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to 

Re: Automated merge after review continuous integration

2013-11-07 Thread Venkateswara Reddy
even i am looking for this, let me know if some one did it.
Vreddy

On Friday, September 20, 2013 9:30:05 PM UTC+5:30, David Trowbridge wrote:

 There have been no changes to this as yet. We'd like to address this 
 eventually but it's a very difficult thing to address in a generic way, and 
 for the time being we have other priorities.

 -David


 On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský 
 lubos.r...@gmail.comjavascript:
  wrote:

 I have the same question. Is there any way how to merge (from 
 ReviewBoard) after acceptance of review?


 On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:

 Hey David,
 This is an older post but im actually looking for exactly these things 
 currently and was wondering if these features have been built into 
 reviewboard now  / via plugins or are they still in pipeline?

 Thanks,
 M

 On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:

 #2 would be great; I know a lot of people have requested the ability to 
 have some indication that the patch submitted will (a) apply cleanly and 
 (b) build (maybe even including automated testing).

 #1 is often requested, but it's something which we've been wary of 
 because of the complexities of user authentication, audit chains, and the 
 abilities it would introduce to break things. It would be a cool feature, 
 but I think we'd need to approach it carefully.

 -David


 On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski jan.ko...@gmail.comwrote:

 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two 
 things bring my attention:

 1) Gerrit try to merge code automatically after review. This is great 
 ability. As far I'm aware when merge won't end with success developer get 
 message to rebase their code and send to review again. It will be cool to 
 get something similar at reviewboard. I think this approach will for for 
 Git and probably for Mercurial too.

 2) Build system integration. I saw Hudson  Gerrit integration which 
 assume additional field for build system which check is project build 
 with 
 new versions or not. It is well  exposed at http://source.android.com/
 **source/life-of-a-patch.htmlhttp://source.android.com/source/life-of-a-patch.html.
  
 Will be something nice to make accessible some by API checkbox field 
 for 
 build system and approach such workflow in reviewboard - optional 
 ofcourse.

 What do You think?

 Regards,

 Jan

 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard...@googlegroups.**com
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en


  -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---

 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Automated merge after review continuous integration

2013-09-20 Thread Luboš Račanský
I have the same question. Is there any way how to merge (from ReviewBoard) 
after acceptance of review?

On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:

 Hey David,
 This is an older post but im actually looking for exactly these things 
 currently and was wondering if these features have been built into 
 reviewboard now  / via plugins or are they still in pipeline?

 Thanks,
 M

 On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:

 #2 would be great; I know a lot of people have requested the ability to 
 have some indication that the patch submitted will (a) apply cleanly and 
 (b) build (maybe even including automated testing).

 #1 is often requested, but it's something which we've been wary of 
 because of the complexities of user authentication, audit chains, and the 
 abilities it would introduce to break things. It would be a cool feature, 
 but I think we'd need to approach it carefully.

 -David


 On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski jan.ko...@gmail.comwrote:

 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two 
 things bring my attention:

 1) Gerrit try to merge code automatically after review. This is great 
 ability. As far I'm aware when merge won't end with success developer get 
 message to rebase their code and send to review again. It will be cool to 
 get something similar at reviewboard. I think this approach will for for 
 Git and probably for Mercurial too.

 2) Build system integration. I saw Hudson  Gerrit integration which 
 assume additional field for build system which check is project build with 
 new versions or not. It is well  exposed at 
 http://source.android.com/source/life-of-a-patch.html. Will be 
 something nice to make accessible some by API checkbox field for build 
 system and approach such workflow in reviewboard - optional ofcourse.

 What do You think?

 Regards,

 Jan

 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Automated merge after review continuous integration

2013-09-20 Thread David Trowbridge
There have been no changes to this as yet. We'd like to address this
eventually but it's a very difficult thing to address in a generic way, and
for the time being we have other priorities.

-David


On Fri, Sep 20, 2013 at 4:32 AM, Luboš Račanský lubos.racan...@gmail.comwrote:

 I have the same question. Is there any way how to merge (from ReviewBoard)
 after acceptance of review?


 On Friday, May 3, 2013 11:05:07 PM UTC+2, mamta.n...@gmail.com wrote:

 Hey David,
 This is an older post but im actually looking for exactly these things
 currently and was wondering if these features have been built into
 reviewboard now  / via plugins or are they still in pipeline?

 Thanks,
 M

 On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:

 #2 would be great; I know a lot of people have requested the ability to
 have some indication that the patch submitted will (a) apply cleanly and
 (b) build (maybe even including automated testing).

 #1 is often requested, but it's something which we've been wary of
 because of the complexities of user authentication, audit chains, and the
 abilities it would introduce to break things. It would be a cool feature,
 but I think we'd need to approach it carefully.

 -David


 On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski jan.ko...@gmail.comwrote:

 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two
 things bring my attention:

 1) Gerrit try to merge code automatically after review. This is great
 ability. As far I'm aware when merge won't end with success developer get
 message to rebase their code and send to review again. It will be cool to
 get something similar at reviewboard. I think this approach will for for
 Git and probably for Mercurial too.

 2) Build system integration. I saw Hudson  Gerrit integration which
 assume additional field for build system which check is project build with
 new versions or not. It is well  exposed at http://source.android.com/*
 *source/life-of-a-patch.htmlhttp://source.android.com/source/life-of-a-patch.html.
 Will be something nice to make accessible some by API checkbox field for
 build system and approach such workflow in reviewboard - optional ofcourse.

 What do You think?

 Regards,

 Jan

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard...@googlegroups.**com
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en


  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---

 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Automated merge after review continuous integration

2013-05-03 Thread mamta . nanavati
Hey David,
This is an older post but im actually looking for exactly these things 
currently and was wondering if these features have been built into 
reviewboard now  / via plugins or are they still in pipeline?

Thanks,
M

On Wednesday, April 20, 2011 3:34:59 PM UTC-7, David Trowbridge wrote:

 #2 would be great; I know a lot of people have requested the ability to 
 have some indication that the patch submitted will (a) apply cleanly and 
 (b) build (maybe even including automated testing).

 #1 is often requested, but it's something which we've been wary of because 
 of the complexities of user authentication, audit chains, and the abilities 
 it would introduce to break things. It would be a cool feature, but I think 
 we'd need to approach it carefully.

 -David


 On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski 
 jan.ko...@gmail.comjavascript:
  wrote:

 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two 
 things bring my attention:

 1) Gerrit try to merge code automatically after review. This is great 
 ability. As far I'm aware when merge won't end with success developer get 
 message to rebase their code and send to review again. It will be cool to 
 get something similar at reviewboard. I think this approach will for for 
 Git and probably for Mercurial too.

 2) Build system integration. I saw Hudson  Gerrit integration which 
 assume additional field for build system which check is project build with 
 new versions or not. It is well  exposed at 
 http://source.android.com/source/life-of-a-patch.html. Will be something 
 nice to make accessible some by API checkbox field for build system and 
 approach such workflow in reviewboard - optional ofcourse.

 What do You think?

 Regards,

 Jan

 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard...@googlegroups.com javascript:
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Automated merge after review continuous integration

2011-04-20 Thread David Trowbridge
#2 would be great; I know a lot of people have requested the ability to have
some indication that the patch submitted will (a) apply cleanly and (b)
build (maybe even including automated testing).

#1 is often requested, but it's something which we've been wary of because
of the complexities of user authentication, audit chains, and the abilities
it would introduce to break things. It would be a cool feature, but I think
we'd need to approach it carefully.

-David


On Thu, Apr 14, 2011 at 10:19 AM, Jan Koprowski jan.koprow...@gmail.comwrote:

 Hi,

 Recently i look at Gerrit - review tool dedicated for git guys. Two things
 bring my attention:

 1) Gerrit try to merge code automatically after review. This is great
 ability. As far I'm aware when merge won't end with success developer get
 message to rebase their code and send to review again. It will be cool to
 get something similar at reviewboard. I think this approach will for for Git
 and probably for Mercurial too.

 2) Build system integration. I saw Hudson  Gerrit integration which assume
 additional field for build system which check is project build with new
 versions or not. It is well  exposed at
 http://source.android.com/source/life-of-a-patch.html. Will be something
 nice to make accessible some by API checkbox field for build system and
 approach such workflow in reviewboard - optional ofcourse.

 What do You think?

 Regards,

 Jan

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en