Re: Unable to upload git patch after upgrading reviewboard to version

[Christian Hammond]

For Git, due to protocol limitations, you'll need to set up a compatible
Git service or, if the upstream Git repository is accessible through direct
file access by Review Board, you'll need to put the path to the .git
directory as the Path field.

Christian


On Sun, Jan 22, 2017 at 21:55 pritesh pagar 
wrote:

> Hi Christian,
>
> The git url you are seeing is hosted on local server running SCM Manager.
>
> Note: Reviewboard is also hosted on same server.
>
> Regards,
> Pritesh
>
>
> On Friday, January 20, 2017 at 1:23:26 PM UTC+5:30, Christian Hammond
> wrote:
>
> Hi Pritesh,
>
> A couple important notes:
>
> 1) Git and Mercurial are not compatible, and Git repositories cannot be
> used with Mercurial repository configurations. It may have appeared to be
> working due to Mercurial understanding a variant of Git diffs, and with the
> local developer using Mercurial and generating Git diffs, but using a local
> Git clone and a Mercurial configuration is not possible. They would have
> different SHAs, and you would not be able to fetch the files from the
> repository.
>
> Unless this is some kind of Git/Mercurial bridge, but I don't know
> anything about your setup. I'll need to know more.
>
> 2) Git's remoting protocol is limited and does not support the kind of
> fine-grained access we require from a remote repository. To use a remote
> Git repository, you need to configure the "raw file URL mask" field, which
> is basically a way to point to some URL that, given a file path and Git
> blob SHA, will return the contents of a file. This requires a service like
> cgit or gitweb.
>
>
> Based on my current understanding, I'm not sure how this would have worked
> before. What service is hosting that URL shown in the screenshot?
>
> Christian
>
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
>
>
> On Thu, Jan 19, 2017 at 9:38 PM, pritesh pagar 
> wrote:
>
> Hi Christian,
>
> Below are the Repo configuration of reviewboard:
>
>
> 
>
> Note:
> 1. In repo configuration, You can see Repo Type is Mercurial even though
> repo is a git repo. This was requirement from some developer and was
> working correctly before upgrade.
> I tried changing repo type to GIT as well, still got same error.
>
> 2. Git repo is hosted on our Inhouse SCM server, not on git cloud.
>
> Regards,
> Pritesh
>
> On Friday, January 20, 2017 at 9:35:39 AM UTC+5:30, Christian Hammond
> wrote:
>
> Hi Pritesh,
>
> Can you show me the configuration for your repository in Review Board?
>
> Do existing review requests work?
>
> How are you generating/uploading the diff?
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
>
>
> On Thu, Jan 19, 2017 at 5:41 AM, pritesh pagar 
> wrote:
>
> Hi,
>
> Recently I upgraded reviewboard from 2.0.15 to 2.5.7.
>
> After upgrade, diff upload for git repo is failng.
>
> *ERROR ON UI:*
> The patch to 'index.js' didn't apply cleanly. The temporary files have
> been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
> `patch` returned:
>
> This may be a bug in the software, a temporary outage, or an issue with
> the format of your diff.
>
> *After debugging, I found following error in reviewboard error logs:*
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
> line 299, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> 

Re: Unable to upload git patch after upgrading reviewboard to version

[pritesh pagar]

Hi Christian,

The git url you are seeing is hosted on local server running SCM Manager.

Note: Reviewboard is also hosted on same server.

Regards,
Pritesh

On Friday, January 20, 2017 at 1:23:26 PM UTC+5:30, Christian Hammond wrote:
>
> Hi Pritesh,
>
> A couple important notes:
>
> 1) Git and Mercurial are not compatible, and Git repositories cannot be 
> used with Mercurial repository configurations. It may have appeared to be 
> working due to Mercurial understanding a variant of Git diffs, and with the 
> local developer using Mercurial and generating Git diffs, but using a local 
> Git clone and a Mercurial configuration is not possible. They would have 
> different SHAs, and you would not be able to fetch the files from the 
> repository.
>
> Unless this is some kind of Git/Mercurial bridge, but I don't know 
> anything about your setup. I'll need to know more.
>
> 2) Git's remoting protocol is limited and does not support the kind of 
> fine-grained access we require from a remote repository. To use a remote 
> Git repository, you need to configure the "raw file URL mask" field, which 
> is basically a way to point to some URL that, given a file path and Git 
> blob SHA, will return the contents of a file. This requires a service like 
> cgit or gitweb.
>
>
> Based on my current understanding, I'm not sure how this would have worked 
> before. What service is hosting that URL shown in the screenshot?
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Thu, Jan 19, 2017 at 9:38 PM, pritesh pagar  > wrote:
>
>> Hi Christian,
>>
>> Below are the Repo configuration of reviewboard:
>>
>>
>> 
>>
>> Note:
>> 1. In repo configuration, You can see Repo Type is Mercurial even though 
>> repo is a git repo. This was requirement from some developer and was 
>> working correctly before upgrade.
>> I tried changing repo type to GIT as well, still got same error.
>>
>> 2. Git repo is hosted on our Inhouse SCM server, not on git cloud.
>>
>> Regards,
>> Pritesh
>>
>> On Friday, January 20, 2017 at 9:35:39 AM UTC+5:30, Christian Hammond 
>> wrote:
>>>
>>> Hi Pritesh,
>>>
>>> Can you show me the configuration for your repository in Review Board?
>>>
>>> Do existing review requests work?
>>>
>>> How are you generating/uploading the diff?
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Thu, Jan 19, 2017 at 5:41 AM, pritesh pagar  
>>> wrote:
>>>
 Hi,

 Recently I upgraded reviewboard from 2.0.15 to 2.5.7.

 After upgrade, diff upload for git repo is failng.

 *ERROR ON UI:*
 The patch to 'index.js' didn't apply cleanly. The temporary files have 
 been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
 `patch` returned: 

 This may be a bug in the software, a temporary outage, or an issue with 
 the format of your diff.

 *After debugging, I found following error in reviewboard error logs:*
 Traceback (most recent call last):
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
  
 line 299, in get
 response = renderer.render_to_response(request)
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 56, in render_to_response
 return HttpResponse(self.render_to_string(request))
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 74, in render_to_string
 large_data=True)
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
  
 line 295, in cache_memoize
 compress_large_data))
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
  
 line 249, in cache_memoize_iter
 items = items_or_callable()
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
  
 line 292, in 
 lambda: [lookup_callable()],
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 73, in 
 lambda: self.render_to_string_uncached(request),
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 87, in render_to_string_uncached
 request=request)
   File 
 

Re: Unable to upload git patch after upgrading reviewboard to version

[Christian Hammond]

Hi Pritesh,

A couple important notes:

1) Git and Mercurial are not compatible, and Git repositories cannot be
used with Mercurial repository configurations. It may have appeared to be
working due to Mercurial understanding a variant of Git diffs, and with the
local developer using Mercurial and generating Git diffs, but using a local
Git clone and a Mercurial configuration is not possible. They would have
different SHAs, and you would not be able to fetch the files from the
repository.

Unless this is some kind of Git/Mercurial bridge, but I don't know anything
about your setup. I'll need to know more.

2) Git's remoting protocol is limited and does not support the kind of
fine-grained access we require from a remote repository. To use a remote
Git repository, you need to configure the "raw file URL mask" field, which
is basically a way to point to some URL that, given a file path and Git
blob SHA, will return the contents of a file. This requires a service like
cgit or gitweb.


Based on my current understanding, I'm not sure how this would have worked
before. What service is hosting that URL shown in the screenshot?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Thu, Jan 19, 2017 at 9:38 PM, pritesh pagar 
wrote:

> Hi Christian,
>
> Below are the Repo configuration of reviewboard:
>
>
> 
>
> Note:
> 1. In repo configuration, You can see Repo Type is Mercurial even though
> repo is a git repo. This was requirement from some developer and was
> working correctly before upgrade.
> I tried changing repo type to GIT as well, still got same error.
>
> 2. Git repo is hosted on our Inhouse SCM server, not on git cloud.
>
> Regards,
> Pritesh
>
> On Friday, January 20, 2017 at 9:35:39 AM UTC+5:30, Christian Hammond
> wrote:
>>
>> Hi Pritesh,
>>
>> Can you show me the configuration for your repository in Review Board?
>>
>> Do existing review requests work?
>>
>> How are you generating/uploading the diff?
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Thu, Jan 19, 2017 at 5:41 AM, pritesh pagar 
>> wrote:
>>
>>> Hi,
>>>
>>> Recently I upgraded reviewboard from 2.0.15 to 2.5.7.
>>>
>>> After upgrade, diff upload for git repo is failng.
>>>
>>> *ERROR ON UI:*
>>> The patch to 'index.js' didn't apply cleanly. The temporary files have
>>> been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
>>> `patch` returned:
>>>
>>> This may be a bug in the software, a temporary outage, or an issue with
>>> the format of your diff.
>>>
>>> *After debugging, I found following error in reviewboard error logs:*
>>> Traceback (most recent call last):
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> py2.7.egg/reviewboard/diffviewer/views.py", line 299, in get
>>> response = renderer.render_to_response(request)
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> py2.7.egg/reviewboard/diffviewer/renderers.py", line 56, in
>>> render_to_response
>>> return HttpResponse(self.render_to_string(request))
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> py2.7.egg/reviewboard/diffviewer/renderers.py", line 74, in
>>> render_to_string
>>> large_data=True)
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>> line 295, in cache_memoize
>>> compress_large_data))
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>> line 249, in cache_memoize_iter
>>> items = items_or_callable()
>>>   File 
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>> line 292, in 
>>> lambda: [lookup_callable()],
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> py2.7.egg/reviewboard/diffviewer/renderers.py", line 73, in 
>>> lambda: self.render_to_string_uncached(request),
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> py2.7.egg/reviewboard/diffviewer/renderers.py", line 87, in
>>> render_to_string_uncached
>>> request=request)
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> py2.7.egg/reviewboard/diffviewer/diffutils.py", line 667, in
>>> populate_diff_chunks
>>> chunks = list(generator.get_chunks())
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 756, in
>>> get_chunks
>>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-
>>> 

Re: Unable to upload git patch after upgrading reviewboard to version

[pritesh pagar]

Hi Christian,

Below are the Repo configuration of reviewboard:



Note:
1. In repo configuration, You can see Repo Type is Mercurial even though 
repo is a git repo. This was requirement from some developer and was 
working correctly before upgrade.
I tried changing repo type to GIT as well, still got same error.

2. Git repo is hosted on our Inhouse SCM server, not on git cloud.

Regards,
Pritesh

On Friday, January 20, 2017 at 9:35:39 AM UTC+5:30, Christian Hammond wrote:
>
> Hi Pritesh,
>
> Can you show me the configuration for your repository in Review Board?
>
> Do existing review requests work?
>
> How are you generating/uploading the diff?
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Thu, Jan 19, 2017 at 5:41 AM, pritesh pagar  > wrote:
>
>> Hi,
>>
>> Recently I upgraded reviewboard from 2.0.15 to 2.5.7.
>>
>> After upgrade, diff upload for git repo is failng.
>>
>> *ERROR ON UI:*
>> The patch to 'index.js' didn't apply cleanly. The temporary files have 
>> been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
>> `patch` returned: 
>>
>> This may be a bug in the software, a temporary outage, or an issue with 
>> the format of your diff.
>>
>> *After debugging, I found following error in reviewboard error logs:*
>> Traceback (most recent call last):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
>>  
>> line 299, in get
>> response = renderer.render_to_response(request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 56, in render_to_response
>> return HttpResponse(self.render_to_string(request))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 74, in render_to_string
>> large_data=True)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 295, in cache_memoize
>> compress_large_data))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 249, in cache_memoize_iter
>> items = items_or_callable()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 292, in 
>> lambda: [lookup_callable()],
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 73, in 
>> lambda: self.render_to_string_uncached(request),
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 87, in render_to_string_uncached
>> request=request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 667, in populate_diff_chunks
>> chunks = list(generator.get_chunks())
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 756, in get_chunks
>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 107, in get_chunks
>> large_data=True)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 295, in cache_memoize
>> compress_large_data))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 249, in cache_memoize_iter
>> items = items_or_callable()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 292, in 
>> lambda: [lookup_callable()],
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 106, in 
>> lambda: list(self.get_chunks_uncached()),
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 763, in get_chunks_uncached
>> new = get_patched_file(old, self.filediff, self.request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 233, in get_patched_file
>> return patch(diff, buffer, filediff.dest_file, request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 169, in patch
>> 'output': 

Re: Unable to upload git patch after upgrading reviewboard to version

[Christian Hammond]

Hi Pritesh,

Can you show me the configuration for your repository in Review Board?

Do existing review requests work?

How are you generating/uploading the diff?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Thu, Jan 19, 2017 at 5:41 AM, pritesh pagar 
wrote:

> Hi,
>
> Recently I upgraded reviewboard from 2.0.15 to 2.5.7.
>
> After upgrade, diff upload for git repo is failng.
>
> *ERROR ON UI:*
> The patch to 'index.js' didn't apply cleanly. The temporary files have
> been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
> `patch` returned:
>
> This may be a bug in the software, a temporary outage, or an issue with
> the format of your diff.
>
> *After debugging, I found following error in reviewboard error logs:*
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/views.py", line 299, in get
> response = renderer.render_to_response(request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/renderers.py", line 56, in
> render_to_response
> return HttpResponse(self.render_to_string(request))
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/renderers.py", line 74, in
> render_to_string
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-
> py2.7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-
> py2.7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-
> py2.7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/renderers.py", line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/renderers.py", line 87, in
> render_to_string_uncached
> request=request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 667, in
> populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 756, in
> get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 107, in
> get_chunks
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-
> py2.7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-
> py2.7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-
> py2.7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 106, in
> 
> lambda: list(self.get_chunks_uncached()),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 763, in
> get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 233, in
> get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 7-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 169, in patch
> 'output': stderr,
> Exception: The patch to 'index.js' didn't apply cleanly. The temporary
> files have been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
> `patch` returned:
>
>
> *Could this error be caused because of GIT version and REVIEBOARD version
> incompatibility, or could it be something else?*
>
> *Note: This issue is only in case of git patch upload, patch of mercurial
> repo is uploaded correctly.*
>
> Regards,
> Pritesh
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop 

Unable to upload git patch after upgrading reviewboard to version

[pritesh pagar]

Hi,

Recently I upgraded reviewboard from 2.0.15 to 2.5.7.

After upgrade, diff upload for git repo is failng.

*ERROR ON UI:*
The patch to 'index.js' didn't apply cleanly. The temporary files have been 
left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
`patch` returned: 

This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff.

*After debugging, I found following error in reviewboard error logs:*
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 299, in get
response = renderer.render_to_response(request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string
large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in 
lambda: self.render_to_string_uncached(request),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached
request=request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 667, in populate_diff_chunks
chunks = list(generator.get_chunks())
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks
large_data=True)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 295, in cache_memoize
compress_large_data))
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 249, in cache_memoize_iter
items = items_or_callable()
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-0.9.4-py2.7.egg/djblets/cache/backend.py",
 
line 292, in 
lambda: [lookup_callable()],
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in 
lambda: list(self.get_chunks_uncached()),
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch
'output': stderr,
Exception: The patch to 'index.js' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.cMAy_Q' for debugging purposes.
`patch` returned: 

   
*Could this error be caused because of GIT version and REVIEBOARD version 
incompatibility, or could it be something else?*

*Note: This issue is only in case of git patch upload, patch of mercurial 
repo is uploaded correctly.*

Regards,
Pritesh

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.