Issue 585 in reviewboard: post-review dies when binaries are part of a p4 changeset
Updates: Status: Fixed Comment #3 on issue 585 by chipx86: post-review dies when binaries are part of a p4 changeset http://code.google.com/p/reviewboard/issues/detail?id=585 Fixed in r1862. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 909 in reviewboard: Add ship it status for logged in user in the dashboard.
Updates: Status: Fixed Labels: Milestone-Release1.0 Comment #4 on issue 909 by chipx86: Add ship it status for logged in user in the dashboard. http://code.google.com/p/reviewboard/issues/detail?id=909 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 991 in reviewboard: post-review.py does not trim whitespace before comparing a string in diff
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 991 by bengchuan79: post-review.py does not trim whitespace
before comparing a string in diff
http://code.google.com/p/reviewboard/issues/detail?id=991
at line 1486, in def diff(self, args):
if len(dl) == 1 and \
dl[0] == ('Files %s and %s differ'% (old_file, new_file)):
While using with Perforce, dl[0] appears to have a whitespace. This causes
the string comparison failed.
Proposed solution:
if len(dl) == 1 and \
string.strip(dl[0]) == ('Files %s and %s differ'% (old_file,
new_file)):
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 658 in reviewboard: Error : The patch to 'filepath' didn't apply cleanly.
Comment #2 on issue 658 by miguel.rgonzalez: Error : The patch to 'filepath' didn't apply cleanly. http://code.google.com/p/reviewboard/issues/detail?id=658 same issue here. I get the same error when posting reviews for newly created file (nothing to diff against) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 992 in reviewboard: Trailing slash in SVN repository confused post-review
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 992 by nick.las...@kaseya.com: Trailing slash in SVN repository confused post-review http://code.google.com/p/reviewboard/issues/detail?id=992 What's the URL of the page containing the problem? post-review What steps will reproduce the problem? 1. Setup a SVN repository in Review Board such as https://code.google.com/svn/ 2. Run post-review tool on that URL 3. Get an error message saying the repository was not found 4. Change it to https://code.google.com/svn and see that everything works. What is the expected output? What do you see instead? The trailing slash should not matter. What operating system are you using? What browser? Windows client, Ubuntu host. The error comes from the server. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
