Re: Issue 643 in reviewboard: Getting Unable to find RCS line error while using svn
Comment #2 on issue 643 by arunbalaji1985: Getting Unable to find RCS line error while using svn http://code.google.com/p/reviewboard/issues/detail?id=643 Hello, I am facing this issue while trying to use reviewboard with svn. You'll need to fix the repository's configuration to use SVN and not CVS in the admin UI. In the admin page I have set the repository type to be CVS only. I am getting this error on post review of the request to the RB server. {'fields': {'path': ['Unable to find RCS line']}, 'stat': 'fail', 'err': {'msg': 'One or more fields had errors', 'code': 105}} =Arun -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 643 in reviewboard: Getting Unable to find RCS line error while using svn
Comment #3 on issue 643 by arunbalaji1985: Getting Unable to find RCS line error while using svn http://code.google.com/p/reviewboard/issues/detail?id=643 Please read In the admin page I have set the repository type to be CVS only. as In the admin page I have set the repository type to be Subversion only. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1359 in reviewboard: Diff fails for text file with non-ascii characters
Comment #2 on issue 1359 by fiddur: Diff fails for text file with non-ascii characters http://code.google.com/p/reviewboard/issues/detail?id=1359 There is error-handling to be set for unicode and encode-functions. See http://www.amk.ca/python/howto/unicode I had this problem in post-review, and changed: value = files[key]['content'] into: value = unicode(files[key]['content'], errors='replace') -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1511 in reviewboard: Diff is not visible, but downloadable
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1511 by AaronJSherman: Diff is not visible, but downloadable http://code.google.com/p/reviewboard/issues/detail?id=1511 What version are you running? 1.0.5.1 What's the URL of the page containing the problem? Not public, sadly What steps will reproduce the problem? We can reproduce this issue with a given Perforce changeset, but cannot reproduce it with a new change, so we're not sure how to go about reproducing this in the wild. The issue is this: User uploaded a change from Perforce via post-review. The change consists of just over 100 lines of diff with 2 distinct edits. There was no error reported by post-review and no errors appeared in the logs. When the user visits the review, there is no diff. In fact, when we look at the HTML, the entire table (class=sidebyside) is missing. The page goes from div id=diffs to the javascript that normally comes after the table. Looking at the logs again, generating this page produced no errors and what's really strange is that the diff WAS uploaded just fine, and clicking Download Diff yields a perfectly acceptable diff file. What can I provide that will help to track this down? Unfortunately, I can't just upload our code, but if someone tells me what to look for, I'll happily go probing and report back. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1381 in reviewboard: diff update doesn't work in web GUI and in post-review utility
Updates: Status: Fixed Comment #4 on issue 1381 by trowbrds: diff update doesn't work in web GUI and in post-review utility http://code.google.com/p/reviewboard/issues/detail?id=1381 Going to assume fixed, then. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1427 in reviewboard: Problems with post-review while uploading diffs
Comment #4 on issue 1427 by trowbrds: Problems with post-review while uploading diffs http://code.google.com/p/reviewboard/issues/detail?id=1427 The error really looks like it's trying to use the bzr SCMTool. It's possible that it's maybe confused indexing the tool into the database but we've never seen this before. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1512 in reviewboard: after upgrade to 1.5 beta1 expand in the diff body has no effect
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1512 by Dmitry.Litvintsev: after upgrade to 1.5 beta1 expand in the diff body has no effect http://code.google.com/p/reviewboard/issues/detail?id=1512 after upgrade to 1.5 beta1 expand in the diff body has no effect If I click on Expand link while viewing diff nothing happens. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1512 in reviewboard: after upgrade to 1.5 beta1 expand in the diff body has no effect
Updates: Status: Duplicate Mergedinto: 1500 Comment #1 on issue 1512 by chipx86: after upgrade to 1.5 beta1 expand in the diff body has no effect http://code.google.com/p/reviewboard/issues/detail?id=1512 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1500 in reviewboard: xx lines hidden [Expand] link stopped working
Comment #5 on issue 1500 by chipx86: xx lines hidden [Expand] link stopped working http://code.google.com/p/reviewboard/issues/detail?id=1500 Issue 1512 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1511 in reviewboard: Diffs containing only indentation changes causes the diff viewer to look empty
Updates: Summary: Diffs containing only indentation changes causes the diff viewer to look empty Status: Confirmed Labels: -Priority-Medium Priority-Low Component-DiffViewer Comment #1 on issue 1511 by chipx86: Diffs containing only indentation changes causes the diff viewer to look empty http://code.google.com/p/reviewboard/issues/detail?id=1511 Okay, I've investigated this a little and it can basically be reproduced with a diff such as: --- filename.foo (...) +++ filename.foo (...) @@ ... @@ Some text Some text - Foo + Foo Blah blah - /Foo + /Foo Notice how the only thing that is changing is the indentation. To Review Board, this really means nothing has changed. We don't show leading whitespace changes. So, internally, it's finding that nothing has changed with the code and when we go to render this and see no changed chunks, we consider this to be a file in the changeset without any changes and we remove it from the list. This is important for interdiffs, which is mostly why the logic is there. So, this particular diff in question isn't doing anything but changing indentation and Review Board is therefore not seeing that anything is really up for review. We probably should be a little more graceful about this, but I will point out that this is the first time we've seen this sort of an issue where a diff containing nothing but indentation changes has gone up and confused people. We can look at may be special-casing non-interdiffs and displaying some indication that the file hasn't changed. Given the rarity of the case, though, it's not a huge priority at the moment. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.