Re: Issue 1539 in reviewboard: 'WatchedGroupDataGrid' object has no attribute 'counts'

2010-05-13 Thread reviewboard


Comment #2 on issue 1539 by lonico: 'WatchedGroupDataGrid' object has no  
attribute 'counts'

http://code.google.com/p/reviewboard/issues/detail?id=1539

I'm still seeing the issue on 1.5 Beta 2:
http://demo.reviewboard.org/dashboard/?view=watched-groups
(or my private installation).

From the main dashboard, you have to click on "Watched Groups" to trigger  
the error.

Clicking on any of the groups under Watched Groups looks OK.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1133 in reviewboard: API to obtain the logged in user's name.

2010-05-13 Thread reviewboard


Comment #6 on issue 1133 by diwakergupta: API to obtain the logged in  
user's name.

http://code.google.com/p/reviewboard/issues/detail?id=1133

I'd be perfectly happy with this approach. In fact, in my original request  
I said:


"I went through the JSON API but I'm at a loss to find a call that either  
gives me all
the review requests for the logged in user, or some easy way to obtain the  
username of
the logged in user first and then use that to get the list of review  
requests."


So yes, a way to get at the user name would be perfect!

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1133 in reviewboard: API to obtain the logged in user's name.

2010-05-13 Thread reviewboard

Updates:
Summary: API to obtain the logged in user's name.
Status: Confirmed

Comment #5 on issue 1133 by chipx86: API to obtain the logged in user's  
name.

http://code.google.com/p/reviewboard/issues/detail?id=1133

There likely won't be any resource path for "The logged in user's  
".
Instead, what I want to do is make it easier to find out the logged in  
user, and use
that for paths, so that we don't end up duplicating all the resources out  
there.

Otherwise, we'll get requests for the logged in user's:

* review requests
* reviews
* comments
* watched groups
* watched review requests
* profile information

etc

That's just a lot of extra stuff to maintain, and I don't want to go that  
route. I'll
repurpose this bug to make sure we add something for finding out the logged  
in user's
name and information. Perhaps even linking to prebuilt queries for things  
like the

review requests.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1133 in reviewboard: API to obtain reviews for the logged in user

2010-05-13 Thread reviewboard


Comment #4 on issue 1133 by diwakergupta: API to obtain reviews for the  
logged in user

http://code.google.com/p/reviewboard/issues/detail?id=1133

I'm aware of this API. However, the problem is calling this API without  
having to
specify the username. Consider this concrete example. Say I want to extend  
post-

review to list all of my unsubmitted reviews:

$ post-review.py --list

In the common case, I already have a valid cookie, so post-review won't ask  
for my
username. As a consequence, when post-review runs, it doesn't explicitly  
know the
username at all. The whole point of this issue was that there is no  
mechanism to list
the issues for the "current/logged in" user, nor is there a mechanism to  
fetch the

username of the logged-in user.

I hope that clarifies. IIUC, the API still hasn't changed to support the  
behavior

described in this issue.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1649 in reviewboard: Commenting on a screenshot with an existing comment can accidentally select the old comment's region

2010-05-13 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1649 by swtaarrs: Commenting on a screenshot with an existing  
comment can accidentally select the old comment's region

http://code.google.com/p/reviewboard/issues/detail?id=1649

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0.6

What's the URL of the page containing the problem?
Inside my company's VPN (chipx86 has access to it and has seen the issue).

What steps will reproduce the problem?
1. Start with a screenshot that has an existing published comment
2. Click & drag to create a new comment, with your initial click somewhere
inside the region of the existing comment.

What is the expected output? What do you see instead?
Expected: My new comment will quote the region I selected
Actual: My new comment quotes the region of the old comment, since I
clicked inside it to create the new region

What operating system are you using? What browser?
Ubuntu 9.10 x64, Firefox 3.5.9

Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1648 in reviewboard: post-review throws an exception for Perforce changesets with huge descriptions.

2010-05-13 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1648 by jtsharma: post-review throws an exception for Perforce  
changesets with huge descriptions.

http://code.google.com/p/reviewboard/issues/detail?id=1648

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0.6

What's the URL of the page containing the problem?
path:/r//,

What steps will reproduce the problem?
Just have a huge change description with tons of testing details.

What is the expected output? What do you see instead?
post-review to generate a smart error telling users how to fix their change
description.

What operating system are you using? What browser?
Linux

Please provide any additional information below.

Added Christian's note here for your reference.


they probably put in a huge Description or Testing field again
we serialize a change descrption in the database, but if it's too long,

the DB can truncate it

really need to just artificially enforce a limit..
this is a database limit
if you can file a bug against RB, I can look into some ways to be smarter

about it


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.