Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #48 on issue 1072 by o3j5h9s3: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 old thread but maybe the workaround I found may help some. thou apache is running as apache user the home I got by adding log to the py is ERROR:root:Home directory = /root. Which I guess it the home of the apache root process. But the process running RB is running as apache user and thus cant access the root/.subversion folder. In short I did chown -r apache:apache /root and now it all works fine. real ugly I know -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1587 in reviewboard: Some lines don't word-wrap correctly on IE/Chrome
Comment #5 on issue 1587 by seagle0128: Some lines don't word-wrap correctly on IE/Chrome http://code.google.com/p/reviewboard/issues/detail?id=1587 Some lines like this: Name=VCCLCompilerTool AdditionalIncludeDirectories=.;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\SRC\pscan\res\pscanresquot;;quot;$(SolutionDir)Pscan\RTVScanquot;;quot;$(IntDir)\MIDLquot;;quot;$(SolutionDir)includequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\SRC\pscanquot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\src\GEDataStorequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\SRC\NAV_Gluequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\SRC\includequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\SRC\PScan\DefWatchquot;;quot;$(Root)core_technology\ldvp_shared\src\include\GEDataStorequot;;quot;$(Root)SymSDK\QServer\Includequot;;quot;$(Root)yyy_yyy\STG_Platform\autoprotect\includequot;;quot;$(Root)xxx_xxx\Shared\MD5\Includequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\src\utils\sym_templates\includequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\src\Utils\sym_synch\includequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\src\Utils\sym_time\includequot;;quot;$(Root)xxx_xxx\Corporate_Edition\COMMON\SRC\rtquot;;quot;$(Root)Shareable_code\licensed\InternetSecurity\includequot;;quot;$(Root)Shareable_code\unlicensedquot;;quot;$(Root)yyy_yyy\STG_Platform\Eraser\includequot;;quot;$(Root)yyy_yyy\STG_Platform\DefUtils\includequot;;quot;$(Root)components\SystemSnapshot\SysSnapquot;;quot;$(Root)yyy_yyy\STG_Platform\AVE\includequot;;quot;$(Root)components\ScanAndDeliver\src\includequot;;quot;$(SolutionDir)Pscan\RTVScan\UIMgmtquot;;quot;$(SolutionDir)Pscan\RTVScan\Impersonationquot;;quot;$(SolutionDir)Pscan\RTVScan\WTSquot;;quot;$(Root)xxx_xxx\corporate_edition\win32\src\pscan\rtvscan\OEMquot;;quot;$(Root)xxx_xxx\corporate_edition\win32\src\pscan\rtvscan\Logonquot;;quot;$(Root)tools\Crypto-C\includequot;;quot;$(Root)yyy_yyy\STG_Platform\DecABI\includequot;;quot;$(Root)xxx_xxx\corporate_edition\win32\src\pscan\symprotectstoragequot;;quot;$(SolutionDir)Submitter\includequot;;quot;$(Root)yyy_yyy\Client_Management\src\includequot;;quot;$(Root)yyy_yyy\Client_Management\src\Smc\src\Smcquot;;quot;$(Root)yyy_yyy\Client_Management\src\Smc\src\Incquot;;quot;$(Root)tools\ATLServer\includequot;;quot;$(Root)Tools\Crypto-C\includequot;;quot;$(Root)yyy_yyy\STG_Platform\BASH_Framework\includequot;;quot;$(Root)yyy_yyy\STG_Platform\IRON\includequot;;quot;$(SolutionDir)BASH\Common\srcquot;;quot;$(SolutionDir)BASH\includequot;;quot;$(SolutionDir)ATPI\includequot;;quot;$(SolutionDir)ATPI\AtpiTimquot;;quot;$(SolutionDir)CIDS\includequot;;quot;$(SolutionDir)common\TimSharedquot;;quot;$(Root)yyy_yyy\STG_Platform\CC\include\ccJobMgrquot;;quot;$(Root)yyy_yyy\STG_Platform\CC\include\ccSubSDKquot;;quot;$(SolutionDir)Submissions\Common\GeneratedHeadersquot;;quot;$(SolutionDir)Submissions\Includequot;;quot;$(Root)yyy_yyy\Client_Management\src\SylinkEx\src\SylinkCommonquot;;quot;$(Root)yyy_yyy\Client_Management\src\LUE\includequot;;quot;$(Root)yyy_yyy\Client_Management\src\include\AgentCorequot;;quot;$(Root)yyy_yyy\Client_Management\src\AgentCore\Wrappersquot;;quot;$(Root)Core_Technology\LDVP_Shared\src\Common\RTquot;;quot;$(Root)yyy_yyy\STG_Platform\SymEFA\includequot;;quot;$(Root)sarc\ecom\PreRelease\2010\2010.1\latest\includequot;;quot;$(Root)yyy_yyy\STG_Platform\SymDS\includequot;;quot;$(Root)Core_Technology\LDVP_Shared\src\Common\DBAccessquot;;quot;$(Root)yyy_yyy\Client_Management\src\RebootMgr\includequot;;quot;$(Root)xxx_xxx\Corporate_Edition\Win32\src\commonquot; PreprocessorDefinitions=_DEBUG;_CRTDBG_MAP_ALLOC;_CONSOLE;WINNT;WIN32;_WIN32_WINNT=0x0501;_WINDOWS;_WIN32_DCOM;SERVICE;REAL_SERVICE;SERVER;SER;COMMON_CLIENT_DECOMPOSER;COMMON_CLIENT_SCAN;EVENT_CUSTOM_INFO_CREATE;MULTITHREADED_SCANS;RESUMABLE_SCANS;OEH_SCAN;DISABLE_COM_SNAPSERVER;USE_DPRINTF;IDEFUTILSLOADER_IMPORTED;CCSVCHST_PLUGIN -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1686 in reviewboard: New feature request: code commentary
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 1686 by AaronJSherman: New feature request: code commentary http://code.google.com/p/reviewboard/issues/detail?id=1686 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.0.7 What's the URL of the page this enhancement relates to, if any? N/A Describe the enhancement and the motivation for it. We'd love to see a way to add commentary on code before publishing a review in order to explain changes inline in a similar fashion to reviewing inline. Some slightly different UI elements might make sense for this, though: * A different visual cue to highlight the comment for reviewers as they read the diffs * Ability to reply to such a note, thus attaching the review comment to the line of code AND to the note so that both contexts are preserved on the reviews page. * Perhaps a set of links on the main review page under the description to the notes. Here's a use case: I modify GNU fsutils to make rm not delete symlinks when provided a --no-symlinks option. I post a review, but before publishing, I want to explain inline that the use of stat and not lstat in a given section of code was a conscious choice, and yielded an important benefit. I make this comment on that particular line of code and then reviewers can respond more cogently. What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request
Comment #13 on issue 831 by trowbrds: Can't leave comments before you publish your own newly created review request http://code.google.com/p/reviewboard/issues/detail?id=831 Issue 1686 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1686 in reviewboard: New feature request: code commentary
Updates: Status: Duplicate Mergedinto: 831 Comment #1 on issue 1686 by trowbrds: New feature request: code commentary http://code.google.com/p/reviewboard/issues/detail?id=1686 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request
Comment #14 on issue 831 by AaronJSherman: Can't leave comments before you publish your own newly created review request http://code.google.com/p/reviewboard/issues/detail?id=831 Since my issue 1686 was marked as a dup of this, let me cover what I think are the extras from that request that would pertain, here: Leaving comments on my own review is primarily useful, I think, because of the desire to leave notes to the other reviewers. As such, the marker for such comments should definitely be visually distinct and the UI should make it clear that it's not just another reviewer commenting on the same section of code. Also, a list of links to the notes under the description would really help to emphasize their importance to the reviewers. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1072 in reviewboard: HTTPS Subversion repositories don't work with Review Board
Comment #49 on issue 1072 by chipx86: HTTPS Subversion repositories don't work with Review Board http://code.google.com/p/reviewboard/issues/detail?id=1072 In new installs, HOME will point to a writable directory, which should solve this problem. In new upgrades, rb-site will tell the user how to update their config to fix the home directory. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
