Re: Issue 1587 in reviewboard: Some lines don't word-wrap correctly on IE/Chrome
Comment #8 on issue 1587 by seagle0128: Some lines don't word-wrap correctly on IE/Chrome http://code.google.com/p/reviewboard/issues/detail?id=1587 Okay! I see. But I don't understand why it's good on Firefox. Now I have to recommend others to use Firefox to visit the reviewboard. Thanks for your update anyway. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1637 in reviewboard: Review Board + perforce can not upload diff
Comment #4 on issue 1637 by bweav19: Review Board + perforce can not upload
diff
http://code.google.com/p/reviewboard/issues/detail?id=1637
I have the same issue, here is what my debug output looks like
[r...@re ~]# post-review 513239 --debug
svn info
p4 info
repository info: Path: p4master-atl01.us.msudev.noklab.net:1680, Base
path: None, Supports changesets: True
p4 counters
Generating diff for changenum 513239
p4 describe -s 513239
Processing edit of //depot/syncsuite/cas/trunk/rpm/build.xml
Writing //depot/syncsuite/cas/trunk/rpm/build.xml#15
to /tmp/tmpWRRyXF
p4 print -o /tmp/tmpWRRyXF -q
//depot/syncsuite/cas/trunk/rpm/build.xml#15
Writing //depot/syncsuite/cas/trunk/rpm/build.xml#16
to /tmp/tmpmqWes7
p4 print -o /tmp/tmpmqWes7 -q
//depot/syncsuite/cas/trunk/rpm/build.xml#16
diff -urNp /tmp/tmpWRRyXF /tmp/tmpmqWes7
Looking for 're.us.msudev.noklab.net /reviewboard/' cookie in
/root/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on
p4master-atl01.us.msudev.noklab.net:1680 for 513239
HTTP POSTing to
http://re.us.msudev.noklab.net/reviewboard/api/json/reviewrequests/new/:
{'repository_path': 'p4master-atl01.us.msudev.noklab.net:1680', 'changenum': '513239'}
Review request created
Uploading diff, size: 566
HTTP POSTing to
http://re.us.msudev.noklab.net/reviewboard/api/json/reviewrequests/9/diff/new/:
{}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['[Errno 2] No such file or
directory']}, 'stat': 'fail', 'err': {'msg': 'One or more fields had
errors', 'code': 105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1637 in reviewboard: Review Board + perforce can not upload diff
Comment #5 on issue 1637 by bweav19: Review Board + perforce can not upload
diff
http://code.google.com/p/reviewboard/issues/detail?id=1637
I have the exact same issue, here is my output with debug but not
output-diff. As a note this is a brand new reviewboard server and my first
time setting it up.
#post-review 513239 --debug
svn info
p4 info
repository info: Path: p4server-atl01.us.msudev.lab.net:1680, Base
path: None, Supports changesets: True
p4 counters
Generating diff for changenum 513239
p4 describe -s 513239
Processing edit of //depot/syncsuite/cas/trunk/rpm/build.xml
Writing //depot/syncsuite/cas/trunk/rpm/build.xml#15
to /tmp/tmpWRRyXF
p4 print -o /tmp/tmpWRRyXF -q
//depot/syncsuite/cas/trunk/rpm/build.xml#15
Writing //depot/syncsuite/cas/trunk/rpm/build.xml#16
to /tmp/tmpmqWes7
p4 print -o /tmp/tmpmqWes7 -q
//depot/syncsuite/cas/trunk/rpm/build.xml#16
diff -urNp /tmp/tmpWRRyXF /tmp/tmpmqWes7
Looking for 're.us.msudev.lab.net /reviewboard/' cookie in
/root/.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on
p4server-atl01.us.msudev.lab.net:1680 for 513239
HTTP POSTing to
http://re.us.msudev.lab.net/reviewboard/api/json/reviewrequests/new/:
{'repository_path': 'p4server-atl01.us.msudev.lab.net:1680', 'changenum': '513239'}
Review request created
Uploading diff, size: 566
HTTP POSTing to
http://re.us.msudev.lab.net/reviewboard/api/json/reviewrequests/9/diff/new/:
{}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['[Errno 2] No such file or
directory']}, 'stat': 'fail', 'err': {'msg': 'One or more fields had
errors', 'code': 105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1587 in reviewboard: Some lines don't word-wrap correctly on IE/Chrome
Comment #9 on issue 1587 by chipx86: Some lines don't word-wrap correctly on IE/Chrome http://code.google.com/p/reviewboard/issues/detail?id=1587 It's a difference in how Firefox and other browsers choose to handle long normally unwrappable lines. Firefox is forcing a wrap, whereas the others are not. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1687 in reviewboard: post-review API Error 105
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1687 by Anthony.L.Chen: post-review API Error 105
http://code.google.com/p/reviewboard/issues/detail?id=1687
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
RBTools 0.2, Rb 1.5B2
What's the URL of the page containing the problem?
internal network lab
What steps will reproduce the problem?
1. post-review in subversion checkout directory
What is the expected output? What do you see instead?
Error uploading diff
...
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'time data did not match format:
data=(
revision 21939) fmt=%Y-%m-%d %H:%M:%S']}, u'stat': u'fail', u'err':
{u'msg': u'
One or more fields had errors', u'code': 105}, u'deprecated':
{u'in_version': u'
1.5'}}
...
Please provide any additional information below.
I see that the diff output mode shows
--- /xxx/xxx... (revision 21939)
+++ /xxx/xxx... (working copy)
It appears that the svn info call is expected to give a time/date here
instead of the revision number. I am using SVN 1.6.6 (r40053)
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1688 in reviewboard: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ?
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1688 by jtsharma: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ? http://code.google.com/p/reviewboard/issues/detail?id=1688 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.5 beta 1 What's the URL of the page containing the problem? admin/db/scmtools/repository/add/ What steps will reproduce the problem? Just try to add a long 'Raw File URL mask', it won't let you enter more than 128 character? What is the expected output? What do you see instead? Should take longer strings. I'm stuck as I can't add a new git repo here. What operating system are you using? What browser? Linux Please provide any additional information below. Let me know if you need any additional information -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1688 in reviewboard: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ?
Comment #1 on issue 1688 by jtsharma: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ? http://code.google.com/p/reviewboard/issues/detail?id=1688 Would appreciate a quick workaround on this issue as one of our team is blocked because of this text field size limitation for git repos. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1688 in reviewboard: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ?
Updates: Status: Fixed Comment #2 on issue 1688 by chipx86: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ? http://code.google.com/p/reviewboard/issues/detail?id=1688 This isn't a problem in the released beta 2. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1688 in reviewboard: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ?
Comment #3 on issue 1688 by jtsharma: Raw File URL mask field does not take more than 128 characters (running git supported RB instance) ? http://code.google.com/p/reviewboard/issues/detail?id=1688 Thanks. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1449 in reviewboard: Incompatible with Pylucene 3.0.0
Comment #5 on issue 1449 by latchkey: Incompatible with Pylucene 3.0.0 http://code.google.com/p/reviewboard/issues/detail?id=1449 I'm seeing this too. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1689 in reviewboard: post-review --guess-summary should trim internal newlines
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1689 by tstoakes: post-review --guess-summary should trim
internal newlines
http://code.google.com/p/reviewboard/issues/detail?id=1689
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
post-review --version: RBTools 0.2
Reviewboard server: 1.0.5.1
git --version: 1.7.0.4
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. Create a git branch from a git-svn base
2. Make =2 new git commits on this git branch, where each commit log is of
the form:
First line\n
blank line\n
second line...
3. post-review --revision-range=HEAD^^:HEAD --guess-summary ...
What is the expected output? What do you see instead?
The --guess-summary option takes the first line from each (2) commit
message, and concatenates. However, the newlines are not being stripped.
This results in django errors being emailed to the administrator when the
review is posted (and an error in the web browser).
Traceback (most recent call last):
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/core/handlers/base.py,
line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/views/decorators/cache.py,
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /usr/local/lib/python2.6/dist-packages/Djblets-0.5.5-py2.6.egg/djblets/webapi/decorators.py,
line 59, in _checklogin
response = view_func(request, *args, **kwargs)
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.5.1-py2.6.egg/reviewboard/webapi/json.py,
line 520, in review_request_publish
review_request.publish(request.user)
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.5.1-py2.6.egg/reviewboard/reviews/models.py,
line 458, in publish
mail_review_request(user, self, changes)
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.5.1-py2.6.egg/reviewboard/reviews/email.py,
line 184, in mail_review_request
extra_context)
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.5.1-py2.6.egg/reviewboard/reviews/email.py,
line 114, in send_review_mail
message.send()
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/core/mail.py,
line 266, in send
return self.get_connection(fail_silently).send_messages([self])
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/core/mail.py,
line 172, in send_messages
sent = self._send(message)
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/core/mail.py,
line 186, in _send
email_message.message().as_string())
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.5.1-py2.6.egg/reviewboard/reviews/email.py,
line 41, in message
msg = super(SpiffyEmailMessage, self).message()
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/core/mail.py,
line 238, in message
msg['Subject'] = self.subject
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/core/mail.py,
line 96, in __setitem__
name, val = forbid_multi_line_headers(name, val)
File /usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/django/core/mail.py,
line 76, in forbid_multi_line_headers
raise BadHeaderError(Header values can't contain newlines (got %r
for header %r) % (val, name))
BadHeaderError: Header values can't contain newlines (got u'Review
Request: First line commit 1\nFirst line commit 2' for
header 'Subject')
What operating system are you using? What browser?
Linux (ubuntu) client and server. Firefox, not that it matters.
Please provide any additional information below.
ModPythonRequest
path:/api/json/reviewrequests/267/publish/,
GET:QueryDict: {},
POST:QueryDict: {u'dummy': [u'']},
COOKIES:{'collapsediffs': 'True', 'rbsessionid':
'acceb746e620d983a1c03a08322cbcff'},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': '6',
'CONTENT_TYPE': 'application/x-www-form-urlencoded; charset=UTF-8',
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT': 'application/json, text/javascript, */*',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate',
'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
'HTTP_CACHE_CONTROL': 'no-cache',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_CONTENT_LENGTH': '6',
'HTTP_CONTENT_TYPE': 'application/x-www-form-urlencoded; charset=UTF-8',
'HTTP_COOKIE': 'rbsessionid=acceb746e620d983a1c03a08322cbcff;
collapsediffs=True',
'HTTP_HOST': 'XXX',
'HTTP_KEEP_ALIVE': '300',
'HTTP_PRAGMA': 'no-cache',
'HTTP_REFERER': 'http://XXX/r/267/diff/?page=3',
'HTTP_USER_AGENT': 'Mozilla/5.0 (X11; U; Linux x86_64; en-US;
rv:1.9.1.9) Gecko/20100402 Ubuntu/9.10 (karmic) Firefox/3.5.9',
'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
'PATH_INFO':
