Re: Issue 1536 in reviewboard: Enabling Active Directory causes complete lockout (even local superuser cannot log back in)
Comment #5 on issue 1536 by chipx86: Enabling Active Directory causes complete lockout (even local superuser cannot log back in) http://code.google.com/p/reviewboard/issues/detail?id=1536 Can you try something on your end? You'd need to either modify your installed copy (when nobody's using it, if possible) or have a test dev environment to play with. Edit reviewboard/accounts/backends.py. Find the 'authenticate' function in 'ActiveDirectoryBackend'. Look for the line that says 'user_data = self.search_ad(..)'. Right after that, add: if not user_data: return None Then restart your web server and try again. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1518 in reviewboard: new json api - get list of review requests created between date range
Updates: Status: PendingReview Comment #2 on issue 1518 by chipx86: new json api - get list of review requests created between date range http://code.google.com/p/reviewboard/issues/detail?id=1518 Up for review at http://reviews.reviewboard.org/r/1686/ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1536 in reviewboard: Enabling Active Directory causes complete lockout (even local superuser cannot log back in)
Comment #4 on issue 1536 by sierragolfoneniner: Enabling Active Directory causes complete lockout (even local superuser cannot log back in) http://code.google.com/p/reviewboard/issues/detail?id=1536 I even tried several times to make up admin users with random strings as their names (e.g. "djfskhkfshfsd") so unless AD has some sort of wildcard capability or I was really (un)lucky there's no way the users could have existed. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Status: PendingReview Comment #18 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 That wasn't too bad.. I have a patch up for review at http://reviews.reviewboard.org/r/1685/ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1066 in reviewboard: Show file status in diff (added, modified, deleted, renamed)
Comment #7 on issue 1066 by chipx86: Show file status in diff (added, modified, deleted, renamed) http://code.google.com/p/reviewboard/issues/detail?id=1066 The deleted part of this is up for review at http://reviews.reviewboard.org/r/1685/. This part should end up in 1.5. The rest will wait until 1.6 or later. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1587 in reviewboard: Some lines don't word-wrap correctly on IE/Chrome
Updates: Status: ThirdParty Comment #10 on issue 1587 by chipx86: Some lines don't word-wrap correctly on IE/Chrome http://code.google.com/p/reviewboard/issues/detail?id=1587 Closing as third-party, since there's nothing sane we can do about this. It depends on the browser and on the characters used on the lines. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Owner: chipx86 Labels: -Component-SCMTools Component-DiffViewer Component-DiffParser Comment #17 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Been poking at this. Since the problem is that the RCS File line doesn't contain any information on which module the file is in, we may have to post-process the diff in post-review. Another option is to finally give Review Board a concept of "deleted files", but that's potentially a larger change. This appears to be a conscious choice on behalf of cvs: /* This is fullname, not file, possibly despite the POSIX.2 * specification, because that's the way all the Larry Wall * implementations of patch (are there other implementations?) want * things and the POSIX.2 spec appears to leave room for this. */ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Comment #16 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Actually, that won't be good enough. We really do need the full file path. cvs really should be showing the full path information. The fact that it's not is bad, and we need to investigate how long this has been happening and figure out if there's a fix for it. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 676 in reviewboard: Document how to raise the mysql packet size
Updates: Labels: -Milestone-Release1.5 Milestone-Release1.5.x Comment #10 on issue 676 by chipx86: Document how to raise the mysql packet size http://code.google.com/p/reviewboard/issues/detail?id=676 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1571 in reviewboard: Diff-Upload UI: Base Path field too narrow
Updates: Labels: -Milestone-Release1.5 Milestone-Release1.5.x Comment #4 on issue 1571 by chipx86: Diff-Upload UI: Base Path field too narrow http://code.google.com/p/reviewboard/issues/detail?id=1571 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1683 in reviewboard: PendingDeprecationWarning while rbsite install
Updates: Status: Fixed Owner: chipx86 Comment #3 on issue 1683 by chipx86: PendingDeprecationWarning while rbsite install http://code.google.com/p/reviewboard/issues/detail?id=1683 Changed rb-site to silence this warning. Fixed on master (revision 3028465). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1683 in reviewboard: PendingDeprecationWarning while rbsite install
Comment #2 on issue 1683 by chipx86: PendingDeprecationWarning while rbsite install http://code.google.com/p/reviewboard/issues/detail?id=1683 Well, looks like we can't do much about the warnings in this release. In order to really support 1.1 *and* 1.2, we need get_type and get_db_prep_save to take *args, **kwargs instead of just a connection, but that won't silence the warning due to how they check for it. So, for the time-being, we'll need to silence those warnings. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
