Issue 1735 in reviewboard: Perforce clients not adding the charset
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1735 by carodolan: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 *NOTE: Do not post confidential information in this bug report.* What version are you running? Applies both to 1.0 and 1.5RC1 What's the URL of the page containing the problem? It's an issue on the reviewboard/scmtools/perforce.py file What steps will reproduce the problem? 1. Add a perforce repository whose server is unicode 2. try to upload a review 3. The log will say: Unicode servers permits only unicode enabled clients What is the expected output? What do you see instead? You should be able to post reviews, you get an error message. What operating system are you using? What browser? Doesn't apply. Please provide any additional information below. One could solve it by adding the environment variable P4CHARSET, but if you want to use different repositories, some unicode, some not, that won't work. I have fixed it temporarily by adding on perforce.py: import P4 self.p4 = P4.P4() self.p4.port = str(repository.mirror_path or repository.path) self.p4.user = str(repository.username) self.p4.password = str(repository.password) if (str(repository.encoding)): self.p4.charset = str(repository.encoding) self.p4.exception_level = 1 And cmdline = ['p4', '-p', self.p4.port] if self.p4.user: cmdline.extend(['-u', self.p4.user]) if self.p4.password: cmdline.extend(['-P', self.p4.password]) if self.p4.charset: cmdline.extend(['-C', self.p4.charset]) cmdline.extend(['print', '-q', file]) But that's just a temporary fix, since I don't know the real meaning of the encoding attribute. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1736 in reviewboard: Perforce clients not adding the charset
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1736 by carodolan: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1736 *NOTE: Do not post confidential information in this bug report.* What version are you running? Applies both to 1.0 and 1.5RC1 What's the URL of the page containing the problem? It's an issue on the reviewboard/scmtools/perforce.py file What steps will reproduce the problem? 1. Add a perforce repository whose server is unicode 2. try to upload a review 3. The log will say: Unicode servers permits only unicode enabled clients What is the expected output? What do you see instead? You should be able to post reviews, you get an error message. What operating system are you using? What browser? Doesn't apply. Please provide any additional information below. One could solve it by adding the environment variable P4CHARSET, but if you want to use different repositories, some unicode, some not, that won't work. I have fixed it temporarily by adding on perforce.py: import P4 self.p4 = P4.P4() self.p4.port = str(repository.mirror_path or repository.path) self.p4.user = str(repository.username) self.p4.password = str(repository.password) if (str(repository.encoding)): self.p4.charset = str(repository.encoding) self.p4.exception_level = 1 And cmdline = ['p4', '-p', self.p4.port] if self.p4.user: cmdline.extend(['-u', self.p4.user]) if self.p4.password: cmdline.extend(['-P', self.p4.password]) if self.p4.charset: cmdline.extend(['-C', self.p4.charset]) cmdline.extend(['print', '-q', file]) But that's just a temporary fix, since I don't know the real meaning of the encoding attribute. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1737 in reviewboard: Exception is thrown when adding a private GitHub repository
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1737 by kevin.go...@googlemail.com: Exception is thrown when
adding a private GitHub repository
http://code.google.com/p/reviewboard/issues/detail?id=1737
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.5RC1
What's the URL of the page containing the problem?
http://reviews.kevmaster.com/admin/db/scmtools/repository/add/
What steps will reproduce the problem?
1. Add new repository: Hosting service GitHub (private)
2. Fill out all data
3. Hit Save
What is the expected output? What do you see instead?
Expected: repository gets added.
Actual: 500 page.
What operating system are you using? What browser?
OS X 10.6.4
Chrome 5.0, Firefox 3.6.8 (error happens in both)
Please provide any additional information below.
Error log dump is below:
ERROR:root:Exception thrown for user admin at
http://reviews.kevmaster.com/admin/db/scmtools/repository/add/
'tool'
Traceback (most recent call last):
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/core/handlers/base.py,
line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/sites.py,
line 512, in root
return self.model_page(request, *url.split('/', 2))
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/views/decorators/cache.py,
line 69, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/sites.py,
line 531, in model_page
return admin_obj(request, rest_of_url)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/options.py,
line 1190, in __call__
return self.add_view(request)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py,
line 21, in _wrapper
return decorator(bound_func)(*args, **kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py,
line 76, in _wrapped_view
response = view_func(request, *args, **kwargs)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/utils/decorators.py,
line 17, in bound_func
return func(self, *args2, **kwargs2)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/db/transaction.py,
line 299, in _commit_on_success
res = func(*args, **kw)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/contrib/admin/options.py,
line 777, in add_view
if form.is_valid():
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 577, in is_valid
return (super(RepositoryForm, self).is_valid() and
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 121, in is_valid
return self.is_bound and not bool(self.errors)
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 112, in _get_errors
self.full_clean()
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 499, in full_clean
return super(RepositoryForm, self).full_clean()
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 268, in full_clean
self._clean_form()
File /home3/kevmaste/.local/lib/python2.4/site-packages/Django-1.2.1-py2.4.egg/django/forms/forms.py,
line 296, in _clean_form
self.cleaned_data = self.clean()
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 515, in clean
self._clean_hosting_info()
File /home3/kevmaste/.local/lib/python2.4/site-packages/ReviewBoard-1.5rc1-py2.4.egg/reviewboard/scmtools/forms.py,
line 447, in _clean_hosting_info
tool_name = self.cleaned_data['tool'].name
KeyError: 'tool'
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1737 in reviewboard: Exception is thrown when adding a private GitHub repository
Updates: Labels: -Priority-Medium Priority-Critical Milestone-Release1.5 Component-SCMTools Comment #1 on issue 1737 by chipx86: Exception is thrown when adding a private GitHub repository http://code.google.com/p/reviewboard/issues/detail?id=1737 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1736 in reviewboard: Perforce clients not adding the charset
Updates: Status: Duplicate Mergedinto: 1735 Comment #1 on issue 1736 by trowbrds: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1736 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1735 in reviewboard: Perforce clients not adding the charset
Comment #1 on issue 1735 by trowbrds: Perforce clients not adding the charset http://code.google.com/p/reviewboard/issues/detail?id=1735 Issue 1736 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1737 in reviewboard: Exception is thrown when adding a private GitHub repository
Comment #2 on issue 1737 by kevin.go...@googlemail.com: Exception is thrown
when adding a private GitHub repository
http://code.google.com/p/reviewboard/issues/detail?id=1737
The admin account just received this email containing the post-data for the
failing request. Hope this helps.
WSGIRequest
GET:QueryDict: {},
POST:QueryDict: {u'username': [u'host...@partyearth.com'], u'name':
[u'Partyearth'], u'bug_tracker_type': [u'none'], u'encoding': [u''],
u'tool': [u'2'], u'api_token': [u'xxx'], u'bug_tracker_project_name':
[u'Partyearth'], u'hosting_project_name': [u'Partyearth'],
u'bug_tracker_base_url': [u''], u'visible': [u'on'], u'hosting_type':
[u'github-private'], u'bug_tracker_owner': [u''], u'_save': [u'Save'],
u'raw_file_url': [u''], u'bug_tracker': [u''], u'path': [u''],
u'csrfmiddlewaretoken': [u'46fd13a07a342baa7c4ba8397e2e65be'], u'password':
[u'pe4life!'], u'mirror_path': [u''], u'hosting_owner': [u'partyearth']},
COOKIES:{'csrftoken': '46fd13a07a342baa7c4ba8397e2e65be',
'rbsessionid': 'ebd5c17c7efcd94f605785518577a94d'},
META:{'CONTENT_LENGTH': '2448',
'CONTENT_TYPE': 'multipart/form-data;
boundary=---168072824752491622650073',
'CSRF_COOKIE': '46fd13a07a342baa7c4ba8397e2e65be',
'DOCUMENT_ROOT': '/home3/kevmaste/public_html/reviews',
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_ACCEPT':
'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
'HTTP_ACCEPT_ENCODING': 'gzip,deflate',
'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': 'rbsessionid=ebd5c17c7efcd94f605785518577a94d;
csrftoken=46fd13a07a342baa7c4ba8397e2e65be',
'HTTP_HOST': 'reviews.kevmaster.com',
'HTTP_KEEP_ALIVE': '115',
'HTTP_REFERER':
'http://reviews.kevmaster.com/admin/db/scmtools/repository/add/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8',
'PATH': '/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/bin:/usr/local/sbin',
'PATH_INFO': u'/admin/db/scmtools/repository/add/',
'PATH_TRANSLATED':
'redirect:/reviewboard.fcgi/admin/db/scmtools/repository/add//db/scmtools/repository/add/',
'QUERY_STRING': '',
'REDIRECT_STATUS': '200',
'REDIRECT_UNIQUE_ID': 'TE3hZ0rc12UAADR2IQ8AAACN',
'REDIRECT_URL': '/admin/db/scmtools/repository/add/',
'REDIRECT_file_gzip': '/ramdisk/cpud/status',
'REMOTE_ADDR': '99.107.206.17',
'REMOTE_PORT': '51075',
'REQUEST_METHOD': 'POST',
'REQUEST_URI': '/admin/db/scmtools/repository/add/',
'SCRIPT_FILENAME': '/home3/kevmaste/public_html/reviews/reviewboard.fcgi',
'SCRIPT_NAME': u'',
'SERVER_ADDR': '74.220.202.29',
'SERVER_ADMIN': 'webmas...@reviews.kevmaster.com',
'SERVER_NAME': 'reviews.kevmaster.com',
'SERVER_PORT': '80',
'SERVER_PROTOCOL': 'HTTP/1.1',
'SERVER_SIGNATURE': 'addressApache/2.2.15 (CentOS) mod_ssl/2.2.15 0.9.8l
DAV/2 mod_auth_passthrough/2.1 FrontPage/5.0.2.2635 Server at
reviews.kevmaster.com Port 80/address\n',
'SERVER_SOFTWARE': 'Apache/2.2.15 (CentOS) mod_ssl/2.2.15 0.9.8l DAV/2
mod_auth_passthrough/2.1 FrontPage/5.0.2.2635',
'UNIQUE_ID': 'TE3hZ0rc12UAADR2IQ8AAACN',
'file_gzip': '/ramdisk/cpud/status',
'wsgi.errors': flup.server.fcgi_base.OutputStream object at 0x19354d0,
'wsgi.input': flup.server.fcgi_base.InputStream object at 0x1935d50,
- Hide quoted text -
'wsgi.multiprocess': False,
'wsgi.multithread': True,
'wsgi.run_once': False,
'wsgi.url_scheme': 'http',
'wsgi.version': (1, 0)}
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1738 in reviewboard: post-review --revision-range fails when files have been removed.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1738 by tagster: post-review --revision-range fails when files have been removed. http://code.google.com/p/reviewboard/issues/detail?id=1738 *NOTE: Do not post confidential information in this bug report.* What version are you running? RBTools 0.2 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. remove a file in a revision (we'll call revision 3). 2. post-review --revision-range=0:4 What is the expected output? What do you see instead? Review request #number created. http://location/number What operating system are you using? What browser? Linux, Firefox 3 Please provide any additional information below. post-review --revision-range attempts to call svn info on the removed node, this causes failure: Failed to execute command: ['svn', 'info', 'path'] ['path: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n'] -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1739 in reviewboard: Version diff with files added + removed from diff show the wrong files in the diff
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1739 by MichaelvdB: Version diff with files added + removed from diff show the wrong files in the diff http://code.google.com/p/reviewboard/issues/detail?id=1739 *NOTE: Do not post confidential information in this bug report.* What version are you running? 1.0.9 What's the URL of the page containing the problem? https://reviewboard.eng.vmware.com/r/157999/diff/3-4 This is correct: https://reviewboard.eng.vmware.com/r/157999/diff/4 What steps will reproduce the problem? 1. Upload diff of change 2. Remove a file from the diff: CloneSessionRequestEvent.## 3. Add a file to the diff: CSharpNavigationRequestEvent.## 4. Upload the new diff: Diff was created using: p5 diff -du -c CL# F:\work\diff\change_CL#.diff What is the expected output? CloneSessionRequestEvent - This file was removed, or the diff of the removal, or not listed CSharpNavigationRequestEvent [new content] What do you see instead? CloneSessionRequestEvent - [new content] CSharpNavigationRequestEvent - not listed What operating system are you using? What browser? Windows 2008 R2 + Windows 2003 IE8 + Chrome Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
