Re: Issue 831 in reviewboard: Can't leave comments before you publish your own newly created review request

2011-01-30 Thread reviewboard

Updates:
Status: Confirmed
Labels: -Type-Defect Type-Enhancement Milestone-Release1.7

Comment #21 on issue 831 by chip...@gmail.com: Can't leave comments before  
you publish your own newly created review request

http://code.google.com/p/reviewboard/issues/detail?id=831

You're right. There's many people who want it, and I'm perfectly fine with  
it. Nobody has provided a patch for this, and while that's not a  
prerequisite for getting this in, please understand that there are lot of  
tickets and a lot of e-mails asking for all sorts of things, and we're only  
two people working full-time on this.


I would like to see this done at this point, and maybe we can get it into  
some release at some point soon (1.7 is the soonest I can imagine doing it  
unless someone sends us a patch). But please realize we're not selectively  
ignoring this patch. We just have to prioritize, and unfortunately that  
always means someone ends up not being happy or feels we're prioritizing  
incorrectly.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1963 in reviewboard: HTTP 500 when posting/updating review request via post-review

2011-01-30 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1963 by eallik: HTTP 500 when posting/updating review request via  
post-review

http://code.google.com/p/reviewboard/issues/detail?id=1963

Running RB 1.5.2 and RBTools 0.3. ReviewBoard is installed on a Linux  
machine, and post-review is being run from an OS X 10.5 machine.


I'm trying to update an existing review request with an ID of 112. The  
first time I run the command, it failes with the output below. Then I just  
re-run the exact same command and it runs without error. This is the  
scenario I go through about 80% of times when posting something with  
post-review (we only use post-review to post requests, never manual  
uploads).


$ post-review -r 112  
--revision-range=404fd2a832feee0a35dae9b98471b86ae20e891a:ce39b9a9c0e2e5029d745e7d84a4c0c42981d25a  
-o

Traceback (most recent call last):
  File /Users/erik/.virtualenvs/kultinf/bin/post-review, line 9, in  
module

load_entry_point('RBTools==0.3', 'console_scripts', 'post-review')()
   
File /Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py,  
line 3766, in main

submit_as=options.submit_as)
   
File /Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py,  
line 3437, in tempt_fate

if not server.info.supports_changesets or not options.change_only:
   
File /Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py,  
line 793, in _get_server_info

self._server_info = self._info.find_server_repository_info(self)
   
File /Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py,  
line 209, in find_server_repository_info

info = self._get_repository_info(server, repository)
   
File /Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py,  
line 233, in _get_repository_info

raise e
rbtools.postreview.APIError: HTTP 500

$ post-review -r 112  
--revision-range=404fd2a832feee0a35dae9b98471b86ae20e891a:ce39b9a9c0e2e5029d745e7d84a4c0c42981d25a  
-o

Review request #112 posted.

https://my-rb-domain.ee:1/r/112/


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1963 in reviewboard: HTTP 500 when posting/updating review request via post-review

2011-01-30 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 1963 by chip...@gmail.com: HTTP 500 when  
posting/updating review request via post-review

http://code.google.com/p/reviewboard/issues/detail?id=1963

Was this something that ever happened with RBTools 0.2?

It would be very helpful to see the Review Board log entry for this  
(assuming logging is turned on).


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 654 in reviewboard: Allow user to reorder the files being diffed

2011-01-30 Thread reviewboard

Updates:
Labels: -Priority-Medium Priority-Low

Comment #4 on issue 654 by chip...@gmail.com: Allow user to reorder the  
files being diffed

http://code.google.com/p/reviewboard/issues/detail?id=654

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1915 in reviewboard: Page not found (404)

2011-01-30 Thread reviewboard

Updates:
Status: Incomplete

Comment #2 on issue 1915 by trowb...@gmail.com: Page not found (404)
http://code.google.com/p/reviewboard/issues/detail?id=1915

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1894 in reviewboard: Emails should have Sender header

2011-01-30 Thread reviewboard

Updates:
Status: Fixed

Comment #1 on issue 1894 by trowb...@gmail.com: Emails should have Sender  
header

http://code.google.com/p/reviewboard/issues/detail?id=1894

This is already fixed in git and will be present in 1.6.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1252 in reviewboard: Posted date appears in the dashboard, but not in the review

2011-01-30 Thread reviewboard


Comment #2 on issue 1252 by trowb...@gmail.com: Posted date appears in  
the dashboard, but not in the review

http://code.google.com/p/reviewboard/issues/detail?id=1252

Issue 1807 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1252 in reviewboard: Posted date appears in the dashboard, but not in the review

2011-01-30 Thread reviewboard

Updates:
Labels: EasyFix

Comment #3 on issue 1252 by trowb...@gmail.com: Posted date appears in  
the dashboard, but not in the review

http://code.google.com/p/reviewboard/issues/detail?id=1252

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1707 in reviewboard: Description should not be required

2011-01-30 Thread reviewboard

Updates:
Status: WontFix

Comment #2 on issue 1707 by chip...@gmail.com: Description should not be  
required

http://code.google.com/p/reviewboard/issues/detail?id=1707

For a reviewer, knowing more information about the change is always  
beneficial. I don't think in the majority of cases that a 1 line summary is  
sufficient. I believe by making this field optional, we'll do nothing but  
decrease quality.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1952 in reviewboard: Under mod_wsgi: IOError: sys.stdout access restricted by mod_wsgi (reviewboard/reviews/datagrids.py, line 53, in augment_queryset)

2011-01-30 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 1952 by trowb...@gmail.com: Under mod_wsgi: IOError:  
sys.stdout access restricted by mod_wsgi  
(reviewboard/reviews/datagrids.py, line 53, in augment_queryset)

http://code.google.com/p/reviewboard/issues/detail?id=1952

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1913 in reviewboard: Settings information available to staff without siteconfig permission

2011-01-30 Thread reviewboard

Updates:
Labels: -Type-Defect Type-Enhancement Component-Settings

Comment #1 on issue 1913 by trowb...@gmail.com: Settings information  
available to staff without siteconfig permission

http://code.google.com/p/reviewboard/issues/detail?id=1913

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1827 in reviewboard: Sending notification emails fails

2011-01-30 Thread reviewboard

Updates:
Status: NeedInfo

Comment #3 on issue 1827 by chip...@gmail.com: Sending notification emails  
fails

http://code.google.com/p/reviewboard/issues/detail?id=1827

Did you ever figure this out? I don't know if it's Django 1.1 vs 1.2. Any  
luck with a more modern 1.5.x release though?


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1922 in reviewboard: errors on saving draft, publishing review

2011-01-30 Thread reviewboard

Updates:
Status: Incomplete

Comment #2 on issue 1922 by trowb...@gmail.com: errors on saving draft,  
publishing review

http://code.google.com/p/reviewboard/issues/detail?id=1922

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1457 in reviewboard: Add ability to define metrics and generate reports

2011-01-30 Thread reviewboard


Comment #2 on issue 1457 by trowb...@gmail.com: Add ability to define  
metrics and generate reports

http://code.google.com/p/reviewboard/issues/detail?id=1457

Issue 1947 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1947 in reviewboard: Metrics collection from code review comments

2011-01-30 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 1457

Comment #1 on issue 1947 by trowb...@gmail.com: Metrics collection from  
code review comments

http://code.google.com/p/reviewboard/issues/detail?id=1947

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1963 in reviewboard: HTTP 500 when posting/updating review request via post-review

2011-01-30 Thread reviewboard


Comment #2 on issue 1963 by eallik: HTTP 500 when posting/updating review  
request via post-review

http://code.google.com/p/reviewboard/issues/detail?id=1963

Yes, it happened all the time with 0.2. I was hoping it would go away with  
0.3, but no such luck.
I can turn on logging if it's off and send you the log. It's easy to  
reproduce as it happens virtually every time I use post-review.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.