Re: Issue 1795 in reviewboard: using --submit-as with post-review causes generated mails to be from original submitter
Comment #3 on issue 1795 by michakel...@gmail.com: using --submit-as with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 Is this a post-review issue? We run RB 1.5 beta 2, and see the same behavior. But the submitter in the review request is indeed the specified user (with correctly resolved e-mail address). But even later reviews to this request will never copy that submitter. Is it possible, that there is a general issue with the submitter of a review request being left out from notifications? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2269 in reviewboard: reviewers can review uploaded file just like diff file
Comment #2 on issue 2269 by wangxiao...@gmail.com: reviewers can review uploaded file just like diff file http://code.google.com/p/reviewboard/issues/detail?id=2269 all files(.txt .java .c .h .php .js .css .xml .py .sh .pl etc) expect Binary files and pictures -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2272 in reviewboard: Automatic Update of Chagne Number in ReveiwBoard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2272 by jagtar.c...@gmail.com: Automatic Update of Chagne Number in ReveiwBoard http://code.google.com/p/reviewboard/issues/detail?id=2272 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. I am using ReviewBoard with Perforce. To create a Review, I need to make changes in Perforce and store that changes into 'Saved Numbered Changelist' say 1543. Now if the Review is reviewed next day, there might be more changes are submitted in the Perforce. When I am finally going to submit my change from ChangeList 1543, my changes are submitted with the lasted CL available say 1619. Now when I open the review anytime, the Change Number associated with that review display Change Number 1543. There is no reference of ChangeList 1619 in that particular review. Now my question is how to update the Change Number in ReviewBoard once I get approval of Ship It from the reviewer. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2272 in reviewboard: Automatic Update of Chagne Number in ReveiwBoard
Comment #1 on issue 2272 by chip...@gmail.com: Automatic Update of Chagne Number in ReveiwBoard http://code.google.com/p/reviewboard/issues/detail?id=2272 The change number can only be updated today through the API, as giving users the option to specify their own change number can actually cause problems due to how we treat the change number internally. Some places have a script that takes the new change number and uses the API to update it, but I don't have code you can use off-hand for this. If you're using Review Board 1.6, you can specify the change number the change was committed as in the Close Description message, which will provide the same effect. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1795 in reviewboard: using --submit-as with post-review causes generated mails to be from original submitter
Updates: Labels: -Type-Defect Type-Enhancement Component-EMail Comment #4 on issue 1795 by chip...@gmail.com: using --submit-as with post-review causes generated mails to be from original submitter http://code.google.com/p/reviewboard/issues/detail?id=1795 It's part RBTools, part Review Board. But not really a bug, per se. --submit-as is used for the creation of a review request, to put it in someone else's name. That's a separate operation from publishing. When publishing, the e-mail will go out as the user logged in. There's definitely a use case for making a publish operations happen on behalf of another user, but we aren't set up for that today. So this would need to be added. One option is to just use the review request submitter for the e-mail, but that's likely not what we want in all cases. I'm hoping to introduce a multi-user workflow for review requests, where the ownership can be reassigned, and other users could modify fields with state being preserved to indicate who made the change. That won't solve your problem directly, though. You'd still need to either log in as the user, or would need to specifically do a --submit-as on that operation (which we'd have to support). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2273 in reviewboard: number of incomming/outgoing reviews reset after migration to 1.6
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2273 by kofem...@googlemail.com: number of incomming/outgoing reviews reset after migration to 1.6 http://code.google.com/p/reviewboard/issues/detail?id=2273 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6 What's the URL of the page containing the problem? dashboard What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. after upgrade from 1.5.5 to 1.6 all counters was reset to zero. Now, after some patches get submitted counters start to decrease and become a negative numbers. I guess some DB schema change did not run completely. Attachments: Screenshot-My Dashboard | Review Board - Mozilla Firefox.png 7.9 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2273 in reviewboard: number of incomming/outgoing reviews reset after migration to 1.6
Updates: Status: NeedInfo Labels: -Priority-Medium Priority-Critical Milestone-Release1.6.x Component-Dashboard Comment #1 on issue 2273 by chip...@gmail.com: number of incomming/outgoing reviews reset after migration to 1.6 http://code.google.com/p/reviewboard/issues/detail?id=2273 What type of database are you using? For now, try running: rb-site manage /path/to/site fixreviewcounts -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2273 in reviewboard: number of incomming/outgoing reviews reset after migration to 1.6
Comment #2 on issue 2273 by kofem...@googlemail.com: number of incomming/outgoing reviews reset after migration to 1.6 http://code.google.com/p/reviewboard/issues/detail?id=2273 I run Mysql 5.0.51a on debian lenny. fixreviewcounts did the job. Thanks. Attachments: Screenshot-My Dashboard | Review Board - Mozilla Firefox.png 8.1 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2273 in reviewboard: number of incomming/outgoing reviews reset after migration to 1.6
Comment #3 on issue 2273 by chip...@gmail.com: number of incomming/outgoing reviews reset after migration to 1.6 http://code.google.com/p/reviewboard/issues/detail?id=2273 We thought we had this nailed down in the betas, but alas... We call fixreviewcounts on upgrade, which should have taken care of this. Strange that it did not, but someone else also reported this. We'll do more tests. It looks like the group counts were correct though? Given the difference in screenshots. So the broken fields were Starred, Outgoing, Incoming, To Me, and All My Requests? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2273 in reviewboard: number of incomming/outgoing reviews reset after migration to 1.6
Comment #4 on issue 2273 by kofem...@googlemail.com: number of incomming/outgoing reviews reset after migration to 1.6 http://code.google.com/p/reviewboard/issues/detail?id=2273 It looks like the group counts were correct though? Given the difference in screenshots. So the broken fields were Starred, Outgoing, Incoming, To Me, and All My Requests? That's right, group counter where correct. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2268 in reviewboard: My incoming reviews have a negative number
Comment #6 on issue 2268 by manjunat...@gmail.com: My incoming reviews have a negative number http://code.google.com/p/reviewboard/issues/detail?id=2268 When I upgraded from 1.5 to 1.6, i got -1 for Outgoing Reviews and zero for all the other case (example Outgoing Reviews). When I ran rb-site manage path/to/site fixreviewcounts, counts were seen correctly (Outgoing Reviews now 83). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2268 in reviewboard: My incoming reviews have a negative number
Comment #7 on issue 2268 by manjunat...@gmail.com: My incoming reviews have a negative number http://code.google.com/p/reviewboard/issues/detail?id=2268 When I upgraded from 1.5 to 1.6, i got -1 for Outgoing Reviews and zero for all the other case (example All My Requests). When I ran rb-site manage path/to/site fixreviewcounts, counts were seen correctly (All My Requests now 83). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1722 in reviewboard: UTF-16 file from Perforce not displayed
Comment #4 on issue 1722 by joshua.m...@gmail.com: UTF-16 file from Perforce not displayed http://code.google.com/p/reviewboard/issues/detail?id=1722 It just shows This is a binary file, contents cannot be displayed or whatever it usually does when encountering a binary file. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2268 in reviewboard: My incoming reviews have a negative number
Comment #8 on issue 2268 by trowb...@gmail.com: My incoming reviews have a negative number http://code.google.com/p/reviewboard/issues/detail?id=2268 Issue 2273 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2274 in reviewboard: add Outgouing link to the dashboard
Updates: Status: WontFix Comment #1 on issue 2274 by chip...@gmail.com: add Outgouing link to the dashboard http://code.google.com/p/reviewboard/issues/detail?id=2274 Thanks, but this isn't how we'd like to tackle this. Rather, the idea is to have a drop-down arrow besides My Dashboard that will allow quick access to any dashboard page. It's a bit more work than adding a link, though. Might happen in 1.6.x. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2275 in reviewboard: Defect in the Bugs field
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2275 by gdinsh...@gmail.com: Defect in the Bugs field http://code.google.com/p/reviewboard/issues/detail?id=2275 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.5.1 What's the URL of the page containing the problem? http://gpreview9300.houston.lgc.com/r/1151/ What steps will reproduce the problem? 1. In the bugs field I entered the following text: Defect Id 873851: Post Processing-Volumetrics; DSR and Java NPE when clicking next to Step 3 Calculate Fluid Saturation with Saturation-Height Model selected when using Grid only 2. After doing ok and publishing the defect the text somehow gets corrupted as you can see in the attachment. 3. What is the expected output? What do you see instead? The text should be as entered. I see instead a bunch of random comma separated words. What operating system are you using? What browser? Win 7 IE 8 Please provide any additional information below. Please fix this bug. Attachments: ReviewBoardBug-AFTER.png 158 KB ReviewBoardBug-BEFORE_PUBLISHING.png 172 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2275 in reviewboard: Defect in the Bugs field
Updates: Status: UserError Comment #1 on issue 2275 by trowb...@gmail.com: Defect in the Bugs field http://code.google.com/p/reviewboard/issues/detail?id=2275 This is as expected. The bugs field is not supposed to be a text description, but rather a list of bug IDs to link. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2184 in reviewboard: Mercurial rename support: Pure file renames with *no actual changes* to the file fails with Diff did not apply cleanly
Comment #2 on issue 2184 by carl.van...@gmail.com: Mercurial rename support: Pure file renames with *no actual changes* to the file fails with Diff did not apply cleanly http://code.google.com/p/reviewboard/issues/detail?id=2184 This bug applies to more than just Mercurial changesets. I've tested in both mercurial and git that: (reviewboard 1.6RC2) 1. Renames without modifications 2. Deletes of empty files 3. Addition of empty files All three have similar properties in that the diff file contains meta data, but no actual diff headers, thus reviewboard internal patching fails. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
