Re: Issue 2327 in reviewboard: API: getting file diffs for a file returns filediffs for all files

2012-09-28 Thread reviewboard


Comment #2 on issue 2327 by allysh...@gmail.com: API: getting file diffs  
for a file returns filediffs for all files

http://code.google.com/p/reviewboard/issues/detail?id=2327

Allyshia S. will take a look at this one.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2327 in reviewboard: API: getting file diffs for a file returns filediffs for all files

2012-09-28 Thread reviewboard


Comment #3 on issue 2327 by sinn.fon...@gmail.com: API: getting file diffs  
for a file returns filediffs for all files

http://code.google.com/p/reviewboard/issues/detail?id=2327

Will try to work on this.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-09-28 Thread reviewboard


Comment #2 on issue 2553 by sinn.fon...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

Will look into this.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-09-28 Thread reviewboard


Comment #3 on issue 2553 by miche.ch...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

Will look into this. - Michelle C.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2389 in reviewboard: Incorrect web interface styling when using parent diffs and new files

2012-09-28 Thread reviewboard


Comment #2 on issue 2389 by tinayang...@gmail.com: Incorrect web interface  
styling when using parent diffs and new files

http://code.google.com/p/reviewboard/issues/detail?id=2389

I'll look into this.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2163 in reviewboard: Missing My Comments column in user's review requests listing

2012-09-28 Thread reviewboard


Comment #4 on issue 2163 by m...@aam1r.com: Missing My Comments column in  
user's review requests listing

http://code.google.com/p/reviewboard/issues/detail?id=2163

Aamir will look into this bug

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2012-09-28 Thread reviewboard


Comment #8 on issue 2002 by john.sin...@gmail.com: linkified URL has  
succeeding parenthesis included in link's target URL

http://code.google.com/p/reviewboard/issues/detail?id=2002

Having a look at this, with regards to the sbress's comment.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2390 in reviewboard: Adding a site commands directory breaks all management commands

2012-09-28 Thread reviewboard


Comment #6 on issue 2390 by enchuf...@gmail.com: Adding a site commands  
directory breaks all management commands

http://code.google.com/p/reviewboard/issues/detail?id=2390

I'll look into this

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2358 in reviewboard: The hit target for collapsing/expanding a review is too small

2012-09-28 Thread reviewboard

Updates:
Labels: EasyFix

Comment #1 on issue 2358 by trowb...@gmail.com: The hit target for  
collapsing/expanding a review is too small

http://code.google.com/p/reviewboard/issues/detail?id=2358

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2449 in reviewboard: Referencing issues with # does not work correctly with redmine integration

2012-09-28 Thread reviewboard


Comment #3 on issue 2449 by enchuf...@gmail.com: Referencing issues  
with # does not work correctly with redmine integration

http://code.google.com/p/reviewboard/issues/detail?id=2449

i'll look into this

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 750 in reviewboard: My Reviews option in dashboard

2012-09-28 Thread reviewboard


Comment #5 on issue 750 by trowb...@gmail.com: My Reviews option in  
dashboard

http://code.google.com/p/reviewboard/issues/detail?id=750

Issue 2328 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2734 in reviewboard: If the People field is completed, and I delete it the page dont't stop Loading...

2012-09-28 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 2734 by trowb...@gmail.com: If the People field is  
completed, and I delete it the page dont't stop Loading...

http://code.google.com/p/reviewboard/issues/detail?id=2734

What operating system are you using? What browser?

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2722 in reviewboard: Not able to publish the review once edit review option is used

2012-09-28 Thread reviewboard

Updates:
Status: Incomplete

Comment #2 on issue 2722 by trowb...@gmail.com: Not able to publish the  
review once edit review option is used

http://code.google.com/p/reviewboard/issues/detail?id=2722

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 44 in reviewboard: Keyboard shortcut for commenting on a selected block

2012-09-28 Thread reviewboard

Updates:
Labels: EasyFix

Comment #6 on issue 44 by trowb...@gmail.com: Keyboard shortcut for  
commenting on a selected block

http://code.google.com/p/reviewboard/issues/detail?id=44

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2449 in reviewboard: Referencing issues with # does not work correctly with redmine integration

2012-09-28 Thread reviewboard

Updates:
Status: Fixed

Comment #4 on issue 2449 by trowb...@gmail.com: Referencing issues with #  
does not work correctly with redmine integration

http://code.google.com/p/reviewboard/issues/detail?id=2449

Apparently this works now. Dunno when it was fixed exactly.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 994 in reviewboard: Description text for the Base Diff Path: field

2012-09-28 Thread reviewboard

Updates:
Labels: EasyFix

Comment #5 on issue 994 by trowb...@gmail.com: Description text for  
the Base Diff Path: field

http://code.google.com/p/reviewboard/issues/detail?id=994

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1996 in reviewboard: Custom Bug tracker URL verification check

2012-09-28 Thread reviewboard

Updates:
Labels: EasyFix

Comment #2 on issue 1996 by trowb...@gmail.com: Custom Bug tracker URL  
verification check

http://code.google.com/p/reviewboard/issues/detail?id=1996

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 564 in reviewboard: Summarize reviewer ship status

2012-09-28 Thread reviewboard


Comment #7 on issue 564 by trowb...@gmail.com: Summarize reviewer ship  
status

http://code.google.com/p/reviewboard/issues/detail?id=564

Issue 2263 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2263 in reviewboard: Display each reviewers status

2012-09-28 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 564

Comment #1 on issue 2263 by trowb...@gmail.com: Display each reviewers  
status

http://code.google.com/p/reviewboard/issues/detail?id=2263

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2163 in reviewboard: Missing My Comments column in user's review requests listing

2012-09-28 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 2163 by mike.d.c...@gmail.com: Missing My Comments  
column in user's review requests listing

http://code.google.com/p/reviewboard/issues/detail?id=2163

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2478 in reviewboard: Web Service API 2.0 doesn't allow creating Review Group?

2012-09-28 Thread reviewboard


Comment #7 on issue 2478 by trowb...@gmail.com: Web Service API 2.0 doesn't  
allow creating Review Group?

http://code.google.com/p/reviewboard/issues/detail?id=2478

Issue 2688 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2688 in reviewboard: Add create/update methods for review group via webapi.

2012-09-28 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2478

Comment #1 on issue 2688 by trowb...@gmail.com: Add create/update methods  
for review group via webapi.

http://code.google.com/p/reviewboard/issues/detail?id=2688

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2538 in reviewboard: Djblets: memcached leakage across instances - when instances run same server domain but different site root

2012-09-28 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 2538 by trowb...@gmail.com: Djblets: memcached leakage  
across instances - when instances run same server domain but different site  
root

http://code.google.com/p/reviewboard/issues/detail?id=2538

Thanks! Pushed to master (0fdc48b)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2372 in reviewboard: REST Api doesn't work when searching for review requests with ship-it status set to false

2012-09-28 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 2635

Comment #2 on issue 2372 by trowb...@gmail.com: REST Api doesn't work when  
searching for review requests with ship-it status set to false

http://code.google.com/p/reviewboard/issues/detail?id=2372

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2726 in reviewboard: why there are two ways to change user's password?

2012-09-28 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 2726 by trowb...@gmail.com: why there are two ways to  
change user's password?

http://code.google.com/p/reviewboard/issues/detail?id=2726

Fixed in master (a2ad3a7). Thanks!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 739 in reviewboard: Add Last Updated By column to Dashboard

2012-09-28 Thread reviewboard


Comment #7 on issue 739 by crystal@gmail.com: Add Last Updated By  
column to Dashboard

http://code.google.com/p/reviewboard/issues/detail?id=739

Crystal is working on this. It's been in code review and combined with  
another feature. Hope to get this in real soon!


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2553 in reviewboard: /api/review-requests/#/diffs/#/files/#/ will 404 with empty response when ids are invalid

2012-09-28 Thread reviewboard


Comment #4 on issue 2553 by miche.ch...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/ will 404 with empty response when  
ids are invalid

http://code.google.com/p/reviewboard/issues/detail?id=2553

The page does actually return with an error payload, but it doesn't seem to  
show up with certain plugins like Firebug or Chrome REST Console.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2552 in reviewboard: /api/review-requests/#/diffs/#/files/#/diff-comments/ does not 404 for invalid diff or file ids

2012-09-28 Thread reviewboard


Comment #3 on issue 2552 by miche.ch...@gmail.com:  
/api/review-requests/#/diffs/#/files/#/diff-comments/ does not 404 for  
invalid diff or file ids

http://code.google.com/p/reviewboard/issues/detail?id=2552

Will work on this.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2751 in reviewboard: Images with file names longer than 72 characters can not be properly uploaded as screenshots

2012-09-28 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2751 by matthew@ni.com: Images with file names longer than 72  
characters can not be properly uploaded as screenshots

http://code.google.com/p/reviewboard/issues/detail?id=2751

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?

1.6.12

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Create an image with a file name that is 72 characters long (including  
the extension)

2. Upload this file as a screenshot to review board
3. Publish this change

What is the expected output? What do you see instead?
Normally, a thumbnail of the screenshot shows up.  Clicking the thumbnail  
opens a page with the full screenshot. Instead, the thumbnail is blank and  
the image on the next page is completely empty. See the attached files.


What operating system are you using? What browser?
Win7 64-bit
Chrome 22.0.1229.79

Please provide any additional information below.

It looks like the screenshot is stored like this:

image = models.ImageField(_(image),
  upload_to=os.path.join('uploaded', 'images',
 '%Y', '%m', '%d'))

The django ImageField has a default max_length of 100, so when you take out  
the uploaded/images/2012/09/28/ that leaves about 72 characters. Which is  
the length of the 68 character file name, plus the four character extension.



At the very least, users should be informed that an error has occurred and  
no broken screenshots should be added. This error message could tell them  
how they can avoid the problem (shortening the length of the file name).


Beyond that, it'd be great if this max_length could be increased.



Attachments:
full screenshot.PNG  7.8 KB
screenshot thumbnails.PNG  21.0 KB

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2751 in reviewboard: Images with file names longer than 72 characters can not be properly uploaded as screenshots

2012-09-28 Thread reviewboard

Updates:
Status: Confirmed
Labels: -Priority-Medium Priority-High Milestone-Release1.6.x EasyFix

Comment #1 on issue 2751 by chip...@gmail.com: Images with file names  
longer than 72 characters can not be properly uploaded as screenshots

http://code.google.com/p/reviewboard/issues/detail?id=2751

That's a long filename,  but we should be able to fix this.

This would apply to file attachments as well.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.