Issue 3965 in reviewboard: View diff fails for C/C++ files from unified CVS diff
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3965 by boris.bo...@gmail.com: View diff fails for C/C++ files from unified CVS diff https://code.google.com/p/reviewboard/issues/detail?id=3965 What version are you running? Review Board 2.0.18 What's the URL of the page containing the problem? http://vmreviewboard.dsa-ac.de/r/22/diff/1#index_header What steps will reproduce the problem? 1. Upload unified diff with C/C++ implementation and header files 2. View diff What is the expected output? What do you see instead? Expected is a diff for C/C++ files but instead only an error is shown. Non C/C++ files from the same diff file (Makefile, ini files, ...) are shown correctly. What operating system are you using? What browser? Fedora 20, Chrome 45.0.2454.85 Please provide any additional information below. -- The patch to 'app/tester/dtm/src/dtmmain.cpp' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.UtdaSy' for debugging purposes. `patch` returned: This may be a bug in the software, a temporary outage, or an issue with the format of your diff. Please try again, and if you still have trouble, contact support. Details Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/views.py", line 265, in get response = renderer.render_to_response(request) File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", line 56, in render_to_response return HttpResponse(self.render_to_string(request)) File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", line 74, in render_to_string large_data=True) File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 111, in cache_memoize data = lookup_callable() File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", line 73, in lambda: self.render_to_string_uncached(request), File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py", line 87, in render_to_string_uncached request=request) File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py", line 422, in populate_diff_chunks chunks = generator.get_chunks() File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py", line 156, in get_chunks large_data=True) File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line 111, in cache_memoize data = lookup_callable() File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py", line 155, in lambda: list(self._get_chunks_uncached()), File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py", line 163, in _get_chunks_uncached new = get_patched_file(old, self.filediff, self.request) File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py", line 232, in get_patched_file return patch(diff, buffer, filediff.dest_file, request) File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py", line 168, in patch 'output': stderr, Exception: The patch to 'app/tester/dtm/src/dtmmain.cpp' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.UtdaSy' for debugging purposes. `patch` returned: --- The files in the tmp folder have not been created. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing
Comment #3 on issue 3963 by paul.man...@alcatel-lucent.com: markdown in the field Note to Reviewers gets quoted with backslashes after editing https://code.google.com/p/reviewboard/issues/detail?id=3963 Hi, yes, I did publish the review with some notes-for-reviewers set, and then modified the field afterwards. I can subsequently edit the field and remove the backslash and click OK and then the text gets re-emboldened. But when I publish the review the markdown gets re-enquoted into backslash hash, so the text becomes normal. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs
Comment #4 on issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 Some new info. This appears to be a Chrome- or at least browser-related issue. I cleared Chrome's browsing history and the data corrected itself. It would seem Chrome thinks codereview/r/232/diff/1-2/ is a page it should cache, but codereview/r/232/diff/2/ is not. So at least the reviewer will see the correct diff, even if the reviewee cannot. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 What version are you running? Reviewboard 2.0.19 and RBTools 0.7.4 for Windows I am using a git repository that is mounted as a directory on the reviewboard server. What's the URL of the page containing the problem? /r/232/diff/1-2/ What steps will reproduce the problem? Summary: Upload and publish a CR then upload two move revisions before publishing the latter. The 1-2 diff will be incorrect. 1. Create a code change with a diff (e.g. adding a line to a file that reads "Change #1") and run 'rbt post' 2. Publish the review. 3. Update the code change (e.g. change the line to say "Fake Change #2") and run 'rbt post -u' 4. On reviewboard, view the diffs orig-1, orig-2 and 1-2, and verify that they show diffs between three versions of a file with a blank line, 'Change #1' and 'Fake Change #2', but DON'T publish. 5. Update the code change once more (e.g. change the line to say 'Real Change #2) and run 'rbt post -u' 6. On reviewboard, view the diffs once more. Verify that orig-2 shows that the line 'Real Change #2' has been added. Look at the diff 1-2 and notice that it says 'Change #1' -> 'Fake Change #2', instead of 'Change #1' -> 'Real Change #2'. What is the expected output? What do you see instead? Expected output: All diffs accurately represent the difference between the respective versions of the code change. Actual output: Diffs between orig and another commit are correct, but relative diffs (1-2) are out of date and show non-existent changes. What operating system are you using? What browser? Windows 8.1 Pro 64-bit and latest Google Chrome (Version 45.0.2454.85 m) Please provide any additional information below. It appears that the relative diffs between intermediate revisions and the latest revision are being stored at the moment that the latest revision is uploaded and not updated when the revision is updated prior to publishing it. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs
Comment #3 on issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 I looked up how to flush memcached and ended up running echo 'flush_all' | nc localhost 11211 This did not seem to fix the incorrect data. If you give me more specific steps to check I can try those. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs
Updates: Status: NeedInfo Comment #2 on issue 3966 by chip...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 As a test, what happens if you clear the server cache? Does the problem fix itself? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs
Comment #1 on issue 3966 by chip...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 Thanks for the detailed reproduction steps! We generate the changes between diffs on-the-fly by patching the source files for each revision with the accompanying patches, and then generating a side-by-side diff. It sounds like this may be a caching issue. We've heard of such issues from a recent release, but haven't had a good repro case. I'll give this a try and see what we can see. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3963 in reviewboard: markdown in the field Note to Reviewers gets quoted with backslashes after editing
Comment #4 on issue 3963 by chip...@gmail.com: markdown in the field Note to Reviewers gets quoted with backslashes after editing https://code.google.com/p/reviewboard/issues/detail?id=3963 Would you be able to get the API payloads for me at each stage? That'll tell me more. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
