Re: Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Updates: Status: Fixed Comment #22 on issue 147 by trowb...@gmail.com: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Actually, these are now also available in the UI in the master branch (there are little download links). Between that and the text-file review (attaching files to review requests instead of uploading diffs), I think this is probably covered well enough. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #20 on issue 147 by g.cha...@gmail.com: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Hi. I've reviewed quickly all the different issues merged into this one and I think there are 2 slightly different functionality requests: 1) Being able to review new code only: not yet in a repository, review plain files, not diff file 2) Being able to download separately each side of the current diff view. I mean, for each file, to be able to download the versions before and after the diff is applied. I am very interested in 2). This can be useful when the file is not easy to review in text format and can be displayed nicely in an external application. I understand that this can easily be reproduced manually by checking out the repository and applying the diff file to get each version of the file but I think it's the point of RB to make this straightforward. I do not know the internals of RB but it seems to me that at some point it must checkout/generate both files in order to generate the diff view... Should this be tracked in a separate Issue? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #21 on issue 147 by trowb...@gmail.com: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 The original and patched files are available through the API. You could write a script or extension to let you download it from that. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #18 on issue 147 by eddie.d...@gmail.com: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Is this something you won't implement because you feel you have more important things to do and precious little time, or is it something you object to on a design level? I.e., if someone sent a fix for this, would you include it? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #15 on issue 147 by trowb...@gmail.com: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Issue 2136 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #17 on issue 147 by chip...@gmail.com: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 There are no plans for this. You could accomplish it with a Greasemonkey or Stylish script though by changing the CSS. It's very unlikely we'll bake it into Review Board. Maybe someone can code it up in 2.0 when extensions are there. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #14 on issue 147 by brownboy...@gmail.com: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Are there any plans to proceed with this feature? I know many users who would find it extremely useful. The side-by-side diff view can become cluttered very quickly in larger reviews. It would be useful to be able to collapse the column of the table containing either the old output or new output. Hopefully this could be done client-side with some suitable javascript and css. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #13 on issue 147 by trowbrds: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Issue 1316 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #12 on issue 147 by chipx86: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Issue 1209 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #8 on issue 147 by trowbrds: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Issue 852 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #9 on issue 147 by trowbrds: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Issue 936 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #10 on issue 147 by trowbrds: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 Issue 973 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 147 in reviewboard: Ability to view complete source files without diff coloring/block insertions
Comment #11 on issue 147 by jocelyn.fiat: Ability to view complete source files without diff coloring/block insertions http://code.google.com/p/reviewboard/issues/detail?id=147 I see Issue 973 has been merged into this issue. However, my initial request was mainly to be able to review existing code. Not especially comparing with any other version. Just do a code review on existing source code (then no diff). This was just to clarify. Regards -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
