Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Updates: Status: Fixed Comment #16 on issue 3044 by trowb...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #11 on issue 3044 by abhir...@gmail.com: plasticscm repository
doesn't work
http://code.google.com/p/reviewboard/issues/detail?id=3044
It doesn't seem to be a debug log 'only'. I also see a red bar which
contents are not readable because it is hidded behind some element. Plastic
repository which I was trying to add is not visible in the reviewboard, so
it seem like adding repository didn't work.
On the other node, I tried to do the same thing on the 'master' branch and
there repository could be added on reviewboard site but creating a review
by giving a changeset doesn't work from the site. A blank review is created
but there is no file description or diff :(
Using 'post-review' encountered the following error when trying to post the
review.
abhiravk@MrvServer:~/workspace/plastic$ post-review 447
Traceback (most recent call last):
File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.5.1.dev', 'console_scripts', 'post-review')()
File /usr/local/lib/python2.7/dist-packages/RBTools-0.5.1.dev-py2.7.egg/rbtools/postreview.py,
line 1303, in main
server.load_capabilities()
File /usr/local/lib/python2.7/dist-packages/RBTools-0.5.1.dev-py2.7.egg/rbtools/postreview.py,
line 266, in load_capabilities
info = self.api_get('api/info/')
File /usr/local/lib/python2.7/dist-packages/RBTools-0.5.1.dev-py2.7.egg/rbtools/postreview.py,
line 697, in api_get
return self.process_json(self.http_get(path))
File /usr/local/lib/python2.7/dist-packages/RBTools-0.5.1.dev-py2.7.egg/rbtools/postreview.py,
line 634, in process_json
rsp = json_loads(data)
File /usr/lib/python2.7/json/__init__.py, line 338, in loads
return _default_decoder.decode(s)
File /usr/lib/python2.7/json/decoder.py, line 365, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File /usr/lib/python2.7/json/decoder.py, line 383, in raw_decode
raise ValueError(No JSON object could be decoded)
ValueError: No JSON object could be decoded
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #12 on issue 3044 by abhir...@gmail.com: plasticscm repository
doesn't work
http://code.google.com/p/reviewboard/issues/detail?id=3044
using the latest post-review with the 'master' reviewboard site, give me
the following error,
abhiravk@MrvServer:~/workspace/plastic$ post-review 447
Failed to execute command: ['cm', 'diff', '447', '--format={status} {path}
rev:revid:{revid} rev:revid:{parentrevid} src:{srccmpath}
dst:{dstcmpath}{newline}']
['Incorrect object specification 447\n']
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #13 on issue 3044 by abhir...@gmail.com: plasticscm repository
doesn't work
http://code.google.com/p/reviewboard/issues/detail?id=3044
It doesn't seem to be a debug log 'only'. I also see a red bar which
contents are not readable because it is hidded behind some element. Plastic
repository which I was trying to add is not visible in the reviewboard, so
it seem like adding repository didn't work.
On the other node, I tried to do the same thing on the 'master' branch and
there repository could be added on reviewboard site but creating a review
by giving a changeset doesn't work from the site. A blank review is created
but there is no file description or diff :(
Using 'post-review' encountered the following error when trying to post the
review.
abhiravk@MrvServer:~/workspace/plastic$ post-review 447
Failed to execute command: ['cm', 'diff', '447', '--format={status} {path}
rev:revid:{revid} rev:revid:{parentrevid} src:{srccmpath}
dst:{dstcmpath}{newline}']
['Incorrect object specification 447\n']
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #14 on issue 3044 by abhir...@gmail.com: plasticscm repository
doesn't work
http://code.google.com/p/reviewboard/issues/detail?id=3044
abhiravk@MrvServer:~/workspace/plastic$ post-review cs:412 cs:443
== HTTP Authentication Required
Enter authorization information for Web API at localhost:
Username: abhiravk
Password:
Error uploading diff
Your review request still exists, but the diff is not attached.
--
Web server log when posting review using 'post-review'
--
2013-08-07 01:41:21,024 - DEBUG - None - AnonymousUser -
/api/review-requests/ - Attempting authentication on API for user abhiravk
[07/Aug/2013 01:41:22] POST /api/review-requests/ HTTP/1.1 201 1544
[07/Aug/2013 01:41:22] PUT /api/review-requests/3/draft/ HTTP/1.1 200 914
2013-08-07 01:41:22,978 - DEBUG - - DiffParser.parse: Beginning parse of
diff, size = 45257
2013-08-07 01:41:22,987 - DEBUG - - DiffParser.parse: Finished parsing
diff.
2013-08-07 01:41:22,987 - DEBUG - - Plastic: parse_diff_revision
file /home/abhiravk/workspace/plastic/config_ac.c revision rev:revid:13356
2013-08-07 01:41:22,988 - DEBUG - - Plastic:
file_exists /home/abhiravk/workspace/plastic/config_ac.c revision
rev:revid:13356
2013-08-07 01:41:22,988 - DEBUG - - Plastic:
get_file /home/abhiravk/workspace/config_ac.c rev rev:revid:13356
2013-08-07 01:41:23,528 - ERROR - None - abhiravk -
/api/review-requests/3/diffs/ - Error uploading new diff: The specified
revision was not found rev:revid:13356@rep:op@repserver:172.16.135.11:8087
Traceback (most recent call last):
File /home/abhiravk/workspace/reviewboard/reviewboard/webapi/resources.py,
line 2041, in create
request.FILES.get('parent_diff_path'))
File /home/abhiravk/workspace/reviewboard/reviewboard/reviews/forms.py,
line 310, in create
history)
File /home/abhiravk/workspace/reviewboard/reviewboard/diffviewer/forms.py,
line 54, in create
basedir, self.request)
File /home/abhiravk/workspace/reviewboard/reviewboard/diffviewer/managers.py,
line 80, in create_from_upload
save=save)
File /home/abhiravk/workspace/reviewboard/reviewboard/diffviewer/managers.py,
line 96, in create_from_data
check_existence=(not parent_diff_file_contents)))
File /home/abhiravk/workspace/reviewboard/reviewboard/diffviewer/managers.py,
line 202, in _process_files
not repository.get_file_exists(filename, revision, request))):
File /home/abhiravk/workspace/reviewboard/reviewboard/scmtools/models.py,
line 207, in get_file_exists
exists = self._get_file_exists_uncached(path, revision, request)
File /home/abhiravk/workspace/reviewboard/reviewboard/scmtools/models.py,
line 365, in _get_file_exists_uncached
exists = self.get_scmtool().file_exists(path, revision)
File /home/abhiravk/workspace/reviewboard/reviewboard/scmtools/plastic.py,
line 113, in file_exists
return self.client.get_file(path, revision)
File /home/abhiravk/workspace/reviewboard/reviewboard/scmtools/plastic.py,
line 246, in get_file
raise SCMError(errmsg)
SCMError: The specified revision was not found
rev:revid:13356@rep:op@repserver:172.16.135.11:8087
[07/Aug/2013 01:41:23] POST /api/review-requests/3/diffs/ HTTP/1.1 400 198
---
My repository is using xLinks.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Updates: Status: New Comment #15 on issue 3044 by trowb...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 At this point, I think the regressions that we introduced have been fixed, and we need someone who knows about plastic to weigh in. I emailed the plastic maintainers with a link to this bug, so hopefully they'll take a look at some point. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #9 on issue 3044 by abhir...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 Hi I was testing this fix on 1.7.13 alpha 0 and found the encountered the following error while adding a plastic SCM repository. 09:19:56DEBUG - Plastic: Checking repository op@127.0.0.1:8087 09:19:56DEBUG - Plastic: get_repositories 127.0.0.1:8087 I'll test the fixes on the master branch and share the result. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #10 on issue 3044 by trowb...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 I think that's just some debug logging, not a real error. Did the diff upload correctly? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Updates: Status: PendingReview Comment #6 on issue 3044 by trowb...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 Fixes for both reviewboard and rbtools are pending review. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #7 on issue 3044 by trowb...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 Review Board fix pushed to release-1.7.x (c5a373c). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Updates: Status: Fixed Comment #8 on issue 3044 by trowb...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 RBTools fix pushed to master (3bd0c7f). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Updates: Status: Confirmed Owner: trowb...@gmail.com Labels: Component-RBTools Component-SCMTools Comment #5 on issue 3044 by chip...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 Looks like two things: 1) Fallout from options restructuring on the RBTools side. 2) Fallout from commit ID changes on the Review Board side. (This is why we really need an actual Plastic maintainer, or some solid unit tests.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Updates: Status: NeedInfo Comment #1 on issue 3044 by trowb...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 Are there any errors in the web UI or in the review board logs? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3044 in reviewboard: plasticscm repository doesn't work
Comment #2 on issue 3044 by abhir...@gmail.com: plasticscm repository doesn't work http://code.google.com/p/reviewboard/issues/detail?id=3044 From the logs it seems that get_repositories function in the plastic plugin fails to fetch the repositories. - 2013-07-11 10:16:02,919 - DEBUG - - Plastic: get_repositories On the other note, I tried the dev build(1.8) of reviewboard from the github and it seems to add the PlasticScm repository. However, now 'post-review' fails to raise a review request. There was an error raised by plastic plugin something about '_options'. I don't have the exact exception trace at the moment. I'll try to reproduce the issue and paste the exact backtrace. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
