Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Status: Fixed Comment #19 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 This should work fine now. We now indicate deletes as actual deletes, instead of bothering with any patch operations. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Comment #16 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Actually, that won't be good enough. We really do need the full file path. cvs really should be showing the full path information. The fact that it's not is bad, and we need to investigate how long this has been happening and figure out if there's a fix for it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Owner: chipx86 Labels: -Component-SCMTools Component-DiffViewer Component-DiffParser Comment #17 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Been poking at this. Since the problem is that the RCS File line doesn't contain any information on which module the file is in, we may have to post-process the diff in post-review. Another option is to finally give Review Board a concept of deleted files, but that's potentially a larger change. This appears to be a conscious choice on behalf of cvs: /* This is fullname, not file, possibly despite the POSIX.2 * specification, because that's the way all the Larry Wall * implementations of patch (are there other implementations?) want * things and the POSIX.2 spec appears to leave room for this. */ -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Status: PendingReview Comment #18 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 That wasn't too bad.. I have a patch up for review at http://reviews.reviewboard.org/r/1685/ -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Comment #14 on issue 394 by msbcode: if a diff includes a file that has
been cvs remove'd, reviewboard won't accept it
http://code.google.com/p/reviewboard/issues/detail?id=394
As mentioned above I seem to be having this same issue with ReviewBoard
1.0.8 and a CVS project.
Please let me know if I should file this as a separate issue.
Attached is the output from running post-review with the --output-diff
switch. Note I've edited out the empty output from CVS like cvs diff:
Diffing web/css for directories in which there were no change. The diff
should show that I removed one file (build.properties) and edited two
others.
The output from attempting to upload this change to reviewboard with
post-review is:
HTTP POSTing to
http://localhost/reviewboard/api/json/reviewrequests/new/:
{'repository_path': 'cvshost:/cvsroot/gotoaudio'}
Review request created
Attempting to set field 'summary' to 'g2atest 2' for review request '32'
HTTP POSTing to
http://localhost/reviewboard/api/json/reviewrequests/32/draft/set/:
{'summary': 'g2atest 2'}
Uploading diff, size: 14196
HTTP POSTing to
http://localhost/reviewboard/api/json/reviewrequests/32/diff/new/: {}
Got API Error 207 (HTTP code 200): The file was not found in the
repository
Error data: {u'stat': u'fail', u'file': u'build.properties', u'err':
{u'msg': u'The file was not found in the repository', u'code': 207},
u'revision': u'1.8'}
Error uploading diff
Your review request still exists, but the diff is not attached.
Is there any other data I could supply which would be useful to help
troubleshoot this?
Attachments:
diff.txt 2.3 KB
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Updates: Status: Confirmed Labels: -PendingReview Milestone-Release1.5 Comment #15 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Looks like we need to make sure when we see the +++ /dev/null line that we should mark the file as deleted and not attempt to open it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Comment #13 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 It does look like the fix exists in the codebase, both on master and 1.0.x. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Comment #11 on issue 394 by msbcode: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 I'm having this same issue in ReviewBoard 1.5 beta 2. Was this fix ever applied/accepted? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Comment #12 on issue 394 by msbcode: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Whoops sorry - I'm on 1.0.8, not 1.5. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Issue 394: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Comment #7 by chipx86: Can you please provide this as a diff on http://reviews.review-board.org/ ? Issue attribute updates: Labels: PendingReview -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 394 in reviewboard: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
Issue 394: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it http://code.google.com/p/reviewboard/issues/detail?id=394 Comment #8 by torsten.flatter: Done: http://reviews.review-board.org/r/555/ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
