Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #11 on issue 547 by mailsw...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 I am still seing this issue with the latest release of reviewboard: 1.6.4.1. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #12 on issue 547 by trowb...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 Are you seeing problems with HTTPS or SSH repositories? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #13 on issue 547 by mailsw...@gmail.com: post-review doesn't link
up with authenticated Mercurial repositories properly
http://code.google.com/p/reviewboard/issues/detail?id=547
This issue is with ssh repositories. I'm seeing different issues with https
based repos.
I tried applying the patch but looks like the hg.py file is different from
the time of the patch. Here's the relevant code:
class HgClient(object):
def __init__(self, repoPath, local_site):
from mercurial import hg, ui
from mercurial.__version__ import version
version_parts = [int(x) for x in version.split(.)]
if version_parts[0] == 1 and version_parts[1] = 2:
hg_ui = ui.ui(interactive=False)
else:
hg_ui = ui.ui()
hg_ui.setconfig('ui', 'interactive', 'off')
# Check whether ssh is configured for mercurial. Assume that any
# configured ssh is set up correctly for this repository.
hg_ssh = hg_ui.config('ui', 'ssh')
if not hg_ssh:
logging.debug('Using rbssh for mercurial')
hg_ui.setconfig('ui', 'ssh', 'rbssh --rb-local-site=%s'
% local_site)
else:
logging.debug('Found configured ssh for mercurial: %s' % hg_ssh)
self.repo = hg.repository(hg_ui, path=repoPath)
def cat_file(self, path, rev=tip):
if rev == HEAD:
rev = tip
elif rev == PRE_CREATION:
rev =
try:
return self.repo.changectx(rev).filectx(path).data()
except Exception, e:
# LookupError moves from repo to revlog in hg v0.9.4, so we
# catch the more general Exception to avoid the dependency.
raise FileNotFoundError(path, rev, str(e))
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #14 on issue 547 by trowb...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 Please open a separate bug for ssh repositories. This issue was opened about HTTPS repositories which don't send the WWW-Authenticate header. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #15 on issue 547 by mailsw...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 Logs: 2012-03-28 16:24:39,755 - DEBUG - Using rbssh for mercurial 2012-03-28 16:24:40,559 - DEBUG - Using rbssh for mercurial 2012-03-28 16:24:41,192 - DEBUG - Generating diff viewer page for filediff id 9 2012-03-28 16:24:41,195 - DEBUG - Begin: Generating diff file info for diffset id 9 2012-03-28 16:24:41,200 - DEBUG - Using rbssh for mercurial 2012-03-28 16:24:41,890 - DEBUG - End: Generating diff file info for diffset id 9 2012-03-28 16:24:41,891 - DEBUG - Generating diff file info for diffset id 9 took 0.694481 seconds 2012-03-28 16:24:42,059 - DEBUG - Begin: Generating diff file info for diffset id 9, filediff 14 2012-03-28 16:24:42,060 - DEBUG - Using rbssh for mercurial 2012-03-28 16:24:42,743 - INFO - Cache miss for key reviews.example.com:diff-sidebyside-hl-14. 2012-03-28 16:24:42,746 - DEBUG - Using rbssh for mercurial 2012-03-28 16:24:43,384 - INFO - Cache miss for key reviews.example.com:ssh%3A//hg%40hg.example.com/dev/gui:README:UNKNOWN. 2012-03-28 16:24:43,385 - DEBUG - Begin: Fetching file 'README' rUNKNOWN from gui -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #16 on issue 547 by mailsw...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 ok. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #17 on issue 547 by mailsw...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 Filed bug 2556 for ssh based mercurial issues. Filed bug 2555 for https based mercurial issues. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #19 on issue 547 by mailsw...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 I noticed that the patch in this bug doesn't seem applied on hg.py. Is that by design? Maybe the relevant code was refactored out? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #8 on issue 547 by trowb...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 I just experimented and ssh-based access works now (fixing the issue in comment #5). Not passing the username and password properly when there's no www-authenticate header is a legitimate problem, and one that occurs with other types of servers as well. I'm going to experiment and see if the requests module implements this correctly. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #9 on issue 547 by trowb...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Updates: Status: Fixed Comment #10 on issue 547 by trowb...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 Fixed in release-1.6.x (f591a04) and master. Thanks! -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #6 on issue 547 by amch...@gmail.com: post-review doesn't link up
with authenticated Mercurial repositories properly
http://code.google.com/p/reviewboard/issues/detail?id=547
It looks like post-review sets HGRCPATH to /dev/null which doesn't seem
very friendly or useful. I tried removing this and I get the follow stack
trace:
Traceback (most recent call last):
File /usr/local/share/python/post-review, line 9, in module
load_entry_point('RBTools==0.3.2', 'console_scripts', 'post-review')()
File /usr/local/Cellar/python/2.7.1/lib/python2.7/site-packages/rbtools/postreview.py,
line 3773, in main
diff, parent_diff = tool.diff(args)
File /usr/local/Cellar/python/2.7.1/lib/python2.7/site-packages/rbtools/postreview.py,
line 2446, in diff
return self._get_outgoing_diff(files)
File /usr/local/Cellar/python/2.7.1/lib/python2.7/site-packages/rbtools/postreview.py,
line 2503, in _get_outgoing_diff
self._get_top_and_bottom_outgoing_revs(outgoing_changesets)
File /usr/local/Cellar/python/2.7.1/lib/python2.7/site-packages/rbtools/postreview.py,
line 2540, in _get_top_and_bottom_outgoing_revs
top_rev = max(outgoing_changesets)
ValueError: max() arg is an empty sequence
I am guessing post-review does this to keep problematic hgrc files from
breaking it but it seems to have done the opposite for me.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Comment #3 on issue 547 by xaka2...@gmail.com: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 Any updates on this? I looked at code and see that you put empty env when do hg call so no USER/HOME variables propogates to. That's because hg can't find config file. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 547 in reviewboard: post-review doesn't link up with authenticated Mercurial repositories properly
Updates: Status: Confirmed Labels: Component-RBTools Milestone-RBTools-Release1.0 Comment #1 on issue 547 by chipx86: post-review doesn't link up with authenticated Mercurial repositories properly http://code.google.com/p/reviewboard/issues/detail?id=547 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
