Re: Issue 1511 in reviewboard: Diffs containing only indentation changes causes the diff viewer to look empty
Updates: Status: Fixed Labels: Milestone-Release2.0 Comment #8 on issue 1511 by chip...@gmail.com: Diffs containing only indentation changes causes the diff viewer to look empty http://code.google.com/p/reviewboard/issues/detail?id=1511 Review Board 2.0's diff viewer will show all indentation changes. Committed to master (6dcae76) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 1511 in reviewboard: Diffs containing only indentation changes causes the diff viewer to look empty
Comment #5 on issue 1511 by combacsa: Diffs containing only indentation changes causes the diff viewer to look empty http://code.google.com/p/reviewboard/issues/detail?id=1511 I'm using Python. In Python, whitespace makes changes on indentation level - which means the code block itself is totally changed. For example, a.py if 1 == 2: print hello print world We will got nothing out. But b.py if 1 == 2: print hello print world we will got world printed out on standard output. Whitespace changes everything. So it is a huge problem for Python users. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1511 in reviewboard: Diffs containing only indentation changes causes the diff viewer to look empty
Comment #4 on issue 1511 by jagdmann: Diffs containing only indentation changes causes the diff viewer to look empty http://code.google.com/p/reviewboard/issues/detail?id=1511 I have just run into this on our company review board as well. A fix would be nice, since I often change indention in our legacy code. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1511 in reviewboard: Diffs containing only indentation changes causes the diff viewer to look empty
Updates: Summary: Diffs containing only indentation changes causes the diff viewer to look empty Status: Confirmed Labels: -Priority-Medium Priority-Low Component-DiffViewer Comment #1 on issue 1511 by chipx86: Diffs containing only indentation changes causes the diff viewer to look empty http://code.google.com/p/reviewboard/issues/detail?id=1511 Okay, I've investigated this a little and it can basically be reproduced with a diff such as: --- filename.foo (...) +++ filename.foo (...) @@ ... @@ Some text Some text - Foo + Foo Blah blah - /Foo + /Foo Notice how the only thing that is changing is the indentation. To Review Board, this really means nothing has changed. We don't show leading whitespace changes. So, internally, it's finding that nothing has changed with the code and when we go to render this and see no changed chunks, we consider this to be a file in the changeset without any changes and we remove it from the list. This is important for interdiffs, which is mostly why the logic is there. So, this particular diff in question isn't doing anything but changing indentation and Review Board is therefore not seeing that anything is really up for review. We probably should be a little more graceful about this, but I will point out that this is the first time we've seen this sort of an issue where a diff containing nothing but indentation changes has gone up and confused people. We can look at may be special-casing non-interdiffs and displaying some indication that the file hasn't changed. Given the rarity of the case, though, it's not a huge priority at the moment. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
