date:20160404

Re: Review Request 45724: Activate Standby option should not be shown on HAWQ Standby component on host summary page

2016-04-04 Thread Lav Jain


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45724/#review127037
---


Ship it!




Ship It!

- Lav Jain


On April 5, 2016, 2:38 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45724/
> ---
> 
> (Updated April 5, 2016, 2:38 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, and Lav Jain.
> 
> 
> Bugs: AMBARI-15705
> https://issues.apache.org/jira/browse/AMBARI-15705
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Activate Standby option should not be shown on HAWQ Standby component on host 
> summary page
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/host_component.js 7a5805c 
> 
> Diff: https://reviews.apache.org/r/45724/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Ran unit tests:
>   25609 tests complete (22 seconds)
>   154 tests pending
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 55.352 s
> [INFO] Finished at: 2016-04-04T19:35:54-07:00
> [INFO] Final Memory: 12M/311M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 45714: AMBARI-15703: HostResourceProvider should include maintenance_state when a request is made directly with the host name

2016-04-04 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45714/#review127033
---


Ship it!




Ship It!

- Sumit Mohanty


On April 5, 2016, 4:41 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45714/
> ---
> 
> (Updated April 5, 2016, 4:41 a.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-15703
> https://issues.apache.org/jira/browse/AMBARI-15703
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15703: HostResourceProvider should include ** maintenance_state ** 
> when a request is made directly with the host name
> 
> ** Issue **:
> 
> The property ** maintenance_state ** is not available in host response when 
> making a request directly on the host instead of via the clusters.
> 
> curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
> http://localhost:8080/api/v1/hosts/c6403.ambari.apache.org
> 
> ** Fix **:
> 
> Get the cluster id and the associated maintenance state and add it to the 
> response object.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  1ffd3aa63e5cc0bbd40310634f0e400a2793b36a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  1612233751e498417a07a0175cf10b2aae673769 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
>  23524d7b3962a6ceb5ac4b7b0f0573cb80b929d4 
> 
> Diff: https://reviews.apache.org/r/45714/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.655s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.037s]
> [INFO] Ambari Web  SUCCESS [35.691s]
> [INFO] Ambari Views .. SUCCESS [1.301s]
> [INFO] Ambari Admin View . SUCCESS [7.877s]
> [INFO] ambari-metrics  SUCCESS [0.363s]
> [INFO] Ambari Metrics Common . SUCCESS [0.480s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.100s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.612s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.643s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.527s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6.741s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.144s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.874s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:15.067s]
> [INFO] Ambari Server . SUCCESS [2:39.870s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.719s]
> [INFO] Ambari Agent .. SUCCESS [22.670s]
> [INFO] Ambari Client . SUCCESS [0.073s]
> [INFO] Ambari Python Client .. SUCCESS [0.956s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.413s]
> [INFO] Ambari Shell .. SUCCESS [0.084s]
> [INFO] Ambari Python Shell ... SUCCESS [0.695s]
> [INFO] Ambari Groovy Shell ... SUCCESS [1.066s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 5:33.331s
> [INFO] Finished at: Mon Apr 04 15:54:58 PDT 2016
> [INFO] Final Memory: 270M/1184M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipPythonTests -DTest=HostResourceProviderTest **
> 
> ---
>  T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running org.apache.ambari.server.controller.internal.HostResourceProviderTest
> Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.291 sec - 
> in org.apache.ambari.server.controller.internal.HostResourceProviderTest
> 
> Results :
> 
> Tests run: 31, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
>

Re: Review Request 45714: AMBARI-15703: HostResourceProvider should include maintenance_state when a request is made directly with the host name

2016-04-04 Thread Nahappan Somasundaram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45714/
---

(Updated April 4, 2016, 9:41 p.m.)


Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, and 
Sid Wagle.


Changes
---

Fixed UT failure in AmbariManagementControllerTest.testGetHosts(). Caused by 
variable reuse.


Bugs: AMBARI-15703
https://issues.apache.org/jira/browse/AMBARI-15703


Repository: ambari


Description
---

AMBARI-15703: HostResourceProvider should include ** maintenance_state ** when 
a request is made directly with the host name

** Issue **:

The property ** maintenance_state ** is not available in host response when 
making a request directly on the host instead of via the clusters.

curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
http://localhost:8080/api/v1/hosts/c6403.ambari.apache.org

** Fix **:

Get the cluster id and the associated maintenance state and add it to the 
response object.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 1ffd3aa63e5cc0bbd40310634f0e400a2793b36a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 1612233751e498417a07a0175cf10b2aae673769 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
 23524d7b3962a6ceb5ac4b7b0f0573cb80b929d4 

Diff: https://reviews.apache.org/r/45714/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.655s]
[INFO] Apache Ambari Project POM . SUCCESS [0.037s]
[INFO] Ambari Web  SUCCESS [35.691s]
[INFO] Ambari Views .. SUCCESS [1.301s]
[INFO] Ambari Admin View . SUCCESS [7.877s]
[INFO] ambari-metrics  SUCCESS [0.363s]
[INFO] Ambari Metrics Common . SUCCESS [0.480s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.100s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.612s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.643s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.527s]
[INFO] Ambari Metrics Collector .. SUCCESS [6.741s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.144s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.874s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:15.067s]
[INFO] Ambari Server . SUCCESS [2:39.870s]
[INFO] Ambari Functional Tests ... SUCCESS [2.719s]
[INFO] Ambari Agent .. SUCCESS [22.670s]
[INFO] Ambari Client . SUCCESS [0.073s]
[INFO] Ambari Python Client .. SUCCESS [0.956s]
[INFO] Ambari Groovy Client .. SUCCESS [2.413s]
[INFO] Ambari Shell .. SUCCESS [0.084s]
[INFO] Ambari Python Shell ... SUCCESS [0.695s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.066s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5:33.331s
[INFO] Finished at: Mon Apr 04 15:54:58 PDT 2016
[INFO] Final Memory: 270M/1184M
[INFO] 

** 2. mvn test -DskipPythonTests -DTest=HostResourceProviderTest **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.controller.internal.HostResourceProviderTest
Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.291 sec - in 
org.apache.ambari.server.controller.internal.HostResourceProviderTest

Results :

Tests run: 31, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 29.600s
[INFO] Finished at: Mon Apr 04 15:59:10 PDT 2016
[INFO] Final Memory: 56M/1023M
[INFO] 

** 3. Manual tests ** 

Deploy a VM with ambari-server JAR replaced with the fix. Try the following

Review Request 45724: Activate Standby option should not be shown on HAWQ Standby component on host summary page

2016-04-04 Thread Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45724/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, 
and Lav Jain.


Bugs: AMBARI-15705
https://issues.apache.org/jira/browse/AMBARI-15705


Repository: ambari


Description
---

Activate Standby option should not be shown on HAWQ Standby component on host 
summary page


Diffs
-

  ambari-web/app/models/host_component.js 7a5805c 

Diff: https://reviews.apache.org/r/45724/diff/


Testing
---

Manually Tested.

Ran unit tests:
  25609 tests complete (22 seconds)
  154 tests pending

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 55.352 s
[INFO] Finished at: 2016-04-04T19:35:54-07:00
[INFO] Final Memory: 12M/311M
[INFO] 


Thanks,

Matt

Re: Review Request 45703: Allow skipping creation of repo files

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/#review127013
---


Ship it!





ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
(lines 121 - 122)


Is this really a warning? Kind of odd to warn on a feature.


- Jonathan Hurley


On April 4, 2016, 5 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45703/
> ---
> 
> (Updated April 4, 2016, 5 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15697
> https://issues.apache.org/jira/browse/AMBARI-15697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RH Satellite requires that Ambari not manage the repositories for an OS.  Add 
> an attribute to OperatingSystems that gets persisted to do this work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  f3197cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a0b98f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java
>  06b4148 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  bb50820 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java
>  fd4a91f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/OperatingSystemEntity.java
>  3c881a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  6a36522 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c01dbb3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  05751fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  4da8896 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  e031fc8 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py ad4206b 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  aacd1f2 
> 
> Diff: https://reviews.apache.org/r/45703/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-04 Thread Srimanth Gunturi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45705/#review127014
---


Ship it!




Ship It!

- Srimanth Gunturi


On April 4, 2016, 9:48 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45705/
> ---
> 
> (Updated April 4, 2016, 9:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, Lav Jain, Matt, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15693
> https://issues.apache.org/jira/browse/AMBARI-15693
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ segment percentage alert critical threshold should be 25%
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 8da5beb 
>   ambari-web/app/views/main/dashboard/widgets.js 04be7bb 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js c35d2b2 
> 
> Diff: https://reviews.apache.org/r/45705/diff/
> 
> 
> Testing
> ---
> 
> manual, ran python tests:
> 
> --
> Total run:933
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 45703: Allow skipping creation of repo files

2016-04-04 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/#review127012
---


Ship it!




Ship It!

- Jayush Luniya


On April 4, 2016, 9 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45703/
> ---
> 
> (Updated April 4, 2016, 9 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15697
> https://issues.apache.org/jira/browse/AMBARI-15697
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RH Satellite requires that Ambari not manage the repositories for an OS.  Add 
> an attribute to OperatingSystems that gets persisted to do this work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  f3197cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a0b98f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java
>  06b4148 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  bb50820 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java
>  fd4a91f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/OperatingSystemEntity.java
>  3c881a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  6a36522 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c01dbb3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  05751fa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  4da8896 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
>  e031fc8 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py ad4206b 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  aacd1f2 
> 
> Diff: https://reviews.apache.org/r/45703/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-04 Thread Matt



> On April 4, 2016, 7:17 p.m., Jayush Luniya wrote:
> > ambari-web/app/views/main/dashboard/widgets.js, line 481
> > 
> >
> > Surprised that this needs UI changes too. Why isnt alerts.json change 
> > sufficient for this? 
> > 
> > Also these values need documentation.

Change to the alert.json is sufficient for the alert.

We have a main dashboard widget that shows no. of HAWQ Segments Live (similar 
to Datanodes Live). The dashboard widget is independent of the alert.
The change to the UI is to keep the thresholds of the dashboard widget similar 
to that of the alert thresholds so that users see the same color coding (Alert 
- CRITICAL RED when 25% or more segments are down AND Dashboard widget shows 
RED when less than 75% of segments are up)


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45705/#review127007
---


On April 4, 2016, 2:48 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45705/
> ---
> 
> (Updated April 4, 2016, 2:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, Lav Jain, Matt, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15693
> https://issues.apache.org/jira/browse/AMBARI-15693
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ segment percentage alert critical threshold should be 25%
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 8da5beb 
>   ambari-web/app/views/main/dashboard/widgets.js 04be7bb 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js c35d2b2 
> 
> Diff: https://reviews.apache.org/r/45705/diff/
> 
> 
> Testing
> ---
> 
> manual, ran python tests:
> 
> --
> Total run:933
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-04 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45705/#review127007
---




ambari-web/app/views/main/dashboard/widgets.js (line 481)


Surprised that this needs UI changes too. Why isnt alerts.json change 
sufficient for this? 

Also these values need documentation.


- Jayush Luniya


On April 4, 2016, 9:48 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45705/
> ---
> 
> (Updated April 4, 2016, 9:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, Lav Jain, Matt, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15693
> https://issues.apache.org/jira/browse/AMBARI-15693
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ segment percentage alert critical threshold should be 25%
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 8da5beb 
>   ambari-web/app/views/main/dashboard/widgets.js 04be7bb 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js c35d2b2 
> 
> Diff: https://reviews.apache.org/r/45705/diff/
> 
> 
> Testing
> ---
> 
> manual, ran python tests:
> 
> --
> Total run:933
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%

2016-04-04 Thread Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45705/#review127001
---


Ship it!




Ship It!

- Matt


On April 4, 2016, 2:48 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45705/
> ---
> 
> (Updated April 4, 2016, 2:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, Lav Jain, Matt, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15693
> https://issues.apache.org/jira/browse/AMBARI-15693
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ segment percentage alert critical threshold should be 25%
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 
> 8da5beb 
>   ambari-web/app/views/main/dashboard/widgets.js 04be7bb 
>   ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js c35d2b2 
> 
> Diff: https://reviews.apache.org/r/45705/diff/
> 
> 
> Testing
> ---
> 
> manual, ran python tests:
> 
> --
> Total run:933
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Review Request 45714: AMBARI-15703: HostResourceProvider should include maintenance_state when a request is made directly with the host name

2016-04-04 Thread Nahappan Somasundaram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45714/
---

Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, and 
Sid Wagle.


Bugs: AMBARI-15703
https://issues.apache.org/jira/browse/AMBARI-15703


Repository: ambari


Description
---

AMBARI-15703: HostResourceProvider should include ** maintenance_state ** when 
a request is made directly with the host name

** Issue **:

The property ** maintenance_state ** is not available in host response when 
making a request directly on the host instead of via the clusters.

curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
http://localhost:8080/api/v1/hosts/c6403.ambari.apache.org

** Fix **:

Get the cluster id and the associated maintenance state and add it to the 
response object.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 1ffd3aa63e5cc0bbd40310634f0e400a2793b36a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
 23524d7b3962a6ceb5ac4b7b0f0573cb80b929d4 

Diff: https://reviews.apache.org/r/45714/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.655s]
[INFO] Apache Ambari Project POM . SUCCESS [0.037s]
[INFO] Ambari Web  SUCCESS [35.691s]
[INFO] Ambari Views .. SUCCESS [1.301s]
[INFO] Ambari Admin View . SUCCESS [7.877s]
[INFO] ambari-metrics  SUCCESS [0.363s]
[INFO] Ambari Metrics Common . SUCCESS [0.480s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.100s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.612s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.643s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.527s]
[INFO] Ambari Metrics Collector .. SUCCESS [6.741s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.144s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.874s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:15.067s]
[INFO] Ambari Server . SUCCESS [2:39.870s]
[INFO] Ambari Functional Tests ... SUCCESS [2.719s]
[INFO] Ambari Agent .. SUCCESS [22.670s]
[INFO] Ambari Client . SUCCESS [0.073s]
[INFO] Ambari Python Client .. SUCCESS [0.956s]
[INFO] Ambari Groovy Client .. SUCCESS [2.413s]
[INFO] Ambari Shell .. SUCCESS [0.084s]
[INFO] Ambari Python Shell ... SUCCESS [0.695s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.066s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5:33.331s
[INFO] Finished at: Mon Apr 04 15:54:58 PDT 2016
[INFO] Final Memory: 270M/1184M
[INFO] 

** 2. mvn test -DskipPythonTests -DTest=HostResourceProviderTest **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.controller.internal.HostResourceProviderTest
Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.291 sec - in 
org.apache.ambari.server.controller.internal.HostResourceProviderTest

Results :

Tests run: 31, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 29.600s
[INFO] Finished at: Mon Apr 04 15:59:10 PDT 2016
[INFO] Final Memory: 56M/1023M
[INFO] 

** 3. Manual tests ** 

Deploy a VM with ambari-server JAR replaced with the fix. Try the following 
request:

curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
http://localhost:8080/api/v1/hosts/c6403.ambari.apache.org

Manually verify that the response contains ** maintenance_state ** property:

"last_heartbeat_time" : 1459810855978,
"last_registration_time" : 1459802815284,

Re: Review Request 45712: Global Repeat Tolerance Value For Alerts

2016-04-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/#review126966
---


Ship it!




Ship It!

- Nate Cole


On April 4, 2016, 6:47 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45712/
> ---
> 
> (Updated April 4, 2016, 6:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15702
> https://issues.apache.org/jira/browse/AMBARI-15702
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The global repeat tolerance value for all alert definitions is set on the 
> {{cluster-env}} configuration. Unless an alert definition overrides this 
> value, it will be used for any definition in the system. By default, this 
> value will be set to 1, indicating that there is no retry tolerance and the 
> alert state should be taken at face value.
> 
> ```
> GET api/v1/clusters//configurations?type=cluster-env=
> 
>   "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
>   },
>   "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
>...
>   }
> ```
> 
> The scope of work must also include
> - Default values if the property does not exist
> - Ambari upgrade work to ensure it's populated with a default value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java
>  951b04b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  4c20c6c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java
>  dec2a33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  2800ac6 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 38d05ab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 77e36c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  9e456eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b3241e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  f8a1f64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  df2ef46 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  ea0547b 
> 
> Diff: https://reviews.apache.org/r/45712/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45712: Global Repeat Tolerance Value For Alerts

2016-04-04 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/#review126965
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 4, 2016, 10:47 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45712/
> ---
> 
> (Updated April 4, 2016, 10:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15702
> https://issues.apache.org/jira/browse/AMBARI-15702
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The global repeat tolerance value for all alert definitions is set on the 
> {{cluster-env}} configuration. Unless an alert definition overrides this 
> value, it will be used for any definition in the system. By default, this 
> value will be set to 1, indicating that there is no retry tolerance and the 
> alert state should be taken at face value.
> 
> ```
> GET api/v1/clusters//configurations?type=cluster-env=
> 
>   "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
>   },
>   "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
>...
>   }
> ```
> 
> The scope of work must also include
> - Default values if the property does not exist
> - Ambari upgrade work to ensure it's populated with a default value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java
>  951b04b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  4c20c6c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java
>  dec2a33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  2800ac6 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 38d05ab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 77e36c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  9e456eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  b3241e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  f8a1f64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  df2ef46 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  ea0547b 
> 
> Diff: https://reviews.apache.org/r/45712/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45462: AMBARI-15604 Alert Definitions Repeat Tolerance Values Exposed In Web Client

2016-04-04 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45462/#review126964
---


Ship it!




Ship It!

- Richard Zang


On April 4, 2016, 10:44 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45462/
> ---
> 
> (Updated April 4, 2016, 10:44 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15604
> https://issues.apache.org/jira/browse/AMBARI-15604
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Alert definitions will now expose two properties to control repeat tolerance 
> values on an individual based (overriding those from 
> cluster-env/alerts_repeat_tolerance)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/update_controller.js dcef1a2 
>   ambari-web/app/controllers/main/alerts/definition_details_controller.js 
> fe17732 
>   ambari-web/app/mappers/alert_definitions_mapper.js 0bf534e 
>   ambari-web/app/messages.js 1653eeb 
>   ambari-web/app/models/alerts/alert_definition.js a730572 
>   ambari-web/app/styles/alerts.less 50246e6 
>   ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d 
>   ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1 
>   ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b 
> 
> Diff: https://reviews.apache.org/r/45462/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 25642 tests complete (22 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45712: Global Repeat Tolerance Value For Alerts

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/
---

(Updated April 4, 2016, 6:47 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
Luniya, and Nate Cole.


Bugs: AMBARI-15702
https://issues.apache.org/jira/browse/AMBARI-15702


Repository: ambari


Description
---

The global repeat tolerance value for all alert definitions is set on the 
{{cluster-env}} configuration. Unless an alert definition overrides this value, 
it will be used for any definition in the system. By default, this value will 
be set to 1, indicating that there is no retry tolerance and the alert state 
should be taken at face value.

```
GET api/v1/clusters//configurations?type=cluster-env=

  "Config": {
"cluster_name": "c1",
"stack_id": "HDP-2.4"
  },
  "properties": {
"command_retry_enabled": "true",
"command_retry_max_time_in_sec": "600",
...
"alerts_repeat_tolerance" : "1"
   ...
  }
```

The scope of work must also include
- Default values if the property does not exist
- Ambari upgrade work to ensure it's populated with a default value


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java
 951b04b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 4c20c6c 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java
 dec2a33 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 2800ac6 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
38d05ab 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
77e36c8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 9e456eb 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 b3241e0 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
 f8a1f64 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 df2ef46 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 ea0547b 

Diff: https://reviews.apache.org/r/45712/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 45712: Global Repeat Tolerance Value For Alerts

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
Luniya, and Nate Cole.


Bugs: AMBARI-15702
https://issues.apache.org/jira/browse/AMBARI-15702


Repository: ambari


Description
---

The global repeat tolerance value for all alert definitions is set on the 
{{cluster-env}} configuration. Unless an alert definition overrides this value, 
it will be used for any definition in the system. By default, this value will 
be set to 1, indicating that there is no retry tolerance and the alert state 
should be taken at face value.

```
GET api/v1/clusters//configurations?type=cluster-env=

  "Config": {
"cluster_name": "c1",
"stack_id": "HDP-2.4"
  },
  "properties": {
"command_retry_enabled": "true",
"command_retry_max_time_in_sec": "600",
...
"alerts_repeat_tolerance" : "1"
   ...
  }
```

The scope of work must also include
- Default values if the property does not exist
- Ambari upgrade work to ensure it's populated with a default value


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java
 951b04b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 4c20c6c 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java
 dec2a33 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 2800ac6 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
38d05ab 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
77e36c8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 9e456eb 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 b3241e0 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
 f8a1f64 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 df2ef46 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 ea0547b 

Diff: https://reviews.apache.org/r/45712/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts

2016-04-04 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45612/#review126961
---


Ship it!




Ship It!

- Richard Zang


On April 4, 2016, 10:02 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45612/
> ---
> 
> (Updated April 4, 2016, 10:02 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15605
> https://issues.apache.org/jira/browse/AMBARI-15605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Alert repeat tolerance values should be captured and exposed via the API. The 
> rules for capturing the occurrences of an alert are:
> 
> - Alert instances always start at 1
> - Alerts with an {{OK}} state always reset the counter
> - When transitioning from {{OK}} to non-{{OK}}, the counter is reset
> - When transitioning within non-{{OK}} states (such as back and forth between 
> {{WARNING}} and {{CRITICAL}}, the counter is merely incremented.
> 
> GET api/v1/clusters/c1/alerts/1
> {
>   "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1;,
>   "Alert": {
> "cluster_name": "c1",
> ...
> "repeat_tolerance": 1,
> "repeat_tolerance_remaining": 0,
> "occurrences": 8,
> 
> 
> - {{OK}} alert instances will *always* have a value of {{0}} for 
> {{repeat_tolerance_remaining}} since they do not honor repeat tolerance. An 
> {{OK}} alert is considered to be correct always.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/update_controller.js dcef1a2 
>   ambari-web/app/mappers/alert_instances_mapper.js 349d94d 
>   ambari-web/app/messages.js 1b2a02f 
>   ambari-web/app/models/alerts/alert_instance.js d8710a0 
>   ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 4debe10 
>   ambari-web/app/templates/main/alerts/alert_instance/status.hbs d82bc7b 
>   ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d 
>   ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1 
> 
> Diff: https://reviews.apache.org/r/45612/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 25602 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45710: AMBARI-15701. Host filter: minor UX edits

2016-04-04 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45710/#review126958
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On April 4, 2016, 10:14 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45710/
> ---
> 
> (Updated April 4, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-15701
> https://issues.apache.org/jira/browse/AMBARI-15701
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add solid background style to facet.
> Change "Health Status" to "Host Status"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less a6b79ce 
>   ambari-web/app/views/main/host/combo_search_box.js b31fe81 
> 
> Diff: https://reviews.apache.org/r/45710/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster. All unit tests passed.
>   25600 tests complete (26 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 45710: AMBARI-15701. Host filter: minor UX edits

2016-04-04 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45710/
---

Review request for Ambari and Zhe (Joe) Wang.


Bugs: AMBARI-15701
https://issues.apache.org/jira/browse/AMBARI-15701


Repository: ambari


Description
---

Add solid background style to facet.
Change "Health Status" to "Host Status"


Diffs
-

  ambari-web/app/styles/application.less a6b79ce 
  ambari-web/app/views/main/host/combo_search_box.js b31fe81 

Diff: https://reviews.apache.org/r/45710/diff/


Testing
---

Manually tested on live cluster. All unit tests passed.
  25600 tests complete (26 seconds)
  154 tests pending


Thanks,

Richard Zang

Re: Review Request 45708: AMBARI-15699: Remove HDP specific hardcodings from common-services config properties

2016-04-04 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45708/
---

(Updated April 4, 2016, 10:11 p.m.)


Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
Mohanty.


Bugs: AMBARI-15699
https://issues.apache.org/jira/browse/AMBARI-15699


Repository: ambari


Description
---

Remove HDP specific hardcodings from common-services config properties


Diffs
-

  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
 325886f 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml
 c2e0200 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
 eef1daf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
 6b3bb6c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-env.xml
 3cda54a 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-policymgr-ssl.xml
 f6b4cbc 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 ee0c48f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/configuration/oozie-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/configuration/zeppelin-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45708/diff/


Testing (updated)
---

mvn clean test -DskipSurefireTests

--
Ran 253 tests in 6.647s

OK
--
Total run:933
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 54.075s
[INFO] Finished at: Mon Apr 04 15:11:13 PDT 2016
[INFO] Final Memory: 62M/1125M
[INFO] 


Thanks,

Jayush Luniya

Re: Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts

2016-04-04 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45612/
---

(Updated April 4, 2016, 10:02 p.m.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15605
https://issues.apache.org/jira/browse/AMBARI-15605


Repository: ambari


Description
---

Alert repeat tolerance values should be captured and exposed via the API. The 
rules for capturing the occurrences of an alert are:

- Alert instances always start at 1
- Alerts with an {{OK}} state always reset the counter
- When transitioning from {{OK}} to non-{{OK}}, the counter is reset
- When transitioning within non-{{OK}} states (such as back and forth between 
{{WARNING}} and {{CRITICAL}}, the counter is merely incremented.

GET api/v1/clusters/c1/alerts/1
{
  "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1;,
  "Alert": {
"cluster_name": "c1",
...
"repeat_tolerance": 1,
"repeat_tolerance_remaining": 0,
"occurrences": 8,


- {{OK}} alert instances will *always* have a value of {{0}} for 
{{repeat_tolerance_remaining}} since they do not honor repeat tolerance. An 
{{OK}} alert is considered to be correct always.


Diffs (updated)
-

  ambari-web/app/controllers/global/update_controller.js dcef1a2 
  ambari-web/app/mappers/alert_instances_mapper.js 349d94d 
  ambari-web/app/messages.js 1b2a02f 
  ambari-web/app/models/alerts/alert_instance.js d8710a0 
  ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 4debe10 
  ambari-web/app/templates/main/alerts/alert_instance/status.hbs d82bc7b 
  ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d 
  ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1 

Diff: https://reviews.apache.org/r/45612/diff/


Testing
---

Local ambari-web test passed.
25602 tests complete (23 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Review Request 45703: Allow skipping creation of repo files

2016-04-04 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-15697
https://issues.apache.org/jira/browse/AMBARI-15697


Repository: ambari


Description
---

RH Satellite requires that Ambari not manage the repositories for an OS.  Add 
an attribute to OperatingSystems that gets persisted to do this work.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 f3197cb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 a0b98f7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/OperatingSystemResponse.java
 06b4148 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 bb50820 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java
 fd4a91f 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/OperatingSystemEntity.java
 3c881a1 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 6a36522 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
c01dbb3 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
 05751fa 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
 4da8896 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
 e031fc8 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py ad4206b 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
 aacd1f2 

Diff: https://reviews.apache.org/r/45703/diff/


Testing
---

Manual.  Automated pending


Thanks,

Nate Cole

Re: Review Request 45692: AMBARI-15603 Exposure of Global Alert Repeat Tolerance Value in Web Client

2016-04-04 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45692/#review126937
---


Ship it!




Ship It!

- Richard Zang


On April 4, 2016, 5:58 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45692/
> ---
> 
> (Updated April 4, 2016, 5:58 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15603
> https://issues.apache.org/jira/browse/AMBARI-15603
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The global repeat tolerance value for all alert definitions is set on the 
> cluster-env configuration. Unless an alert definition overrides this value, 
> it will be used for any definition in the system. By default, this value will 
> be set to 1, indicating that there is no tolerance and the alert state should 
> be taken at face value.
> 
> GET api/v1/clusters//configurations?type=cluster-env=
> 
>   "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
>   },
>   "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
>...
>   }
> 
> The web client should expose a way to update the {{cluster-env}} to set this 
> value. 
> 
> *UI Warning of Delayed Alerts*
> When changing the value of the global of definition-specific repeat 
> tolerance, a warning should be presented to the user to indicate that it will 
> now take longer for the alert notifications to be sent. This is because 
> notifications are delayed until the interval multiplied by the repeat 
> tolerance is reached. Consider the case where the check against an alert 
> happens every 5 minutes and the repeat tolerance is set to 5. It will be at 
> least 25 minutes before any outbound notifications are dispatched. This 
> warning can be on a per-alert definition basis as well as when setting the 
> global value.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  dc9f78c 
>   ambari-web/app/messages.js 1b2a02f 
>   ambari-web/app/styles/application.less a6b79ce 
>   ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65 
> 
> Diff: https://reviews.apache.org/r/45692/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 25600 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45692: AMBARI-15603 Exposure of Global Alert Repeat Tolerance Value in Web Client

2016-04-04 Thread Jaimin Jetly



> On April 4, 2016, 8:35 p.m., Jaimin Jetly wrote:
> > This patch doesn't address newly installed cluster case but does not 
> > address upgrade scenario i.e introducing new 
> > cluster-env/alerts_repeat_tolerance property to the existing cluster on 
> > upgrade with stack default value.
> > If there is not task tracking this work please create one.

Typo in the above comment.
This patch *do* address newly installed cluster case but does not address 
upgrade scenario


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45692/#review126935
---


On April 4, 2016, 5:58 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45692/
> ---
> 
> (Updated April 4, 2016, 5:58 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15603
> https://issues.apache.org/jira/browse/AMBARI-15603
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The global repeat tolerance value for all alert definitions is set on the 
> cluster-env configuration. Unless an alert definition overrides this value, 
> it will be used for any definition in the system. By default, this value will 
> be set to 1, indicating that there is no tolerance and the alert state should 
> be taken at face value.
> 
> GET api/v1/clusters//configurations?type=cluster-env=
> 
>   "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
>   },
>   "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
>...
>   }
> 
> The web client should expose a way to update the {{cluster-env}} to set this 
> value. 
> 
> *UI Warning of Delayed Alerts*
> When changing the value of the global of definition-specific repeat 
> tolerance, a warning should be presented to the user to indicate that it will 
> now take longer for the alert notifications to be sent. This is because 
> notifications are delayed until the interval multiplied by the repeat 
> tolerance is reached. Consider the case where the check against an alert 
> happens every 5 minutes and the repeat tolerance is set to 5. It will be at 
> least 25 minutes before any outbound notifications are dispatched. This 
> warning can be on a per-alert definition basis as well as when setting the 
> global value.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  dc9f78c 
>   ambari-web/app/messages.js 1b2a02f 
>   ambari-web/app/styles/application.less a6b79ce 
>   ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65 
> 
> Diff: https://reviews.apache.org/r/45692/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 25600 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45692: AMBARI-15603 Exposure of Global Alert Repeat Tolerance Value in Web Client

2016-04-04 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45692/#review126935
---


Ship it!




This patch doesn't address newly installed cluster case but does not address 
upgrade scenario i.e introducing new cluster-env/alerts_repeat_tolerance 
property to the existing cluster on upgrade with stack default value.
If there is not task tracking this work please create one.

- Jaimin Jetly


On April 4, 2016, 5:58 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45692/
> ---
> 
> (Updated April 4, 2016, 5:58 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
> Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15603
> https://issues.apache.org/jira/browse/AMBARI-15603
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The global repeat tolerance value for all alert definitions is set on the 
> cluster-env configuration. Unless an alert definition overrides this value, 
> it will be used for any definition in the system. By default, this value will 
> be set to 1, indicating that there is no tolerance and the alert state should 
> be taken at face value.
> 
> GET api/v1/clusters//configurations?type=cluster-env=
> 
>   "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
>   },
>   "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
>...
>   }
> 
> The web client should expose a way to update the {{cluster-env}} to set this 
> value. 
> 
> *UI Warning of Delayed Alerts*
> When changing the value of the global of definition-specific repeat 
> tolerance, a warning should be presented to the user to indicate that it will 
> now take longer for the alert notifications to be sent. This is because 
> notifications are delayed until the interval multiplied by the repeat 
> tolerance is reached. Consider the case where the check against an alert 
> happens every 5 minutes and the repeat tolerance is set to 5. It will be at 
> least 25 minutes before any outbound notifications are dispatched. This 
> warning can be on a per-alert definition basis as well as when setting the 
> global value.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  dc9f78c 
>   ambari-web/app/messages.js 1b2a02f 
>   ambari-web/app/styles/application.less a6b79ce 
>   ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65 
> 
> Diff: https://reviews.apache.org/r/45692/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 25600 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 45612: AMBARI-15605 UI Changes To Expose Alert Repeat Tolerance Counts

2016-04-04 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45612/
---

(Updated April 4, 2016, 8:23 p.m.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15605
https://issues.apache.org/jira/browse/AMBARI-15605


Repository: ambari


Description
---

Alert repeat tolerance values should be captured and exposed via the API. The 
rules for capturing the occurrences of an alert are:

- Alert instances always start at 1
- Alerts with an {{OK}} state always reset the counter
- When transitioning from {{OK}} to non-{{OK}}, the counter is reset
- When transitioning within non-{{OK}} states (such as back and forth between 
{{WARNING}} and {{CRITICAL}}, the counter is merely incremented.

GET api/v1/clusters/c1/alerts/1
{
  "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1;,
  "Alert": {
"cluster_name": "c1",
...
"repeat_tolerance": 1,
"repeat_tolerance_remaining": 0,
"occurrences": 8,


- {{OK}} alert instances will *always* have a value of {{0}} for 
{{repeat_tolerance_remaining}} since they do not honor repeat tolerance. An 
{{OK}} alert is considered to be correct always.


Diffs (updated)
-

  ambari-web/app/controllers/global/update_controller.js dcef1a2 
  ambari-web/app/mappers/alert_instances_mapper.js 349d94d 
  ambari-web/app/messages.js 1b2a02f 
  ambari-web/app/models/alerts/alert_instance.js d8710a0 
  ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 4debe10 
  ambari-web/app/templates/main/alerts/alert_instance/status.hbs d82bc7b 
  ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d 
  ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1 

Diff: https://reviews.apache.org/r/45612/diff/


Testing
---

Local ambari-web test passed.
25602 tests complete (23 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 45696: AMBARI-15692 : AMS-HBase should explicitly set its HBASE_HOME path

2016-04-04 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45696/
---

(Updated April 4, 2016, 8:17 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Changes
---

Added unit test.


Bugs: AMBARI-15692
https://issues.apache.org/jira/browse/AMBARI-15692


Repository: ambari


Description
---

AMS-Collector host had the environment variable HBASE_HOME=/usr/lib/hbase 
defined somewhere in the system. AMS user somehow inherited this environment 
variable. When AMS-Collector started, he would start the embedded HBase which 
would use the incorrect environment variable and failed to start 
(/usr/lib/hbase was missing many JARs).

AMS-HBase's hbase-env.sh script should explicitly set the HBASE_HOME to its own 
path and not fail due to some incorrect environment variable.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f4a0b8c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 378138b 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 3723ff8 

Diff: https://reviews.apache.org/r/45696/diff/


Testing
---

Manually tested on cluster where AMS co-existed with cluster HBase.


Thanks,

Aravindan Vijayan

Re: Review Request 45560: AMBARI-15655: Remove remaining hdp specific logic from resource_management library

2016-04-04 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45560/#review126922
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 31, 2016, 9:16 p.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45560/
> ---
> 
> (Updated March 31, 2016, 9:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15655
> https://issues.apache.org/jira/browse/AMBARI-15655
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove remaining HDP specific logic from resource_management. 
> AMBARI-15420 didnt cover them as this need stack_featurization changes.
> 
> TODOs:
> 1. Cleanup HDP hardcodings in custom_actions scripts
> 2. Cleanup HDP hardcodings in configurations especially in common-services
> 3. Stack-driven configs for lzo-packages, list of repos etc.
> 
> 
> Diffs
> -
> 
>   
> ambari-agent/src/test/python/resource_management/TestListAmbariManagedRepos.py
>  8c590da 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  d4e88e7 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  870bb0c 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/list_ambari_managed_repos.py
>  bab6374 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  6169699 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  02cd7ca 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
>  9122a0e 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
>  38269cb 
>   
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py
>  4467114 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 4020ae0 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 9fa24cc 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 338d3d3 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> b6a19ec 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 8c61b0b 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 67bbb9d 
> 
> Diff: https://reviews.apache.org/r/45560/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45686: Alert Dispatch Scheduling Changes to Support Repeat Tolerance

2016-04-04 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45686/#review126918
---


Ship it!




Ship It!

- Jayush Luniya


On April 4, 2016, 3:49 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45686/
> ---
> 
> (Updated April 4, 2016, 3:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15686
> https://issues.apache.org/jira/browse/AMBARI-15686
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When an alert state change is received, its notification will no longer be 
> queued for immediate delivery if the firmness of the alert is SOFT. Instead, 
> notifications will only be created and queued for delivery if the alert 
> firmness is HARD in order to prevent false positives on alerts which have 
> repeat tolerance enabled. 
> 
> Changes Included in this task:
> - Database changes to support HARD/SOFT states to complement repeat 
> occurrence values
> ```
> CREATE TABLE alert_current (
>   ...
>   occurrences BIGINT NOT NULL DEFAULT 1,
>   firmness VARCHAR(255) NOT NULL DEFAULT 'HARD',
>   ...
> );
> ```
> 
> - Changes to eventing system to handle alert state changes difference 
> depending on whether the alerts are HARD/SOFT
> - HARD/SOFT Calculations
> -- If an alert is {{AlertState#OK}}, then the firmness is always 
> {{AlertFirmness#HARD}}
> -- If an alert is {{link SourceType#AGGREGATE}}, then the firmness is always 
> {{link AlertFirmness#HARD}}.
> -- Otherwise, the firmness will be {@link AlertFirmness#SOFT} unless the 
> repeat tolerance has been met.
> 
> - Exposure of HARD/SOFT alert states
> ```
> GET api/v1/clusters/c1/alerts/1
> {
>   "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1;,
>   "Alert": {
> "cluster_name": "c1",
> ...
> "repeat_tolerance": 1,
> "repeat_tolerance_remaining": 0,
> "occurrences": 8,
> "firmness": "HARD"
> 
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  5a985d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertStateChangeEvent.java
>  60dbec4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java
>  0bcfa2f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  fbd5c12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
>  08563e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
>  31f2154 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> f91d372 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/AlertFirmness.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f4a0b8c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2fb2195 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 6a3712e 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 964941f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 366bbeb 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> f7e7262 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bdb6843 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c6df84a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
>  29969d6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  7d6c691 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
>  e42e1a7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  3ddeb2a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  3723ff8 
> 
> Diff: https://reviews.apache.org/r/45686/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45598: Stack Upgrade should allow suspended=false when aborting an upgrade to initiate a downgrade

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45598/#review126903
---


Ship it!




Ship It!

- Jonathan Hurley


On April 4, 2016, 3:01 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45598/
> ---
> 
> (Updated April 4, 2016, 3:01 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-15673
> https://issues.apache.org/jira/browse/AMBARI-15673
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Installed Ambari ambari-server-2.2.2.0-354.x86_64
> * HDP 2.3.0.0-2557
> * Installed bits for HDP 2.4.0.0-169
> * Performed EU
> * It failed on waiting to leave HDFS Safemode, but you can do this on any 
> manual stage, such as Pre-Finalize; click the "Downgrade" button
> Notice that the current Upgrade did not get ABORTED.
> 
> I had to manually run,
> ```update host_role_command set status = 'ABORTED' WHERE  request_id = ? and 
> status IN ('PENDING', 'HOLDING_FAILED');```
> 
> Root cause is that UpgradeResourceProvider was expecting both these 
> properties to be passed as "status=ABORTED" & "suspended=true".
> The UI was passing "status=ABORTED" & "suspended=false", which is correct 
> because it was used to initiate a Downgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  b3bf345 
> 
> Diff: https://reviews.apache.org/r/45598/diff/
> 
> 
> Testing
> ---
> 
> Verified manually, waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 45696: AMBARI-15692 : AMS-HBase should explicitly set its HBASE_HOME path

2016-04-04 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45696/#review126896
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 (line 720)


Any changes to unit test ?


- Dmytro Sen


On Апрель 4, 2016, 6:38 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45696/
> ---
> 
> (Updated Апрель 4, 2016, 6:38 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15692
> https://issues.apache.org/jira/browse/AMBARI-15692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS-Collector host had the environment variable HBASE_HOME=/usr/lib/hbase 
> defined somewhere in the system. AMS user somehow inherited this environment 
> variable. When AMS-Collector started, he would start the embedded HBase which 
> would use the incorrect environment variable and failed to start 
> (/usr/lib/hbase was missing many JARs).
> 
> AMS-HBase's hbase-env.sh script should explicitly set the HBASE_HOME to its 
> own path and not fail due to some incorrect environment variable.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  f4a0b8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  378138b 
> 
> Diff: https://reviews.apache.org/r/45696/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on cluster where AMS co-existed with cluster HBase.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

2016-04-04 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review126892
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 4, 2016, 11:38 до полудня, Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated Квітень 4, 2016, 11:38 до полудня)
> 
> 
> Review request for Ambari, jun aoki and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Review Request 45692: AMBARI-15603 Exposure of Global Alert Repeat Tolerance Value in Web Client

2016-04-04 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45692/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, 
Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15603
https://issues.apache.org/jira/browse/AMBARI-15603


Repository: ambari


Description
---

The global repeat tolerance value for all alert definitions is set on the 
cluster-env configuration. Unless an alert definition overrides this value, it 
will be used for any definition in the system. By default, this value will be 
set to 1, indicating that there is no tolerance and the alert state should be 
taken at face value.

GET api/v1/clusters//configurations?type=cluster-env=

  "Config": {
"cluster_name": "c1",
"stack_id": "HDP-2.4"
  },
  "properties": {
"command_retry_enabled": "true",
"command_retry_max_time_in_sec": "600",
...
"alerts_repeat_tolerance" : "1"
   ...
  }

The web client should expose a way to update the {{cluster-env}} to set this 
value. 

*UI Warning of Delayed Alerts*
When changing the value of the global of definition-specific repeat tolerance, 
a warning should be presented to the user to indicate that it will now take 
longer for the alert notifications to be sent. This is because notifications 
are delayed until the interval multiplied by the repeat tolerance is reached. 
Consider the case where the check against an alert happens every 5 minutes and 
the repeat tolerance is set to 5. It will be at least 25 minutes before any 
outbound notifications are dispatched. This warning can be on a per-alert 
definition basis as well as when setting the global value.


Diffs
-

  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
dc9f78c 
  ambari-web/app/messages.js 1b2a02f 
  ambari-web/app/styles/application.less a6b79ce 
  ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65 

Diff: https://reviews.apache.org/r/45692/diff/


Testing
---

Local ambari-web test passed.
25600 tests complete (23 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-04 Thread Juanjo Marron



> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py,
> >  line 114
> > 
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
> 
> Juanjo  Marron wrote:
> Maintained  for now in the new patch. Please, let me know if it needs to 
> be edited
> 
> Jayush Luniya wrote:
> @Juanjo. I didnt get a chance to look into this. For now lets leave these 
> feature as LZO itself and since your logic is correct go ahead with the 
> change. We can rename if required the feature to oozie_lzo or something like 
> that if this is Oozie specific.
> 
> Juanjo  Marron wrote:
> Thanks @Jayush.
> I did that and the new patch was uploaded and it is available to be 
> reviewed and committed
> 
> Jayush Luniya wrote:
> Yes, committed to trunk

Thanks!


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
---


On April 1, 2016, 5:31 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated April 1, 2016, 5:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  175b889 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  6169699 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd3fbde 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-04 Thread Jayush Luniya



> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py,
> >  line 114
> > 
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
> 
> Juanjo  Marron wrote:
> Maintained  for now in the new patch. Please, let me know if it needs to 
> be edited
> 
> Jayush Luniya wrote:
> @Juanjo. I didnt get a chance to look into this. For now lets leave these 
> feature as LZO itself and since your logic is correct go ahead with the 
> change. We can rename if required the feature to oozie_lzo or something like 
> that if this is Oozie specific.
> 
> Juanjo  Marron wrote:
> Thanks @Jayush.
> I did that and the new patch was uploaded and it is available to be 
> reviewed and committed

Yes, committed to trunk


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
---


On April 1, 2016, 5:31 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated April 1, 2016, 5:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  175b889 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  6169699 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd3fbde 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-04 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126863
---


Ship it!




Ship It!

- Jayush Luniya


On April 1, 2016, 5:31 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated April 1, 2016, 5:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  175b889 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  6169699 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd3fbde 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-04 Thread Jayush Luniya



> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py,
> >  line 114
> > 
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
> 
> Juanjo  Marron wrote:
> Maintained  for now in the new patch. Please, let me know if it needs to 
> be edited

@Juanjo. I didnt get a chance to look into this. For now lets leave these 
feature as LZO itself and since your logic is correct go ahead with the change. 
We can rename if required the feature to oozie_lzo or something like that if 
this is Oozie specific.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
---


On April 1, 2016, 5:31 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated April 1, 2016, 5:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  175b889 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  6169699 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd3fbde 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45686: Alert Dispatch Scheduling Changes to Support Repeat Tolerance

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45686/
---

(Updated April 4, 2016, 11:49 a.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
Luniya, and Nate Cole.


Bugs: AMBARI-15686
https://issues.apache.org/jira/browse/AMBARI-15686


Repository: ambari


Description
---

When an alert state change is received, its notification will no longer be 
queued for immediate delivery if the firmness of the alert is SOFT. Instead, 
notifications will only be created and queued for delivery if the alert 
firmness is HARD in order to prevent false positives on alerts which have 
repeat tolerance enabled. 

Changes Included in this task:
- Database changes to support HARD/SOFT states to complement repeat occurrence 
values
```
CREATE TABLE alert_current (
  ...
  occurrences BIGINT NOT NULL DEFAULT 1,
  firmness VARCHAR(255) NOT NULL DEFAULT 'HARD',
  ...
);
```

- Changes to eventing system to handle alert state changes difference depending 
on whether the alerts are HARD/SOFT
- HARD/SOFT Calculations
-- If an alert is {{AlertState#OK}}, then the firmness is always 
{{AlertFirmness#HARD}}
-- If an alert is {{link SourceType#AGGREGATE}}, then the firmness is always 
{{link AlertFirmness#HARD}}.
-- Otherwise, the firmness will be {@link AlertFirmness#SOFT} unless the repeat 
tolerance has been met.

- Exposure of HARD/SOFT alert states
```
GET api/v1/clusters/c1/alerts/1
{
  "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1;,
  "Alert": {
"cluster_name": "c1",
...
"repeat_tolerance": 1,
"repeat_tolerance_remaining": 0,
"occurrences": 8,
"firmness": "HARD"

```


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 5a985d6 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertStateChangeEvent.java
 60dbec4 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java
 0bcfa2f 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 fbd5c12 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
 08563e3 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
 31f2154 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java f91d372 
  ambari-server/src/main/java/org/apache/ambari/server/state/AlertFirmness.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 f4a0b8c 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2fb2195 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 6a3712e 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 964941f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 366bbeb 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
f7e7262 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bdb6843 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c6df84a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
 29969d6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
 7d6c691 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
 e42e1a7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
 3ddeb2a 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 3723ff8 

Diff: https://reviews.apache.org/r/45686/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 45686: Alert Dispatch Scheduling Changes to Support Repeat Tolerance

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45686/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush 
Luniya, and Nate Cole.


Bugs: AMBARI-15686
https://issues.apache.org/jira/browse/AMBARI-15686


Repository: ambari


Description
---

When an alert state change is received, its notification will no longer be 
queued for immediate delivery if the firmness of the alert is SOFT. Instead, 
notifications will only be created and queued for delivery if the alert 
firmness is HARD in order to prevent false positives on alerts which have 
repeat tolerance enabled. 

Changes Included in this task:
- Database changes to support HARD/SOFT states to complement repeat occurrence 
values
```
CREATE TABLE alert_current (
  ...
  occurrences BIGINT NOT NULL DEFAULT 1,
  firmness VARCHAR(255) NOT NULL DEFAULT 'HARD',
  ...
);
```

- Changes to eventing system to handle alert state changes difference depending 
on whether the alerts are HARD/SOFT
- HARD/SOFT Calculations
-- If an alert is {{AlertState#OK}}, then the firmness is always 
{{AlertFirmness#HARD}}
-- If an alert is {{link SourceType#AGGREGATE}}, then the firmness is always 
{{link AlertFirmness#HARD}}.
-- Otherwise, the firmness will be {@link AlertFirmness#SOFT} unless the repeat 
tolerance has been met.

- Exposure of HARD/SOFT alert states
```
GET api/v1/clusters/c1/alerts/1
{
  "href": "http://localhost:8080/api/v1/clusters/c1/alerts/1;,
  "Alert": {
"cluster_name": "c1",
...
"repeat_tolerance": 1,
"repeat_tolerance_remaining": 0,
"occurrences": 8,
"firmness": "HARD"

```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 5a985d6 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertStateChangeEvent.java
 60dbec4 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java
 0bcfa2f 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 fbd5c12 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
 08563e3 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
 31f2154 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java f91d372 
  ambari-server/src/main/java/org/apache/ambari/server/state/AlertFirmness.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 46aa152 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2fb2195 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 6a3712e 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 964941f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 366bbeb 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
f7e7262 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql bdb6843 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c6df84a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
 29969d6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
 7d6c691 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
 e42e1a7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
 3ddeb2a 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 3723ff8 

Diff: https://reviews.apache.org/r/45686/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-04 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45538/#review126826
---




ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 (line 835)


It look slike this method and the one above can access this cache 
concurrently; you might need to make this Map threadsafe. 

Also, it's an interesting approach to clearing this cache. Component 
removals are not very often and I think the original point of clearing the 
cache was just to ensure it didn't stick around forever.

You brought up good points that the cache only was mapping a Long to an 
Enum; maybe a simple expiring cache would have been simpler/safer/better here.



ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AbstractBaseEventCreator.java
 (line 28)


I'm actually a fan of composition over inheritance. If these methods truly 
are part of a common logic for all Creators, then we can keep it. But would it 
be better to simply have a class which can perform these operations and merely 
reference it from all of the RequestAuditEventCreator instances? I don't see 
any shared state in this class, which is why I ask.


- Jonathan Hurley


On April 4, 2016, 4:24 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45538/
> ---
> 
> (Updated April 4, 2016, 4:24 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15646
> https://issues.apache.org/jira/browse/AMBARI-15646
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ThreadLocal:
> InitialValue() method is used when initializing the ThreadLocal member 
> variable.
> 
> Multibinder:
> The same logic is used for binding multiple classes from a package 
> "automatically" as in org.apache.ambari.server.cleanup.CleanupModule.
> 
> Creator properties:
> Property retrieval from responses now grouped into an abstract baseclass. It 
> can get properties from namedPropertySets and propertySets.
> 
> Auditlog enabling:
> Added checks to more places in the code to skip auditlog related object 
> creation if auditlog is disabled.
> 
> Cache:
> The previously existing 3 variables now groupped into a single data structure 
> to act as a cache. Every request has a RequestDetails object, which contains 
> the last status of the request and a map for tasks. A task has a key that is 
> composed of a component name and a host name, the value is the previous 
> status of the task.
> By using this structure, tasks for components can easily be removed and if 
> the RequestDetails has no task, the request itself can also be removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  79d3470 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  2e5b920 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/LogoutService.java
>  3b449ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java
>  1cfb740 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
>  b20714b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditEventCreator.java
>  ccb39de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditLoggerImpl.java
>  56efd18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AbstractBaseEventCreator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertGroupEventCreator.java
>  103fd4d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertTargetEventCreator.java
>  29a241e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintEventCreator.java
>  bdd6dbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintExportEventCreator.java
>  1416021 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ComponentEventCreator.java
>  8034d24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java
>  7e58893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/CredentialEventCreator.java
>  3b1f462 
>   
>

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-04 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45538/#review126823
---




ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 (line 137)


I think access to 'auditLogRequestCache' has to be made thread safe to 
cover edges cases where one component deployed to multiple hosts (A, B and C) 
might be receiving updates from host A and B while the component is being 
removed from host C.



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 (line 994)


You could use the EqualsVerifier library to ensure with a unit test that 
none breaks the equals() and hashcode() implementation inadvertently.



ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 (line 127)


If requestBodySet is not empty than the last 'result' will be logged twice 
as the while loop above will log it as well.



ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AbstractBaseEventCreator.java
 (line 28)


Documenr the purpose of this class.


- Sebastian Toader


On April 4, 2016, 10:24 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45538/
> ---
> 
> (Updated April 4, 2016, 10:24 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15646
> https://issues.apache.org/jira/browse/AMBARI-15646
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ThreadLocal:
> InitialValue() method is used when initializing the ThreadLocal member 
> variable.
> 
> Multibinder:
> The same logic is used for binding multiple classes from a package 
> "automatically" as in org.apache.ambari.server.cleanup.CleanupModule.
> 
> Creator properties:
> Property retrieval from responses now grouped into an abstract baseclass. It 
> can get properties from namedPropertySets and propertySets.
> 
> Auditlog enabling:
> Added checks to more places in the code to skip auditlog related object 
> creation if auditlog is disabled.
> 
> Cache:
> The previously existing 3 variables now groupped into a single data structure 
> to act as a cache. Every request has a RequestDetails object, which contains 
> the last status of the request and a map for tasks. A task has a key that is 
> composed of a component name and a host name, the value is the previous 
> status of the task.
> By using this structure, tasks for components can easily be removed and if 
> the RequestDetails has no task, the request itself can also be removed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  79d3470 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  2e5b920 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/LogoutService.java
>  3b449ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java
>  1cfb740 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
>  b20714b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditEventCreator.java
>  ccb39de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditLoggerImpl.java
>  56efd18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AbstractBaseEventCreator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertGroupEventCreator.java
>  103fd4d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertTargetEventCreator.java
>  29a241e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintEventCreator.java
>  bdd6dbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintExportEventCreator.java
>  1416021 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ComponentEventCreator.java
>  8034d24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java
>  7e58893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/CredentialEventCreator.java
>  3b1f462 
>   
>

Re: Review Request 45677: Provide more intuitive error message when unable to change Ambari server pid or log dirs

2016-04-04 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45677/
---

(Updated April 4, 2016, 12:19 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15684
https://issues.apache.org/jira/browse/AMBARI-15684


Repository: ambari


Description
---

I am unable to change the Ambari Server log and pid directory and the error is
not very intuitive.

1\. Ran ambari server setup  
2\. changed ambari server daemon to ambaritest (from root)  
3\. edited the files to change log and pid  
4\. Not working. Might be related to #2. Need to confirm changing log and/or
pid working in all paths: root, non-root, after setup, after
setup->start->stop, etc.

vi /etc/ambari-server/conf/ambari.properties  
pid.dir=/tmp/run/ambari-server




[root@c6402 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
 Make sure that you include only one javax.servlet.jsp.jstl.jar in the java 
class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
Server PID at: /tmp/run/ambari-server/ambari-server.pid
Server out at: /tmp/log/ambari-server/ambari-server.out
Server log at: /tmp/log/ambari-server/ambari-server.log
Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
No such file or directory
sh: /tmp/run/ambari-server/ambari-server.exitcode: Permission denied
.
ERROR: Exiting with exit code -1. 
REASON: Ambari Server java process died with exitcode -1. Check 
/tmp/log/ambari-server/ambari-server.out for more information.
[root@c6402 ~]# 


vi /etc/ambari-server/conf/log4j.properties  
ambari.log.dir=$

{ambari.root.dir}

/var/log/ambari-server




[root@c6402 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
 Make sure that you include only one javax.servlet.jsp.jstl.jar in the java 
class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /tmp/log/ambari-server/ambari-server.out
Server log at: /tmp/log/ambari-server/ambari-server.log
Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
No such file or directory
.
ERROR: Exiting with exit code -1. 
REASON: Ambari Server java process died with exitcode 1. Check 
/tmp/log/ambari-server/ambari-server.out for more information.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 54db372 
  ambari-server/src/test/python/TestAmbariServer.py 091869f 
  ambari-server/src/test/python/TestOSCheck.py 1be783e 
  ambari-server/src/test/python/TestServerClassPath.py fc66e7c 
  ambari-server/src/test/python/TestServerUpgrade.py 04ec337 
  ambari-server/src/test/python/TestServerUtils.py c34bba5 

Diff: https://reviews.apache.org/r/45677/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 45677: Provide more intuitive error message when unable to change Ambari server pid or log dirs

2016-04-04 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45677/#review126817
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 4, 2016, 12:12 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45677/
> ---
> 
> (Updated Квітень 4, 2016, 12:12 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15684
> https://issues.apache.org/jira/browse/AMBARI-15684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I am unable to change the Ambari Server log and pid directory and the error is
> not very intuitive.
> 
> 1\. Ran ambari server setup  
> 2\. changed ambari server daemon to ambaritest (from root)  
> 3\. edited the files to change log and pid  
> 4\. Not working. Might be related to #2. Need to confirm changing log and/or
> pid working in all paths: root, non-root, after setup, after
> setup->start->stop, etc.
> 
> vi /etc/ambari-server/conf/ambari.properties  
> pid.dir=/tmp/run/ambari-server
> 
> 
> 
> 
> [root@c6402 ~]# ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
> class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
> /usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
>  Make sure that you include only one javax.servlet.jsp.jstl.jar in the 
> java class path 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
> Server PID at: /tmp/run/ambari-server/ambari-server.pid
> Server out at: /tmp/log/ambari-server/ambari-server.out
> Server log at: /tmp/log/ambari-server/ambari-server.log
> Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
> No such file or directory
> sh: /tmp/run/ambari-server/ambari-server.exitcode: Permission denied
> .
> ERROR: Exiting with exit code -1. 
> REASON: Ambari Server java process died with exitcode -1. Check 
> /tmp/log/ambari-server/ambari-server.out for more information.
> [root@c6402 ~]# 
> 
> 
> vi /etc/ambari-server/conf/log4j.properties  
> ambari.log.dir=$
> 
> {ambari.root.dir}
> 
> /var/log/ambari-server
> 
> 
> 
> 
> [root@c6402 ~]# ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
> class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
> /usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
>  Make sure that you include only one javax.servlet.jsp.jstl.jar in the 
> java class path 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /tmp/log/ambari-server/ambari-server.out
> Server log at: /tmp/log/ambari-server/ambari-server.log
> Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
> No such file or directory
> .
> ERROR: Exiting with exit code -1. 
> REASON: Ambari Server java process died with exitcode 1. Check 
> /tmp/log/ambari-server/ambari-server.out for more information.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 2d49b9a 
>   ambari-server/src/test/python/TestAmbariServer.py ac24f7d 
>   ambari-server/src/test/python/TestOSCheck.py 1be783e 
>   ambari-server/src/test/python/TestServerClassPath.py fc66e7c 
>   ambari-server/src/test/python/TestServerUpgrade.py 04ec337 
>   ambari-server/src/test/python/TestServerUtils.py c34bba5 
> 
> Diff: https://reviews.apache.org/r/45677/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 45677: Provide more intuitive error message when unable to change Ambari server pid or log dirs

2016-04-04 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45677/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15684
https://issues.apache.org/jira/browse/AMBARI-15684


Repository: ambari


Description
---

I am unable to change the Ambari Server log and pid directory and the error is
not very intuitive.

1\. Ran ambari server setup  
2\. changed ambari server daemon to ambaritest (from root)  
3\. edited the files to change log and pid  
4\. Not working. Might be related to #2. Need to confirm changing log and/or
pid working in all paths: root, non-root, after setup, after
setup->start->stop, etc.

vi /etc/ambari-server/conf/ambari.properties  
pid.dir=/tmp/run/ambari-server




[root@c6402 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
 Make sure that you include only one javax.servlet.jsp.jstl.jar in the java 
class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
Server PID at: /tmp/run/ambari-server/ambari-server.pid
Server out at: /tmp/log/ambari-server/ambari-server.out
Server log at: /tmp/log/ambari-server/ambari-server.log
Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
No such file or directory
sh: /tmp/run/ambari-server/ambari-server.exitcode: Permission denied
.
ERROR: Exiting with exit code -1. 
REASON: Ambari Server java process died with exitcode -1. Check 
/tmp/log/ambari-server/ambari-server.out for more information.
[root@c6402 ~]# 


vi /etc/ambari-server/conf/log4j.properties  
ambari.log.dir=$

{ambari.root.dir}

/var/log/ambari-server




[root@c6402 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
 Make sure that you include only one javax.servlet.jsp.jstl.jar in the java 
class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /tmp/log/ambari-server/ambari-server.out
Server log at: /tmp/log/ambari-server/ambari-server.log
Waiting for server startsh: /tmp/log/ambari-server/ambari-server.out: 
No such file or directory
.
ERROR: Exiting with exit code -1. 
REASON: Ambari Server java process died with exitcode 1. Check 
/tmp/log/ambari-server/ambari-server.out for more information.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py 2d49b9a 
  ambari-server/src/test/python/TestAmbariServer.py ac24f7d 
  ambari-server/src/test/python/TestOSCheck.py 1be783e 
  ambari-server/src/test/python/TestServerClassPath.py fc66e7c 
  ambari-server/src/test/python/TestServerUpgrade.py 04ec337 
  ambari-server/src/test/python/TestServerUtils.py c34bba5 

Diff: https://reviews.apache.org/r/45677/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 45618: Log streaming disabled in Oozie

2016-04-04 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45618/
---

(Updated Квітень 4, 2016, 11:56 до полудня)


Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sumit Mohanty.


Bugs: AMBARI-15676
https://issues.apache.org/jira/browse/AMBARI-15676


Repository: ambari


Description
---

When I execute the oozie log command in the latest builds it is showing as "Log 
streaming disabled" .


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml
 b4518ce 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-log4j.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45618/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126813
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 76)


Commented code.


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126808
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 (line 27)


Intentation



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 (line 60)


Can use bunded conditional class names.



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 (line 33)


please correct the intentation.



contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
(line 28)


Better to off these listeners on willDestroy.


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-04 Thread Sreenath Somarajapuram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126795
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 (line 19)


Looks like you can delete this file.
Even if the file name is queueMappingParser.js, this is same as 
queueMappingInterpreter.js.
Also correct th require.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 142)


We souldnt have commented code.
The line can be removed if not required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 229)


All debug logs must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 241)


All debug logs must be removed.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 275)


Again remove comments.



contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 (line 887)


Intentation



contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 (line 28)


Whay are we having an anchor tags inside link-to? And what is the purpose 
fo href="view.href".


- Sreenath Somarajapuram


On March 11, 2016, 10:41 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated March 11, 2016, 10:41 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingInterpreter.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
>

Re: Review Request 45538: Audit Log Code Cleanup & Safety

2016-04-04 Thread Daniel Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45538/
---

(Updated ápr. 4, 2016, 8:24 de)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-15646
https://issues.apache.org/jira/browse/AMBARI-15646


Repository: ambari


Description (updated)
---

ThreadLocal:
InitialValue() method is used when initializing the ThreadLocal member variable.

Multibinder:
The same logic is used for binding multiple classes from a package 
"automatically" as in org.apache.ambari.server.cleanup.CleanupModule.

Creator properties:
Property retrieval from responses now grouped into an abstract baseclass. It 
can get properties from namedPropertySets and propertySets.

Auditlog enabling:
Added checks to more places in the code to skip auditlog related object 
creation if auditlog is disabled.

Cache:
The previously existing 3 variables now groupped into a single data structure 
to act as a cache. Every request has a RequestDetails object, which contains 
the last status of the request and a map for tasks. A task has a key that is 
composed of a component name and a host name, the value is the previous status 
of the task.
By using this structure, tasks for components can easily be removed and if the 
RequestDetails has no task, the request itself can also be removed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 79d3470 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 2e5b920 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/LogoutService.java
 3b449ca 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerDefaultImpl.java
 1cfb740 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java
 b20714b 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditEventCreator.java
 ccb39de 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/RequestAuditLoggerImpl.java
 56efd18 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AbstractBaseEventCreator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertGroupEventCreator.java
 103fd4d 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/AlertTargetEventCreator.java
 29a241e 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintEventCreator.java
 bdd6dbe 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/BlueprintExportEventCreator.java
 1416021 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ComponentEventCreator.java
 8034d24 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java
 7e58893 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/CredentialEventCreator.java
 3b1f462 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/DefaultEventCreator.java
 d0f57f2 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/GroupEventCreator.java
 d926d94 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java
 910280d 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/MemberEventCreator.java
 a3c3164 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java
 bdc7b59 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RecommendationIgnoreEventCreator.java
 6b7bb2b 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryEventCreator.java
 fe6f8cc 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java
 7c9c731 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 fd13973 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ServiceConfigDownloadEventCreator.java
 681cfb8 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ServiceEventCreator.java
 2e2b91d 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UnauthorizedEventCreator.java
 d53aa68 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UpgradeEventCreator.java
 b8a6873

49 matches

Mail list logo